Re: Confusing entity names

Thanks everyone for all your inputs. Seems that there is no common conclusion derived for this change. I will hold/discard the ticket created for this soon. -- Thanks and Regards, *Suraj Khurana* | Sr. Enterprise Software Engineer HotWax Commerce by HotWax Systems Plot no. 80, Scheme no. 78,

Re: Confusing entity names

+1 Scott. I'm also not in favor of changing the names. Suraj suggested better names but existing are also fine. Another point is OrderItemShipGrpInvRes have relation with both the mentioned entities. Which tells by modeling that, one OISG may have more than one OISGIR which may in turn have

Re: Confusing entity names

Just to throw in my 2 cents, I don't think the naming is so confusing that it warrants changing. The number of replies in this thread highlights that it isn't a straightforward thing to change, and personally I don't think the names are so bad that it's worth any of the pain that might come from

RE: Confusing entity names

[mailto:mallah.raj...@gmail.com] Sent: 17 April 2018 3:29 PM To: dev@ofbiz.apache.org Subject: Re: Confusing entity names I feel this approach ( deprecated=”true” ) gives breathing space for stakeholders to absorb changes at their own pace. And its not unique here , most reputable softwares takes this path

Re: Confusing entity names

o: dev@ofbiz.apache.org Subject: Re: Confusing entity names Hi Gareth, Yes, this is how it's supposed to be handled in OFBiz from start, see my answer to Mathieu Lirzin in this thread: https://markmail.org/message/wypy4tuhyyv5bugw<https://markma il.org/message/wypy4tuhyyv5bugw> Jacques Le 17/

Re: Confusing entity names

> >>> This would certainly cause havoc for us! So I would propose not to >>> change them! >>> >>> I certainly do agree the names do not make sense so rather than rename, >>> could a new type of entity be created that can reference existing entities? >&

Re: Confusing entity names

;> Software Development Analyst >> >> >> Stannah Management Services Ltd >> >> >> IT Department >> >> >> Ext: >> >> >> 7036 >> >> >> DDI: >> >> >> 01264 364311 >> >> >> >&

Re: Confusing entity names

] Sent: 17 April 2018 11:21 AM To: dev@ofbiz.apache.org Subject: Re: Confusing entity names Hi Gareth, Yes, this is how it's supposed to be handled in OFBiz from start, see my answer to Mathieu Lirzin in this thread: https://markmail.org/message/wypy4tuhyyv5bugw<https://markmail.org/mess

RE: Confusing entity names

2018 11:21 AM To: dev@ofbiz.apache.org Subject: Re: Confusing entity names Hi Gareth, Yes, this is how it's supposed to be handled in OFBiz from start, see my answer to Mathieu Lirzin in this thread: https://markmail.org/message/wypy4tuhyyv5bugw<https://markmail.org/message/wypy4tuhyyv5b

Re: Confusing entity names

Management Services Ltd IT Department Ext: 7036 DDI: 01264 364311 Please consider the environment before printing this email. -Original Message- From: Rajesh Mallah [mailto:mallah.raj...@gmail.com] Sent: 12 April 2018 2:47 PM To: dev@ofbiz.apache.org Subject: Re: Confusing entity names -1

RE: Confusing entity names

To: dev@ofbiz.apache.org Subject: Re: Confusing entity names -1 is it really worth taking the risk , renaming generally wrecks havoc! specially considering OFBiz which have 100's of entities and dozens named similarly. however i agree with the proposer that they are not named properly. secondly

Re: Confusing entity names

Le 15/04/2018 à 14:30, Mathieu Lirzin a écrit : Jacques Le Roux writes: Let me clarify my position. I'm not strictly against this change. I don't fear a such OOTB change, after all it's only name change, isn't ? And what you mentioned below Suraj is the right

Re: Confusing entity names

Jacques Le Roux writes: > Let me clarify my position. I'm not strictly against this change. I > don't fear a such OOTB change, after all it's only name change, isn't > ? And what you mentioned below Suraj is the right way to go. Obviously > the concern is for custom

Re: Confusing entity names

Hi all, I like the all or nothing (yet) proposal (thanks Taher btw :) ), since it offers a way to communicate around this big change and a way to migrate existing implementation. It's an optimum choice for this kind of refactoring, but it will need more effort to deliver it. So now we'll need

Re: Confusing entity names

Let me clarify my position. I'm not strictly against this change. I don't fear a such OOTB change, after all it's only name change, isn't ? And what you mentioned below Suraj is the right way to go. Obviously the concern is for custom projects. Though I'm not directly concerned (I have no

Re: Confusing entity names

I wonder, should it be really all or nothing? Will it not add more concerns and difficulties to deliver a such big package? Should we wait for that to happen, and how long? Jacques Le 15/04/2018 à 02:55, innate Genius a écrit : +1 Taher On 14-Apr-2018, at 12:40 PM, Taher Alkhateeb

Re: Confusing entity names

+1 Taher > On 14-Apr-2018, at 12:40 PM, Taher Alkhateeb > wrote: > > Hi Everyone, > > Thinking some more about the concerns from multiple people in this thread > like Michael, Rajesh, Gil and others I have a different suggestion. > > Why not make a sweeping review

Re: Confusing entity names

Hi Everyone, Thinking some more about the concerns from multiple people in this thread like Michael, Rajesh, Gil and others I have a different suggestion. Why not make a sweeping review of the full domain model, and then decide on one comprehensive change, with even a migration script that we

Re: Confusing entity names

Suraj, I still do not see much value in this change, compared to the effort needed for development and testing as well as the migration the users have to do. Please consider to not do this change. Thanks, Michael Am 13.04.18 um 10:09 schrieb Suraj Khurana: Thanks everyone for your

Re: Confusing entity names

Hi Suraj, Did you get a chance to check if these entities are covered by tests somehow? Thanks Jacques Le 13/04/2018 à 10:09, Suraj Khurana a écrit : Thanks everyone for your thoughts. One more point is we also manage Data Migration By release document so it will help existing uses. Such

Re: Confusing entity names

Thanks everyone for your thoughts. One more point is we also manage Data Migration By release document so it will help existing uses. Such as https://cwiki.apache.org/confl uence/display/OFBIZ/Data+Migration+by+releases

Re: Confusing entity names

Hi On 10/04/2018 13:24, Suraj Khurana wrote: Hello, There are some entities which could be renamed as per their usage. - *OrderItemShipGroup*: It shows order ship groups and it doesn't contain anything at order item level. So, it could be re-named as *OrderShipGroup.* -

Re: Confusing entity names

Hi All, Got the same feeling as Michael... Thanks, Gil On 12/04/2018 14:48, Michael Brohl wrote: Hi Suraj, thanks for your proposal. Looking at it in isolation, it seems a good idea to just rename these entities. Having the users in mind, I'm not sure if this is worth the need for

Re: Confusing entity names

+1 Suraj Vaibhav Jain Sr. Enterprise Software Engineer HotWax Systems m: 782-834-1900 e: vaibhav.j...@hotwaxsystems.com On Fri, Apr 13, 2018 at 10:32 AM, Swapnil Mane < swapnil.m...@hotwaxsystems.com> wrote: > +1 > > We maintain the document for users to upgrade

Re: Confusing entity names

+1 We maintain the document for users to upgrade the revision. https://cwiki.apache.org/confluence/display/OFBIZ/Revisions+Requiring+Data+Migration+-+upgrade+ofbiz So, IMO we can proceed with this change. - Best Regards, Swapnil M Mane www.hotwaxsystems.com On Tue, Apr 10, 2018 at 4:54 PM,

Re: Confusing entity names

Premature optimization is something totally different :) But I understand your point. On Thu, Apr 12, 2018 at 4:51 PM, Jacques Le Roux wrote: > I agree (Premature Optimisation...), but let's see what others have to > say... > > Jacques > > > > Le 12/04/2018 à 15:47,

Re: Confusing entity names

I agree (Premature Optimisation...), but let's see what others have to say... Jacques Le 12/04/2018 à 15:47, Rajesh Mallah a écrit : -1 is it really worth taking the risk , renaming generally wrecks havoc! specially considering OFBiz which have 100's of entities and dozens named similarly.

Re: Confusing entity names

-1 is it really worth taking the risk , renaming generally wrecks havoc! specially considering OFBiz which have 100's of entities and dozens named similarly. however i agree with the proposer that they are not named properly. secondly , Is the current state of test suites or integration checks

Re: Confusing entity names

Hi Suraj, thanks for your proposal. Looking at it in isolation, it seems a good idea to just rename these entities. Having the users in mind, I'm not sure if this is worth the need for data migrations they have to do if they want to stay up-to-date. I'm not sure where the original names

Re: Confusing entity names

+1 Suraj for this improvement. And my vote is more inclined with the name suggested by Arun here. Thanks & Regards, Devanshu Vyas. On Thu, Apr 12, 2018 at 2:27 PM, Arun Patidar < arun.pati...@hotwaxsystems.com> wrote: > +1 Suraj for the improvement. Please see my comments inline: > > > On

Re: Confusing entity names

Hi Suraj, May I recommend giving this conversation some room for others to contribute their opinion before taking an action (even though I agree with it). A few more days won't hurt to make sure people are okay with the idea. On Thu, Apr 12, 2018 at 2:07 PM, Suraj Khurana

Re: Confusing entity names

Thanks everyone for your thoughts and inputs. Here is the ticket created for the same. -- Thanks and Regards, *Suraj Khurana* | Omni-channel OMS Technical Expert *HotWax Commerce* by *HotWax Systems* Plot no. 80, Scheme no. 78, Vijay Nagar,

Re: Confusing entity names

+1 Suraj for the improvement. Please see my comments inline: On Tue, Apr 10, 2018 at 4:54 PM, Suraj Khurana < suraj.khur...@hotwaxsystems.com> wrote: > Hello, > > There are some entities which could be renamed as per their usage. > >- *OrderItemShipGroup*: It shows order ship groups and it

Re: Confusing entity names

+1 Thanks and Regards -- Akash Jain On Tue, Apr 10, 2018 at 4:54 PM, Suraj Khurana < suraj.khur...@hotwaxsystems.com> wrote: > Hello, > > There are some entities which could be renamed as per their usage. > >- *OrderItemShipGroup*: It shows order ship groups and it doesn't >contain

Re: Confusing entity names

+1 Thanks and Regards -- Pritam Kute On Thu, Apr 12, 2018 at 1:13 PM, Taher Alkhateeb wrote: > I think by now some people might think my last name is "Refactoring" > :) But I always welcome improvements. However, such a change needs to > be carefully done and

Re: Confusing entity names

I think by now some people might think my last name is "Refactoring" :) But I always welcome improvements. However, such a change needs to be carefully done and reviewed and we should ensure that all relevant artifacts are updated accordingly (widgets, services, scripts, etc ...) +1 On Tue, Apr

Confusing entity names

Hello, There are some entities which could be renamed as per their usage. - *OrderItemShipGroup*: It shows order ship groups and it doesn't contain anything at order item level. So, it could be re-named as *OrderShipGroup.* - *OrderItemShipGroupAssoc: *It do not maintain any