teeb [mailto:slidingfilame...@gmail.com]
>> 发送时间: 2018年7月3日 15:09
>> 收件人: OFBIZ Development Mailing List
>> 主题: Re: [Discussion]: Add method attribute to request-map (Was: svn
>> commit: r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
>>
>> Thank you Shi. I
日 23:59
收件人: dev@ofbiz.apache.org
主题: Re: [Discussion]: Add method attribute to request-map (Was: svn
commit: r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
+1 to Taher's recommendations.
Jacopo
On Thu, Jun 28, 2018 at 9:15 AM, Taher Alkhateeb <
slidingfilame...@gmail.com
wr
: [Discussion]: Add method attribute to request-map (Was: svn commit:
r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
That is not a constructive thing to say in my opinion. Sounds to me like:
hey I don't like reverting, but I know this code is good and now that I
reverted I don't care
> > 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com]
> > 发送时间: 2018年6月28日 23:59
> > 收件人: dev@ofbiz.apache.org
> > 主题: Re: [Discussion]: Add method attribute to request-map (Was: svn
> commit: r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...
ble code I needed :)
>
>
> -邮件原件-
> 发件人: Taher Alkhateeb [mailto:slidingfilame...@gmail.com]
> 发送时间: 2018年7月3日 15:09
> 收件人: OFBIZ Development Mailing List
> 主题: Re: [Discussion]: Add method attribute to request-map (Was: svn
> commit: r1834389 - in /ofbiz/ofbi
---
> >> 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com]
> >> 发送时间: 2018年6月28日 23:59
> >> 收件人: dev@ofbiz.apache.org
> >> 主题: Re: [Discussion]: Add method attribute to request-map (Was: svn
> commit: r1834389 - in /ofbiz/ofbiz-framework/trunk
-
发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com]
发送时间: 2018年6月28日 23:59
收件人: dev@ofbiz.apache.org
主题: Re: [Discussion]: Add method attribute to request-map (Was: svn commit:
r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
+1 to Taher's recommendations.
Jacopo
; 主题: Re: [Discussion]: Add method attribute to request-map (Was: svn commit:
> r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
>
> +1 to Taher's recommendations.
>
> Jacopo
>
> On Thu, Jun 28, 2018 at 9:15 AM, Taher Alkhateeb > wrote:
>
>> A few comments:
&
Add method attribute to request-map (Was: svn commit:
> r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
>
> +1 to Taher's recommendations.
>
> Jacopo
>
> On Thu, Jun 28, 2018 at 9:15 AM, Taher Alkhateeb > wrote:
>
>> A few comments:
>>
>> 1- I wou
Reverted in rev 1834917.
-邮件原件-
发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com]
发送时间: 2018年6月28日 23:59
收件人: dev@ofbiz.apache.org
主题: Re: [Discussion]: Add method attribute to request-map (Was: svn commit:
r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
+1
+1 to Taher's recommendations.
Jacopo
On Thu, Jun 28, 2018 at 9:15 AM, Taher Alkhateeb wrote:
> A few comments:
>
> 1- I would suggest to try and avoid in the future committing any
> design changes to the framework without discussing it properly in the
> mailing list first
> 2- I think it
+1 Taher
On Thu, Jun 28, 2018 at 2:01 PM Michael Brohl
wrote:
> A strong +1 to your recommendations.
>
> There were several commits in the OFBiz core recently which were not
> properly discussed before they were committed. We should avoid this.
>
> People should have in mind that other
A strong +1 to your recommendations.
There were several commits in the OFBiz core recently which were not
properly discussed before they were committed. We should avoid this.
People should have in mind that other committers might not have the time
to review, think and discuss these patches
A few comments:
1- I would suggest to try and avoid in the future committing any
design changes to the framework without discussing it properly in the
mailing list first
2- I think it would be better to revert this work. I noticed in the
JIRA for example that Mathieu Lirzin asked for some time to
Hi all,
Thanks Jacques, Taher and Nicolas mentioned our community rule, "a proper
discussion".
I created an issue "Add method attribute to request-map to controll a uri can
be called GET or POST only" a week ago:
https://issues.apache.org/jira/browse/OFBIZ-10438
Thanks Mathieu, he submitted
15 matches
Mail list logo
