shangxinli commented on pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-714828022
I just pushed more comments and squashed into one. This is ready for review
now.
This is an automated
shangxinli commented on a change in pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#discussion_r510460619
##
File path:
parquet-hadoop/src/test/java/org/apache/parquet/crypto/propertiesfactory/SchemaControlEncryptionTest.java
##
@@ -0,0 +1,248 @@
+/*
+ *
shangxinli commented on a change in pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#discussion_r510457820
##
File path:
parquet-hadoop/src/test/java/org/apache/parquet/crypto/propertiesfactory/SchemaControlEncryptionTest.java
##
@@ -0,0 +1,248 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/PARQUET-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219293#comment-17219293
]
Xinli Shang commented on PARQUET-1927:
--
[~gszadovszky], the problem is when rowCount is 0(line 966
[
https://issues.apache.org/jira/browse/PARQUET-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong resolved PARQUET-1932.
---
Resolution: Fixed
> Bump Fastutil to 8.4.2
> --
>
>
[
https://issues.apache.org/jira/browse/PARQUET-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong updated PARQUET-1932:
--
Affects Version/s: 1.11.0
> Bump Fastutil to 8.4.2
> --
>
>
[
https://issues.apache.org/jira/browse/PARQUET-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219234#comment-17219234
]
ASF GitHub Bot commented on PARQUET-1932:
-
Fokko merged pull request #836:
URL:
Fokko merged pull request #836:
URL: https://github.com/apache/parquet-mr/pull/836
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dossett commented on pull request #818:
URL: https://github.com/apache/parquet-mr/pull/818#issuecomment-714624897
That works too!
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/PARQUET-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong resolved PARQUET-1929.
---
Fix Version/s: 1.12.0
Resolution: Fixed
> Bump Snappy to 1.1.8
>
[
https://issues.apache.org/jira/browse/PARQUET-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219160#comment-17219160
]
ASF GitHub Bot commented on PARQUET-1929:
-
Fokko merged pull request #833:
URL:
Fokko merged pull request #833:
URL: https://github.com/apache/parquet-mr/pull/833
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/PARQUET-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong updated PARQUET-1929:
--
Affects Version/s: 1.11.0
> Bump Snappy to 1.1.8
>
>
>
[
https://issues.apache.org/jira/browse/PARQUET-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong resolved PARQUET-1931.
---
Fix Version/s: 1.12.0
Resolution: Fixed
> Bump Junit 4.13.1
>
[
https://issues.apache.org/jira/browse/PARQUET-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219158#comment-17219158
]
ASF GitHub Bot commented on PARQUET-1931:
-
Fokko merged pull request #835:
URL:
[
https://issues.apache.org/jira/browse/PARQUET-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong updated PARQUET-1931:
--
Affects Version/s: 1.11.0
> Bump Junit 4.13.1
> -
>
>
Fokko merged pull request #835:
URL: https://github.com/apache/parquet-mr/pull/835
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Fokko commented on pull request #818:
URL: https://github.com/apache/parquet-mr/pull/818#issuecomment-714619809
Thanks @dossett for letting us know. Master is now at Apache Thrift 0.13.0
(https://github.com/apache/parquet-mr/pull/834) which is available at Brew:
`brew install thrift@0.13`
Fokko closed pull request #818:
URL: https://github.com/apache/parquet-mr/pull/818
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/PARQUET-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong updated PARQUET-1930:
--
Summary: Bump Apache Thrift to 0.13.0 (was: Bump Apache Thrift to 0.13)
> Bump
[
https://issues.apache.org/jira/browse/PARQUET-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong reassigned PARQUET-1910:
-
Assignee: Grisha Weintraub
> Parquet-cli is broken after
Fokko merged pull request #834:
URL: https://github.com/apache/parquet-mr/pull/834
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/PARQUET-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong updated PARQUET-1930:
--
Affects Version/s: 1.11.0
> Bump Apache Thrift to 0.13
> --
[
https://issues.apache.org/jira/browse/PARQUET-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong resolved PARQUET-1930.
---
Resolution: Fixed
> Bump Apache Thrift to 0.13
> --
>
>
[
https://issues.apache.org/jira/browse/PARQUET-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219154#comment-17219154
]
ASF GitHub Bot commented on PARQUET-1930:
-
Fokko merged pull request #834:
URL:
[
https://issues.apache.org/jira/browse/PARQUET-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong updated PARQUET-1930:
--
Fix Version/s: 1.12.0
> Bump Apache Thrift to 0.13
> --
>
>
shangxinli commented on a change in pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#discussion_r510278202
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetWriter.java
##
@@ -279,6 +279,11 @@ public ParquetWriter(Path file,
Hi Gabor,
> It is still not clear to me if we want to recommend V2 for production use
> at all
Again, I'm missing context here, but what is blocking V2 for production
use? Is it specification finalization, implementation finalization?
Something else?
or simply introduce the new encodings for
[
https://issues.apache.org/jira/browse/PARQUET-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219114#comment-17219114
]
ASF GitHub Bot commented on PARQUET-1925:
-
belugabehr commented on pull request #828:
URL:
belugabehr commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-714581308
OK. I added a unit test. I don't love the test, but it's something (and
better than nothing). I'm also not sure how good of an example it will be for
future tests in
[
https://issues.apache.org/jira/browse/PARQUET-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219077#comment-17219077
]
ASF GitHub Bot commented on PARQUET-1917:
-
dossett commented on pull request #820:
URL:
[
https://issues.apache.org/jira/browse/PARQUET-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Szadovszky resolved PARQUET-1914.
---
Resolution: Fixed
> Allow ProtoParquetReader To Support InputFile
>
gszadovszky merged pull request #817:
URL: https://github.com/apache/parquet-mr/pull/817
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/PARQUET-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219076#comment-17219076
]
ASF GitHub Bot commented on PARQUET-1914:
-
gszadovszky merged pull request #817:
URL:
dossett commented on pull request #820:
URL: https://github.com/apache/parquet-mr/pull/820#issuecomment-714553061
Thank you both!
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/PARQUET-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Szadovszky resolved PARQUET-1917.
---
Resolution: Fixed
> [parquet-proto] default values are stored in oneOf fields that
[
https://issues.apache.org/jira/browse/PARQUET-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Szadovszky reassigned PARQUET-1917:
-
Assignee: Aaron Blake Niskode-Dossett
> [parquet-proto] default values are
[
https://issues.apache.org/jira/browse/PARQUET-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219074#comment-17219074
]
ASF GitHub Bot commented on PARQUET-1917:
-
gszadovszky merged pull request #820:
URL:
gszadovszky merged pull request #820:
URL: https://github.com/apache/parquet-mr/pull/820
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
belugabehr commented on pull request #820:
URL: https://github.com/apache/parquet-mr/pull/820#issuecomment-714550284
I looked at the unit test again, it's fine as-is. +1
Thanks.
This is an automated message from the
[
https://issues.apache.org/jira/browse/PARQUET-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219072#comment-17219072
]
ASF GitHub Bot commented on PARQUET-1917:
-
belugabehr commented on pull request #820:
URL:
[
https://issues.apache.org/jira/browse/PARQUET-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219067#comment-17219067
]
ASF GitHub Bot commented on PARQUET-1917:
-
gszadovszky commented on pull request #820:
URL:
gszadovszky commented on pull request #820:
URL: https://github.com/apache/parquet-mr/pull/820#issuecomment-714544732
@dossett, it looks good to me. Let me wait for @belugabehr's approval then
I'll approve and push this.
[
https://issues.apache.org/jira/browse/PARQUET-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219055#comment-17219055
]
ASF GitHub Bot commented on PARQUET-1918:
-
gszadovszky commented on pull request #822:
URL:
gszadovszky commented on pull request #822:
URL: https://github.com/apache/parquet-mr/pull/822#issuecomment-714533411
@belugabehr, what about blocking the jira with the thrift ticket so it is
clear why we cannot step forward?
Also, after fixing THRIFT-5288 we have to fix `Binary` as
[
https://issues.apache.org/jira/browse/PARQUET-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219049#comment-17219049
]
ASF GitHub Bot commented on PARQUET-1922:
-
gszadovszky commented on a change in pull request
gszadovszky commented on a change in pull request #825:
URL: https://github.com/apache/parquet-mr/pull/825#discussion_r510205081
##
File path:
parquet-column/src/main/java/org/apache/parquet/column/values/plain/PlainValuesWriter.java
##
@@ -127,7 +127,6 @@ public void reset()
gszadovszky merged pull request #807:
URL: https://github.com/apache/parquet-mr/pull/807
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/PARQUET-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Szadovszky resolved PARQUET-1893.
---
Resolution: Fixed
> H2SeekableInputStream readFully() doesn't respect start and
[
https://issues.apache.org/jira/browse/PARQUET-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219044#comment-17219044
]
ASF GitHub Bot commented on PARQUET-1893:
-
gszadovszky merged pull request #807:
URL:
[
https://issues.apache.org/jira/browse/PARQUET-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219039#comment-17219039
]
ASF GitHub Bot commented on PARQUET-1917:
-
dossett commented on pull request #820:
URL:
dossett commented on pull request #820:
URL: https://github.com/apache/parquet-mr/pull/820#issuecomment-714526665
@gszadovszky Tagging you on this PR per discussion in the dev list. If you
approve the change I will also clean up the new tests a bit per David's
comments. Thanks!
[
https://issues.apache.org/jira/browse/PARQUET-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219034#comment-17219034
]
ASF GitHub Bot commented on PARQUET-1925:
-
belugabehr commented on pull request #828:
URL:
[
https://issues.apache.org/jira/browse/PARQUET-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219035#comment-17219035
]
ASF GitHub Bot commented on PARQUET-1903:
-
gszadovszky commented on a change in pull request
gszadovszky commented on a change in pull request #813:
URL: https://github.com/apache/parquet-mr/pull/813#discussion_r510168205
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetReader.java
##
@@ -136,6 +136,7 @@ public T read() throws IOException {
belugabehr commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-714525290
> I like this very much. Would it be possible to have a test to check the
output of the template?
Great! I started working on some of the more complex templates, but
[
https://issues.apache.org/jira/browse/PARQUET-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219030#comment-17219030
]
ASF GitHub Bot commented on PARQUET-1918:
-
belugabehr edited a comment on pull request #822:
belugabehr edited a comment on pull request #822:
URL: https://github.com/apache/parquet-mr/pull/822#issuecomment-714521089
@gszadovszky Ya. I did discover that this is a bit more tricky than I had
anticipated. My expectation was that ByteBuffers were handled the same way as
there are
[
https://issues.apache.org/jira/browse/PARQUET-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219028#comment-17219028
]
ASF GitHub Bot commented on PARQUET-1918:
-
belugabehr commented on pull request #822:
URL:
belugabehr commented on pull request #822:
URL: https://github.com/apache/parquet-mr/pull/822#issuecomment-714521089
@gszadovszky Ya. I did discover that this is a bit more tricky than I had
anticipated. My expectation was this ByteBuffers were handled the same way as
there are defined
[
https://issues.apache.org/jira/browse/PARQUET-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219026#comment-17219026
]
ASF GitHub Bot commented on PARQUET-1922:
-
belugabehr commented on a change in pull request
belugabehr commented on a change in pull request #825:
URL: https://github.com/apache/parquet-mr/pull/825#discussion_r510189309
##
File path:
parquet-column/src/main/java/org/apache/parquet/column/values/plain/PlainValuesWriter.java
##
@@ -127,7 +127,6 @@ public void reset()
[
https://issues.apache.org/jira/browse/PARQUET-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219002#comment-17219002
]
ASF GitHub Bot commented on PARQUET-1914:
-
gszadovszky commented on a change in pull request
gszadovszky commented on a change in pull request #817:
URL: https://github.com/apache/parquet-mr/pull/817#discussion_r510154080
##
File path:
parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoParquetReader.java
##
@@ -56,7 +61,25 @@ public ProtoParquetReader(Path
[
https://issues.apache.org/jira/browse/PARQUET-1922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218997#comment-17218997
]
ASF GitHub Bot commented on PARQUET-1922:
-
gszadovszky commented on a change in pull request
gszadovszky commented on a change in pull request #825:
URL: https://github.com/apache/parquet-mr/pull/825#discussion_r510146819
##
File path:
parquet-column/src/main/java/org/apache/parquet/column/values/plain/PlainValuesWriter.java
##
@@ -127,7 +127,6 @@ public void reset()
[
https://issues.apache.org/jira/browse/PARQUET-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218980#comment-17218980
]
ASF GitHub Bot commented on PARQUET-1915:
-
gszadovszky commented on a change in pull request
gszadovszky commented on a change in pull request #819:
URL: https://github.com/apache/parquet-mr/pull/819#discussion_r510113275
##
File path:
parquet-cli/src/main/java/org/apache/parquet/cli/commands/ColumnMaskingCommand.java
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/PARQUET-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Szadovszky resolved PARQUET-1528.
---
Resolution: Fixed
> Add JSON support to `parquet-tools head`
>
[
https://issues.apache.org/jira/browse/PARQUET-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Szadovszky reassigned PARQUET-1528:
-
Assignee: Raphaël Afanyan
> Add JSON support to `parquet-tools head`
>
[
https://issues.apache.org/jira/browse/PARQUET-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218894#comment-17218894
]
ASF GitHub Bot commented on PARQUET-1528:
-
raph-af commented on pull request #829:
URL:
raph-af commented on pull request #829:
URL: https://github.com/apache/parquet-mr/pull/829#issuecomment-714358867
@gszadovszky ty for having a look ! I have an account, my username is
"Raphael Af"
This is an automated
It is still not clear to me if we want to recommend V2 for production use
at all or simply introduce the new encodings for V1. I would suggest
discussing this topic on the parquet sync next Tuesday.
On Thu, Oct 22, 2020 at 6:04 AM Micah Kornfield
wrote:
> I've created
[
https://issues.apache.org/jira/browse/PARQUET-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218860#comment-17218860
]
ASF GitHub Bot commented on PARQUET-1528:
-
gszadovszky merged pull request #829:
URL:
[
https://issues.apache.org/jira/browse/PARQUET-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218861#comment-17218861
]
ASF GitHub Bot commented on PARQUET-1528:
-
gszadovszky commented on pull request #829:
URL:
gszadovszky merged pull request #829:
URL: https://github.com/apache/parquet-mr/pull/829
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gszadovszky commented on pull request #829:
URL: https://github.com/apache/parquet-mr/pull/829#issuecomment-714322870
@raph-af, do you have a jira account so I can assign this one to you?
This is an automated message from
[
https://issues.apache.org/jira/browse/PARQUET-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218852#comment-17218852
]
ASF GitHub Bot commented on PARQUET-1930:
-
gszadovszky commented on a change in pull request
gszadovszky commented on a change in pull request #162:
URL: https://github.com/apache/parquet-format/pull/162#discussion_r509964168
##
File path: parquet-format.iml
##
@@ -0,0 +1,24 @@
+
Review comment:
Please, do not check in IDE files.
I'm afraid that is the main issue that we have no active committers who
have enough experience in protobuf. Meanwhile it is great that there are
more contributors who work on it so they can review each other's work.
So I would suggest cross reviewing your PRs first and if you got an
experienced
[
https://issues.apache.org/jira/browse/PARQUET-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218845#comment-17218845
]
Gabor Szadovszky commented on PARQUET-1927:
---
Rechecked the code again and found that
Gidon Gershinsky created PARQUET-1934:
-
Summary: Dictionary page is not decrypted in predicate pushdown
path
Key: PARQUET-1934
URL: https://issues.apache.org/jira/browse/PARQUET-1934
Project:
82 matches
Mail list logo