martin-g edited a comment on pull request #924:
URL: https://github.com/apache/parquet-mr/pull/924#issuecomment-900057808
With `-Dorg.slf4j.simpleLogger.logFile=mvn-verify.log` all the output is
redirected from stdout to a file.
TravisCI stops the job if there is no output for 10 minutes
YunLemon commented on pull request #924:
URL: https://github.com/apache/parquet-mr/pull/924#issuecomment-968429043
yes,
[https://app.travis-ci.com/github/apache/parquet-mr/jobs/541671084](https://app.travis-ci.com/github/apache/parquet-mr/jobs/541671084),
I think this build can explain wha
mixermt commented on pull request #754:
URL: https://github.com/apache/parquet-mr/pull/754#issuecomment-968261545
Hi,
It is not clear how the property should work with lists
Example:
listField:
OPTIONAL F:1
shangxinli commented on pull request #828:
URL: https://github.com/apache/parquet-mr/pull/828#issuecomment-967286140
@belugabehr As @gszadovszky asked, do you plan to work on this further?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
shangxinli commented on pull request #900:
URL: https://github.com/apache/parquet-mr/pull/900#issuecomment-967285427
@mwong38, can you put more information in the Jira on why/what is changed?
This is pretty big change and it would help people to review your code.
--
This is an automated
shangxinli commented on pull request #907:
URL: https://github.com/apache/parquet-mr/pull/907#issuecomment-967283233
@belugabehr, do you want to fix the build errors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
shangxinli commented on pull request #924:
URL: https://github.com/apache/parquet-mr/pull/924#issuecomment-967272796
@YunLemon, Thanks for working on this! Are we still on track to reduce the
minutes to wait?
--
This is an automated message from the Apache Git Service.
To respond to the
shangxinli closed pull request #932:
URL: https://github.com/apache/parquet-mr/pull/932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubs
shangxinli commented on pull request #935:
URL: https://github.com/apache/parquet-mr/pull/935#issuecomment-967258392
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
gszadovszky merged pull request #937:
URL: https://github.com/apache/parquet-mr/pull/937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
ryanrupp edited a comment on pull request #937:
URL: https://github.com/apache/parquet-mr/pull/937#issuecomment-966007150
Random but had noticed this in https://github.com/trinodb/trino/issues/9890
(not related to the issue other than the toString is just used to print the
stats in the exc
ryanrupp commented on pull request #937:
URL: https://github.com/apache/parquet-mr/pull/937#issuecomment-966007150
Random but had noticed this in https://github.com/trinodb/trino/issues/9890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ryanrupp opened a new pull request #937:
URL: https://github.com/apache/parquet-mr/pull/937
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in
gszadovszky merged pull request #936:
URL: https://github.com/apache/parquet-mr/pull/936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
gszadovszky merged pull request #936:
URL: https://github.com/apache/parquet-mr/pull/936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
gszadovszky merged pull request #936:
URL: https://github.com/apache/parquet-mr/pull/936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
sekikn opened a new pull request #936:
URL: https://github.com/apache/parquet-mr/pull/936
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them in th
gszadovszky commented on a change in pull request #935:
URL: https://github.com/apache/parquet-mr/pull/935#discussion_r732870171
##
File path: parquet-hadoop/src/main/java/org/apache/parquet/crypto/AesCipher.java
##
@@ -37,6 +37,12 @@
protected static final int GCM_TAG_LENGT
shangxinli merged pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubs
shangxinli commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-933844414
Thank @ggershinsky and @gszadovszky for spending time on it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
ggershinsky commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-933545241
@shangxinli looks good, I think we're down to the 2 remaining points
(related to a crypto-config flag)
https://github.com/apache/parquet-mr/pull/928/files#r719567036
ggershinsky commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-933506341
> So I just simply revert my change that partially renamed AAD to
pageHeaderAAD. I looked at the util.java file and I see there are a lot of
other places all using AAD inst
shangxinli edited a comment on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-933499949
@gszadovszky Just addressed your feedback. For the conflict, I tried to
merge from upstream but it always resulted in a lot more conflict. So I just
simply revert my
shangxinli commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-933499949
Just addressed your feedback. For the conflict, I tried to merge from
upstream but it always resulted in a lot more conflict. So I just simply revert
my change that partiall
gszadovszky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r721165920
##
File path:
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/OffsetIndexBuilder.java
##
@@ -151,22 +151,36 @@ public Of
rdblue commented on pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#issuecomment-933027683
@gszadovszky, thanks for getting this done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ggershinsky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r720770145
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache S
ggershinsky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r720769917
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache S
shangxinli commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r720460937
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache So
shangxinli commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r720460487
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache So
ggershinsky commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-931970339
went over the code, adding a few more comments. Overall looks good; once the
remaining points are handled, I'll be ok with the PR.
--
This is an automated message from th
ggershinsky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r719992595
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache S
ggershinsky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r719567391
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java
##
@@ -1125,7 +1154,7 @@ private static void serializeCo
ggershinsky commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-931470099
yep, a couple of quick comments. will comb again tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
shangxinli commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-931428972
@ggershinsky Do you want to have another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
shangxinli edited a comment on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-931386393
@gszadovszky The first two commits had the OffsetIndex issue. The 3rd commit
added test verifyOffsetIndexes() which verified not only the offset but also
the page(hea
shangxinli commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-931426352
> Sorry, @shangxinli. My bad. Ignore my comment about the testing.
No problem Gabor! Thank you for all the feedbacks!
--
This is an automated message from the Apach
gszadovszky commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-931396500
Sorry, @shangxinli. My bad. Ignore my comment about the testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
shangxinli commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r719478762
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -280,8 +288,12 @@ private void encryptPages(Tran
shangxinli commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-931386393
@gszadovszky The first two commits had the OffsetIndex issue. The 3rd commit
added test verifyOffsetIndexes() which verified not only the offset but also
the page(header and
gszadovszky commented on pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923#issuecomment-931370971
Thank you for your contribution, @huaxingao! Great work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
huaxingao commented on pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923#issuecomment-931369233
@gszadovszky @shangxinli @viirya @dbtsai Thank you so much for all your
help!!
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
gszadovszky merged pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
gszadovszky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r719139712
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -180,21 +192,13 @@ private void processBlocks(T
gszadovszky merged pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
shangxinli commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r718777078
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache So
ggershinsky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r718184216
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache S
shangxinli commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r718777078
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache So
ggershinsky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r718184216
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache S
shangxinli commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-929348539
@gszadovszky Do you want to have a look at it again for offset index that
Gidon mentioned?
--
This is an automated message from the Apache Git Service.
To respond to the
huaxingao commented on a change in pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923#discussion_r717696646
##
File path: parquet-column/src/main/java/org/apache/parquet/column/MinMax.java
##
@@ -18,25 +18,17 @@
*/
package org.apache.parquet.column;
-imp
gszadovszky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r717723359
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache S
shangxinli edited a comment on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-929348539
@gszadovszky Do you want to have a look at it again for offsetIndex that
Gidon mentioned?
--
This is an automated message from the Apache Git Service.
To respond t
gszadovszky commented on pull request #934:
URL: https://github.com/apache/parquet-mr/pull/934#issuecomment-928994865
@vinooganesh, everything is fine. Only that I usually wait for additional 24
hours before merging so others have a chance to complain.
--
This is an automated message fro
gszadovszky commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r717364884
##
File path:
parquet-format-structures/src/main/java/org/apache/parquet/format/MetadataValidator.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the A
shangxinli commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r717708267
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache So
gszadovszky merged pull request #934:
URL: https://github.com/apache/parquet-mr/pull/934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
ggershinsky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r717301743
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
##
@@ -503,7 +503,7 @@ private void add
vinooganesh commented on pull request #934:
URL: https://github.com/apache/parquet-mr/pull/934#issuecomment-928643532
@gszadovszky - thanks for the approval! Please let me know if there is
anything else I need to do before we merge.
--
This is an automated message from the Apache Git Ser
dongjoon-hyun commented on pull request #934:
URL: https://github.com/apache/parquet-mr/pull/934#issuecomment-928791691
Thank you, @vinooganesh and all. I also hit this issue. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
gszadovszky commented on a change in pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923#discussion_r717354327
##
File path: parquet-column/src/main/java/org/apache/parquet/column/MinMax.java
##
@@ -18,25 +18,17 @@
*/
package org.apache.parquet.column;
-i
rdblue commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r716970875
##
File path:
parquet-format-structures/src/main/java/org/apache/parquet/format/MetadataValidator.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
rdblue commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r717768759
##
File path:
parquet-format-structures/src/test/java/org/apache/parquet/format/TestUtil.java
##
@@ -23,13 +23,16 @@
import static junit.framework.Asser
rdblue commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r717768214
##
File path:
parquet-format-structures/src/main/java/org/apache/parquet/format/InvalidParquetMetadataException.java
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed
gszadovszky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r717723359
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache S
shangxinli edited a comment on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-929348539
@gszadovszky Do you want to have a look at it again for offsetIndex that
Gidon mentioned?
--
This is an automated message from the Apache Git Service.
To respond t
shangxinli commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-929348539
@gszadovszky Do you want to have a look at it again for offset index that
Gidon mentioned?
--
This is an automated message from the Apache Git Service.
To respond to the
shangxinli commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r717708267
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache So
huaxingao commented on a change in pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923#discussion_r717696646
##
File path: parquet-column/src/main/java/org/apache/parquet/column/MinMax.java
##
@@ -18,25 +18,17 @@
*/
package org.apache.parquet.column;
-imp
gszadovszky merged pull request #934:
URL: https://github.com/apache/parquet-mr/pull/934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsub
gszadovszky commented on pull request #934:
URL: https://github.com/apache/parquet-mr/pull/934#issuecomment-928994865
@vinooganesh, everything is fine. Only that I usually wait for additional 24
hours before merging so others have a chance to complain.
--
This is an automated message fro
gszadovszky commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r717364884
##
File path:
parquet-format-structures/src/main/java/org/apache/parquet/format/MetadataValidator.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the A
gszadovszky commented on a change in pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923#discussion_r717354327
##
File path: parquet-column/src/main/java/org/apache/parquet/column/MinMax.java
##
@@ -18,25 +18,17 @@
*/
package org.apache.parquet.column;
-i
ggershinsky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r717319745
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,307 @@
+/*
+ * Licensed to the Apache S
ggershinsky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r717312882
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache S
ggershinsky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r717301743
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java
##
@@ -503,7 +503,7 @@ private void add
dongjoon-hyun commented on pull request #934:
URL: https://github.com/apache/parquet-mr/pull/934#issuecomment-928791691
Thank you, @vinooganesh and all. I also hit this issue. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
vinooganesh commented on pull request #934:
URL: https://github.com/apache/parquet-mr/pull/934#issuecomment-928643532
@gszadovszky - thanks for the approval! Please let me know if there is
anything else I need to do before we merge.
--
This is an automated message from the Apache Git Ser
rdblue commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r716970875
##
File path:
parquet-format-structures/src/main/java/org/apache/parquet/format/MetadataValidator.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache
shangxinli commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r716877124
##
File path: pom.xml
##
@@ -522,6 +522,9 @@
change to fix a integer overflow issue.
TODO: remove this after Parquet
gszadovszky commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r716526515
##
File path: pom.xml
##
@@ -522,6 +522,9 @@
change to fix a integer overflow issue.
TODO: remove this after Parque
gszadovszky commented on a change in pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923#discussion_r716474012
##
File path: parquet-column/src/main/java/org/apache/parquet/column/MinMax.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundati
gszadovszky commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r716453533
##
File path:
parquet-format-structures/src/test/java/org/apache/parquet/format/TestUtil.java
##
@@ -77,6 +81,21 @@ public void testReadFileMetadata
gszadovszky commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r716452332
##
File path:
parquet-format-structures/src/main/java/org/apache/parquet/format/MetadataValidator.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the A
gszadovszky commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r716450578
##
File path:
parquet-format-structures/src/main/java/org/apache/parquet/format/MetadataValidator.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the A
vinooganesh commented on pull request #934:
URL: https://github.com/apache/parquet-mr/pull/934#issuecomment-927473988
cc @gszadovszky @sunchao from https://github.com/apache/parquet-mr/pull/927.
@sunchao - apologies for the quick upgrade after yours, I saw was building
parquet from source
vinooganesh commented on pull request #934:
URL: https://github.com/apache/parquet-mr/pull/934#issuecomment-927469278
@rdblue This is a baby commit - but could you approve running tests on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
vinooganesh opened a new pull request #934:
URL: https://github.com/apache/parquet-mr/pull/934
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references
them
huaxingao commented on a change in pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923#discussion_r716278313
##
File path:
parquet-hadoop/src/test/java/org/apache/parquet/filter2/recordlevel/TestRecordLevelFilters.java
##
@@ -146,6 +147,33 @@ public void test
huaxingao commented on a change in pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923#discussion_r716278171
##
File path:
parquet-column/src/main/java/org/apache/parquet/internal/column/columnindex/ColumnIndexBuilder.java
##
@@ -326,12 +323,27 @@ boolean isN
huaxingao commented on a change in pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923#discussion_r716278127
##
File path:
parquet-generator/src/main/java/org/apache/parquet/filter2/IncrementallyUpdatedFilterPredicateGenerator.java
##
@@ -1,14 +1,14 @@
-/*
shangxinli commented on pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#issuecomment-926207482
@ggershinsky @gszadovszky Just pushed another commit to address more
feedback. Can you have another look?
--
This is an automated message from the Apache Git Service.
To
shangxinli commented on a change in pull request #928:
URL: https://github.com/apache/parquet-mr/pull/928#discussion_r715195044
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ColumnEncryptor.java
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the Apache So
rdblue commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r715155364
##
File path:
parquet-format-structures/src/test/java/org/apache/parquet/format/TestUtil.java
##
@@ -77,6 +81,21 @@ public void testReadFileMetadata() th
rdblue commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r715154831
##
File path:
parquet-format-structures/src/main/java/org/apache/parquet/format/Util.java
##
@@ -130,7 +131,7 @@ public static PageHeader readPageHeader(
rdblue commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r715154439
##
File path:
parquet-format-structures/src/main/java/org/apache/parquet/format/MetadataValidator.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache
rdblue commented on a change in pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#discussion_r715153249
##
File path:
parquet-format-structures/src/main/java/org/apache/parquet/format/MetadataValidator.java
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache
gszadovszky commented on a change in pull request #923:
URL: https://github.com/apache/parquet-mr/pull/923#discussion_r714956184
##
File path:
parquet-hadoop/src/main/java/org/apache/parquet/filter2/statisticslevel/StatisticsFilter.java
##
@@ -186,26 +186,36 @@ private boolean
shangxinli commented on pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#issuecomment-925915291
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
plygrnd commented on pull request #933:
URL: https://github.com/apache/parquet-mr/pull/933#issuecomment-925872659
Okay, LGTM then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
1201 - 1300 of 2875 matches
Mail list logo
