[
https://issues.apache.org/jira/browse/PHOENIX-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495380#comment-16495380
]
James Taylor commented on PHOENIX-3623:
---
With the change to have local indexes maintained from
[
https://issues.apache.org/jira/browse/PHOENIX-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495420#comment-16495420
]
James Taylor commented on PHOENIX-3623:
---
The failure in
[
https://issues.apache.org/jira/browse/PHOENIX-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495603#comment-16495603
]
James Taylor commented on PHOENIX-4752:
---
I don't see a benefit or need here. Phoenix treats it's
+1
Ran a test driver against a local instance which does concurrent batch
upserts to an indexed table.
Everything looked fine.
On Tue, May 29, 2018 at 2:55 PM, Thomas D'Silva
wrote:
> +1
>
> Successfully built from source and was able run all UTs/ITs.
>
> On Sun, May 27, 2018 at 2:55 PM, James
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191925360
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ExplainPlanWithStatsEnabledIT.java
---
@@ -1202,33 +1202,44 @@ private void
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495696#comment-16495696
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191926624
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -388,51 +435,65 @@ public void
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191927956
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java
---
@@ -293,6 +293,7 @@ public SQLException
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495702#comment-16495702
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495739#comment-16495739
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
+1 (binding)
Disclaimer: I only looked at the source releases. Too many other
convenience binaries to pull it all down and validate individually.
* hbase-1.1 had a slightly different xsum (.sha instead of .sha256 and
.sha512) -- not sure if this was just caused by a human
* xsums/sigs all
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495717#comment-16495717
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191931341
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
---
@@ -479,179 +498,355 @@ private void
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191936296
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java ---
@@ -1253,7 +1253,9 @@ public void
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495744#comment-16495744
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495751#comment-16495751
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191936918
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/coprocessor/MetaDataEndpointImplTest.java
---
@@ -0,0 +1,299 @@
+package
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495690#comment-16495690
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191932416
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
---
@@ -479,179 +498,355 @@ private void
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495720#comment-16495720
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191935338
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PColumnImpl.java ---
@@ -156,14 +209,14 @@ public String toString() {
[
https://issues.apache.org/jira/browse/PHOENIX-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495584#comment-16495584
]
Karan Mehta commented on PHOENIX-4752:
--
[~jamestaylor] Any thoughts here?
> Phoenix with
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495725#comment-16495725
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191933107
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2967,6 +2982,11 @@ protected PhoenixConnection
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191938147
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -586,48 +573,336 @@ public void
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495764#comment-16495764
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495819#comment-16495819
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191944884
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -388,51 +435,65 @@ public void
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495848#comment-16495848
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user churrodog commented on a diff in the
Github user churrodog commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191948951
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/WhereConstantParser.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495849#comment-16495849
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user twdsilva commented on a diff in the pull
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191941040
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1995,36 +2287,46 @@ public void
+1
Tested (installed from parcels) in CDH 5.11.2 updating from Phoenix 4.13.2
to 4.14.0 (basic table operation seems fine, no issues found) and also a
clean install in clusters running CDH 5.12, 5.13 and 5.14 ( also with basic
table operations ). Built from sources with all IT passing in all CDH
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495816#comment-16495816
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user twdsilva commented on a diff in the pull
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495792#comment-16495792
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
+1.
Verified backward compatibility and perf. to be on par with previous
release (0.98 branch).
On Wed, May 30, 2018 at 3:39 PM, Pedro Boado wrote:
> +1
>
> Tested (installed from parcels) in CDH 5.11.2 updating from Phoenix 4.13.2
> to 4.14.0 (basic table operation seems fine, no issues
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495842#comment-16495842
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user churrodog commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495850#comment-16495850
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user churrodog commented on a diff in the
Github user churrodog commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191948329
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/DropColumnIT.java ---
@@ -522,7 +523,8 @@ public void
[
https://issues.apache.org/jira/browse/PHOENIX-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal resolved PHOENIX-4567.
Resolution: Fixed
> Re-enable Phoenix transactional table tests
>
[
https://issues.apache.org/jira/browse/PHOENIX-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495980#comment-16495980
]
Ankit Singhal commented on PHOENIX-4567:
All transactions tests are enabled as a part of
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495778#comment-16495778
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user twdsilva commented on a diff in the pull
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191938764
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -586,48 +573,336 @@ public void
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495775#comment-16495775
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user twdsilva commented on a diff in the pull
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191939222
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -388,51 +435,65 @@ public void
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191942250
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -2227,35 +2551,36 @@ private
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495828#comment-16495828
]
Karan Mehta commented on PHOENIX-3655:
--
{quote}Maybe we're talking past each other. I am talking
Sergey Soldatov created PHOENIX-4759:
Summary: During restart RS that hosts SYSTEM.CATALOG table may get
stuck
Key: PHOENIX-4759
URL: https://issues.apache.org/jira/browse/PHOENIX-4759
Project:
0 We have a blocker for 5.x branch (PHOENIX-4759). It's a similar to
PHOENIX-4719 lockup in static code during classloading. Root cause -
introducing ConnectionFactory in PHOENIX-4685, so it might affect master
branch as well. If nobody else saw problems with cluster restart (For 5.x
branch we
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191939788
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1457,28 +1761,69 @@ private static void
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495787#comment-16495787
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495794#comment-16495794
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user twdsilva commented on a diff in the pull
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191944295
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -2227,35 +2551,36 @@ private MetaDataMutationResult
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495844#comment-16495844
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user churrodog commented on a diff in the
Github user churrodog commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191948510
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ColumnNameTrackingExpressionCompiler.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495845#comment-16495845
]
Josh Elser commented on PHOENIX-3655:
-
{quote}Would not this mean that we will have to manage the
Github user churrodog commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191948812
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java ---
@@ -787,7 +787,7 @@ public MutationPlan compile(UpsertStatement
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191948821
--- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java
---
@@ -388,51 +435,65 @@ public void
[
https://issues.apache.org/jira/browse/PHOENIX-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495958#comment-16495958
]
James Taylor commented on PHOENIX-3623:
---
Latest test run on my Linux box. Would be good to get
+1
Checked sums and signatures: ok
RAT check passes (0.98, 1.3, 1.4): ok
Built from source (0.98, 1.3, 1.4): ok
Unit tests pass (0.98): ok, with two flakes: PhoenixQueryTimeoutIT and
OctetLengthFunctionEnd2EndIT
Unit tests pass (1.3): ok
On Sun, May 27, 2018 at 2:55 PM, James Taylor
wrote:
[
https://issues.apache.org/jira/browse/PHOENIX-4567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal reassigned PHOENIX-4567:
--
Assignee: Ankit Singhal
> Re-enable Phoenix transactional table tests
>
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/303#discussion_r191940463
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1995,36 +2287,46 @@ public void
[
https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495797#comment-16495797
]
ASF GitHub Bot commented on PHOENIX-3534:
-
Github user JamesRTaylor commented on a diff in the
[
https://issues.apache.org/jira/browse/PHOENIX-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496098#comment-16496098
]
James Taylor commented on PHOENIX-4760:
---
FYI, [~ohads] - some follow up work to do.
> Prevent
James Taylor created PHOENIX-4760:
-
Summary: Prevent data loss for client-side local index maintanence
in Omid
Key: PHOENIX-4760
URL: https://issues.apache.org/jira/browse/PHOENIX-4760
Project:
65 matches
Mail list logo
