NiklasMerz opened a new pull request #1: Remove headline border and background
URL: https://github.com/apache/plc4x-build-tools/pull/1
I would remove the background for all `h` tags to make it look more "clean"
and "modern"
See mail to mailing list.
-
chrisdutz merged pull request #1: Remove headline border and background
URL: https://github.com/apache/plc4x-build-tools/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log o
dominikriemer opened a new pull request #2: PLC4X landing page
URL: https://github.com/apache/plc4x-build-tools/pull/2
This PR adds some improvements to the PLC4X homepage:
- teaser image + teaser text
- improved layout of the feature sections
- carousel to show integrations on the
chrisdutz merged pull request #2: PLC4X landing page
URL: https://github.com/apache/plc4x-build-tools/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
splatch opened a new pull request #3: [WIP] PLC4X-193 Support for little endian
types in build tools.
URL: https://github.com/apache/plc4x-build-tools/pull/3
This is work in progress.
This is an automated message from the Apa
splatch commented on issue #3: [WIP] PLC4X-193 Support for little endian types
in build tools.
URL: https://github.com/apache/plc4x-build-tools/pull/3#issuecomment-613112539
@chrisdutz I didn't do any grouping cause `Protocol` itself doesn't have any
marks which indicate its byte order. St
chrisdutz commented on issue #3: [WIP] PLC4X-193 Support for little endian
types in build tools.
URL: https://github.com/apache/plc4x-build-tools/pull/3#issuecomment-613245404
Hi Lukasz ... well this protocol level switch is already there ... if you
initialize the Read and WriteBuffers as
splatch opened a new pull request #4: More content about MSpec, its use and
overall structure.
URL: https://github.com/apache/plc4x-build-tools/pull/4
Main intention is to provide a description to someone who is unfamiliar with
protocol development and knows nothing about MSpec.
-
ottobackwards opened a new pull request #142:
URL: https://github.com/apache/plc4x/pull/142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ottobackwards opened a new pull request #143:
URL: https://github.com/apache/plc4x/pull/143
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ottobackwards opened a new pull request #144:
URL: https://github.com/apache/plc4x/pull/144
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ottobackwards opened a new pull request #145:
URL: https://github.com/apache/plc4x/pull/145
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
chrisdutz commented on pull request #119:
URL: https://github.com/apache/plc4x/pull/119#issuecomment-619860506
I'm going to close this one as the problem is no longer applicable to the
new S7 driver.
This is an automated mes
chrisdutz commented on pull request #67:
URL: https://github.com/apache/plc4x/pull/67#issuecomment-619862104
Oh gee .. I can't believe how long this has been open .. I am extremely
sorry for that.
I just had a look and to me it seems as if the same thing you are addressing
here is also
chrisdutz commented on pull request #108:
URL: https://github.com/apache/plc4x/pull/108#issuecomment-619862951
Any progress on bringing this to mspec?
This is an automated message from the Apache Git Service.
To respond to th
glcj commented on pull request #108:
URL: https://github.com/apache/plc4x/pull/108#issuecomment-620280905
>
>
> Any progress on bringing this to mspec?
Hi Chris,
At this moment I am migrating Merlot to use the PLC4X driver model, as soon
as I finish I will carry out lo
ottobackwards opened a new pull request #146:
URL: https://github.com/apache/plc4x/pull/146
- fixed some of the list stuff
- changed to use lists for parameters
added note: the response items are created in the driver and opaque, they
must be given back to the driver to free().
ottobackwards opened a new pull request #147:
URL: https://github.com/apache/plc4x/pull/147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ottobackwards opened a new pull request #148:
URL: https://github.com/apache/plc4x/pull/148
Use plc4c_data not void*
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ottobackwards opened a new pull request #149:
URL: https://github.com/apache/plc4x/pull/149
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
splatch commented on pull request #141:
URL: https://github.com/apache/plc4x/pull/141#issuecomment-624355174
I'm closing this one since it is not required to get ADS handling. Basic
fields which are assembled to bit, byte or int types can be mapped using a
receiving order without need to s
splatch commented on pull request #3:
URL: https://github.com/apache/plc4x-build-tools/pull/3#issuecomment-624355650
This PR is not relevant any more due to mentioned ability of `ReadBuffer`
and `WriteBuffer`.
This is an aut
ottobackwards opened a new pull request #150:
URL: https://github.com/apache/plc4x/pull/150
… to plc4_connection and plc4c_system to start
clang-format changes
add ability to look up an element from a void*
fix some bugs around cleanup.
logic to destroy connections
con
ottobackwards opened a new pull request #151:
URL: https://github.com/apache/plc4x/pull/151
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ottobackwards opened a new pull request #152:
URL: https://github.com/apache/plc4x/pull/152
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ottobackwards opened a new pull request #156:
URL: https://github.com/apache/plc4x/pull/156
If you are just working on c, and in CLion or something, the dependency on
BUILD_PHASE for the maven caller doesn't make sense.
Changes so that you can work only in C.
note: you still h
chrisdutz commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629095469
Perhaps inverting the logic and allowing to disable tests would be an option
...
This is an automated message fro
chrisdutz commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629095235
The thing with this is that now you can't build without tests ... I
intentionally built it that way, that you can do a maven build and skip tests
...
---
ottobackwards commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629213899
OK, I'll add that.
This is an automated message from the Apache Git Service.
To respond to the message, please
ottobackwards commented on pull request #156:
URL: https://github.com/apache/plc4x/pull/156#issuecomment-629273548
never mind
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ottobackwards closed pull request #156:
URL: https://github.com/apache/plc4x/pull/156
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
JulianFeinauer opened a new pull request #157:
URL: https://github.com/apache/plc4x/pull/157
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
asfgit merged pull request #157:
URL: https://github.com/apache/plc4x/pull/157
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
patrickse opened a new pull request #158:
URL: https://github.com/apache/plc4x/pull/158
Eclipse Milo 0.3.7 supports relaxed nonce validation when not using
protected credentials. It's needed to talk to development PLC from Schneider
Electric.
https://github.com/eclipse/milo/commit/
JulianFeinauer commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633477367
Thanks @patrickse ! Do we have integration tests for milo or did you test
the code already?
This is an autom
patrickse commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479410
I am not aware of any integration test. We've changed the dependency and
deployd it to our platform. It looks ok for now. How could I implement an
integration test?
JulianFeinauer commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479750
Good question, indeed.
This is an automated message from the Apache Git Service.
To respond to the message, p
JulianFeinauer edited a comment on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479750
Good question, indeed. But good to know that it works for you. @nalim2 we
should definetly have a look there. Probably we could start an OPC Server and
start a Client
nalim2 commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633525795
Yeah i think to include there a Sample Server should be a good idea. I would
first just integrate a Milo example server and would transfere the ManualTest
class to an integration tes
nalim2 edited a comment on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633525795
Yeah i think to include there a Sample Server should be a good idea. I would
first just integrate a Milo example server and would transfere the ManualTest
class to an integrat
nalim2 commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633527174
But just the updated versions lgtm
This is an automated message from the Apache Git Service.
To respond to the messag
ottobackwards merged pull request #160:
URL: https://github.com/apache/plc4x/pull/160
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
chrisdutz merged pull request #159:
URL: https://github.com/apache/plc4x/pull/159
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ottobackwards opened a new pull request #160:
URL: https://github.com/apache/plc4x/pull/160
… fu between all supported versions
This is an automated message from the Apache Git Service.
To respond to the message, please log o
chrisdutz opened a new pull request #161:
URL: https://github.com/apache/plc4x/pull/161
…) so we can do code reviews on it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nalim2 merged pull request #158:
URL: https://github.com/apache/plc4x/pull/158
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
chrisdutz commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-634810800
Yeah that would indeed shorten some names by 50%
This is an automated message from the Apache Git Service.
To resp
chrisdutz commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-634811316
So how about if the next letter is uppercase too, treat the current as the
same block.
This is an automated mess
ottobackwards commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-634876265
Yes something like that
This is an automated message from the Apache Git Service.
To respond to the message, p
chrisdutz opened a new pull request #162:
URL: https://github.com/apache/plc4x/pull/162
Hi folks,
I would like the community to approve this change ...
Chris
This is an automated message from the Apache Git Ser
JulianFeinauer commented on pull request #162:
URL: https://github.com/apache/plc4x/pull/162#issuecomment-635229505
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
JulianFeinauer merged pull request #162:
URL: https://github.com/apache/plc4x/pull/162
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ottobackwards commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-635369565
That looks great!
This is an automated message from the Apache Git Service.
To respond to the message, please
ottobackwards commented on a change in pull request #161:
URL: https://github.com/apache/plc4x/pull/161#discussion_r433854541
##
File path: sandbox/plc4c/spi/include/plc4c/spi/read_buffer.h
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
chrisdutz commented on a change in pull request #161:
URL: https://github.com/apache/plc4x/pull/161#discussion_r433855719
##
File path: sandbox/plc4c/spi/include/plc4c/spi/read_buffer.h
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
ottobackwards commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-637526622
wrt read/write buffer. I think we'll need something for endianness and
float formats
This is an automated me
chrisdutz commented on pull request #161:
URL: https://github.com/apache/plc4x/pull/161#issuecomment-637527414
;-) ... I am currently replicating what we have in Java and here the
endianess is handled internally. It's handled in the constructor of the buffer.
-
ottobackwards commented on a change in pull request #161:
URL: https://github.com/apache/plc4x/pull/161#discussion_r433858766
##
File path: sandbox/plc4c/spi/include/plc4c/spi/read_buffer.h
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
chrisdutz commented on a change in pull request #161:
URL: https://github.com/apache/plc4x/pull/161#discussion_r433860059
##
File path: sandbox/plc4c/spi/include/plc4c/spi/read_buffer.h
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
ottobackwards commented on a change in pull request #161:
URL: https://github.com/apache/plc4x/pull/161#discussion_r433861139
##
File path: sandbox/plc4c/spi/include/plc4c/spi/read_buffer.h
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
chrisdutz merged pull request #161:
URL: https://github.com/apache/plc4x/pull/161
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
chrisdutz opened a new pull request #163:
URL: https://github.com/apache/plc4x/pull/163
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nalim2 opened a new pull request #164:
URL: https://github.com/apache/plc4x/pull/164
included a milo server into the test cases for read, write and connection.
Build a PR for feedback on the test structure, the milo integration and not to
mess up again the git history 👯
KonstantinKe opened a new pull request #165:
URL: https://github.com/apache/plc4x/pull/165
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
JulianFeinauer merged pull request #165:
URL: https://github.com/apache/plc4x/pull/165
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
JulianFeinauer commented on pull request #165:
URL: https://github.com/apache/plc4x/pull/165#issuecomment-644650704
❤️ Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nalim2 merged pull request #164:
URL: https://github.com/apache/plc4x/pull/164
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
nalim2 opened a new pull request #166:
URL: https://github.com/apache/plc4x/pull/166
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nalim2 commented on pull request #166:
URL: https://github.com/apache/plc4x/pull/166#issuecomment-644956201
Haha ok i will update that one later for you <3
This is an automated message from the Apache Git Service.
To respond
nalim2 opened a new pull request #167:
URL: https://github.com/apache/plc4x/pull/167
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nalim2 commented on pull request #167:
URL: https://github.com/apache/plc4x/pull/167#issuecomment-644957237
Hope the long wide image size is ok
This is an automated message from the Apache Git Service.
To respond to the messa
chrisdutz opened a new pull request #168:
URL: https://github.com/apache/plc4x/pull/168
This is the new approach using tagged unions instead of separate types for
every sub-type.
This is an automated message from the Apache
ottobackwards commented on a change in pull request #168:
URL: https://github.com/apache/plc4x/pull/168#discussion_r441130521
##
File path:
build-utils/language-c/src/main/java/org/apache/plc4x/language/c/CLanguageTemplateHelper.java
##
@@ -436,8 +476,45 @@ private String toEx
ottobackwards commented on a change in pull request #168:
URL: https://github.com/apache/plc4x/pull/168#discussion_r441131919
##
File path: sandbox/plc4c/generated-sources/modbus/src/modbus_constants.c
##
@@ -24,18 +24,18 @@
#include "modbus_constants.h"
// Parse function.
ottobackwards commented on pull request #168:
URL: https://github.com/apache/plc4x/pull/168#issuecomment-645005753
that is too much to look through all of it.
It looks good. A couple of things that come to mind:
- can we run clang-format after generation?
- should we be generat
nalim2 commented on pull request #167:
URL: https://github.com/apache/plc4x/pull/167#issuecomment-645018424
@JulianFeinauer Yep ty for rec this CP error
This is an automated message from the Apache Git Service.
To respond to
JulianFeinauer merged pull request #167:
URL: https://github.com/apache/plc4x/pull/167
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chrisdutz commented on a change in pull request #168:
URL: https://github.com/apache/plc4x/pull/168#discussion_r442008506
##
File path:
build-utils/language-c/src/main/java/org/apache/plc4x/language/c/CLanguageTemplateHelper.java
##
@@ -436,8 +476,45 @@ private String toExpres
chrisdutz commented on a change in pull request #168:
URL: https://github.com/apache/plc4x/pull/168#discussion_r442009007
##
File path: sandbox/plc4c/generated-sources/modbus/src/modbus_constants.c
##
@@ -24,18 +24,18 @@
#include "modbus_constants.h"
// Parse function.
-plc
chrisdutz commented on pull request #168:
URL: https://github.com/apache/plc4x/pull/168#issuecomment-645823603
> that is too much to look through all of it.
> It looks good. A couple of things that come to mind:
>
> * can we run clang-format after generation?
> * should we be ge
ottobackwards commented on pull request #168:
URL: https://github.com/apache/plc4x/pull/168#issuecomment-645992571
@chrisdutz that is fair enough. no reason not to keep it like it is
This is an automated message from the Apa
ottobackwards commented on a change in pull request #168:
URL: https://github.com/apache/plc4x/pull/168#discussion_r442298201
##
File path:
build-utils/language-c/src/main/java/org/apache/plc4x/language/c/CLanguageTemplateHelper.java
##
@@ -436,8 +476,45 @@ private String toEx
chrisdutz commented on a change in pull request #168:
URL: https://github.com/apache/plc4x/pull/168#discussion_r442300763
##
File path:
build-utils/language-c/src/main/java/org/apache/plc4x/language/c/CLanguageTemplateHelper.java
##
@@ -436,8 +476,45 @@ private String toExpres
chrisdutz merged pull request #163:
URL: https://github.com/apache/plc4x/pull/163
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
chrisdutz merged pull request #168:
URL: https://github.com/apache/plc4x/pull/168
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
JulianFeinauer opened a new pull request #169:
URL: https://github.com/apache/plc4x/pull/169
@glcj: I Started a PR for it, to have a place to discuss and Test stuff. I
hope that is okay for you?
This is an automated message
glcj commented on pull request #169:
URL: https://github.com/apache/plc4x/pull/169#issuecomment-653082111
Thanks, Julian,
All the information and the links to the test codes and the pcap captures
are in the open points of Jira (I imagine that if the PR proceeds they will be
closed).
JulianFeinauer opened a new pull request #170:
URL: https://github.com/apache/plc4x/pull/170
…ify the user.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ottobackwards commented on pull request #170:
URL: https://github.com/apache/plc4x/pull/170#issuecomment-655750717
This looks good. It would be nice if there were some tests for this though
+1
This is an automated mes
JulianFeinauer commented on pull request #170:
URL: https://github.com/apache/plc4x/pull/170#issuecomment-655942698
@ottobackwards I agree with you (I also would like to have a test), yet I'm
unsure how we can provide a Test with lower complexity then the implementation.
Perhaps @chrisdutz
chrisdutz commented on a change in pull request #170:
URL: https://github.com/apache/plc4x/pull/170#discussion_r452018041
##
File path:
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
##
@@ -299,6 +319,14 @@ public void onConnect
JulianFeinauer commented on a change in pull request #170:
URL: https://github.com/apache/plc4x/pull/170#discussion_r452019997
##
File path:
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
##
@@ -299,6 +319,14 @@ public void onCo
chrisdutz commented on a change in pull request #170:
URL: https://github.com/apache/plc4x/pull/170#discussion_r452032069
##
File path:
plc4j/drivers/s7/src/main/java/org/apache/plc4x/java/s7/readwrite/protocol/S7ProtocolLogic.java
##
@@ -299,6 +319,14 @@ public void onConnect
jixuan1989 opened a new pull request #171:
URL: https://github.com/apache/plc4x/pull/171
Hi,
this pr provides using IoTDB session API for writing data.
The related doc on the website is also supplied.
This is an autom
hutcheb opened a new pull request #172:
URL: https://github.com/apache/plc4x/pull/172
- Address formats similar to 41, 01 were added
- Address formats similar to 4x1, 0x01 were added.
- Changed the lowest address the user can reference to 1 instead of 0.
-
chrisdutz commented on a change in pull request #172:
URL: https://github.com/apache/plc4x/pull/172#discussion_r456296593
##
File path:
plc4j/drivers/modbus/src/main/java/org/apache/plc4x/java/modbus/field/ModbusFieldDiscreteInput.java
##
@@ -26,21 +26,40 @@ Licensed to the Ap
chrisdutz commented on pull request #171:
URL: https://github.com/apache/plc4x/pull/171#issuecomment-659969892
Probably might be a good idea to add the "useJDBC" to the options and allow
switching from the command-line?
This
chrisdutz merged pull request #166:
URL: https://github.com/apache/plc4x/pull/166
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
chrisdutz commented on pull request #170:
URL: https://github.com/apache/plc4x/pull/170#issuecomment-659973093
> @ottobackwards I agree with you (I also would like to have a test), yet
I'm unsure how we can provide a Test with lower complexity then the
implementation. Perhaps @chrisdutz ha
chrisdutz edited a comment on pull request #170:
URL: https://github.com/apache/plc4x/pull/170#issuecomment-659973093
> @ottobackwards I agree with you (I also would like to have a test), yet
I'm unsure how we can provide a Test with lower complexity then the
implementation. Perhaps @chris
1 - 100 of 2242 matches
Mail list logo
