Re: Java 11 for POI 5?

[Dominik Stadler]

So I see two +1 and one -1 from comitters, one user stated a +1 for
updating support to Java 11+ in the next major version of Apache POI.

Unfortunately still not a very decisive outcome :(

So let's ask another way:


*Are you using Apache POI with Java 8 and do you think that it needs to
continue to support it in the next major version? If so, please speak up so
we know about it!*

Thanks... Dominik.


On Thu, Feb 22, 2024 at 3:59 PM Axel Howind  wrote:

> I feel really bad that I mixed up versions when I asked this. POI 5 can of
> course stay on Java 8 and everybody can be using POI 5 for as long as they
> want. With Java 11 having reached Premier Support EOL in September last
> year, we should be really having this conversation about Java 17 for POI 6
> now.
>
> IMHO anyone still running on Java 8 in 2024 either does not care about
> running the latest version of every library they use, or accepts that
> rather sooner than later his dependencies might not provide fixes for bugs
> and security issues any more.
>
> > * I am not aware of any dependency that we rely on that has fixes that
> we can't uptake if we stick to Java 8 - ie the projects still publish Java
> 8 friendly releases even if they have higher version releases that don't
> support Java 8
>
> We are talking about the next major release of POI that will be in
> production through the coming years. Dependencies that come to mind:
> - javax.xml.bind is deprecated. The natural replacement would be
> jakarta.xml.bind that already requires Java 11.
> - PDFBox will move to Java 11 in their next major version.
> - Log4J 3 is currently in beta and has bumped the required runtime version
> to Java 17 (https://logging.apache.org/log4j/3.x/release-notes.html).
>
> Why can’t we do the same thing as those dependencies you mentioned?
> Publish a Java 8 friendly POI 5 and POI 6 using a newer Java baseline?
>
> > * I am not aware of any major Java runtime features that we need to
> uptake that are not in Java 8
>
> I am also not aware of any runtime features that POI needs that could not
> have been solved in Java 4. But what we end up with is code that is slow
> and adds maintenance cost that enables POI to be compatible with Java 8 and
> is completely useless on Java 11+.
>
> - Improved I/O in Java 11:
>
>   Take the IOUtils.copy() methods as an example. They could be replaced by
> a single IOStream.transferTo() call in Java 11 but we still copy every byte
> manually.
>
>   Another example: there are several toByteARRAY() METHODS IN IoUtils that
> are all implemented by calling this method:
>
> private static byte[] toByteArray(InputStream stream, final int
> length, final int maxLength,
>   final boolean checkEOFException,
> final boolean isLengthKnown) throws IOException {
> if (length < 0 || maxLength < 0) {
> throw new RecordFormatException("Can't allocate an array of
> length < 0");
> }
> final int derivedMaxLength = Math.max(maxLength,
> BYTE_ARRAY_MAX_OVERRIDE);
> if ((length != Integer.MAX_VALUE) || (derivedMaxLength !=
> Integer.MAX_VALUE)) {
> checkLength(length, derivedMaxLength);
> }
>
> final int derivedLen = isLengthKnown ? Math.min(length,
> derivedMaxLength) : derivedMaxLength;
> final int byteArrayInitLen =
> calculateByteArrayInitLength(isLengthKnown, length, derivedMaxLength);
> final int internalBufferLen = DEFAULT_BUFFER_SIZE;
> try (UnsynchronizedByteArrayOutputStream baos =
> UnsynchronizedByteArrayOutputStream.builder().setBufferSize(byteArrayInitLen).get())
> {
> byte[] buffer = new byte[internalBufferLen];
> int totalBytes = 0, readBytes;
> do {
> readBytes = stream.read(buffer, 0,
> Math.min(internalBufferLen, derivedLen - totalBytes));
> totalBytes += Math.max(readBytes, 0);
> if (readBytes > 0) {
> baos.write(buffer, 0, readBytes);
> }
> checkByteSizeLimit(totalBytes);
> } while (totalBytes < derivedLen && readBytes > -1);
>
> if (BYTE_ARRAY_MAX_OVERRIDE < 0 && readBytes > -1 &&
> !isLengthKnown && stream.read() >= 0) {
> throwRecordTruncationException(derivedMaxLength);
> }
>
> if (checkEOFException && derivedLen != Integer.MAX_VALUE &&
> totalBytes < derivedLen) {
> throw new EOFException("unexpected EOF - expected len: " +
> derivedLen + " - actual len: " + totalBytes);
> }
>
> return baos.toByteArray();
> }
> }
>
> In Java 11, you’d call either stream.readNBytes() or stream.readAllBytes()
> and put away with the IoUtils.toByteArray() implementation.
>
> - String improvements:
>
>   Currently we have to use code like `textContent.trim().split("\n“)` to
> create an array of lines and then use a for-each loop to process the
> entries. Not only 

Re: Why is org.gradle.caching not enabled?

[Dominik Stadler]

Hi,

Thanks for the research,it seems I committed this back in 2021:

Use parallel build to speed up building and running tests
>
> Enable parallel building and parallel test-execution
> Provide a configuration to still build/test serially on CI
> via CI_BUILD=TRUE gradle --no-parallel --max-workers=1 clean build
> Adjust Jenkins DSL to set CI_BUILD to avoid problems in CI
> Adjust TestAllFiles to not fail when parallel builds are enabled
> Reduce memory settings to reduce requirements on build-environments
> Add gradle plugin to list task-dependencies
>
> Thanks to Andreas Reichel for the PR
>
> Closes #275


Some more details are at https://github.com/apache/poi/pull/275

I could not find a reason why we needed to keep caching disabled back then,
so I'd say go for it, we can revert it easily if we find issues with it.

Thanks... Dominik.


On Sun, Feb 25, 2024 at 11:38 AM Axel Howind  wrote:

> Hi,
>
> PJ mentioned in the "Java 11“ thread that poi-ooxml-lite build times were
> slow, so I eaned to look into this. I saw the following comment in
> build.gradle.properties:
>
> # Activating will be much faster, but break the build of
> 'poi-ooxml-lite‘
> # @todo: look into poi-ooxml-lite task generateModuleInfo and enforce
> running whatever is needed before
> org.gradle.caching=false
>
> To test, I set org.gradle.caching to true and did several clean and build
> runs both of the parent project and ooxml-lite and everything passed
> without error. Is the problem maybe already solved? Could be a change in
> the build files or fixed by a gradle update. If nobody knows why it is
> still disabled, maybe we should try to enable the caching again and see if
> it works now. If not, we at least know that it really still breaks the
> build.
>
> I am sorry if this has been discussed on the mailing list and I missed it.
> I have been away for a while because of my day job and more pressing
> problems I had with other projects that I need for my project.
>
> Cheers,
> Axel
>
>

Re: Java 11 for POI 5?

[Dominik Stadler]

Hi,

What do others thing?

We currently are at +2/-1 for moving to Java 11 minimum.

Would be good if we get a more significant number of votes for this.

Thanks... Dominik.


On Sat, Feb 3, 2024 at 10:04 PM Axel Howind  wrote:

> Hi,
>
> for whatever reason I cannot reach both the Nabble and MarkMail archives
> to check if this has been discussed before, but I think it would be a good
> idea to bump the minimum Java version for POI 5 to 11. I’d also be ok (or
> rather like) 17. What do you think?
>
> Cheers,
> Axel
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Java 11 for POI 5?

[Dominik Stadler]

Hi,

+1 from me for raising minimum Java to 11


* We can get rid of some build-complexity
* Anybody who is at Java 8 should start planning upgrading by now in my
opinion
* expected performance improvements seen when upgrading are sometimes
impressive and make for a very easy business justification if needed.
* Many Apache projects moved already


Regards... Dominik

On Sun, Feb 4, 2024 at 9:04 PM Axel Howind  wrote:

> AFAIK XMLBeans is now maintained by the POI project itself, so it should
> not be problematic.
>
>
> > Am 04.02.2024 um 20:59 schrieb Dave Fisher :
> >
> > What version of Java is the minimum for XMLBeans? We should not forget
> XMLBeans in this discussion.
> >
> > Best,
> > Dave
> >
> >> On Feb 3, 2024, at 5:54 PM, Axel Howind  wrote:
> >>
> >> No one forces users of POI to update to the latest version. Going to 11
> in POI 6 doesn't mean we
> >> have to stop providing bug fixes to POI 5 from one day to the next. But
> whoever is still using
> >> Java 8 is now certainly used to not being able to use the newest
> version of every dependency.
> >>
> >> Most major frameworks and many libraries now have a baseline of at
> least Java 11. And many of
> >> those that are still on 8 will also have to do the switch because
> features from older Java
> >> versions will be removed and the replacements are not yet available on
> 8:
> >> - finalizers (replaced by Cleaner introduced in 9)
> >> - sun.misc.Unsafe (replacement depends on use case, some introduced
> from 9 on)
> >>
> >> Current minimum Java version for some of the most used framework and
> libraries:
> >> Spring Framework and Spring Boot: java 17
> >> WildFly: Java 11
> >> Quarkus: Java 11
> >> Hibernate: Java 11
> >> KeyCloak: Java 17
> >> RabbitMQ: Java 11
> >>
> >> Even the IDEs require more recent versions to run (but can compile
> using older versions):
> >> Eclipse: Java 11 (17 recommeded)
> >> Netbeans: Java 11
> >> IntelliJ: Java 17
> >>
> >> Even some dependencies of POI already require Java 11 in their current
> version:
> >> Jakarta XML bind: Java 11 is required for version 4.x
> >> xmlsec: Java 11 is required for 4.x
> >>
> >> And some will bump the Java version for their next major release:
> >> Log4j 3.x will require Java 17
> >> PDFbox 4.x will require Java 11
> >> Saxon is (hopefully?) still Java 8 compatible but not tested anymore
> under Java 8
> >>
> >> So staying on 8 would mean that POI will not be able to upgrade
> dependencies to the latest
> >> versions of some of the dependencies and possibly rely on versions that
> will be unsupported in the
> >> foreseeable future.
> >>
> >> Moving to Java 11 will make the code easier to maintain. There are a
> lot of improvements in IO,
> >> String handling, and collections that make the code more concise,
> easier to understand, and maintain.
> >>
> >>
> >>> Am 03.02.2024 um 22:18 schrieb PJ Fanning  >:
> >>>
> >>> Current POI version is 5.2.5. So I presume the idea is to release a
> POI 6 with Java 11 only support. I'm -1 on this. I don't see any great
> advantage in only supporting Java 11. Java 8 is still widely supported by
> vendors.
> >>>
> >>> https://endoflife.date/oracle-jdk says 6 more years of Java 8.
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> On Saturday 3 February 2024 at 22:04:26 GMT+1, Axel Howind <
> a...@dua3.com> wrote:
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> Hi,
> >>>
> >>> for whatever reason I cannot reach both the Nabble and MarkMail
> archives to check if this has been discussed before, but I think it would
> be a good idea to bump the minimum Java version for POI 5 to 11. I’d also
> be ok (or rather like) 17. What do you think?
> >>>
> >>> Cheers,
> >>> Axel
> >>>
> >>>
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> >>> For additional commands, e-mail: dev-h...@poi.apache.org
> >>>
> >>>
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> >>> For additional commands, e-mail: dev-h...@poi.apache.org
> >>>
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> >> For additional commands, e-mail: dev-h...@poi.apache.org
> >>
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
>
>

Re: Vulnerability Found: (Click Jacking)

[Dominik Stadler]

Hi,

Please note that posting such reports to public mailing lists is
discouraged.

Please follow the guidelines outlined at https://www.apache.org/security/
for reporting to the proper lists/channels.

Dominik.


On Sat, Jan 6, 2024 at 11:26 AM Elias Finn <
elias.ethics.researc...@gmail.com> wrote:

> Hello Team,
>
> As an Ethical Hacker I found some Vulnerabilities in your site one of them
> is as follows.
>
>
> *Issue : CLICKJACKINGa*
>
>
> Clickjacking, also known as a "UI redress attack", is when an attackaer
> uses
> multiple transparent or opaque layers to trick a user into clicking on a
> button or link on another page when they were intending to click on the
> top level page. Thus, the attacker is "hijacking" clicks meant for their
> page and routing them to another page, most likely owned by another
> application, domain, or both.
> Using a similar technique, keystrokes can also be hijacked. With a
> carefully crafted combination of stylesheets, iframes, and text boxes, a
> user can be led to believe they are typing in the password to their email
> or bank account, but are instead typing into an invisible frame controlled
> by the attacker.
>
>
>
> *PoC:*
> 
> https://www.alansasphalt.com/>
> https://poi.apache.org/ " >
>
> 
> 
>
>
> *IMPACTS:*
> By using Clickjacking technique, an attacker hijacks clicks meant for one
> page and routes them to another page, most likely for another application,
> domain, or both.
>
>
> *Remediation:*
> Frame busting technique is the better framing protection
> technique. Sending the proper X-Frame-Options HTTP response headers
> that instruct the browser to not allow framing from other
> domains
>
>
> *For Fix:*
> it is missing a X-FRAME header. a user with the help of some tricky css
> can trick the user to click on the one
> click actions. . You should apply a X-FRAME header
>
> *References:*
>
> https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options
> https://www.owasp.org/index.php/Clickjacking
>
> https://github.com/OWASP/CheatSheetSeries/blob/master/cheatsheets/Clickjacking_Defense_Cheat_Sheet.md
>
>
>
>
> *Note:* I’m hoping to receive a bounty reward for my current finding. I
> will be looking forward to hearing from you on this and will be reporting
> other vulnerabilities accordingly.
>
>
> Kind Regards
>
> *Elias Finn*
>
> *Snapshot:*
> [image: image.png]
>

Re: Regression in JDK 21.0.1 related to XML signature validation

[Dominik Stadler]

Hi, 

FYI, Oracle has confirmed and fixed the regression with XML Signature 
Validation, so the test should start working again with JDK 21.0.2 and newer.


I have now reported another regression, this time in 
XMLInputFactory.getProperty() in early-access builds of JDK 22 and 23. This 
currently makes tests fail on these JDK versions when run locally with Ant 
(Gradle does not yet work with JDK 22+):

https://bugs.openjdk.org/browse/JDK-8320597

Thanks Dominik

On 2023/11/22 13:19:48 Dominik Stadler wrote:
> Hi,
> 
> FYI, builds for JDK 21 started to fail recently at
> https://builds.apache.org/job/POI/job/POI-DSL-1.21/.
> 
> It turns out that JDK 21.0.1 seems to have a regression related to XML
> Signature Validation compared to JDK 21.0.0!
> 
> See https://bugs.openjdk.org/browse/JDK-8320597 for the related bug-report
> for the JDK.
> 
> Thanks... Dominik.
> 

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: Missing pivot sorting related classes in apache lite

[Dominik Stadler]

Hi,

For compiling you need JDK 8, but Gradle can't find any, e.g. via the
following property or running the whole build with JDK 8


-Porg.gradle.java.installations.paths=/custom/path/jdk1.8,/shared/jre11

See https://docs.gradle.org/current/userguide/toolchains.html for
details about this Gradle feature.

Dominik.

.

Dominik.

On Sat, Dec 2, 2023 at 11:13 AM Constantine Linnick <
clinn...@recordlinker.com> wrote:

> Hello
>
> tl;dr: I need several classes in poi-lite and can't even build the poi
> gradle project.
>
> I'm trying to build pivot table and I need following classes:
>
> import
> org.openxmlformats.schemas.spreadsheetml.x2006.main.CTPivotAreaReference
> import org.openxmlformats.schemas.spreadsheetml.x2006.main.STFieldSortType
>
> Probably impl versions too:
>
>
> org.openxmlformats.schemas.spreadsheetml.x2006.main.impl.STFieldSortTypeImpl
>
> org.openxmlformats.schemas.spreadsheetml.x2006.main.impl.CTPivotAreaReferenceImpl
>
> According to faq-N10025 I should provide a test case that will demonstrate
> the use case for this file.
>
> And here's another problem: I can't even build poi on win x64 temurin 17.
> Both gradlew and IDEA failing with:
>
> A problem occurred evaluating project ':poi'.
> > Failed to calculate the value of task ':poi:compileTestJava' property
> 'javaCompiler'.
>> No matching toolchains found for requested specification:
> {languageVersion=8, vendor=any, implementation=vendor-specific} for WINDOWS
> on x86_64.
>   > No locally installed toolchains match and toolchain download
> repositories have not been configured.
>
> What is my next step?
>

Regression in JDK 21.0.1 related to XML signature validation

[Dominik Stadler]

Hi,

FYI, builds for JDK 21 started to fail recently at
https://builds.apache.org/job/POI/job/POI-DSL-1.21/.

It turns out that JDK 21.0.1 seems to have a regression related to XML
Signature Validation compared to JDK 21.0.0!

See https://bugs.openjdk.org/browse/JDK-8320597 for the related bug-report
for the JDK.

Thanks... Dominik.

Re: [VOTE] Release Apache POI 5.2.5 (RC1)

[Dominik Stadler]

Hi,

Verified contents of src-package and tested the staging binaries in some
projects, everything seems to work fine!

Did also run the large regression testing corpus. There were a high number
of failures, however those are likely caused by some new checks in
poi-integration and a non-deterministic order of loading ExtractorFactory.
I will add a small change to use a deterministic order, but this was the
case since a long time, so we don't need to hold the release because of it.
See
http://people.apache.org/~centic/poi_regression/reports/index524RC1to525RC1.html
for details

So I am +1 for Apache POI 5.2.5

Thanks!

On Sat, Nov 18, 2023 at 12:37 PM PJ Fanning  wrote:

> Hello POI Community,
>
> This is a call for a vote to release Apache POI version 5.2.5 (RC1).
>
> The discussion thread:
>
> https://lists.apache.org/thread/v34mgjl4tm5b0s76b7cbj3xxb7lp2sv7
>
> The release candidate:
>
> https://dist.apache.org/repos/dist/dev/poi/
>
> This release has been signed with a PGP key available here:
>
> https://dist.apache.org/repos/dist/release/poi/KEYS
>
> Release Notes:
>
> https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.5.txt
>
> I will add the svn tag REL_5_2_5 if the vote passes.
> Svn commit ID: https://svn.apache.org/repos/asf/poi/trunk@1913865
>
> Please download, verify, and test.
>
> We have also staged jars in the Apache Nexus Repository. These were
> built with the same code
> as appears in this Source Release Candidate. We would appreciate if
> users could test with these too.
> If anyone finds any serious problems with these jars, please also
> notify us on this thread.
>
> https://repository.apache.org/content/groups/staging/org/apache/poi/
>
> In gradle, you can add this repository.
>
> maven {
> url "https://repository.apache.org/content/groups/staging/;
> }
>
>
>
> The VOTE will pass if we have more positive votes than negative votes
> and there must be a minimum of 3 approvals from POI PMC members.
>
> I will leave the vote open for at least a week.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> To learn more about Apache POI, please see https://poi.apache.org/
>
> Checklist for reference:
>
> [ ] Download links are valid.
> [ ] Checksums and signatures.
> [ ] LICENSE/NOTICE files exist
> [ ] No unexpected binary files
> [ ] Source files have ASF headers
> [ ] Can compile from source
>
> To compile from the source, please refer to:
>
> Some notes about verifying downloads can be found at:
>
> https://poi.apache.org/download.html
>
>
> Here is my +1 (binding).
>
> Thanks,
>
> PJ Fanning (Apache POI PMC member)
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache XmlBeans 5.2.0 release (RC1)

[Dominik Stadler]

Hi,

did a check of the contents of binary and source packages and verified
checksums, .. everything looks good.

So +1 from me!

D.

On Wed, Nov 8, 2023 at 10:18 AM PJ Fanning 
wrote:

> Hi everyone,
>
> I've prepared artifacts for the release of Apache XmlBeans 5.2.0 (RC1).
> This is built with Java 8.
>
> This is a bug fix and dependency upgrade release.
>
>
> A full list of changes is available in the change log:
>
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10436=12352213
>
>
> https://issues.apache.org/jira/browse/XMLBEANS-642?jql=project%20%3D%20XMLBEANS%20AND%20fixVersion%20%3D%20%22Version%205.2.0%22
>
>
> The artifacts are at:
>
> https://dist.apache.org/repos/dist/dev/poi/XMLBeans-5.2.0-RC1/
>
>
>
> You can use this maven URL for your mvn/gradle builds:
>
> https://repository.apache.org/content/repositories/staging
>
>
>
> Please vote to release the artifacts.
>
> The vote is open until 2023-11-15 12:00 UTC.
>
>
> Here is my +1(binding)
>
> PJ
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [DISCUSS] XMLBeans 5.2.0 release

[Dominik Stadler]

Hi,

Sorry for delayed response, I think it a good idea to update XmlBeans first
and then include it in an updated POI, thanks PJ for preparing the release!

Thanks... Dominik.

On Tue, Nov 7, 2023 at 11:02 AM PJ Fanning 
wrote:

> Since there doesn't seem to be a major rush on getting POI 5.2.5 out, I'd
> like to press on with XMLBeans 5.2.0.
>
> After we get that released, we can uptake it in POI and do a POI release.
>
> I intend to take the artifacts from
> https://ci-builds.apache.org/job/POI/job/POI-XMLBeans-DSL-1.8/218/. The
> aim would be to verify them locally first before loading them up to
> dist.apache.org for review.
>
>
>
>
>
>
> On Sunday 1 October 2023 at 16:08:14 GMT+2, PJ Fanning <
> fannin...@apache.org> wrote:
>
>
>
>
>
> It's been a year since the last XMLBeans release. There aren't a huge
> number of changes but Saxon-HE has some breaking changes in its 12.x
> releases. This makes it sort of messy for us to have our last XMLBeans
> release depending on Saxon-HE 11.x.
>
> Changes:
> https://issues.apache.org/jira/projects/XMLBEANS/versions/12352213
>
> I don't think there is a major driver to quickly release a follow up POI
> release but we could probably do one in a few months with XMLBeans and
> PDFBox upgraded. POI is currently blocked from using PDFBox 3 because of
> https://bz.apache.org/bugzilla/show_bug.cgi?id=67023 - but this might be
> fixed soon.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: POI 5.2.5 release

[Dominik Stadler]

Hi,

According to my testing, ALL versions since 3-something did close
InputStream when you use XSSFWorkbook or OPCPackage, so this has been the
established behaviour for quite some time in Apache POI.

The change in ZipPackage in 66584 seems to have caused a close() even if no
exception is thrown, which is causing the problem reported in #67579.

So I think it best for now to revert both changes so we are back at what
5.2.3 did, not sure what 66584 actually fixed anyway.

Dominik.

On Thu, Oct 26, 2023 at 5:18 PM PJ Fanning 
wrote:

> HSSFWorkbook(InputStream) closes its InputStream. So this is really a
> mess. So I guess the best is for XSSFWorkbook to also close
> its InputStream. We can document this and warn users that this is the
> behaviour and that they can work around it by using something like
> NoCloseInputStream.
>
>
> https://github.com/apache/poi/blob/f64524916d449d37350e0763e4f86edc239bbd34/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/internal/NoCloseInputStream.java
>
>
>
>
>
>
>
>
>
> On Thursday 26 October 2023 at 15:44:03 IST, PJ Fanning <
> fannin...@yahoo.com> wrote:
>
>
>
>
>
> Can I clarify?
>
> You want https://bz.apache.org/bugzilla/show_bug.cgi?id=67579 reverted?
>
> If I interpret the poi-reproduce results correctly, there is a regression
> from 5.2.3 to 5.2.4 in the stream case.
>
> The behaviour might have changed in 5.2.2 to 5.2.3 migration but it still
> means that there is a regression in 5.2.3 to 5.2.4.
>
> Surely, we should not be closing input streams - they should be closed by
> the provider. We should only close input streams that our code creates
> internally.
>
> What if we call the prospective release 5.3.0 and keep the 67579 fix?
>
>
>
> On Thursday 26 October 2023 at 15:16:48 IST, Dominik Stadler <
> dominik.stad...@gmx.at> wrote:
>
>
>
>
>
> Hi,
>
> ah, sorry, seems I did not take a close enough look myself until now.
>
> I wanted to be sure what the state was before and how it should be. See the
> "reproducer" project at https://github.com/centic9/poi-reproduce and the
> resulting summary:
>
>
> 3.17 4.0.0 4.0.1 4.1.0 4.1.1 4.1.2 5.0.0 5.1.0 5.2.0 5.2.1 5.2.2 5.2.3
> 5.2.4
> trunk-2023-10-26 Goal
> Workbook-Stream closed closed leaked closed closed closed closed closed
> closed closed closed closed closed leaked closed
> Workbook-File fails, closed closed closed closed closed closed closed
> closed
> closed closed closed closed closed closed closed
> Workbook-String fails, closed closed closed closed closed closed closed
> closed closed closed closed closed closed closed closed
> OPCPacakge-Stream closed closed leaked closed closed closed closed closed
> closed closed closed closed closed leaked closed
> OPCPackage-File closed closed closed closed closed closed closed closed
> closed closed closed closed closed closed closed
> OPCPackage-String closed closed closed closed closed closed closed closed
> closed closed closed closed closed closed closed
> Broken-file - Stream leaked closed closed leaked leaked leaked leaked
> leaked
> leaked leaked leaked leaked closed leaked closed
> Broken-file - File leaked closed closed leaked leaked leaked leaked leaked
> leaked leaked leaked leaked leaked leaked closed
> Broken-file - String leaked closed closed leaked leaked leaked leaked
> leaked
> leaked leaked leaked leaked leaked leaked closed
>
>
> This indicates the following to me:
>
> * The bug-report about a "regression with closing streams in 5.2.4" seems
> to be incorrect. We closed provided InputStreams since a long time!
> * => So I do not think we should change close-behavior, we rather should
> revert the recent changes in trunk to restore the state of 5.2.4 for now
> * We can look at the special case of a file that is not a proper Zip-File,
> but this is a minor thing not relevant to the release
>
>
> Thanks... Dominik.
>
>
> On Wed, Oct 25, 2023 at 6:49 PM PJ Fanning 
> wrote:
>
> > I cannot reproduce the leaked file handle. This test case does not leak
> > files. I tested with `lsof -f`. I had a file handle until I closed the
> > xssfWorkbook but not after.
> >
> > File file = ...
> > XSSFWorkbook xssfWorkbook = new XSSFWorkbook(file);
> > // some Thread.sleep(...) here - use `lsof- f` during this sleep
> >  xssfWorkbook.close();
> > // some Thread.sleep(...) here - use `lsof- f` during this 2nd sleep
> >
> > Tested on a Mac with latest POI code in svn trunk.
> >
> >
> >
> >
> >
> > On Wednesday 25 October 2023 at 12:40:12 IST, PJ Fanning
> >  wrote:
> >
> >
> >
> >
> >
> > I wi

Re: POI 5.2.5 release

[Dominik Stadler]

Hi,

ah, sorry, seems I did not take a close enough look myself until now.

I wanted to be sure what the state was before and how it should be. See the
"reproducer" project at https://github.com/centic9/poi-reproduce and the
resulting summary:


3.17 4.0.0 4.0.1 4.1.0 4.1.1 4.1.2 5.0.0 5.1.0 5.2.0 5.2.1 5.2.2 5.2.3 5.2.4
trunk-2023-10-26 Goal
Workbook-Stream closed closed leaked closed closed closed closed closed
closed closed closed closed closed leaked closed
Workbook-File fails, closed closed closed closed closed closed closed closed
closed closed closed closed closed closed closed
Workbook-String fails, closed closed closed closed closed closed closed
closed closed closed closed closed closed closed closed
OPCPacakge-Stream closed closed leaked closed closed closed closed closed
closed closed closed closed closed leaked closed
OPCPackage-File closed closed closed closed closed closed closed closed
closed closed closed closed closed closed closed
OPCPackage-String closed closed closed closed closed closed closed closed
closed closed closed closed closed closed closed
Broken-file - Stream leaked closed closed leaked leaked leaked leaked leaked
leaked leaked leaked leaked closed leaked closed
Broken-file - File leaked closed closed leaked leaked leaked leaked leaked
leaked leaked leaked leaked leaked leaked closed
Broken-file - String leaked closed closed leaked leaked leaked leaked leaked
leaked leaked leaked leaked leaked leaked closed


This indicates the following to me:

* The bug-report about a "regression with closing streams in 5.2.4" seems
to be incorrect. We closed provided InputStreams since a long time!
* => So I do not think we should change close-behavior, we rather should
revert the recent changes in trunk to restore the state of 5.2.4 for now
* We can look at the special case of a file that is not a proper Zip-File,
but this is a minor thing not relevant to the release


Thanks... Dominik.


On Wed, Oct 25, 2023 at 6:49 PM PJ Fanning 
wrote:

> I cannot reproduce the leaked file handle. This test case does not leak
> files. I tested with `lsof -f`. I had a file handle until I closed the
> xssfWorkbook but not after.
>
> File file = ...
> XSSFWorkbook xssfWorkbook = new XSSFWorkbook(file);
> // some Thread.sleep(...) here - use `lsof- f` during this sleep
>  xssfWorkbook.close();
> // some Thread.sleep(...) here - use `lsof- f` during this 2nd sleep
>
> Tested on a Mac with latest POI code in svn trunk.
>
>
>
>
>
> On Wednesday 25 October 2023 at 12:40:12 IST, PJ Fanning
>  wrote:
>
>
>
>
>
> I will try to set up some debugging of the File path. I am not convinced
> that the ZipPackage InputStream changes affect the behaviour when you
> provide a File instead. The code handles Files and InputStreams differently.
>
>
>
>
>
> On Wednesday 25 October 2023 at 07:24:52 IST, Dominik Stadler <
> dominik.stad...@gmx.at> wrote:
>
>
>
>
>
> Hi,
>
> We now leave open file-handles whenever the constructor for "File" is used
> in ZipPackage. Not sure if the background Java support for closing stale
> file-handles will capture those or if we will see "too many open files" in
> large environments.
>
> Can we only wrap the stream in NoCloseStream when it is actually opened via
> an incoming InputStream and not when it is opened from a File?
>
> Thanks... Dominik.
>
> On Wed, Oct 25, 2023 at 12:38 AM PJ Fanning  wrote:
>
> > Are we in a position to proceed with a 5.2.5 RC1?
> >
> >
> > On 2023/10/16 10:23:42 Tim Allison wrote:
> > > This just bit us on Tika:
> > > https://bz.apache.org/bugzilla/show_bug.cgi?id=67767
> > >
> > > The fix is easy.  I can patch it today.  It would be great to get it
> into
> > > 5.2.5. I'm sorry that I didn't catch it during the earlier regression
> > > tests...my fault.
> > >
> > > On Sun, Oct 15, 2023 at 4:34 PM Dominik Stadler <
> dominik.stad...@gmx.at>
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > I use file-leak-detector when running tests locally, this shows any
> > > > left-over file-handles when running tests via the IDE.
> > > >
> > > > See https://github.com/jenkinsci/lib-file-leak-detector
> > > >
> > > > If you clone the latest version and build the tool locally via Maven,
> > you
> > > > can add something like the following in the run-config in the IDE:
> > > >
> > > >
> > > >
> >
> -javaagent:/opt/file-leak-detector/target/file-leak-detector-1.17-SNAPSHOT-jar-with-dependencies.jar=http=0,strong,excludes=/opt/poi/file-leak-detector.exclude,dumpatshutdown
> > > >

Re: POI 5.2.5 release

[Dominik Stadler]

Hi,

We now leave open file-handles whenever the constructor for "File" is used
in ZipPackage. Not sure if the background Java support for closing stale
file-handles will capture those or if we will see "too many open files" in
large environments.

Can we only wrap the stream in NoCloseStream when it is actually opened via
an incoming InputStream and not when it is opened from a File?

Thanks... Dominik.

On Wed, Oct 25, 2023 at 12:38 AM PJ Fanning  wrote:

> Are we in a position to proceed with a 5.2.5 RC1?
>
>
> On 2023/10/16 10:23:42 Tim Allison wrote:
> > This just bit us on Tika:
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=67767
> >
> > The fix is easy.  I can patch it today.  It would be great to get it into
> > 5.2.5. I'm sorry that I didn't catch it during the earlier regression
> > tests...my fault.
> >
> > On Sun, Oct 15, 2023 at 4:34 PM Dominik Stadler 
> > wrote:
> >
> > > Hi,
> > >
> > > I use file-leak-detector when running tests locally, this shows any
> > > left-over file-handles when running tests via the IDE.
> > >
> > > See https://github.com/jenkinsci/lib-file-leak-detector
> > >
> > > If you clone the latest version and build the tool locally via Maven,
> you
> > > can add something like the following in the run-config in the IDE:
> > >
> > >
> > >
> -javaagent:/opt/file-leak-detector/target/file-leak-detector-1.17-SNAPSHOT-jar-with-dependencies.jar=http=0,strong,excludes=/opt/poi/file-leak-detector.exclude,dumpatshutdown
> > >
> > > Then you will get a dump of all leftover file-handles at the end.
> > >
> > > In this case, it only happens if we enter the special catch-block in
> > > ZipPackage#ZipPackage(File, PackageAccess).
> > >
> > > One of the broken files from fuzzing seems to trigger this,
> constructing
> > > the package succeeds then, however with a resulting unclosed
> file-handle.
> > >
> > > So it seems to be less wide-spread than I originally thought and may
> > > actually have been the case before as well, not sure any more now...
> > >
> > > Dominik.
> > >
> > > On Sun, Oct 15, 2023 at 9:34 PM PJ Fanning  >
> > > wrote:
> > >
> > > > Thanks Dominik for the feedback. The probable breaking change was:
> > > >
> > > >
> > >
> https://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/ZipPackage.java?r1=1909467=1909466=1909467
> > > >
> > > >
> > > > There have been some more changes, eg using java.nio.files.File to
> create
> > > > InputStreams instead of using FileInputStream.
> > > >
> > > > For this reason, I would prefer to use a test based approach to
> ensuring
> > > > the 'close' is called. Ideally, I would like to leave behind a
> regression
> > > > test.
> > > >
> > > > The ZipPackage change (r1909467) only affects the use of
> InputStreams and
> > > > does not affect the use of File inputs. The ZipPackage code is very
> > > > different on whether you start by providing an InputStream as
> opposed to
> > > a
> > > > java.io.File. In the latter case, we use a ZipFile class instance to
> do
> > > > random access to the wrapped files.
> > > >
> > > > Could you provide me with some example of what needs debugging? For
> > > > instance, would something like this not work ok?
> > > >
> > > > File file = 
> > > > try (XSSFWorkbook wb = new XSSFWorkbook(file)) {
> > > >   ... use wb
> > > > }
> > > >
> > > > Is the sort of usage you are suggesting where we would fail to close
> an
> > > > InputStream?
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > On Sunday 15 October 2023 at 19:37:33 IST, Dominik Stadler <
> > > > dominik.stad...@gmx.at> wrote:
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > Hi,
> > > >
> > > > FYI, the current fix for not closing streams also does not close any
> > > stream
> > > > opened via a "File" parameter, so we are introducing many unclosed
> > > > resources via this change at the moment.
> > > >
> > > > Can we solve this somehow differently?

Re: POI 5.2.5 release

[Dominik Stadler]

Hi,

I use file-leak-detector when running tests locally, this shows any
left-over file-handles when running tests via the IDE.

See https://github.com/jenkinsci/lib-file-leak-detector

If you clone the latest version and build the tool locally via Maven, you
can add something like the following in the run-config in the IDE:

-javaagent:/opt/file-leak-detector/target/file-leak-detector-1.17-SNAPSHOT-jar-with-dependencies.jar=http=0,strong,excludes=/opt/poi/file-leak-detector.exclude,dumpatshutdown

Then you will get a dump of all leftover file-handles at the end.

In this case, it only happens if we enter the special catch-block in
ZipPackage#ZipPackage(File, PackageAccess).

One of the broken files from fuzzing seems to trigger this, constructing
the package succeeds then, however with a resulting unclosed file-handle.

So it seems to be less wide-spread than I originally thought and may
actually have been the case before as well, not sure any more now...

Dominik.

On Sun, Oct 15, 2023 at 9:34 PM PJ Fanning 
wrote:

> Thanks Dominik for the feedback. The probable breaking change was:
>
> https://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/openxml4j/opc/ZipPackage.java?r1=1909467=1909466=1909467
>
>
> There have been some more changes, eg using java.nio.files.File to create
> InputStreams instead of using FileInputStream.
>
> For this reason, I would prefer to use a test based approach to ensuring
> the 'close' is called. Ideally, I would like to leave behind a regression
> test.
>
> The ZipPackage change (r1909467) only affects the use of InputStreams and
> does not affect the use of File inputs. The ZipPackage code is very
> different on whether you start by providing an InputStream as opposed to a
> java.io.File. In the latter case, we use a ZipFile class instance to do
> random access to the wrapped files.
>
> Could you provide me with some example of what needs debugging? For
> instance, would something like this not work ok?
>
> File file = 
> try (XSSFWorkbook wb = new XSSFWorkbook(file)) {
>   ... use wb
> }
>
> Is the sort of usage you are suggesting where we would fail to close an
> InputStream?
>
>
>
>
>
>
>
>
> On Sunday 15 October 2023 at 19:37:33 IST, Dominik Stadler <
> dominik.stad...@gmx.at> wrote:
>
>
>
>
>
> Hi,
>
> FYI, the current fix for not closing streams also does not close any stream
> opened via a "File" parameter, so we are introducing many unclosed
> resources via this change at the moment.
>
> Can we solve this somehow differently? Maybe cleanly revert the change
> which introduced it?
>
> Thanks... Dominik.
>
>
>
> On Mon, Oct 9, 2023 at 1:47 PM PJ Fanning  wrote:
>
> > HI everyone,
> >
> > I think the regression in issue 67579 [1] is serious to warrant a new POI
> > release. With that in mind, could we ramp down on changes while we decide
> > if we want to release soon.
> >
> > I can do this one again unless someone else wants to do it.
> >
> > Regards,
> > PJ
> >
> > [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=67579
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: POI 5.2.5 release

[Dominik Stadler]

Hi,

FYI, the current fix for not closing streams also does not close any stream
opened via a "File" parameter, so we are introducing many unclosed
resources via this change at the moment.

Can we solve this somehow differently? Maybe cleanly revert the change
which introduced it?

Thanks... Dominik.



On Mon, Oct 9, 2023 at 1:47 PM PJ Fanning  wrote:

> HI everyone,
>
> I think the regression in issue 67579 [1] is serious to warrant a new POI
> release. With that in mind, could we ramp down on changes while we decide
> if we want to release soon.
>
> I can do this one again unless someone else wants to do it.
>
> Regards,
> PJ
>
> [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=67579
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Request to contribure to Apache Poi

[Dominik Stadler]

Hi,

We have collected information about starting development with Apache POI at
https://poi.apache.org/devel/index.html

It should be mostly up to date as far as I see. Also the sub-pages
https://poi.apache.org/devel/subversion.html and
https://poi.apache.org/devel/guidelines.html provide additional information.

Please let us know if you run into roadblocks so we can help out and also
update these pages if necessary.

Dominik.


On Mon, Oct 9, 2023 at 2:34 PM Axel Howind  wrote:

> Hi Lynda,
>
> thank you for offering to help. If you found an issue with Apache POI, you
> should check the issue tracker first to see if this has already been
> reported. If not, create an issue yourself.
>
> Provide a reproducible example. The next step would be to check out the
> source and build POI yourself. IMHO the easiest way to do so is fork Apache
> POI on Github. Make sure everything compiles and all tests pass. Then
> create a branch for your issue. Write a test case and add it to your
> branch. Now the build should fail. Try to fix the code and once the build
> runs without errors, make a pull request or attach a patch to your bug
> report and then ask for a review.
>
> Note that this is my personal, totally unofficial list of things I do when
> I have issues with any Open Source project I use, it’s neither official,
> nor Apache POI specific.
>
> Just let us know if you need any more specific help.
>
> Greetings,
> Axel
>
> > Am 09.10.2023 um 05:28 schrieb Lynda Douglas  >:
> >
> > Good evening,
> > I have been using the Apache POI packages to create applications for
> almost
> > a year now but I ran into an issue with the XDDF XWPF just a few days
> ago.
> > I saw in one of the comments that the developer who used to maintain
> these
> > libraries no longer makes contributions  so I would like to find out
> > exactly what it takes to try to help out.
> >
> > I am trying to follow the instructions on the page but many of the links
> > are broken and the dates are as early as 2003. Thank you for taking the
> > time out to read this email and I look forward to hearing from you.
> >
> > Sincerely,
> > Lynda Douglas
> > Github: https://github.com/LyndaPD94
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

[jira] [Commented] (XMLBEANS-641) Fuzzing XMLBeans triggers an assert() for an input-file via Apache POI

[Dominik Stadler (Jira)]

[ 
https://issues.apache.org/jira/browse/XMLBEANS-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771435#comment-17771435
 ] 

Dominik Stadler commented on XMLBEANS-641:
--

Currently fuzzing via oss-fuzz only found this one, but it may pop up more when 
fuzzing is continuing.

It should be possible to reproduce with Apache POI via the attached document 
and the following:

 
{code:java}
try (XWPFDocument doc = new XWPFDocument(new ByteArrayInputStream(input))) {
doc.write(NullOutputStream.INSTANCE);
} {code}
Can that be used to produce a reproducer-test for XMLBeans?

 

> Fuzzing XMLBeans triggers an assert() for an input-file via Apache POI
> --
>
> Key: XMLBEANS-641
> URL: https://issues.apache.org/jira/browse/XMLBEANS-641
> Project: XMLBeans
>  Issue Type: Bug
>    Reporter: Dominik Stadler
>Priority: Major
> Attachments: 
> clusterfuzz-testcase-minimized-POIXWPFFuzzer-6733884933668864.docx
>
>
> Fuzzing Apache POI via oss-fuzz shows the following assert() being triggered 
> via an input-file.
>  
> Would be good to convert to IllegalArgumentException or IllegalStateException 
> so that fuzzy testing can continue to flag other places where assert() is 
> used incorrectly.
>  
> {code:java}
>  at org.apache.xmlbeans.impl.store.Saver$TextSaver.emitName(Saver.java:1099)
>  at org.apache.xmlbeans.impl.store.Saver$TextSaver.emitElement(Saver.java:894)
>  at org.apache.xmlbeans.impl.store.Saver.processElement(Saver.java:461)
>  at org.apache.xmlbeans.impl.store.Saver.process(Saver.java:291)
>  at org.apache.xmlbeans.impl.store.Saver$TextSaver.write(Saver.java:1696)
>  at 
> org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.ensure(Saver.java:2348)
>  at 
> org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.access$200(Saver.java:2234)
>  at 
> org.apache.xmlbeans.impl.store.Saver$InputStreamSaver$OutputStreamImpl.read(Saver.java:2393)
>  at 
> org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.lambda$read$0(Saver.java:2332)
>  at org.apache.xmlbeans.impl.store.Saver.syncWrap(Saver.java:2184)
>  at org.apache.xmlbeans.impl.store.Saver.access$000(Saver.java:33)
>  at 
> org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.read(Saver.java:2332)
>  at java.base/java.io.InputStream.read(InputStream.java:218)
>  at org.apache.xmlbeans.impl.store.Cursor._save(Cursor.java:570)
>  at org.apache.xmlbeans.impl.store.Cursor.lambda$save$17(Cursor.java:2006)
>  at org.apache.xmlbeans.impl.store.Cursor.syncWrapHelper(Cursor.java:2551)
>  at org.apache.xmlbeans.impl.store.Cursor.syncWrapIOEx(Cursor.java:2504)
>  at org.apache.xmlbeans.impl.store.Cursor.save(Cursor.java:2006)
>  at org.apache.xmlbeans.impl.values.XmlObjectBase.save(XmlObjectBase.java:190)
>  at org.apache.poi.xwpf.usermodel.XWPFTheme.commit(XWPFTheme.java:178)
>  at 
> org.apache.poi.ooxml.POIXMLDocumentPart.onSave(POIXMLDocumentPart.java:467)
>  at 
> org.apache.poi.ooxml.POIXMLDocumentPart.onSave(POIXMLDocumentPart.java:472)
>  at org.apache.poi.ooxml.POIXMLDocument.write(POIXMLDocument.java:221){code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[jira] [Updated] (XMLBEANS-641) Fuzzing XMLBeans triggers an assert() for an input-file via Apache POI

[Dominik Stadler (Jira)]

 [ 
https://issues.apache.org/jira/browse/XMLBEANS-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Stadler updated XMLBEANS-641:
-
Attachment: 
clusterfuzz-testcase-minimized-POIXWPFFuzzer-6733884933668864.docx

> Fuzzing XMLBeans triggers an assert() for an input-file via Apache POI
> --
>
> Key: XMLBEANS-641
> URL: https://issues.apache.org/jira/browse/XMLBEANS-641
> Project: XMLBeans
>  Issue Type: Bug
>    Reporter: Dominik Stadler
>Priority: Major
> Attachments: 
> clusterfuzz-testcase-minimized-POIXWPFFuzzer-6733884933668864.docx
>
>
> Fuzzing Apache POI via oss-fuzz shows the following assert() being triggered 
> via an input-file.
>  
> Would be good to convert to IllegalArgumentException or IllegalStateException 
> so that fuzzy testing can continue to flag other places where assert() is 
> used incorrectly.
>  
> {code:java}
>  at org.apache.xmlbeans.impl.store.Saver$TextSaver.emitName(Saver.java:1099)
>  at org.apache.xmlbeans.impl.store.Saver$TextSaver.emitElement(Saver.java:894)
>  at org.apache.xmlbeans.impl.store.Saver.processElement(Saver.java:461)
>  at org.apache.xmlbeans.impl.store.Saver.process(Saver.java:291)
>  at org.apache.xmlbeans.impl.store.Saver$TextSaver.write(Saver.java:1696)
>  at 
> org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.ensure(Saver.java:2348)
>  at 
> org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.access$200(Saver.java:2234)
>  at 
> org.apache.xmlbeans.impl.store.Saver$InputStreamSaver$OutputStreamImpl.read(Saver.java:2393)
>  at 
> org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.lambda$read$0(Saver.java:2332)
>  at org.apache.xmlbeans.impl.store.Saver.syncWrap(Saver.java:2184)
>  at org.apache.xmlbeans.impl.store.Saver.access$000(Saver.java:33)
>  at 
> org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.read(Saver.java:2332)
>  at java.base/java.io.InputStream.read(InputStream.java:218)
>  at org.apache.xmlbeans.impl.store.Cursor._save(Cursor.java:570)
>  at org.apache.xmlbeans.impl.store.Cursor.lambda$save$17(Cursor.java:2006)
>  at org.apache.xmlbeans.impl.store.Cursor.syncWrapHelper(Cursor.java:2551)
>  at org.apache.xmlbeans.impl.store.Cursor.syncWrapIOEx(Cursor.java:2504)
>  at org.apache.xmlbeans.impl.store.Cursor.save(Cursor.java:2006)
>  at org.apache.xmlbeans.impl.values.XmlObjectBase.save(XmlObjectBase.java:190)
>  at org.apache.poi.xwpf.usermodel.XWPFTheme.commit(XWPFTheme.java:178)
>  at 
> org.apache.poi.ooxml.POIXMLDocumentPart.onSave(POIXMLDocumentPart.java:467)
>  at 
> org.apache.poi.ooxml.POIXMLDocumentPart.onSave(POIXMLDocumentPart.java:472)
>  at org.apache.poi.ooxml.POIXMLDocument.write(POIXMLDocument.java:221){code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: [DISCUSS] XMLBeans 5.2.0 release

[Dominik Stadler]

Yes, would be good to release and then later include it in Apache POI.

There is one assert() which can be triggered via POI with a specially
crafted file. I have created
https://issues.apache.org/jira/browse/XMLBEANS-641

Would be nice to change this to an exception so we can continue to detect
unwanted assert()s in other places.

Dominik.


On Sun, Oct 1, 2023 at 4:08 PM PJ Fanning  wrote:

> It's been a year since the last XMLBeans release. There aren't a huge
> number of changes but Saxon-HE has some breaking changes in its 12.x
> releases. This makes it sort of messy for us to have our last XMLBeans
> release depending on Saxon-HE 11.x.
>
> Changes:
> https://issues.apache.org/jira/projects/XMLBEANS/versions/12352213
>
> I don't think there is a major driver to quickly release a follow up POI
> release but we could probably do one in a few months with XMLBeans and
> PDFBox upgraded. POI is currently blocked from using PDFBox 3 because of
> https://bz.apache.org/bugzilla/show_bug.cgi?id=67023 - but this might be
> fixed soon.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

[jira] [Created] (XMLBEANS-641) Fuzzing XMLBeans triggers an assert() for an input-file via Apache POI

[Dominik Stadler (Jira)]

Dominik Stadler created XMLBEANS-641:


 Summary: Fuzzing XMLBeans triggers an assert() for an input-file 
via Apache POI
 Key: XMLBEANS-641
 URL: https://issues.apache.org/jira/browse/XMLBEANS-641
 Project: XMLBeans
  Issue Type: Bug
Reporter: Dominik Stadler


Fuzzing Apache POI via oss-fuzz shows the following assert() being triggered 
via an input-file.

 

Would be good to convert to IllegalArgumentException or IllegalStateException 
so that fuzzy testing can continue to flag other places where assert() is used 
incorrectly.

 
{code:java}
 at org.apache.xmlbeans.impl.store.Saver$TextSaver.emitName(Saver.java:1099)
 at org.apache.xmlbeans.impl.store.Saver$TextSaver.emitElement(Saver.java:894)
 at org.apache.xmlbeans.impl.store.Saver.processElement(Saver.java:461)
 at org.apache.xmlbeans.impl.store.Saver.process(Saver.java:291)
 at org.apache.xmlbeans.impl.store.Saver$TextSaver.write(Saver.java:1696)
 at 
org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.ensure(Saver.java:2348)
 at 
org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.access$200(Saver.java:2234)
 at 
org.apache.xmlbeans.impl.store.Saver$InputStreamSaver$OutputStreamImpl.read(Saver.java:2393)
 at 
org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.lambda$read$0(Saver.java:2332)
 at org.apache.xmlbeans.impl.store.Saver.syncWrap(Saver.java:2184)
 at org.apache.xmlbeans.impl.store.Saver.access$000(Saver.java:33)
 at org.apache.xmlbeans.impl.store.Saver$InputStreamSaver.read(Saver.java:2332)
 at java.base/java.io.InputStream.read(InputStream.java:218)
 at org.apache.xmlbeans.impl.store.Cursor._save(Cursor.java:570)
 at org.apache.xmlbeans.impl.store.Cursor.lambda$save$17(Cursor.java:2006)
 at org.apache.xmlbeans.impl.store.Cursor.syncWrapHelper(Cursor.java:2551)
 at org.apache.xmlbeans.impl.store.Cursor.syncWrapIOEx(Cursor.java:2504)
 at org.apache.xmlbeans.impl.store.Cursor.save(Cursor.java:2006)
 at org.apache.xmlbeans.impl.values.XmlObjectBase.save(XmlObjectBase.java:190)
 at org.apache.poi.xwpf.usermodel.XWPFTheme.commit(XWPFTheme.java:178)
 at org.apache.poi.ooxml.POIXMLDocumentPart.onSave(POIXMLDocumentPart.java:467)
 at org.apache.poi.ooxml.POIXMLDocumentPart.onSave(POIXMLDocumentPart.java:472)
 at org.apache.poi.ooxml.POIXMLDocument.write(POIXMLDocument.java:221){code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: [VOTE] Release Apache POI 5.2.4 (RC1)

[Dominik Stadler]

Hi,

I found one additional minor issue,the following 2 files are part of the
source-package and break the "rat" step if you execute full "jenkins" build
target. But I would not re-run the release just because of this unless
something else pops up.

./poi/src/main/java/org/apache/poi/hssf/record/SSTDeserializer.java
(working copy).svnpatch.rej
./poi/src/test/java/org/apache/poi/hssf/record/TestSSTDeserializer.java
  (working copy).svnpatch.rej

Dominik.

On Sat, Sep 23, 2023 at 12:31 PM Dominik Stadler 
wrote:

> Hi,
>
> +1 from me, thanks P.J.!
>
> Large-scale regression testing looks good, only very very few regressions
> for more than 3mio documents ( ~0.02% ), most are caused by slightly
> stricter handling (more than 1000 compressed files, more than 300 nested
> children), a few remaining cases which we can take a look after release.
> Results are at
> http://people.apache.org/~centic/poi_regression/reports/index523RC1to524RC1.html
> and
> http://people.apache.org/~centic/poi_regression/reportsAll/index523RC1to524RC1.html
>
> Difference between source-packages from 5.2.3 and 5.2.4 looks good.
>
> Building from sources works locally.
>
> Upgrading projects to 5.2.4RC1 from the staging Maven repository did work
> fine, all tests passing.
>
>
> I added a note in the changelog about the removed binary packages, but if
> possible we should also add a bit more description about this in the
> announcement email. I think it may disrupt how some people integrate poi
> and thus may be worth to note in the release notes/announcement as well.
> I.e. "either build it yourself or download the binaries from Maven Central"
>
> Regards... Dominik.
>
> On Fri, Sep 22, 2023 at 9:26 PM Tim Allison  wrote:
>
>> +1
>>
>> Reports are here:  There's surprisingly little difference:
>> https://corpora.tika.apache.org/base/reports/poi-reports.tgz
>>
>> I only had time to glance briefly.
>>
>> Thank you PJ and team!
>>
>> On Fri, Sep 22, 2023 at 4:09 AM PJ Fanning 
>> wrote:
>>
>> > Thanks Alex. The pdfbox issue is tracked at
>> > https://bz.apache.org/bugzilla/show_bug.cgi?id=67023 and includes a
>> link
>> > to what is blocking our upgrade.
>> >
>> > In terms of the version names of the jars - the ASF has a rule that you
>> > must release what has been voted on. That means I can't create 5.2.4-RC1
>> > jars - get those voted on and then go off and rebuild 5.2.4 jars without
>> > having those voted on. The jars are not in Maven Central yet, they are
>> in a
>> > staging area. Anyone who tests the staging jars will need to consider
>> > cleaning out their local jar caches (e.g. their Maven local cache) after
>> > they test the staging jars. Only a small number of POI reviewers will
>> use
>> > the staging jars.
>> >
>> >
>> >
>> >
>> >
>> >
>> > On Friday 22 September 2023 at 04:05:48 IST, Axel Howind > >
>> > wrote:
>> >
>> >
>> >
>> >
>> >
>> > +1 for the release.
>> >
>> > I just built and tested one of my own projects with the RC and
>> everything
>> > seems to work just fine.
>> >
>> > Two notes:
>> > - I think release candidates should be published with an "rc“ in the
>> > version string, something like "5.3.4-rc1“ because otherwise when a
>> second
>> > release candidate/the final release becomes available, Maven might stick
>> > with the old rc build in the local .m2.
>> > - pdfboc has been updated to 2.0.29. in the meantime, pdfbox released
>> the
>> > next major release (3.0.0), but I think switching to pdfbox 3 should be
>> > more thoroughly tested and would rather be something for POI 5.3
>> >
>> > > Am 21.09.2023 um 23:58 schrieb PJ Fanning :
>> > >
>> > > https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.4.txt
>> >
>> > -
>> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
>> > For additional commands, e-mail: dev-h...@poi.apache.org
>> >
>> >
>>
>

Re: [VOTE] Release Apache POI 5.2.4 (RC1)

[Dominik Stadler]

Hi,

+1 from me, thanks P.J.!

Large-scale regression testing looks good, only very very few regressions
for more than 3mio documents ( ~0.02% ), most are caused by slightly
stricter handling (more than 1000 compressed files, more than 300 nested
children), a few remaining cases which we can take a look after release.
Results are at
http://people.apache.org/~centic/poi_regression/reports/index523RC1to524RC1.html
and
http://people.apache.org/~centic/poi_regression/reportsAll/index523RC1to524RC1.html

Difference between source-packages from 5.2.3 and 5.2.4 looks good.

Building from sources works locally.

Upgrading projects to 5.2.4RC1 from the staging Maven repository did work
fine, all tests passing.


I added a note in the changelog about the removed binary packages, but if
possible we should also add a bit more description about this in the
announcement email. I think it may disrupt how some people integrate poi
and thus may be worth to note in the release notes/announcement as well.
I.e. "either build it yourself or download the binaries from Maven Central"

Regards... Dominik.

On Fri, Sep 22, 2023 at 9:26 PM Tim Allison  wrote:

> +1
>
> Reports are here:  There's surprisingly little difference:
> https://corpora.tika.apache.org/base/reports/poi-reports.tgz
>
> I only had time to glance briefly.
>
> Thank you PJ and team!
>
> On Fri, Sep 22, 2023 at 4:09 AM PJ Fanning 
> wrote:
>
> > Thanks Alex. The pdfbox issue is tracked at
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=67023 and includes a link
> > to what is blocking our upgrade.
> >
> > In terms of the version names of the jars - the ASF has a rule that you
> > must release what has been voted on. That means I can't create 5.2.4-RC1
> > jars - get those voted on and then go off and rebuild 5.2.4 jars without
> > having those voted on. The jars are not in Maven Central yet, they are
> in a
> > staging area. Anyone who tests the staging jars will need to consider
> > cleaning out their local jar caches (e.g. their Maven local cache) after
> > they test the staging jars. Only a small number of POI reviewers will use
> > the staging jars.
> >
> >
> >
> >
> >
> >
> > On Friday 22 September 2023 at 04:05:48 IST, Axel Howind 
> > wrote:
> >
> >
> >
> >
> >
> > +1 for the release.
> >
> > I just built and tested one of my own projects with the RC and everything
> > seems to work just fine.
> >
> > Two notes:
> > - I think release candidates should be published with an "rc“ in the
> > version string, something like "5.3.4-rc1“ because otherwise when a
> second
> > release candidate/the final release becomes available, Maven might stick
> > with the old rc build in the local .m2.
> > - pdfboc has been updated to 2.0.29. in the meantime, pdfbox released the
> > next major release (3.0.0), but I think switching to pdfbox 3 should be
> > more thoroughly tested and would rather be something for POI 5.3
> >
> > > Am 21.09.2023 um 23:58 schrieb PJ Fanning :
> > >
> > > https://dist.apache.org/repos/dist/dev/poi/RELEASE-NOTES-5.2.4.txt
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >
>

Re: DirectoryNode's getEntry() and IllegalArgumentException

[Dominik Stadler]

Hi,

Seems I added this back in 2019, but I cannot remember why :(.

Commit-message says "Adjust handling of some exceptions in regression tests"

I assume I tried to give more user-readable error messages for cases where
a document has an incorrect extension.

Dominik.


On Fri, Sep 22, 2023 at 3:04 PM Tim Allison  wrote:

> All,
>   First, I'm not proposing any changes for 5.2.4 (many thanks PJ for
> running the release!).
>
>   In looking at DirectoryNode's getEntry, I see this:
>
> @Override
> public Entry getEntry(final String name) throws FileNotFoundException {
> Entry rval = null;
>
> if (name != null) {
> rval = _byname.get(name);
> }
> if (rval == null) {
> // throw more useful exceptions for known wrong file-extensions
> if(_byname.containsKey("Workbook")) {
> throw new IllegalArgumentException("The document is really
> a XLS file");
> } else if(_byname.containsKey("PowerPoint Document")) {
> throw new IllegalArgumentException("The document is really
> a PPT file");
> } else if(_byname.containsKey("VisioDocument")) {
> throw new IllegalArgumentException("The document is really
> a VSD file");
> }
>
> // either a null name was given, or there is no such name
> throw new FileNotFoundException("no such entry: \"" + name
> + "\", had: " + _byname.keySet());
> }
> return rval;
> }
>
> I blindly copied this logic into getEntryCaseInsenstive.  Does anyone
> remember/know how the IllegalArgumentExceptions are more useful than
> the FNFE?
>
> If this is a general DirectoryNode for OLE2, shouldn't an fnfe be the
> right answer no matter whether its a ppt or xls or vsd?
>
> Thank you!
>
> Best,
>
> Tim
>

Re: poi 5.2.4 release

[Dominik Stadler]

Hi,

Yes, I agree, a release soon would be good to get the many many
improvements out to users.

P.J., could you run the process once more and maybe update documentation
along the way so others can do it as well in the future? Not sure how
up-to-date
https://svn.apache.org/repos/asf/poi/site/src/documentation/release-guide.txt
is to the actual current steps?

I can trigger a regression-run of the large corpus over the weekend to see
which regressions may have creeped in.

Thanks... Dominik.


On Wed, Sep 20, 2023 at 9:32 PM PJ Fanning  wrote:

> Should we be looking at doing a POI 5.2.4 release soon? It's about a year
> since the 5.2.3 release and we have quite a backlog of changes in trunk.
> There also some lib changes where CVEs have been issued with those
> downstream libs (eg commons-compress).
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: POI5.2.3 latest JAR to DLL

[Dominik Stadler]

Hi,

there is no "dll" provided as part of Apache POI. Not sure how you try to
get a "dll" from a JAR.

If you are actually looking for NPOI, then take a look at
https://github.com/nissl-lab/npoi as it is a fully separate project
developed independently there.

Otherwise I am not sure what functionality you try to use here and thus
likely we cannot help much here.

Thanks... Dominik.

On Fri, Jun 30, 2023 at 1:55 PM Sharma, Bhumika 
wrote:

> Hi Team,
>
>
>
> When I am converting latest JAR file from IKVM to dll. It does not contain
> proper code.
>
> I need to update with the latest POI dll. Please guide me or let me know
> the path from where I can get the latest POI dll for my C# code.
>
>
>
>
>
>
>
> Early response will be highly appreciated. Thanks!
>
>
>
> Thanks & Regards
>
> Bhumika Sharma
>
> APP DEV & SUPPORT ENGINEER III
>
>
>

Re: POI Java 8 CI builds failing

[Dominik Stadler]

Hi,

please note that setting the property likely has no effect with the
additional jar-file and options. You need to download the corresponding
jar-file and add the -Xbootclasspath option to actually switch rendering,
see e.g.
https://github.com/centic9/poi-benchmark/blob/master/src/jmh/java/org/apache/poi/benchmark/suite/BaseBenchmark.java#LL143C1-L143C1

But simply starting to deprecate JDK 8 for the next version is fine with me
as setting this up properly proved to be very error-prone because it is not
failing, but silently ignores missing stuff and silently falls back to the
broken renderer.

Regards... Dominik.


On Sun, May 14, 2023 at 12:58 PM PJ Fanning  wrote:

> Thanks Dominik. I changed the poi-ooxml gradle file for JDK8 to use
> MarlinRenderingEngine in tests. I think that helped a little. The builds
> seemed to hang in random places before.
>
> The remaining issue appears to be the poi-integration tests. I disabled
> them for JDK8 (again in the gradle file for that subdir). The CI builds are
> now clean.
>
> If someone wants to experiment and find which file(s) is causing the
> poi-integration JDK8 test issues, feel free to do so. The key thing is that
> poi-integration tests run ok on newer JDKs so we have coverage.
>
> On 2023/05/09 18:24:54 Dominik Stadler wrote:
> > Hi,
> >
> > This might be caused by "busy loop hangs" in the Java
> > "PiscesRenderingEngine", I had a similar issue in poi-benchmark
> > <https://github.com/centic9/poi-benchmark> , I solved it by switching to
> > the "MarlinRenderingEngine" as described in the second "Note" at
> > https://poi.apache.org/components/slideshow/ppt-wmf-emf-renderer.html
> >
> > I download the additional jar at
> > https://github.com/centic9/poi-benchmark/blob/master/runBenchmark.sh#L13
> > and patch the build.gradle file at
> >
> https://github.com/centic9/poi-benchmark/blob/master/src/jmh/java/org/apache/poi/benchmark/suite/BaseBenchmark.java#L144
> >
> > Not sure what actually triggers the endless-loop, maybe a specific
> > patchlevel of the JDK or maybe some timing needs to fall in place.
> >
> > It is really annoying that the JDK 8 does not seem to get a fix for this
> > any more.
> >
> > We could try to make this a "permanent" in our tests, but it would add
> even
> > more complexity to the build.
> >
> > Another option that I am considering is to discontinue support for JDK 8
> > and only support JDK 11+ to be able to remove quite some build-logic.
> >
> >
> > Regards... Dominik.
> >
> >
> > On Tue, May 9, 2023 at 5:59 PM PJ Fanning 
> > wrote:
> >
> > > Hi everyone,
> > >
> > > The CI builds are passing with newer Java versions (11 and 17) but
> failing
> > > with Java 8. The builds seem to crash and timeout.
> > >
> > > https://ci-builds.apache.org/job/POI/
> > >
> > > I can't reproduce the issues on my laptop.
> > >
> > > I raised https://issues.apache.org/jira/browse/INFRA-24362 but didn't
> get
> > > much info from it.
> > >
> > > Anyone have any ideas on how to proceed?
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > > For additional commands, e-mail: dev-h...@poi.apache.org
> > >
> > >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: POI Java 8 CI builds failing

[Dominik Stadler]

Hi,

This might be caused by "busy loop hangs" in the Java
"PiscesRenderingEngine", I had a similar issue in poi-benchmark
 , I solved it by switching to
the "MarlinRenderingEngine" as described in the second "Note" at
https://poi.apache.org/components/slideshow/ppt-wmf-emf-renderer.html

I download the additional jar at
https://github.com/centic9/poi-benchmark/blob/master/runBenchmark.sh#L13
and patch the build.gradle file at
https://github.com/centic9/poi-benchmark/blob/master/src/jmh/java/org/apache/poi/benchmark/suite/BaseBenchmark.java#L144

Not sure what actually triggers the endless-loop, maybe a specific
patchlevel of the JDK or maybe some timing needs to fall in place.

It is really annoying that the JDK 8 does not seem to get a fix for this
any more.

We could try to make this a "permanent" in our tests, but it would add even
more complexity to the build.

Another option that I am considering is to discontinue support for JDK 8
and only support JDK 11+ to be able to remove quite some build-logic.


Regards... Dominik.


On Tue, May 9, 2023 at 5:59 PM PJ Fanning 
wrote:

> Hi everyone,
>
> The CI builds are passing with newer Java versions (11 and 17) but failing
> with Java 8. The builds seem to crash and timeout.
>
> https://ci-builds.apache.org/job/POI/
>
> I can't reproduce the issues on my laptop.
>
> I raised https://issues.apache.org/jira/browse/INFRA-24362 but didn't get
> much info from it.
>
> Anyone have any ideas on how to proceed?
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Apply "setQuotePrefixed(true)" automatically

[Dominik Stadler]

Hi,

I would fully wrap Apache POI in a clean set of interfaces/factories and
this way only provide the minimum necessary methods.

If you have lots of existing code, maybe you can style it in a similar way
to keep required code-changes small.

Otherwise there is always a way to access underlying "CT" objects and thus
alter content in unpredictable ways.

Static code checkers like "forbidden-apis" and custom rules for it can then
help to prevent anyone from using the underlying code directly.

Regards... Dominik.

On Thu, May 4, 2023 at 2:49 PM PJ Fanning 
wrote:

> Why don't you refactor your code so that there is a method to make one
> cell safe? Your XSSF commit code can still call the make one cell safe
> method. With SXSSF, you can call that method every time you add a new cell
> to an SXSSF row.
>
> This sort of stuff is better going to stackoverflow btw. There are many
> more people on that than there is on this mailing list.
>
>
>
>
>
>
> On Thursday 4 May 2023 at 13:14:22 IST, Tobias Fink 
> wrote:
>
>
>
>
>
> Hi,
>
> We have a project with quite a big codebase and I'm looking for a way to
> implement a security-feature, where the "setQuotePrefixed(true);"
> style-flag is automatically applied to cells with content that starts with
> a "=" (as these contents would be interpreted as formulars once excel is
> opened and the cell value is changed or pressed enter on unchanged).
> We already have a class that produces "clean" instances of XSSFWorkbook
> (with some core properties nilled out). There I've implemented a method to
> create autofixing workbooks - but this is not working for streaming
> workbooks (SXSSFWorkbook), because these are already streamed out before
> the "commit" method is called.
>
> Do you know how I could implement such a behaviour for SXSSFWorkbooks ?
>
> Thank you and best regards,
>
> Tobias
>
> Heres my code for XSSFWorkbooks:
>
> public static XSSFWorkbook createCleanXSSFWorkbook(InputStream is) throws
> IOException
> {
> XSSFWorkbook wb=new XSSFWorkbook(is){
>   @Override
>   protected void commit() throws IOException
>   {
>   applySafeCellStyles(this);
>   super.commit();
>   }
> };
> cleanXSSFMetaInformation(wb);
> return wb;
> }
>
> private static void applySafeCellStyles(Workbook wb)
> {
> int sheets = wb.getNumberOfSheets();
> Map styleToSafeStyleMap = new
> HashMap<>();
> for (int sheetNumber = 0; sheetNumber < sheets;
> sheetNumber++)
> {
>   Sheet sheet = wb.getSheetAt(sheetNumber);
>   for (Row row : sheet)
>   {
>   for (Cell cell : row)
>   {
>   if
> (cell.getCellType() == CellType.STRING)
>   {
>
> String cellValue = cell.getStringCellValue();
>
> if (cellValue.startsWith("="))
>
> {
>
> CellStyle thisCellStyle = cell.getCellStyle();
>
> CellStyle safeCellStyle =
> styleToSafeStyleMap.get(thisCellStyle);
>
> if (safeCellStyle == null)
>
> {
>
> safeCellStyle = wb.createCellStyle();
>
>
> safeCellStyle.cloneStyleFrom(thisCellStyle);
>
> safeCellStyle.setQuotePrefixed(true);
>
> styleToSafeStyleMap.put(thisCellStyle,
> safeCellStyle);
>
> }
>
>
> cell.setCellStyle(safeCellStyle);
>
> }
>   }
>   }
>   }
> }
> }
>
> Freundliche Grüße
>
> Tobias Fink
> Software Development
>
> Tel.: +49(0)621 - 520078 - 0 -- Fax: +49(0)621 - 520078 - 20
> E-Mail: i...@fasihi.net
>
> Fasihi GmbH - Ludwig-Reichling-Straße 6 - 67059 Ludwigshafen
> Geschäftsführer Saeid Fasihi, Rolf Lutzer - Firmensitz Ludwigshafen a. Rh.
> Amtsgericht Ludwigshafen - HRB 60601
>
>
> -
> Preisträger Großer Preis des Mittelstandes 2014
> Innovationspreisträger Rheinland-Pfalz 2011
> -
> Besuchen Sie uns auch unter
> Das Digitale Assistenzsystem: https://das-assistenzsystem.de/
> Fasihi eXperience Platform:  https://fxp.fasihi.net/
> Homepage: http://www.fasihi.net
> Unsere Hinweise zum Datenschutz finden Sie hier: Datenschutzerklärung
> Fasihi 

Re: Feedback components/index.html

[Dominik Stadler]

Hi,

Thanks for the note, should be adjusted now along some other versions which
were outdated, see
https://svn.apache.org/viewvc?view=revision=1909344

Thanks... Dominik.

On Thu, Apr 20, 2023 at 7:22 PM Fernando Teixeira Barros <
fernando.tbar...@gmail.com> wrote:

> Hello guys!
> There is an error with a link do xmlbeans lib. It's tied to 5.0.1 version,
> but in this version there is an error with POI 5.2.3.
> So it should be 5.1.1.
> The wrong link is
> https://search.maven.org/#artifactdetails|org.apache.xmlbeans|xmlbeans|5.0.1|jar
> :
> [image: image.png]
> And the link above it it's wrong too.
>
> --
> github.com/FernandoTBarros
> Fernando Teixeira Barros
>

Re: POI PMC roll call

[Dominik Stadler]

Hi,

You can take a look at https://poi.apache.org/devel/index.html for
documentation, please let us know if you get stuck on the way.

Regards... Dominik


On Wed, Mar 8, 2023 at 11:48 AM Kamal Chandrashekar 
wrote:

> sry team pls assist me in setting up the code I will try my best.
>
> On Sun, Mar 5, 2023, 4:06 AM a...@dua3.com  wrote:
>
> > Hi,
> > I don’t find much time to contribute. I look into the dev list from time
> > to time and occasionally respond or comment on issues, but it has been
> some
> > time since I last contributed any code. Reason is that my current dayjob
> > does not involve POI anymore and in the remaining time I am preparing to
> > start a small company which has now become my “nightjob”. So I might
> > occasionally make a small contribution, and there might be a moment when
> I
> > will find more time for POI again, but I have no idea when that will be.
> > Regards,
> > Axel
> >
> >
> >
>

Re: thread locals in POI code

[Dominik Stadler]

Yes, the first approach ended in dependency-conflicts.

Thus my current approach for POI uses a small static registry of
"cleaners", so each class which is using thread-locals registers itself for
cleaning and thus the dependency from scratchpad, ooxml, ... to the core
"poi" is properly handled.

Thanks... Dominik.


On Fri, Mar 10, 2023 at 8:37 PM PJ Fanning 
wrote:

> Thanks Dominik - seems like a valid solution. Ideally, there would be
> separate ThreadLocalUtil-like classes for poi-ooxml and poi-scratchpad
> (XSSF vs HSSF) - and probably poi main jar too.
>
> I was thinking myself more along the lines of supporting a flag to turn
> off the use of ThreadLocals (not the default mode, an opt in). This could
> still be added as a separate util method. I think this latter mode will
> prove use once Virtual Threads become more common.
>
>
>
>
>
>
> On Friday 10 March 2023 at 12:51:40 GMT+1, Dominik Stadler <
> dominik.stad...@gmx.at> wrote:
>
>
>
>
>
> Hi,
>
> Some of them likely have had a valid use-case and would at least cause
> performance issues if removed.
>
> The issues from Tomcat or other WebServers usually come because they check
> if memory is lingering at the point when the thread is "given back" to a
> global pool.
>
> XmlBeans also uses ThreadLocals and there were similar reports some time
> ago. There we provide
>
> https://github.com/apache/xmlbeans/blob/trunk/src/main/java/org/apache/xmlbeans/ThreadLocalUtil.java
> which allows to clean out all ThreadLocals in the current thread and can be
> used in a Web-Application to release stuff at the end if necessary.
>
> I would propose to provide a similar util for POI, I even have an initial
> version of it, but never managed to finish it. Unless you object I can tidy
> it up and add it as solution for anyone having issues with threadlocals.
>
> Dominik.
>
> On Wed, Mar 8, 2023 at 10:09 PM PJ Fanning 
> wrote:
>
> > Hi everyone,
> >
> > We have a lot of open issues about ThreadLocals.
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=66521 was opened today.
> >
> > With Virtual Threads (aka Project Loom), ThreadLocals seem like a bad
> > solution.
> >
> > I've looked at the ThreadLocals in POI a few times and have always
> > struggled to see what they really achieve.
> >
> > Would anyone object if we just simply remove them all?
> >
> > Interacting with individual HSSFWorkbook, XSSFWorkbook and their
> > equivalents using multiple threads seems to be something that we don't
> test
> > much and we could simply say it's a bad idea. Sure, being able to produce
> > multiple separate docs with separate threads is definitely something we
> > want.
> >
> > Does anyone have any thoughts?
> >
> > Regards,
> > PJ
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: thread locals in POI code

[Dominik Stadler]

Hi,

Some of them likely have had a valid use-case and would at least cause
performance issues if removed.

The issues from Tomcat or other WebServers usually come because they check
if memory is lingering at the point when the thread is "given back" to a
global pool.

XmlBeans also uses ThreadLocals and there were similar reports some time
ago. There we provide
https://github.com/apache/xmlbeans/blob/trunk/src/main/java/org/apache/xmlbeans/ThreadLocalUtil.java
which allows to clean out all ThreadLocals in the current thread and can be
used in a Web-Application to release stuff at the end if necessary.

I would propose to provide a similar util for POI, I even have an initial
version of it, but never managed to finish it. Unless you object I can tidy
it up and add it as solution for anyone having issues with threadlocals.

Dominik.

On Wed, Mar 8, 2023 at 10:09 PM PJ Fanning 
wrote:

> Hi everyone,
>
> We have a lot of open issues about ThreadLocals.
> https://bz.apache.org/bugzilla/show_bug.cgi?id=66521 was opened today.
>
> With Virtual Threads (aka Project Loom), ThreadLocals seem like a bad
> solution.
>
> I've looked at the ThreadLocals in POI a few times and have always
> struggled to see what they really achieve.
>
> Would anyone object if we just simply remove them all?
>
> Interacting with individual HSSFWorkbook, XSSFWorkbook and their
> equivalents using multiple threads seems to be something that we don't test
> much and we could simply say it's a bad idea. Sure, being able to produce
> multiple separate docs with separate threads is definitely something we
> want.
>
> Does anyone have any thoughts?
>
> Regards,
> PJ
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: POI PMC roll call

[Dominik Stadler]

I'm still following along and look at the odd bug-report from time to time.
I can keep the PMC-stuff like board reports going as it is fairly
low-effort anyway.

As my $dayjob is unrelated since a long time, I will mostly spend time on
topics which spur my personal interest, e.g. mass-regression testing,
fuzzing, sometimes tricky bug-fixes, ...

Dominik.


On Fri, Mar 3, 2023 at 9:52 PM Tim Allison  wrote:

> Similar to Nick and others. I have time to pay attention, but not as
> much as I'd like to contribute.  Always hopeful...  So, y, I'm still
> interested.  Thank you for calling roll and all of your work on POI
> and beyond!
>
> On Fri, Mar 3, 2023 at 12:06 PM Nick Burch  wrote:
> >
> > On Fri, 3 Mar 2023, PJ Fanning wrote:
> > > Apologies if anyone thinks I'm going in the wrong direction here. The
> > > TLDR is: I am asking if PMC members could respond with whether they are
> > > still interested in working on POI or if they are no longer in a
> > > position to help.
> >
> > Still here, still watching, but I don't currently have any ringfenced
> time
> > for open source work in my $DAYJOB so it's quite variable how much time
> > I've got free to give at any point.
> >
> > Happy to help mentor some new people towards committership, if there's
> any
> > candidates, as that (long term) gives more benefit for the time invested
> > :)
> >
> > Nick
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: xmlbeans bin artifact

[Dominik Stadler]

Hi,

I did take a quick look at artifact xmlbeans-bin-5.1.2-SNAPSHOT-20230225.tgz


In the binary-packge, the existing NOTICE/LICENSE are enhanced with more
content and look good from a lay-man's point of view. If you would like a
review from a legal/licensing standpoint, maybe
https://www.apache.org/legal/ can give some more information and
legal-discuss@
 may
be the place to ask specific questions.

Regards... Dominik.




On Fri, Feb 24, 2023 at 12:28 AM PJ Fanning 
wrote:

> I've updated xmlbeans to have LICENSE-binary.txt and NOTICE-binary.txt
> that better describe what appears in the bin distributions, including the
> 3rd party jars we include in the zip/tgz files.
>
> I'd appreciate if POI contributors could review the changes.
> https://ci-builds.apache.org/job/POI/job/POI-XMLBeans-DSL-1.8/ has the
> latest build.
>
>
>
>
> On Thursday 9 February 2023 at 02:17:28 GMT+1, PJ Fanning
>  wrote:
>
>
>
>
>
> Hi everyone,
> I must admit that the correctness of the LICENSE/NOTICE files in our
> releases has never been my highest priority. My assumption was that the
> files were already up to date.
>
> In the last few months, I've been involved with getting Apache Pekko
> ramped up as an Incubator podling and a lot of the requirements coming our
> way relate to getting the licenses correct.
> From what I've seen there, I'm starting to wonder if we might need to look
> again at the licenses/notices in some of the POI and XMLBeans artifacts.
>
> I've just downloaded xmlbeans-bin-5.1.1-20220819.zip and its NOTICE lists
> a few dependencies but not everything. The LICENSE makes no mention of
> other jars. There are over 10 non-XMLBeans jars shipped in this zip. Most
> are Apache licensed and there is an argument not to list them but one
> example of a non-Apache licensed jar is slf4j-api (MIT licensed).
>
> Does anyone have any expertise or confidence that they understand the
> LICENSE/NOTICE requirements well enough to review what we have in XMLBeans
> and POI?
>
> A lot of other ASF projects have LICENSE-binary (spark example [1]) and
> NOTICE-binary files that list long lists of transitive dependencies and
> their licenses. Should we follow suit?
>
> Regards,
> PJ
>
> [1] https://github.com/apache/spark/blob/master/LICENSE-binary
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache POI 5.2.3 release (RC1)

[Dominik Stadler]

Hi,

Mass-regression tests look good, only new 11 failures compared to 5.2.0,
seems we are slightly more picky about missing columns in xlsx-tables or
some new features trigger this now.

See
http://people.apache.org/~centic/poi_regression/reports/index520RC1to523RC1.html
for "diff" to 5.2.0 and
http://people.apache.org/~centic/poi_regression/reportsAll/index520RC1to523RC1.html
for full results.

Also compared the contents of the jar-files, everything seems proper
compared to previous releases.

So I am +1

Thanks... Dominik.

P.S.: not relevant for release, but it seems we include "poi-javadoc" in
the bin-tgz/zip since a long time. Seems a "poi-*.jar" selects this one. We
should remove this from the bin-package for future releases.


On Fri, Sep 9, 2022 at 10:51 PM PJ Fanning 
wrote:

> Hi everyone,
>
> The Apache POI project is pleased to announce the release of POI 5.2.3.
> Featured are a handful of new areas of functionality, and numerous bug
> fixes.
>
> See the downloads page for binary and source distributions:
> https://poi.apache.org/download.html
>
>
> Release Notes
>
> Changes
> 
> The most notable changes in this release are:
>
> * upgrade dependencies: log4j-api 2.18.0, xmlbeans 5.1.1, xmlsec 3.0.0,
> graphics2d 0.40, pdfbox 2.0.26 ...
> * Avoid some more possible overly large memory allocations on certain
> input documents
> * Support capitalized text in WordExtractors [#63575,#63576]
> * Fix issues with some Excel functions
> [#65988,#66022,#66047,#66087,#66098,#66181]
> * Support more Excel functions
> [#github-330,#58468,#66083,#66090,#66092,#66093,#66094,#66095,#66097,#66105]
> * Shifting Excel rows or columns can damage formulas in tables [#66215]
> * Some Password protected XLS files are not rea [#66115]
> * SXSSF doesn't update dimension field [#65562]
> * SXSSFWorkbook should work even when fonts not installed on OS [#66230]
> * Issue with orphaned (in package) images and notes post slide removal
> [#66242]
> * Issues with XSSFTables [#66211,#66212,#66213]
>
>
> A full list of changes is available in the change log:
> https://poi.apache.org/changes.html.
>
> The artifacts are at:
>
> https://dist.apache.org/repos/dist/dev/poi/
>
>
> You can use this maven URL for your mvn/gradle builds:
>
> https://repository.apache.org/content/repositories/staging
>
>
> I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
>
>
> Please vote to release the artifacts. Here is my +1.
>
>
> The vote is open until 2022-09-16 23:00 UTC.
>
> Planned release announcement date is Sunday, 2022-09-17.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: poi 5.2.3 release

[Dominik Stadler]

Hi,

yes, sounds good, I'll also run the big regression testing (
https://github.com/centic9/poi-regression-test) on my large corpus of files
over the next few days

Regards... Dominik.


On Thu, Sep 8, 2022 at 8:14 PM Tim Allison  wrote:

> +1
>
> I'll have time next week to run against our regression corpus, too. If
> there's interest.
>
> On Wed, Sep 7, 2022 at 4:35 PM PJ Fanning 
> wrote:
>
> > Hi everyone,
> >
> > Is it time for new POI release? It's about 6 months since the last one
> and
> > the change list is fairly big - https://poi.apache.org/changes.html
> >
> > I can put together a new RC if team members think there is enough
> capacity
> > to verify it.
> >
> > Regards,
> > PJ
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >
>

Re: [VOTE] Apache XmlBeans 5.1.1 release (RC2)

[Dominik Stadler]

Hi,

Did some verification with the release artifacts:
* Using XmlBeans in Android Applications now works out of the box
* sha512sums match
* file-contents compared to 5.1.0 looks sane

So I am +1 for release!

As always, special thanks to P.J. for rolling the release!

Dominik.

P.S.: A few of the JIRA issues in the release notes are still "open".

On Fri, Aug 19, 2022 at 5:10 PM PJ Fanning 
wrote:

> Hi everyone,
>
> I've prepared artifacts for the release of Apache XmlBeans 5.1.1 (RC2).
> This is built with Java 8.
>
>
> The most notable changes in this release are:
>
> * Adjust Class loading to allow using XMLBeans on Android
> * Performance enhancement for interface extension generation
> * Remove xstc tool
> * Upgrade dependencies (javaparser-core 3.24.4, Saxon-HE 11.4, log4j-api
> 2.18.0)
>
>
> A full list of changes is available in the change log:
>
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10436=12351806
>
>
> https://issues.apache.org/jira/browse/XMLBEANS-612?jql=project%20%3D%20XMLBEANS%20AND%20fixVersion%20%3D%20%22Version%205.1.1%22
>
>
> The artifacts are at:
>
> https://dist.apache.org/repos/dist/release/poi/xmlbeans/dev/
>
>
> You can use this maven URL for your mvn/gradle builds:
>
> https://repository.apache.org/content/repositories/staging
>
>
> I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
>
>
> Please vote to release the artifacts.
>
>
> The vote is open until 2022-08-26 23:00 UTC.
>
>
> Planned release announcement date is Monday, 2022-08-27.
>
> Here is my +1
>
> PJ
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: xmlbeans 5.1.1 release?

[Dominik Stadler]

Hi,

Sounds good to me!

Thanks... Dominik.

On Mon, Aug 15, 2022 at 12:11 PM PJ Fanning 
wrote:

> Hi everyone,Is it worthwhile doing an XMLBeans 5.1.1 release in prep for a
> POI 5.2.3 release? There is fair backlog of changes to get out for POI but
> it might be nice to get the Android fix for XMLBeans as part of that.
>
>
> https://issues.apache.org/jira/browse/XMLBEANS-612?jql=project%20%3D%20XMLBEANS%20AND%20fixVersion%20%3D%20%22Version%205.1.1%22
>
>
> I can prepare the XMLBeans release if there are no objections.
> Regards,PJ
>
>
>

Re: JDK 19: Rampdown Phase 2 + JavaOne

[Dominik Stadler]

Hi,

FYI, when executing unit-tests of Apache POI against latest JDK 19 and 20
early access builds, I stumbled across a small change in behaviour for very
small double values, I reported https://bugs.openjdk.org/browse/JDK-8291240
to check if this is intended.

Thanks... Dominik.

On Mon, Jul 25, 2022 at 5:03 PM David Delabassee <
david.delabas...@oracle.com> wrote:

> Greetings!
>
> JDK 19 is now in Rampdown Phase Two [1]. The overall feature set is
> frozen. Per the JDK Release Process [2] we now turn our focus to P1 and
> P2 bugs, which can be fixed with approval [3]. Late enhancements are
> still possible, with approval, but the bar is now extraordinarily high [4].
>
> Given the current state of affairs, it is a good time to start testing
> your project(s) on JDK 20 Early-Access builds. To conclude, please make
> sure to check the heads-up below, including the one covering JavaOne!
>
> [1] https://mail.openjdk.org/pipermail/jdk-dev/2022-July/006803.html
> [2] https://openjdk.org/jeps/3
> [3] https://openjdk.org/jeps/3#Fix-Request-Process
> [4] https://openjdk.org/jeps/3#Late-Enhancement-Request-Process
>
>
> ## Heads-up - JavaOne is back!
>
> After a long hiatus, JavaOne is back! From October 17-20 in Las Vegas,
> JavaOne will be jam-packed with hundreds of valuable and actionable
> sessions directly from the experts: learning sessions, tutorials,
> hands-on labs, lightning talks, panels, an unconference, BoF's, etc. The
> full JavaOne content catalog will be released soon. In the meantime,
> make sure to check https://inside.java/javaone/ for more updates.
>
> And if you are planning to attend JavaOne, please ping me. I'd like to
> meet you in person to chat over OpenJDK and the Quality Outreach
> program. And the drinks will be on me!
>
>
> ## Heads-up - JavaFX Media enhancements survey
>
> The JavaFX team is conducting a short survey [5] to gather input on
> potential JavaFX Media enhancements.
> The process is quite simple as the feedback will be collected via the
> openjfx-dev [6] mailing list. So if you are using JavaFX, make sure to
> raise your voice.
>
> [5] https://mail.openjdk.org/pipermail/openjfx-dev/2022-July/034949.html
> [6] https://mail.openjdk.org/mailman/listinfo/openjfx-dev
>
>
> ## JDK 19
>
> JDK 19 Early-Access builds 32 are now available [7], and are provided
> under the GNU General Public License v2, with the Classpath Exception.
> The Release Notes are available here [8].
>
> [7] https://jdk.java.net/19/
> [8] https://jdk.java.net/19/release-notes
>
> ### JEPs integrated to JDK 19:
> - JEP 405: Record Patterns (Preview)
> - JEP 422: Linux/RISC-V Port
> - JEP 424: Foreign Function & Memory API (Preview)
> - JEP 425: Virtual Threads (Preview)
> - JEP 426: Vector API (4th Incubator)
> - JEP 427: Pattern Matching for switch (3rd Preview)
> - JEP 428: Structured Concurrency (Incubator)
>
> ### Recent changes that maybe of interest:
> - JDK-8289127: Apache Lucene triggers: DEBUG MESSAGE: duplicated
> predicate failed which is impossible
> - JDK-8290596: Update java.net.InetAddress to Detect Ambiguous IPv4
> Address Literals
> - JDK-8290615: Remove the Alternate ThreadLocal Implementation of the
> Subject::current and Subject::callAs APIs
> - JDK-8290417: CDS cannot archive lamda proxy with useImplMethodHandle
> - JDK-8287809: Revisit implementation of memory session
> - JDK-8289278: Suspend/ResumeAllVirtualThreads need both can_suspend and
> can_support_virtual_threads
> - JDK-8288589: Files.readString ignores encoding errors for UTF-16
> - JDK-8288425: Footprint regression due MH creation when initializing
> StringConcatFactory
>
>
> ## JDK 20
>
> JDK 20 Early-Access builds 7 are now available [9], and are provided
> under the GNU General Public License v2, with the Classpath Exception.
>
> [9] https://jdk.java.net/20/
>
> ### Recent changes that maybe of interest:
> - JDK-8264999: GeneralPath.lineTo() to itself produces jagged lines
> [Logged by Apache PDFBox]
> - JDK-8284997: arm32 build crashes since JDK-8283326 [Logged by JaCoCo]
> - JDK-8286101: Support formatting in @value tag
> - JDK-8289260: BigDecimal movePointLeft() and movePointRight() do not
> follow their API spec
> - JDK-8287835: Add support for additional float/double to integral
> conversion for x86
> - JDK-8283091: Support type conversion between different data sizes in SLP
> - JDK-8288573: Make Executable.getParameterCount() actually abstract
> - JDK-8266670: Better modeling of access flags in core reflection
> - JDK-8290601: Update java.net.InetAddress to Detect Ambiguous IPv4
> Address Literals
> - JDK-8290334: Update FreeType to 2.12.1
> - JDK-8286030: Avoid JVM crash when containers share the same /tmp dir
> - JDK-8289743: AArch64: Clean up patching logic
> - JDK-8288107: Auto-vectorization for integer min/max
> - JDK-8274235: -Xshare:dump should not call vm_direct_exit
>
>
> ## Topics of Interest:
>
> * What is OpenJDK? - Inside Java Newscast
> https://inside.java/2022/06/30/insidejava-newscast-028/
>
> * 

Re: module-info.class files

[Dominik Stadler]

Hi PJ,

You can run Gradle with "--info :poi:jar" to make it print out details
about why it does or does not run some tasks.

Here it seems an "onlyIf" in the main build.gradle at line 187 is the
culprit. It seems the "onlyIf" here leads to these the "java9" tasks being
skipped always. These were added at some point but things changed later. I
would assume this check can now simply be removed, at least it works if I
remove the three lines completely.

Andi might be able to state details and why this was necessary in the first
place and if it actually became obsolete when he switched the build to
"Gradle toolchains".


Regards... Dominik.

On Mon, Jul 25, 2022 at 1:25 PM PJ Fanning 
wrote:

>  I used the ant build to regen some of the module-info classes. I had to
> change the build.xml to get the compile to work with Java 11.
>
> https://github.com/apache/poi/commit/9626dd0661159b09e3fbeb93a59cf1b8f0cfee60
>
> If anyone knows how to fix the Gradle build or objects to my Ant build
> change, please get in touch.
>
>
> On Monday 25 July 2022 at 11:42:31 IST, PJ Fanning <
> fannin...@yahoo.com> wrote:
>
>  Hi everyone,When using the Gradle build, I've found that the tasks to
> compile the module-info files do not run, even when I use JDK versions
> higher than Java 8. They don't fail, they just get skipped.Something about
> the Gradle toolchain and/or the onlyIf conditions seems to be not working.
> Could someone else have a look?Our checked-in module-info class files are
> important for the Java 8 build - which is what we use for our public
> releases. The class files are out of date.
> Regards,PJ

[jira] [Commented] (XMLBEANS-616) is there a dead lock in loading the SOAP Service Concurrently

[Dominik Stadler (Jira)]

[ 
https://issues.apache.org/jira/browse/XMLBEANS-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566729#comment-17566729
 ] 

Dominik Stadler commented on XMLBEANS-616:
--

This looks very strange and likely unrelated to XmlBeans, all threads report 
being blocked in Object.wait(), even code which is for sure not using any 
waiting/synchronizing/blocking.

Maybe you can reduce this into a reproducible test-case which shows the problem 
with minimal code?

> is there a dead lock in loading the SOAP Service Concurrently
> -
>
> Key: XMLBEANS-616
> URL: https://issues.apache.org/jira/browse/XMLBEANS-616
> Project: XMLBeans
>  Issue Type: Bug
>Reporter: yanglinfu
>Priority: Major
> Attachments: 007337a1-7e50-40bc-ac1f-d2ebd469f095.png, 
> 2a6c2727-50e1-4ccc-a2f5-33abd746117a.png, 
> 40f87ce3-cbcd-495e-9ce7-0ae861a3bdb7.png, 
> b3d30bc4-a060-419a-b990-503b188fe262.png, image-2022-07-14-09-54-42-466.png, 
> image-2022-07-14-09-55-15-029.png, image-2022-07-14-14-04-52-429.png
>
>
> *i have 10 threads to loading the SOAP Service Concurrently,and i find a dead 
> lock in xmlBeans's some  class loading process.*
> Thread1 info:
> "pool-13-thread-9" #120 prio=5 os_prio=0 tid=0x2ae578872800 nid=0x19b4 in 
> Object.wait() [0x2ae5c1814000]
>    java.lang.Thread.State: RUNNABLE
>     at org.apache.xmlbeans.XmlBeans.getNoType(XmlBeans.java:504)
>     at org.apache.xmlbeans.XmlBeans.(XmlBeans.java:517)
>     at 
> org.apache.xmlbeans.impl.schema.XmlObjectFactory.(XmlObjectFactory.java:41)
>     at org.apache.xmlbeans.XmlObject.(XmlObject.java:128)
>     at sun.misc.Unsafe.ensureClassInitialized(Native Method)
>     at 
> sun.reflect.UnsafeFieldAccessorFactory.newFieldAccessor(UnsafeFieldAccessorFactory.java:43)
>     at 
> sun.reflect.ReflectionFactory.newFieldAccessor(ReflectionFactory.java:156)
>     at java.lang.reflect.Field.acquireFieldAccessor(Field.java:1088)
>     at java.lang.reflect.Field.getFieldAccessor(Field.java:1069)
>     at java.lang.reflect.Field.get(Field.java:393)
>  
> Thread2 info :
> "pool-13-thread-1" #112 prio=5 os_prio=0 tid=0x2ae578861800 nid=0x19ab in 
> Object.wait() [0x2ae5c100c000]
>    java.lang.Thread.State: RUNNABLE
>     at 
> org.apache.xmlbeans.impl.schema.SchemaTypeLoaderBase.(SchemaTypeLoaderBase.java:38)
>     at 
> com.***.***.service.QueryRecommendOfferingsReqMsgDocument.(QueryRecommendOfferingsReqMsgDocument.java:23)
>     at sun.misc.Unsafe.ensureClassInitialized(Native Method)
>     at 
> sun.reflect.UnsafeFieldAccessorFactory.newFieldAccessor(UnsafeFieldAccessorFactory.java:43)
>     at 
> sun.reflect.ReflectionFactory.newFieldAccessor(ReflectionFactory.java:156)
>     at java.lang.reflect.Field.acquireFieldAccessor(Field.java:1088)
>     at java.lang.reflect.Field.getFieldAccessor(Field.java:1069)
>     at java.lang.reflect.Field.get(Field.java:393)
>  
> *xmlBeans code analyze*
> 1.the object XmlBeans init is waiting for BuiltinSchemaTypeSystem  inited
> !007337a1-7e50-40bc-ac1f-d2ebd469f095.png!
> 2. BuiltinSchemaTypeSystem  is the sub class of SchemaTypeLoaderBase ,so  
> BuiltinSchemaTypeSystem is inited after SchemaTypeLoaderBase ;
> !b3d30bc4-a060-419a-b990-503b188fe262.png!
> 3. SchemaTypeLoaderBase init is need XmlBeans init in line 38;
>  
> !2a6c2727-50e1-4ccc-a2f5-33abd746117a.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[jira] [Commented] (XMLBEANS-616) is there a dead lock in loading the SOAP Service Concurrently

[Dominik Stadler (Jira)]

[ 
https://issues.apache.org/jira/browse/XMLBEANS-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562806#comment-17562806
 ] 

Dominik Stadler commented on XMLBEANS-616:
--

Are you sure this is a deadlock? A RUNNABLE thread is not blocked by any lock, 
it is rather currently doing work or could do work if CPU would be available, 
so this does not indicate a deadlock.

Can you attach a full thread-dump with all threads so we can take a look? E.g. 
via "jstack ".

> is there a dead lock in loading the SOAP Service Concurrently
> -
>
> Key: XMLBEANS-616
> URL: https://issues.apache.org/jira/browse/XMLBEANS-616
> Project: XMLBeans
>  Issue Type: Bug
>Reporter: yanglinfu
>Priority: Major
> Attachments: 007337a1-7e50-40bc-ac1f-d2ebd469f095.png, 
> 2a6c2727-50e1-4ccc-a2f5-33abd746117a.png, 
> 40f87ce3-cbcd-495e-9ce7-0ae861a3bdb7.png, 
> b3d30bc4-a060-419a-b990-503b188fe262.png
>
>
> *i have 10 threads to loading the SOAP Service Concurrently,and i find a dead 
> lock in xmlBeans's some  class loading process.*
> !40f87ce3-cbcd-495e-9ce7-0ae861a3bdb7.png!
>  
> *xmlBeans code analyze*
> 1.the object XmlBeans init is waiting for BuiltinSchemaTypeSystem  inited
> !007337a1-7e50-40bc-ac1f-d2ebd469f095.png!
> 2. BuiltinSchemaTypeSystem  is the sub class of SchemaTypeLoaderBase ,so  
> BuiltinSchemaTypeSystem is inited after SchemaTypeLoaderBase ;
> !b3d30bc4-a060-419a-b990-503b188fe262.png!
> 3. SchemaTypeLoaderBase init is need XmlBeans init in line 38;
>  
> !2a6c2727-50e1-4ccc-a2f5-33abd746117a.png!
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[jira] [Resolved] (XMLBEANS-612) Adjust Class loading to allow using XMLBeans on Android

[Dominik Stadler (Jira)]

 [ 
https://issues.apache.org/jira/browse/XMLBEANS-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Stadler resolved XMLBEANS-612.
--
Resolution: Fixed

Applied the change via revision r1901904

> Adjust Class loading to allow using XMLBeans on Android
> ---
>
> Key: XMLBEANS-612
> URL: https://issues.apache.org/jira/browse/XMLBEANS-612
> Project: XMLBeans
>  Issue Type: New Feature
>Affects Versions: Version 5.0.3
>        Reporter: Dominik Stadler
>    Assignee: Dominik Stadler
>Priority: Major
> Fix For: Version 5.1.1
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The project [https://github.com/centic9/poi-on-android] allows to run Apache 
> POI as part of Android Apps and thus also uses XMLBeans.
> When trying to update to Apache POI 5.2.2 and XMLBeans 5.1.0, I saw that 
> there is a problem with the Class-loading.
> XMLBeans tries to do the following
> {noformat}
> cl.getResource("xyz.class") {noformat}
> However on Android you cannot get class-resources this way.
> It seems this is only done to prevent a ClassNotFoundException in the call to 
> {{Class.forName}} which follows.
>  
> Therefore I propose to change the code as follows so that we simply expect a 
> ClassNotFoundException instead of doing this separate lookup via getResource()
> {noformat}
> // BEGIN CHANGES 
> =
> //
> // Simply remove this pre-check and handle ClassNotFoundException below
> // as Android does not find .class-files in getResource()
> //
> // See 
> https://stackoverflow.com/questions/72616517/looking-up-class-files-via-classloader-getresource-on-android
> // for a related question
> //
> /*if (cl.getResource(clName.replace(".", "/") + ".class") == null) {
> // if the first class isn't found in the package, continue with the next 
> package
> break;
> }*/
> try {
> @SuppressWarnings("unchecked")
> Class cls = (Class SchemaTypeLoader>) Class.forName(clName, true, cl);
> list.add((SchemaTypeLoader) cls.getDeclaredField("typeSystem").get(null));
> } catch (ClassNotFoundException e) {
> // if the first class isn't found in the package, continue with the next 
> package
> // this can happen and thus is ignored here
> } catch (Exception e) {
> throw new XmlRuntimeException(e);
> }
> // END-CHANGES 
> ={noformat}
>  
> Applying this change locally makes the project work on Android with Apache 
> POI 5.2.2 and XMLBeans 5.1.0.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[jira] [Updated] (XMLBEANS-612) Adjust Class loading to allow using XMLBeans on Android

[Dominik Stadler (Jira)]

 [ 
https://issues.apache.org/jira/browse/XMLBEANS-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Stadler updated XMLBEANS-612:
-
Summary: Adjust Class loading to allow using XMLBeans on Android  (was: 
Adjust Class loading for using XMLBeans on Android)

> Adjust Class loading to allow using XMLBeans on Android
> ---
>
> Key: XMLBEANS-612
> URL: https://issues.apache.org/jira/browse/XMLBEANS-612
> Project: XMLBeans
>  Issue Type: New Feature
>Affects Versions: Version 5.0.3
>        Reporter: Dominik Stadler
>    Assignee: Dominik Stadler
>Priority: Major
> Fix For: Version 5.1.0
>
>
> The project [https://github.com/centic9/poi-on-android] allows to run Apache 
> POI as part of Android Apps and thus also uses XMLBeans.
> When trying to update to Apache POI 5.2.2 and XMLBeans 5.1.0, I saw that 
> there is a problem with the Class-loading.
> XMLBeans tries to do the following
> {noformat}
> cl.getResource("xyz.class") {noformat}
> However on Android you cannot get class-resources this way.
> It seems this is only done to prevent a ClassNotFoundException in the call to 
> {{Class.forName}} which follows.
>  
> Therefore I propose to change the code as follows so that we simply expect a 
> ClassNotFoundException instead of doing this separate lookup via getResource()
> {noformat}
> // BEGIN CHANGES 
> =
> //
> // Simply remove this pre-check and handle ClassNotFoundException below
> // as Android does not find .class-files in getResource()
> //
> // See 
> https://stackoverflow.com/questions/72616517/looking-up-class-files-via-classloader-getresource-on-android
> // for a related question
> //
> /*if (cl.getResource(clName.replace(".", "/") + ".class") == null) {
> // if the first class isn't found in the package, continue with the next 
> package
> break;
> }*/
> try {
> @SuppressWarnings("unchecked")
> Class cls = (Class SchemaTypeLoader>) Class.forName(clName, true, cl);
> list.add((SchemaTypeLoader) cls.getDeclaredField("typeSystem").get(null));
> } catch (ClassNotFoundException e) {
> // if the first class isn't found in the package, continue with the next 
> package
> // this can happen and thus is ignored here
> } catch (Exception e) {
> throw new XmlRuntimeException(e);
> }
> // END-CHANGES 
> ={noformat}
>  
> Applying this change locally makes the project work on Android with Apache 
> POI 5.2.2 and XMLBeans 5.1.0.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[jira] [Commented] (XMLBEANS-612) Adjust Class loading for using XMLBeans on Android

[Dominik Stadler (Jira)]

[ 
https://issues.apache.org/jira/browse/XMLBEANS-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554079#comment-17554079
 ] 

Dominik Stadler commented on XMLBEANS-612:
--

[~pj.fanning] I can do this change, but wanted to get your input if you see any 
problem with catching the ClassNotFoundException instead of the getResource() 
call.

> Adjust Class loading for using XMLBeans on Android
> --
>
> Key: XMLBEANS-612
> URL: https://issues.apache.org/jira/browse/XMLBEANS-612
> Project: XMLBeans
>  Issue Type: New Feature
>Affects Versions: Version 5.0.3
>        Reporter: Dominik Stadler
>    Assignee: Dominik Stadler
>Priority: Major
> Fix For: Version 5.1.0
>
>
> The project [https://github.com/centic9/poi-on-android] allows to run Apache 
> POI as part of Android Apps and thus also uses XMLBeans.
> When trying to update to Apache POI 5.2.2 and XMLBeans 5.1.0, I saw that 
> there is a problem with the Class-loading.
> XMLBeans tries to do the following
> {noformat}
> cl.getResource("xyz.class") {noformat}
> However on Android you cannot get class-resources this way.
> It seems this is only done to prevent a ClassNotFoundException in the call to 
> {{Class.forName}} which follows.
>  
> Therefore I propose to change the code as follows so that we simply expect a 
> ClassNotFoundException instead of doing this separate lookup via getResource()
> {noformat}
> // BEGIN CHANGES 
> =
> //
> // Simply remove this pre-check and handle ClassNotFoundException below
> // as Android does not find .class-files in getResource()
> //
> // See 
> https://stackoverflow.com/questions/72616517/looking-up-class-files-via-classloader-getresource-on-android
> // for a related question
> //
> /*if (cl.getResource(clName.replace(".", "/") + ".class") == null) {
> // if the first class isn't found in the package, continue with the next 
> package
> break;
> }*/
> try {
> @SuppressWarnings("unchecked")
> Class cls = (Class SchemaTypeLoader>) Class.forName(clName, true, cl);
> list.add((SchemaTypeLoader) cls.getDeclaredField("typeSystem").get(null));
> } catch (ClassNotFoundException e) {
> // if the first class isn't found in the package, continue with the next 
> package
> // this can happen and thus is ignored here
> } catch (Exception e) {
> throw new XmlRuntimeException(e);
> }
> // END-CHANGES 
> ={noformat}
>  
> Applying this change locally makes the project work on Android with Apache 
> POI 5.2.2 and XMLBeans 5.1.0.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[jira] [Updated] (XMLBEANS-612) Adjust Class loading for using XMLBeans on Android

[Dominik Stadler (Jira)]

 [ 
https://issues.apache.org/jira/browse/XMLBEANS-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Stadler updated XMLBEANS-612:
-
Description: 
The project [https://github.com/centic9/poi-on-android] allows to run Apache 
POI as part of Android Apps and thus also uses XMLBeans.

When trying to update to Apache POI 5.2.2 and XMLBeans 5.1.0, I saw that there 
is a problem with the Class-loading.

XMLBeans tries to do the following
{noformat}
cl.getResource("xyz.class") {noformat}
However on Android you cannot get class-resources this way.

It seems this is only done to prevent a ClassNotFoundException in the call to 
{{Class.forName}} which follows.

 

Therefore I propose to change the code as follows so that we simply expect a 
ClassNotFoundException instead of doing this separate lookup via getResource()
{noformat}
// BEGIN CHANGES 
=
//
// Simply remove this pre-check and handle ClassNotFoundException below
// as Android does not find .class-files in getResource()
//
// See 
https://stackoverflow.com/questions/72616517/looking-up-class-files-via-classloader-getresource-on-android
// for a related question
//
/*if (cl.getResource(clName.replace(".", "/") + ".class") == null) {
// if the first class isn't found in the package, continue with the next 
package
break;
}*/

try {
@SuppressWarnings("unchecked")
Class cls = (Class) 
Class.forName(clName, true, cl);
list.add((SchemaTypeLoader) cls.getDeclaredField("typeSystem").get(null));
} catch (ClassNotFoundException e) {
// if the first class isn't found in the package, continue with the next 
package
// this can happen and thus is ignored here
} catch (Exception e) {
throw new XmlRuntimeException(e);
}
// END-CHANGES 
={noformat}
 

Applying this change locally makes the project work on Android with Apache POI 
5.2.2 and XMLBeans 5.1.0.

  was:
The project [https://github.com/centic9/poi-on-android] allows to run Apache 
POI as part of Android Apps and thus also uses XMLBeans.

When trying to update to Apache POI 5.2.0, I saw that there is a problem with 
the SAX parser on Android as it fails when both features "namespaces" and 
"namespace-prefix" are set to true.

XMLBeans currently does this in the class {{Locale.SaxLoader}} and thus an 
Android Application crashes with an error "The 'namespace-prefix' feature is 
not supported while the 'namespaces' feature is enabled."

 

Therefore I  will introduce a system property which can be used to control the 
SAX feature "namespace-prefixes" to be able to set it to "false" if required.

 

The full stacktrace is:

 
{noformat}
E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.dstadler.poiandroidtest.poitest, PID: 26552
    java.lang.RuntimeException: Unable to start activity 
ComponentInfo{org.dstadler.poiandroidtest.poitest/org.dstadler.poiandroidtest.poitest.DocumentListActivity}:
 java.lang.IllegalStateException: org.apache.poi.ooxml.POIXMLException: unable 
to parse shared strings table
        at 
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2817)
        at 
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2892)
        at android.app.ActivityThread.-wrap11(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593)
        at android.os.Handler.dispatchMessage(Handler.java:105)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6541)
        at java.lang.reflect.Method.invoke(Native Method)
        at 
com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
     Caused by: java.lang.IllegalStateException: 
org.apache.poi.ooxml.POIXMLException: unable to parse shared strings table
        at 
org.dstadler.poiandroidtest.poitest.DocumentListActivity.onCreate(DocumentListActivity.java:191)
        at android.app.Activity.performCreate(Activity.java:6975)
        at 
android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1213)
        at 
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2770)
        at 
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2892) 
        at android.app.ActivityThread.-wrap11(Unknown Source:0) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593) 
        at android.os.Handler.dispatchMessage(Handler.java:105) 
        at android.os.Looper.loop(Looper.java:164) 
        at android.app.ActivityThread.main(ActivityThread.java:6541) 
        at java.lang.reflect.Me

[jira] [Created] (XMLBEANS-612) Adjust Class loading for using XMLBeans on Android

[Dominik Stadler (Jira)]

Dominik Stadler created XMLBEANS-612:


 Summary: Adjust Class loading for using XMLBeans on Android
 Key: XMLBEANS-612
 URL: https://issues.apache.org/jira/browse/XMLBEANS-612
 Project: XMLBeans
  Issue Type: New Feature
Affects Versions: Version 5.0.3
Reporter: Dominik Stadler
Assignee: Dominik Stadler
 Fix For: Version 5.1.0


The project [https://github.com/centic9/poi-on-android] allows to run Apache 
POI as part of Android Apps and thus also uses XMLBeans.

When trying to update to Apache POI 5.2.0, I saw that there is a problem with 
the SAX parser on Android as it fails when both features "namespaces" and 
"namespace-prefix" are set to true.

XMLBeans currently does this in the class {{Locale.SaxLoader}} and thus an 
Android Application crashes with an error "The 'namespace-prefix' feature is 
not supported while the 'namespaces' feature is enabled."

 

Therefore I  will introduce a system property which can be used to control the 
SAX feature "namespace-prefixes" to be able to set it to "false" if required.

 

The full stacktrace is:

 
{noformat}
E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.dstadler.poiandroidtest.poitest, PID: 26552
    java.lang.RuntimeException: Unable to start activity 
ComponentInfo{org.dstadler.poiandroidtest.poitest/org.dstadler.poiandroidtest.poitest.DocumentListActivity}:
 java.lang.IllegalStateException: org.apache.poi.ooxml.POIXMLException: unable 
to parse shared strings table
        at 
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2817)
        at 
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2892)
        at android.app.ActivityThread.-wrap11(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593)
        at android.os.Handler.dispatchMessage(Handler.java:105)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6541)
        at java.lang.reflect.Method.invoke(Native Method)
        at 
com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
     Caused by: java.lang.IllegalStateException: 
org.apache.poi.ooxml.POIXMLException: unable to parse shared strings table
        at 
org.dstadler.poiandroidtest.poitest.DocumentListActivity.onCreate(DocumentListActivity.java:191)
        at android.app.Activity.performCreate(Activity.java:6975)
        at 
android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1213)
        at 
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2770)
        at 
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2892) 
        at android.app.ActivityThread.-wrap11(Unknown Source:0) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593) 
        at android.os.Handler.dispatchMessage(Handler.java:105) 
        at android.os.Looper.loop(Looper.java:164) 
        at android.app.ActivityThread.main(ActivityThread.java:6541) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at 
com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767) 
     Caused by: org.apache.poi.ooxml.POIXMLException: unable to parse shared 
strings table
        at 
org.apache.poi.ooxml.POIXMLFactory.createDocumentPart(POIXMLFactory.java:68)
        at 
org.apache.poi.ooxml.POIXMLDocumentPart.read(POIXMLDocumentPart.java:661)
        at org.apache.poi.ooxml.POIXMLDocument.load(POIXMLDocument.java:165)
        at 
org.apache.poi.xssf.usermodel.XSSFWorkbook.(XSSFWorkbook.java:274)
        at 
org.apache.poi.xssf.usermodel.XSSFWorkbookFactory.createWorkbook(XSSFWorkbookFactory.java:118)
        at 
org.apache.poi.xssf.usermodel.XSSFWorkbookFactory.create(XSSFWorkbookFactory.java:98)
        at 
org.apache.poi.xssf.usermodel.XSSFWorkbookFactory.create(XSSFWorkbookFactory.java:36)
        at 
org.apache.poi.ss.usermodel.WorkbookFactory.lambda$create$2(WorkbookFactory.java:224)
        at 
org.apache.poi.ss.usermodel.WorkbookFactory$$ExternalSyntheticLambda4.create(Unknown
 Source:2)
        at 
org.apache.poi.ss.usermodel.WorkbookFactory.wp(WorkbookFactory.java:329)
        at 
org.apache.poi.ss.usermodel.WorkbookFactory.create(WorkbookFactory.java:224)
        at 
org.apache.poi.ss.usermodel.WorkbookFactory.create(WorkbookFactory.java:185)
        at 
org.dstadler.poiandroidtest.poitest.DocumentListActivity.onCreate(DocumentListActivity.java:81)
        at android.app.Activity.performCreate(Activity.java:6975) 
        at 
android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1213) 
        at 
android.app.ActivityThr

Re: [VOTE] Apache XmlBeans 5.1.0 release (RC4)

[Dominik Stadler]

Hi,

looks all good now, +1 from me, thanks for adjusting/improving the build
until we can do another high-quality release!

Thanks... Domink.

On Sun, Jun 5, 2022 at 5:20 PM PJ Fanning 
wrote:

> Hi everyone,
>
> I've prepared artifacts for the release of Apache XmlBeans 5.1.0 (RC4).
> This is built with Java 8.
>
> One thing to watch out for is in the src artifacts now should be built
> with gradle - instead of ant.
>
> The most notable changes in this release are:
>
> * create temp files using java.nio.files.Files
> * Line breaks in base64binary caused a validation error
> * Improve support for using XMLBeans on Android by not relying on the
> namespace-prefixes feature on the XML SAX parser
> * Use generics in Collections
> * GDate can return diferent values on different current timezones
> * Migrate ant build to gradle
> * change version code so that the value is automatically generated
> * Make XmlCursor AutoCloseable
> * Fix some problems with XMLBeans Extension Interfaces Feature
> * Inner Class Handler was not supported
> * When specifying user types in an xsdconfig, types that are not being
> compiled could not be referenced properly
> * Make XSD documentation parsing lazy
> * Upgrade dependencies (javaparser 3.24.2, Saxon-HE 11.3, log4j-api 2.17.2)
>
> A full list of changes is available in the change log:
>
> https://issues.apache.org/jira/projects/XMLBEANS/versions/12351143
>
> The artifacts are at:
>
> https://dist.apache.org/repos/dist/release/poi/xmlbeans/dev/
>
> You can use this maven URL for your mvn/gradle builds:
>
> https://repository.apache.org/content/repositories/staging
>
>
>
> I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
>
> Please vote to release the artifacts.
>
> The vote is open until 2022-06-12 23:00 UTC.
>
> Planned release announcement date is Monday, 2022-06-13.
>
>
> Here is my +1
>
> PJ
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache XmlBeans 5.1.0 release (RC3)

[Dominik Stadler]

Hi,

File-contents looks good now, but it seems they now contain Java 11
class-files.

Are we missing some "Keep Java 8 compatibility" in the Gradle build or do
we rather need to use the Java 8 artefacts for release?

If i use the newer build from
https://repository.apache.org/content/repositories/staging in Apache POI I
get:

> Task :poi-ooxml-lite-agent:compileJava FAILED
/opt/apache/poi/git-svn/poi-ooxml-lite-agent/src/main/java/org/apache/poi/ooxml/lite/OOXMLLiteAgent.java:40:
error: cannot access org.apache.xmlbeans.impl.schema.SchemaTypeSystemImpl
import org.apache.xmlbeans.impl.schema.SchemaTypeSystemImpl;
 ^
 bad class file:
/home/user/.gradle/caches/modules-2/files-2.1/org.apache.xmlbeans/xmlbeans/5.1.0/4b50c9b21dc3ba2e8e92e50fa901bf36eb9304d4/xmlbeans-5.1.0.jar(org/apache/xmlbeans/impl/schema/SchemaTypeSystemImpl.class)

   class file has wrong version 55.0, should be 52.0
   Please remove or make sure it appears in the correct subdirectory of the
classpath.

> Task :poi-ooxml-lite:compileOoxmlLite




Thanks... Dominik.


On Sun, Jun 5, 2022 at 11:19 AM PJ Fanning 
wrote:

> Hi everyone,
>
> I've prepared artifacts for the release of Apache XmlBeans 5.1.0 (RC3).
>
> One thing to watch out for is in the src artifacts now should be built
> with gradle - instead of ant.
>
>
> The most notable changes in this release are:
>
> * create temp files using java.nio.files.Files
> * Line breaks in base64binary caused a validation error
> * Improve support for using XMLBeans on Android by not relying on the
> namespace-prefixes feature on the XML SAX parser
> * Use generics in Collections
> * GDate can return diferent values on different current timezones
> * Migrate ant build to gradle
> * change version code so that the value is automatically generated
> * Make XmlCursor AutoCloseable
> * Fix some problems with XMLBeans Extension Interfaces Feature
> * Inner Class Handler was not supported
> * When specifying user types in an xsdconfig, types that are not being
> compiled could not be referenced properly
> * Make XSD documentation parsing lazy
> * Upgrade dependencies (javaparser 3.24.2, Saxon-HE 11.3, log4j-api 2.17.2)
>
>
> A full list of changes is available in the change log:
>
> https://issues.apache.org/jira/projects/XMLBEANS/versions/12351143
>
> The artifacts are at:
>
> https://dist.apache.org/repos/dist/release/poi/xmlbeans/dev/
>
> You can use this maven URL for your mvn/gradle builds:
>
> https://repository.apache.org/content/repositories/staging
>
>
>
> I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
>
>
> Please vote to release the artifacts.
>
>
> The vote keeps open until 2022-06-12 23:00 UTC.
>
> Planned release announcement date is Monday, 2022-06-13.
>
>
> Here is my +1
>
> PJ
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache XmlBeans 5.1.0 release (RC1)

[Dominik Stadler]

I quickly tried to fix/adjust a few things, maven-xml-version and java9
folders should be fine now, maybe you can roll a RC2 with those to see if
we are good now.

Thanks... Dominik.


On Sat, Jun 4, 2022 at 9:25 AM Dominik Stadler 
wrote:

> Hi PJ,
>
> that already looks better, the "version" folder is now in place.
>
> but still a few things that I am not sure about:
>
> * the maven plugin.xml and pom.xml under "maven" do not have a version
> set, but rather @VERSION@
> * We seem to duplicate the class to the "org" folder in META-INF, but that
> is probably not causing any issues
> * log4j-core is not included any more in the "bin" distribution
>
> I'll see if I manage a quick glance at the build.gradle stuff, but maybe
> Andi can take a look as he did this for the Apache POI side as well and
> thus seems to know the most about this topic...
>
>
> Thanks... Dominik.
>
>
> On Fri, Jun 3, 2022 at 8:04 PM PJ Fanning 
> wrote:
>
>> Hi Dominik,
>> I changed the gradle build and I think the CI build for Java 11 is closer
>> to what is needed. The build produces Java 8 compatible classes.
>>
>> Could you have a look at the jar in
>> https://ci-builds.apache.org/job/POI/job/POI-XMLBeans-DSL-1.11/56/  ?
>>
>> If that one looks ok, I can produce an RC2 based on that build.
>>
>>
>>
>>
>> On Friday 3 June 2022, 16:46:47 IST, PJ Fanning
>>  wrote:
>>
>>
>>
>>
>>
>> Doesn't look right. I wasn't involved in the Gradle changes for XmlBeans
>> but the jar doesn't seem right. The licenses/notices are there but have
>> moved to META-INF. I think this is ok. But the missing META-INF/versions/9
>> is an issue that blocks the release. Even the jars built with Java 11 are
>> missing this.
>>
>> So -1 from me for the RC1. I will see what can be done to get an RC2
>> together but Gradle is not an area of expertise for me.
>>
>>
>>
>>
>>
>>
>> On Friday 3 June 2022, 16:04:46 IST, Dominik Stadler <
>> dominik.stad...@gmx.at> wrote:
>>
>>
>>
>>
>>
>> Hi,
>>
>> As always, thanks PJ for preparing the release!
>>
>> I compared release artifacts and the contents of directory META-INF in
>> the main jar-file is fairly different between 5.0.3 and 5.1.0, probably due
>> to switching to Gradle.
>>
>> Is this expected?
>>
>> The "Java 9+" support may break because related files are not located
>> under "version/9" directory any more, or?
>>
>>
>>
>>
>> Also not sure if we need to include LICENSE and NOTICE files in each jar
>> for legal reasons, but previously we did and now not any more.
>>
>> And META-INF/maven is gone, not sure if that is relevant, though.
>>
>> Dominik.
>>
>> On Thu, Jun 2, 2022 at 12:55 PM PJ Fanning 
>> wrote:
>> > Hi everyone,
>> >
>> > I've prepared artifacts for the release of Apache XmlBeans 5.1.0 (RC1).
>> > One thing to watch out for is in the src artifacts now should be built
>> with gradle - instead of ant.
>> >
>> > The most notable changes in this release are:
>> >
>> > * create temp files using java.nio.files.Files
>> > * Line breaks in base64binary caused a validation error
>> > * Improve support for using XMLBeans on Android by not relying on the
>> namespace-prefixes feature on the XML SAX parser
>> > * Use generics in Collections
>> > * GDate can return diferent values on different current timezones
>> > * Migrate ant build to gradle
>> > * change version code so that the value is automatically generated
>> > * Make XmlCursor AutoCloseable
>> > * Fix some problems with XMLBeans Extension Interfaces Feature
>> > * Inner Class Handler was not supported
>> > * When specifying user types in an xsdconfig, types that are not being
>> compiled could not be referenced properly
>> > * Upgrade dependencies (javaparser 3.24.2, Saxon-HE 11.3, log4j-api
>> 2.17.2)
>> >
>> > A full list of changes is available in the change log:
>> > https://issues.apache.org/jira/projects/XMLBEANS/versions/12350699
>> >
>> > The artifacts are at:
>> > https://dist.apache.org/repos/dist/release/poi/xmlbeans/dev/
>> >
>> >
>> > You can use this maven URL for your mvn/gradle builds:
>> > https://repository.apache.org/content/repositories/staging
>> >
>> > I haven't updated the "provided" dependencies as those 

Re: [VOTE] Apache XmlBeans 5.1.0 release (RC1)

[Dominik Stadler]

Hi PJ,

that already looks better, the "version" folder is now in place.

but still a few things that I am not sure about:

* the maven plugin.xml and pom.xml under "maven" do not have a version set,
but rather @VERSION@
* We seem to duplicate the class to the "org" folder in META-INF, but that
is probably not causing any issues
* log4j-core is not included any more in the "bin" distribution

I'll see if I manage a quick glance at the build.gradle stuff, but maybe
Andi can take a look as he did this for the Apache POI side as well and
thus seems to know the most about this topic...


Thanks... Dominik.


On Fri, Jun 3, 2022 at 8:04 PM PJ Fanning 
wrote:

> Hi Dominik,
> I changed the gradle build and I think the CI build for Java 11 is closer
> to what is needed. The build produces Java 8 compatible classes.
>
> Could you have a look at the jar in
> https://ci-builds.apache.org/job/POI/job/POI-XMLBeans-DSL-1.11/56/  ?
>
> If that one looks ok, I can produce an RC2 based on that build.
>
>
>
>
> On Friday 3 June 2022, 16:46:47 IST, PJ Fanning
>  wrote:
>
>
>
>
>
> Doesn't look right. I wasn't involved in the Gradle changes for XmlBeans
> but the jar doesn't seem right. The licenses/notices are there but have
> moved to META-INF. I think this is ok. But the missing META-INF/versions/9
> is an issue that blocks the release. Even the jars built with Java 11 are
> missing this.
>
> So -1 from me for the RC1. I will see what can be done to get an RC2
> together but Gradle is not an area of expertise for me.
>
>
>
>
>
>
> On Friday 3 June 2022, 16:04:46 IST, Dominik Stadler <
> dominik.stad...@gmx.at> wrote:
>
>
>
>
>
> Hi,
>
> As always, thanks PJ for preparing the release!
>
> I compared release artifacts and the contents of directory META-INF in the
> main jar-file is fairly different between 5.0.3 and 5.1.0, probably due to
> switching to Gradle.
>
> Is this expected?
>
> The "Java 9+" support may break because related files are not located
> under "version/9" directory any more, or?
>
>
>
>
> Also not sure if we need to include LICENSE and NOTICE files in each jar
> for legal reasons, but previously we did and now not any more.
>
> And META-INF/maven is gone, not sure if that is relevant, though.
>
> Dominik.
>
> On Thu, Jun 2, 2022 at 12:55 PM PJ Fanning 
> wrote:
> > Hi everyone,
> >
> > I've prepared artifacts for the release of Apache XmlBeans 5.1.0 (RC1).
> > One thing to watch out for is in the src artifacts now should be built
> with gradle - instead of ant.
> >
> > The most notable changes in this release are:
> >
> > * create temp files using java.nio.files.Files
> > * Line breaks in base64binary caused a validation error
> > * Improve support for using XMLBeans on Android by not relying on the
> namespace-prefixes feature on the XML SAX parser
> > * Use generics in Collections
> > * GDate can return diferent values on different current timezones
> > * Migrate ant build to gradle
> > * change version code so that the value is automatically generated
> > * Make XmlCursor AutoCloseable
> > * Fix some problems with XMLBeans Extension Interfaces Feature
> > * Inner Class Handler was not supported
> > * When specifying user types in an xsdconfig, types that are not being
> compiled could not be referenced properly
> > * Upgrade dependencies (javaparser 3.24.2, Saxon-HE 11.3, log4j-api
> 2.17.2)
> >
> > A full list of changes is available in the change log:
> > https://issues.apache.org/jira/projects/XMLBEANS/versions/12350699
> >
> > The artifacts are at:
> > https://dist.apache.org/repos/dist/release/poi/xmlbeans/dev/
> >
> >
> > You can use this maven URL for your mvn/gradle builds:
> > https://repository.apache.org/content/repositories/staging
> >
> > I haven't updated the "provided" dependencies as those have to be
> > activated anyway explicitly.
> >
> > Please vote to release the artifacts.
> > The vote keeps open until 2022-06-09 23:00 UTC.
> > Planned release announcement date is Friday, 2022-06-10.
> >
> >
> > Here is my +1
> >
> >
> > PJ
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
>
> >
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache XmlBeans 5.1.0 release (RC1)

[Dominik Stadler]

Hi,

As always, thanks PJ for preparing the release!

I compared release artifacts and the contents of directory META-INF in the
main jar-file is fairly different between 5.0.3 and 5.1.0, probably due to
switching to Gradle.

Is this expected?

The "Java 9+" support may break because related files are not located under
"version/9" directory any more, or?


[image: image.png]

Also not sure if we need to include LICENSE and NOTICE files in each jar
for legal reasons, but previously we did and now not any more.

And META-INF/maven is gone, not sure if that is relevant, though.

Dominik.

On Thu, Jun 2, 2022 at 12:55 PM PJ Fanning 
wrote:

> Hi everyone,
>
> I've prepared artifacts for the release of Apache XmlBeans 5.1.0 (RC1).
> One thing to watch out for is in the src artifacts now should be built
> with gradle - instead of ant.
>
> The most notable changes in this release are:
>
> * create temp files using java.nio.files.Files
> * Line breaks in base64binary caused a validation error
> * Improve support for using XMLBeans on Android by not relying on the
> namespace-prefixes feature on the XML SAX parser
> * Use generics in Collections
> * GDate can return diferent values on different current timezones
> * Migrate ant build to gradle
> * change version code so that the value is automatically generated
> * Make XmlCursor AutoCloseable
> * Fix some problems with XMLBeans Extension Interfaces Feature
> * Inner Class Handler was not supported
> * When specifying user types in an xsdconfig, types that are not being
> compiled could not be referenced properly
> * Upgrade dependencies (javaparser 3.24.2, Saxon-HE 11.3, log4j-api 2.17.2)
>
> A full list of changes is available in the change log:
> https://issues.apache.org/jira/projects/XMLBEANS/versions/12350699
>
> The artifacts are at:
> https://dist.apache.org/repos/dist/release/poi/xmlbeans/dev/
>
>
> You can use this maven URL for your mvn/gradle builds:
> https://repository.apache.org/content/repositories/staging
>
> I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
>
> Please vote to release the artifacts.
> The vote keeps open until 2022-06-09 23:00 UTC.
> Planned release announcement date is Friday, 2022-06-10.
>
>
> Here is my +1
>
>
> PJ
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: xmlbeans 5.1.0 release

[Dominik Stadler]

+1

Dominik.

On Mon, May 23, 2022 at 5:22 PM PJ Fanning 
wrote:

> Hi everyone,
> There are a fair number of unreleased changes in XMLBeans. Is it time for
> a v5.1.0 release?
>
>
> https://issues.apache.org/jira/browse/XMLBEANS-604?jql=project%20%3D%20XMLBEANS%20AND%20fixVersion%20%3D%20%22Version%205.1.0%22
>
> I can put together an RC if there are no objections.
>
> Regards,
> PJ
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: want to provide patch

[Dominik Stadler]

Hi,

This is the default workflow of Github-repositories. You need to create a
fork of the code into a new repository, create the branch there and then
send a PR to the main repo.

The following might help:
*
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks
*
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork
* https://gist.github.com/Chaser324/ce0505fbed06b947d962

Dominik.

On Fri, Apr 29, 2022 at 7:01 AM stanton fisque  wrote:

> so i've cloned the repo, created a branch locally to make changes, added
> the code and a corresponding unit test.  but when i try to push back, i get
> permission failure.  it appears i cannot create a new branch, so that begs
> the question, how does one submit a PR if they cannot create a feature
> branch for the PR source.
>
>
> Stanton Fisque
> principal technologist
> latticeware.com
> portland, oregon
>
> > On Apr 28, 2022, at 09:00 AM, Nick Burch  wrote:
> >
> > On Thu, 28 Apr 2022, stanton fisque wrote:
> >> i'd like to provide a patch for some missing functionality,
> specifically the support handler for AverageIf (the generalized version is
> present but not the singular version).  what is the best way to provide
> that? is there a repo where a pull request can be provided?
> >
> > Great! You'll want:
> > * https://poi.apache.org/devel/guidelines.html
> > * https://github.com/apache/poi
> >
> > For formula functions, see also
> > * https://poi.apache.org/components/spreadsheet/eval.html
> > *
> http://home.apache.org/~yegor/apachecon_us2010/Evaluation_Of_Excel_Formulas_In_POI.pptx
> >
> > Nick
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: poi-src-5.2.2-20220312.zip SHA sums mismatch

[Dominik Stadler]

Hi,

downloading works for me, but I also see a difference in sha512 and sha256
checksums:

$ sha512sum
dist.apache.org/repos/dist/dev/poi/src/poi-src-5.2.2-20220312.zip
ae404f0df06852ea65328f893d566a2b29d442a1506a3aeef17272c1ca529802402dc6900229456cebce29bff512d396b3aec0896687ae185fe701a149904db3
 dist.apache.org/repos/dist/dev/poi/src/poi-src-5.2.2-20220312.zip
$ cat
dist.apache.org/repos/dist/dev/poi/src/poi-src-5.2.2-20220312.zip.sha512
16792230539b8881723ffa7ff1d54540fbb4582ad24f0dd2dd790aea608b5f8d9ff15b30461a18e42e8ad70d89f5b1cb96661507601941b42543fead12db
 poi-src-5.2.2-20220312.zip


The same when using the dist.apache.org SVN checkout:

$ sha512sum dist/./release/src/poi-src-5.2.2-20220312.zip
ae404f0df06852ea65328f893d566a2b29d442a1506a3aeef17272c1ca529802402dc6900229456cebce29bff512d396b3aec0896687ae185fe701a149904db3
 dist/./release/src/poi-src-5.2.2-20220312.zip
$ cat dist/./release/src/poi-src-5.2.2-20220312.zip.sha512
16792230539b8881723ffa7ff1d54540fbb4582ad24f0dd2dd790aea608b5f8d9ff15b30461a18e42e8ad70d89f5b1cb96661507601941b42543fead12db
 poi-src-5.2.2-20220312.zip

$ sha256sum dist/./release/src/poi-src-5.2.2-20220312.zip
70e51f1ab8324fb0373b6a654ac859049adb174720e5e036eecd91ecee0ba84a
 dist/./release/src/poi-src-5.2.2-20220312.zip
$ cat dist/./release/src/poi-src-5.2.2-20220312.zip.sha256
0618bb6527cd731dae28268d98474ef845def6b85b1a4a299262f96b441ffca4
 poi-src-5.2.2-20220312.zip

Dominik.


On Mon, Apr 18, 2022 at 10:31 AM PJ Fanning 
wrote:

> I have no problems downloading any of the files on the download page. With
> the zip file, have you checked if you downloaded the full file? Seems like
> you might have access issues with the apache web sites.
>
>
>
>
>
>
> On Monday 18 April 2022, 10:21:46 GMT+2, R Vlasov 
> wrote:
>
>
>
>
>
> Hello,
> I downloaded poi-src-5.2.2-20220312.zip from the backup site:
> *https://downloads.apache.org/poi/release/src/poi-src-5.2.2-20220312.zip*
> 
>
> The normal hyperlink was hanging, not retrieving any content:
> *https://dlcdn.apache.org/poi/release/src/poi-src-5.2.2-20220312.zip*
> 
>
> The SHA 256 and 512 sums did not match the ones retrieved from the main
> download page: https://poi.apache.org/download.html
>
> The size of the downloaded file was 121,115,226 bytes
>
> Note: the "bin" version (poi-*bin*-5.2.2-20220312.zip) was fine.
>
> Thank you!
> Radu
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Log4j

[Dominik Stadler]

The page is updated now to focus more on the state since Apache POI 5.1.0
and it also describes the options with slf4j a bit more.

Let us know if you think more content would be useful.

Thanks... Dominik.

On Thu, Mar 24, 2022 at 10:12 PM Timothy Spear  wrote:

> Ah, then the second line in the link below states POI from 5.1.0 uses log4j
> directly left myself and a few other developers confused. Probably should
> have just checked the code. Did not think of that until you replied
> https://poi.apache.org/components/logging.html
>
> Thanks,
>
> Tim
>
> On Thu, Mar 24, 2022 at 5:00 PM PJ Fanning 
> wrote:
>
> > We do use a facade - log4j-api - you can then choose which compatible
> impl
> > to use.
> > * log4j-core is one impl
> > * log4j-slf4j-impl is an impl that bridges to slf4j -
> > https://github.com/pjfanning/poi-gradle-example/blob/main/build.gradle
> > uses that bridge and use slf4j-simple as the log framework.
> >
> > https://poi.apache.org/components/logging.html has extra details.
> >
> >
> >
> >
> >
> >
> > On Thursday 24 March 2022, 21:50:13 GMT+1, Timothy Spear <
> n61...@gmail.com>
> > wrote:
> >
> >
> >
> >
> >
> > Curious,
> >
> > I could not find in any ticket, wiki or documentation. Why the switch
> from
> > a facade like SL4J to direct log4j as the logging engine? Going direct
> to a
> > logging engine has caused me module conflicts and classpath problems as
> > multiple competing logging engines are required by separate libraries.
> >
> > A facade such as SLF4J eliminates most of these types of issues.
> >
> > Tim
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >
>

Re: poi-ooxml-lite: Check in list of classes and xsb-files to avoid the jar-to-test dependency

[Dominik Stadler]

This is committed now, let me know if it causes issues.

Dominik


On Sun, 20 Mar 2022, 16:50 Dominik Stadler,  wrote:

> Hi Devs!
>
> I would like to get some review of a change that I prepared which would
> make working with Apache POI easier (at least for me)
>
> I propose to persist the list of classes/xsbs instead of creating them
> on-the-fly every time the build is executed.
>
> This would then be similar to how we build the Java 9 java/class files.
>
> Let's discuss details at https://github.com/apache/poi/pull/313 where I
> also put a detailed description and pros/cons.
>
> I plan to commit this in a few days if I do not get any "-1" or concerns
> about this change.
>
> Thanks... Dominik.
>

poi-ooxml-lite: Check in list of classes and xsb-files to avoid the jar-to-test dependency

[Dominik Stadler]

Hi Devs!

I would like to get some review of a change that I prepared which would
make working with Apache POI easier (at least for me)

I propose to persist the list of classes/xsbs instead of creating them
on-the-fly every time the build is executed.

This would then be similar to how we build the Java 9 java/class files.

Let's discuss details at https://github.com/apache/poi/pull/313 where I
also put a detailed description and pros/cons.

I plan to commit this in a few days if I do not get any "-1" or concerns
about this change.

Thanks... Dominik.

Re: [VOTE] Apache POI 5.2.2 release (RC2)

[Dominik Stadler]

Hi,

I compared the contents of the release and tested some projects with the
release, everything looks fine!

+1 from me.

Thanks PJ for yet another spot-less release-build!


Thanks... Dominik.

On Sun, Mar 13, 2022 at 11:29 AM PJ Fanning 
wrote:

> Hi everyone,
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=65950 seems serious enough
> to warrant a new release.
>
> I've prepared artifacts for the release of Apache POI 5.2.2 (RC2).
>
> I'd appreciate if anyone could review the IOUtils changes (in particular).
>
> The most notable changes in this release are:
> * upgrade dependencies: log4j-api 2.17.2, graphics2d 0.35 ...
> * Support rich text strings in SXSSFWorkbook (only when shared string
> table is used) [#65943]
> * POIXMLPropertiesTextExtractor returns duplicate key for Core properties
> [#65946]
> * Fix issue where Boolean functions (AND, OR) do not work properly in
> array context [#65915]
> * Add XSLF APIs to remove paragraphs and text runs [#65934,#65935]
> * POI 5.2.1 can allocate byte arrays that are too big [#65950]
> * Fix stackoverflow issue when removing formulas with circular references
> [#65939]
>
>
> A full list of changes is available in the change log:
>
> https://poi.apache.org/changes.html
>
>
> The artifacts are at:
>
> https://dist.apache.org/repos/dist/dev/poi/
>
>
> You can use this maven URL for your mvn/gradle builds:
>
> https://repository.apache.org/content/repositories/staging
>
>
> I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
>
>
> Please vote to release the artifacts. Here is my +1.
>
> The vote is open until 2022-03-19 23:00 UTC.
>
>
>
> Planned release announcement date is Sunday, 2022-03-20.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache POI 5.2.1 release (RC1)

[Dominik Stadler]

Hi,

I compared jars and zips between 5.2.0 and 5.2.1, everything looks fine on
this side. Also upgrading to the RC for some projects did work fine.

Great work PJ!

+1 from me.

Dominik

On Fri, Feb 25, 2022 at 10:12 AM PJ Fanning 
wrote:

> Hi everyone,
>
> I've prepared artifacts for the release of Apache POI 5.2.1 (RC1).
>
> * upgrade dependencies: curvesapi 1.07 ...
> * IOUtils.toByteArray did not fully take into account value set by
> IOUtils.setByteArrayMaxOverride [#65887]
> * Fix issue where malformed TNEF file can cause memory issues [#65899]
> * XAdES-XL modifications due to specification check errors [#65908]
> * Picture resize can lead to infinite loop [#65839]
> * Multiplication in cell formulas can have small rounding issues [#65792]
> * Add support a number of extra Excel functions (Normal Distribution,
> BESSELJ, NUMBERVALUE, WORKDAY.INTL, DOLLARDE and DOLLARFR)
>
>
>
> A full list of changes is available in the change log:
>
> https://poi.apache.org/changes.html
>
>
> The artifacts are at:
>
> https://dist.apache.org/repos/dist/dev/poi/
>
>
>
> You can use this maven URL for your mvn/gradle builds:
>
> https://repository.apache.org/content/repositories/staging
>
>
>
> I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
>
>
> Please vote to release the artifacts. Here is my +1.
>
>
> The vote keeps open until 2022-03-03 23:00 UTC.
>
>
> Planned release announcement date is Saturday, 2022-03-05.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Missing class in latest snapshots

[Dominik Stadler]

Thanks for checking, I actually found that this also did not work with
Apache POI 5.2.0 with poi-ooxml-lite, so it seems to not be a regression.

The following test triggers it.

Dominik.

@Test
public void testSnapshot() {
   SectionType sectionType = mock(SectionType.class);
   RowType rowType = mock(RowType.class);

   when(sectionType.getCellArray()).thenReturn(new CellType[0]);
   when(sectionType.getRowArray()).thenReturn(new RowType[] {
 rowType
   });
   when(rowType.getIX()).thenReturn(0L);
   when(rowType.getT()).thenReturn("ArcTo");
   when(rowType.getCellArray()).thenReturn(new CellType[0]);

   GeometrySection section = new GeometrySection(sectionType, null);
   assertNotNull(section);
}


On Wed, Feb 23, 2022 at 10:23 PM PJ Fanning 
wrote:

> Hi Dominik,
> I checked POI 5.2.0, 5.1.0 and 4.1.2 and poi-ooxml-lite (poi-ooxml-schemas
> before 5.x release) and none contain
> com/microsoft/schemas/office/visio/x2012/main/TriggerType.
>
> We can add extra classes to the lite if we need to.
>
> Regards,
> PJ
>
>
>
>
>
>
> On Wednesday 23 February 2022, 22:17:04 GMT+1, Dominik Stadler <
> dominik.stad...@gmx.at> wrote:
>
>
>
>
>
> Hi,
>
> when I try to test something with the latest -jar files built off of trunk,
> I get the following exception.
>
> Do we miss some classes in poi-ooxml-lite now?
>
> After adding poi-ooxml-full, it works again.
>
> Thanks... Dominik.
>
> Caused by: java.lang.IllegalArgumentException: Could not create type
> at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:155)
> at
>
> net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:366)
> at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:175)
> at
>
> net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:377)
> at
>
> org.mockito.internal.creation.bytebuddy.TypeCachingBytecodeGenerator.mockClass(TypeCachingBytecodeGenerator.java:40)
> at
>
> org.mockito.internal.creation.bytebuddy.SubclassByteBuddyMockMaker.createMockType(SubclassByteBuddyMockMaker.java:77)
> at
>
> org.mockito.internal.creation.bytebuddy.SubclassByteBuddyMockMaker.createMock(SubclassByteBuddyMockMaker.java:43)
> at
>
> org.mockito.internal.creation.bytebuddy.ByteBuddyMockMaker.createMock(ByteBuddyMockMaker.java:43)
> at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:53)
> at org.mockito.internal.MockitoCore.mock(MockitoCore.java:84)
> at org.mockito.Mockito.mock(Mockito.java:1964)
> at org.mockito.Mockito.mock(Mockito.java:1879)
> ... 59 more
> Caused by: java.lang.NoClassDefFoundError:
> [Lcom/microsoft/schemas/office/visio/x2012/main/TriggerType;
> at java.base/java.lang.Class.getDeclaredMethods0(Native Method)
> at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3166)
> at java.base/java.lang.Class.privateGetPublicMethods(Class.java:3191)
> at java.base/java.lang.Class.getMethods(Class.java:1904)
> at
>
> org.mockito.internal.creation.bytebuddy.SubclassBytecodeGenerator.hasNonPublicTypeReference(SubclassBytecodeGenerator.java:117)
> at
>
> org.mockito.internal.creation.bytebuddy.SubclassBytecodeGenerator.needsSamePackageClassLoader(SubclassBytecodeGenerator.java:101)
> at
>
> org.mockito.internal.creation.bytebuddy.SubclassBytecodeGenerator.mockClass(SubclassBytecodeGenerator.java:144)
> at
>
> org.mockito.internal.creation.bytebuddy.TypeCachingBytecodeGenerator.lambda$mockClass$0(TypeCachingBytecodeGenerator.java:47)
> at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:153)
> ... 70 more
> Caused by: java.lang.ClassNotFoundException:
> com.microsoft.schemas.office.visio.x2012.main.TriggerType
> at
>
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
> at
>
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
> ... 79 more
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Missing class in latest snapshots

[Dominik Stadler]

Hi,

when I try to test something with the latest -jar files built off of trunk,
I get the following exception.

Do we miss some classes in poi-ooxml-lite now?

After adding poi-ooxml-full, it works again.

Thanks... Dominik.

Caused by: java.lang.IllegalArgumentException: Could not create type
at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:155)
at
net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:366)
at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:175)
at
net.bytebuddy.TypeCache$WithInlineExpunction.findOrInsert(TypeCache.java:377)
at
org.mockito.internal.creation.bytebuddy.TypeCachingBytecodeGenerator.mockClass(TypeCachingBytecodeGenerator.java:40)
at
org.mockito.internal.creation.bytebuddy.SubclassByteBuddyMockMaker.createMockType(SubclassByteBuddyMockMaker.java:77)
at
org.mockito.internal.creation.bytebuddy.SubclassByteBuddyMockMaker.createMock(SubclassByteBuddyMockMaker.java:43)
at
org.mockito.internal.creation.bytebuddy.ByteBuddyMockMaker.createMock(ByteBuddyMockMaker.java:43)
at org.mockito.internal.util.MockUtil.createMock(MockUtil.java:53)
at org.mockito.internal.MockitoCore.mock(MockitoCore.java:84)
at org.mockito.Mockito.mock(Mockito.java:1964)
at org.mockito.Mockito.mock(Mockito.java:1879)
... 59 more
Caused by: java.lang.NoClassDefFoundError:
[Lcom/microsoft/schemas/office/visio/x2012/main/TriggerType;
at java.base/java.lang.Class.getDeclaredMethods0(Native Method)
at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3166)
at java.base/java.lang.Class.privateGetPublicMethods(Class.java:3191)
at java.base/java.lang.Class.getMethods(Class.java:1904)
at
org.mockito.internal.creation.bytebuddy.SubclassBytecodeGenerator.hasNonPublicTypeReference(SubclassBytecodeGenerator.java:117)
at
org.mockito.internal.creation.bytebuddy.SubclassBytecodeGenerator.needsSamePackageClassLoader(SubclassBytecodeGenerator.java:101)
at
org.mockito.internal.creation.bytebuddy.SubclassBytecodeGenerator.mockClass(SubclassBytecodeGenerator.java:144)
at
org.mockito.internal.creation.bytebuddy.TypeCachingBytecodeGenerator.lambda$mockClass$0(TypeCachingBytecodeGenerator.java:47)
at net.bytebuddy.TypeCache.findOrInsert(TypeCache.java:153)
... 70 more
Caused by: java.lang.ClassNotFoundException:
com.microsoft.schemas.office.visio.x2012.main.TriggerType
at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
at
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
... 79 more

Re: Cannot resolve type when upgrading to Apache POI 5.2.0 in poi-on-android

[Dominik Stadler]

Thanks for the work,

I tried but unfortunately did not manage to reproduce the error outside of
the Android Emulator, different combinations of both features either work
or result in different exceptions.

Also trying with the latest version of Locale.java inside the Android
Emulator also did not work. I still get the same error message.

It seems there is some other difference in XMLBeans here which introduced
this issue.

Please note that the current version of the poi-on-android project is based
on 4.1.2 and there removing the "namespace-prefixes" feature did make it
work. I only get this when upgrading to newer versions of Apache POI. So
something between Apache POI 4.12 and 5.2.0 (and the corresponding XMLBeans
version) changed and introduced this error.

Regards... Dominik

On Wed, Feb 9, 2022 at 12:21 PM PJ Fanning 
wrote:

> Hi Dominik,
> I committed
> https://github.com/apache/xmlbeans/commit/71e0f1e4da5e76c4470c2532538705b46229e1e4
>
> It seems to work for me locally. I'll revert it if it causes problems.
> Feel free to revert it or change it yourself if you think that this is the
> wrong approach.
>
> I raised https://issues.apache.org/jira/browse/XMLBEANS-598 as a weakness
> of the old and new code. I might have a look at that later this week if the
> XMLBEANS-597 solution works for the existing scenarios.
>
> Regards,
> PJ
>
>
>
>
>
>
> On Wednesday 9 February 2022, 11:43:26 GMT+1, PJ Fanning
>  wrote:
>
>
>
>
>
> It looks like the current SAX code in XMLBeans Locale class relies on the
> namespace-prefix feature being enabled.
> When it is enabled, startElement method receives all the xmlns entries on
> the element as attributes. You can see in current code how startElement is
> trying to build up a namespace context from these attributes.
>
> If you don't set the namespace-prefix feature, you do not get these
> namespace mappings as attributes. They can still be worked out because the
> startPrefixMapping gets called with the namespace mapping.
>
> So, it looks like we need to rewrite the SAX to never set namespace-prefix
> feature to true and to change how the SAX code created the namespace
> context (by doing it inside the startPrefixMapping instead).
>
>
>
>
>
>
> On Tuesday 8 February 2022, 23:13:35 GMT+1, PJ Fanning
>  wrote:
>
>
>
>
>
> Aim would be to reproduce the issue in a non-android env and that would
> make it easier to try to find a fix.
>
>
>
>
>
>
> On Tuesday 8 February 2022, 23:10:39 GMT+1, Dominik Stadler <
> dominik.stad...@gmx.at> wrote:
>
>
>
>
>
> Hi,
>
> I will check that, but what would happen if I keep "namespace-prefixes:
> true" and switch the feature "namespaces" to "false"? It will likely lead
> to other trouble, or?
>
> Thanks... Dominik.
>
>
> On Tue, Feb 8, 2022 at 10:44 PM PJ Fanning 
> wrote:
>
> > Maybe this only works if namespace-prefix handling is enabled on the
> > XMLReader - the thing that doesn't work on Android (
> > https://issues.apache.org/jira/browse/XMLBEANS-597).
> >
> > Could you try this test in a non-android env where XMLBeans doesn't
> > enable namespace-prefix feature? This might cause it to fail in same way
> as
> > on android env.
> >
> >
> >
> >
> >
> >
> > On Tuesday 8 February 2022, 22:32:26 GMT+1, Dominik Stadler <
> > dominik.stad...@gmx.at> wrote:
> >
> >
> >
> >
> >
> > Hi,
> >
> > when I try to update Apache POI from 4.1.2 to 5.2.0 in the sample-project
> > that provides Apache POI for Android Apps (
> > https://github.com/centic9/poi-on-android ), I get a very strange
> > exception.
> >
> > It seems that some of the resources are not found, although they are
> > present properly as far as I can tell. I think there were quite some
> > changes in that area between 4.1.2 and 5.2.0
> >
> > Did any of the XMLBeans gurus encounter something like this or knows what
> > the reason could be?
> >
> > Thanks... Dominik.
> >
> > Stacktrace:
> >
> >Caused by: org.apache.xmlbeans.SchemaTypeLoaderException: Cannot
> > resolve type for handle _XY_Q=space|R=space@
> > http://www.w3.org/XML/1998/namespace
> > (org.apache.poi.schemas.ooxml.system.ooxml.cttext7f5btype) - code 13
> >at
> > org.apache.xmlbeans.impl.schema.XsbReader.readHandle(XsbReader.java:483)
> >at
> > org.apache.xmlbeans.impl.schema.XsbReader.readTypeRef(XsbReader.java:548)
> >at
> >
> >
> org.apache.xmlbeans.impl.schema.XsbReader.loadAttribute(XsbReader.java:1282)

Re: Cannot resolve type when upgrading to Apache POI 5.2.0 in poi-on-android

[Dominik Stadler]

Hi,

I will check that, but what would happen if I keep "namespace-prefixes:
true" and switch the feature "namespaces" to "false"? It will likely lead
to other trouble, or?

Thanks... Dominik.


On Tue, Feb 8, 2022 at 10:44 PM PJ Fanning 
wrote:

> Maybe this only works if namespace-prefix handling is enabled on the
> XMLReader - the thing that doesn't work on Android (
> https://issues.apache.org/jira/browse/XMLBEANS-597).
>
> Could you try this test in a non-android env where XMLBeans doesn't
> enable namespace-prefix feature? This might cause it to fail in same way as
> on android env.
>
>
>
>
>
>
> On Tuesday 8 February 2022, 22:32:26 GMT+1, Dominik Stadler <
> dominik.stad...@gmx.at> wrote:
>
>
>
>
>
> Hi,
>
> when I try to update Apache POI from 4.1.2 to 5.2.0 in the sample-project
> that provides Apache POI for Android Apps (
> https://github.com/centic9/poi-on-android ), I get a very strange
> exception.
>
> It seems that some of the resources are not found, although they are
> present properly as far as I can tell. I think there were quite some
> changes in that area between 4.1.2 and 5.2.0
>
> Did any of the XMLBeans gurus encounter something like this or knows what
> the reason could be?
>
> Thanks... Dominik.
>
> Stacktrace:
>
> Caused by: org.apache.xmlbeans.SchemaTypeLoaderException: Cannot
> resolve type for handle _XY_Q=space|R=space@
> http://www.w3.org/XML/1998/namespace
> (org.apache.poi.schemas.ooxml.system.ooxml.cttext7f5btype) - code 13
> at
> org.apache.xmlbeans.impl.schema.XsbReader.readHandle(XsbReader.java:483)
> at
> org.apache.xmlbeans.impl.schema.XsbReader.readTypeRef(XsbReader.java:548)
> at
>
> org.apache.xmlbeans.impl.schema.XsbReader.loadAttribute(XsbReader.java:1282)
> at
>
> org.apache.xmlbeans.impl.schema.XsbReader.readAttributeData(XsbReader.java:1275)
> at
>
> org.apache.xmlbeans.impl.schema.XsbReader.finishLoadingType(XsbReader.java:902)
> at
>
> org.apache.xmlbeans.impl.schema.SchemaTypeSystemImpl.resolveHandle(SchemaTypeSystemImpl.java:938)
> at
>
> org.apache.xmlbeans.SchemaComponent$Ref.getComponent(SchemaComponent.java:113)
> at org.apache.xmlbeans.SchemaType$Ref.get(SchemaType.java:1072)
> at
>
> org.apache.xmlbeans.impl.schema.SchemaPropertyImpl.getType(SchemaPropertyImpl.java:85)
> at
>
> org.apache.xmlbeans.impl.schema.SchemaTypeImpl.createElementType(SchemaTypeImpl.java:990)
> at
>
> org.apache.xmlbeans.impl.values.XmlObjectBase.create_element_user(XmlObjectBase.java:914)
> at org.apache.xmlbeans.impl.store.Xobj.getUser(Xobj.java:1597)
> at org.apache.xmlbeans.impl.store.Cur.getUser(Cur.java:2571)
> at org.apache.xmlbeans.impl.store.Cur.getObject(Cur.java:2565)
> at
> org.apache.xmlbeans.impl.store.Cursor._getObject(Cursor.java:817)
> at
>
> org.apache.xmlbeans.impl.store.Cursor$$ExternalSyntheticLambda64.get(Unknown
> Source:2)
> at
> org.apache.xmlbeans.impl.store.Cursor.syncWrapHelper(Cursor.java:2520)
> at org.apache.xmlbeans.impl.store.Cursor.syncWrap(Cursor.java:2451)
> at
> org.apache.xmlbeans.impl.store.Cursor.getObject(Cursor.java:2078)
> at
> org.apache.poi.xwpf.usermodel.XWPFParagraph.(XWPFParagraph.java:79)
> at
>
> org.apache.poi.xwpf.usermodel.XWPFDocument.onDocumentRead(XWPFDocument.java:214)
> at
> org.apache.poi.ooxml.POIXMLDocument.load(POIXMLDocument.java:169)
> at
> org.apache.poi.xwpf.usermodel.XWPFDocument.(XWPFDocument.java:159)
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Cannot resolve type when upgrading to Apache POI 5.2.0 in poi-on-android

[Dominik Stadler]

Hi,

when I try to update Apache POI from 4.1.2 to 5.2.0 in the sample-project
that provides Apache POI for Android Apps (
https://github.com/centic9/poi-on-android ), I get a very strange exception.

It seems that some of the resources are not found, although they are
present properly as far as I can tell. I think there were quite some
changes in that area between 4.1.2 and 5.2.0

Did any of the XMLBeans gurus encounter something like this or knows what
the reason could be?

Thanks... Dominik.

Stacktrace:

 Caused by: org.apache.xmlbeans.SchemaTypeLoaderException: Cannot
resolve type for handle _XY_Q=space|R=space@
http://www.w3.org/XML/1998/namespace
(org.apache.poi.schemas.ooxml.system.ooxml.cttext7f5btype) - code 13
at
org.apache.xmlbeans.impl.schema.XsbReader.readHandle(XsbReader.java:483)
at
org.apache.xmlbeans.impl.schema.XsbReader.readTypeRef(XsbReader.java:548)
at
org.apache.xmlbeans.impl.schema.XsbReader.loadAttribute(XsbReader.java:1282)
at
org.apache.xmlbeans.impl.schema.XsbReader.readAttributeData(XsbReader.java:1275)
at
org.apache.xmlbeans.impl.schema.XsbReader.finishLoadingType(XsbReader.java:902)
at
org.apache.xmlbeans.impl.schema.SchemaTypeSystemImpl.resolveHandle(SchemaTypeSystemImpl.java:938)
at
org.apache.xmlbeans.SchemaComponent$Ref.getComponent(SchemaComponent.java:113)
at org.apache.xmlbeans.SchemaType$Ref.get(SchemaType.java:1072)
at
org.apache.xmlbeans.impl.schema.SchemaPropertyImpl.getType(SchemaPropertyImpl.java:85)
at
org.apache.xmlbeans.impl.schema.SchemaTypeImpl.createElementType(SchemaTypeImpl.java:990)
at
org.apache.xmlbeans.impl.values.XmlObjectBase.create_element_user(XmlObjectBase.java:914)
at org.apache.xmlbeans.impl.store.Xobj.getUser(Xobj.java:1597)
at org.apache.xmlbeans.impl.store.Cur.getUser(Cur.java:2571)
at org.apache.xmlbeans.impl.store.Cur.getObject(Cur.java:2565)
at org.apache.xmlbeans.impl.store.Cursor._getObject(Cursor.java:817)
at
org.apache.xmlbeans.impl.store.Cursor$$ExternalSyntheticLambda64.get(Unknown
Source:2)
at
org.apache.xmlbeans.impl.store.Cursor.syncWrapHelper(Cursor.java:2520)
at org.apache.xmlbeans.impl.store.Cursor.syncWrap(Cursor.java:2451)
at org.apache.xmlbeans.impl.store.Cursor.getObject(Cursor.java:2078)
at
org.apache.poi.xwpf.usermodel.XWPFParagraph.(XWPFParagraph.java:79)
at
org.apache.poi.xwpf.usermodel.XWPFDocument.onDocumentRead(XWPFDocument.java:214)
at org.apache.poi.ooxml.POIXMLDocument.load(POIXMLDocument.java:169)
at
org.apache.poi.xwpf.usermodel.XWPFDocument.(XWPFDocument.java:159)

[jira] [Updated] (XMLBEANS-597) Improve support for using XMLBeans on Android

[Dominik Stadler (Jira)]

 [ 
https://issues.apache.org/jira/browse/XMLBEANS-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Stadler updated XMLBEANS-597:
-
Description: 
The project [https://github.com/centic9/poi-on-android] allows to run Apache 
POI as part of Android Apps and thus also uses XMLBeans.

When trying to update to Apache POI 5.2.0, I saw that there is a problem with 
the SAX parser on Android as it fails when both features "namespaces" and 
"namespace-prefix" are set to true.

XMLBeans currently does this in the class {{Locale.SaxLoader}} and thus an 
Android Application crashes with an error "The 'namespace-prefix' feature is 
not supported while the 'namespaces' feature is enabled."

 

Therefore I  will introduce a system property which can be used to control the 
SAX feature "namespace-prefixes" to be able to set it to "false" if required.

 

The full stacktrace is:

 
{noformat}
E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.dstadler.poiandroidtest.poitest, PID: 26552
    java.lang.RuntimeException: Unable to start activity 
ComponentInfo{org.dstadler.poiandroidtest.poitest/org.dstadler.poiandroidtest.poitest.DocumentListActivity}:
 java.lang.IllegalStateException: org.apache.poi.ooxml.POIXMLException: unable 
to parse shared strings table
        at 
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2817)
        at 
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2892)
        at android.app.ActivityThread.-wrap11(Unknown Source:0)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593)
        at android.os.Handler.dispatchMessage(Handler.java:105)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6541)
        at java.lang.reflect.Method.invoke(Native Method)
        at 
com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
     Caused by: java.lang.IllegalStateException: 
org.apache.poi.ooxml.POIXMLException: unable to parse shared strings table
        at 
org.dstadler.poiandroidtest.poitest.DocumentListActivity.onCreate(DocumentListActivity.java:191)
        at android.app.Activity.performCreate(Activity.java:6975)
        at 
android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1213)
        at 
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2770)
        at 
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2892) 
        at android.app.ActivityThread.-wrap11(Unknown Source:0) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593) 
        at android.os.Handler.dispatchMessage(Handler.java:105) 
        at android.os.Looper.loop(Looper.java:164) 
        at android.app.ActivityThread.main(ActivityThread.java:6541) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at 
com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767) 
     Caused by: org.apache.poi.ooxml.POIXMLException: unable to parse shared 
strings table
        at 
org.apache.poi.ooxml.POIXMLFactory.createDocumentPart(POIXMLFactory.java:68)
        at 
org.apache.poi.ooxml.POIXMLDocumentPart.read(POIXMLDocumentPart.java:661)
        at org.apache.poi.ooxml.POIXMLDocument.load(POIXMLDocument.java:165)
        at 
org.apache.poi.xssf.usermodel.XSSFWorkbook.(XSSFWorkbook.java:274)
        at 
org.apache.poi.xssf.usermodel.XSSFWorkbookFactory.createWorkbook(XSSFWorkbookFactory.java:118)
        at 
org.apache.poi.xssf.usermodel.XSSFWorkbookFactory.create(XSSFWorkbookFactory.java:98)
        at 
org.apache.poi.xssf.usermodel.XSSFWorkbookFactory.create(XSSFWorkbookFactory.java:36)
        at 
org.apache.poi.ss.usermodel.WorkbookFactory.lambda$create$2(WorkbookFactory.java:224)
        at 
org.apache.poi.ss.usermodel.WorkbookFactory$$ExternalSyntheticLambda4.create(Unknown
 Source:2)
        at 
org.apache.poi.ss.usermodel.WorkbookFactory.wp(WorkbookFactory.java:329)
        at 
org.apache.poi.ss.usermodel.WorkbookFactory.create(WorkbookFactory.java:224)
        at 
org.apache.poi.ss.usermodel.WorkbookFactory.create(WorkbookFactory.java:185)
        at 
org.dstadler.poiandroidtest.poitest.DocumentListActivity.onCreate(DocumentListActivity.java:81)
        at android.app.Activity.performCreate(Activity.java:6975) 
        at 
android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1213) 
        at 
android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2770) 
        at 
android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2892) 
        at android.app.ActivityThread.-wrap11(Unknown Source:0) 
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:15

[jira] [Reopened] (XMLBEANS-597) Improve support for using XMLBeans on Android

[Dominik Stadler (Jira)]

 [ 
https://issues.apache.org/jira/browse/XMLBEANS-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Stadler reopened XMLBEANS-597:
--

Thanks for the idea, unfortunately I don't know much about the XmlBeans code so 
didn't want to mess around too much, but I will give it a try and see what I 
can come up with.

> Improve support for using XMLBeans on Android
> -
>
> Key: XMLBEANS-597
> URL: https://issues.apache.org/jira/browse/XMLBEANS-597
> Project: XMLBeans
>  Issue Type: New Feature
>Affects Versions: Version 5.0.3
>        Reporter: Dominik Stadler
>    Assignee: Dominik Stadler
>Priority: Major
> Fix For: Version 5.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The project [https://github.com/centic9/poi-on-android] allows to run Apache 
> POI as part of Android Apps and thus also uses XMLBeans.
> When trying to update to Apache POI 5.2.0, I saw that there is a problem with 
> the SAX parser on Android as it fails when both features "namespaces" and 
> "namespace-prefix" are set to true.
> XMLBeans currently does this in the class {{Locale.SaxLoader}} and thus an 
> Android Application crashes with an error "The 'namespace-prefix' feature is 
> not supported while the 'namespaces' feature is enabled."
>  
> Therefore I  will introduce a system property which can be used to control 
> the SAX feature "namespace-prefixes" to be able to set it to "false" if 
> required.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[jira] [Updated] (XMLBEANS-597) Improve support for using XMLBeans on Android

[Dominik Stadler (Jira)]

 [ 
https://issues.apache.org/jira/browse/XMLBEANS-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Stadler updated XMLBEANS-597:
-
Description: 
The project [https://github.com/centic9/poi-on-android] allows to run Apache 
POI as part of Android Apps and thus also uses XMLBeans.

When trying to update to Apache POI 5.2.0, I saw that there is a problem with 
the SAX parser on Android as it fails when both features "namespaces" and 
"namespace-prefix" are set to true.

XMLBeans currently does this in the class {{Locale.SaxLoader}} and thus an 
Android Application crashes with an error "The 'namespace-prefix' feature is 
not supported while the 'namespaces' feature is enabled."

 

Therefore I  will introduce a system property which can be used to control the 
SAX feature "namespace-prefixes" to be able to set it to "false" if required.

  was:
The project [https://github.com/centic9/poi-on-android] allows to run Apache 
POI as part of Android Apps and thus also uses XMLBeans.

When trying to use the distribution, I saw that there is a problem with the SAX 
parser on Android as it fails when both features "namespaces" and 
"namespace-prefix" are set to true.

XMLBeans currently does this in the class {{Locale.SaxLoader}} and thus an 
Android Application crashes with an error.

 

Therefore I  will introduce a system property which can be used to control the 
SAX feature "namespace-prefixes" to be able to set it to "false" if required.


> Improve support for using XMLBeans on Android
> -
>
> Key: XMLBEANS-597
> URL: https://issues.apache.org/jira/browse/XMLBEANS-597
> Project: XMLBeans
>  Issue Type: New Feature
>Affects Versions: Version 5.0.3
>Reporter: Dominik Stadler
>Assignee: Dominik Stadler
>Priority: Major
> Fix For: Version 5.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The project [https://github.com/centic9/poi-on-android] allows to run Apache 
> POI as part of Android Apps and thus also uses XMLBeans.
> When trying to update to Apache POI 5.2.0, I saw that there is a problem with 
> the SAX parser on Android as it fails when both features "namespaces" and 
> "namespace-prefix" are set to true.
> XMLBeans currently does this in the class {{Locale.SaxLoader}} and thus an 
> Android Application crashes with an error "The 'namespace-prefix' feature is 
> not supported while the 'namespaces' feature is enabled."
>  
> Therefore I  will introduce a system property which can be used to control 
> the SAX feature "namespace-prefixes" to be able to set it to "false" if 
> required.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[jira] [Resolved] (XMLBEANS-597) Improve support for using XMLBeans on Android

[Dominik Stadler (Jira)]

 [ 
https://issues.apache.org/jira/browse/XMLBEANS-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dominik Stadler resolved XMLBEANS-597.
--
Resolution: Fixed

Added a system property via 
https://svn.apache.org/viewvc?view=revision=1897874

> Improve support for using XMLBeans on Android
> -
>
> Key: XMLBEANS-597
> URL: https://issues.apache.org/jira/browse/XMLBEANS-597
> Project: XMLBeans
>  Issue Type: New Feature
>Affects Versions: Version 5.0.3
>        Reporter: Dominik Stadler
>    Assignee: Dominik Stadler
>Priority: Major
> Fix For: Version 5.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The project [https://github.com/centic9/poi-on-android] allows to run Apache 
> POI as part of Android Apps and thus also uses XMLBeans.
> When trying to use the distribution, I saw that there is a problem with the 
> SAX parser on Android as it fails when both features "namespaces" and 
> "namespace-prefix" are set to true.
> XMLBeans currently does this in the class {{Locale.SaxLoader}} and thus an 
> Android Application crashes with an error.
>  
> Therefore I  will introduce a system property which can be used to control 
> the SAX feature "namespace-prefixes" to be able to set it to "false" if 
> required.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[jira] [Created] (XMLBEANS-597) Improve support for using XMLBeans on Android

[Dominik Stadler (Jira)]

Dominik Stadler created XMLBEANS-597:


 Summary: Improve support for using XMLBeans on Android
 Key: XMLBEANS-597
 URL: https://issues.apache.org/jira/browse/XMLBEANS-597
 Project: XMLBeans
  Issue Type: New Feature
Affects Versions: Version 5.0.3
Reporter: Dominik Stadler
Assignee: Dominik Stadler
 Fix For: Version 5.1.0


The project [https://github.com/centic9/poi-on-android] allows to run Apache 
POI as part of Android Apps and thus also uses XMLBeans.

When trying to use the distribution, I saw that there is a problem with the SAX 
parser on Android as it fails when both features "namespaces" and 
"namespace-prefix" are set to true.

XMLBeans currently does this in the class {{Locale.SaxLoader}} and thus an 
Android Application crashes with an error.

 

Therefore I  will introduce a system property which can be used to control the 
SAX feature "namespace-prefixes" to be able to set it to "false" if required.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

Re: Java 9+ build issues

[Dominik Stadler]

Hi,

thanks for reverting, yes, let's keep it this way for now.

FYI, I had some actual error appear about duplicated classes when I
included the test-jars in a project, probably one of the regression or
fuzzy testing efforts.

Dominik.

On Sat, Jan 22, 2022 at 10:21 PM PJ Fanning 
wrote:

> We don't distribute the test jars - at least not via Maven Central. If we
> ever did choose to distribute the test jars, we would have to consider not
> including the main source classes.
>
>
>
>
>
>
> On Saturday 22 January 2022, 22:19:19 GMT+1, PJ Fanning
>  wrote:
>
>
>
>
>
> Hi Andreas,
> I'm ok with reverting the test jar changes.
>
>
>
>
>
>
> On Saturday 22 January 2022, 22:06:41 GMT+1, Dominik Stadler <
> dominik.stad...@gmx.at> wrote:
>
>
>
>
>
> Hi,
>
> sorry for breaking the build, unfortunately these Java 9+ module stuff is
> quite a mystery for me as well.We can revert to the previous state if you
> think your current solution is not final.
>
> Would be nice if we can decide to ditch Java 8 at some point so we can
> simplify the build and then have less "works on Java 8, but breaks on Java
> 9+" issues.
>
> Thanks... Dominik.
>
>
> On Sat, Jan 22, 2022 at 3:37 PM PJ Fanning 
> wrote:
>
> > Hi,
> > I've tried to fix the build issues in Java 9+ that happened after
> >
> https://github.com/apache/poi/commit/bba249d52207799dc984efd884353aa4783c1c40
> >
> > This change seems worthwhile so I tried to fix the underlying compile
> > issues but ran into trouble with the test tasks setting module stuff. By
> > commenting out this module stuff, the test tasks run again (on my
> laptop).
> > I may not have fixed all the submodules yet and will have to leave it for
> > the next few hours.
> >
> >
> >
> https://github.com/apache/poi/commit/ca9cf3c6f83e06fe2504a01fff4bb7b53f44f577
> >
> >
> https://github.com/apache/poi/commit/1ee199b1ea8ce524d734aa5e9fa7fbe0c4a52ac0
> >
> > If anyone knows more about Jigsaw modules than me (and I don't much) --
> > maybe they can have a look.
>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
>
>
> >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Java 9+ build issues

[Dominik Stadler]

Hi,

sorry for breaking the build, unfortunately these Java 9+ module stuff is
quite a mystery for me as well.We can revert to the previous state if you
think your current solution is not final.

Would be nice if we can decide to ditch Java 8 at some point so we can
simplify the build and then have less "works on Java 8, but breaks on Java
9+" issues.

Thanks... Dominik.


On Sat, Jan 22, 2022 at 3:37 PM PJ Fanning 
wrote:

> Hi,
> I've tried to fix the build issues in Java 9+ that happened after
> https://github.com/apache/poi/commit/bba249d52207799dc984efd884353aa4783c1c40
>
> This change seems worthwhile so I tried to fix the underlying compile
> issues but ran into trouble with the test tasks setting module stuff. By
> commenting out this module stuff, the test tasks run again (on my laptop).
> I may not have fixed all the submodules yet and will have to leave it for
> the next few hours.
>
>
> https://github.com/apache/poi/commit/ca9cf3c6f83e06fe2504a01fff4bb7b53f44f577
>
> https://github.com/apache/poi/commit/1ee199b1ea8ce524d734aa5e9fa7fbe0c4a52ac0
>
> If anyone knows more about Jigsaw modules than me (and I don't much) --
> maybe they can have a look.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache POI 5.2.0 release (RC2)

[Dominik Stadler]

On Logging dependencies: As far as I understand it, we should not deliver
such "log-framework-x to log-framework-y" dependencies as part of a library
as it can lead to endless-loops of forwarding logs back and forth if an
application or another library includes the reverse forwarding.

So my proposal would be that we only document that some transitive
dependencies of Apache POI use slf4j and thus dependencies on either the
bridge "log4j -> slf4j" or "slf4j -> log4j" should be added by users,
depending on what framework the application wants to use.

Thanks... Dominik.


On Sun, Jan 9, 2022 at 10:36 PM Andreas Beeker  wrote:

> +1 from me. Thank you for providing the release, PJ!
>
> Eventually we need to decide, if we only provide the logging api jars or
> also the implementation,
> as SLF4J is used at least in XmlSec and providing the api is not enough
> [1].
> On the other side for log4j-shell, we had the excuse of only providing the
> api ...
>
> Andi
>
> [1] https://logging.apache.org/log4j/2.x/log4j-slf4j-impl/index.html
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache POI 5.2.0 release (RC2)

[Dominik Stadler]

Hi,

mass-regression testing looks good, we now actually successfully process
2695 documents which failed before in 5.1.0, nice!

also a quick comparison of release files looks good.

+1 from me.

Thanks... Dominik.


On Fri, Jan 7, 2022 at 5:33 PM Axel Howind  wrote:

> +1
>
>
>
> > Am 07.01.2022 um 09:44 schrieb PJ Fanning :
> >
> > Hi everyone,
> >
> > I've prepared artifacts for the release of Apache POI 5.2.0 (RC2).
> >
> >
> > The most notable changes in this release are:
> >
> > * upgrade dependencies: XmlBeans 5.0.3, XMLSec 2.3.0, BouncyCastle 1.70,
> Log4j-API 2.17.1, PDFBox Graphics2d 0.34, PDFBox 2.0.25 ...
> >
> > * Issue in XSSFReader where string builder is not always cleared between
> cell reads [#65676]
> >
> > * Extra DataFormatter options [#63211], [#65703], [#65730]
> >
> > * Password Protecting a document when Saxon is on classpath can corrupt
> the output [#65701]
> >
> > * stop using file deleteOnExit in DefaultTempFileCreationStrategy
> [#65772]
> >
> > * Refactor to XSSFReader, SharedStringsTable, CommentsTable and
> ThemesTable to make them more extensible
> >
> > * Support for Excel functions XMATCH, XLOOKUP
> >
> > * Extra checks for malicious files that could cause excess memory usage
> >
> >
> >
> > A full list of changes is available in the change log:
> >
> > https://poi.apache.org/changes.html
> >
> >
> > The artifacts are at:
> >
> > https://dist.apache.org/repos/dist/dev/poi/
> >
> >
> >
> > You can use this maven URL for your mvn/gradle builds:
> >
> > https://repository.apache.org/content/repositories/staging
> >
> >
> > I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
> >
> >
> > Please vote to release the artifacts.
> >
> >
> > The vote keeps open until 2022-01-14 23:00 UTC.
> >
> >
> > Planned release announcement date is Saturday, 2022-01-15.
> >
> >
> >
> > Here is my +1
> >
> > PJ
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache POI 5.2.0 release (RC1)

[Dominik Stadler]

Hi,

I did a partial regression-test round and found a few smaller issues, some
of the new limits are hit by some valid test-files, so I increased a few of
those a bit. Not sure how likely such documents are encountered out there,
but if we want to keep handling those without regressions, we should roll a
RC2 with latest trunk.

Otherwise regression tests look good with only very few failures which are
explained by more support for features in HSLF.

Dominik.


On Wed, Jan 5, 2022 at 2:12 PM PJ Fanning 
wrote:

> Hi everyone,
>
>
> I've prepared artifacts for the release of Apache POI 5.2.0 (RC1).
>
>
> The most notable changes in this release are:
>
> * upgrade dependencies: XmlBeans 5.0.3, XMLSec 2.3.0, BouncyCastle 1.70,
> Log4j-API 2.17.1, PDFBox Graphics2d 0.34, PDFBox 2.0.25 ...
> * Issue in XSSFReader where string builder is not always cleared between
> cell reads [#65676]
> * Extra DataFormatter options [#63211], [#65703], [#65730]
> * Password Protecting a document when Saxon is on classpath can corrupt
> the output [#65701]
> * stop using file deleteOnExit in DefaultTempFileCreationStrategy [#65772]
> * Support for Excel functions XMATCH, XLOOKUP
> * Extra checks for malicious files that could cause excess memory usage
>
>
>
> A full list of changes is available in the change log:
>
> https://poi.apache.org/changes.html
>
>
> The artifacts are at:
>
> https://dist.apache.org/repos/dist/dev/poi/
>
>
> You can use this maven URL for your mvn/gradle builds:
>
> https://repository.apache.org/content/repositories/staging
>
>
>
> I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
>
>
> Please vote to release the artifacts.
>
>
> The vote keeps open until 2022-01-12 23:00 UTC.
>
>
>
> Planned release announcement date is Friday, 2021-12-31.
>
>
>
> Here is my +1
>
> PJ
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache XmlBeans 5.0.3 release (RC2)

[Dominik Stadler]

+1

Thanks for another well-built release!

Dominik.


On Thu, Dec 23, 2021 at 9:11 PM PJ Fanning 
wrote:

> Hi everyone,
>
> I've prepared artifacts for the release of Apache XmlBeans 5.0.3 (RC2).
>
> The most notable changes in this release are:
>
> * SampleXmlUtil misses root element with only one child
> * Duplicated "xmlns" attribute in XmlObject.toString() result
> * Upgrade dependencies (javaparser 3.23.1, log4j 2.17.0)
>
>
> A full list of changes is available in the change log:
>
> https://issues.apache.org/jira/projects/XMLBEANS/versions/12350699
>
>
> The artifacts are at:
>
> https://dist.apache.org/repos/dist/release/poi/xmlbeans/dev/
>
>
>
> You can use this maven URL for your mvn/gradle builds:
>
> https://repository.apache.org/content/repositories/staging
>
>
>
> I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
>
>
> Please vote to release the artifacts.
>
> The vote keeps open until 2021-12-29 23:00 UTC.
>
> Planned release announcement date is Friday, 2021-12-31.
>
>
> Here is my +1
>
>
> PJ
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache XmlBeans 5.0.3 release (RC1)

[Dominik Stadler]

+1,

looks good from a quick look, thanks for preparing the release!

Dominik.

On Sun, Dec 12, 2021 at 10:55 PM Andreas Beeker 
wrote:

> +1 - I've compared the contents of 5.0.2 vs 5.0.3, and only saw those
> minimal changes.
>
> Thank you for providing the RC.
>
> Andi
>
> On 12.12.21 20:56, PJ Fanning wrote:
> > Hi everyone,
> >
> > I've prepared artifacts for the release of Apache XmlBeans 5.0.3 (RC1).
> >
> > The most notable changes in this release are:
> >
> > * SampleXmlUtil misses root element with only one child
> > * Upgrade dependencies (javaparser 3.23.1, log4j 2.15.0)
> >
> >
> > A full list of changes is available in the change log:
> > https://issues.apache.org/jira/projects/XMLBEANS/versions/12350699
> >
> > The artifacts are at:
> > https://dist.apache.org/repos/dist/release/poi/xmlbeans/dev/
> >
> >
> > You can use this maven URL for your mvn/gradle builds:
> > https://repository.apache.org/content/repositories/staging
> >
> >
> >
> > I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
> >
> > Please vote to release the artifacts.
> > The vote keeps open until 2021-12-15 23:00 UTC.
> > Planned release announcement date is Friday, 2021-12-17.
> >
> >
> > Here is my +1
> >
> >
> > PJ
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: flaky tests on CI/CD

[Dominik Stadler]

Hi P.J.

for parallel building, it should be disabled via CI_BUILD=TRUE environment
variable, but maybe this is not working properly, do you have a link to a
failing build? I could only see the SVN timeouts in recent failures.

For the SVN timeouts, hopefully
https://issues.apache.org/jira/browse/INFRA-22568 will get some care soon.

Some JDK 17 builds still fail with the Java bug that you reported to
OpenJDK at https://bugs.openjdk.java.net/browse/JDK-8275610 , in the
meantime Oracle has confirmed the bug. We might be able to exclude some
classes from optimizations as getting a fixed JDK likely takes some more
time.

Dominik.

On Thu, Nov 25, 2021 at 1:30 PM PJ Fanning 
wrote:

> Thanks Nick. I sent this email -
> https://mail-archives.apache.org/mod_mbox/www-builds/202111.mbox/%3CCAMRKCNE%3Dvfq5y4n%3DQv0-tmRvTxT2A-qzuKTaRa6fiGPfNmQBCw%40mail.gmail.com%3E
>
>
>
>
>
>
> On Thursday 25 November 2021, 12:26:13 GMT+1, Nick Burch <
> apa...@gagravarr.org> wrote:
>
>
>
>
>
> On Thu, 25 Nov 2021, PJ Fanning wrote:
>
> > There are other issues on the CI/CD tests. For
> > example, https://ci-builds.apache.org/job/POI/job/POI-DSL-1.11/ just
> > keeps failing with svn issues. It's like the machine(s) that support
> > Java 11 have an issue. Is there somewhere we can report this?
>
>
> Based on https://ci.apache.org/ I think the folks who could help hang out
> on builds@ - see https://mail-archives.apache.org/mod_mbox/www-builds/
>
> Nick
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Move poi:main:org.apache.poi.hssf.dev to poi:test

[Dominik Stadler]

Hi,

using them in the intergration test originally was just a "hey, let's cover
those things also in our integration tests", so originally it was the other
way around: standalone dev-tools that we covered in our tests a bit.
Having them as standalone tools in "examples" sounds nice, as they still
can full-fill a small and defined purpose outside of tests, maybe also for
some of our more experienced users.

Dominik.


On Thu, Nov 25, 2021 at 10:01 PM Andreas Beeker 
wrote:

> Hi Dominik,
>
> there's a replacement, but with a limitation.
>
> the limitation: asking users to execute BiffViewer with the poi.jar won't
> work anymore.
> I can't remember having seen this request ever.
>
> In other usecases - use the Junit c org.apache.poi.hssf.dev directly.
> Those contain now the functionality originally provided by the poi::main
> classes.
> Overriding BaseTestIteratingXLS::files() makes it easy to define the files
> to be parsed.
> I usually prefer test drivers to main() invocations and also use test
> drivers when developing examples.
>
> For the visual inclined (aka Klickibunti), there's another alternative:
> https://github.com/kiwiwings/poi-visualizer
>
> Andi
>
> On 25.11.21 07:32, Dominik Stadler wrote:
> > Hi Andi,
> >
> > It seems you removed the main() method from BiffViewer as part of this
> > move. This was a handy tool on it's own for inspecting the raw contents
> of
> > .xls files, fairly useful when investigating bugs with handling of the
> raw
> > format in HSSF. Is there a replacement?
> >
> > Not sure about the other tools that are gone now, they might be useful
> for
> > some specific things, but at least I did not use them much.
> >
> > Thanks... Dominik.
> >
> > On Sun, Nov 14, 2021 at 3:31 PM Andreas Beeker 
> wrote:
> >
> >> Hi Devs,
> >>
> >> those *-saved.xls left-overs in the test-data directory cause/d build
> >> problems.
> >> I'm quite sure those are created by org.apache.poi.hssf.dev.ReSave.
> >> I'll now move all development utils of that package to poi:test and
> change
> >> the output directory to the temp path, because I think those tools are
> used
> >> by developers working on the source / project ... or I'll remove a few
> >> completely, as the same functionality is invoked many times by the other
> >> tests.
> >>
> >> Andi
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> >> For additional commands, e-mail: dev-h...@poi.apache.org
> >>
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Move poi:main:org.apache.poi.hssf.dev to poi:test

[Dominik Stadler]

Hi Andi,

It seems you removed the main() method from BiffViewer as part of this
move. This was a handy tool on it's own for inspecting the raw contents of
.xls files, fairly useful when investigating bugs with handling of the raw
format in HSSF. Is there a replacement?

Not sure about the other tools that are gone now, they might be useful for
some specific things, but at least I did not use them much.

Thanks... Dominik.

On Sun, Nov 14, 2021 at 3:31 PM Andreas Beeker  wrote:

> Hi Devs,
>
> those *-saved.xls left-overs in the test-data directory cause/d build
> problems.
> I'm quite sure those are created by org.apache.poi.hssf.dev.ReSave.
> I'll now move all development utils of that package to poi:test and change
> the output directory to the temp path, because I think those tools are used
> by developers working on the source / project ... or I'll remove a few
> completely, as the same functionality is invoked many times by the other
> tests.
>
> Andi
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: ExcelCetabFunctionExtractor/functionMetadataCetab.txt and FILTER function

[Dominik Stadler]

Hi,

it seems I was the last one touching this around 2 1/2 years ago, but
unfortunately I do not remember exactly why/how.

I found the file functionMetadataCetab-PDF.txt still lying around on my
disk, it seems to be some extract of the PDF-SPECS that I did at that time.

I attach it here, maybe it helps you in some way with this topic.

Dominik..

On Fri, Oct 22, 2021 at 3:39 PM PJ Fanning 
wrote:

> Hi,
>
> Does anyone know anything about ExcelCetabFunctionExtractor
> and functionMetadataCetab.txt?
>
> The file that ExcelCetabFunctionExtractor needs seems to be missing.
> -- org/apache/poi/ss/formula/function/functionMetadataCetab-PDF.txt
>
> There is an issue related to FILTER function and how POI thinks that this
> function takes 0 params (when it should take many params).
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=65643
>
>
>
> Regards,
> PJ
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>
0x
BEEP
beep-params = [val]
0x0001
OPEN
open-params = *17(val)
0x0002
OPEN.LINKS
open-links-params = *15(val)
0x0003
CLOSE.ALL
This function takes no parameters
756 / 1185
[MS-XLS] — v20141018
Excel Binary File Format (.xls) Structure
Copyright © 2014 Microsoft Corporation.
Release: October 30, 2014Value Meaning
0x0004 SAVE
This function takes no parameters
0x0005
SAVE.AS
save-as-params = *7(val)
0x0006
FILE.DELETE
file-delete-params = [val]
0x0007
PAGE.SETUP
page-setup-params = *30(val)
0x0008
PRINT
print-params = *17(val)
0x0009
PRINTER.SETUP
printer-setup-params = [val]
0x000A
QUIT
This function takes no parameters
0x000B
NEW.WINDOW
This function takes no parameters
0x000C
ARRANGE.ALL
arrange-All-params = *4(val)
0x000D
WINDOW.SIZE
window-size-params = *3(val)
0x000E
WINDOW.MOVE
window-move-params = *3(val)
0x000F
FULL
full-params = [val]
0x0010
CLOSE
close-params = *2(val)
0x0011
RUN
run-params = [(ref / val), [val]]
0x0016
SET.PRINT.AREA
set-print-area-params = [ref / val]
757 / 1185
[MS-XLS] — v20141018
Excel Binary File Format (.xls) Structure
Copyright © 2014 Microsoft Corporation.
Release: October 30, 2014Value Meaning
0x0017 SET.PRINT.TITLES
set-print-titles-params = *2(ref / val)
0x0018
SET.PAGE.BREAK
This function takes no parameters
0x0019
REMOVE.PAGE.BREAK
remove-page-break-params = *2(val)
0x001A
FONT
font-params = *2(val)
0x001B
DISPLAY
display-params = *9(val)
0x001C
PROTECT.DOCUMENT
protect-document-params = *7(val)
0x001D
PRECISION
precision-params = [val]
0x001E
A1.R1C1
a1-r1c1-params = [val]
0x001F
CALCULATE.NOW
This function takes no parameters
0x0020
CALCULATION
calculation-params = *11(val)
0x0022
DATA.FIND
data-find-params = [val]
0x0023
EXTRACT
extract-params = [val]
0x0024
DATA.DELETE
This function takes no parameters
0x0025
SET.DATABASE
This function takes no parameters
0x0026
SET.CRITERIA
This function takes no parameters
758 / 1185
[MS-XLS] — v20141018
Excel Binary File Format (.xls) Structure
Copyright © 2014 Microsoft Corporation.
Release: October 30, 2014Value Meaning
0x0027 SORT
sort-params = [val, [(ref / val), [(ref / val), [(ref / val), [(ref / val), 
[(ref / val), [(ref / val), *10(val)]]]
0x0028
DATA.SERIES
data-series-params = *6(val)
0x0029
TABLE
table-params = *2(ref / val)
0x002A
FORMAT.NUMBER
format-number-params = [val]
0x002B
ALIGNMENT
alignment-params = *10(val)
0x002C
STYLE
style-params = *2(val)
0x002D
BORDER
border-params = *27(val)
0x002E
CELL.PROTECTION
cell-protection-params = *2(val)
0x002F
COLUMN.WIDTH
column-width-params = [val, *4(ref / val)]
0x0030
UNDO
This function takes no parameters
0x0031
CUT
cut-params = *2(ref / val)
0x0032
COPY
copy-params = *2(ref / val)
0x0033
PASTE
paste-params = [ref / val]
0x0034
CLEAR
clear-params = [val]
0x0035
PASTE.SPECIAL
759 / 1185
[MS-XLS] — v20141018
Excel Binary File Format (.xls) Structure
Copyright © 2014 Microsoft Corporation.
Release: October 30, 2014Value
Meaning
paste-special-params = *7(val)
0x0036
EDIT.DELETE
edit-delete-params = [val]
0x0037
INSERT
insert-params = *2(val)
0x0038
FILL.RIGHT
This function takes no parameters
0x0039
FILL.DOWN
This function takes no parameters
0x003D
DEFINE.NAME
define-name-params = [val, [(ref / val), [(ref / val), [(ref / val), [(ref / 
val), [(ref / val),[val]]]
0x003E
CREATE.NAMES
create-names-params = *4(val)
0x003F
FORMULA.GOTO
formula-goto-params = [(ref / val), [val]]
0x0040
FORMULA.FIND
formula-find-params = *12(val)
0x0041
SELECT.LAST.CELL
This function takes no parameters
0x0042
SHOW.ACTIVE.CELL
This function takes no parameters
0x0043
GALLERY.AREA
gAllery-area-params = *2(val)
0x0044
GALLERY.BAR
gAllery-bar-params = *2(val)
0x0045
GALLERY.COLUMN
gAllery-column-params = *2(val)
0x0046
GALLERY.LINE
gAllery-line-params = *2(val)
760 / 1185
[MS-XLS] — v20141018
Excel Binary File Format (.xls) Structure
Copyright © 2014 Microsoft Corporation.
Release: October 30, 2014Value Meaning
0x0047 GALLERY.PIE

Re: [VOTE] Apache POI 5.1.0 release (RC2)

[Dominik Stadler]

+1 from me, compared the contents of jars/zips/targzs and looks good. Also
tried to upgrade a small tool which uses POI, which worked fine.

One small thing: Probably does not block the release but the
"poi-scratchpad" is missing from the Maven Staging repository.

Thanks a lot for pushing the release! Dominik.


On Mon, Oct 25, 2021 at 1:55 PM PJ Fanning 
wrote:

> Hi everyone,
>
> I've prepared artifacts for the release of Apache POI 5.1.0 (RC2).
>
> The most notable changes in this release are:
>
> * upgrade dependencies: XmlBeans 5.0.2, XMLSec 2.2.3, Batik 1.14,
> BouncyCastle 1.69, Commons-Compress 1.21, ...
> * switching build to Gradle - Ant build is not supported anymore [#65206]
> * XSLFTable::addRow functionality reverted to pre-5.0.0 [github-221]
> * XSSFDrawing - import chart from other drawing [#63901]
> * Support for Excel functions IFS, SWITCH, TEXTJOIN, IFNA, MAXIFS, MINIFS,
> AVERAGEIFS, TDIST
> * Fix SVG-related image rendering
>
> https://dist.apache.org/repos/dist/dev/poi/5.1.0-RC2/
>
> https://repository.apache.org/content/groups/staging/org/apache/poi/
>
>
> Things to check:
> According to Stackoverflow there were some problems with JPMS and XmlBeans
> -
> so maybe check for potential problems there.
>
> Please vote to release the artifacts.
> The vote keeps open until November 1, 2021 (23:00 UTC)
> Planned release announcement date is November 3, 2021.
>
> Here is my +1
>
> The SVN repo is open again. Can we avoid major changes until this vote
> succeeds or starts getting -1s.
>
> PJ
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Thank you! JDK 18 Early Access build 20 is now available

[Dominik Stadler]

Thanks Rory for all the work! We wish you a happy time with your family!

And welcome to David!

The Quality Outreach program is really a big improvement for us, having a
more direct way of discussing issues that our testing reveals on
pre-releases helps us a lot when testing the library and improves quality
of the JavaVM releases considerably!

Thanks... Dominik
(on behalf of the Apache POI developer community)


On Tue, Oct 26, 2021 at 2:48 PM Rory O'Donnell 
wrote:

> Hi Dominik,
>
> *Thank you.*
>
> I'm retiring at the end of November 2021, it's time to spend more time
> with the family.
>
> We started the Quality Outreach back in October 2014.  We now have 170+
> projects participating.
> Thank you for taking the time to provide Testing feedback , excellent
> bugs and support throughout
> the last seven years.
>
> It's been a pleasure working with you. I am delighted to say that the
> program will continue
> with the support of the Java DevRel Team, with David Delabassee as your
> contact. David has
> been assisting with on-boarding new projects for the last couple of years.
>
> All the best, Rory
>
>
> *OpenJDK 18Early Access build 20is now available
> at**https://jdk.java.net/18/ **
> *
>
>   * These early-access , open-source builds are provided under the
>   o GNU General Public License, version 2, with the Classpath
> Exception .
>   * Release Notes are available athttps://jdk.java.net/18/release-notes
> 
>   * Features:
>   o JEPs integrated to JDK 18, so far:
>   + JEP 400: UTF-8 by Default 
>   + JEP 408: Simple Web Server 
>   + JEP 413: Code Snippets in Java API Documentation
> 
>   o JEPs targeted to JDK 18, so far
>   + JEP 417: Vector API (Third Incubator)
> 
>   o JEPs proposed to target JDK 18:
>   + JEP 416: Reimplement Core Reflection with Method Handles
> 
>
>   * Significant changes since the last availability email:
>   o Build 20:
>   + JDK-8275252: Migrate cacerts from JKS to password-less PKCS12
>   + JDK-8275149: (ch) ReadableByteChannel returned by
> Channels.newChannel(InputStream) throws ReadOnlyBufferException
>   + JDK-8266936: Add a finalization JFR event
>   + JDK-8264849: Add KW and KWP support to PKCS11 provider
>   o Build 19:
>   + JDK-8274840: Update OS detection code to recognize Windows 11
>   + JDK-8274407: (tz) Update Timezone Data to 2021c
>   + JDK-8273102: Delete deprecated for removal the empty
> finalize() in java.desktop module
>   o Build 18:
>   + JDK-8274656: Remove default_checksum and safe_checksum_type
> from krb5.conf
>   + JDK-8274471: Add support for RSASSA-PSS in OCSP Response
>   + JDK-8274227: Remove "impl.prefix" jdk system property usage
> from InetAddress
>   + JDK-8274002: [win11 and winserver2022] JDK executable
> installer from network drive starts with huge delay
>   + JDK-8273670: Remove weak etypes from default krb5 etype list
>   o Build 17:
>   + JDK-8273401: Disable JarIndex Support In URLClassPath
>   + JDK-8231640: (prop) Canonical property storage
>   + Build 16:
>   + JDK-8269039: Disable SHA-1 Signed JARs
>
> *Topics of Interest:*_
> _
>
> _JDK 17:_**
> **
>
>   * *Inside Java Podcast “Java 17 is Here!”*
>   o *Part 1: https://inside.java/2021/09/14/podcast-019/
> *
>   o *Part 2: https://inside.java/2021/09/27/podcast-020/
> *
>   * *G1 GC & Parallel GC Improvements in JDK 17*
>   o *https://inside.java/2021/09/17/jdk-17-gc-updates/
> *
>   * ZGC - What's new in JDK 17**
>   o *https://inside.java/2021/10/05/zgc-in-jdk17/
> *
>   * JDK 17 Security Enhancements**
>   o *https://inside.java/2021/09/15/jdk-17-security-enhancements/
> *
>   * The Vector API in JDK 17 (video)**
>   o *https://inside.java/2021/09/23/devlive-vector-api/
> *
>   * Faster Charset Encoding**
>   o *https://inside.java/2021/10/17/faster-charset-encoding/
> *
>
> _JDK 18:_
>
>   * JEP 400 and the Default Charset
>   o https://inside.java/2021/10/04/the-default-charset-jep400/
> 

Re: POI 5.1.0 RC2?

[Dominik Stadler]

Hi,

The re-run with "full" is now available at
http://people.apache.org/~centic/poi_regression/reports/index500RC2to510RC2.html

1089 failed files compared to 5.0.0, mostly XDDF, only a few others.

Also 300 files that now fail with some "invalid ZIP", seems Apache Compress
is a bit more "picky" on some half-broken files compared to the Java Zip
classes, but there is likely not much we can do.

BTW, 1377 failed before, but now work fine, so overall we already improved
things!

Thanks... Dominik.




On Tue, Oct 19, 2021 at 6:59 PM Tim Allison  wrote:

> Apologies for being absent... The xsb issue is why we haven't upgraded
> to 5.x on Tika yet.  I _think_ we'd like to avoid the ooxml-full jar,
> but if that's the most robust option, we'll have to go with that.
>
> I'm also happy to grab new files, or run against our corpus if that'd
> be of any use.
>
> Many thanks!
>
>Best,
>
>  Tim
>
> On Tue, Oct 19, 2021 at 11:57 AM Dominik Stadler 
> wrote:
> >
> > Hi,
> >
> > You are right, we discussed the reasons before, I am sorry.
> >
> > LG... Dominik.
> >
> > On Mon, Oct 18, 2021 at 9:06 PM Andreas Beeker 
> wrote:
> >
> > > Hi Dominik,
> > >
> > > > Would be nice to know what changes made them required now as the
> > > documents themselves did not change.
> > >
> > > I think you know, but to be safe, I mentioned it again.
> > > Originally only the classes where filtered, but I've added the .xsb
> > > filtering also a while ago, to minimize the lite jar further,
> > > because they are a substantial part of the jar.
> > >
> > > I could iterate through all document parts and try to see if those
> parts
> > > are parsed and check the structure recursive.
> > >
> > > On the other hand, I've optimized the xmlbeans schema generation, so
> the
> > > schema shrunk from 19mb to 13mb.
> > > There would be the option to split the schema jar to the sub schemas
> > > including the necessary dependencies to the base/abstract schemas -
> but I
> > > guess this will be even more confusing for the user base.
> > >
> > > Regarding the 107 documents, it's fairly easy to add the documents
> locally
> > > and see which deltas, i.e. not yet loaded .xsbs, are added from file to
> > > file, to identify the files which needed to be added to the integration
> > > directory.
> > >
> > > Andi.
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > > For additional commands, e-mail: dev-h...@poi.apache.org
> > >
> > >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: POI 5.1.0 RC2?

[Dominik Stadler]

Hi,

You are right, we discussed the reasons before, I am sorry.

LG... Dominik.

On Mon, Oct 18, 2021 at 9:06 PM Andreas Beeker  wrote:

> Hi Dominik,
>
> > Would be nice to know what changes made them required now as the
> documents themselves did not change.
>
> I think you know, but to be safe, I mentioned it again.
> Originally only the classes where filtered, but I've added the .xsb
> filtering also a while ago, to minimize the lite jar further,
> because they are a substantial part of the jar.
>
> I could iterate through all document parts and try to see if those parts
> are parsed and check the structure recursive.
>
> On the other hand, I've optimized the xmlbeans schema generation, so the
> schema shrunk from 19mb to 13mb.
> There would be the option to split the schema jar to the sub schemas
> including the necessary dependencies to the base/abstract schemas - but I
> guess this will be even more confusing for the user base.
>
> Regarding the 107 documents, it's fairly easy to add the documents locally
> and see which deltas, i.e. not yet loaded .xsbs, are added from file to
> file, to identify the files which needed to be added to the integration
> directory.
>
> Andi.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: POI 5.1.0 RC2?

[Dominik Stadler]

Hi,

See the report at
http://people.apache.org/~centic/poi_regression/reports/index500RC2to510RC1.html
, one of the files is
http://people.apache.org/~centic/poi_regression/reports/bib-chernigovka.netdo.ru_download_docs_17459.doc
(it's actually a docx, so is processed via XSSFFileHandler).

Thanks... Dominik.

On Mon, Oct 18, 2021 at 5:06 PM PJ Fanning 
wrote:

> Hi Dominik,
> Would you be able to provide one of the files that causes the missing xsb
> issues? I could try debugging to see if I can see why it fails.
>
>
>
>
>
> On Monday 18 October 2021, 12:12:02 IST, PJ Fanning
>  wrote:
>
>
>
>
>
> Maybe POI 5.1.0 poi-ooxml can default to poi-ooxml-full as the dependency
> and we could produce the lite jar with a health warning and documentation
> about how to use that instead if you choose to? After POI 5.1.0, we could
> see if the community needs the lite jar at all. Some users still try to use
> POI on android and maybe they would prefer smaller jar sizes.
>
>
>
>
>
>
> On Monday 18 October 2021, 11:54:04 IST, Dominik Stadler <
> dominik.stad...@gmx.at> wrote:
>
>
>
>
>
> Hi,
>
> hm, would be fairly tedious to look for up to 107 documents and add all of
> them to the integration-tests. Would be nice to know what changes made them
> required now as the documents themselves did not change. For now I will
> trigger another mass-testing run with "full" sometimes this week.
>
> FYI, as "lite" is only 3-times smaller than "full" nowadays and disk-sizes
> and download speeds have greatly improved over the years I will propose
> removal of the "lite" jar and all the related pieces after the 5.1.0
> release. The amount of work we put into this is very high and gains for our
> uses are small by now. Even the recent JDK 17 segfaults in CI may be
> related to byte-code rewriting that is done for this. Also building locally
> takes ages because nearly every Gradle target has to run all tests
> including integration-tests now, very hard to do anything useful, at least
> for me.
>
> Dominik.
>
>
>
> On Mon, Oct 18, 2021 at 11:40 AM PJ Fanning 
> wrote:
>
> > Thanks Dominik for running the tests. I'm not sure what the best approach
> > is but adding some of the files that cause the missing xsb issues to the
> > poi-test-data dir might be a good starting point.
> >
> >
> >
> >
> >
> >
> > On Monday 18 October 2021, 08:05:21 IST, Dominik Stadler <
> > dominik.stad...@gmx.at> wrote:
> >
> >
> >
> >
> >
> > FYI, I did re-run the mass-testing and the missing schema is still
> > reported a lot (>90k times).
> >
> > One sample missing xsb is
> > org/apache/poi/schemas/ooxml/system/ooxml/backgroundelement.xsb
> >
> > This was also not included in the "lite" package in 5.0.0, so it seems
> > some code-change now requires this, but it is not included
> automatically...
> >
> > I extracted the attached list of 107 missing XSBs.
> >
> > Dominik.
> >
> >
> > On Fri, Oct 15, 2021 at 1:17 AM Andreas Beeker 
> > wrote:
> > > "Kept you waiting, huh?" (tm) -No problem for me ... XmlBeans RC2 looks
> > good so far, therefore it can be only a matter of days.
> > >
> > >
> > > On 15.10.21 00:06, PJ Fanning wrote:
> > >> With POI trunk, I've added a use case that relies on XMLBeans 5.0.2
> > release. Can we wait until XMLBeans 5.0.2 is released? Alternatively, I
> can
> > remove the new POI code that use XmlOptions
> setDisallowDocTypeDeclaration.
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > > For additional commands, e-mail: dev-h...@poi.apache.org
>
>
> > >
> > >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: POI 5.1.0 RC2?

[Dominik Stadler]

Hi,

hm, would be fairly tedious to look for up to 107 documents and add all of
them to the integration-tests. Would be nice to know what changes made them
required now as the documents themselves did not change. For now I will
trigger another mass-testing run with "full" sometimes this week.

FYI, as "lite" is only 3-times smaller than "full" nowadays and disk-sizes
and download speeds have greatly improved over the years I will propose
removal of the "lite" jar and all the related pieces after the 5.1.0
release. The amount of work we put into this is very high and gains for our
uses are small by now. Even the recent JDK 17 segfaults in CI may be
related to byte-code rewriting that is done for this. Also building locally
takes ages because nearly every Gradle target has to run all tests
including integration-tests now, very hard to do anything useful, at least
for me.

Dominik.



On Mon, Oct 18, 2021 at 11:40 AM PJ Fanning 
wrote:

> Thanks Dominik for running the tests. I'm not sure what the best approach
> is but adding some of the files that cause the missing xsb issues to the
> poi-test-data dir might be a good starting point.
>
>
>
>
>
>
> On Monday 18 October 2021, 08:05:21 IST, Dominik Stadler <
> dominik.stad...@gmx.at> wrote:
>
>
>
>
>
> FYI, I did re-run the mass-testing and the missing schema is still
> reported a lot (>90k times).
>
> One sample missing xsb is
> org/apache/poi/schemas/ooxml/system/ooxml/backgroundelement.xsb
>
> This was also not included in the "lite" package in 5.0.0, so it seems
> some code-change now requires this, but it is not included automatically...
>
> I extracted the attached list of 107 missing XSBs.
>
> Dominik.
>
>
> On Fri, Oct 15, 2021 at 1:17 AM Andreas Beeker 
> wrote:
> > "Kept you waiting, huh?" (tm) -No problem for me ... XmlBeans RC2 looks
> good so far, therefore it can be only a matter of days.
> >
> >
> > On 15.10.21 00:06, PJ Fanning wrote:
> >> With POI trunk, I've added a use case that relies on XMLBeans 5.0.2
> release. Can we wait until XMLBeans 5.0.2 is released? Alternatively, I can
> remove the new POI code that use XmlOptions setDisallowDocTypeDeclaration.
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache XmlBeans 5.0.2 release (RC2)

[Dominik Stadler]

Hi,

Thanks for the changes, this looks good now when comparing 5.0.2 to 5.0.1
binaries and sources!

And using the binaries directly from the Jenkins job is a good idea, then
we avoid local variations and have a canonical environment which produces
releases! Not sure how much is missing so we can also do this for POI
itself?


+1 from me!


Thanks... Dominik.



On Thu, Oct 14, 2021 at 11:10 PM Andreas Beeker 
wrote:

> Thank you again for providing the RC2 immediately.
>
> As we provide the module-info, the Automatic-Module-Name is probably not
> needed.
>
> So +1 from me.
>
> Andi
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache XmlBeans 5.0.2 release (RC1)

[Dominik Stadler]

Hi,

I compared the contents of packages for 5.0.2 with 5.0.1, I found some
differences that we should check:

* dist.apache.org
\repos\dist\release\poi\xmlbeans\dev\bin\xmlbeans-bin-5.0.2-20211013.tgz\xmlbeans-5.0.2\samples\MixedContent\build
* dist.apache.org
\repos\dist\release\poi\xmlbeans\dev\bin\xmlbeans-bin-5.0.2-20211013.tgz\xmlbeans-5.0.2\samples\OrderMatters\build

Also the source-packages contain a few:

* dist.apache.org
\repos\dist\release\poi\xmlbeans\dev\src\xmlbeans-src-5.0.2-20211013.tgz\xmlbeans-5.0.2\samples\MixedContent\build
* dist.apache.org
\repos\dist\release\poi\xmlbeans\dev\src\xmlbeans-src-5.0.2-20211013.tgz\xmlbeans-5.0.2\samples\OrderMatters\build
* dist.apache.org
\repos\dist\release\poi\xmlbeans\dev\src\xmlbeans-src-5.0.2-20211013.tgz\xmlbeans-5.0.2\samples\SampleTemplate\build

Additionally sources contain a directory "vxsdb" which looks strange.

The sources now include a binary file xcresolver.zip, I expect this is
on-purpose: dist.apache.org
\repos\dist\release\poi\xmlbeans\dev\src\xmlbeans-src-5.0.2-20211013.tgz\xmlbeans-5.0.2\external\lib\xcresolver.zip

In the "maven" folder, the files are now in a sub-folder
"org\apache\xmlbeans\xmlbeans\5.0.2\", not sure if this is on-purpose.

Also the doap_XMLBeans.rdf file is not updated with 5.0.1/5.0.2, but this
is not relevant for the release as far as I see.


Thanks... Dominik.


On Wed, Oct 13, 2021 at 10:50 PM PJ Fanning 
wrote:

> Hi *,
>
> I've prepared artifacts for the release of Apache XmlBeans 5.0.2 (RC1).
>
> The most notable changes in this release are:
>
> * When generating Java code, there is a wrong reference to
> java.util.Object[]
> * support disallow-doctype-decl setting on XML parser
> * Fix issue where you can get a StackOverflowError when parsing a large
> number of characters in an XML element
>
>
> A full list of changes is available in the change log:
> https://issues.apache.org/jira/projects/XMLBEANS/versions/12350390
>
> The artifacts are at:
> https://dist.apache.org/repos/dist/release/poi/xmlbeans/dev/
>
> You can use this maven URL for your mvn/gradle builds:
> https://dist.apache.org/repos/dist/release/poi/xmlbeans/dev/maven
>
>
>
>
> I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
>
> Please vote to release the artifacts.
> The vote keeps open until 2021-10-20 23:00 UTC.
> Planned release announcement date is Friday, 2021-10-22.
>
> Here is my +1
>
> PJ
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: XMLBeans 5.0.2 release

[Dominik Stadler]

Yes, thanks for all the work! Go for it!

Dominik.

On Wed, Oct 13, 2021 at 7:57 PM Andreas Beeker  wrote:

> Hi PJ;
>
> thank you for all the work you've put in the last months - actually
> unbelievable.
> I think it's good, if someone else gives releasing also a try - so +1 from
> me.
> As I made a mistake last time - please make sure to use JDK 8 for the
> build.
>
> Andi
>
>
> On 13.10.21 15:29, PJ Fanning wrote:
> > I don't think this blocks a release of POI 5.1.0. There are still a few
> fixes in XMLBeans trunk awaiting release. I can prepare a XMLBeans
> 5.0.2-RC1 if people think this is a good idea.
> >
> >
> https://issues.apache.org/jira/browse/XMLBEANS-572?jql=project%20%3D%20XMLBEANS%20AND%20fixVersion%20%3D%20%22Version%205.0.2%22
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> > For additional commands, e-mail: dev-h...@poi.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: forrest question

[Dominik Stadler]

Hi,

I think this is introduced via the forrest-"skin" that is used, so a proper
fix that avoids having to grep/sed would need a change to Forrest to fix
this.

$ grep -R google.com/search /opt/apache/forrest/apache-forrest-0.9
/opt/apache/forrest/apache-forrest-0.9/main/webapp/skins/pelt/xslt/html/site-to-xhtml.xsl
:http://www.google.com/search;>
/opt/apache/forrest/apache-forrest-0.9/main/webapp/skins/pelt/xslt/html/site-to-xhtml.xsl
:  http://www.google.com/search;>
...

Dominik.

On Fri, Sep 24, 2021 at 9:06 PM PJ Fanning 
wrote:

> When I run forrest on the POI docs, all the google search URLs come up
> with http schemes instead of the https schemes. I generally hand edit the
> files before committing them to put back the https scheme. I've tried a
> variety of sed commands to try to global replace the value but with no
> success.
> Does anyone know a better way?

Re: [VOTE] Apache POI 5.1.0 release (RC1)

[Dominik Stadler]

Preliminary results of the test-run are at

   - 5.0.0-RC2 to 5.1.0-RC1
   
<http://people.apache.org/~centic/poi_regression/reports/index500RC2to510RC1.html>
   - 5.1.0-RC1-All
   
<http://people.apache.org/~centic/poi_regression/reportsAll/index500RC2to510RC1.html>

We now run 3.5mio documents, 200k more than in the previous runs.

There are 88124 failures compared to 5.0.0 due to missing ".xsb" files in
poi-ooxml-lite, e.g. ctsdtrow2f71type and others.

Also a few other failures, NPEs, NotImplementedException, ..., some may
trigger now because new functionality triggers them now, a few are because
commons-math3 was not up-to-date in the test-driver.

Dominik.


On Sat, Sep 4, 2021 at 1:00 PM Dominik Stadler 
wrote:

> Hi,
>
> I started the test-suite today and hopefully can report on it before
> voting ends.
>
> Dominik.
>
> On Sat, Sep 4, 2021 at 1:10 AM PJ Fanning 
> wrote:
>
>> Thanks Andi for prepping the RC.
>>
>> Have we run the test suite with the large number of test files to see if
>> the results are ok?
>>
>>
>>
>>
>>
>> On Friday 3 September 2021, 23:40:08 IST, Andreas Beeker <
>> kiwiwi...@apache.org> wrote:
>>
>>
>>
>>
>>
>> Hi *,
>>
>> I've prepared artifacts for the release of Apache POI 5.1.0 (RC1).
>>
>> The most notable changes in this release are:
>>
>> * upgrade dependencies: XmlBeans 5.0.1, Batik 1.14, BouncyCastle 1.69,
>> Commons-Compress 1.21, ...
>> * switching build to Gradle - Ant build is not supported anymore [#65206]
>> * XSLFTable::addRow functionality reverted to pre-5.0.0 [github-221]
>> * XSSFDrawing - import chart from other drawing [#63901]
>> * Support for Excel functions IFS, SWITCH, TEXTJOIN, IFNA, MAXIFS,
>> MINIFS, AVERAGEIFS
>> * Fix SVG-related image rendering
>>
>> https://dist.apache.org/repos/dist/dev/poi/5.1.0-RC1/
>>
>> Things to check:
>> According to Stackoverflow there were some problems with JPMS and
>> XmlBeans -
>> so maybe check for potential problems there.
>>
>> Please vote to release the artifacts.
>> The vote keeps open until 2021-09-10.
>> Planned release announcement date is Saturday, 2021-09-11.
>>
>> Here is my +1
>>
>> The SVN repo is open again.
>>
>> Andi
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
>> For additional commands, e-mail: dev-h...@poi.apache.org
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
>> For additional commands, e-mail: dev-h...@poi.apache.org
>>
>>

Re: [VOTE] Apache POI 5.1.0 release (RC1)

[Dominik Stadler]

Hi,

When comparing the release files with 5.0.0, I saw the following, not sure
which one are on-purpose and which one should be changed:

* Files poi-5.1.0.pom.sha256 and poi-5.1.0.pom.sha512 are not included
* The jar-files under maven/* do not contain "LICENSE" and "NOTICE" any
more under "META-INF"
* Jar-file "poi.jar" does not contain class "org.apache.poi.Version" any
more
* The MANIFEST.MF file previously had fields for "Specification-*" and
"Implementation-*" which are now missing
* jars for "poi-integration" are not included any more. These are mostly
used for mass-regression-testing, which usually works off of locally built
binaries anyway, so likely not needed.
* the poi-ooxml-lite and poi-ooxml-full packages do not include all the
*Factory classes any more

Thanks... Dominik.



On Sat, Sep 4, 2021 at 12:40 AM Andreas Beeker  wrote:

> Hi *,
>
> I've prepared artifacts for the release of Apache POI 5.1.0 (RC1).
>
> The most notable changes in this release are:
>
> * upgrade dependencies: XmlBeans 5.0.1, Batik 1.14, BouncyCastle 1.69,
> Commons-Compress 1.21, ...
> * switching build to Gradle - Ant build is not supported anymore [#65206]
> * XSLFTable::addRow functionality reverted to pre-5.0.0 [github-221]
> * XSSFDrawing - import chart from other drawing [#63901]
> * Support for Excel functions IFS, SWITCH, TEXTJOIN, IFNA, MAXIFS, MINIFS,
> AVERAGEIFS
> * Fix SVG-related image rendering
>
> https://dist.apache.org/repos/dist/dev/poi/5.1.0-RC1/
>
> Things to check:
> According to Stackoverflow there were some problems with JPMS and XmlBeans
> -
> so maybe check for potential problems there.
>
> Please vote to release the artifacts.
> The vote keeps open until 2021-09-10.
> Planned release announcement date is Saturday, 2021-09-11.
>
> Here is my +1
>
> The SVN repo is open again.
>
> Andi
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: [VOTE] Apache POI 5.1.0 release (RC1)

[Dominik Stadler]

Hi,

I started the test-suite today and hopefully can report on it before voting
ends.

Dominik.

On Sat, Sep 4, 2021 at 1:10 AM PJ Fanning 
wrote:

> Thanks Andi for prepping the RC.
>
> Have we run the test suite with the large number of test files to see if
> the results are ok?
>
>
>
>
>
> On Friday 3 September 2021, 23:40:08 IST, Andreas Beeker <
> kiwiwi...@apache.org> wrote:
>
>
>
>
>
> Hi *,
>
> I've prepared artifacts for the release of Apache POI 5.1.0 (RC1).
>
> The most notable changes in this release are:
>
> * upgrade dependencies: XmlBeans 5.0.1, Batik 1.14, BouncyCastle 1.69,
> Commons-Compress 1.21, ...
> * switching build to Gradle - Ant build is not supported anymore [#65206]
> * XSLFTable::addRow functionality reverted to pre-5.0.0 [github-221]
> * XSSFDrawing - import chart from other drawing [#63901]
> * Support for Excel functions IFS, SWITCH, TEXTJOIN, IFNA, MAXIFS, MINIFS,
> AVERAGEIFS
> * Fix SVG-related image rendering
>
> https://dist.apache.org/repos/dist/dev/poi/5.1.0-RC1/
>
> Things to check:
> According to Stackoverflow there were some problems with JPMS and XmlBeans
> -
> so maybe check for potential problems there.
>
> Please vote to release the artifacts.
> The vote keeps open until 2021-09-10.
> Planned release announcement date is Saturday, 2021-09-11.
>
> Here is my +1
>
> The SVN repo is open again.
>
> Andi
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Next release of POI

[Dominik Stadler]

Similar for me,

a) good time roll the next release

b) whatever is easier right now, we can also use Ant once again if Gradle
needs a bit more work

c) I'd also opt for 5.1.0, it does not feel like big enough changes for a
major release

Dominik.


On Tue, Aug 31, 2021 at 5:08 PM Alain FAGOT BÉAREZ 
wrote:

> Hi,
>
> a) many changes deserve to be released
>
> b) up to you to estimate the benefits or the burden
>
> c) I don't think we introduced API breaking changes, so 5.1.0 would
> encompass the logging changes
>
> Best regards,
> Alain FAGOT BÉAREZ
>
>
> ⁣Obter o BlueMail para Android ​
>
> Em 29 de ago de 2021 21:11, em 21:11, PJ Fanning
>  escreveu:
> >Hi Andi,
> >
> >a) I think we need a new release
> >
> >b) I don't think we need to solve all the build issues before the next
> >release
> >
> >c) I'd prefer to call the next release 6.0.0 or failing that 5.1.0. The
> >log4j change makes calling next release 5.0.1 problematic for me.
> >
> >
> >
> >
> >
> >
> >On Sunday 29 August 2021, 18:57:42 IST, Andreas Beeker
> > wrote:
> >
> >
> >
> >
> >
> >Hi Devs,
> >
> >a) what's your opinion about rolling the next release?
> >
> >From my side, only the distsource build is not implemented in gradle
> >and a few of the release task need to be done manually.
> >
> >b) Now that the gradle dist plugin picks up all the dependencies, how
> >important is the distsource check?
> >
> >c) what's our next release version? 5.0.1,  5.1 or 6.0
> >
> >Andi
> >
> >
> >-
> >To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> >For additional commands, e-mail: dev-h...@poi.apache.org
> >
> >
> >-
> >To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> >For additional commands, e-mail: dev-h...@poi.apache.org
>

Re: [VOTE] Apache XmlBeans 5.0.1 release (RC1)

[Dominik Stadler]

Hi,

Did my usual comparison of the binaries against the previous
release-binaries, everything looks good from that point.

+1

Dominik.


On Fri, Jul 2, 2021 at 11:07 PM Andreas Beeker  wrote:

> Hi *,
>
> I've prepared artifacts for the release of Apache XmlBeans 5.0.1 (RC1).
>
> The most notable changes in this release are:
>
> * Support annotations longer than 64kb
> * Support enumerations with more than 64k entries
> * Enable mapping of schema annotations to javadoc entries in the generated
> classes via schema compiler option
> * Generate TypeSystemHolder as .java (in sources) instead of .class (in
> resources)
>
> https://dist.apache.org/repos/dist/dev/poi/xmlbeans/5.0.1-RC1/
>
> I haven't updated the "provided" dependencies as those have to be
> activated anyway explicitly.
>
> Please vote to release the artifacts.
> The vote keeps open until 2021-07-09 23:00 UTC.
> Planned release announcement date is Saturday, 2021-07-10.
>
> Here is my +1
>
> Andi
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Github Actions TestSignatureInfo failing

[Dominik Stadler]

When reproducing this in a VM locally I get the failure-details below,
maybe the same happens in the Github Action as well.

Seems to be a known regression in latest Java 8 patchlevel 292, see e.g.

* https://github.com/bcgit/bc-java/issues/941
* https://bugs.openjdk.java.net/browse/JDK-8266279
* https://bugs.openjdk.java.net/browse/JDK-8266261

Unfortunately the workarounds discussed in the Github issue did not work
for me locally, so maybe only the next JDK 8 update will fix it again via
https://bugs.openjdk.java.net/browse/JDK-8267258 it is scheduled around
July, 20th, see https://wiki.openjdk.java.net/display/jdk8u/Main

D.

   at
sun.security.pkcs12.PKCS12KeyStore.setKeyEntry(PKCS12KeyStore.java:677)
   at
sun.security.pkcs12.PKCS12KeyStore.engineSetKeyEntry(PKCS12KeyStore.java:577)

   at java.security.KeyStore.setKeyEntry(KeyStore.java:1140)
   at
org.apache.poi.poifs.crypt.dsig.TestSignatureInfo.initKeyPair(TestSignatureInfo.java:1097)

   at
org.apache.poi.poifs.crypt.dsig.TestSignatureInfo.initKeyPair(TestSignatureInfo.java:1060)

   at
org.apache.poi.poifs.crypt.dsig.TestSignatureInfo.bug65214(TestSignatureInfo.java:749)

Caused by: java.security.UnrecoverableKeyException: Encrypt Private Key
failed: unrecognized algorithm name: PBEWithSHA1AndDESede
   at
sun.security.pkcs12.PKCS12KeyStore.encryptPrivateKey(PKCS12KeyStore.java:921)

   at
sun.security.pkcs12.PKCS12KeyStore.setKeyEntry(PKCS12KeyStore.java:614)
   ... 63 more
Caused by: java.security.NoSuchAlgorithmException: unrecognized algorithm
name: PBEWithSHA1AndDESede
   at sun.security.x509.AlgorithmId.get(AlgorithmId.java:448)
   at
sun.security.pkcs12.PKCS12KeyStore.mapPBEAlgorithmToOID(PKCS12KeyStore.java:938)

   at
sun.security.pkcs12.PKCS12KeyStore.encryptPrivateKey(PKCS12KeyStore.java:895)

   ... 64 more

On Sun, Jul 4, 2021 at 5:08 PM fannin...@apache.org 
wrote:

> Hi,
> Does anyone know why TestSignatureInfo fails when run here?
>
> https://github.com/apache/poi/actions
>
> Seems like some crypto algorithms are disabled in the JVM. Could this be
> related to preventing crypto mining?
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Building with Java 11?

[Dominik Stadler]

Hi,

I see similar behaviour also on Monday mornings, so no sign of missing
outdoor-time :)

Seems there is some difference between JDKs or other build-parameters which
cause these difference when building, would be good interesting if anybody
has a clue what the difference in build-setup is when they are created
differently.

Thanks... Dominik.

On Fri, May 7, 2021 at 6:13 PM Tim Allison  wrote:

> Hi All,
>I recently tried to build with Java 11 because of [1], I found that
> the build was modifying module-info.java and module-info.class.  Is
> this expected? Is the combination of the Java issue and this item a
> sign I should put down the keyboard for the weekend a bit early?
>
>  Cheers,
>
>Tim
>
> svn diff
> Index: poi-ooxml-lite/src/main/java9/module-info.class
> ===
> Cannot display: file marked as a binary type.
> svn:mime-type = application/octet-stream
> Index: poi-ooxml-lite/src/main/java9/module-info.java
> ===
> --- poi-ooxml-lite/src/main/java9/module-info.java(revision 1889636)
> +++ poi-ooxml-lite/src/main/java9/module-info.java(working copy)
> @@ -29,7 +29,6 @@
>  exports com.microsoft.schemas.office.excel;
>  exports com.microsoft.schemas.office.office;
>  exports com.microsoft.schemas.office.visio.x2012.main;
> -exports com.microsoft.schemas.office.word;
>  exports com.microsoft.schemas.office.x2006.digsig;
>  exports com.microsoft.schemas.vml;
>  exports org.apache.poi.schemas.ooxml.system.ooxml;
>
> [1] https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8266261
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
> For additional commands, e-mail: dev-h...@poi.apache.org
>
>

Re: Reading conditional formatting not working when format references another sheet

[Dominik Stadler]

Hi,

Thanks for the report, can you open a bug via
https://bz.apache.org/bugzilla/ for this?

Maybe you can first review the existing related issues via
https://bz.apache.org/bugzilla/buglist.cgi?bug_status=UNCONFIRMED_status=NEW_status=ASSIGNED_status=REOPENED_status=NEEDINFO=OP=OP=CP=CP=OR_id=195367=POI_format=advanced_desc=condition_desc_type=allwordssubstr
to see if there is already an issue for this.

Thanks... Dominik.

On Sun, Apr 25, 2021 at 3:12 PM Eduardo Eduardo  wrote:

> sorry for the formatting.
> I hope it is now formatted as text:
>
> import java.io.File;
> import org.apache.poi.ss.usermodel.Sheet;
> import org.apache.poi.ss.usermodel.Workbook;
> import org.apache.poi.ss.usermodel.WorkbookFactory;
> import org.apache.poi.xssf.usermodel.XSSFSheet;
>
> public class ReadPoi {
>public static final String XLSX_FILE_PATH =
> "/Users/eduardo/Desktop/jxls-issue/conditional_formatting_issue_ok.xlsx";
>public static void main(String[] args) throws Exception {
>   Workbook workbook = WorkbookFactory.create(new File(XLSX_FILE_PATH));
>   for (Sheet sheet : workbook) {
>  XSSFSheet xsheet = (XSSFSheet) sheet;
>  System.out.println(sheet.getSheetName() + " has "
>+
> xsheet.getSheetConditionalFormatting().getNumConditionalFormattings() + "
> conditional formattings");
>   }
>}
> }
>
> Am So., 25. Apr. 2021 um 15:08 Uhr schrieb Eduardo Eduardo <
> edu00...@gmail.com>:
>
> > java file seem not to get attached.
> >
> > Here the code of the testcase:
> >
> > *import* java.io.File;
> >
> >
> > *import* org.apache.poi.ss.usermodel.Sheet;
> >
> > *import* org.apache.poi.ss.usermodel.Workbook;
> >
> > *import* org.apache.poi.ss.usermodel.WorkbookFactory;
> >
> > *import* org.apache.poi.xssf.usermodel.XSSFSheet;
> >
> >
> > *public* *class* ReadPoi {
> >
> >
> >*public* *static* *final* String *XLSX_FILE_PATH* =
> > "/Users/eduardo/Desktop/jxls-issue/conditional_formatting_issue_ok.xlsx";
> >
> >
> >*public* *static* *void* main(String[] args) *throws* Exception {
> >
> >   Workbook workbook = WorkbookFactory.*create*(*new* File(
> > *XLSX_FILE_PATH*));
> >
> >
> >   *for* (Sheet sheet : workbook) {
> >
> >  XSSFSheet xsheet = (XSSFSheet) sheet;
> >
> >  System.*out*.println(sheet.getSheetName() + " has "
> >
> >+
> xsheet.getSheetConditionalFormatting().getNumConditionalFormattings()
> > + " conditional formattings");
> >
> >   }
> >
> >}
> >
> > }
> >
> > Am So., 25. Apr. 2021 um 15:01 Uhr schrieb Eduardo Eduardo <
> > edu00...@gmail.com>:
> >
> >> Hi,
> >>
> >> reading the number of conditional formatting via
> getNumConditionalFormattings
> >> is only working if the condition references cells in the same sheet.
> >>
> >> Attached two simple Excel files and a simple testcase:
> >>
> >> If you run it with "conditional_formatting_issue.xlsx", you see this
> >> ouput:
> >>
> >> Tabelle1 has 0 conditional formattings
> >>
> >> MyData has 0 conditional formattings
> >>
> >>
> >> here you see that conditional formattings were not correctly read,
> >> although there is one (referencing another sheet).
> >>
> >>
> >> If the conditional formatting references same sheet (
> >> conditional_formatting_issue_ok.xlsx), I get the output:
> >>
> >> Tabelle1 has 1 conditional formattings
> >>
> >>
> >> which shows that in this case it works.
> >>
> >>
> >> I tested both with POI 4.1.2 and POI 5.0.0
> >>
> >>
> >>
>