Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/218#discussion_r106795847
--- Diff: utility/ExecutionDAGVisualizer.cpp ---
@@ -176,6 +189,18 @@ void ExecutionDAGVisualizer::bindProfilingStats
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/218
LGTM except one minor style issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/224
Fix a bug in PackedPayloadHashTable
This PR fixes a bug in `PackedPayloadHashTable` when `derived_accessor` is
of type `TupleIdSequenceAdapterValueAccessor`.
Thanks Harshad
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/224#discussion_r108504337
--- Diff: storage/PackedPayloadHashTable.cpp ---
@@ -239,26 +239,47 @@ bool
PackedPayloadHashTable::upsertValueAccessorCompositeKey
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/224#discussion_r108504416
--- Diff: storage/PackedPayloadHashTable.cpp ---
@@ -239,26 +239,47 @@ bool
PackedPayloadHashTable::upsertValueAccessorCompositeKey
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/224
Updated to work around the gcc internal error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
/TianrunLi/tcpreader/src
Best,
Jianqiao
2017-03-30 10:10 GMT-05:00 Marc Spehlmann :
> Hi dev,
> I'm looking to make a simple TCP server interface to Quickstep so that we
> can keep the db running while we communicate to it from a python program.
> After investigating, I think the simple
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/226
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/226
Have merged the branch but not reflected in github.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/227
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/229#discussion_r110523124
--- Diff: parser/SqlParser.ypp ---
@@ -676,7 +686,7 @@ sql_statement:
| quit_statement {
$$ = $1
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/229
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/234
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/236
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/237
QUICKSTEP-89 Add support for common subexpression.
This PR adds support for common subexpression elimination in Quickstep. In
summary we apply two kinds of optimizations:
**(1
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/237
Will fix the issues in one PR shortly after.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/239
Add ThreadPrivateCompactKeyHashTable for aggregation.
This PR implements a new specialized aggregation hash table that is
preferable for two-phase (i.e. aggregate locally and then
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/240
Fix the issues with the common subexpression feature
This PR fixes the issues in #237.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/239#discussion_r112991169
--- Diff: storage/ThreadPrivateCompactKeyHashTable.cpp ---
@@ -0,0 +1,422 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/240#discussion_r113066280
--- Diff: query_optimizer/rules/ExtractCommonSubexpression.hpp ---
@@ -111,7 +111,7 @@ class ExtractCommonSubexpression : public
Rule
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r113066931
--- Diff: expressions/scalar/ScalarCaseExpression.cpp ---
@@ -420,15 +429,15 @@ void
ScalarCaseExpression::MultiplexNativeColumnVector
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r113070383
--- Diff: query_optimizer/expressions/CommonSubexpression.hpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r113070668
--- Diff: query_optimizer/expressions/Scalar.hpp ---
@@ -65,10 +67,49 @@ class Scalar : public Expression {
const std::unordered_map
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/237#discussion_r113070938
--- Diff: query_optimizer/expressions/Scalar.hpp ---
@@ -65,10 +67,49 @@ class Scalar : public Expression {
const std::unordered_map
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/243
LGTM. Thanks @zuyu for the fix! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/244
Fix a problem in CopyGroupList + minor style fixes
This PR adjusts the implementation of `CopyGroupList::merge_contiguous()`
to handle some cases correctly.
E.g. let `R`be a
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/244
All updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/246
Improve disjunctive predicate pushdown to optimize more scenarios
This PR improves the `PushDownLowCostDisjunctivePredicate` optimization to
consider more applicable scenarios
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/252
LGTM. Can you rebase the commit w.r.t. the current master HEAD? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/255
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/249
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/257#discussion_r122325834
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -176,6 +177,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/257#discussion_r122326409
--- Diff: query_optimizer/PhysicalGenerator.cpp ---
@@ -176,6 +177,8 @@ P::PhysicalPtr PhysicalGenerator::optimizePlan
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/257
Good refactoring. LGTM! Except one place in `PhysicalGenerator.cpp`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/267
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/268
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/270
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/264
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/265
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/272
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/273
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/274
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/276
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/277
Fix a bug with min/max aggregation.
This PR fixes the bug with min/max aggregation (that produces incorrect
results) when the aggregated column is stored with **leading-zero
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/279
I think the PR looks good and the code structure is convenient for further
adjustment. So merge it now so that @zuyu can continue the work on
partition-aware scheduling.
---
If your
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/280
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/282
LGTM! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/290
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/289
LGTM. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/291
Add "COPY TO" operator for exporting data from Quickstep.
This PR adds support for the "COPY TO" statement for exporting tables from
Quickstep. Two formats
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136178749
--- Diff: parser/ParseStatement.hpp ---
@@ -60,16 +60,16 @@ class ParseStatement : public ParseTreeNode {
* @brief The possible types
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136175863
--- Diff: parser/ParseKeyValue.hpp ---
@@ -37,14 +37,15 @@ namespace quickstep {
*/
class ParseKeyValue : public ParseTreeNode
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198661
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
&parse_q
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136180038
--- Diff: parser/ParseStatement.hpp ---
@@ -898,24 +916,53 @@ class ParseStatementCopyFrom : public ParseStatement {
std::vector
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198676
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
&parse_q
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199560
--- Diff: utility/BulkIOConfiguration.hpp ---
@@ -0,0 +1,198 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199785
--- Diff: utility/BulkIOConfiguration.hpp ---
@@ -0,0 +1,198 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199029
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
&parse_q
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199940
--- Diff: utility/ExecutionDAGVisualizer.cpp ---
@@ -55,12 +55,15 @@ using std::to_string;
namespace quickstep {
DEFINE_bool
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199148
--- Diff: relational_operators/TableExportOperator.hpp ---
@@ -0,0 +1,268 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198306
--- Diff: query_optimizer/physical/PhysicalType.hpp ---
@@ -34,6 +34,7 @@ namespace physical {
enum class PhysicalType {
kAggregate
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198462
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
&parse_q
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198547
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
&parse_q
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199047
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -1595,6 +1742,19 @@ void
Resolver::appendProjectIfNeedPrecomputationAfterAggregation
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198737
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
&parse_q
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198572
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -418,27 +455,157 @@ L::LogicalPtr Resolver::resolve(const ParseStatement
&parse_q
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198255
--- Diff: query_optimizer/physical/CopyTo.hpp ---
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136197848
--- Diff: query_optimizer/logical/CopyTo.hpp ---
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136180815
--- Diff: query_optimizer/logical/CopyFrom.hpp ---
@@ -66,20 +67,14 @@ class CopyFrom : public Logical {
const std::string& file_
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136178849
--- Diff: parser/ParseStatement.hpp ---
@@ -771,122 +776,135 @@ class ParseStatementInsertSelection : public
ParseStatementInsert
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199193
--- Diff: relational_operators/TableExportOperator.hpp ---
@@ -0,0 +1,268 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198182
--- Diff: query_optimizer/physical/CopyFrom.hpp ---
@@ -68,22 +69,14 @@ class CopyFrom : public Physical {
const std::string& file_
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136197963
--- Diff: query_optimizer/logical/LogicalType.hpp ---
@@ -34,6 +34,7 @@ namespace logical {
enum class LogicalType {
kAggregate
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136198329
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -143,6 +145,45 @@ namespace E = ::quickstep::optimizer::expressions;
namespace L
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/291#discussion_r136199350
--- Diff: relational_operators/TextScanOperator.cpp ---
@@ -82,14 +81,19 @@ static bool ValidateTextScanTextSegmentSize(const char
*flagname
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/292
Redirect stdout and stderr in network mode.
This PR redirects `stdout / stderr` to `io_handle->out() /
io_handle->err()` (see
[here](https://github.com/apache/incubator-qui
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/293
LGTM. Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/296
LGTM. Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/271
LGTM. Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/297
LGTM. Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/298
LGTM. Merging.
---
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/299
QUICKSTEP-104 Fix the problem that LineReader cannot recognize a command if
there are whitespaces before it.
This PR fixes a bug that the Quickstep REPL cannot recognize a command
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/299#discussion_r140060711
--- Diff: cli/tests/command_executor/D.test ---
@@ -69,6 +71,7 @@ INSERT INTO foo3 values(5, 1, 1.0, 1.0, 'XYZZ');
col4
Github user jianqiao commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/299#discussion_r140061423
--- Diff: cli/LineReader.cpp ---
@@ -171,7 +173,7 @@ std::string LineReader::getNextCommand() {
case
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/304
LGTM! Merging.
---
GitHub user jianqiao opened a pull request:
https://github.com/apache/incubator-quickstep/pull/315
[DO NOT MERGE] Refactor type system to provide better extensibility of
types and functions
This is a preliminary PR that is not ready to be merged but provides an
overall view of the
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/314
LGTM! Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/316
LGTM! Will merge after travis-ci's tests.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/320
It may just be fine before `ExecutionGenerator`, I think the fix is to
revise `ExecutionGenerator::convertInsertTuple()` and do some modifications
inside `InsertOperator`.
---
Hi Om,
It seems that your "cmake" output is okay. Can you also provide the "make"
error message?
Best,
Jianqiao
2017-11-06 11:34 GMT-06:00 Harshad Deshmukh :
> Hi Om,
>
> What's your build setup? Did you download the prerequisites and
> initialized th
It seems to be a problem related to C++ compiler version. Can you check its
version by using command:
gcc -v
The fix should be a few lines of changes in root directory's/glog's
CMakeLists.txt.
Best,
Jianqiao
2017-11-08 15:30 GMT-06:00 Om Jadhav :
> Hi Jianqiao,
>
> Please
KE_CXX_FLAGS} -Werror")
Line 588
<https://github.com/apache/incubator-quickstep/blob/master/CMakeLists.txt#L588>
: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-return-type-c-linkage")
This should fix the problem for gcc-6.3.. we may add systematic fixes for
different compiler v
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/323
LGTM! Can you squash the two commits into one and then I can merge this PR.
(To squash the two commits, go to the repo, `git rebase -i HEAD~2`, change
the second `pick` to
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/323
Merged
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/321
LGTM! Merging.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
@dylanpbacon Hi Dylan, I updated the LIP related stuff and put it in this
[branch](https://github.com/apache/incubator-quickstep/tree/Hash-Join-Fuse),
you may just fetch the changes to
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/325
The design looks good to me! It would be better to fast forward to
subsequent PRs to see the actual usage.
---
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
@zuyu Currently `HashJoinOperator` performance is sensitive to the _number
of build blocks per probe block_ due to the concurrency bottleneck within LRU
policy enforcer
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/300
Merging.
---
Hi Song,
It seems to be problem with higher versions of gcc/clang.
As a temporary fix please comment out (or remove) the following two lines
in incubator/CMakeLists.txt and see if it works:
https://github.com/apache/incubator-quickstep/compare/disable-flags
Best,
Jianqiao
2017-11-28 18:57 GMT
101 - 200 of 307 matches
Mail list logo
