ld be better to seek a generic solution.
Ok. Very nice advice, I had fixed it. Thanks a lots.
- pengjianhua
---
This is an automatically generated e-mail. To reply, visit:
https://r
/main/webapp/scripts/views/policies/PermissionList.js
bb649840
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js
9a8d82db
Diff: https://reviews.apache.org/r/62325/diff/3/
Changes: https://reviews.apache.org/r/62325/diff/2-3/
Testing
---
Thanks,
pengjianhua
/src/main/webapp/scripts/views/policies/RangerPolicyForm.js
9a8d82db
Diff: https://reviews.apache.org/r/62325/diff/2/
Changes: https://reviews.apache.org/r/62325/diff/1-2/
Testing
---
Thanks,
pengjianhua
ot; and
"url".
Please refer to
https://community.hortonworks.com/questions/135781/ranger-hive-read-and-write-permissions.html
Diffs
-
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js
bb649840
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js
9a8d82db
Diff: https://reviews.apache.org/r/62325/diff/1/
Testing
---
Thanks,
pengjianhua
171e9
Diff: https://reviews.apache.org/r/62264/diff/1/
Testing
---
Thanks,
pengjianhua
d modify the control logic of Ranger menu to keep consistent with
https://issues.apache.org/jira/projects/RANGER.
Diffs
-
security-admin/src/main/webapp/scripts/views/common/TopNav.js bc5d17c4
Diff: https://reviews.apache.org/r/62269/diff/1/
Testing
---
Thanks,
pengjianhua
/scripts/views/common/TopNav.js bc5d17c4
Diff: https://reviews.apache.org/r/62269/diff/1/
Testing
---
Thanks,
pengjianhua
return false;
}
Here should return ret .
Diffs
-
agents-audit/src/main/java/org/apache/ranger/audit/provider/BufferedAuditProvider.java
31b171e9
Diff: https://reviews.apache.org/r/62264/diff/1/
Testing
---
Thanks,
pengjianhua
e/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
9990dd4c
Diff: https://reviews.apache.org/r/62233/diff/1/
Testing
---
Thanks,
pengjianhua
andler.java
9990dd4c
Diff: https://reviews.apache.org/r/62233/diff/1/
Testing
---
Thanks,
pengjianhua
hould exit the loop to improve execution efficiency once the
attribute value is set.
Diffs
-
security-admin/scripts/update_property.py 80ccdb8f
Diff: https://reviews.apache.org/r/62156/diff/1/
Testing
---
Thanks,
pengjianhua
(hiveObj.getType() == null){
> > if(databaseorUrl == null){
Ok. I had fixed it. Thanks.
- pengjianhua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62076/#review184697
Testing
---
Thanks,
pengjianhua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61909/#review184763
---
Ship it!
Ship It!
- pengjianhua
On 八月 25, 2017, 3:09 a.m
urity-admin/src/main/webapp/scripts/views/service/ServiceForm.js 079ce00a
Diff: https://reviews.apache.org/r/62111/diff/1/
Testing
---
Thanks,
pengjianhua
tps://reviews.apache.org/r/62111/diff/1/
Testing
---
Thanks,
pengjianhua
/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
1c7a9d08
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveResource.java
d04d3bfa
Diff: https://reviews.apache.org/r/62076/diff/1/
Testing
---
Thanks,
pengjianhua
gent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveResource.java
d04d3bfa
Diff: https://reviews.apache.org/r/62076/diff/1/
Testing
---
Thanks,
pengjianhua
js
6f27d5db
Diff: https://reviews.apache.org/r/62062/diff/2/
Testing
---
Thanks,
pengjianhua
as expanded.
Diffs
-
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js
6f27d5db
Diff: https://reviews.apache.org/r/62062/diff/2/
Testing
---
Thanks,
pengjianhua
t/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveResource.java
d04d3bfa
Diff: https://reviews.apache.org/r/62076/diff/1/
Testing
---
Thanks,
pengjianhua
g/r/62076/diff/1/
Testing
---
Thanks,
pengjianhua
62/diff/1/
Testing
---
Thanks,
pengjianhua
pache.org/r/62010/diff/2/
Changes: https://reviews.apache.org/r/62010/diff/1-2/
Testing
---
Thanks,
pengjianhua
}
}
return false;
}
Activity
Diffs
-
hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
da73c677
Diff: https://reviews.apache.org/r/62010/diff/1/
Testing
---
Thanks,
pengjianhua
>
> > Can you explain why this patch is required? In case of HA enabled
> > namenode, linking both core-site.xml and hdfs-site.xml under
> > /etc/ranger/admin/conf should get test connection feature working fine.
>
> pengjianhua wrote:
> 1.It will prompt &
not a valid
configuration item.
2.We need to configure multiple hdfs services when ranger manages multiple
clusters of hdfs. How to distinguish hdfs clusters , if I link both
core-site.xml and hdfs-site.xml under /etc/ranger/admin/conf. Whether we can
only configure on the page
- pengjianhua
HdfsClient.java
cab1b52e
Diff: https://reviews.apache.org/r/61909/diff/1/
Testing
---
Thanks,
pengjianhua
/
Testing
---
Thanks,
pengjianhua
nodes.[nameservice ID] not
specified".
Diffs
-
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java
cab1b52e
Diff: https://reviews.apache.org/r/61836/diff/1/
Testing
---
Thanks,
pengjianhua
iews.apache.org/r/61771/diff/1/
Testing
---
Thanks,
pengjianhua
attribute values in globalDict variable.
2. Invalid parsing will degrade the performance of program.
Diffs
-
security-admin/scripts/restrict_permissions.py a4998be
Diff: https://reviews.apache.org/r/61771/diff/1/
Testing
---
Thanks,
pengjianhua
group exists
before created user group in security admin.
Diffs
-
security-admin/scripts/set_globals.sh 5e985e2
Diff: https://reviews.apache.org/r/61770/diff/1/
Testing
---
Thanks,
pengjianhua
with the logic
of pidf is not the same. The result is that the initd will run repeatedly when
ranger-usersync-services.sh was running.
Diffs
-
unixauthservice/scripts/initd a1062af
Diff: https://reviews.apache.org/r/61769/diff/1/
Testing
---
Thanks,
pengjianhua
.
Diffs
-
security-admin/scripts/ranger_credential_helper.py 940dbf1
Diff: https://reviews.apache.org/r/61768/diff/1/
Testing
---
Thanks,
pengjianhua
://reviews.apache.org/r/61202/diff/7-8/
Testing
---
tested it
Thanks,
pengjianhua
> On 八月 10, 2017, 10:48 a.m., Colm O hEigeartaigh wrote:
> > There's a whitespace error at the end of the test.
Fixed it ,and update the patch ,it's my failure ,thanks again.
- pengjianhua
---
This is an automatical
://reviews.apache.org/r/61202/diff/6-7/
Testing
---
tested it
Thanks,
pengjianhua
gt; [INFO]
Hi .The test case includes two sub-test cases, The second sub-test case is to
test that the user does not exist. you are right, it may May mislead you I
removed second sub-test case. thanks.
- pengjianhua
---
This is an a
://reviews.apache.org/r/61202/diff/5-6/
Testing
---
tested it
Thanks,
pengjianhua
c09f6
Diff: https://reviews.apache.org/r/61452/diff/2/
Changes: https://reviews.apache.org/r/61452/diff/1-2/
Testing
---
Thanks,
pengjianhua
or loop to
> > avoid creating unnecessary objects.
> > 2) Also in the if statement it references "msObjRef.getObjectType()",
> > whereas just above we have the definition of "objectType" that could be
> > used instead.
Yes, you a
uot;);
Diffs (updated)
-
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
6872e50
Diff: https://reviews.apache.org/r/61202/diff/5/
Changes: https://reviews.apache.org/r/61202/diff/4-5/
Testing
---
tested it
Thanks,
pengjianhua
/EmbeddedServiceDefsUtil.java
0bc09f6
Diff: https://reviews.apache.org/r/61452/diff/1/
Testing
---
Thanks,
pengjianhua
specified service will be created, but I think this judge is incorrect.
Diffs
-
agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java
0bc09f6
Diff: https://reviews.apache.org/r/61452/diff/1/
Testing
---
Thanks,
pengjianhua
> On 八月 4, 2017, 10:15 a.m., Colm O hEigeartaigh wrote:
> > The indentation is still incorrect in RangerHiveAuthorizer starting line
> > 1473...
Hi?May be my code templates and your advantages of different, I changed another
code template? I modify the patch ?Thanks.
://reviews.apache.org/r/61202/diff/3-4/
Testing
---
tested it
Thanks,
pengjianhua
atch again? Please review again.
- pengjianhua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61202/#review182122
---
On 八月 4, 201
che.org/r/61202/diff/3/
Changes: https://reviews.apache.org/r/61202/diff/2-3/
Testing
---
tested it
Thanks,
pengjianhua
/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java
89d5f4d
security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java b1f0be4
Diff: https://reviews.apache.org/r/61395/diff/1/
Testing
---
Thanks,
pengjianhua
is is not the case. If the output is
> > nothing to do with Ranger policies, then I'm wondering what the use-case is
> > here for supporting this functionality with the Ranger authorizer?
>
> pengjianhua wrote:
> The hive plugin effected the hive function after used t
is is not the case. If the output is
> > nothing to do with Ranger policies, then I'm wondering what the use-case is
> > here for supporting this functionality with the Ranger authorizer?
>
> pengjianhua wrote:
> The hive plugin effected the hive function after used t
thorizerTest.java
011d2c3
Diff: https://reviews.apache.org/r/61202/diff/2/
Testing
---
tested it
Thanks,
pengjianhua
ger. This issue affected the hive's functions which
are ok if user doesn't use our hive plugin.
- pengjianhua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61202/#review181803
----
> On 七月 28, 2017, 4:03 p.m., Colm O hEigeartaigh wrote:
> > The "else" after the initial "if (principal == null) {" is not necessary.
Thanks for you advise ,I had modify the code and add test for this feature
,Please
uthorization/hive/authorizer/RangerHiveAuthorizer.java
6872e50
hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java
011d2c3
Diff: https://reviews.apache.org/r/61202/diff/2/
Changes: https://reviews.apache.org/r/61202/diff/1-2/
Testing
---
tested it
Thanks,
pengjianhua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61202/#review181650
---
Ship it!
Ship It!
- pengjianhua
On 七月 28, 2017, 3:32 a.m
rg/r/61202/diff/1/
Testing
---
tested it
Thanks,
pengjianhua
> On 七月 25, 2017, 2:13 p.m., Colm O hEigeartaigh wrote:
> > The log output ends up in src/test/resources for me - instead it should be
> > somewhere in the target directory:
> >
> > src/test/resources/kms/kms-audit-localhost-autotest.log
Ok
://reviews.apache.org/r/61106/diff/2/
Changes: https://reviews.apache.org/r/61106/diff/1-2/
Testing
---
Thanks,
pengjianhua
---
Thanks,
pengjianhua
That includes the noggit jar in the plugins without having to add a
> dependency in the poms. We should also do the same for:
>
> 'com.google.protobuf:protobuf-java:jar:${protobuf-java.version}
Ok. I rebuilt the patch after carefully checked and verified it. Thanks.
-
://reviews.apache.org/r/60997/diff/2-3/
Testing
---
Thanks,
pengjianhua
/2/
Changes: https://reviews.apache.org/r/60997/diff/1-2/
Testing
---
Thanks,
pengjianhua
---
Thanks,
pengjianhua
s: https://reviews.apache.org/r/60454/diff/2-3/
Testing
---
tested it
Thanks,
pengjianhua
s: https://reviews.apache.org/r/60454/diff/1-2/
Testing
---
tested it
Thanks,
pengjianhua
t;
> > Falling back to Native SQLStdHiveAccessControler is not a ideal way to
> > resolve this. HiveAuthorizer should provide the necessary implementation
> > for showPrivileges(). This has to be discussed with Hive comitter also.
>
> pengjianhua wrote:
> Ok. I
https://reviews.apache.org/r/60837/diff/1/
Testing
---
Thanks,
pengjianhua
-
kms/config/kms-webapp/kms-log4j.properties 479b5b4
kms/scripts/ranger-kms e902509
Diff: https://reviews.apache.org/r/60801/diff/1/
Testing
---
Thanks,
pengjianhua
479b5b4
kms/scripts/ranger-kms e902509
Diff: https://reviews.apache.org/r/60801/diff/1/
Testing
---
Thanks,
pengjianhua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60789/#review180288
---
Ship it!
Ship It!
- pengjianhua
On 七月 12, 2017, 2:42 a.m
ing
---
Thanks,
pengjianhua
tps://reviews.apache.org/r/60789/diff/1/
Testing
---
Thanks,
pengjianhua
pts/install.properties 13ae1e5
unixauthservice/scripts/templates/installprop2xml.properties 1a9bf36
unixauthservice/scripts/templates/ranger-ugsync-template.xml 0025dc8
Diff: https://reviews.apache.org/r/60789/diff/1/
Testing
---
Thanks,
pengjianhua
-kms.tar.gz. The result
was that the VERSION variable can only get a fixed 0.5.0 value when installed
ranger kms.
Diffs
-
src/main/assembly/kms.xml e26dd33
Diff: https://reviews.apache.org/r/60772/diff/1/
Testing
---
Thanks,
pengjianhua
}-${user}.log
Diffs
-
unixauthservice/src/main/resources/log4j.properties dbad541
Diff: https://reviews.apache.org/r/60759/diff/1/
Testing
---
Thanks,
pengjianhua
g folder.
> >
> > My suggestion is to not include this patch.
Ok. I will close the issue. Thanks.
- pengjianhua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60733/#revie
t;
> > Falling back to Native SQLStdHiveAccessControler is not a ideal way to
> > resolve this. HiveAuthorizer should provide the necessary implementation
> > for showPrivileges(). This has to be discussed with Hive comitter also.
Ok. I will rebuild the pat
agents-audit/src/main/java/org/apache/ranger/audit/utils/SolrAppUtil.java
PRE-CREATION
Diff: https://reviews.apache.org/r/60696/diff/3/
Changes: https://reviews.apache.org/r/60696/diff/2-3/
Testing
---
Thanks,
pengjianhua
-
Thanks,
pengjianhua
ecurity-admin/src/main/resources/conf.dist/core-site.xml PRE-CREATION
Diff: https://reviews.apache.org/r/60733/diff/1/
Testing
---
Thanks,
pengjianhua
y-admin/scripts/setup.sh 1630684
security-admin/src/main/resources/conf.dist/core-site.xml PRE-CREATION
Diff: https://reviews.apache.org/r/60733/diff/1/
Testing (updated)
---
test it!
Thanks,
pengjianhua
n/java/org/apache/ranger/audit/utils/SolrAppUtil.java
PRE-CREATION
Diff: https://reviews.apache.org/r/60696/diff/1/
Testing
---
Thanks,
pengjianhua
igHolder.java
fd925aa
Diff: https://reviews.apache.org/r/60680/diff/1/
Testing
---
Thanks,
pengjianhua
://reviews.apache.org/r/60260/diff/1-2/
Testing
---
Thanks,
pengjianhua
> On 六月 21, 2017, 9:38 a.m., Colm O hEigeartaigh wrote:
> > With the patch, the $LOGFILES property is not actually used at all. Do we
> > know what $LOGFILES is meant to do, and why we have both $LOGFILE and
> > $LOGFILES?
>
> pengjianhua wrote:
> I also no
Testing
---
tested it
Thanks,
pengjianhua
Testing
---
tested it
Thanks,
pengjianhua
e/ranger/authorization/hive/authorizer/RangerHiveAuthorizerBase.java
c313870
Diff: https://reviews.apache.org/r/60454/diff/1/
Testing
---
tested it
Thanks,
pengjianhua
uot;" >
${WEBAPP_ROOT}/WEB-INF/classes/conf/core-site.xml
fi
fi
fi
Diffs
-
security-admin/scripts/setup.sh f49bb13
Diff: https://reviews.apache.org/r/60452/diff/1/
Testing
---
Thanks,
pengjianhua
echo "" >
${WEBAPP_ROOT}/WEB-INF/classes/conf/core-site.xml
fi
fi
fi
Diffs
-
security-admin/scripts/setup.sh f49bb13
Diff: https://reviews.apache.org/r/60452/diff/1/
Testing
---
Thanks,
pengjianhua
> On 六月 21, 2017, 9:38 a.m., Colm O hEigeartaigh wrote:
> > With the patch, the $LOGFILES property is not actually used at all. Do we
> > know what $LOGFILES is meant to do, and why we have both $LOGFILE and
> > $LOGFILES?
>
> pengjianhua wrote:
> I also no
> On 六月 22, 2017, 9:04 a.m., Colm O hEigeartaigh wrote:
> > Looks fine, but change it to "For multiple urls"
Thanks,
I have changed and updated the patch.
- pengjianhua
---
This is an automatically generated e-ma
Diff: https://reviews.apache.org/r/60359/diff/2/
Changes: https://reviews.apache.org/r/60359/diff/1-2/
Testing
---
test?
Thanks,
pengjianhua
iff/1/
Testing
---
test?
Thanks,
pengjianhua
ould not be needed in current
context. I have been thinking, why the orignal developer added it? Do I think
we should remove it, your opinion?
- pengjianhua
---
This is an automatically generated e-mail. To reply, visit:
https://revie
case of compatibility with existing logic.
When running ranger, users can set the pid file to meet their own needs.
Diffs
-
kms/scripts/ranger-kms 11dc4ff
Diff: https://reviews.apache.org/r/60262/diff/1/
Testing
---
Thanks,
pengjianhua
/ranger-kms 11dc4ff
Diff: https://reviews.apache.org/r/60262/diff/1/
Testing
---
Thanks,
pengjianhua
installation
script. Its processing logic is chaotic. We should optimize this logic.
Diffs
-
kms/scripts/setup.sh 77d8e80
Diff: https://reviews.apache.org/r/60260/diff/1/
Testing
---
Thanks,
pengjianhua
201 - 300 of 362 matches
Mail list logo
