---
Tested:
1. policy-cache is correctly updated.
2. Policy evaluation when tag policies are updated.
3. Policy evaluation when tags are updated.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71583/#review218120
---
Ship it!
Ship It!
- Abhay Kulkarni
On Oct. 7, 2019, 6:05
/plugin/util/PolicyRefresher.java
d4d790274
Diff: https://reviews.apache.org/r/71593/diff/1/
Testing
---
Ran all unit tests.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71583/#review218144
---
Ship it!
Ship It!
- Abhay Kulkarni
On Oct. 9, 2019, 1:01
enhanced, internal Java object more suitable for GUI
consumption).
Diffs
-
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java
f329d1775
Diff: https://reviews.apache.org/r/71603/diff/1/
Testing
---
Ran all unit tests successfully
Thanks,
Abhay Kulkarni
/2/
Changes: https://reviews.apache.org/r/71603/diff/1-2/
Testing
---
Ran all unit tests successfully
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71583/#review218167
---
Ship it!
Ship It!
- Abhay Kulkarni
On Oct. 10, 2019
+1
Thanks, Selva!
On Tue, Oct 8, 2019 at 9:38 AM Selvamohan Neethiraj
wrote:
> Apache Ranger PMC:
>
> Could you please review draft board report below and provide your feedback.
>
>
> Thanks,
> Selva-
>
>
> ## Description:
> - Apache Ranger is a framework to enable, monitor an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71609/#review218207
---
Ship it!
Ship It!
- Abhay Kulkarni
On Oct. 11, 2019, 5:28
/71626/diff/1/
Testing
---
Tested with a cluster to ensure that tags are propagated correctly to
descendant entities.
Thanks,
Abhay Kulkarni
----
On Oct. 16, 2019, 7:20 p.m., Abhay Kulkarni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71626/
> ---
/apache/ranger/plugin/util/ServiceDefUtil.java
f383241f1
Diff: https://reviews.apache.org/r/71626/diff/2/
Changes: https://reviews.apache.org/r/71626/diff/1-2/
Testing
---
Tested with a cluster to ensure that tags are propagated correctly to
descendant entities.
Thanks,
Abhay Kulkarni
and groups and roles"
security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java
Lines 319 (patched)
<https://reviews.apache.org/r/71621/#comment305880>
Why is detach() necessary ? here and in line 326.
- Abh
/org/apache/ranger/plugin/util/ServiceDefUtil.java
f383241f1
Diff: https://reviews.apache.org/r/71626/diff/3/
Changes: https://reviews.apache.org/r/71626/diff/2-3/
Testing
---
Tested with a cluster to ensure that tags are propagated correctly to
descendant entities.
Thanks,
Abhay
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71621/#review218249
---
Ship it!
Ship It!
- Abhay Kulkarni
On Oct. 16, 2019, 10:55
/TestTagREST.java
402f1ce2c
Diff: https://reviews.apache.org/r/71635/diff/1/
Testing
---
Developed unit tests and ran them successfully.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71627/#review218272
---
Ship it!
Ship It!
- Abhay Kulkarni
On Oct. 17, 2019, 7:50
/TestServiceREST.java
a7e19bf03
security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java
402f1ce2c
Diff: https://reviews.apache.org/r/71635/diff/2/
Changes: https://reviews.apache.org/r/71635/diff/1-2/
Testing
---
Developed unit tests and ran them successfully.
Thanks,
Abhay
that policy download failed.
Thanks,
Abhay Kulkarni
script to invoke policy download
without acquiring kerberos identity. Ensured that policy download failed.
Thanks,
Abhay Kulkarni
rg/r/71651/diff/4/
Changes: https://reviews.apache.org/r/71651/diff/3-4/
Testing (updated)
---
Passes all unit tests
Thanks,
Abhay Kulkarni
org/r/71651/diff/4-5/
Testing
---
Passes all unit tests
Thanks,
Abhay Kulkarni
tests
Thanks,
Abhay Kulkarni
ews.apache.org/r/71668/#comment306219>
Please consider making displayName field searchable/sortable here and in
RangerServiceDef.
- Abhay Kulkarni
On Oct. 30, 2019, 5:54 a.m., Kishor Gollapalliwar wrote:
>
> ---
> This is a
service is invalid.
- Abhay Kulkarni
On Oct. 23, 2019, 9:08 a.m., Xing Peng wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71723/#review218516
---
Ship it!
Ship It!
- Abhay Kulkarni
On Nov. 5, 2019, 10:09
(updated)
---
Passed all unit tests
Thanks,
Abhay Kulkarni
/71724/diff/4/
Changes: https://reviews.apache.org/r/71724/diff/3-4/
Testing
---
Passed all unit tests
Thanks,
Abhay Kulkarni
/ServiceREST.java
3d8a32977
Diff: https://reviews.apache.org/r/71724/diff/5/
Changes: https://reviews.apache.org/r/71724/diff/4-5/
Testing
---
Passed all unit tests
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71759/#review218619
---
Ship it!
Ship It!
- Abhay Kulkarni
On Nov. 13, 2019, 2:59
/XXGlobalStateDao.java
Lines 100 (patched)
<https://reviews.apache.org/r/71758/#comment306414>
Please consider printing the exception here.
- Abhay Kulkarni
On Nov. 12, 2019, 9:53 p.m., Sailaja Polavarapu wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71765/#review218628
---
Ship it!
Ship It!
- Abhay Kulkarni
On Nov. 14, 2019, 12:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71758/#review218639
---
Ship it!
Ship It!
- Abhay Kulkarni
On Nov. 14, 2019, 10:49
/71724/diff/6-7/
Testing
---
Passed all unit tests
Thanks,
Abhay Kulkarni
://reviews.apache.org/r/71724/diff/7-8/
Testing
---
Passed all unit tests
Thanks,
Abhay Kulkarni
-admin/src/test/resources/admin/service-defs/test-hive-servicedef.json
PRE-CREATION
security-admin/src/test/resources/admin/service-defs/test-tag-servicedef.json
PRE-CREATION
Diff: https://reviews.apache.org/r/71802/diff/1/
Testing
---
Passes all unit tests
Thanks,
Abhay Kulkarni
,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71808/#review218774
---
Ship it!
Ship It!
- Abhay Kulkarni
On Nov. 22, 2019, 5:43
/
Testing
---
Passes all unit tests
Thanks,
Abhay Kulkarni
/plugin/policyengine/TestPolicyEngine.java
b4c3060ef
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngineComparison.java
94ba8b90a
Diff: https://reviews.apache.org/r/71828/diff/1/
Testing
---
Passed all unit tests
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71830/#review218814
---
Ship it!
Ship It!
- Abhay Kulkarni
On Nov. 26, 2019, 11:44
/apache/ranger/plugin/policyengine/TestPolicyEngineComparison.java
94ba8b90a
Diff: https://reviews.apache.org/r/71828/diff/2/
Changes: https://reviews.apache.org/r/71828/diff/1-2/
Testing
---
Passed all unit tests
Thanks,
Abhay Kulkarni
/ranger/plugin/policyengine/TestPolicyEngineComparison.java
94ba8b90a
Diff: https://reviews.apache.org/r/71828/diff/3/
Changes: https://reviews.apache.org/r/71828/diff/2-3/
Testing
---
Passed all unit tests
Thanks,
Abhay Kulkarni
/authorizer/RangerHiveAuthorizer.java
Line 1158 (original), 1161 (patched)
<https://reviews.apache.org/r/71839/#comment306711>
When objectType is DATABASE, isn't objectName the same as dbName?
- Abhay Kulkarni
On Nov. 27, 2019, 5:53 p.m., Ramesh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71839/#review218833
---
Ship it!
Ship It!
- Abhay Kulkarni
On Nov. 27, 2019, 5:53
/org/apache/ranger/authorization/hive/authorizer/RangerHiveResourceACLs.java
PRE-CREATION
pom.xml bce4f20d0
Diff: https://reviews.apache.org/r/71829/diff/3/
Testing
---
Passes all unit tests
Thanks,
Abhay Kulkarni
Diff: https://reviews.apache.org/r/71869/diff/1/
Testing
---
Passes all unit tests
Thanks,
Abhay Kulkarni
/authorizer/RangerHiveResourceACLs.java
PRE-CREATION
pom.xml bce4f20d0
Diff: https://reviews.apache.org/r/71829/diff/4/
Changes: https://reviews.apache.org/r/71829/diff/3-4/
Testing
---
Passes all unit tests
Thanks,
Abhay Kulkarni
://reviews.apache.org/r/71829/diff/5/
Changes: https://reviews.apache.org/r/71829/diff/4-5/
Testing
---
Passes all unit tests
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71874/#review218926
---
Ship it!
Ship It!
- Abhay Kulkarni
On Dec. 4, 2019, 10:53
/biz/RangerPolicyAdminCache.java
76dabb4a0
Diff: https://reviews.apache.org/r/71890/diff/1/
Testing
---
Passes all unit tests. Tested with cluster configured with ranger-admin enabled
for using policy-deltas.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71891/#review218971
---
Ship it!
Ship It!
- Abhay Kulkarni
On Dec. 7, 2019, 1:55
dmin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
Lines 1658 (patched)
<https://reviews.apache.org/r/71894/#comment306991>
Please consider having a space surrounding operator.
- Abhay Kulkarni
On Dec. 9, 2019, 10:33 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71893/#review218989
---
Ship it!
Ship It!
- Abhay Kulkarni
On Dec. 10, 2019, 1:18
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71693/#review218991
---
Ship it!
Ship It!
- Abhay Kulkarni
On Nov. 7, 2019, 6:45
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71938/#review219197
---
Ship it!
Ship It!
- Abhay Kulkarni
On Jan. 9, 2020, 3 p.m
-and-applicable.json
b0b0f8d07
Diff: https://reviews.apache.org/r/71989/diff/1/
Testing
---
Ran build with command
mvn clean compile test package verify
Build succeeded without errors.
Thanks,
Abhay Kulkarni
getDisplayName())) {
ret.setDisplayName(ret.getName());
}
- Abhay Kulkarni
On Jan. 14, 2020, 10:38 a.m., Kishor Gollapalliwar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
-kudu.json
Lines 100 (patched)
<https://reviews.apache.org/r/71954/#comment307417>
"label": "DELETE",
- Abhay Kulkarni
On Jan. 6, 2020, 10:43 p.m., Hao Hao wrote:
>
> ---
> This is an automaticall
---
Tested in a kerberized cluster with Grant/Revoke commands.
Thanks,
Abhay Kulkarni
-kafka.json
Line 79 (original), 95 (patched)
<https://reviews.apache.org/r/72020/#comment307464>
Please consider ordering accessTypes by the itemIds?
- Abhay Kulkarni
On Jan. 16, 2020, 10:46 p.m., Ramesh Mani wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72020/#review219314
---
Ship it!
Ship It!
- Abhay Kulkarni
On Jan. 16, 2020, 11:42
g/r/72000/#comment307467>
Please consider logging the exception with LOG.error()
- Abhay Kulkarni
On Jan. 15, 2020, 6:09 a.m., Ramesh Mani wrote:
>
> ---
> This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72010/#review219346
---
Ship it!
Ship It!
- Abhay Kulkarni
On Jan. 18, 2020, 6:08
ws.apache.org/r/71993/#comment307489>
Please ensure that the thread is a damon thread. Please see
TagAdminRESTSink.start() for reference.
- Abhay Kulkarni
On Jan. 21, 2020, 7:14 a.m., Dineshkumar Yadav wrote:
>
> ---
> This is an a
tched)
<https://reviews.apache.org/r/71999/#comment307505>
Please review to see if we need to create a new Gson object in this
function. It will be good if that can be avoided.
- Abhay Kulkarni
On Jan. 22, 2020, 7:02 a.m., Sailaja Polavarapu wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71993/#review219363
---
Ship it!
Ship It!
- Abhay Kulkarni
On Jan. 22, 2020, 8:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71954/#review219508
---
Ship it!
Ship It!
- Abhay Kulkarni
On Jan. 31, 2020, 9:23
fbb23
Diff: https://reviews.apache.org/r/72086/diff/1/
Testing
---
Tested with cluster by deleting policies from a hive service. Ensured that when
the last policy is deleted, 'for-resource' API call returns zero policies.
Thanks,
Abhay Kulkarni
with this policy engine.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71999/#review219564
---
Ship it!
Ship It!
- Abhay Kulkarni
On Feb. 5, 2020, 11:17
h
attrEnabled is set to true? If so, please check for null to avoid potential NPE.
- Abhay Kulkarni
On Feb. 15, 2020, 2:03 a.m., Sailaja Polavarapu wrote:
>
> ---
> This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72152/#review219614
---
Ship it!
Ship It!
- Abhay Kulkarni
On Feb. 19, 2020, 8:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72195/#review219779
---
Ship it!
Ship It!
- Abhay Kulkarni
On March 4, 2020, 6:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72136/#review219853
---
Ship it!
Ship It!
- Abhay Kulkarni
On March 3, 2020, 9:06
Lines 29 (patched)
<https://reviews.apache.org/r/72219/#comment308220>
Please expand out the imports.
- Abhay Kulkarni
On March 11, 2020, 6:52 p.m., Sailaja Polavarapu wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72219/#review219989
---
Ship it!
Ship It!
- Abhay Kulkarni
On March 18, 2020, 11:54
/SessionMgr.java
Lines 184 (patched)
<https://reviews.apache.org/r/72251/#comment308274>
Please consider doing this check before line 182. If the check fails, then
the rest of the condition(s) may be checked.
- Abhay Kulkarni
On March 19, 2020, 2:25 p.m., Sailaja Polavarapu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72251/#review220049
---
Ship it!
Ship It!
- Abhay Kulkarni
On March 20, 2020, 7:15
bug the issue. Include
"continuing" to the log message.
- Abhay Kulkarni
On March 30, 2020, 3:49 p.m., Mahesh Bandal wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72252/#review220150
---
Ship it!
Ship It!
- Abhay Kulkarni
On March 31, 2020, 7:25
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72298/#review220174
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 1, 2020, 7:43
---
Tested in a live cluster.
Thanks,
Abhay Kulkarni
/RangerScriptConditionEvaluator.java
5b6653901
Diff: https://reviews.apache.org/r/72302/diff/2/
Changes: https://reviews.apache.org/r/72302/diff/1-2/
Testing
---
Tested in a live cluster.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72299/#review220218
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 3, 2020, 6:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72320/#review220229
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 6, 2020, 6:53
/tagsync/source/atlas/AtlasAdlsResourceMapper.java
Lines 112 (patched)
<https://reviews.apache.org/r/72319/#comment308549>
Will this condition be ever satisfied? Please review.
- Abhay Kulkarni
On April 5, 2020, 12:51 a.m., Madhan Neethiraj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72329/#review220235
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 7, 2020, 1:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72307/#review220244
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 7, 2020, 2:09
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72341/#review220273
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 9, 2020, 4:47
Diff: https://reviews.apache.org/r/72342/diff/1/
Testing
---
Ensured that Ranger-admin is correctly initialized on startup and configured
service-definitions are created in the database.
Thanks,
Abhay Kulkarni
---
Ensured that Ranger-admin is correctly initialized on startup and configured
service-definitions are created in the database.
Thanks,
Abhay Kulkarni
6bd2d9766
Diff: https://reviews.apache.org/r/72350/diff/1/
Testing
---
Compiled clean with verify option successfully
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72381/#review220350
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 17, 2020, 4:40
e evaluated the policy condition correctly.
Thanks,
Abhay Kulkarni
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72416/#review220433
---
Ship it!
Ship It!
- Abhay Kulkarni
On April 22, 2020, 3:51
/ServiceREST.java
82e67e654
security-admin/src/main/java/org/apache/ranger/rest/ServiceRESTUtil.java
640d3c349
Diff: https://reviews.apache.org/r/72425/diff/4/
Testing
---
Tested with merging an existing policy with different policy-items
Thanks,
Abhay Kulkarni
--
On April 30, 2020, 9:29 p.m., Abhay Kulkarni wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72455/
>
service resources. Took about 3 minutes.
Thanks,
Abhay Kulkarni
/HDFSAuditDestination.java
Line 180 (original), 182 (patched)
<https://reviews.apache.org/r/72457/#comment309061>
Should this code be executed only if out != null (as was done before this
change)?
- Abhay Kulkarni
On May 1, 2020, 2:36 a.m., Ramesh Mani
501 - 600 of 1706 matches
Mail list logo
