Re: Review Request 61692: RANGER-1705 : Good coding practice in Ranger recommended by static code analysis *

than users are synchronised form there they got same role which is specified in usersync-side. 2.Verified unix authentication and usersync. 3.Junit test was successful Thanks, Fatima Khan

Review Request 61691: RANGER-1705 : Good coding practice in Ranger recommended by static code analysis

there they got same role which is specified in usersync-side. 2.Verified unix authentication and usersync. 3.Junit test was successful Thanks, Fatima Khan

Review Request 61692: RANGER-1705 : Good coding practice in Ranger recommended by static code analysis *

there they got same role which is specified in usersync-side. 2.Verified unix authentication and usersync. 3.Junit test was successful Thanks, Fatima Khan

Re: Review Request 61691: RANGER-1736 : Good coding practice in Ranger recommended by static code analysis

, Fatima Khan

Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

, Fatima Khan

Re: Request to make me contributor in Apache Ranger

Thanks a lot, Madhan. On 26-Jun-2017 1:13 pm, "Madhan Neethiraj" <mad...@apache.org> wrote: > Fatima, > > Done. Welcome to Apache Ranger community! > > Thanks, > Madhan > > > > > On 6/23/17, 6:11 AM, "Fatima Khan" <fatimakhan4...@gmai

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

--- Tested on Simple against all roles Tested on Secure against all roles Thanks, Fatima Khan

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

t: https://reviews.apache.org/r/61553/#review185372 ------- On Sept. 14, 2017, 4:33 a.m., Fatima Khan wrote: > > --- > This is an automatically generated e

Re: FW: New Defects reported by Coverity Scan for Apache Ranger

Hi Abhay, I will take care of all issues related to RoleBasedUserSearchUtil.java and TestRoleBasedUserSearchUtil.java. *Thanks & Regards ,* *Fatima Khan* On Thu, Sep 21, 2017 at 9:19 PM, Abhay Kulkarni <akulka...@hortonworks.com> wrote: > Contributors/Committers, > > Pl

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

--- Tested on Simple against all roles Tested on Secure against all roles Thanks, Fatima Khan

Re: Review Request 62709: RANGER-1817 : Audit to Solr fails to log when the number of columns are in large number

y properties in Ranger. This will be a new feature. - Fatima --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62709/#review186786 ------

Re: Review Request 62713: RANGER 1818: Good coding practice in Ranger recommended by static code analysis

https://reviews.apache.org/r/62713/#review186857 --- On Sept. 30, 2017, 10:17 a.m., Fatima Khan wrote: > > --- > This is an automatically generated e-m

Review Request 62538: Good coding practice in Ranger recommended by static code analysis

: https://reviews.apache.org/r/62538/diff/1/ Testing --- 1.Tested SSO Authentication 2.Junit test was successful Thanks, Fatima Khan

Re: FW: New Defects reported by Coverity Scan for Apache Ranger

Hi Abhay, I will look into it. On 28-Sep-2017 8:48 pm, "Abhay Kulkarni" wrote: Contributors/Committers, Please review and fix as appropriate. Thanks! -Abhay On 9/28/17, 12:43 AM, "scan-ad...@coverity.com" wrote: > >Hi, > >Please

Re: Review Request 62538: Good coding practice in Ranger recommended by static code analysis

> On Sept. 25, 2017, 2:08 p.m., Colm O hEigeartaigh wrote: > > Why not just change the existing for loops to use > > "roleSysAdminMap.entrySet()" instead of adding an Iterator? > > Fatima Khan wrote: > In coverity scan, we had got FB.WMI_WRONG_MAP_ITERA

Re: Review Request 62538: Good coding practice in Ranger recommended by static code analysis

security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBasedUserSearchUtil.java 83eab7a Diff: https://reviews.apache.org/r/62538/diff/2/ Changes: https://reviews.apache.org/r/62538/diff/1-2/ Testing --- 1.Tested SSO Authentication 2.Junit test was successful Thanks, Fatima

Review Request 62713: RANGER 1818: Good coding practice in Ranger recommended by static code analysis

/org/apache/ranger/authentication/PasswordValidator.java 20ced89 Diff: https://reviews.apache.org/r/62713/diff/1/ Testing --- 1.Tested SSO Authentication 2.Junit test was successful Thanks, Fatima Khan

Review Request 61728: RANGER-1727 : Restrict password change request of external users

/UserMgr.java c1145e7 Diff: https://reviews.apache.org/r/61728/diff/1/ Testing --- 1.Verified that external users are not allowed to change their password with ranger api Thanks, Fatima Khan

Review Request 62709: RANGER-1817 : Audit to Solr fails to log when the number of columns are in large number

: https://reviews.apache.org/r/62709/diff/1/ Testing --- 1.Tested Ranger installation 2.Junit test was successful Thanks, Fatima Khan

Review Request 62567: RANGER-1727 : Ranger allows user to change an external user's password with 'null' old password

/62567/diff/1/ Testing --- 1.External user is not able to change the password using ranger Api's (same as ui). 2.Verified all the existing unit tests are passing. 3.Verified password change feature for internal users. Thanks, Fatima Khan

Re: Review Request 62538: Good coding practice in Ranger recommended by static code analysis

org/r/62538/#review186118 --- On Sept. 25, 2017, 10:44 a.m., Fatima Khan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62538/ > --

Re: Review Request 61553: RANGER-1730 : Utility script that will list the users with a given role

/ranger/patch/cliutil/TestRoleBaseUserSearchUtil.java PRE-CREATION Diff: https://reviews.apache.org/r/61553/diff/2/ Changes: https://reviews.apache.org/r/61553/diff/1-2/ Testing --- Tested on Simple against all roles Tested on Secure against all roles Thanks, Fatima Khan

Re: Review Request 66867: RANGER-2083 : Restrict KMS audit events to KMS related users only

--- Testing done by checking that only Keyadmin and KMS Auditor role users are be able to see KMS related audit logs. Thanks, Fatima Khan

Re: Review Request 66867: RANGER-2083 : Restrict KMS audit events to KMS related users only

related audit logs. Thanks, Fatima Khan

Review Request 66796: RANGER-2041 : Handle validations for passwords of admin accounts during ranger install

- security-admin/scripts/db_setup.py 2cbe665 security-admin/scripts/dba_script.py 4a57bba security-admin/scripts/setup.sh 45bc918 Diff: https://reviews.apache.org/r/66796/diff/1/ Testing --- Tested the validation for all password combinations in manual install. Thanks, Fatima Khan

Review Request 67181: RANGER-2106 : Keyadmin is not able to see 'Audit tab' and 'User tab' by default.

28c89dc Diff: https://reviews.apache.org/r/67181/diff/1/ Testing --- Tested that Keyadmin gets by default access to users/groups tab and Audit tab Thanks, Fatima Khan

Review Request 67056: RANGER-2100 : REST API to get count of total services, policies, users, groups and various mapping.

the combination of curl commands possible for analytics. Thanks, Fatima Khan

Review Request 67319: RANGER-2113 : Improve error handling when of change password process gets killed.

verified : Successfull installation of Ranger if patch values are cleared in x_db_version_h table. Thanks, Fatima Khan

Review Request 66867: RANGER-2083 : Resctict KMS audit events to KMS related users only

-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 7dcb074 Diff: https://reviews.apache.org/r/66867/diff/1/ Testing --- Testing done by checking that only Keyadmin and KMS Auditor role users are be able to see KMS related audit logs. Thanks, Fatima Khan

Review Request 65729: RANGER-1982 : Improve Error handling in analytical metrics of ranger admin and ranger kms

- embeddedwebserver/scripts/ranger-admin-services.sh e902f73 kms/scripts/ranger-kms c279bc1 Diff: https://reviews.apache.org/r/65729/diff/1/ Testing --- Tested with all the combination of commands possible for analytics metric. Thanks, Fatima Khan

Review Request 67687: RANGER-2138 : Add unit tests for org.apache.ranger.service package

n test Thanks, Fatima Khan

Re: Review Request 68293: RANGER-2114 : Internal Exception: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'content' at row 1

data_hist table. - Fatima --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68293/#review207108 --- On Aug. 10, 2018, 1:22 p.m., Fatima K

Review Request 68293: RANGER-2114 : Internal Exception: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'content' at row 1

--- Tested the following 1.In fresh install and upgrade scenario. 2.Checked the data type of x_data_hist is changed from text to mediumtext. Thanks, Fatima Khan

Review Request 68031: RANGER-2138 : Add unit tests for org.apache.ranger.service package

-CREATION security-admin/src/test/java/org/apache/ranger/service/TestXPermMapService.java PRE-CREATION Diff: https://reviews.apache.org/r/68031/diff/1/ Testing --- Tested with below two type 1.eclipse->Run as->Junit Test 2.mvn test Thanks, Fatima Khan

Re: Review Request 65978: RANGER-2013 : Restrict updation of user source

. Thanks, Fatima Khan

Review Request 65978: RANGER-2013 : Restrict updation of user source

- security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 487fefa Diff: https://reviews.apache.org/r/65978/diff/1/ Testing --- Tested and validated the update user Api. Thanks, Fatima Khan

Re: Review Request 65978: RANGER-2013 : Restrict updation of user source

. Thanks, Fatima Khan

Re: Review Request 65914: Ranger 1948 : Support for Read-only Ranger Admin users

during initial start of usersync.Property value in install.properties will be GROUP_BASED_ROLE_ASSIGNMENT_RULES= _ADMIN_AUDITOR:u:userName_KEY_ADMIN_AUDITOR:u:userName_KEY_ADMIN_AUDITOR:g:groupName_ADMIN_AUDITOR:g:groupName Thanks, Fatima Khan

Re: Review Request 66036: RANGER-1496 : Excel/csv exported file should have complete details of the policy

. Tested and validated the exported CSV. Thanks, Fatima Khan

Review Request 66036: RANGER-1496 : Excel/csv exported file should have complete details of the policy

. Thanks, Fatima Khan

Re: Review Request 65914: RANGER 1948 : Support for Read-only Ranger Admin users

= _ADMIN_AUDITOR:u:userName_KEY_ADMIN_AUDITOR:u:userName_KEY_ADMIN_AUDITOR:g:groupName_ADMIN_AUDITOR:g:groupName Thanks, Fatima Khan

Re: Review Request 65978: RANGER-2013 : Restrict updation of user source

end to update sync source or not. - Fatima --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65978/#review198874 ------- O

Review Request 66304: RANGER-2041 : Handle validations for passwords of admin accounts during ranger install.

security-admin/src/main/java/org/apache/ranger/patch/cliutil/ChangePasswordUtil.java e7a4035 Diff: https://reviews.apache.org/r/66304/diff/1/ Testing --- Tested the validation for all password combinations. Thanks, Fatima Khan

Re: Review Request 66304: RANGER-2041 : Handle validations for passwords of admin accounts during ranger install.

sword combinations. Thanks, Fatima Khan

Review Request 66684: RANGER-2070 : Ranger Storm service creation fails

is getting created 2.Auditor and KMS Auditor Role user are blocked from the respective Api's Thanks, Fatima Khan

Re: Review Request 66684: RANGER-2070 : Ranger Storm service creation fails

/apache/ranger/biz/TestUserMgr.java 307f435 Diff: https://reviews.apache.org/r/66684/diff/2/ Changes: https://reviews.apache.org/r/66684/diff/1-2/ Testing --- 1.Storm Service is getting created 2.Auditor and KMS Auditor Role user are blocked from the respective Api's Thanks, Fatima Khan

Review Request 66301: RANGER-2040 : Improvement in Analytics Metric of Ranger Admin and Ranger Kms for Users/groups metric collection for Auditor Role.

-admin/src/main/java/org/apache/ranger/view/VXMetricUserGroupCount.java 345465d Diff: https://reviews.apache.org/r/66301/diff/1/ Testing --- Tested that in user/groups metric collection we are getting Auditor role users. Thanks, Fatima Khan

Review Request 66279: RANGER-2039 : Allow access to Audit tab for all users of role Keyadmin and KMS Auditor

, Fatima Khan

Review Request 66280: RANGER-2038 : Handle validations for Auditor role users for Grant/revoke actions as well

- security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 1bff815 Diff: https://reviews.apache.org/r/66280/diff/1/ Testing --- Verified that user having Auditor role is not able to create or update policy Thanks, Fatima Khan

Review Request 66281: RANGER-2036 : Allow Auditor and KMS Auditor role user to Export of Excel and CSV

bd098d Diff: https://reviews.apache.org/r/66281/diff/1/ Testing --- Tested that Auditor and KMS Auditor role users are able to download Excel and CSV only from report page Thanks, Fatima Khan

Re: Review Request 66279: RANGER-2039 : Allow access to Audit tab for all users of role Keyadmin and KMS Auditor

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66279/#review200275 --- On April 2, 2018, 7:39 a.m., Fatima Khan wrote: > > --

Re: Review Request 66279: RANGER-2039 : Allow access to Audit tab for all users of role Keyadmin and KMS Auditor

://reviews.apache.org/r/66279/diff/2/ Changes: https://reviews.apache.org/r/66279/diff/1-2/ Testing --- Tested the by creating Auditor and KMS Auditor role user's get default access to users/groups tab and Audit tab Thanks, Fatima Khan

Re: Review Request 66279: RANGER-2039 : Allow access to Audit tab for all users of role Keyadmin and KMS Auditor

/66279/diff/2/ Testing --- Tested the by creating Auditor and KMS Auditor role user's get default access to users/groups tab and Audit tab Thanks, Fatima Khan

Re: Review Request 66301: RANGER-2040 : Improvement in Analytics Metric of Ranger Admin and Ranger Kms for Users/groups metric collection for Auditor Role.

/66301/diff/1/ Testing --- Tested that in user/groups metric collection we are getting Auditor role users. Thanks, Fatima Khan

Re: Review Request 66281: RANGER-2036 : Allow Auditor and KMS Auditor role user to Export of Excel and CSV

eports/UserAccessLayout_tmpl.html 3bd098d Diff: https://reviews.apache.org/r/66281/diff/1/ Testing --- Tested that Auditor and KMS Auditor role users are able to download Excel and CSV only from report page Thanks, Fatima Khan

Re: Review Request 66304: RANGER-2041 : Handle validations for passwords of admin accounts during ranger install.

https://reviews.apache.org/r/66304/diff/1/ Testing --- Tested the validation for all password combinations. Thanks, Fatima Khan

Re: Review Request 66304: RANGER-2041 : Handle validations for passwords of admin accounts during ranger install.

ly, visit: https://reviews.apache.org/r/66304/#review200422 --- On April 4, 2018, 6:43 a.m., Fatima Khan wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 65829: Improvement on permission module for listing modules

applying filters for user's name and group name . Thanks, Fatima Khan

Review Request 65831: RANGER-1998 : Add ability to specify passwords for admin accounts during ranger install only.

passwords during ranger install. Logged in to ranger using those passwords and verified all functionality provided for those users. Thanks, Fatima Khan

Review Request 65914: Ranger 1948 : Support for Read-only Ranger Admin users

will be GROUP_BASED_ROLE_ASSIGNMENT_RULES= _ADMIN_AUDITOR:u:userName_KEY_ADMIN_AUDITOR:u:userName_KEY_ADMIN_AUDITOR:g:groupName_ADMIN_AUDITOR:g:groupName Thanks, Fatima Khan

Re: Review Request 70932: Ranger: use Solr API to upload config set (during bootstrapping)

.Solr collections were created successfully Thanks, Fatima Khan

Review Request 70932: Ranger: use Solr API to upload config set (during bootstrapping)

collections were created successfully Thanks, Fatima Khan

Review Request 71015: RANGER-2490:Add https support while using Solr API to upload config set

/SolrCollectionBootstrapper.java 02a3f6c Diff: https://reviews.apache.org/r/71015/diff/1/ Testing --- Tested Below Scenario in Ranger with https support 1.Solr configuration were uploaded successfully 2.Solr collections were created successfully Thanks, Fatima Khan

Re: Review Request 70932: Ranger-2482: use Solr API to upload config set (during bootstrapping)

-3/ Testing --- Tested Below Scenario in ranger 1.Solr configuration were uploaded successfully 2.Solr collections were created successfully Thanks, Fatima Khan

Re: Review Request 70932: Ranger-2482: use Solr API to upload config set (during bootstrapping)

collections were created successfully Thanks, Fatima Khan

Re: Review Request 70932: Ranger-2482: use Solr API to upload config set (during bootstrapping)

y, visit: https://reviews.apache.org/r/70932/#review216158 ------- On June 27, 2019, 5:11 a.m., Fatima Khan wrote: > > --- > This is an automatically gene

Re: Review Request 71015: RANGER-2490:Add https support while using Solr API to upload config set

successfully 2.Solr collections were created successfully Thanks, Fatima Khan

Review Request 71495: RANGER-2570 : Handling the pop up of policy details on Ranger Access audit log row

- security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java ced9ea8 security-admin/src/main/webapp/scripts/models/RangerPolicy.js cd873b3 Diff: https://reviews.apache.org/r/71495/diff/1/ Testing --- The policy details get popped up. Thanks, Fatima Khan

Re: Review Request 71495: RANGER-2570 : Handling the pop up of policy details on Ranger Access audit log row

--- The policy details get popped up. Thanks, Fatima Khan

Re: Review Request 71563: RANGER-2597 :Allow auditor role user to get details of services and policies from public API

and forbidden from creating, updating and deleting the policies. Thanks, Fatima Khan

Re: Review Request 71015: RANGER-2490:Add https support while using Solr API to upload config set

t;http"; String uploadConfigsUrl = String.format("%s://%s/admin/configs?action=UPLOAD=", protocol, baseUrl.toString()); - Fatima --- This is an automatically generated e-mail. To reply, visit: https://r

Re: Review Request 71015: RANGER-2490:Add https support while using Solr API to upload config set

uploadConfigsUrl = > > String.format("%s://%s//admin/configs?action=UPLOAD=%s", protocol, > > baseUrl.toString(), solr_config_name) > > ``` > > Fatima Khan wrote: > Did u mean this > String protocol = isSSLEnabled ? "https": "http"; >

Re: Review Request 71015: RANGER-2490:Add https support while using Solr API to upload config set

successfully 2.Solr collections were created successfully Thanks, Fatima Khan

Re: Review Request 71713: RANGER-2616: Add reencryptEncryptedKey, batch reencryption interface to KMS and improve logs

/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAudit.java 04daeee Diff: https://reviews.apache.org/r/71713/diff/1/ Testing --- Tested the CRUD operations related to keys and re-encrypt EDEKs after the EZ key rotation works fine. Thanks, Fatima Khan

Re: Review Request 71713: RANGER-2616: Add reencryptEncryptedKey, batch reencryption interface to KMS and improve logs

rotation works fine. Thanks, Fatima Khan

Re: Review Request 71718: RANGER-2635 : Backport hadoop-kms changes in ranger-kms

--- Tested all the operations related to ranger-kms Thanks, Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

the desired json Thanks, Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

the desired json Thanks, Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

pace": { "init": 44564480, "used": 30075104, "committed": 48758784, "max": 48758784 }, "PS Old Gen": { "init": 716177408, "used": 7971432, "committed": 716177408, "max": 716177408 } } } }, "vm": { "JVM Machine Actual Name": "OpenJDK 64-Bit Server VM", "version": "25.222-b10", "JVM Machine Representation Name": "15526@fipl5", "Up time of JVM": 10414, "JVM Vendor Name": "Private Build" } } } Thanks, Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

792, "committed":260046848, "max":261619712 }, "PS Survivor Space":{ "init":44564480, "used":30648600, "committed":48758784, "max":48758784 }, "PS Old Gen":{ "init":716177408, "used":7870896, "committed":716177408, "max":716177408 } } } } } } Thanks, Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

/src/main/java/org/apache/ranger/util/RangerJVMMetricUtil.java PRE-CREATION security-admin/src/main/resources/conf.dist/security-applicationContext.xml 672d4a6 Diff: https://reviews.apache.org/r/71565/diff/3/ Testing --- Getting the desired json Thanks, Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

/src/main/java/org/apache/ranger/util/RangerJVMMetricUtil.java PRE-CREATION security-admin/src/main/resources/conf.dist/security-applicationContext.xml 672d4a6 Diff: https://reviews.apache.org/r/71565/diff/3/ Testing --- Getting the desired json Thanks, Fatima Khan

Re: Review Request 71565: RANGER-2589 : Introduce Ranger API to return Ranger's JVM resource status metric

: https://reviews.apache.org/r/71565/diff/3-4/ Testing --- Getting the desired json Thanks, Fatima Khan