Review Request 55920: RANGER-1330 : When report exported in CSV format we get one random data in ID field

2017-01-25 Thread Mehul Parikh
--- Verified : 1. exported EXCEL,CSV and JSON file with non-us characters, data are written as expected. 2. Imported those json files which had users with non-US characters in username and checked policy format. Thanks, Mehul Parikh

Re: Review Request 56694: RANGER-1380 : not able to delete group that is having special character from ranger admin

2017-02-17 Thread Mehul Parikh
port of a group with special character in groupname from LDAP / AD. 3) Delete of a user / group having & in username / groupname. 4) Listing and search of such users in Policy listing and edit policy page. Thanks, Mehul Parikh

Review Request 57086: RANGER-1405 : groups are not shown if exact user name is passed in search filter

2017-02-28 Thread Mehul Parikh
search by multiple criterias on User Listing page. 3) Verified same search criterias by REST APIs as well. Thanks, Mehul Parikh

Re: Review Request 57905: RANGER-1474 : On SP12, hive policy page opens up with UDF as default under resources, rather than table.

2017-03-29 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57905/#review170364 --- Ship it! Ship It! - Mehul Parikh On March 24, 2017, 5:52

Re: Review Request 58104: RangerUI: Escape of policy condition text entered in the policy form.

2017-04-03 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58104/#review170846 --- Ship it! Ship It! - Mehul Parikh On March 31, 2017, 11:15

Re: Review Request 61078: RANGER-1708: Remove tag services from service type and service name filters under Access Audit.

2017-08-02 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61078/#review182074 --- Ship it! Ship It! - Mehul Parikh On Aug. 1, 2017, 6:42 a.m

Re: Review Request 60732: RANGER-1491 : Automatically map group of external users to Administrator Role

2017-08-10 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60732/#review182660 --- Ship it! Ship It! - Mehul Parikh On Aug. 8, 2017, 8:31 a.m

Re: Review Request 60385: Ranger KMS should validate key name before importing into DB

2017-07-10 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60385/#review180019 --- Ship it! Ship It! - Mehul Parikh On June 23, 2017, 6:19 a.m

Re: Review Request 61421: RANGER-1724: On Report listing page for masking/row filter policies show only mask/row filter conditions.

2017-08-06 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61421/#review182263 --- Ship it! Ship It! - Mehul Parikh On Aug. 4, 2017, 4:01 a.m

Re: Review Request 61025: Good coding practice in Ranger recommended by static code analysis

2017-08-22 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61025/#review183569 --- Ship it! Ship It! - Mehul Parikh On July 21, 2017, 12:33

Review Request 60238: RANGER-1651 : Improve Ranger and Ranger KMS REST Api documentation

2017-06-20 Thread Mehul Parikh
://reviews.apache.org/r/60238/diff/1/ Testing --- Verified : Verified all the APIs of Ranger admin and Ranger KMS being added to the document. Thanks, Mehul Parikh

Re: UI regression for Knox?

2017-06-22 Thread Mehul Parikh
them in this way. > > Colm. > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com > -- Thanks and regards, Mehul Parikh M: +91 98191 54446 E: xsme...@gmail.com

Re: Review Request 60195: Proxying Ranger UI does not work with Ranger-KnoxSSO

2017-06-25 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60195/#review178860 --- Ship it! Ship It! - Mehul Parikh On June 19, 2017, 11:48

Re: Review Request 62328: RANGER-1682: Clicking on export service after session timeout gets stuck indefinitely.

2017-09-18 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62328/#review185544 --- Ship it! Ship It! - Mehul Parikh On Sept. 14, 2017, 12:33

Re: Review Request 62374: RANGER-1786: Need warning on external user role change.

2017-09-19 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62374/#review185675 --- Ship it! Ship It! - Mehul Parikh On Sept. 18, 2017, 5:41

Re: Review Request 62375: RANGER-1787: User has to fill up all the allow and deny conditions items to create a knox policy.

2017-09-19 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62375/#review185676 --- Ship it! Ship It! - Mehul Parikh On Sept. 18, 2017, 6 a.m

Re: Review Request 62709: RANGER-1817 : Audit to Solr fails to log when the number of columns are in large number

2017-10-04 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62709/#review187053 --- Ship it! Ship It! - Mehul Parikh On Sept. 30, 2017, 6:26

Re: Review Request 62841: RANGER-1826: Import of bulk policies is causing OutOfMemoryError and Apparent Deadlock

2017-10-10 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62841/#review187508 --- Ship it! Ship It! - Mehul Parikh On Oct. 10, 2017, 3:47 a.m

Re: Review Request 62881: RANGER-1176: Ranger admin does not allow to create / update a policy with only delegate admin permission.

2017-10-11 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62881/#review187648 --- Ship it! Ship It! - Mehul Parikh On Oct. 11, 2017, 8:17 a.m

Re: Website/RANGER-1651

2017-09-08 Thread Mehul Parikh
KMS? On Sat, Sep 2, 2017 at 12:55 PM, Mehul Parikh <xsme...@gmail.com> wrote: > Hi Colm, > > I will check for the same and provide a updated patch if needed. > > On Sep 1, 2017 4:15 PM, "Colm O hEigeartaigh" <cohei...@apache.org> wrote: > >> Hi

Re: Website/RANGER-1651

2017-09-11 Thread Mehul Parikh
RA to fix the KMS REST API. > > Colm. > > On Sat, Sep 9, 2017 at 4:37 AM, Mehul Parikh <xsme...@gmail.com> wrote: > > > Hi Colm, > > > > Please run : "mvn enunciate:docs" and then from docs directory run: "mvn > > site". > &

Re: Website/RANGER-1651

2017-09-08 Thread Mehul Parikh
tall > -DskipTests" on the root dir, and "mvn site" in docs, but I still don't see > a link being generated for the KMS api-docs? > > Colm. > > On Fri, Sep 8, 2017 at 10:30 AM, Mehul Parikh <xsme...@gmail.com> wrote: > >> Hi Colm, >> >> I have

Re: Review Request 62714: RANGER-1819: Not able to delete group that is having special character(ampersand) from ranger admin.

2017-09-30 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62714/#review186782 --- Ship it! Ship It! - Mehul Parikh On Sept. 30, 2017, 11:26

Re: Review Request 62538: Good coding practice in Ranger recommended by static code analysis

2017-09-27 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62538/#review186396 --- Ship it! Ship It! - Mehul Parikh On Sept. 26, 2017, 1:39

Re: Review Request 61779: RANGER-1676: Policy Details popup from Access audit page not displaying details of masking policy.

2017-08-21 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61779/#review183447 --- Ship it! Ship It! - Mehul Parikh On Aug. 21, 2017, 10 a.m

Re: Review Request 61776: RANGER-1724: On Report listing page for masking/row filter policies show only mask/row filter conditions.

2017-08-21 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61776/#review183444 --- Ship it! Ship It! - Mehul Parikh On Aug. 21, 2017, 8:53 a.m

Re: Review Request 61421: RANGER-1724: On Report listing page for masking/row filter policies show only mask/row filter conditions.

2017-08-21 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61421/#review183443 --- Ship it! Ship It! - Mehul Parikh On Aug. 21, 2017, 8:50 a.m

Re: Review Request 61845: RANGER-1748 : User is unable to update existing policy while importing policy from file

2017-08-23 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61845/#review183703 --- Ship it! Ship It! - Mehul Parikh On Aug. 23, 2017, 11:59

Re: Review Request 61848: RANGER-1748 : User is unable to update existing policy while importing policy from file

2017-08-23 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61848/#review183704 --- Ship it! Ship It! - Mehul Parikh On Aug. 23, 2017, 12:25

Re: Review Request 61555: RANGER-1726 : Users are not getting deleted when Knox proxy is Enabled.

2017-08-24 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61555/#review183717 --- Ship it! Ship It! - Mehul Parikh On Aug. 22, 2017, 6:55 a.m

Re: Website/RANGER-1651

2017-09-02 Thread Mehul Parikh
Hi Colm, I will check for the same and provide a updated patch if needed. On Sep 1, 2017 4:15 PM, "Colm O hEigeartaigh" wrote: > Hi Mehul, > > I've recently updated the website and I've noticed a few issues relating > to the patch you did for RANGER-1651. > > The "apidocs"

Re: Review Request 64051: RANGER-1906 - Simplify Atlas plugin dependency management

2017-11-29 Thread Mehul Parikh
are working after removal of these dependencies? - Mehul Parikh On Nov. 28, 2017, 11:44 a.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63575: RANGER-1873: Fix property handling in RangerKMSDB

2017-11-07 Thread Mehul Parikh
Line 198 (original), 185 (patched) <https://reviews.apache.org/r/63575/#comment267571> @Zsombor : Can you please confirm if you have verified Ranger KMS sanity testing on SSL enabled MySQL DB ? - Mehul Parikh On Nov. 6, 2017, 10:22 a.m., Zsombor Gegesy

Review Request 67111: RANGER-2101 : Testcases Improvement to follow best practices

2018-05-14 Thread Mehul Parikh
- security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java 81bc548 security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java ce6971d Diff: https://reviews.apache.org/r/67111/diff/1/ Testing --- Verified successful build for Ranger. Thanks, Mehul

Re: Review Request 66985: improvement in ranger policy timezones and keeping validation at both ranger server and UI end consistent.

2018-05-09 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66985/#review202743 --- Ship it! Ship It! - Mehul Parikh On May 7, 2018, 1:59 p.m

Re: Review Request 66867: RANGER-2083 : Restrict KMS audit events to KMS related users only

2018-05-09 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66867/#review202744 --- Ship it! Ship It! - Mehul Parikh On May 9, 2018, 7:09 a.m

Re: Review Request 66951: RANGER-2095 : Add unit tests for new read only admin-auditor/kms-auditor roles functionality

2018-05-09 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66951/#review202745 --- Ship it! Ship It! - Mehul Parikh On May 4, 2018, 12:27 p.m

Re: Review Request 67052: RANGER Admin UI login through knox proxy fails with 404

2018-05-10 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67052/#review202896 --- Ship it! Ship It! - Mehul Parikh On May 10, 2018, 7:04 a.m

Re: Review Request 67056: RANGER-2100 : REST API to get count of total services, policies, users, groups and various mapping.

2018-05-15 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67056/#review203129 --- Ship it! Ship It! - Mehul Parikh On May 15, 2018, 10:25 a.m

Re: Review Request 67181: RANGER-2106 : Keyadmin is not able to see 'Audit tab' and 'User tab' by default.

2018-05-21 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67181/#review203493 --- Ship it! Ship It! - Mehul Parikh On May 17, 2018, 1:33 p.m

Re: Review Request 67230: RANGER-2110: 'copy hive query to clipboard' button in audits tab is not working

2018-05-20 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67230/#review203480 --- Ship it! Ship It! - Mehul Parikh On May 19, 2018, 8:36 a.m

Re: Review Request 67471: Improvement in ranger yarn and hdfs plugin for additional default policy creation feature during service creation

2018-06-06 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67471/#review204390 --- Ship it! Ship It! - Mehul Parikh On June 6, 2018, 7:17 a.m

Re: Review Request 67507: Improve ranger coverage of unit tests for REST layer.

2018-06-11 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67507/#review204584 --- Ship it! Ship It! - Mehul Parikh On June 11, 2018, 9:19 a.m

Re: Review Request 67475: Different error msg on backend/frontend login validation

2018-06-11 Thread Mehul Parikh
file, if you can just make a patch file and attach it on review board. it will be helpful : As mentioned in Wiki page : https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244 $ git add $ git commit -m "RANGER-: " $ git format-patch -n HEAD~ - Mehul Parikh On June

Re: Review Request 67475: Different error msg on backend/frontend login validation

2018-06-12 Thread Mehul Parikh
> On June 12, 2018, 4:19 a.m., Mehul Parikh wrote: > > @david : Your patch is still not getting applied, it is a diff file, if you > > can just make a patch file and attach it on review board. it will be > > helpful : > > > > As mentioned in Wiki pag

Re: Review Request 67599: Ranger UserSync port (ie 5151) supports TLSv1.0

2018-06-16 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67599/#review204894 --- Ship it! Ship It! - Mehul Parikh On June 15, 2018, 12:37

Re: Review Request 67545: Good coding practices for REST classes and unit tests

2018-06-14 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67545/#review204778 --- Ship it! Ship It! - Mehul Parikh On June 12, 2018, 2:04 p.m

Re: Review Request 67382: RANGER-2116: Ranger UI: Fix policy condition field usability issue when multi-line attribute is set to true in policy screen

2018-05-30 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67382/#review204101 --- Ship it! Ship It! - Mehul Parikh On May 30, 2018, 1:54 p.m

Re: Ranger 1.1 release

2018-06-26 Thread Mehul Parikh
added ( > > > > > https://issues.apache.org/jira/browse/RANGER-2136 < > > > > > https://issues.apache.org/jira/browse/RANGER-2136>), I propose > > to > > > > release > > > > > Ranger 1.1 (tentative first week of July). > > > > > > > > > > > > I request the community to resolve open JIRA’s marked for 1.1 > > in > > > > the > > > > > next couple of weeks or move them to next release. My proposal > is > > > to > > > > call > > > > > next release 2.0 and update master to 2.0.0-SNAPSHOT. > > > > > > > > > > > > Thank you, > > > > > > Vel > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > Colm O hEigeartaigh > > > > Talend Community Coder > > http://coders.talend.com > > > -- Thanks and regards, Mehul Parikh M: +91 98191 54446 E: xsme...@gmail.com

Re: Review Request 66818: RANGER-1889: Improvements to list Users belonging to Group in Group tab.

2018-04-29 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66818/#review202112 --- Ship it! Ship It! - Mehul Parikh On April 26, 2018, 6:08

Re: Review Request 66796: RANGER-2041 : Handle validations for passwords of admin accounts during ranger install

2018-04-30 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66796/#review202121 --- Ship it! Ship It! - Mehul Parikh On April 27, 2018, 11:15

Review Request 66945: RANGER-2094 : Handle Export Policy feature for different browsers

2018-05-04 Thread Mehul Parikh
ome and IE 11. Thanks, Mehul Parikh

Re: Review Request 62882: Good coding practice-add additional headers in ranger

2017-10-23 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62882/#review188924 --- Ship it! Ship It! - Mehul Parikh On Oct. 17, 2017, 10:54

Re: Review Request 65188: RANGER-1956: Update CredentialBuilder module

2018-01-21 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65188/#review195881 --- Ship it! Ship It! - Mehul Parikh On Jan. 17, 2018, 10:41

Re: Review Request 62533: RANGER-1805: Code improvement to follow best practices in js

2018-01-30 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62533/#review196554 --- Ship it! Ship It! - Mehul Parikh On Jan. 25, 2018, 6:17 a.m

Re: Review Request 65747: RANGER-1981: Error in constructing base path for UI API when accessing Atlas via knox proxy without "/" at the end

2018-02-22 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65747/#review198102 --- Ship it! Ship It! - Mehul Parikh On Feb. 22, 2018, 5:44 a.m

Re: Review Request 65729: RANGER-1982 : Improve Error handling in analytical metrics of ranger admin and ranger kms

2018-02-22 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65729/#review198101 --- Ship it! Ship It! - Mehul Parikh On Feb. 21, 2018, 12:04

Re: Prep for ranger-1.0.0 release

2018-02-22 Thread Mehul Parikh
e with Hadoop 2.7.x (not Hadoop 3) and Atlas 0.8.2 as > >dependencies. > >> > >> Please let me know if any of you have any concerns and/or > >suggestions on the release process. > >> > >> Thanks, > >> Sailaja. > > > > > > > > > > -- Thanks and regards, Mehul Parikh M: +91 98191 54446 E: xsme...@gmail.com

Re: Review Request 65752: RANGER-1990: Add One-way SSL MySQL support in Ranger Admin

2018-02-25 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65752/#review198275 --- Ship it! Ship It! - Mehul Parikh On Feb. 22, 2018, 10:31

Re: Review Request 64862: RANGER-1944: Action filter for Admin Audit is not working

2017-12-28 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64862/#review194576 --- Ship it! Ship It! - Mehul Parikh On Dec. 28, 2017, 12:32

Re: Review Request 64740: RANGER-1938: Solr for Audit setup doesn't use DocValues effectively

2017-12-27 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64740/#review194566 --- Ship it! Ship It! - Mehul Parikh On Dec. 20, 2017, 1:22 a.m

Re: Review Request 67643: RANGER-2137 : Service Creation Failure, if user is not present in ranger database

2018-06-21 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67643/#review205170 --- Ship it! Ship It! - Mehul Parikh On June 20, 2018, 1:32 p.m

Re: Review Request 67635: RANGER-2136 - Upgrade to the released version of Atlas 1.0.0

2018-06-20 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67635/#review205069 --- Ship it! Ship It! - Mehul Parikh On June 18, 2018, 3:56 p.m

Re: Review Request 67687: RANGER-2138 : Add unit tests for org.apache.ranger.service package

2018-06-21 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67687/#review205228 --- Ship it! Ship It! - Mehul Parikh On June 21, 2018, 1:25 p.m

Re: Review Request 68062: Ranger to add default altlas policy for rangertagsync user.

2018-07-27 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68062/#review206539 --- Ship it! Ship It! - Mehul Parikh On July 26, 2018, 1:45 p.m

Re: Review Request 68031: RANGER-2138 : Add unit tests for org.apache.ranger.service package

2018-07-26 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68031/#review206492 --- Ship it! Ship It! - Mehul Parikh On July 24, 2018, 11:59

Re: Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

2018-07-29 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68042/#review206586 --- Ship it! Ship It! - Mehul Parikh On July 27, 2018, 7:32 a.m

Re: Review Request 68269: RANGER-2184 : Update RangerAtlas authorization to authorize add/update/remove of relationships

2018-08-09 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68269/#review207020 --- Ship it! Ship It! - Mehul Parikh On Aug. 8, 2018, 4:47 p.m

Re: Review Request 68191: RANGER-2182 : Handle upgrade scenario since atlas-service def is added with new resources for relationship

2018-08-09 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68191/#review207014 --- Ship it! Ship It! - Mehul Parikh On Aug. 8, 2018, 12:03 p.m

Re: Review Request 68292: RANGER-2187 : External Group search fails on Ranger UI when installed with postgres

2018-08-11 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68292/#review207110 --- Ship it! Ship It! - Mehul Parikh On Aug. 10, 2018, 11:19

Re: Review Request 68228: Unit Test cases to cover policy operations from service admin user

2018-08-07 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68228/#review206936 --- Ship it! Ship It! - Mehul Parikh On Aug. 7, 2018, 7:26 a.m

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

2018-08-07 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/#review206969 --- Ship it! Ship It! - Mehul Parikh On Aug. 7, 2018, 1:21 p.m

Re: Review Request 68522: RANGER-2201 :- Log no ranger audits when entityId value is not null or empty string

2018-08-27 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68522/#review207976 --- Ship it! Ship It! - Mehul Parikh On Aug. 27, 2018, 12:33

Re: Review Request 67835: RANGER-2150: Unit test coverage for XUserMgr and UserMgr class

2018-07-22 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67835/#review206331 --- Ship it! Ship It! - Mehul Parikh On July 7, 2018, 5:45 a.m

Re: Review Request 68037: RANGER-2161 : Improvement in policy screen permission item's

2018-07-25 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68037/#review206443 --- Ship it! Ship It! - Mehul Parikh On July 25, 2018, 10:06

Re: Review Request 67782: RANGER-2144 - refactor DAO creation

2018-09-05 Thread Mehul Parikh
. Can you please rebase your patch to latest master branch? - Mehul Parikh On Aug. 6, 2018, 7:44 p.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 68428: RANGER-1935/RANGER-1738 - Upgrade Ranger to support Apache Hadoop 3.0.0

2018-09-05 Thread Mehul Parikh
. Can you please rebase your patch? - Mehul Parikh On Sept. 5, 2018, 8:56 a.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: [VOTE] Apache Ranger Release 1.1.0-rc2

2018-07-06 Thread Mehul Parikh
nger+1.1.0+-+Release+Notes > > > Build verification steps can be found at: >http://ranger.apache.org/quick_start_guide.html > > > The vote will be open for at least 72 hours or until necessary number of > votes are reached. > [ ] +1 approve > [ ] +0 no opinion &g

Re: Review Request 67804: Improve ranger coverage of unit tests for REST layer.

2018-07-03 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67804/#review205675 --- Ship it! Ship It! - Mehul Parikh On July 3, 2018, 7:35 a.m

Re: Review Request 65259: improvement on user-group page listing

2018-01-24 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65259/#review196117 --- Ship it! Ship It! - Mehul Parikh On Jan. 22, 2018, 7:03 a.m

Re: Review Request 65860: RANGER-2003: On Report page 'User, Group and Access' details are not shown for policyItem exceeding more than 25 policies

2018-03-06 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65860/#review198762 --- Ship it! Ship It! - Mehul Parikh On March 1, 2018, 9:39 a.m

Re: Review Request 65924: RANGER-2011: Level 20 resource value is not set on UI in Ranger Edit Policy.

2018-03-06 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65924/#review198763 --- Ship it! Ship It! - Mehul Parikh On March 6, 2018, 2:08 p.m

Re: Review Request 65922: RANGER-2008: Policy evaluation is failing for multiline policy conditions.

2018-03-06 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65922/#review198761 --- Ship it! Ship It! - Mehul Parikh On March 6, 2018, 1:23 p.m

Re: Review Request 66021: RANGER-2014: Unable to see policy detail in view policy mode after updating recursive flag

2018-03-11 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66021/#review199001 --- Ship it! Ship It! - Mehul Parikh On March 10, 2018, 3:27

Re: [VOTE] Apache Ranger Release 1.0.0-rc0 (Updated links)

2018-03-13 Thread Mehul Parikh
+1 (binding) - Successfully extracted tar file - Able to clean and build successfully with rat plugin. On Mar 13, 2018 7:21 AM, "Sailaja Polavarapu" wrote: > Rangers: > Thank you for your contribution to Apache Ranger community. Apache Ranger > 1.0.0 release

Re: [VOTE] Apache Ranger Release 1.0.0-rc1

2018-03-15 Thread Mehul Parikh
.org/quick_start_guide.html > > > The vote will be open for at least 72 hours or until necessary number of > votes are reached. > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > Here is my +1 > > Thanks, > Sailaja. > > -- Thanks and regards, Mehul Parikh M: +91 98191 54446 E: xsme...@gmail.com

Re: Review Request 66080: RANGER-2015: In view policy we are able to see 'Deny Policy' & 'Except Conditions' even if 'enableDenyAndExceptionsInPolicies : false'

2018-03-15 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66080/#review199251 --- Ship it! Ship It! - Mehul Parikh On March 15, 2018, 7:21

Re: Review Request 66301: RANGER-2040 : Improvement in Analytics Metric of Ranger Admin and Ranger Kms for Users/groups metric collection for Auditor Role.

2018-04-03 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66301/#review200348 --- Ship it! Ship It! - Mehul Parikh On April 3, 2018, 5:23 a.m

Re: Review Request 66448: Good coding practices for KMS and unixauth

2018-04-07 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66448/#review200697 --- Ship it! Ship It! - Mehul Parikh On April 5, 2018, 11 a.m

Re: Review Request 66245: Ranger Kafka default policy creation improvement

2018-04-06 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66245/#review200641 --- Ship it! Ship It! - Mehul Parikh On April 3, 2018, 7:21 a.m

Re: Review Request 66473: RANGER-2059 : Write unit tests for export/import functionality

2018-04-06 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66473/#review200640 --- Ship it! Ship It! - Mehul Parikh On April 5, 2018, 10:21

Re: Review Request 66509: RANGER-2060 : Knox proxy with knox-sso is not working for ranger

2018-04-11 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66509/#review200896 --- Ship it! Ship It! - Mehul Parikh On April 9, 2018, 2:33 p.m

Re: Review Request 66499: RANGER-2062: Update jQuery version

2018-04-11 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66499/#review200897 --- Ship it! Ship It! - Mehul Parikh On April 9, 2018, 6:07 a.m

Re: Review Request 66506: RANGER-2057: ranger-ugsync-default file not found and Log message

2018-04-09 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66506/#review200789 --- Ship it! Ship It! - Mehul Parikh On April 9, 2018, 12:06

Re: Review Request 66304: RANGER-2041 : Handle validations for passwords of admin accounts during ranger install.

2018-04-08 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66304/#review200721 --- Ship it! Ship It! - Mehul Parikh On April 7, 2018, 12:27

Re: Review Request 66627: RANGER-1985:Auditing for Ranger Usersync operations

2018-04-17 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66627/#review201300 --- Ship it! Ship It! - Mehul Parikh On April 16, 2018, 2:35

Review Request 66681: RANGER-2071 : Correct log file permissions for Tagsync and usersync

2018-04-18 Thread Mehul Parikh
permission is provided to group and others. Thanks, Mehul Parikh

Re: Review Request 66684: RANGER-2070 : Ranger Storm service creation fails

2018-04-19 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66684/#review201609 --- Ship it! Ship It! - Mehul Parikh On April 19, 2018, 2:34

Review Request 66731: RANGER-2075 : Handle restart of Ranger Admin service from ranger-admin-services.sh

2018-04-20 Thread Mehul Parikh
-admin-services.sh 7061cd5 Diff: https://reviews.apache.org/r/66731/diff/1/ Testing --- Verified Stop, start and restart actions of ranger admin service. Thanks, Mehul Parikh

Re: Review Request 66241: RANGER-2032: Use consolidated and optimized DB schema script for fresh install of Ranger

2018-03-27 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66241/#review200029 --- Ship it! Ship It! - Mehul Parikh On March 27, 2018, 4:34

  1   2   3   4   5   6   >