Re: [Discuss] Start release process 0.9.3

Alina, Please use develop to test your current build. Thanks, Piotr czw., 6 wrz 2018 o 15:24 Harbs napisał(a): > OK. Done. > > > On Sep 6, 2018, at 4:20 PM, Piotr Zarzycki > wrote: > > > > I'm ok with merging back to develop, since everything seems to be > working. > > -- Piotr Zarzycki

Re: [Discuss] Start release process 0.9.3

OK. Done. > On Sep 6, 2018, at 4:20 PM, Piotr Zarzycki wrote: > > I'm ok with merging back to develop, since everything seems to be working.

Re: [Discuss] Start release process 0.9.3

Sorry I can’t help with that. Good luck figuring that out! Harbs > On Sep 6, 2018, at 4:13 PM, Piotr Zarzycki wrote: > > It looks like something is missing for Maven build, cause I have error > which I have mentioned earlier. > > czw., 6 wrz 2018 o 15:11 Harbs napisał(a): > >> Yeah. Looks

Re: [Discuss] Start release process 0.9.3

I'm ok with merging back to develop, since everything seems to be working. Once you merge that I will start playing with release process. czw., 6 wrz 2018 o 15:13 Piotr Zarzycki napisał(a): > It looks like something is missing for Maven build, cause I have error > which I have mentioned

Re: [Discuss] Start release process 0.9.3

It looks like something is missing for Maven build, cause I have error which I have mentioned earlier. czw., 6 wrz 2018 o 15:11 Harbs napisał(a): > Yeah. Looks about the same. > > MX HelloWorld is working. > > > On Sep 6, 2018, at 4:05 PM, Piotr Zarzycki > wrote: > > > > Harbs, > > > > I think

Re: [Discuss] Start release process 0.9.3

Yeah. Looks about the same. MX HelloWorld is working. > On Sep 6, 2018, at 4:05 PM, Piotr Zarzycki wrote: > > Harbs, > > I think we should assume that you can see following results [1] - This has > been build from MXRoyale branch. > > What about MX HelloWorld example ? Is it working for you

Re: [Discuss] Start release process 0.9.3

Harbs, I think we should assume that you can see following results [1] - This has been build from MXRoyale branch. What about MX HelloWorld example ? Is it working for you ? [1]

Re: [Discuss] Start release process 0.9.3

I have Tour de Flex compiled on my machine, and I can load the Tour de Flex app in JS. However, none of the examples actually seem to work. Can I assume that’s to be expected? If yes, I think it’s time to merge back into develop and move the MXRoyale development over to develop as well.

Re: [Discuss] Start release process 0.9.3

Harbs, I will need your assistance with getting up Your Dr Flex. I will still try ant build etc, but don't want to spend to much time on this if others have it working. Thanks for checking! Piotr On Thu, Sep 6, 2018, 11:13 AM Harbs wrote: > I just tried compiling tourdeflexmodules. > > I’m

Re: [Discuss] Start release process 0.9.3

I just tried compiling tourdeflexmodules. I’m getting an error on On Sep 6, 2018, at 10:27 AM, Alex Harui wrote: > > For Windows users, if you are not using Internet Explorer, you may still need > to open IE or go to Internet Options in Control Panel and clear its cache. > > HTH, > -Alex >

Re: [Discuss] Start release process 0.9.3

For Windows users, if you are not using Internet Explorer, you may still need to open IE or go to Internet Options in Control Panel and clear its cache. HTH, -Alex On 9/6/18, 12:08 AM, "Piotr Zarzycki" wrote: Hi Guys, I was trying to check Tour De Flex if it has the same issue

Re: [Discuss] Start release process 0.9.3

Did you try ant thirdparty-downloads directly? I’m pretty sure it only downloads the assets if they weren’t already downloaded. You can probably also try downloading and expanding manually. > On Sep 6, 2018, at 10:08 AM, Piotr Zarzycki wrote: > > Hi Guys, > > I was trying to check Tour De

Re: [Discuss] Start release process 0.9.3

I don’t know. It worked for me the last time I compiled. You can try building the js-only build. > On Sep 6, 2018, at 10:08 AM, Piotr Zarzycki wrote: > > Hi Guys, > > I was trying to check Tour De Flex if it has the same issue as the rest of > MX examples. In order to do that I would like to

Re: [Discuss] Start release process 0.9.3

Hi Guys, I was trying to check Tour De Flex if it has the same issue as the rest of MX examples. In order to do that I would like to build Framework using ANT. I got it working couple of days ago, but now it's constantly failing. Pixel blender is downloaded corrupted. [1] Do you have any idea why

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Those probably need to be changed the itemRenderer equivalents (numItemRenderers, etc.) > On Sep 5, 2018, at 2:28 PM, Carlos Rovira wrote: > > Hi Harbs, > > I'm seeing few problems in JewelExample, that pass unnoticed for me > yesterday. Maybe I was testing release and not debug...don't know:

Re: [Discuss] Start release process 0.9.3

> On Sep 4, 2018, at 7:34 PM, Alex Harui wrote: > > Or not. Layouts are easy to change out. I agree that it would be nice to > have better naming/hinting about potential layout issues, but it wouldn't be > the highest priority IMO. > > But adding function calls on every instance of UIBase

Re: [Discuss] Start release process 0.9.3

Or not. Layouts are easy to change out. I agree that it would be nice to have better naming/hinting about potential layout issues, but it wouldn't be the highest priority IMO. But adding function calls on every instance of UIBase when only a few had this collision seems not very PAYG to me.

Re: [Discuss] Start release process 0.9.3

It looks like main application is using ApplicationLayout, but it is not ILayoutHost type. wt., 4 wrz 2018 o 15:35 Piotr Zarzycki napisał(a): > It looks like there is a missing Layout for main application, because that > function returns null: > > var /** @type

Re: [Discuss] Start release process 0.9.3

royale-confie.xml wasn't in distribution folder, so it was not copied. I think the way Chris made distribution was copy a version of some file-template.xml and a duplicate without "-template" in the name. So I added those files, but still don't get VSCode works ok regarding "royale-asjs" folder,

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

I already did in that commit, we have both now El mar., 4 sept. 2018 a las 13:31, Harbs () escribió: > Great. I’ll add the asconfigc tasks to that later. > > > On Sep 4, 2018, at 2:10 PM, Carlos Rovira > wrote: > > > > I found it how to do it > > New VSCode forma 2.0.0 solves this and more :))

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Great. I’ll add the asconfigc tasks to that later. > On Sep 4, 2018, at 2:10 PM, Carlos Rovira wrote: > > I found it how to do it > New VSCode forma 2.0.0 solves this and more :)) > > one thing it you can configure a task to be default, but I didn't commit > anyone as default since the others

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

I found it how to do it New VSCode forma 2.0.0 solves this and more :)) one thing it you can configure a task to be default, but I didn't commit anyone as default since the others will be less quick to execute El mar., 4 sept. 2018 a las 12:55, Harbs () escribió: > Awesome. :-) > > > On Sep 4,

Re: [Discuss] Start release process 0.9.3

Yes. royale-asjs. Does Maven copy the royale-config.xml file? That’s required and is done by the ant build. > On Sep 4, 2018, at 1:30 PM, Carlos Rovira wrote: > > mmm "asjs" folder is "royale-asjs" ? > If I try to click in VSCode the SDK button (bottom-right) and click then > "Add more

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi, I revert my revert ;), so I can find a non intrusive way. I'm sure VSCode should have a way to configure a task but make it not default or block AS3 extension when I get it I'll commit the solution El mar., 4 sept. 2018 a las 12:20, Harbs () escribió: > I had some errors on missing

Re: [Discuss] Start release process 0.9.3

mmm "asjs" folder is "royale-asjs" ? If I try to click in VSCode the SDK button (bottom-right) and click then "Add more SDKs to this list..." (button on top of VSCode) and go to "royale-asjs" it's not recognized as a valid SDK. Or are you talking about other asjs folder? El mar., 4 sept. 2018

Re: [Discuss] Start release process 0.9.3

I’m not totally sure what you’re asking. I have VS Code pointed to my asjs folder. The only thing you need to do to make it a valid SDK is copying playerglobal to frameworks/libs/player/11.1/playerglobal.swc: Thanks, Harbs > On Sep 4, 2018, at 1:16 PM, Carlos Rovira wrote: > > Harbs, > > I

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

I had some errors on missing resources. I’ve never managed to get maven to work for me. Dunno why. The tasks.json file overrides the defaults, so the build task uses maven instead of asconfigc. We should either modify the tasks.json file to allow for multiple build tasks, or include it in

Re: [Discuss] Start release process 0.9.3

Harbs, I suppose you create a SDK from develop to use with VSCode. Do you create it with ANT? Can you post here how do you build it? I guess that we are very near to get a valid SDK build with maven, so if is few time, I'll try to fix this for this release, since I think it could be a good

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi, AMF/RemoteObject examples working as expected! I think we can merge in develop, if others have tested other example projects and all is working ok. With all that merged, we can release we can in parallel start conversation about how Basic linking affect Jewel. I have a compilation with

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi Harbs, Jewel all working right!, :) good work on merging I need to test now AMF/RemoteObject I revert latest commit since launch.json works ok with maven, what problem did you find? Is what I use in day-by-day to work with VSCode Let's go to test AMF thanks El mar., 4 sept. 2018 a las

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi Harbs, thanks! I'll be looking at it now. Will be soon reporting Carlos El mar., 4 sept. 2018 a las 10:41, Harbs () escribió: > Please let me know whether you think the merge branch should be merged > back into develop… > > > On Sep 4, 2018, at 11:18 AM, Harbs wrote: > > > > DataGroup is not

Re: [Discuss] Start release process 0.9.3

Cool. Thanks. I merged in all new commits in MXRoyale and develop. > On Sep 4, 2018, at 12:05 PM, Piotr Zarzycki wrote: > > Harbs, > > I will start checking tour De Flex in couple of hours. > > I saw yesterday new Pull Requests accepted from Pashmina in MXRoyale > branch. Could make sure

Re: [Discuss] Start release process 0.9.3

Harbs, I will start checking tour De Flex in couple of hours. I saw yesterday new Pull Requests accepted from Pashmina in MXRoyale branch. Could make sure that is included in integration branch? Thanks, Piotr On Tue, Sep 4, 2018, 10:23 AM Harbs wrote: > If we’re going to have “compatible

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Please let me know whether you think the merge branch should be merged back into develop… > On Sep 4, 2018, at 11:18 AM, Harbs wrote: > > DataGroup is not an IItemRendererParent any more, so the Jewel DataGroup > doesn’t work the way it was being used. > > I based it on DataContainer and

Re: [Discuss] Start release process 0.9.3

If we’re going to have “compatible sets”, we’re going to need some way of organizing them (naming or otherwise) to indicate which sets of layouts are compatible with each other. > On Sep 4, 2018, at 10:28 AM, Alex Harui wrote: > > It seems to me that there are going to be incompatible sets of

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

DataGroup is not an IItemRendererParent any more, so the Jewel DataGroup doesn’t work the way it was being used. I based it on DataContainer and change the access code in the view and controller to make it work. It looks to me like the whole Jewel playground functions correctly now. Let me

Re: [Discuss] Start release process 0.9.3

It also allows layouts which might use class names to specify the set display without writing to the style. > On Sep 4, 2018, at 11:02 AM, Harbs wrote: > > The code in UIBase is actually an optimization. I don’t think it’s just in > case, and IMO it’s not heavy. > > Before that method, the

Re: [Discuss] Start release process 0.9.3

The code in UIBase is actually an optimization. I don’t think it’s just in case, and IMO it’s not heavy. Before that method, the only way a layout could check what’s set, is to read the style which can cause a reflow. > On Sep 4, 2018, at 10:28 AM, Alex Harui wrote: > > IMO, this is too

Re: [Discuss] Start release process 0.9.3

IMO, this is too heavy and just-in-case for UIBase. It seems to me that there are going to be incompatible sets of layouts. IOW, if you want to use flexbox, you may have to use flexbox layouts in all parents. And not use percentages in the children (IIRC). And not nest flexboxes, etc.

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

I fixed everything except ComboBox. I’m not sure why my fix didn’t resolve ComboBox too. Looking into it… Looking good… :-) > On Sep 3, 2018, at 10:04 PM, Carlos Rovira wrote: > > Hi > > as Piotr said JewelExample is the example to check. Fixing DataGroup should > fix the four sections

Re: [Discuss] Start release process 0.9.3

I have item1 > item2 > item3. Item1 has a VerticalLayout This sets item2 to block Item2 has OneFlexibleChildHorizontalLayout which sets itself to flex and sets flex-grow and flex-shrink on item3 VerticalLayout and OneFlexibleChildHorizontalLayout are stepping on each other when setting the

Re: [Discuss] Start release process 0.9.3

Hmm. That change doesn't make sense to me. AIUI, some component has flex layout and a child has block. The child with a vertical layout should be setting block on its children, not itself. Of course, I could be wrong... -Alex On 9/3/18, 3:52 AM, "Harbs" wrote: Yup. That seems to

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi as Piotr said JewelExample is the example to check. Fixing DataGroup should fix the four sections involved: -TablePlayGround -DateComponentsPlayGround -ComboBoxPlayGround -ListPlayGround just as a hint, I move this lines in MainContent.mxml to the bottom of ApplicationMainContent, to let the

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

I see the problem. I’m out of time for tonight. I’ll work on fixing this in the morning. Thanks, Harbs > On Sep 3, 2018, at 3:46 PM, Carlos Rovira wrote: > > The problem here's the changes in DataGroup, we can skip this problem if we > want for now making Jewel DataGroup be equal to old

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

I'm glad that you resolved it! :) pon., 3 wrz 2018 o 20:21 Harbs napisał(a): > Huh. I had an outdated version of asconfigc installed… > > > On Sep 3, 2018, at 9:16 PM, Harbs wrote: > > > > I saw that, but for some reason it did not work for me… > > > >> On Sep 3, 2018, at 9:11 PM, Piotr

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

That token is working for Moonshine as well, so not sure what is wrong on your end. :( pon., 3 wrz 2018 o 20:16 Harbs napisał(a): > I saw that, but for some reason it did not work for me… > > > On Sep 3, 2018, at 9:11 PM, Piotr Zarzycki > wrote: > > > > It's recognized. Today I have fixed

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Huh. I had an outdated version of asconfigc installed… > On Sep 3, 2018, at 9:16 PM, Harbs wrote: > > I saw that, but for some reason it did not work for me… > >> On Sep 3, 2018, at 9:11 PM, Piotr Zarzycki wrote: >> >> It's recognized. Today I have fixed Jewel Alert example by that commit

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

I saw that, but for some reason it did not work for me… > On Sep 3, 2018, at 9:11 PM, Piotr Zarzycki wrote: > > It's recognized. Today I have fixed Jewel Alert example by that commit [1] > > [1] > https://github.com/apache/royale-asjs/commit/37d24b86a674c61be9688f09492978c74a243f3b > >

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

It's recognized. Today I have fixed Jewel Alert example by that commit [1] [1] https://github.com/apache/royale-asjs/commit/37d24b86a674c61be9688f09492978c74a243f3b Thanks, Piotr pon., 3 wrz 2018 o 20:09 Harbs napisał(a): > I don’t think theme is recognized by asconfigc and I don’t think

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

I don’t think theme is recognized by asconfigc and I don’t think there’s a way to use relative paths or tokens as a compiler option. Am I missing something? > On Sep 3, 2018, at 8:59 PM, Piotr Zarzycki wrote: > > Harbs, > > I believe JewelExample contains TablePlayGround. If you will be

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Harbs, I believe JewelExample contains TablePlayGround. If you will be playing with that. Can you fix VSCode build as well ? Enough if you add missing parts in asconfig.json. Check what jewel theme is being used in pom.xml. Thanks, Piotr pon., 3 wrz 2018 o 19:54 Harbs napisał(a): > Hi Carlos,

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi Carlos, Thanks for checking. Which Jewel examples should I use to fix this? > On Sep 3, 2018, at 3:46 PM, Carlos Rovira wrote: > > Hi, congratulations! jewel example is running almost at 70% aprox > > Things to fix: > > * Table, this will fix DateChooser and this DateField (DateChooser

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi, congratulations! jewel example is running almost at 70% aprox Things to fix: * Table, this will fix DateChooser and this DateField (DateChooser uses a Table internally) The problem here's the changes in DataGroup, we can skip this problem if we want for now making Jewel DataGroup be equal to

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

build with maven is ok for me :) I try examples now El lun., 3 sept. 2018 a las 14:21, Harbs () escribió: > Oops. I broke that. > > Should be fixed now… > > > On Sep 3, 2018, at 3:09 PM, Carlos Rovira > wrote: > > > > Hi build with maven fails in MXRoyale: > > > > COMPC > > > > Loading

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Oops. I broke that. Should be fixed now… > On Sep 3, 2018, at 3:09 PM, Carlos Rovira wrote: > > Hi build with maven fails in MXRoyale: > > COMPC > > Loading configuration: > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/MXRoyale/target/compile-swf-config.xml > > >

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi build with maven fails in MXRoyale: COMPC Loading configuration: /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/MXRoyale/target/compile-swf-config.xml Warning: mx.controls.RichTextEditor is defined by multiple files:

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Maven build should work - I checked it one hour ago. I will try to get from your plate Tour De Flex. On Mon, Sep 3, 2018, 1:26 PM Harbs wrote: > > > On Sep 3, 2018, at 2:22 PM, Carlos Rovira > wrote: > > > > Hi Harbs > > > > just check what I can do: > > The branch you're working is

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

> On Sep 3, 2018, at 2:22 PM, Carlos Rovira wrote: > > Hi Harbs > > just check what I can do: > The branch you're working is "feature/new_merge" right? Yes. > this builds with maven? Theoretically, but I have not tried. Please let me know. > Can I check it out, build and test Jewel now?

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi Harbs just check what I can do: The branch you're working is "feature/new_merge" right? this builds with maven? Can I check it out, build and test Jewel now? So I can report what I see? thanks El lun., 3 sept. 2018 a las 13:17, Harbs () escribió: > I’m done for the morning and I’ll be out

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

I’m done for the morning and I’ll be out this afternoon. I’ll try to spend some more time this evening on this. I still need to: * Test the framework against some more of my apps. * Make sure the examples work. * See if the Jewel examples run. * See if Tour de Flex runs. Anyone who can confirm

Re: [Discuss] Start release process 0.9.3

Yup. That seems to work. > On Sep 3, 2018, at 1:45 PM, Harbs wrote: > > It is related to the merge because it works on the revert-refactor branch. > > I’m guessing the order of layouts changed somehow, but I don’t know where > that change is. > > I’m working on a change to VerticalLayout

Re: [Discuss] Start release process 0.9.3

It is related to the merge because it works on the revert-refactor branch. I’m guessing the order of layouts changed somehow, but I don’t know where that change is. I’m working on a change to VerticalLayout which should solve this... > On Sep 3, 2018, at 1:26 PM, Carlos Rovira wrote: > > Ok,

Re: [Discuss] Start release process 0.9.3

Ok, that layout is from Basic and I think there's no changes from MXRoyale in that part (Jewel for sure doesn't change Basic Layouts since I made Jewel ones based on CSS) So I think whatever problem in Basic Layouts could be a bug or something that seems to work and some change in your app made

Re: [Discuss] Start release process 0.9.3

I found where it’s going off. I have a component with a layout of OneFlexibleChildHorizontalLayout. It’s inside another component with a standard VerticalLayout. OneFlexibleChildHorizontalLayout.layout sets the position to flex and then the VerticalLayout sets it to block. For some reason

Re: [Discuss] Start release process 0.9.3

Hi Harbs, let me know if you want that I take a look, checking the branch and building it thanks El lun., 3 sept. 2018 a las 12:07, Harbs () escribió: > Foo. Something is setting Container position to “block” when the layout > should be setting it to “flex”… :-( > > > On Sep 3, 2018, at 1:01

Re: [Discuss] Start release process 0.9.3

Foo. Something is setting Container position to “block” when the layout should be setting it to “flex”… :-( > On Sep 3, 2018, at 1:01 PM, Piotr Zarzycki wrote: > > Good news Harbs! Thank you! > > pon., 3 wrz 2018 o 11:58 Harbs > napisał(a): > >> I just got the

Re: [Discuss] Start release process 0.9.3

Good news Harbs! Thank you! pon., 3 wrz 2018 o 11:58 Harbs napisał(a): > I just got the merge branch to work with my app. There’s some visual > differences still. Need to figure that out… > > > On Sep 3, 2018, at 5:53 AM, Alex Harui wrote: > > > > FWIW, I agree with Harbs. Enough time has

Re: [Discuss] Start release process 0.9.3

I just got the merge branch to work with my app. There’s some visual differences still. Need to figure that out… > On Sep 3, 2018, at 5:53 AM, Alex Harui wrote: > > FWIW, I agree with Harbs. Enough time has passed and changes have been made > that it is time to try making Jewel dependent on

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi Piotr, thanks for asking. Yes, if we want to try link Jewel is ok to link to others like HTML. Carlos El lun., 3 sept. 2018 a las 10:56, Piotr Zarzycki (< piotrzarzyck...@gmail.com>) escribió: > I'm doing Maven build and HTML was failing. It is because it need to depend > again from Basic.

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

I'm doing Maven build and HTML was failing. It is because it need to depend again from Basic. I can make the changes. Carlos are you on that right now ? I don't want to collide with you. Thanks, Piotr pon., 3 wrz 2018 o 10:28 Carlos Rovira napisał(a): > Hi Harbs, > > I'm available for you to

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi Harbs, I'm available for you to help you solve. write me when you need. Just a note: for doing this, I'll take the following path: I'll try to compile and run without make Jewel depend on Basic, since is the actual shape. From there I'll try to link Basic. I think that path will provide you a

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

OK. Everything compiles now. I’m going to run the branch against some applications and see what happens. If you could do the same, it would be helpful. Carlos, I probably need some direction on how to test Jewel. Harbs > On Sep 3, 2018, at 10:38 AM, Piotr Zarzycki wrote: > > Ok! Again good

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Ok! Again good luck! :) pon., 3 wrz 2018 o 09:34 Harbs napisał(a): > The issues that I see with Jewel are related to the changes that were lost > when you merged. > > I’m hoping I can resolve this quickly. Let’s see how over-optimistic I’m > being… ;-) > > Harbs > > > On Sep 3, 2018, at 10:28

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

The issues that I see with Jewel are related to the changes that were lost when you merged. I’m hoping I can resolve this quickly. Let’s see how over-optimistic I’m being… ;-) Harbs > On Sep 3, 2018, at 10:28 AM, Piotr Zarzycki wrote: > > Harbs, > > There is also another way. Maybe it is

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Harbs, There is also another way. Maybe it is worth that I will spend couple of hours on my branch and try to understand what was wrong. If I would manage to do that - maybe you will be able to add your stuff on top of that ? Do you see value in that approach ? I'm just afraid that doing again

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi Harbs, Looking forward to your changes. I'm just interested in release in whatever state it is and dealing with discussion later on. Btw. I have invested also at least 6h with merge stuff and as you can see it end up with bigger things. Good Luck! :) Thanks, Piotr pon., 3 wrz 2018 o 09:18

Re: Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Right now, my priority is getting all three active branches combined with all code working. That means MX/Spark, Jewel, and all the additions on the revert branch all coexisting nicely in the merge branch. I’m spending the better part of today on that. I’d like to hold off on discussing where

Make Jewel dependent on Basic (Re: [Discuss] Start release process 0.9.3)

Hi, considering making Jewel dependent on Basic. I'm trying to put my mind in that place. Since this is a huge effort for me, hope you all try to do the same as me and considering some thoughts, so we can plan something that works for all: Since Basic will be the middle point between Core and

Re: [Discuss] Start release process 0.9.3

FWIW, I agree with Harbs. Enough time has passed and changes have been made that it is time to try making Jewel dependent on Basic so we can see in code (not words) what the problems are with doing that. My 2 cents, -Alex On 9/2/18, 3:10 PM, "Carlos Rovira" wrote: Hi, I'm

Re: [Discuss] Start release process 0.9.3

Hi, I'm mostly done...well, there' still lots of things to do...but, I must cut on a point. Harbs, for my experience, I had to rewrite many things in the copied code from Basic (as I predicted). If you find a class in Jewel called XYZ.as. that class will share some percentage of code with

Re: [Discuss] Start release process 0.9.3

Harbs, In case of conflicts with Networks I did the same. If you can invest time on finishing this up - that would be better for me. Because I will be able to invest my time later for making release itself. Thanks, Piotr On Sun, Sep 2, 2018, 11:37 PM Harbs wrote: > FYI, there were a lot of

Re: [Discuss] Start release process 0.9.3

FYI, there were a lot of conflicts in Network related to AMF. I Made the assumption that the code in develop was the most up-to-date code. I’m not sure my assumption was correct. Those who worked on the code, please check my merges there… Thanks, Harbs > On Sep 3, 2018, at 12:34 AM, Harbs

Re: [Discuss] Start release process 0.9.3

I’m done for the night and I pushed what I’ve done so far. Currently everything builds with the exception of Jewel. Jewel List code is not compatible with the view changes done by Alex. I will work on resolving that in the morning if no-one gets to it before me. I made Jewel dependent on Basic

Re: [Discuss] Start release process 0.9.3

Cool! Let's wait than what Harbs gives us with his merge effort. Thanks, Piotr On Sun, Sep 2, 2018, 10:41 PM Carlos Rovira wrote: > Hi Piotr, > I reduced my list to only make some final touches in ComboBox and DateField > popups (responsive/classic visuals) that I should finish in the next few

Re: [Discuss] Start release process 0.9.3

Hi Piotr, I reduced my list to only make some final touches in ComboBox and DateField popups (responsive/classic visuals) that I should finish in the next few hours. Other points two points I want to address will be left out of this release. So I can focus on release by tomorrow morning El

Re: [Discuss] Start release process 0.9.3

Carlos, Do you think you will finish in the next 1-2 days those changes and make stop till release or better switch to branch with new features ? Thanks, Piotr niedz., 2 wrz 2018 o 21:41 Carlos Rovira napisał(a): > One more reason, is that I'm now making changes. Making such update over >

Re: [Discuss] Start release process 0.9.3

One more reason, is that I'm now making changes. Making such update over develop could make get stuck with some important work I already didn't stabilize to commit. El dom., 2 sept. 2018 a las 21:39, Carlos Rovira () escribió: > Hi Harbs, > > I insist that is better, to push to the branch so I

Re: [Discuss] Start release process 0.9.3

Hi Harbs, I insist that is better, to push to the branch so I can compare between develop and your branch. otherwise will be more difficult for me to get differences and patch them. Once I make the fixes, that is pretty sure I'll have to do, I can merge it directly or wait to others that would

Re: [Discuss] Start release process 0.9.3

Hi Harbs, I will wait for your branch and take a look into that as well. Thanks, Piotr niedz., 2 wrz 2018 o 20:36 Harbs napisał(a): > I hope to be able to push tonight. > > I’m pretty close, but there’s still some issues with the merge. > > Once I push, you can look at what I did and comment.

Re: [Discuss] Start release process 0.9.3

I hope to be able to push tonight. I’m pretty close, but there’s still some issues with the merge. Once I push, you can look at what I did and comment. :-) Harbs > On Sep 2, 2018, at 9:12 PM, Carlos Rovira wrote: > > Ok Harbs, > > I'll prefer, you say here you have it ok. So me and others

Re: [Discuss] Start release process 0.9.3

Ok Harbs, I'll prefer, you say here you have it ok. So me and others could build localy and test as most projects as possible, to detect that all is ok. As I said there's code on Jewel changed that will not work in the current state, and I think I'm the only one that knows what's working and what

Re: [Discuss] Start release process 0.9.3

I’m working on a new merge. I’m moving some classes back to Basic to reduce the number of conflicts. Let’s see if my attempt works any better. If it works well, I’ll push my branch when it’s done… On my first attempt to merge, I see lots of conflicts related to AMF. I’m not sure which is the

Re: [Discuss] Start release process 0.9.3

The problem is than far beyond the merge problems, code was changed in some classes (at least in Jewel I see changes), to get compiling. This make more difficult to be confident with the actual code I integration branch since we must to know what code is the latest, and see if code was not changed

Re: [Discuss] Start release process 0.9.3

HI Piotr, sorry about that, I can't never imagine that a normal var in maven (i.e: ${someVar}), would break something else in the other side of the world (i.e: lexUnit test). It's like if we insert a private var someVar:String in AS3 and this break a build. This one is very difficult, and I

Re: [Discuss] Start release process 0.9.3

I meant here DataContainerView and DataContainerBase missing methods there. Thanks, Piotr niedz., 2 wrz 2018 o 14:24 Harbs napisał(a): > I’m not sure what you are referring to. Do you mean the merge conflicts? > > I’m pretty sure there is more than one class which has conflicts. Carlos > is

Re: [Discuss] Start release process 0.9.3

I’m not sure what you are referring to. Do you mean the merge conflicts? I’m pretty sure there is more than one class which has conflicts. Carlos is right that there could be lot of classes which need resolution, but I’m not sure what the right answer is. We might need to go through all the

Re: [Discuss] Start release process 0.9.3

Hi Carlos, Please let's do not make such drastical steps. It looks like Harbs found where the issue is. Let's make the changes and see whether it is working. Harbs can you do this? Thanks, Piotr On Sun, Sep 2, 2018, 12:42 PM Harbs wrote: > To tell you the truth, I don’t understand exactly

Re: [Discuss] Start release process 0.9.3

To tell you the truth, I don’t understand exactly how the tokens are working, but the $ prefix definitely breaks it. I’m guessing the brackets is an XML construct recognized as a variable in things like E4X. Harbs > On Sep 2, 2018, at 1:30 PM, Carlos Rovira wrote: > > Hi Habs, > > El dom.,

Re: [Discuss] Start release process 0.9.3

El dom., 2 sept. 2018 a las 12:22, Harbs () escribió: > It looks like the merge from MXRoyale has problems. > > DataContainerView has none of the changes that were done in MXRoyale > (among other things) > > DataContainerView got all the methods that were originally in > DataContainerBase, but

Re: [Discuss] Start release process 0.9.3

El dom., 2 sept. 2018 a las 11:59, Harbs () escribió: > Now that I’m able to compile, I started testing the current state… > > Why was DataContainerBase changed? > > DataContainerBase.removeAllItemRenderers no longer exists. > DataItemRendererFactoryForArrayList.dataProviderChangeHandler calls >

<    1   2   3   4   >