Re: Review Request 60955: SENTRY-1853: Add the log level access mechanism

/sentry/provider/db/service/thrift/TestSentryServerLogLevel.java Lines 37 (patched) <https://reviews.apache.org/r/60955/#comment256713> Why do we need an empty before/after methods? Can these be removed? - Alexander Kolbasov On July 24, 2017, 7:39 a.m., Donghui Xu

Re: Review Request 60955: SENTRY-1853: Add the log level access mechanism

he/sentry/provider/db/service/thrift/TestSentryServerLogLevel.java Lines 63 (patched) <https://reviews.apache.org/r/60955/#comment256712> Should it also check that the log level matches whatever logger thinks it is? - Alexander Kolbasov On July 24, 2017, 7:39 a.m., Donghui Xu wrote:

Re: Splitting permissions and path updates

ore); > pathsUpdater = new DBUpdateForwarder<>(pathImageRetriever, > pathDeltaRetriever); <- path has its own instance > permsUpdater = new DBUpdateForwarder<>(permImageRetriever, > permDeltaRetriever); <- perm has its own instance > ... > } > > Th

Re: JIRA versions

Removed. On Mon, Jul 24, 2017 at 5:02 PM, Colm O hEigeartaigh wrote: > I still see the following version in JIRA: > > https://issues.apache.org/jira/projects/SENTRY/versions/12336080 > > Colm. > > On Mon, Jul 24, 2017 at 3:57 PM, Alexander Kolbasov > wrote: > &g

Re: Sentry-jdk-1.7-v2 - Build # 100 - Still Failing

Thanks Dapeng! On Mon, Jul 24, 2017 at 10:12 AM, Sun, Dapeng wrote: > The failure is happened on ubuntu-eu2, I have removed this node from build > list. > > -Original Message- > From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] > Sent: Monday, July 24, 2017 4:06 PM > To: s..

Re: JIRA versions

Done! On Mon, Jul 24, 2017 at 10:21 AM, Colm O hEigeartaigh wrote: > Can someone with admin privileges on JIRA make this happen? Just bulk move > all sentry-ha-redesign issues to 2.0.0 + delete the sentry-ha-redesign > version once this is done. > > Colm. > > On Thu, Jul 20, 2017 at 4:26 PM, Kal

Re: JIRA versions

I am in the process of doing that On Mon, Jul 24, 2017 at 4:41 PM, Mat Crocker wrote: > Hi Colm, > > Can you confirm this is the set you are trying to migrate? > > "project = sentry and (fixVersion = sentry-ha-redesign or affectedVersion = > sentry-ha-redesign) " > > Happy to help. > > > > On Mo

Splitting permissions and path updates

Lina’s email prompted an interesting thought - right now when the NameNode plugin isn’t happy and wants a full update we send it both permissions update and path update. Path update is very expensive while permissions update is usually much smaller. It would be very useful to be able to send ju

Re: SENTRY-1855: PERM/PATH transactions can fail to commit to the sentry database under load

Lina, Thank you for sending a detailed summary! > On Jul 22, 2017, at 12:29 AM, Na Li > wrote: > > Hello, > > Can you provide your feedback on this issue? We need to make decision soon. > > 1) Summary > > The current approach updates changeID (primary key for per

Re: Review Request 60883: SENTRY-1825: Dropping a Hive database/table doesn't cleanup the permissions associated with it

er/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java Lines 223 (patched) <https://reviews.apache.org/r/60883/#comment256544> Please document what this case is testing. Same for tests below. - Al

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60926/#review181048 --- Ship it! Ship It! - Alexander Kolbasov On July 19, 2017, 8

Re: Review Request 60926: SENTRY-1760: HMSFollower should detect when a full snapshot from HMS is required

entryHMSClient.java Lines 239 (patched) <https://reviews.apache.org/r/60926/#comment256314> can eventId be null here? - Alexander Kolbasov On July 18, 2017, 8:23 p.m., Sergio Pena wrote: > > --- > This i

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

> On July 12, 2017, 7:01 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HmsFollower.java > > Lines 84 (patched) > > <https://reviews.apache.org/r/59508/diff/9/?file=1774882#file1774882line84> >

Re: Review Request 60806: SENTRY-1696 Expose time spent creating the initial snapshot as a metric

reply, visit: https://reviews.apache.org/r/60806/#review180351 --- On July 12, 2017, 3:59 p.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60806/ >

Re: Review Request 60779: SENTRY-1798: Provide names for HMSFollower and cleaner threads

at it is called multiple times. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60779/#review180312 ------- On July

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

caller logging the exception? Since you just re-throw the exception you can as well just remove the try statement and propagate it to the caller - Alexander Kolbasov On July 12, 2017, 5:44 p.m., kalyan kumar kalvagadda wrote: > > -

Re: Review Request 60669: SENTRY-1762 notification id's in SENTRY_HMS_NOTIFICATION_ID should be purged periodically

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60669/#review180337 --- Ship it! Ship It! - Alexander Kolbasov On July 12, 2017, 6

Review Request 60812: SENTRY-1697: Deprecate feature flag for enabling notification log

/e2e/hdfs/TestHDFSIntegrationBase.java ba507523077f3205ada214eeaf88c22d45468019 Diff: https://reviews.apache.org/r/60812/diff/1/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 60806: SENTRY-1696 Expose time spent creating the initial snapshot as a metric

iew180313 --- On July 12, 2017, 3:59 p.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Review Request 60806: SENTRY-1696 Expose time spent creating the initial snapshot as a metric

--- Thanks, Alexander Kolbasov

Re: Sentry interactive CLI

> wrote: > > > > > On Tue, Jun 27, 2017 at 11:39 PM, Alexander Kolbasov > > > wrote: > > > >> a) I think it supports command history with arrow keys. > >> > > > > It would be good to integrate this if it is supported by cliche - > &g

Re: Review Request 60779: SENTRY-1798: Provide names for HMSFollower and cleaner threads

://reviews.apache.org/r/60779/diff/4/ Changes: https://reviews.apache.org/r/60779/diff/3-4/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 60779: SENTRY-1798: Provide names for HMSFollower and cleaner threads

/60779/diff/3/ Changes: https://reviews.apache.org/r/60779/diff/2-3/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 60779: SENTRY-1798: Provide names for HMSFollower and cleaner threads

/diff/2/ Changes: https://reviews.apache.org/r/60779/diff/1-2/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 60779: SENTRY-1798: Provide names for HMSFollower and cleaner threads

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60779/#review180240 --- On July 11, 2017, 6:55 p.m., Alexander Kolbasov wrote: > > -

Review Request 60779: SENTRY-1798: Provide names for HMSFollower and cleaner threads

sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java ec938da1fb02bd0e58554336b671d14e7c6fc621 Diff: https://reviews.apache.org/r/60779/diff/1/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 60775: SENTRY-1630 out of sequence error in HMSFollower

7;ll do it in Sentry, but I'd prefer Hive team to provide it. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60775/#review180207 --- On July 11, 2017, 3:46 p.m., Alexander Kolb

Re: Review Request 60775: SENTRY-1630 out of sequence error in HMSFollower

://reviews.apache.org/r/60775/diff/1-2/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 60502: SENTRY-1817: Deprecate SENTRY_HA_ENABLED and all tests that use it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60502/#review180225 --- Ship it! Ship It! - Alexander Kolbasov On July 11, 2017, 5

Review Request 60777: SENTRY-1833 Expose current set of IDs as Sentry metrics

--- Thanks, Alexander Kolbasov

Re: Review Request 60669: SENTRY-1762 notification id's in SENTRY_HMS_NOTIFICATION_ID should be purged periodically

27;t add any value - probably should be removed. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 2937 (patched) <https://reviews.apache.org/r/60669/#comment255237> This is test-only, so can be protected - Alexande

Review Request 60775: SENTRY-1630 out of sequence error in HMSFollower

-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java ec938da1fb02bd0e58554336b671d14e7c6fc621 Diff: https://reviews.apache.org/r/60775/diff/1/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 60669: SENTRY-1762 notification id's in SENTRY_HMS_NOTIFICATION_ID should be purged periodically

/sentry/provider/db/service/persistent/SentryStore.java Lines 547 (patched) <https://reviews.apache.org/r/60669/#comment255144> Can we unify and another purge method? They only differ in the type of entry - Alexander Kolbasov On July 8, 2017, 3:31 p.m., kalyan kumar kalvagadda

Re: Review Request 60502: SENTRY-1817: Deprecate SENTRY_HA_ENABLED and all tests that use it

a Line 117 (original), 116 (patched) <https://reviews.apache.org/r/60502/#comment255138> Why are you still starting ZK? - Alexander Kolbasov On July 10, 2017, 7:17 p.m., Na Li wrote: > > --- > This is an automatically

Re: Review Request 60727: SENTRY-1828 Rename version in sentry-ha-redesign branch to 2.0.0-SNAPSHOT

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60727/#review180118 --- Ship it! Ship It! - Alexander Kolbasov On July 10, 2017, 8

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60518/#review180103 --- Ship it! Ship It! - Alexander Kolbasov On July 10, 2017, 9

Re: Review Request 60727: SENTRY-1828 Rename version in sentry-ha-redesign branch to 2.0.0-SNAPSHOT

iginal), 42 (patched) <https://reviews.apache.org/r/60727/#comment255126> Why are you adding LOGGER - it isn't used later - Alexander Kolbasov On July 10, 2017, 8:45 p.m., kalyan kumar kalvagadda wrote: > > --- >

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java Lines 142 (patched) <https://reviews.apache.org/r/60518/#comment255107> Yeah, this is rather ugly as well... The String.format was at least cleaner :-( - Alexander Kolbasov On July 7, 2017, 5:07 p.m., Sergi

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

> On July 6, 2017, 3:25 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java > > Lines 72 (patched) > > <https://reviews.apache.org/r/60518/diff/5/?file=1769585#file1769585line72> > >

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

> On July 6, 2017, 5:06 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > > Line 139 (original), 139 (patched) > > <https://reviews.apache.org/r/60518/diff/5/?file=17

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java Line 47 (original), 57 (patched) <https://reviews.apache.org/r/59508/#comment255073> Please document what this and other tests are actually testing. - Alexander Kolbasov On July 10, 2017, 3:

Re: Review Request 60727: SENTRY-1828 Rename version in sentry-ha-redesign branch to 2.0.0-SNAPSHOT

der/db/service/persistent/SentryStoreSchemaInfo.java Lines 65 (patched) <https://reviews.apache.org/r/60727/#comment255069> What is this? - Alexander Kolbasov On July 8, 2017, 3:38 p.m., kalyan kumar kalvagadda wrote: > > --

Re: Code style and checkstyle

file and added it to intellij. > > To change the existing code according to this style I should pick a file > and apply Code=>Format Code menu option. > > Is there something else I should be doing? > > -Kalyan > > On Fri, Jul 7, 2017 at 4:34 PM, Alexander Kolbasov

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

ment254910> This and the next one can be private. They can be final as well. sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestSentryHMSClient.java Lines 70 (patched) <https://reviews.apache.org/r/59508/#comment254911> This one is never used

Re: Review Request 60669: SENTRY-1762 notification id's in SENTRY_HMS_NOTIFICATION_ID should be purged periodically

> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60669/ > --- > > (Updated July 5, 2017, 11:10 p.m.) > > > Review request for sentry, Alexand

Re: Code style and checkstyle

the google java style. Seems more updated to the developing > practices these days. > > On Fri, Jul 7, 2017 at 10:55 AM, Alexander Kolbasov > wrote: > > > Thanks Lina. What is AD_SAL and MD_SAL? Who were you citing as the person > > preferring yo use Google Java style? I

Re: [DISCUSS] Sentry 1.8.0 release

Sergio, thanks for stepping up. We'll figure out something to get things moving. Hopefully Kalyan will have some time to do any required commits otherwise someone else will step in. Please go ahead and start the process. - Alex On Fri, Jul 7, 2017 at 11:11 PM, Sergio Pena wrote: > Hi, > > It's

Re: Code style and checkstyle

cided on going > with that style." > > I like the idea of enforcing style on new code. I can take a look on how > easy to do that. > > Thanks, > > Lina > > On Fri, Jul 7, 2017 at 9:50 AM, Alexander Kolbasov > wrote: > > > Hello, > > > > What w

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

isn't correct, please verify. - Alexander Kolbasov On July 6, 2017, 3:44 p.m., kalyan kumar kalvagadda wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Code style and checkstyle

Hello, What would people thing about enforcing code style for Apache Sentry code? There is a maven/IntelliJ plugin - checkstyle ( http://checkstyle.sourceforge.net/index.html) that can help enforcing the style. The problem is that the current code isn't compliant and fails a lot of checks and it

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

> On July 6, 2017, 5:06 p.m., Alexander Kolbasov wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java > > Line 136 (original), 136 (patched) > > <https://reviews.apache.org/r/60518/diff/5/?file=17

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

<https://reviews.apache.org/r/60518/#comment254674> Why not call getMaxPersistedIDCore() directly? - Alexander Kolbasov On July 6, 2017, 5:01 p.m., Sergio Pena wrote: > > --- > This is an

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

518/#comment254639> This is public member of public class - why do you need @VisibleForTesting here? - Alexander Kolbasov On July 6, 2017, 5:01 p.m., Sergio Pena wrote: > > --- > This is an automatically gen

Re: Review Request 60518: SENTRY-1815: Send new HMS snapshots to HDFS requesting an old generation ID

rvice/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java Line 72 (original), 89 (patched) <https://reviews.apache.org/r/60518/#comment254634> Add info-level log here - it is important to know where we get full updates. Before, when list of deltas was empty we were re

Re: Review Request 60502: SENTRY-1817: Deprecate SENTRY_HA_ENABLED and all tests that use it

are fixed. - Alexander Kolbasov On June 30, 2017, 8:37 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Solr AuthorizationPlugin support?

Are there any Solr people here who can comment? Should we ping someone from Solr? On Fri, Jun 30, 2017 at 9:36 AM, Colm O hEigeartaigh wrote: > As a corollary of this question, I don't believe the Sentry Solr code will > work with any version of Solr post 4.10.x. As Solr is currently on 6.6.0, I

Re: Kafka privileges with the Sentry service

(we also need to handle the "Generic" case in that example). > If we're doing this for 1.8.0 it needs to be documented in the release > notes as older configuration wouldn't work anymore. > > Colm. > > On Thu, Jun 29, 2017 at 6:12 PM, Alexander Kolbasov > wrote

Re: Review Request 60502: SENTRY-1817: Deprecate SENTRY_HA_ENABLED and all tests that use it

-tests-hive/src/test/java/org/apache/sentry/tests/e2e/minisentry/InternalSentrySrv.java Line 116 (original), 116 (patched) <https://reviews.apache.org/r/60502/#comment253971> This should go away - Alexander Kolbasov On June 28, 2017, 3:19 p.m., Na Li wrote: > > -

Re: Review Request 60517: SENTRY-1824: SentryStore may serialize transactions that rely on unique key

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60517/#review179308 --- Ship it! Ship It! - Alexander Kolbasov On June 29, 2017, 8

Re: Kafka privileges with the Sentry service

, Jun 29, 2017 at 5:13 PM, Na Li wrote: > > > Flexibility means when you make different choices, it works, but has > > different behavior. > > When you make the wrong choice, and it breaks, it is not flexibility, it > > is a trap. > > > > Should we cre

Re: Review Request 60517: SENTRY-1824: SentryStore may serialize transactions that rely on unique key

/sentry/provider/db/service/persistent/SentryStore.java Lines 103 (patched) <https://reviews.apache.org/r/60517/#comment253924> Since you are explaining the issue here, you may just refer to SENTRY-1824 for more details. Please use HTML formatting for javadoc. - Alexander Kolbaso

Re: Review Request 60499: SENTRY-1823 - Fix the sentryShell script to support other types

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60499/#review179271 --- Ship it! Ship It! - Alexander Kolbasov On June 29, 2017, 10

Re: Kafka privileges with the Sentry service

ything other than Hive? > > Colm. > > On Wed, Jun 28, 2017 at 8:24 PM, Alexander Kolbasov > wrote: > >> This is weird, Hive and Generic privileges are separated at the Thrift >> level so Kafka should send different Thrift calls which should return >> different results

Re: Review Request 60490: SENTRY-1820: Add JSON file reporter for Sentry metrics

if CM doesn't read the file within the interval then are > the metrics lost during this time? > > Alexander Kolbasov wrote: > It writes a new content every time The metrics are cumulative. CM reads some snapshot. The

Re: Review Request 60490: SENTRY-1820: Add JSON file reporter for Sentry metrics

r --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60490/#review179213 ------- On June 29, 2017, 12:34 a.m., Alexander Kolbasov wrote: >

Re: Review Request 60517: SENTRY-1824: SentryStore may serialize transactions that rely on unique key

. - Alexander Kolbasov On June 28, 2017, 9:03 p.m., Na Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 60490: SENTRY-1820: Add JSON file reporter for Sentry metrics

://reviews.apache.org/r/60490/diff/1-2/ Testing --- Thanks, Alexander Kolbasov

Re: Review Request 60490: SENTRY-1820: Add JSON file reporter for Sentry metrics

ps://reviews.apache.org/r/60490/#review179166 ------- On June 28, 2017, 5:56 a.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 60490: SENTRY-1820: Add JSON file reporter for Sentry metrics

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60490/#review179168 ------- On June 28, 2017, 5:56 a.m., Alexander Kolbasov wrote: > > --

Re: Kafka privileges with the Sentry service

This is weird, Hive and Generic privileges are separated at the Thrift level so Kafka should send different Thrift calls which should return different results. This can be a bug though. Doesn't look like some that comes from configuration. On Wed, Jun 28, 2017 at 4:19 AM, Colm O hEigeartaigh wrot

Re: Review Request 60499: SENTRY-1823 - Fix the sentryShell script to support other types

tps://reviews.apache.org/r/60499/#comment253700> Why not use getopt instead? bin/sentryShell Line 61 (original), 61 (patched) <https://reviews.apache.org/r/60499/#comment253699> Even better, we should just ignore the case, require lower case in command and use case statement.

Re: Review Request 60499: SENTRY-1823 - Fix the sentryShell script to support other types

(patched) <https://reviews.apache.org/r/60499/#comment253697> That's a rather ugly way to achieve this. We can just convert everything to lower case with something like echo $2 | tr A-Z a-z or perhaps use some neat bash trick for that. - Alexander Kolbasov On June 28, 2017, 11:15

Re: Optimizing Sentry to HDFS protocol

memory-efficient.In your stack overflow article it talks about benefits of Thrift over HTTP. Here we are talking about internal representation, while keeping Thrift transpor Thanks, Lina Sent from my iPhone On Jun 27, 2017, at 5:44 PM, Alexander Kolbasov wrote: Some food for thought. Cu

Review Request 60505: SENTRY-1821: Transactions could fail to commit to the database under load

/diff/1/ Testing --- Thanks, Alexander Kolbasov

Review Request 60490: SENTRY-1820: Add JSON file reporter for Sentry metrics

, Alexander Kolbasov

Re: Optimizing Sentry to HDFS protocol

tps://stackoverflow.com/questions/9732381/why-thrift-why-not-http-rpcjsongzip, > Thrift has several benefits. Because these structures are not memory-efficient.In your stack overflow article it talks about benefits of Thrift over HTTP. Here we are talking about internal representa

Optimizing Sentry to HDFS protocol

Some food for thought. Currently Sentry uses serialized Thrift structures to send a lot of information from the Sentry Server to the HDFS namenode plugin for the HDFS sync. We should think of ways to optimize this protocol in several ways: - Rather then streaming huge snapshots in a single m

Re: Sentry interactive CLI

be in 1.8.0? > > Colm. > > On Fri, Jun 23, 2017 at 6:27 PM, Alexander Kolbasov > wrote: > > > Here is another doc about Cliche from the original developer: > > > > https://www.codeproject.com/Articles/55088/Create-Minimal- > > UI-in-No-Time-at-all-Us

Re: Review Request 60469: SENTRY-1814 Provide unit test for LeaderStatusMonitor

t; > > > Is this value too large? If the code has problem, the test will wait > > 500 * 1000, which is 500 seconds, before end. > > Alexander Kolbasov wrote: > What do you think is the reasonable value? > > Na Li wrote: > The zookeeper server is local, so

Re: Review Request 60469: SENTRY-1814 Provide unit test for LeaderStatusMonitor

ally generated e-mail. To reply, visit: https://reviews.apache.org/r/60469/#review179002 ------- On June 27, 2017, 4:57 p.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated

Re: Review Request 60469: SENTRY-1814 Provide unit test for LeaderStatusMonitor

eviews.apache.org/r/60469/#review178998 --- On June 27, 2017, 4:57 p.m., Alexander Kolbasov wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 60469: SENTRY-1814 Provide unit test for LeaderStatusMonitor

/TestLeaderStatusMonitor.java PRE-CREATION Diff: https://reviews.apache.org/r/60469/diff/2/ Changes: https://reviews.apache.org/r/60469/diff/1-2/ Testing --- Thanks, Alexander Kolbasov

Review Request 60469: SENTRY-1814 Provide unit test for LeaderStatusMonitor

, Alexander Kolbasov

Re: Review Request 59720: SENTRY-1781: Persist new HMS snapshots with a new generation ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59720/#review178986 --- Ship it! Ship It! - Alexander Kolbasov On June 27, 2017, 3

Old sentry HA tests

We have some old infrastructure for testing HA servers which is based on the old design where clients find servers using Zookeeper. This no longer works, but we have some e2e tests that somehow attempt to test it and even mysteriously pass. For the sentry-ha-redesign branch we have two options:

Re: Review Request 59720: SENTRY-1781: Persist new HMS snapshots with a new generation ID.

rc/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 2584 (original), 2607 (patched) <https://reviews.apache.org/r/59720/#comment253334> This should just go away - Alexander Kolbasov On June 25, 2017,

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

iews.apache.org/r/59508/#comment253310> What is this function doing? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SnapshotCreationException.java Lines 17 (patched) <https://reviews.apache.org/r/59508/#comment253285> I don't think this e

Re: Question about incrementing IDs for delta changes

s to take for this issue. > > >identity-type="application" detachable="true"> > > value-strategy="increment" key-cache-size="1"> > > > > > > > > > Thanks, > > > Lina

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

> On June 21, 2017, 10:13 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSClientWrapper.java > > Lines 92 (patched) > > <https://reviews.apache.org/r/59508/diff/4/?file=1754606#file1754606line9

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

> On June 22, 2017, 8:02 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java > > Lines 276 (patched) > > <https://reviews.apache.org/r/59508/diff/4/?file=1754610#file1754610lin

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

> On June 21, 2017, 11:05 p.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java > > Line 43 (original), 68 (patched) > > <https://reviews.apache.org/r/59508/diff/4/?file=1

Re: Sentry interactive CLI

is > fine, just make sure that we update our NOTICE and LICENSE file > accordingly, and make sure the MIT license is shipped with the > distribution. > > Colm. > > On Fri, Jun 23, 2017 at 12:27 AM, Alexander Kolbasov > wrote: > > > We had this discussion a while a

Re: Sentry interactive CLI

our NOTICE and LICENSE file > accordingly, and make sure the MIT license is shipped with the > distribution. > > Colm. > > On Fri, Jun 23, 2017 at 12:27 AM, Alexander Kolbasov > wrote: > > > We had this discussion a while ago, I'd like to being it back on the

Re: Review Request 60373: SENTRY-1811: reduce memory consumed by data structures used in HDFS sync

73/#comment253010> Use isEmpty() instead of size() != 0 - Alexander Kolbasov On June 22, 2017, 11:29 p.m., Misha Dmitriev wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Sentry interactive CLI

We had this discussion a while ago, I'd like to being it back on the table. I implemented a simple Sentry interactive CLI that is based on Cliche library (https://github.com/budhash/cliche). The library is available under MIT license - I guess it shouldn't be a problem. I opened SENTRY-1812 to t

Re: Version of ha branch

I would suggest renaming Sentry HA to 2.0.0-SNAPSHOT I would also suggest to rename sentry-ha-redesign branch to 2.0 branch. We also should start thinking about opening 1.8 branch and moving current sentry HA to master. - Alex On Thu, Jun 22, 2017 at 3:06 AM, Colm O hEigeartaigh wrote: > Hi a

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

try-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java Lines 293 (patched) <https://reviews.apache.org/r/59508/#comment252793> use {} formatting instead of string operations - Alexander Kolbasov On Ju

Re: Review Request 60091: SENTRY-1798: Changed thread naming patterns using guava ThreadFactoryBuilder.

to shut it down later sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Line 413 (original), 418 (patched) <https://reviews.apache.org/r/60091/#comment252782> Use explicit size for the new array - Alexander Kolbasov On June 21, 2017,

Re: Review Request 60091: SENTRY-1798: Changed thread naming patterns using guava ThreadFactoryBuilder.

es 49 (patched) <https://reviews.apache.org/r/60091/#comment252682> I think this line has a trailing whitespace. Is there a value in duplicating @deprecated info? - Alexander Kolbasov On June 21, 2017, 2:53 p.m., Brian Towl

Re: Review Request 59508: SENTRY-1769 Refactor HMSFollower Class

This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59508/ > --- > > (Updated June 20, 2017, 4:11 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, Na Li, > Sergio Pena, Vamsee Yarlagadda, and Va

<    1   2   3   4   5   6   7   8   9   10   >