[jira] [Comment Edited] (SQOOP-2728) Sqoop2: Add documentation regarding the need for -Doracle.jdbc.J2EE13Compliant=true when using oracle

2015-12-10 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051508#comment-15051508 ] Abraham Fine edited comment on SQOOP-2728 at 12/10/15 7:33 PM: --- so you can

[jira] [Commented] (SQOOP-2728) Sqoop2: Add documentation regarding the need for -Doracle.jdbc.J2EE13Compliant=true when using oracle

2015-12-10 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051508#comment-15051508 ] Abraham Fine commented on SQOOP-2728: - so you can find some documentation about this property here:

[jira] [Updated] (SQOOP-2634) Sqoop2: Provide classpath isolation for connectors and its dependencies

2015-12-10 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated SQOOP-2634: --- Description: The aim of this JIRA is to provide classpath isolation for connectors and its dependencies.

Review Request 41197: Sqoop2: Improve ConnectorClassLoader to support loading classes from the dependencies inside the connector jar

2015-12-10 Thread Dian Fu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41197/ --- Review request for Sqoop. Bugs: SQOOP-2635

Re: Review Request 39586: Sqoop2: Provide classpath isolation for connectors and its dependencies

2015-12-10 Thread Dian Fu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39586/ --- (Updated Dec. 10, 2015, 9:50 a.m.) Review request for Sqoop. Bugs:

Re: Review Request 39586: Sqoop2: Provide classpath isolation for connectors and its dependencies

2015-12-10 Thread Dian Fu
> On Dec. 5, 2015, 12:35 p.m., Jarek Cecho wrote: > > My apologies for jumping so late on this review. Few high level notes: > > > > 1) It seems that the patch no longer applies cleanly, so you will have to > > rebase it. > > > > 2) I know that we've changed the design quite a bit - would you

Re: Review Request 39586: Sqoop2: Allow connectors to express jar dependencies

2015-12-10 Thread Dian Fu
> On Dec. 5, 2015, 12:35 p.m., Jarek Cecho wrote: > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteFromInitializer.java, > > lines 71-81 > > > > > > Aren't those dependecies on inside

[jira] [Updated] (SQOOP-2634) Sqoop2: Provide classpath isolation for connectors and its dependencies

2015-12-10 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated SQOOP-2634: --- Attachment: SQOOP-2634.013.patch > Sqoop2: Provide classpath isolation for connectors and its dependencies >

Re: Review Request 39586: Sqoop2: Provide classpath isolation for connectors and its dependencies

2015-12-10 Thread Dian Fu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39586/ --- (Updated Dec. 10, 2015, 9:55 a.m.) Review request for Sqoop. Bugs:

[jira] [Updated] (SQOOP-2635) Sqoop2: Improve ConnectorClassLoader to support loading classes from the dependencies inside the connector jar

2015-12-10 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated SQOOP-2635: --- Description: As discussed in SQOOP-2634, we need to improve ConnectorClassLoader to support loading classes

[jira] [Updated] (SQOOP-2634) Sqoop2: Allow connectors to express jar dependencies

2015-12-10 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated SQOOP-2634: --- Attachment: SQOOP-2634.012.patch > Sqoop2: Allow connectors to express jar dependencies >

[jira] [Commented] (SQOOP-2717) Sqoop2: Use connector name in shell

2015-12-10 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050317#comment-15050317 ] Sqoop QA bot commented on SQOOP-2717: - Testing file

[jira] [Updated] (SQOOP-2635) Sqoop2: Improve ConnectorClassLoader to support loading classes from the dependencies inside the connector jar

2015-12-10 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated SQOOP-2635: --- Attachment: SQOOP-2635.001.patch > Sqoop2: Improve ConnectorClassLoader to support loading classes from the

Re: Review Request 39586: Sqoop2: Provide classpath isolation for connectors and its dependencies

2015-12-10 Thread Dian Fu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39586/ --- (Updated Dec. 10, 2015, 9:45 a.m.) Review request for Sqoop. Summary

[jira] [Commented] (SQOOP-2732) Sqoop2: Integration Tests: For Oracle compatibility use decimal instead of numeric sql type

2015-12-10 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051640#comment-15051640 ] Jarek Jarcec Cecho commented on SQOOP-2732: --- +1 > Sqoop2: Integration Tests: For Oracle

[jira] [Commented] (SQOOP-2732) Sqoop2: Integration Tests: For Oracle compatibility use decimal instead of numeric sql type

2015-12-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051756#comment-15051756 ] Hudson commented on SQOOP-2732: --- SUCCESS: Integrated in Sqoop2 #967 (See

Re: Review Request 40896: SQOOP-2719

2015-12-10 Thread Abraham Fine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40896/ --- (Updated Dec. 10, 2015, 9:03 p.m.) Review request for Sqoop. Bugs:

[jira] [Commented] (SQOOP-2732) Sqoop2: Integration Tests: For Oracle compatibility use decimal instead of numeric sql type

2015-12-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051641#comment-15051641 ] ASF subversion and git services commented on SQOOP-2732: Commit

Re: Review Request 40896: SQOOP-2719

2015-12-10 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40896/#review109853 --- Thanks for the patch Abe, appreciated! Few notes:

Re: Review Request 41081: Oracle connector not working with lowercase columns

2015-12-10 Thread David Robson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41081/#review109897 --- Ship it! Ship It! - David Robson On Dec. 8, 2015, 7:30 a.m.,

[jira] [Assigned] (SQOOP-2736) Sqoop2: Document change command line shell interface

2015-12-10 Thread Colin Ma (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Ma reassigned SQOOP-2736: --- Assignee: Colin Ma > Sqoop2: Document change command line shell interface >

[jira] [Commented] (SQOOP-2737) Cannot import table from Oracle with column with spaces in name

2015-12-10 Thread David Robson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051886#comment-15051886 ] David Robson commented on SQOOP-2737: - Can you please try the patch for

[jira] [Commented] (SQOOP-2635) Sqoop2: Improve ConnectorClassLoader to support loading classes from the dependencies inside the connector jar

2015-12-10 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050566#comment-15050566 ] Sqoop QA bot commented on SQOOP-2635: - Testing file

Re: Review Request 41196: SQOOP-2717: Sqoop2: Use connector name in shell

2015-12-10 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41196/#review109741 --- Ship it! Ship It! - Jarek Cecho On Dec. 10, 2015, 7:10 a.m.,

[jira] [Commented] (SQOOP-2717) Sqoop2: Use connector name in shell

2015-12-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050630#comment-15050630 ] ASF subversion and git services commented on SQOOP-2717: Commit

[jira] [Commented] (SQOOP-2733) Sqoop2: Integration Tests: Clean up mapreduce directory for IncrementalReadTest

2015-12-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050644#comment-15050644 ] Hudson commented on SQOOP-2733: --- SUCCESS: Integrated in Sqoop2 #965 (See

[jira] [Commented] (SQOOP-2731) Sqoop2: DisabledObjectsTest creates table that is too long for oracle

2015-12-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050643#comment-15050643 ] Hudson commented on SQOOP-2731: --- SUCCESS: Integrated in Sqoop2 #965 (See

[jira] [Commented] (SQOOP-2727) Sqoop2: Use PreparedStatements for constructing GenericJDBCPartitions

2015-12-10 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050653#comment-15050653 ] Sqoop QA bot commented on SQOOP-2727: - Testing file

[jira] [Commented] (SQOOP-2733) Sqoop2: Integration Tests: Clean up mapreduce directory for IncrementalReadTest

2015-12-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050572#comment-15050572 ] ASF subversion and git services commented on SQOOP-2733: Commit

[jira] [Commented] (SQOOP-2733) Sqoop2: Integration Tests: Clean up mapreduce directory for IncrementalReadTest

2015-12-10 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050570#comment-15050570 ] Jarek Jarcec Cecho commented on SQOOP-2733: --- +1 > Sqoop2: Integration Tests: Clean up mapreduce

[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL

2015-12-10 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050605#comment-15050605 ] Jarek Jarcec Cecho commented on SQOOP-2726: --- Looks good to me, I'll commit it once SQOOP-2727

[jira] [Commented] (SQOOP-2732) Sqoop2: Integration Tests: For Oracle compatibility use decimal instead of numeric sql type

2015-12-10 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050646#comment-15050646 ] Sqoop QA bot commented on SQOOP-2732: - Testing file

[jira] [Commented] (SQOOP-2725) Sqoop2: Integration Tests: Prefer using Timestamp types and PreparedStatements for inserting rows into test databases

2015-12-10 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050902#comment-15050902 ] Sqoop QA bot commented on SQOOP-2725: - Testing file

[jira] [Commented] (SQOOP-2731) Sqoop2: DisabledObjectsTest creates table that is too long for oracle

2015-12-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050583#comment-15050583 ] ASF subversion and git services commented on SQOOP-2731: Commit

[jira] [Commented] (SQOOP-2732) Sqoop2: Integration Tests: For Oracle compatibility use decimal instead of numeric sql type

2015-12-10 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050581#comment-15050581 ] Jarek Jarcec Cecho commented on SQOOP-2732: --- The error in pre-commit hook is: {code}

Re: Review Request 41197: Sqoop2: Improve ConnectorClassLoader to support loading classes from the dependencies inside the connector jar

2015-12-10 Thread Dian Fu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41197/ --- (Updated Dec. 10, 2015, 11:48 a.m.) Review request for Sqoop. Bugs:

[jira] [Updated] (SQOOP-2635) Sqoop2: Improve ConnectorClassLoader to support loading classes from the dependencies inside the connector jar

2015-12-10 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated SQOOP-2635: --- Attachment: SQOOP-2635.002.patch Fixed the license check error and findbugs warnings. > Sqoop2: Improve

[jira] [Updated] (SQOOP-2733) Sqoop2: Integration Tests: Clean up mapreduce directory for IncrementalReadTest

2015-12-10 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-2733: -- Fix Version/s: 1.99.7 > Sqoop2: Integration Tests: Clean up mapreduce directory for >

Re: Review Request 41180: SQOOP-2727

2015-12-10 Thread Jarek Cecho
> On Dec. 10, 2015, 11:09 a.m., Jarek Cecho wrote: > > Overall looks good to me. I have couple of comments inline. It seems that > > there is findbugs warning and test coverage decrease significantly - > > perhaps we should improve unit test coverage for the new code? I've also rerun the

Re: Review Request 41180: SQOOP-2727

2015-12-10 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41180/#review109736 --- Overall looks good to me. I have couple of comments inline. It

[jira] [Created] (SQOOP-2736) Sqoop2: Document change command line shell interface

2015-12-10 Thread Jarek Jarcec Cecho (JIRA)
Jarek Jarcec Cecho created SQOOP-2736: - Summary: Sqoop2: Document change command line shell interface Key: SQOOP-2736 URL: https://issues.apache.org/jira/browse/SQOOP-2736 Project: Sqoop

[jira] [Commented] (SQOOP-2635) Sqoop2: Improve ConnectorClassLoader to support loading classes from the dependencies inside the connector jar

2015-12-10 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050951#comment-15050951 ] Sqoop QA bot commented on SQOOP-2635: - Testing file

[jira] [Commented] (SQOOP-2717) Sqoop2: Use connector name in shell

2015-12-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050923#comment-15050923 ] Hudson commented on SQOOP-2717: --- SUCCESS: Integrated in Sqoop2 #966 (See

Re: Review Request 40635: Sqoop2: Add kerberos support for SqoopMiniCluster

2015-12-10 Thread Dian Fu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40635/ --- (Updated Dec. 11, 2015, 7:30 a.m.) Review request for Sqoop. Bugs:

[jira] [Updated] (SQOOP-2705) Sqoop2: Add kerberos support for SqoopMiniCluster

2015-12-10 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated SQOOP-2705: --- Attachment: SQOOP-2705.011.patch > Sqoop2: Add kerberos support for SqoopMiniCluster >

Re: Review Request 40635: Sqoop2: Add kerberos support for SqoopMiniCluster

2015-12-10 Thread Dian Fu
> On Dec. 7, 2015, 2:41 p.m., Jarek Cecho wrote: > > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java, > > lines 211-212 > > > > > > This is just temporary right? I'm assuming that in

[jira] [Commented] (SQOOP-2692) Sqoop2: Use link name in shell

2015-12-10 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052349#comment-15052349 ] Sqoop QA bot commented on SQOOP-2692: - Testing file

Review Request 41249: SQOOP-2692: Sqoop2: Use link name in shell

2015-12-10 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41249/ --- Review request for Sqoop. Repository: sqoop-sqoop2 Description ---

[jira] [Commented] (SQOOP-2734) Sqoop2: Use job name in shell

2015-12-10 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052184#comment-15052184 ] Sqoop QA bot commented on SQOOP-2734: - Testing file

[jira] [Updated] (SQOOP-2642) Document ability to specify commas in --map-column-hive option

2015-12-10 Thread Ze Jin (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ze Jin updated SQOOP-2642: -- Attachment: SQOOP-2642..patch > Document ability to specify commas in --map-column-hive option >

[jira] [Commented] (SQOOP-2734) Sqoop2: Use job name in shell

2015-12-10 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052183#comment-15052183 ] Sqoop QA bot commented on SQOOP-2734: - Testing file

[jira] [Commented] (SQOOP-2734) Sqoop2: Use job name in shell

2015-12-10 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052240#comment-15052240 ] Sqoop QA bot commented on SQOOP-2734: - Testing file

[jira] [Commented] (SQOOP-2642) Document ability to specify commas in --map-column-hive option

2015-12-10 Thread Ze Jin (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052241#comment-15052241 ] Ze Jin commented on SQOOP-2642: --- I have documented ability to specify commas in --map-column-hive option. I

Review Request 41247: SQOOP-2734: Sqoop2: Use job name in shell

2015-12-10 Thread Colin Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41247/ --- Review request for Sqoop. Repository: sqoop-sqoop2 Description --- Use

[jira] [Updated] (SQOOP-2692) Sqoop2: Use link name in shell

2015-12-10 Thread Colin Ma (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin Ma updated SQOOP-2692: Attachment: SQOOP-2692.001.patch > Sqoop2: Use link name in shell > -- > >

[jira] [Created] (SQOOP-2737) Cannot import table from Oracle with column with spaces in name

2015-12-10 Thread JIRA
Jakub HavlĂ­k created SQOOP-2737: --- Summary: Cannot import table from Oracle with column with spaces in name Key: SQOOP-2737 URL: https://issues.apache.org/jira/browse/SQOOP-2737 Project: Sqoop