[jira] [Commented] (STORM-1098) Storm Nimbus Hook

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994742#comment-14994742 ] ASF GitHub Bot commented on STORM-1098: --- Github user Parth-Brahmbhatt commented on the pull request:

[jira] [Commented] (STORM-1185) Update storm.yaml with HA configuration

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994828#comment-14994828 ] ASF GitHub Bot commented on STORM-1185: --- Github user vesense commented on a diff in the pull

[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...

2015-11-06 Thread vesense
Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/865#discussion_r44204593 --- Diff: conf/storm.yaml.example --- @@ -19,7 +19,7 @@ # - "server1" # - "server2" # -# nimbus.host: "nimbus" +# nimbus.seeds:

[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...

2015-11-06 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/865#discussion_r44204822 --- Diff: conf/storm.yaml.example --- @@ -19,7 +19,7 @@ # - "server1" # - "server2" # -# nimbus.host: "nimbus" +#

[GitHub] storm pull request: STORM-1098: Nimbus hook for topology actions.

2015-11-06 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/862#issuecomment-154580884 Upmerged. I will merge the patch in once someone from Atlas team reviews and confirms this is sufficient for them. --- If your project is set up for it, you

[jira] [Commented] (STORM-1185) Update storm.yaml with HA configuration

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994837#comment-14994837 ] ASF GitHub Bot commented on STORM-1185: --- Github user Parth-Brahmbhatt commented on a diff in the

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

2015-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/743 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1052) TridentKafkaState uses new Kafka Producer API

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994888#comment-14994888 ] ASF GitHub Bot commented on STORM-1052: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-1129: Use topology name instead of id in...

2015-11-06 Thread wuchong
Github user wuchong commented on the pull request: https://github.com/apache/storm/pull/854#issuecomment-154403920 +1 In Alibaba, we implement our monitor system using topology name instead of id. And it is very useful , as users often resubmit topology several times , and

[jira] [Commented] (STORM-1129) Storm should use topology name instead of ids for url in storm UI.

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993622#comment-14993622 ] ASF GitHub Bot commented on STORM-1129: --- Github user wuchong commented on the pull request:

[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/865#issuecomment-154420118 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-1006) Storm is not garbage collecting the messages (causing memory hit)

2015-11-06 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993534#comment-14993534 ] Jark Wu commented on STORM-1006: `CoordinatedBolt` is used to detect when a given bolt has received all of

[jira] [Commented] (STORM-1167) Add sliding & tumbling window support for core storm

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993718#comment-14993718 ] ASF GitHub Bot commented on STORM-1167: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1185) Update storm.yaml with HA configuration

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993727#comment-14993727 ] ASF GitHub Bot commented on STORM-1185: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1153 Use static final instead of just st...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/837#issuecomment-154500817 +1 the changes look good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (STORM-1153) Use static final instead of just static for class members

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994240#comment-14994240 ] ASF GitHub Bot commented on STORM-1153: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1153 Use static final instead of just st...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/837#issuecomment-154503694 @harshach I just noticed that this has already been merged in, but the JIRA was not closed and this pull request was also not closed, there also was no vote on it.

[GitHub] storm pull request: STORM-1153 Use static final instead of just st...

2015-11-06 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/837#issuecomment-154504341 @revans2 Sorry. I thought I already gave my +1 on this. Not sure why the PR isn't closed. retroactive +1 on this. --- If your project is set up for it, you can reply

[jira] [Commented] (STORM-1153) Use static final instead of just static for class members

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994245#comment-14994245 ] ASF GitHub Bot commented on STORM-1153: --- Github user harshach commented on the pull request:

[jira] [Resolved] (STORM-1153) Use static final instead of just static for class members

2015-11-06 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani resolved STORM-1153. --- Resolution: Fixed > Use static final instead of just static for class members

[GitHub] storm pull request: STORM-1153 Use static final instead of just st...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/837#issuecomment-154505031 @harshach I am not concerned about it. The change is good and I assumed you had giving it a +1 just simply by checking it in. I just wanted to be sure things got

[jira] [Commented] (STORM-1153) Use static final instead of just static for class members

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994249#comment-14994249 ] ASF GitHub Bot commented on STORM-1153: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1180: FLUX logo wasn't appearing quite r...

2015-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1180) FLUX logo wasn't appearing quite right

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994270#comment-14994270 ] ASF GitHub Bot commented on STORM-1180: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (STORM-1180) FLUX logo wasn't appearing quite right

2015-11-06 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1180. Resolution: Fixed Fix Version/s: 0.11.0 [~ashnazg], Thanks for the patch I

[jira] [Commented] (STORM-1153) Use static final instead of just static for class members

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994213#comment-14994213 ] ASF GitHub Bot commented on STORM-1153: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1179) Create Maven Profiles for Integration Tests

2015-11-06 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994225#comment-14994225 ] Robert Joseph Evans commented on STORM-1179: Sounds good, I am not hung up on the name though.

[jira] [Issue Comment Deleted] (STORM-921) Create unit tests for worker-worker netty authentication.

2015-11-06 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-921: --- Comment: was deleted (was: Code is pulled in together with load-aware shuffle at:

[jira] [Resolved] (STORM-921) Create unit tests for worker-worker netty authentication.

2015-11-06 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu resolved STORM-921. Resolution: Fixed Code is pulled in together with load-aware shuffle at:

[jira] [Commented] (STORM-1153) Use static final instead of just static for class members

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994246#comment-14994246 ] ASF GitHub Bot commented on STORM-1153: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1153 Use static final instead of just st...

2015-11-06 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/837#issuecomment-154504538 @sureshms can you please close the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (STORM-1156) Link Developer.md doc to the contributing page

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994259#comment-14994259 ] ASF GitHub Bot commented on STORM-1156: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1156. Link Developer.md doc to the contr...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/867#issuecomment-154506906 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Updated] (STORM-1180) FLUX logo wasn't appearing quite right

2015-11-06 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans updated STORM-1180: --- Assignee: Chuck Burgess > FLUX logo wasn't appearing quite right >

[jira] [Commented] (STORM-1126) Allow a configMethod that takes no arguments (Flux)

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994277#comment-14994277 ] ASF GitHub Bot commented on STORM-1126: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1126: allow for configMethods with no ar...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/833#issuecomment-154509466 This looks good to me I am +1, but I would like to have someone more familiar with Flux take a look too. @ptgoetz can you take a look or point out someone who

[jira] [Commented] (STORM-1127) Allow a Boolean value in a constructorArgs list (Flux)

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994289#comment-14994289 ] ASF GitHub Bot commented on STORM-1127: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1127: allow for boolean arguments (Flux)

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/832#issuecomment-154510125 To me the code looks good. +1, but I would like someone more familiar with Flux to also take a look. @ptgoetz can you take a look, or point out someone who

Re: [Discusson] Storm System Tests

2015-11-06 Thread Paul Poulosky
I would like to work on this as well.  We have some integration tests at Yahoo that we run regularly, but also depend on an internal testing framework, and also depend on internal deployment scripts, etc. It would be good to get a set of true integration tests set up that can run in community. 

Re: [Discusson] Storm System Tests

2015-11-06 Thread Bobby Evans
Yes we too have similar tests based on internal Yahoo testing.  Really it comes down to a few operations that the test framework needs to be able to do 1) node/VM allocation 2) deployment 3) modify configuration/processes on running nodes 4) run actual tests. The first three are often specific

[jira] [Commented] (STORM-1179) Create Maven Profiles for Integration Tests

2015-11-06 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993804#comment-14993804 ] Robert Joseph Evans commented on STORM-1179: Perhaps we need to define better what types of

[GitHub] storm pull request: STORM-1098: Nimbus hook for topology actions.

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/862#issuecomment-154437228 The code looks fine to me +1. The CI failures look to be unrelated. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: STORM-1155: Supervisor recurring health checks

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/849#issuecomment-154437494 @longdafeng do you have any more comments on this pull request? I would like to merge this in soon if you are OK with it. --- If your project is set up for it, you can

[GitHub] storm pull request: STORM-1183: bump timeout to 10s, since test ca...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/864#issuecomment-154438396 @ashnazg I think we fixed the failure in https://github.com/apache/storm/pull/859 Could you please check and see if it worked for you? --- If your project is set up

[jira] [Commented] (STORM-1182) Removing and wrapping some exceptions in ConfigValidation

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993814#comment-14993814 ] ASF GitHub Bot commented on STORM-1182: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1183) Intermittent testInOrder failures seen in Travis builds

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993812#comment-14993812 ] ASF GitHub Bot commented on STORM-1183: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1182] - Removing and wrapping some exce...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/863#issuecomment-154438627 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/846#issuecomment-154439175 Still +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1161) Several source files lack an Apache License

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993816#comment-14993816 ] ASF GitHub Bot commented on STORM-1161: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1098: Nimbus hook for topology actions.

2015-11-06 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/862#discussion_r44148739 --- Diff: storm-core/src/jvm/backtype/storm/nimbus/ITopologyActionNotifierPlugin.java --- @@ -0,0 +1,25 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: STORM-1098: Nimbus hook for topology actions.

2015-11-06 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/862#discussion_r44148807 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -124,6 +124,8 @@ :id->sched-status (atom {}) :cred-renewers

[jira] [Commented] (STORM-1098) Storm Nimbus Hook

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993817#comment-14993817 ] ASF GitHub Bot commented on STORM-1098: --- Github user harshach commented on a diff in the pull

[jira] [Commented] (STORM-1098) Storm Nimbus Hook

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993820#comment-14993820 ] ASF GitHub Bot commented on STORM-1098: --- Github user harshach commented on a diff in the pull

[GitHub] storm pull request: STORM-1098: Nimbus hook for topology actions.

2015-11-06 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/862#discussion_r44148868 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -814,6 +816,11 @@ (.assignSlots inimbus topologies)))

[jira] [Commented] (STORM-1098) Storm Nimbus Hook

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993819#comment-14993819 ] ASF GitHub Bot commented on STORM-1098: --- Github user harshach commented on a diff in the pull

[GitHub] storm pull request: STORM-1161: Add License headers and add rat ch...

2015-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/846 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (STORM-1161) Several source files lack an Apache License

2015-11-06 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1161. Resolution: Fixed Fix Version/s: 0.11.0 Thanks [~dossett], I merged this

Re: JStorm Code Import

2015-11-06 Thread Bobby Evans
Great to hear it, now we need to come up with a plan/process for integrating the two. Taylor if you need/want any help with that plan please feel free to reach out to me. - Bobby On Thursday, November 5, 2015 3:47 PM, P. Taylor Goetz wrote: The JStorm code

[GitHub] storm pull request: STORM-1180: FLUX logo wasn't appearing quite r...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/834#issuecomment-154445254 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-1180) FLUX logo wasn't appearing quite right

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993840#comment-14993840 ] ASF GitHub Bot commented on STORM-1180: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1161) Several source files lack an Apache License

2015-11-06 Thread Aaron Dossett (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993855#comment-14993855 ] Aaron Dossett commented on STORM-1161: -- Thank you, [~revans2]! We are doing great things with Storm

[jira] [Commented] (STORM-1167) Add sliding & tumbling window support for core storm

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993863#comment-14993863 ] ASF GitHub Bot commented on STORM-1167: --- Github user harshach commented on the pull request:

[GitHub] storm pull request: STORM-1167: Add windowing support for storm co...

2015-11-06 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/855#issuecomment-154448320 @arunmahadevan @Parth-Brahmbhatt @revans2 still going through the code, give me a day i'll put my comments in. Thanks. --- If your project is set up for it, you can

[jira] [Commented] (STORM-1185) Update storm.yaml with HA configuration

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993888#comment-14993888 ] ASF GitHub Bot commented on STORM-1185: --- Github user zhuoliu commented on the pull request:

[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...

2015-11-06 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/865#issuecomment-154458498 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-1052] TridentKafkaState uses new Kafka ...

2015-11-06 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/743#issuecomment-154461421 Hi @vesense The DisruptorQueue test bug has been fixed in another JIRA. Could you upmerge and trigger the CI again? This pull request looks good to me, I am +1 to merge

[jira] [Commented] (STORM-1052) TridentKafkaState uses new Kafka Producer API

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993904#comment-14993904 ] ASF GitHub Bot commented on STORM-1052: --- Github user zhuoliu commented on the pull request:

[GitHub] storm pull request: [STORM-902] Simple Log Search

2015-11-06 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/848#issuecomment-154464027 Hi @Parth-Brahmbhatt, could I have you some time to check back the fixes? Appreciate that. --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: [STORM-902] Simple Log Search

2015-11-06 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on the pull request: https://github.com/apache/storm/pull/848#issuecomment-154464749 @zhuoliu Sorry I did partial review and then got distracted, give me today's day and I will add more comments. --- If your project is set up for it, you can

[jira] [Commented] (STORM-902) Simple Log Search

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993924#comment-14993924 ] ASF GitHub Bot commented on STORM-902: -- Github user Parth-Brahmbhatt commented on the pull request:

[jira] [Commented] (STORM-1179) Create Maven Profiles for Integration Tests

2015-11-06 Thread Hugo Louro (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993926#comment-14993926 ] Hugo Louro commented on STORM-1179: --- +1 on the the tests format proposed by [~revans2] [~revans2], is

[GitHub] storm pull request: STORM-162: Load Aware Shuffle Grouping

2015-11-06 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/847#issuecomment-154466432 LGTM. +1. This is helpful in managing load across multiple instances of component. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (STORM-1158) Storm metrics to profile various storm functions

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993934#comment-14993934 ] ASF GitHub Bot commented on STORM-1158: --- Github user kishorvpatil commented on the pull request:

[GitHub] storm pull request: [STORM-1158] -Storm metrics to profile various...

2015-11-06 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/850#issuecomment-154468111 LGTM. +1. Good bunch.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request: [STORM-902] Simple Log Search

2015-11-06 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/848#issuecomment-154468820 Sure, that would be great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...

2015-11-06 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/865#discussion_r44159502 --- Diff: conf/storm.yaml.example --- @@ -19,7 +19,7 @@ # - "server1" # - "server2" # -# nimbus.host: "nimbus" +#

[jira] [Commented] (STORM-1185) Update storm.yaml with HA configuration

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993946#comment-14993946 ] ASF GitHub Bot commented on STORM-1185: --- Github user jerrypeng commented on a diff in the pull

[jira] [Commented] (STORM-1177) Build fails because DISCLAIMER file is missing

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993957#comment-14993957 ] ASF GitHub Bot commented on STORM-1177: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1167) Add sliding & tumbling window support for core storm

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993965#comment-14993965 ] ASF GitHub Bot commented on STORM-1167: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1167: Add windowing support for storm co...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/855#issuecomment-154471868 @harshach sure I am not in a rush. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: STORM-1183: bump timeout to 10s, since test ca...

2015-11-06 Thread ashnazg
Github user ashnazg commented on the pull request: https://github.com/apache/storm/pull/864#issuecomment-154471802 @revans2 yep, that test is consistently passing in the builds I'm watching. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: [STORM-1177] Build fails because DISCLAIMER fi...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/861#issuecomment-154471753 @schonfeld it looks like this was already done on a different pull request. ``` commit d59eaac77ed65b85f6aa2d8ab56ca99b1075d468 Author: Sriharsha

[jira] [Commented] (STORM-1183) Intermittent testInOrder failures seen in Travis builds

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993962#comment-14993962 ] ASF GitHub Bot commented on STORM-1183: --- Github user ashnazg commented on the pull request:

[jira] [Commented] (STORM-1183) Intermittent testInOrder failures seen in Travis builds

2015-11-06 Thread Chuck Burgess (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993969#comment-14993969 ] Chuck Burgess commented on STORM-1183: -- Deferring to the fix already merged in STORM-1170. >

[jira] [Closed] (STORM-1183) Intermittent testInOrder failures seen in Travis builds

2015-11-06 Thread Chuck Burgess (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Burgess closed STORM-1183. Resolution: Duplicate > Intermittent testInOrder failures seen in Travis builds >

[GitHub] storm pull request: STORM-1161: Adding ratprint.py

2015-11-06 Thread dossett
GitHub user dossett opened a pull request: https://github.com/apache/storm/pull/866 STORM-1161: Adding ratprint.py @revans2 Apologies, but I just realized that my squash for this JIRA dropped one new file. This PR adds it back. You can merge this pull request into a Git

[jira] [Commented] (STORM-1161) Several source files lack an Apache License

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993980#comment-14993980 ] ASF GitHub Bot commented on STORM-1161: --- GitHub user dossett opened a pull request:

[GitHub] storm pull request: STORM-1183: bump timeout to 10s, since test ca...

2015-11-06 Thread ashnazg
Github user ashnazg closed the pull request at: https://github.com/apache/storm/pull/864 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-1156: Link Developer.md doc to the contr...

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/843#issuecomment-154473887 @tgravescs looks like I was confused about how the documentation is working now. Could you update your request to go off of the asf-site branch instead of master? I

[jira] [Commented] (STORM-1156) Link Developer.md doc to the contributing page

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993984#comment-14993984 ] ASF GitHub Bot commented on STORM-1156: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-885) Heartbeat Server (Pacemaker)

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993986#comment-14993986 ] ASF GitHub Bot commented on STORM-885: -- Github user revans2 commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-885] Heartbeat Server (Pacemaker)

2015-11-06 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r44160889 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/KerberosSaslNettyClient.java --- @@ -0,0 +1,212 @@ +/** + * Licensed to the Apache

[jira] [Assigned] (STORM-1183) Intermittent testInOrder failures seen in Travis builds

2015-11-06 Thread Chuck Burgess (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Burgess reassigned STORM-1183: Assignee: Chuck Burgess > Intermittent testInOrder failures seen in Travis builds >

[jira] [Commented] (STORM-1183) Intermittent testInOrder failures seen in Travis builds

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993964#comment-14993964 ] ASF GitHub Bot commented on STORM-1183: --- Github user ashnazg closed the pull request at:

[GitHub] storm pull request: [STORM-885] Heartbeat Server (Pacemaker)

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/838#issuecomment-154474226 @knusbaum could you please rebase your patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-1158] -Storm metrics to profile various...

2015-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/850 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (STORM-1158) Storm metrics to profile various storm functions

2015-11-06 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1158. Resolution: Fixed Fix Version/s: 0.11.0 Thanks [~jerrypeng], I merged this

[jira] [Commented] (STORM-1158) Storm metrics to profile various storm functions

2015-11-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993992#comment-14993992 ] ASF GitHub Bot commented on STORM-1158: --- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-1154: SequenceFileBolt needs unit tests

2015-11-06 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/841#issuecomment-154475321 Still +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-1156: Link Developer.md doc to the contr...

2015-11-06 Thread tgravescs
Github user tgravescs closed the pull request at: https://github.com/apache/storm/pull/843 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

  1   2   >