Github user ppoulosk commented on the issue:
https://github.com/apache/storm/pull/1661
Yes. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user nilday commented on the issue:
https://github.com/apache/storm/pull/1674
@HeartSaVioR not yet, busy with something else. Will do it as soon as I
have some time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1654
@jerrypeng Could you get the chance to review this?
Or could anyone familiar with IsolatedPool review this?
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1582
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1590
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1582
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1680
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1691
Just to be clear, that wasn't a criticism. I just wanted to point out that
it is important that we know the provenance and license of all code that enters
our repository.
---
If your project is
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1695
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1694
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1691
This a fairly large commit that seemingly includes code from other
projects. That's fine as long as you can document what code was copied, and
what the license for that code was.
---
If your
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1669
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1611
@lujinhong Could we close this as #1606 is merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1591
Since Netty made 3.x version line EOL, I'd like to bump Netty to 4.0.x or
even 4.1.x if there's no performance / resource usage issue.
@hsun-cnnxty
Please upmerge this. If you
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1455
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1640
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1700
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1604
@darionyaphet
Since 3.10.6 is EOL of 3.x, I'd rather move on Netty 4.
Patches are already here #728 (master) #1591 (1.x), and when we're OK with
the performance test I think we can check
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1470
@kosii Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1276
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/1691
Thanks @harshach @HeartSaVioR for reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user raghavgautam closed the pull request at:
https://github.com/apache/storm/pull/1691
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1640
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1399
This is resolved via STORM-1993.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/1691
I had mention this on the jira.
A good part of the vagrant setup has been picked up from:
https://github.com/ptgoetz/storm-vagrant
https://github.com/harshach/storm-vagrant
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1296
I think STORM-2016 covers this, so we can close this.
@abhishekagarwal87 What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1590
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1691
I squashed commits before merging
(b779ca4e270f6f2a86d4d30336004e4a642ec690) but forgot to write 'Closes #1691'
to commit log.
@raghavgautam Could you close this? Thanks!
---
If your
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1701
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1706#discussion_r80183483
--- Diff:
external/sql/storm-sql-runtime/src/test/org/apache/storm/sql/TestUtils.java ---
@@ -60,6 +62,25 @@ public static String result(String
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1709
STORM-2116 [Storm SQL] Support 'CASE' statement
NOTE: This patch is on top of STORM-2089 and STORM-2111, and STORM-2113.
```
SELECT CASE WHEN NAME IN ('a', 'abc', 'abcde') THEN
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1706#discussion_r80184767
--- Diff:
external/sql/storm-sql-runtime/src/test/org/apache/storm/sql/TestUtils.java ---
@@ -60,6 +62,25 @@ public static String result(String
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1706#discussion_r80185268
--- Diff:
external/sql/storm-sql-runtime/src/test/org/apache/storm/sql/TestUtils.java ---
@@ -60,6 +62,25 @@ public static String result(String
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1701
+1 Nice finding.
`storm-kafka` CI build fails but looks unrelated.
Btw, IMO this bug is worth to file an issue, since tuple is sent to the
wrong stream or throwing errors or even not
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1680
+1 Nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1676
I'm +1 on this.
@revans2 @ptgoetz Could you review this as well? This is a change of
dependency but removing shaded dependency. Which version line do you think we
can apply?
---
If your
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1674
@nilday Do you have any updates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1669
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1661
@ppoulosk Could we close this as Supervisor V2 was merged? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user aichow commented on the issue:
https://github.com/apache/storm/pull/1701
@HeartSaVioR Not sure if I tagged the JIRA issue with the right Affects
Versions, so feel free to edit as appropriate. Thanks!
---
If your project is set up for it, you can reply to this email and
Github user ppoulosk closed the pull request at:
https://github.com/apache/storm/pull/1661
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wangli1426 commented on the issue:
https://github.com/apache/storm/pull/753
@harshach I managed to upmerge this PR to 1.x-branch in #1703. Please
review. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1702#discussion_r79990064
--- Diff: external/storm-eventhubs/pom.xml ---
@@ -21,19 +21,19 @@
storm
org.apache.storm
-1.0.3-SNAPSHOT
+
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r79993708
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -266,26 +266,32 @@ private void
GitHub user wangli1426 opened a pull request:
https://github.com/apache/storm/pull/1703
[STORM-1057] Add throughput metrics to spouts/bolts and display them on web
ui for 1.x-branch
Hi @HeartSaVioR, @revans2, @harshach,@d2r,@unsleepy22,
I upmerge PR apache/storm#753 to
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1702
This seems fine once the storm versions are reverted, though you should get
this on the master branch first. I'd like to mention before you spend too much
time on trying to make the spout run reliably,
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1704
STORM-2111 [Storm SQL] support 'LIKE' and 'SIMILAR TO'
Note: This patch is on top of STORM-2089 in order to reduce any merge
conflict and upmerging.
Reviewers may want to only take a
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1696#discussion_r79992419
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -145,6 +154,10 @@ private void initialize(Collection
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1679
This more or less seems done to me. The only thing that bugs me is Storm
double acking tuples. The only case I could think of is if tuples time out and
they're later acked by the acker bolt, but it
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1696
@srdo @jfenc91 I am on vacation this week (with limited access to Internet)
and I will be back on Monday. Can we please holding on merging this until I can
finish my review. I implemented the original
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1679
@srdo @jfenc91 I am on vacation this week (with limited access to Internet)
and I will be back on Monday. **Can we please holding on merging this until I
can finish my review on Monday**. I implemented
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1704
Tests of storm-sql-core failed because of VM crashing. UT passes on my
local dev.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1605#discussion_r80004187
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -330,11 +328,9 @@ public void ack(Object messageId) {
Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/1696#discussion_r79800937
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/SerializableDeserializer.java
---
@@ -0,0 +1,25 @@
+/*
+ * Copyright
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1605
I am +1 overall. Please format the commit message to be easy to read and
squash the two commits. This is a simple change that should have only one
commit. We can merge after that.
---
If your project
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1708
[STORM-2119] - bug in log message printing to stdout
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm STORM-2119
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1696
@hmcl Sure thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1696#discussion_r80026248
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/SerializableDeserializer.java
---
@@ -0,0 +1,25 @@
+/*
+ * Copyright
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1605
Squashed. I hope this commit message is clearer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1706
[STORM-2118] A few fixes for storm-sql standalone mode
1. Cast the result, accumulator and value types correctly
2. Support aggregate functions with more than one argument
You can merge
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1705
STORM-2117 Supervisor V2 with local mode extracts resources directory to
the wrong directory
* it extracts the resources directory to topology root directory instead of
temporary directory
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1679
@hmcl I agree that if there really is a double acking problem somewhere
else, it should be fixed there.
In your scenario say the spout commits 1...5 to Kafka and 4 is later acked.
ackedMsgs
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/1699#discussion_r79851428
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/timer/SupervisorHeartbeat.java
---
@@ -72,10 +72,10 @@ private SupervisorInfo
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1702
Hm, nevermind the new client, it requires Java 8. It's still an option for
Storm 2.0 though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1699
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1699#discussion_r80074819
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/timer/SupervisorHeartbeat.java
---
@@ -72,10 +72,10 @@ private SupervisorInfo
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1694
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1695
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1681
'!storm-core' fails due to the timeout of downloading artifact. I tested it
manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1700
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1707
STORM-2113 [Storm SQL] fix 'OR' and 'AND' operators handle more than 2
operands
NOTE: This is on top of STORM-2089 and STORM-2111 since this requires the
ExprCompiler bugfix introduced on
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1706#discussion_r80131848
--- Diff:
external/sql/storm-sql-runtime/src/test/org/apache/storm/sql/TestUtils.java ---
@@ -60,6 +62,25 @@ public static String result(String
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1702
Btw, IMO, upgrading the dependency is worth to file an issue.
@raviperi Could you file it and copy description of PR to issue's
description?
---
If your project is set up for it, you can
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1708
+1 Nice finding.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1702#discussion_r80133198
--- Diff: external/storm-eventhubs/pom.xml ---
@@ -21,19 +21,19 @@
storm
org.apache.storm
-1.0.3-SNAPSHOT
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1702#discussion_r80133790
--- Diff: external/storm-eventhubs/pom.xml ---
@@ -21,19 +21,19 @@
storm
org.apache.storm
-1.0.3-SNAPSHOT
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1700
The travis failure is unrelated to this change, it is a failure in maven
downloading a dependency.
@knusbaum or @kishorvpatil could you please take a look at this?
---
If your project is
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1699
The travis failure is unrelated it is yet again a maven issue downloading
something that should be there.
@knusbaum @kishorvpatil could you please take a look?
---
If your project is set
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1705
+1
I'll pull this into #1697 too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
81 matches
Mail list logo
