Alexandre,
It's a bug in the way I tried to fix the NPE you had a few days ago in
https://github.com/apache/storm/pull/2428. I missed that using
setKey/setValue actually builds a new KafkaSpoutConfig.Builder instead of
just setting a field, and the change I made to the copy constructor means
that
GitHub user danny0405 opened a pull request:
https://github.com/apache/storm/pull/2431
heartbeats and assignments promotion for storm2.0
For large cluster support, good scheduling performance for scheduling and
assignments distribution.
This is PR for 1.1.x-branch of
Hello Stig,
Here's an update of my tests with storm 1.2.0 preview:
- I accept the limitation on the stability of the string format returned by
getTopicsString(), as I have adapted our code to detect both 1.1.0-style &
1.2.0-style. Isn't there a clean way to get the list of topics other than
our
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2431
@HeartSaVioR hi, i have make PR for storm2.0, please help me to review this
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2319
@HeartSaVioR i have made a PR for storm 2.0, really thx for your review
work, this is the link:
https://github.com/apache/storm/pull/2431/
---
Hi All,
In my project we already installed and running Storm and it’s components as
process but we are planning to install/run storm and it’s components as
services.
Could you please help what all things needs to be taken care which performing
this activity.
Regards
Srikanth Vattikuti
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2430
I think some of the tests are still flaky.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2203
Here are my numbers, and no I didn't do it headless but I was not doing
anything on the laptop at the time it was running except looking at Activity
Monitor to be sure nothing else was using too
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2203
Also looking at the numbers from @HeartSaVioR. They also show the CPU
being higher, but not nearly as much as mine do 219 seconds for V2 vs 206
seconds for 1.2.0 or about a 6% difference.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152348839
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
Hi All,
In my project we already installed and running Storm and it’s components as
process but we are planning to install/run storm and it’s components as
services.
Could you please help what all things needs to be taken care which performing
this activity.
Regards
Srikanth Vattikuti
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2430
The travis test passed on my repo:
https://travis-ci.org/Ethanlm/storm/builds/304993981
Don't know why it failed here.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2426
+1. Thanks @srdo. Can you please squash the commits before merging. Thanks.
---
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152360979
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152368944
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152368599
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152371328
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2426
Thanks for the reviews.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2426
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152365226
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152412106
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152392265
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
GitHub user Ethanlm opened a pull request:
https://github.com/apache/storm/pull/2432
[STORM-2829] fix logviewer deepSearch direct self-reference leading to
cycle exception
https://issues.apache.org/jira/browse/STORM-2829
```
2017-11-21 21:06:19.369 o.e.j.s.HttpChannel
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152407885
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2430#discussion_r152434183
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -97,8 +98,14 @@ public
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
@revans2 Thanks for the update.
My first instinct is that itâs usage of Meter on the critical path.
Adding anything that âdoes somethingâ there is going to add some level of
overhead.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2203
Crude test, but illustrates the cost of meters:
(code marks a meter | increments a counter from 0 to `Integer.MAX`)
```
*** METER ***
Time: 126.39
ops/sec: 16,990,930
***
27 matches
Mail list logo
