[jira] [Commented] (STORM-487) Remove storm.cmd, no need to duplicate work python runs on windows too.

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304681#comment-14304681 ] ASF GitHub Bot commented on STORM-487: -- Github user dashengju commented on the pull re

[GitHub] storm pull request: STORM-487 Let bin/storm compatible with Window...

2015-02-03 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/280#issuecomment-72795383 @harshach , ok, you or @HeartSaVioR should responsible for fix this bug, because I just know how to fix it in linux, but not in windows. thanks --- If your project

[jira] [Commented] (STORM-487) Remove storm.cmd, no need to duplicate work python runs on windows too.

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304676#comment-14304676 ] ASF GitHub Bot commented on STORM-487: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-487 Let bin/storm compatible with Window...

2015-02-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/280#issuecomment-72794546 @dashengju I second that ,just recently noticed it . We can file a follow-up jira for it. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (STORM-487) Remove storm.cmd, no need to duplicate work python runs on windows too.

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304668#comment-14304668 ] ASF GitHub Bot commented on STORM-487: -- Github user dashengju commented on the pull re

[GitHub] storm pull request: STORM-487 Let bin/storm compatible with Window...

2015-02-03 Thread dashengju
Github user dashengju commented on the pull request: https://github.com/apache/storm/pull/280#issuecomment-72793961 @harshach @HeartSaVioR @revans2 , this PR has produce a new bug in linux OS. In function exec_storm_class,line 181: -os.execvp(JAVA_CMD, all_args

[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304585#comment-14304585 ] ASF GitHub Bot commented on STORM-534: -- Github user caofangkun commented on a diff in

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread caofangkun
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/394#discussion_r24060605 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -18,12 +18,17 @@ [java.util Collections]) (:import [java.io FileN

the external Zookeeper in Local mode

2015-02-03 Thread clay teahouse
Hi, I have a topology running in local mode. The topology uses kafkaspout and is configured to use the external zookeeper. But when I start the topology, I see the following: org.apache.storm.zookeeper.ZooKeeper - Initiating client connection, connectString=localhost:2000 I also messages like t

[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304568#comment-14304568 ] ASF GitHub Bot commented on STORM-534: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72782784 @caofangkun Thanks . I think it helps categorizing the configuration into different section. But in a storm deployment same storm.yaml used on all hosts. So I don't think

[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304566#comment-14304566 ] ASF GitHub Bot commented on STORM-534: -- Github user harshach commented on a diff in th

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/394#discussion_r24060103 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -18,12 +18,17 @@ [java.util Collections]) (:import [java.io FileNot

[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304547#comment-14304547 ] ASF GitHub Bot commented on STORM-534: -- Github user caofangkun commented on the pull r

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72781055 @harshach Sorry for my unclear explanation.I am not ok with storing config in zk ether. I am just thinking storm config shoud be classfied to nimbus/supervis

[jira] [Commented] (STORM-656) Document "external" modules and "Committer Sponsors"

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304536#comment-14304536 ] ASF GitHub Bot commented on STORM-656: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: STORM-656: Document "external" modules and "Co...

2015-02-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/416#issuecomment-72780287 @ptgoetz Yes, it can make sense. Contributors which bring a new external module to Storm are willing to contribute more, and it can prevent failing morale and

[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304535#comment-14304535 ] ASF GitHub Bot commented on STORM-534: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72780192 @revans2 @caofangkun Any reason to store storm config in zookeeper. I don't see any benefit of it and whenever user/admin changes storm config these needs to be updated

[jira] [Commented] (STORM-656) Document "external" modules and "Committer Sponsors"

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304530#comment-14304530 ] ASF GitHub Bot commented on STORM-656: -- Github user ptgoetz commented on the pull requ

[GitHub] storm pull request: STORM-656: Document "external" modules and "Co...

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/416#issuecomment-72779670 @HeartSaVioR, yes. Basically just an indicator that at least one committer (i.e. someone with commit rights) is interested in supporting a module. But your questio

[jira] [Commented] (STORM-609) add storm-redis to storm external

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304521#comment-14304521 ] ASF GitHub Bot commented on STORM-609: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: [STORM-609] Add storm-redis to storm external

2015-02-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/365#issuecomment-72779122 @dashengju According to #416, we should remove ourselves from "committer sponsors" to let storm-redis module can be merged into master. Thanks for clarificatio

[jira] [Commented] (STORM-656) Document "external" modules and "Committer Sponsors"

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304515#comment-14304515 ] ASF GitHub Bot commented on STORM-656: -- Github user HeartSaVioR commented on the pull

[GitHub] storm pull request: STORM-656: Document "external" modules and "Co...

2015-02-03 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/416#issuecomment-72778805 PR described "committer sponsors" clearly, especially only committers can join external's "committer sponsors". Right? --- If your project is set up for it, you can r

[jira] [Commented] (STORM-656) Document "external" modules and "Committer Sponsors"

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304506#comment-14304506 ] ASF GitHub Bot commented on STORM-656: -- GitHub user ptgoetz opened a pull request:

[GitHub] storm pull request: STORM-656: Document "external" modules and "Co...

2015-02-03 Thread ptgoetz
GitHub user ptgoetz opened a pull request: https://github.com/apache/storm/pull/416 STORM-656: Document "external" modules and "Committer Sponsors" JIRA: https://issues.apache.org/jira/browse/STORM-656 You can merge this pull request into a Git repository by running: $ git pul

[jira] [Created] (STORM-656) Document "external" modules and "Committer Sponsors"

2015-02-03 Thread P. Taylor Goetz (JIRA)
P. Taylor Goetz created STORM-656: - Summary: Document "external" modules and "Committer Sponsors" Key: STORM-656 URL: https://issues.apache.org/jira/browse/STORM-656 Project: Apache Storm Iss

[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304493#comment-14304493 ] ASF GitHub Bot commented on STORM-534: -- Github user caofangkun commented on the pull r

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72776924 @revans2 it might be good to: 1: the configuration should be paginated 2: we'd better supply three types of configuration and they may different from

[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304426#comment-14304426 ] ASF GitHub Bot commented on STORM-534: -- Github user caofangkun commented on the pull r

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread caofangkun
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72770805 @revans2 Yes, not only nimbus server version numbers , but also supervisors and ui should show up version numbers on UI . In face , it may be better add supervs

[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304421#comment-14304421 ] ASF GitHub Bot commented on STORM-534: -- GitHub user caofangkun reopened a pull request

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread caofangkun
GitHub user caofangkun reopened a pull request: https://github.com/apache/storm/pull/394 STORM-534:Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus like {nimbus_host_n

[jira] [Created] (STORM-655) Ad replication count as part of topology summary.

2015-02-03 Thread Parth Brahmbhatt (JIRA)
Parth Brahmbhatt created STORM-655: -- Summary: Ad replication count as part of topology summary. Key: STORM-655 URL: https://issues.apache.org/jira/browse/STORM-655 Project: Apache Storm Issu

[jira] [Created] (STORM-654) Create a thrift API to discover nimbus so all the clients are not forced to contact zookeeper.

2015-02-03 Thread Parth Brahmbhatt (JIRA)
Parth Brahmbhatt created STORM-654: -- Summary: Create a thrift API to discover nimbus so all the clients are not forced to contact zookeeper. Key: STORM-654 URL: https://issues.apache.org/jira/browse/STORM-654

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24050731 --- Diff: external/storm-jdbc/pom.xml --- @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XML

[jira] [Commented] (STORM-581) Add rebalance params to Storm REST API

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304147#comment-14304147 ] ASF GitHub Bot commented on STORM-581: -- Github user harshach closed the pull request a

[jira] [Commented] (STORM-581) Add rebalance params to Storm REST API

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304145#comment-14304145 ] ASF GitHub Bot commented on STORM-581: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-03 Thread harshach
Github user harshach closed the pull request at: https://github.com/apache/storm/pull/370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (STORM-581) Add rebalance params to Storm REST API

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304144#comment-14304144 ] ASF GitHub Bot commented on STORM-581: -- GitHub user harshach opened a pull request:

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/370#issuecomment-72748703 closing this PR. https://github.com/apache/storm/pull/415 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-03 Thread harshach
GitHub user harshach opened a pull request: https://github.com/apache/storm/pull/415 STORM-581. Add rebalance params to Storm REST API. You can merge this pull request into a Git repository by running: $ git pull https://github.com/harshach/incubator-storm STORM-581-V1 Altern

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24044371 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/Column.java --- @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24043926 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24041005 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java --- @@ -0,0 +1,213 @@ +/** + * Licensed to the Apach

[jira] [Commented] (STORM-581) Add rebalance params to Storm REST API

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304009#comment-14304009 ] ASF GitHub Bot commented on STORM-581: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-581. Add rebalance params to Storm REST ...

2015-02-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/370#issuecomment-72736581 Please hold merging this in. I'll send a new PR. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24040425 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java --- @@ -0,0 +1,213 @@ +/** + * Licensed to the Apach

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/374#issuecomment-72735923 Overall I think this is a good start and I am supportive. @revans2 brought up some good points and I tried to expand/clarify in several places. I feel more efficient use o

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24040287 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/Column.java --- @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Soft

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24039920 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/Column.java --- @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Soft

[jira] [Commented] (STORM-329) Add Option to Config Message handling strategy when connection timeout

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303988#comment-14303988 ] ASF GitHub Bot commented on STORM-329: -- Github user miguno commented on a diff in the

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2015-02-03 Thread miguno
Github user miguno commented on a diff in the pull request: https://github.com/apache/storm/pull/268#discussion_r24039811 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -142,6 +147,15 @@ public void run() { }

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24039560 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcLookupBolt.java --- @@ -0,0 +1,86 @@ +/** + * Licensed to the Apac

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24039341 --- Diff: external/storm-jdbc/pom.xml --- @@ -0,0 +1,125 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-in

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24039240 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Soft

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24039222 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,91 @@ +/** + * Licensed to the Apache Soft

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread Parth-Brahmbhatt
Github user Parth-Brahmbhatt commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24039215 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Soft

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24038992 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/common/JdbcClient.java --- @@ -0,0 +1,213 @@ +/** + * Licensed to the Apache Softwar

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24037432 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24037306 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24036567 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,91 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] storm pull request: Storm-616 : Storm-jdbc connector.

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on a diff in the pull request: https://github.com/apache/storm/pull/374#discussion_r24036406 --- Diff: external/storm-jdbc/src/main/java/org/apache/storm/jdbc/bolt/JdbcBolt.java --- @@ -0,0 +1,91 @@ +/** + * Licensed to the Apache Software Foun

[jira] [Commented] (STORM-130) [Storm 0.8.2]: java.io.FileNotFoundException: File '../stormconf.ser' does not exist

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303904#comment-14303904 ] ASF GitHub Bot commented on STORM-130: -- Github user harshach commented on the pull req

[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...

2015-02-03 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/401#issuecomment-72726626 @ptgoetz will send a new PR against 0.9.3 branch. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (STORM-130) [Storm 0.8.2]: java.io.FileNotFoundException: File '../stormconf.ser' does not exist

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303893#comment-14303893 ] ASF GitHub Bot commented on STORM-130: -- Github user ptgoetz commented on the pull requ

[GitHub] storm pull request: STORM-130: Supervisor getting killed due to ja...

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/401#issuecomment-72725245 +1. I'd also like to see this back-ported to the 0.9.3 branch, but that shouldn't block this from getting merged to master. --- If your project is set up for it, you can

[jira] [Commented] (STORM-637) Integrate PartialKeyGrouping into storm API

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303877#comment-14303877 ] ASF GitHub Bot commented on STORM-637: -- Github user ptgoetz commented on the pull requ

[GitHub] storm pull request: STORM-637: Integrate PartialKeyGrouping into s...

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/404#issuecomment-72723482 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-469) Storm UI Last Error Detail Insufficient for debugging

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303875#comment-14303875 ] ASF GitHub Bot commented on STORM-469: -- Github user rekhajoshm closed the pull request

[jira] [Commented] (STORM-469) Storm UI Last Error Detail Insufficient for debugging

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303874#comment-14303874 ] ASF GitHub Bot commented on STORM-469: -- Github user rekhajoshm commented on the pull r

[GitHub] storm pull request: STORM-469

2015-02-03 Thread rekhajoshm
Github user rekhajoshm closed the pull request at: https://github.com/apache/storm/pull/385 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] storm pull request: STORM-469

2015-02-03 Thread rekhajoshm
Github user rekhajoshm commented on the pull request: https://github.com/apache/storm/pull/385#issuecomment-72723038 created separate pulls. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[jira] [Commented] (STORM-400) Thrift upgrade to 0.9.1

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303872#comment-14303872 ] ASF GitHub Bot commented on STORM-400: -- Github user ptgoetz commented on the pull requ

[GitHub] storm pull request: [STORM-400] Thrift upgrade to thrift-0.9.2

2015-02-03 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/410#issuecomment-72722775 Looks like this needs an up merge, but I'm +1 for the patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[jira] [Commented] (STORM-634) Storm should support rolling upgrade/downgrade of storm cluster.

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303868#comment-14303868 ] ASF GitHub Bot commented on STORM-634: -- GitHub user Parth-Brahmbhatt opened a pull req

[GitHub] storm pull request: STORM-634: Storm serialization changed to thri...

2015-02-03 Thread Parth-Brahmbhatt
GitHub user Parth-Brahmbhatt opened a pull request: https://github.com/apache/storm/pull/414 STORM-634: Storm serialization changed to thrift to support rolling upgrade. Converting SupervisorInfo,Assignment,StormBase,TopologyStatus,ZKWorkerHeartbeat,ErrorInfo,Credentials to thrift

[jira] [Commented] (STORM-650) Storm-Kafka Refactoring and Improvements

2015-02-03 Thread Xavier Stevens (JIRA)
[ https://issues.apache.org/jira/browse/STORM-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303852#comment-14303852 ] Xavier Stevens commented on STORM-650: -- I think it would be useful if the kafka spout

[jira] [Resolved] (STORM-608) Storm UI CSRF escape characters not work correctly

2015-02-03 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-608. --- Resolution: Fixed Fix Version/s: 0.10.0 Thanks Harsha, I pulled this into maste

[jira] [Commented] (STORM-608) Storm UI CSRF escape characters not work correctly

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303823#comment-14303823 ] ASF GitHub Bot commented on STORM-608: -- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-608. Storm UI CSRF escape characters not...

2015-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/371 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-608) Storm UI CSRF escape characters not work correctly

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303818#comment-14303818 ] ASF GitHub Bot commented on STORM-608: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-608. Storm UI CSRF escape characters not...

2015-02-03 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/371#issuecomment-72717689 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Resolved] (STORM-636) UI/Monitor is slow for topologies with a large number of components

2015-02-03 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-636. --- Resolution: Fixed Fix Version/s: 0.10.0 Thanks [~dagit], I merged this into mas

[jira] [Commented] (STORM-636) UI/Monitor is slow for topologies with a large number of components

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303754#comment-14303754 ] ASF GitHub Bot commented on STORM-636: -- Github user asfgit closed the pull request at:

[GitHub] storm pull request: [STORM-636] Faster, optional retrieval of last...

2015-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/392 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-532) Supervisor should restart worker immediately, if the worker process does not exist any more

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303716#comment-14303716 ] ASF GitHub Bot commented on STORM-532: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-532:Supervisor should restart worker imm...

2015-02-03 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/296#issuecomment-72706534 The code change looks OK, but I am seeing test failures in supervisor_test.clj. I also would prefer to have us cache the Process that we used to launch the external proce

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72693402 @caofangkun If you want to reopen this and just add in the nimbus version information I would support that. --- If your project is set up for it, you can reply to this em

[jira] [Commented] (STORM-350) Update disruptor to latest version (3.2.1)

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303625#comment-14303625 ] ASF GitHub Bot commented on STORM-350: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-350: LMAX Disruptor 3.2.1

2015-02-03 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/134#issuecomment-72693694 @darionyaphet, if 3.3.0 is out with a different wait strategy it would at least be worth doing a comparison. Do you have the time to do that? --- If your project is set

[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303620#comment-14303620 ] ASF GitHub Bot commented on STORM-534: -- Github user revans2 commented on the pull requ

[jira] [Commented] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303617#comment-14303617 ] ASF GitHub Bot commented on STORM-534: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...

2015-02-03 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-72693203 Sorry this took me so long to respond to. I am kind of swamped :). I do like the idea of being able to access the version numbers for nimbus, but also for the supervisor

[jira] [Resolved] (STORM-635) logviewer returns 404 if storm_home/logs is a symlinked dir

2015-02-03 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-635. --- Resolution: Fixed Fix Version/s: 0.10.0 Thanks [~sriharsha], I merged this into

[jira] [Commented] (STORM-635) logviewer returns 404 if storm_home/logs is a symlinked dir

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303599#comment-14303599 ] ASF GitHub Bot commented on STORM-635: -- Github user asfgit closed the pull request at:

[GitHub] storm pull request: STORM-635. logviewer returns 404 if storm_home...

2015-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-570) Switch from tablesorter to datatables jquery plugin

2015-02-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303574#comment-14303574 ] ASF GitHub Bot commented on STORM-570: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: [STORM-570] replace table sorter with data tab...

2015-02-03 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/328#issuecomment-72688638 I rebased it so it would merge cleanly. @kishorvpatil if you could take a look again that would be great. --- If your project is set up for it, you can reply to this ema

  1   2   >