[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52713780 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,231 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144239#comment-15144239 ] ASF GitHub Bot commented on STORM-1253: --- Github user abhishekagarwal87 commented on a diff in the

[jira] [Comment Edited] (STORM-1542) Clicking jstack for a worker in UI results in endless empty jstack dumps

2016-02-12 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144458#comment-15144458 ] Abhishek Agarwal edited comment on STORM-1542 at 2/12/16 12:15 PM: --- Now

[jira] [Commented] (STORM-1542) Clicking jstack for a worker in UI results in endless empty jstack dumps

2016-02-12 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144458#comment-15144458 ] Abhishek Agarwal commented on STORM-1542: - Now I can give an easy fix just to counter this

[jira] [Updated] (STORM-1542) Clicking jstack for a worker in UI results in endless empty jstack dumps

2016-02-12 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Agarwal updated STORM-1542: Description: Resolved path for jstack command on supervisor is

[jira] [Updated] (STORM-1542) Clicking jstack for a worker in UI results in endless empty jstack dumps

2016-02-12 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Agarwal updated STORM-1542: Summary: Clicking jstack for a worker in UI results in endless empty jstack dumps (was:

[jira] [Created] (STORM-1542) Clicking jstack in ui results in endless empty jstack dumps

2016-02-12 Thread Abhishek Agarwal (JIRA)
Abhishek Agarwal created STORM-1542: --- Summary: Clicking jstack in ui results in endless empty jstack dumps Key: STORM-1542 URL: https://issues.apache.org/jira/browse/STORM-1542 Project: Apache

[jira] [Commented] (STORM-1542) Clicking jstack for a worker in UI results in endless empty jstack dumps

2016-02-12 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144462#comment-15144462 ] Abhishek Agarwal commented on STORM-1542: - Another problem is handling retention for the dumps

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144639#comment-15144639 ] ASF GitHub Bot commented on STORM-1253: --- Github user jerrypeng commented on a diff in the pull

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52749203 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,231 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144644#comment-15144644 ] ASF GitHub Bot commented on STORM-1253: --- Github user jerrypeng commented on a diff in the pull

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144650#comment-15144650 ] ASF GitHub Bot commented on STORM-1253: --- Github user jerrypeng commented on a diff in the pull

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52749006 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,231 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144643#comment-15144643 ] ASF GitHub Bot commented on STORM-1253: --- Github user jerrypeng commented on a diff in the pull

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52748470 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -332,19 +333,24 @@ :assignment-id (.getAssignmentId isupervisor)

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144647#comment-15144647 ] ASF GitHub Bot commented on STORM-1253: --- Github user jerrypeng commented on a diff in the pull

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144664#comment-15144664 ] ASF GitHub Bot commented on STORM-1253: --- Github user abhishekagarwal87 commented on a diff in the

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52750639 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,231 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52749084 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,231 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] storm pull request: STORM-1538: Exception being thrown after Utils...

2016-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1099 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread jerrypeng
Github user jerrypeng commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52749466 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,231 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1538) Exception being thrown after Utils conversion to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144684#comment-15144684 ] ASF GitHub Bot commented on STORM-1538: --- Github user asfgit closed the pull request at:

[jira] [Created] (STORM-1543) DRPCSpout should always try to reconnect disconnected DRPCInvocationsClient

2016-02-12 Thread Kishor Patil (JIRA)
Kishor Patil created STORM-1543: --- Summary: DRPCSpout should always try to reconnect disconnected DRPCInvocationsClient Key: STORM-1543 URL: https://issues.apache.org/jira/browse/STORM-1543 Project:

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52767645 --- Diff: conf/defaults.yaml --- @@ -263,7 +263,7 @@ topology.state.checkpoint.interval.ms: 1000 # topology priority describing the importance of the

[jira] [Commented] (STORM-1538) Exception being thrown after Utils conversion to java

2016-02-12 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144897#comment-15144897 ] P. Taylor Goetz commented on STORM-1538: [~jerrypeng] Just a gentle reminder that pull requests

[jira] [Commented] (STORM-1543) DRPCSpout should always try to reconnect disconnected DRPCInvocationsClient

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144841#comment-15144841 ] ASF GitHub Bot commented on STORM-1543: --- GitHub user kishorvpatil opened a pull request:

[GitHub] storm pull request: [STORM-1543] Always try to reconnect disconnec...

2016-02-12 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/1103 [STORM-1543] Always try to reconnect disconnected DRPCInvocationsClient `DRPCSpout` should be able to reconnect to DRPC server. You can merge this pull request into a Git repository by

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144853#comment-15144853 ] ASF GitHub Bot commented on STORM-1336: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: STORM-1541 Change scope of 'hadoop-minicluster...

2016-02-12 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1102#issuecomment-183372754 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-12 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52775213 --- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj --- @@ -1178,7 +1212,7 @@ (FileUtils/copyDirectory (File. (.getFile url))

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144961#comment-15144961 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the pull request:

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-12 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1055#issuecomment-183436838 @revans2 rebased.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-12 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52777206 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/Hierarchy.java --- @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software Foundation

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144997#comment-15144997 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the pull request:

[jira] [Commented] (STORM-1537) Upgrade to Kryo 3

2016-02-12 Thread Oscar Boykin (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15144966#comment-15144966 ] Oscar Boykin commented on STORM-1537: - Okay: Soren. You're up. Chill 0.8.0 is out that depends on Kryo

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-12 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/1053#issuecomment-183445741 I upmerged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145039#comment-15145039 ] ASF GitHub Bot commented on STORM-1336: --- Github user jerrypeng commented on the pull request:

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145048#comment-15145048 ] ASF GitHub Bot commented on STORM-1253: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52781328 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,274 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145060#comment-15145060 ] ASF GitHub Bot commented on STORM-1253: --- Github user revans2 commented on a diff in the pull

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145069#comment-15145069 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-12 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52782270 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/core/CpusetCore.java --- @@ -0,0 +1,209 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-12 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r52782841 --- Diff: storm-core/src/jvm/org/apache/storm/Config.java --- @@ -2194,6 +2195,73 @@ @isString public static final Object CLIENT_JAR_TRANSFORMER

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145080#comment-15145080 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-1336] - Evalute/Port JStorm cgroup supp...

2016-02-12 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/1053#issuecomment-183452870 One comment about the new tolerance config name, other than that it looks OK. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145128#comment-15145128 ] ASF GitHub Bot commented on STORM-1253: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: STROM-1263: port backtype.storm.command.kill-t...

2016-02-12 Thread revans2
GitHub user revans2 opened a pull request: https://github.com/apache/storm/pull/1104 STROM-1263: port backtype.storm.command.kill-topology to java (And add in better java CLI) You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52781609 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,274 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145054#comment-15145054 ] ASF GitHub Bot commented on STORM-1253: --- Github user revans2 commented on a diff in the pull

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145067#comment-15145067 ] ASF GitHub Bot commented on STORM-1253: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52782172 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,274 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145076#comment-15145076 ] ASF GitHub Bot commented on STORM-1253: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52782697 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,274 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1336) Evalute/Port JStorm cgroup support

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145092#comment-15145092 ] ASF GitHub Bot commented on STORM-1336: --- Github user d2r commented on the pull request:

[jira] [Created] (STORM-1544) Document Debug/Sampling of Topologies

2016-02-12 Thread P. Taylor Goetz (JIRA)
P. Taylor Goetz created STORM-1544: -- Summary: Document Debug/Sampling of Topologies Key: STORM-1544 URL: https://issues.apache.org/jira/browse/STORM-1544 Project: Apache Storm Issue Type:

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52786150 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,274 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52786981 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,274 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145144#comment-15145144 ] ASF GitHub Bot commented on STORM-1253: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1368] change heapdump file permissions ...

2016-02-12 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1078#discussion_r52788111 --- Diff: storm-core/src/jvm/org/apache/storm/Config.java --- @@ -231,7 +231,7 @@ /** * Whether we want to display all the resource

[jira] [Commented] (STORM-1523) Translate Available Ports task in util.java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145154#comment-15145154 ] ASF GitHub Bot commented on STORM-1523: --- Github user redsanket commented on the pull request:

[GitHub] storm pull request: [STORM-1523] util.clj available-port conversio...

2016-02-12 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1073#issuecomment-183461680 @abhishekagarwal87 @knusbaum please take a look at it, it must go into Utils.java --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm pull request: [STORM-1368] change heapdump file permissions ...

2016-02-12 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1078#issuecomment-183461871 Minor nit, then +1 pending travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (STORM-1368) For secure cluster, heapdump file lacks of group read permissions for UI download

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145156#comment-15145156 ] ASF GitHub Bot commented on STORM-1368: --- Github user knusbaum commented on the pull request:

[GitHub] storm pull request: [STORM-1523] util.clj available-port conversio...

2016-02-12 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1073#issuecomment-183462361 Just a moment, will test it once more --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (STORM-1523) Translate Available Ports task in util.java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145165#comment-15145165 ] ASF GitHub Bot commented on STORM-1523: --- Github user redsanket commented on the pull request:

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52789091 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,274 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52788861 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,274 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145168#comment-15145168 ] ASF GitHub Bot commented on STORM-1253: --- Github user revans2 commented on a diff in the pull

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145172#comment-15145172 ] ASF GitHub Bot commented on STORM-1253: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1098#discussion_r52789245 --- Diff: storm-core/src/jvm/org/apache/storm/StormTimer.java --- @@ -0,0 +1,274 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145175#comment-15145175 ] ASF GitHub Bot commented on STORM-1253: --- Github user revans2 commented on a diff in the pull

[jira] [Commented] (STORM-1253) port backtype.storm.timer to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145179#comment-15145179 ] ASF GitHub Bot commented on STORM-1253: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1253] - port backtype.storm.timer to ja...

2016-02-12 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1098#issuecomment-183464954 I didn't realize how messed up timer.clj really was. Besides fixing the locking issues in the code, my biggest suggestion would be to make it fully object oriented and

[jira] [Commented] (STORM-1368) For secure cluster, heapdump file lacks of group read permissions for UI download

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145186#comment-15145186 ] ASF GitHub Bot commented on STORM-1368: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1368] change heapdump file permissions ...

2016-02-12 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1078#issuecomment-183466471 This breaks windows by default, and is only needed when security is turned on. Why don't we have the logviewer + worker_launcher change the permissions instead of

[jira] [Commented] (STORM-1537) Upgrade to Kryo 3

2016-02-12 Thread Soren Macbeth (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145189#comment-15145189 ] Soren Macbeth commented on STORM-1537: -- On it. > Upgrade to Kryo 3 > - > >

[GitHub] storm pull request: [STORM-1230] port backtype.storm.process-simul...

2016-02-12 Thread zhuoliu
Github user zhuoliu commented on a diff in the pull request: https://github.com/apache/storm/pull/1100#discussion_r52790876 --- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145197#comment-15145197 ] ASF GitHub Bot commented on STORM-1230: --- Github user zhuoliu commented on a diff in the pull

[GitHub] storm pull request: [STORM-1523] util.clj available-port conversio...

2016-02-12 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1073#issuecomment-183469078 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (STORM-1523) Translate Available Ports task in util.java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145202#comment-15145202 ] ASF GitHub Bot commented on STORM-1523: --- Github user knusbaum commented on the pull request:

[jira] [Commented] (STORM-1537) Upgrade to Kryo 3

2016-02-12 Thread Soren Macbeth (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145204#comment-15145204 ] Soren Macbeth commented on STORM-1537: -- carbonite 1.5.0 targeting chill 0.8.0 and kryo 3.0.3 is up on

[jira] [Commented] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145206#comment-15145206 ] ASF GitHub Bot commented on STORM-1248: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (STORM-1248) port backtype.storm.messaging.loader to java

2016-02-12 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1248. Resolution: Fixed Fix Version/s: 2.0.0 Thanks [~abhishek.agarwal], I merged

[jira] [Resolved] (STORM-1247) port backtype.storm.messaging.local to java

2016-02-12 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1247. Resolution: Fixed Fix Version/s: 2.0.0 This went in with STORM-1248 > port

[GitHub] storm pull request: [STORM-1523] util.clj available-port conversio...

2016-02-12 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1073#issuecomment-183595106 Trying with value 0 on failure was a potentially important behavior of the previous implementation. Exceptions will still bubble up if it fails if my solution

[jira] [Commented] (STORM-1523) Translate Available Ports task in util.java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145813#comment-15145813 ] ASF GitHub Bot commented on STORM-1523: --- Github user knusbaum commented on the pull request:

[GitHub] storm pull request: [STORM-1523] util.clj available-port conversio...

2016-02-12 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the pull request: https://github.com/apache/storm/pull/1073#issuecomment-183588726 If there is an exception, tests are going to fail nonetheless. If the exception is bubbled up, test failure will show the right error. Though yes I agree,

[jira] [Commented] (STORM-1523) Translate Available Ports task in util.java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145804#comment-15145804 ] ASF GitHub Bot commented on STORM-1523: --- Github user abhishekagarwal87 commented on the pull

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r52794040 --- Diff: storm-clojure/pom.xml --- @@ -0,0 +1,83 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145373#comment-15145373 ] ASF GitHub Bot commented on STORM-1230: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1523) Translate Available Ports task in util.java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145413#comment-15145413 ] ASF GitHub Bot commented on STORM-1523: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM - 1258] Backport thrift.clj to Thrift.j...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r52795220 --- Diff: storm-clojure/pom.xml --- @@ -0,0 +1,83 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] storm pull request: STORM-1539 - Improve Storm ACK-ing performance

2016-02-12 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1101#issuecomment-183494993 Please close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (STORM-1539) Improve Storm ACK-ing performance

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145343#comment-15145343 ] ASF GitHub Bot commented on STORM-1539: --- Github user knusbaum commented on the pull request:

[GitHub] storm pull request: [STORM-1230] port backtype.storm.process-simul...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1100#discussion_r52803599 --- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java --- @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (STORM-1539) Improve Storm ACK-ing performance

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145368#comment-15145368 ] ASF GitHub Bot commented on STORM-1539: --- Github user roshannaik commented on the pull request:

[GitHub] storm pull request: [STORM-1230] port backtype.storm.process-simul...

2016-02-12 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1100#discussion_r52803469 --- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java --- @@ -0,0 +1,89 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (STORM-1230) port backtype.storm.process-simulator to java

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145369#comment-15145369 ] ASF GitHub Bot commented on STORM-1230: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: STROM-1263: port backtype.storm.command.kill-t...

2016-02-12 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/1104#discussion_r52792355 --- Diff: storm-core/src/jvm/org/apache/storm/command/CLI.java --- @@ -0,0 +1,229 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (STORM-1529) Change default worker temp directory location for workers

2016-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145305#comment-15145305 ] ASF GitHub Bot commented on STORM-1529: --- Github user knusbaum commented on the pull request:

  1   2   >