[GitHub] storm issue #1565: STORM-1970: external project examples refator

2016-07-14 Thread vesense
Github user vesense commented on the issue: https://github.com/apache/storm/pull/1565 hi @darionyaphet sorry for the less information. this PR address @abhishekagarwal87 's topic from dev@ mailing list. >Right now the example topologies/classes for some external modules

[GitHub] storm issue #1536: Storm 1890 ensure we refetch static resources after packa...

2016-07-14 Thread abellina
Github user abellina commented on the issue: https://github.com/apache/storm/pull/1536 No problem. Thanks @HeartSaVioR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1536: Storm 1890 ensure we refetch static resources after packa...

2016-07-14 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1536 @abellina I don't have enough knowledge to front-end tech. But at a glance, I think concept is good. @knusbaum @kishorvpatil Please go ahead reviewing & merging. --- If your project is set

[GitHub] storm issue #1536: Storm 1890 ensure we refetch static resources after packa...

2016-07-14 Thread abellina
Github user abellina commented on the issue: https://github.com/apache/storm/pull/1536 @HeartSaVioR, could you take a look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378670#comment-15378670 ] ASF GitHub Bot commented on STORM-1966: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1560: STORM-1966 Expand metric having Map type as value into mu...

2016-07-14 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1560 I also addressed review comments and also RAT issue to 1.x PR. Please take a look at #1561 as well. Thanks! --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378621#comment-15378621 ] ASF GitHub Bot commented on STORM-1966: --- Github user harshach commented on the issue:

[GitHub] storm issue #1560: STORM-1966 Expand metric having Map type as value into mu...

2016-07-14 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1560 Thanks @HeartSaVioR . +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #1561: STORM-1966 Expand metric having Map type as value into mu...

2016-07-14 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1561 @abhishekagarwal87 @harshach @ptgoetz Please review this as well. Thanks in advance! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378609#comment-15378609 ] ASF GitHub Bot commented on STORM-1966: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1560: STORM-1966 Expand metric having Map type as value into mu...

2016-07-14 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1560 @harshach Addressed. I found RAT issue again (my bad) and fixed it. Btw, I didn't address review comments to PR for 1.x-branch. Once I'm done I'll mention reviewers to review

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378583#comment-15378583 ] ASF GitHub Bot commented on STORM-1966: --- Github user HeartSaVioR commented on the issue:

[jira] [Updated] (STORM-1910) One topology can't use hdfs spout to read from two locations

2016-07-14 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-1910: Issue Type: Improvement (was: Bug) > One topology can't use hdfs spout to read from two locations

Re: Request for reviewing

2016-07-14 Thread Jungtaek Lim
I thought STORM-1910 is likely an improvement, not bugfix. That is why I included this to Storm 1.1.0 epic. I'd like to see others' opinions as well. If we think it's a bugfix we can include it to 1.0.2. What do all of you think about this?

[jira] [Commented] (STORM-1910) One topology can't use hdfs spout to read from two locations

2016-07-14 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378435#comment-15378435 ] Roshan Naik commented on STORM-1910: [~ptgoetz] should this be marked for 1.0.2 as well ? > One

[jira] [Resolved] (STORM-1910) One topology can't use hdfs spout to read from two locations

2016-07-14 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz resolved STORM-1910. Resolution: Fixed Fix Version/s: 2.0.0 Merged to master and 1.x-branch > One

[GitHub] storm pull request #1558: STORM-1910 One topology cannot use hdfs spout to r...

2016-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1910) One topology can't use hdfs spout to read from two locations

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378311#comment-15378311 ] ASF GitHub Bot commented on STORM-1910: --- Github user asfgit closed the pull request at:

[jira] [Commented] (STORM-1910) One topology can't use hdfs spout to read from two locations

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378283#comment-15378283 ] ASF GitHub Bot commented on STORM-1910: --- Github user ptgoetz commented on the issue:

[GitHub] storm issue #1558: STORM-1910 One topology cannot use hdfs spout to read fro...

2016-07-14 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1558 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Request for reviewing

2016-07-14 Thread Roshan Naik
STORM-1910 -roshan On 7/14/16, 8:59 AM, "Jungtaek Lim" wrote: >We seems close to make all issues for 1.0.2 epic resolved soon. > >Epic link: https://issues.apache.org/jira/browse/STORM-1855 >All of open issues are in progress of reviewing. Most of them got +1 and >is

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378057#comment-15378057 ] ASF GitHub Bot commented on STORM-1737: --- Github user harshach commented on the issue:

[GitHub] storm issue #1556: STORM-1737: storm-kafka-client has compilation errors wit...

2016-07-14 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1556 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378056#comment-15378056 ] ASF GitHub Bot commented on STORM-1966: --- Github user harshach commented on the issue:

[GitHub] storm issue #1560: STORM-1966 Expand metric having Map type as value into mu...

2016-07-14 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1560 @HeartSaVioR looks good to me. Just a minor nitpick +1 after that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378040#comment-15378040 ] ASF GitHub Bot commented on STORM-1966: --- Github user harshach commented on a diff in the pull

[GitHub] storm pull request #1560: STORM-1966 Expand metric having Map type as value ...

2016-07-14 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1560#discussion_r70856636 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java --- @@ -391,9 +388,13 @@ public static void addEventLogger(Map conf, StormTopology

[jira] [Commented] (STORM-1969) Modify HiveTopology to show usage of non-partition table

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377900#comment-15377900 ] ASF GitHub Bot commented on STORM-1969: --- Github user harshach commented on the issue:

[GitHub] storm issue #1564: STORM-1969 Modify HiveTopology to show usage of non-parti...

2016-07-14 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1564 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (STORM-1930) Kafka New Client API - Support for Topic Wildcards

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377887#comment-15377887 ] ASF GitHub Bot commented on STORM-1930: --- Github user nabhanelrahman commented on the issue:

[GitHub] storm issue #1518: re-submitting STORM-1930: Kafka New Client API - Support ...

2016-07-14 Thread nabhanelrahman
Github user nabhanelrahman commented on the issue: https://github.com/apache/storm/pull/1518 @hmcl, just following up; it this PR ready to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Assigned] (STORM-1968) Storm logviewer does not work for nimbus.log in secure cluster

2016-07-14 Thread P. Taylor Goetz (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] P. Taylor Goetz reassigned STORM-1968: -- Assignee: Arun Mahadevan (was: P. Taylor Goetz) > Storm logviewer does not work for

[jira] [Commented] (STORM-1968) Storm logviewer does not work for nimbus.log in secure cluster

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377248#comment-15377248 ] ASF GitHub Bot commented on STORM-1968: --- Github user ptgoetz commented on the issue:

[GitHub] storm issue #1563: [STORM-1968] Storm logviewer does not work for nimbus.log...

2016-07-14 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1563 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377244#comment-15377244 ] ASF GitHub Bot commented on STORM-1966: --- Github user ptgoetz commented on the issue:

[GitHub] storm issue #1560: STORM-1966 Expand metric having Map type as value into mu...

2016-07-14 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/1560 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (STORM-1932) Change Duration's value data type

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377216#comment-15377216 ] ASF GitHub Bot commented on STORM-1932: --- Github user darionyaphet commented on a diff in the pull

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70835839 --- Diff: storm-core/src/jvm/org/apache/storm/trident/windowing/config/WindowConfig.java --- @@ -31,13 +31,13 @@ * Returns the length of the

[jira] [Commented] (STORM-1932) Change Duration's value data type

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377193#comment-15377193 ] ASF GitHub Bot commented on STORM-1932: --- Github user darionyaphet commented on a diff in the pull

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70834283 --- Diff: storm-core/src/jvm/org/apache/storm/windowing/CountEvictionPolicy.java --- @@ -26,10 +26,10 @@ * @param the type of event tracked by

Re: Request for reviewing

2016-07-14 Thread Jungtaek Lim
We seems close to make all issues for 1.0.2 epic resolved soon. Epic link: https://issues.apache.org/jira/browse/STORM-1855 All of open issues are in progress of reviewing. Most of them got +1 and is expected to be merged in soon. Is anyone having other critical or blocker issues which need to

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70832297 --- Diff: storm-core/src/jvm/org/apache/storm/topology/base/BaseWindowedBolt.java --- @@ -66,10 +66,14 @@ public String toString() { * Holds a

[jira] [Commented] (STORM-1932) Change Duration's value data type

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377166#comment-15377166 ] ASF GitHub Bot commented on STORM-1932: --- Github user darionyaphet commented on a diff in the pull

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70831175 --- Diff: storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -76,7 +76,7 @@ public WindowedBoltExecutor(IWindowedBolt bolt) {

[jira] [Commented] (STORM-1932) Change Duration's value data type

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377152#comment-15377152 ] ASF GitHub Bot commented on STORM-1932: --- Github user darionyaphet commented on a diff in the pull

Purpose/intent of multilang-javascript module?

2016-07-14 Thread Marc Zbyszynski
Hi There! I'm wondering what the intent of the multilang-javascript module and the storm.js file is ( https://github.com/apache/storm/tree/master/storm-multilang/javascrip). Is this intended as a reference or example implementation of a node.js/storm integration? Or are you intending storm.js to

[jira] [Commented] (STORM-1932) Change Duration's value data type

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377145#comment-15377145 ] ASF GitHub Bot commented on STORM-1932: --- Github user darionyaphet commented on the issue:

[GitHub] storm issue #1527: [STORM-1932] Change Duration's value data type

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1527 @arunmahadevan why don't have `@isLong` ? millisecond using it to decorate is better --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (STORM-1971) HDFS Timed Synchronous Policy

2016-07-14 Thread darion yaphet (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377109#comment-15377109 ] darion yaphet commented on STORM-1971: -- Hi , I checked default.yaml and found

[jira] [Commented] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377113#comment-15377113 ] ASF GitHub Bot commented on STORM-1737: --- Github user hmcl commented on the issue:

[GitHub] storm issue #1556: STORM-1737: storm-kafka-client has compilation errors wit...

2016-07-14 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1556 @harshach @HeartSaVioR @abhishekagarwal87, thank you for your feedback. The updated ReadME, including the added Wildcard Support will be out in a few mins. --- If your project is set up for it, you

[jira] [Commented] (STORM-1968) Storm logviewer does not work for nimbus.log in secure cluster

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377106#comment-15377106 ] ASF GitHub Bot commented on STORM-1968: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm issue #1563: [STORM-1968] Storm logviewer does not work for nimbus.log...

2016-07-14 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1563 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (STORM-1193) supervisor-test error creating symlinks on windows

2016-07-14 Thread Paul Milliken (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377063#comment-15377063 ] Paul Milliken commented on STORM-1193: -- This is occurring in our development environment. We have

[GitHub] storm issue #1563: [STORM-1968] Storm logviewer does not work for nimbus.log...

2016-07-14 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1563 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (STORM-1968) Storm logviewer does not work for nimbus.log in secure cluster

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377070#comment-15377070 ] ASF GitHub Bot commented on STORM-1968: --- Github user harshach commented on the issue:

[GitHub] storm issue #1560: STORM-1966 Expand metric having Map type as value into mu...

2016-07-14 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1560 @harshach Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377062#comment-15377062 ] ASF GitHub Bot commented on STORM-1966: --- Github user HeartSaVioR commented on the issue:

[GitHub] storm pull request #1482: STORM-1876: Option to build storm-kafka and storm-...

2016-07-14 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1482#discussion_r70818175 --- Diff: pom.xml --- @@ -258,6 +258,12 @@ 1.4.0-incubating 2.6.3 2.18.1 + + +0.8.2.1 +

[jira] [Commented] (STORM-1876) Provide option to build storm-kafka against different kafka clients

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377053#comment-15377053 ] ASF GitHub Bot commented on STORM-1876: --- Github user hmcl commented on the issue:

[jira] [Updated] (STORM-1737) storm-kafka-client has compilation errors with Apache Kafka 0.10

2016-07-14 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-1737: Fix Version/s: (was: 1.0.2) Removing fix version and adding to 1.0.2 epic. >

[GitHub] storm issue #1482: STORM-1876: Option to build storm-kafka and storm-kafka-c...

2016-07-14 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1482 +1 besides the neat pick which would be to have the new spout property names prefixed by `storm.kafka.client` property names for consistency. --- If your project is set up for it, you can reply to

[jira] [Commented] (STORM-1876) Provide option to build storm-kafka against different kafka clients

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377044#comment-15377044 ] ASF GitHub Bot commented on STORM-1876: --- Github user hmcl commented on a diff in the pull request:

[jira] [Resolved] (STORM-1959) KafkaPartitionOffsetLag.java does not have license

2016-07-14 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1959. - Resolution: Fixed > KafkaPartitionOffsetLag.java does not have license >

[jira] [Commented] (STORM-1973) Using DefaultTopicSelector to replace StaticTopicSelector

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15377017#comment-15377017 ] ASF GitHub Bot commented on STORM-1973: --- GitHub user darionyaphet opened a pull request:

[jira] [Resolved] (STORM-1960) Add CORS support to STORM UI Rest api

2016-07-14 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1960. - Resolution: Fixed Fix Version/s: (was: 2.0.0) > Add CORS support to STORM UI Rest api

[jira] [Updated] (STORM-1973) Using DefaultTopicSelector to replace StaticTopicSelector

2016-07-14 Thread darion yaphet (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] darion yaphet updated STORM-1973: - Summary: Using DefaultTopicSelector to replace StaticTopicSelector (was: Replace

[jira] [Reopened] (STORM-1959) KafkaPartitionOffsetLag.java does not have license

2016-07-14 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim reopened STORM-1959: - Would like to set epic on this. Reopening. Will resolve issue soon. > KafkaPartitionOffsetLag.java

[GitHub] storm pull request #1567: [STORM-1973] Using DefaultTopicSelector to replace...

2016-07-14 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1567 [STORM-1973] Using DefaultTopicSelector to replace StaticTopicSelector [Using DefaultTopicSelector to replace StaticTopicSelector](https://issues.apache.org/jira/browse/STORM-1973)

[jira] [Created] (STORM-1973) Replace StaticTopicSelector using DefaultTopicSelector

2016-07-14 Thread darion yaphet (JIRA)
darion yaphet created STORM-1973: Summary: Replace StaticTopicSelector using DefaultTopicSelector Key: STORM-1973 URL: https://issues.apache.org/jira/browse/STORM-1973 Project: Apache Storm

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376996#comment-15376996 ] ASF GitHub Bot commented on STORM-1966: --- Github user abhishekagarwal87 commented on the issue:

[GitHub] storm issue #1560: STORM-1966 Expand metric having Map type as value into mu...

2016-07-14 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1560 Thanks @HeartSaVioR . Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376989#comment-15376989 ] ASF GitHub Bot commented on STORM-1966: --- Github user HeartSaVioR commented on the issue:

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376953#comment-15376953 ] ASF GitHub Bot commented on STORM-1966: --- Github user abhishekagarwal87 commented on a diff in the

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376960#comment-15376960 ] ASF GitHub Bot commented on STORM-1966: --- Github user abhishekagarwal87 commented on the issue:

[GitHub] storm issue #1560: STORM-1966 Expand metric having Map type as value into mu...

2016-07-14 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1560 Minor nit regarding variable name. Other than that +1. Please make sure to squash commits before you merge :) --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (STORM-1193) supervisor-test error creating symlinks on windows

2016-07-14 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376963#comment-15376963 ] Jungtaek Lim commented on STORM-1193: - Blobstore feature which is introduced at 1.0.0 heavily uses

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376961#comment-15376961 ] ASF GitHub Bot commented on STORM-1966: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] storm pull request #1560: STORM-1966 Expand metric having Map type as value ...

2016-07-14 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1560#discussion_r70809388 --- Diff: storm-core/src/jvm/org/apache/storm/metric/MetricsConsumerBolt.java --- @@ -43,19 +44,21 @@ OutputCollector _collector;

[GitHub] storm pull request #1560: STORM-1966 Expand metric having Map type as value ...

2016-07-14 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on a diff in the pull request: https://github.com/apache/storm/pull/1560#discussion_r70808499 --- Diff: storm-core/src/jvm/org/apache/storm/metric/MetricsConsumerBolt.java --- @@ -43,19 +44,21 @@ OutputCollector _collector;

[GitHub] storm issue #1560: STORM-1966 Expand metric having Map type as value into mu...

2016-07-14 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1560 Thanks for thoughtful review, @abhishekagarwal87 ! Addressed your review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376932#comment-15376932 ] ASF GitHub Bot commented on STORM-1966: --- Github user HeartSaVioR commented on the issue:

[jira] [Commented] (STORM-1193) supervisor-test error creating symlinks on windows

2016-07-14 Thread Paul Milliken (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376930#comment-15376930 ] Paul Milliken commented on STORM-1193: -- I've just encountered an error which looks very much like

[GitHub] storm issue #1565: STORM-1970: external project examples refator

2016-07-14 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1565 What is it doing ? Do you add more desc ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (STORM-1970) external project examples refator

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376924#comment-15376924 ] ASF GitHub Bot commented on STORM-1970: --- Github user darionyaphet commented on the issue:

[jira] [Commented] (STORM-1971) HDFS Timed Synchronous Policy

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376922#comment-15376922 ] ASF GitHub Bot commented on STORM-1971: --- GitHub user darionyaphet opened a pull request:

[GitHub] storm pull request #1566: [STORM-1971] HDFS Timed Synchronous Policy

2016-07-14 Thread darionyaphet
GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1566 [STORM-1971] HDFS Timed Synchronous Policy [STORM-1971 HDFS Timed Synchronous Policy](https://issues.apache.org/jira/browse/STORM-1971) When the data need to be wrote to HDFS is not

[jira] [Created] (STORM-1972) Storm throws java.lang.ClassNotFoundException on Bolt class

2016-07-14 Thread Ilya Kholinow (JIRA)
Ilya Kholinow created STORM-1972: Summary: Storm throws java.lang.ClassNotFoundException on Bolt class Key: STORM-1972 URL: https://issues.apache.org/jira/browse/STORM-1972 Project: Apache Storm

[jira] [Updated] (STORM-1972) Storm throws java.lang.ClassNotFoundException on Bolt class

2016-07-14 Thread Ilya Kholinow (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Kholinow updated STORM-1972: - Description: I'm trying to debug very simple topology (1 spout 2 bolts) public class

[GitHub] storm pull request #1560: STORM-1966 Expand metric having Map type as value ...

2016-07-14 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1560#discussion_r70804467 --- Diff: storm-core/src/jvm/org/apache/storm/metric/api/IMetricsConsumer.java --- @@ -54,6 +54,25 @@ public String toString() { }

[jira] [Commented] (STORM-1971) HDFS Timed Synchronous Policy

2016-07-14 Thread Aaron Dossett (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376905#comment-15376905 ] Aaron Dossett commented on STORM-1971: -- HDFS bolt does support tick tuples to periodically flush data

[jira] [Created] (STORM-1971) HDFS Timed Synchronous Policy

2016-07-14 Thread darion yaphet (JIRA)
darion yaphet created STORM-1971: Summary: HDFS Timed Synchronous Policy Key: STORM-1971 URL: https://issues.apache.org/jira/browse/STORM-1971 Project: Apache Storm Issue Type: Bug

[jira] [Updated] (STORM-1968) Storm logviewer does not work for nimbus.log in secure cluster

2016-07-14 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim updated STORM-1968: I think this can be included to 1.0.2 as well, since it's already got +1. > Storm logviewer does not

[jira] [Resolved] (STORM-1939) Frequent InterruptedException raised by ShellBoltMessageQueue.poll

2016-07-14 Thread Jungtaek Lim (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jungtaek Lim resolved STORM-1939. - Resolution: Fixed Fix Version/s: 1.1.0 1.0.2 2.0.0

Re: [DISCUSS] Maintaining example topologies for external components

2016-07-14 Thread Xin Wang
Thanks, here is the PR https://github.com/apache/storm/pull/1565. 2016-07-14 12:44 GMT+08:00 Abhishek Agarwal : > Not at all Xin. Please go ahead. > On Jul 14, 2016 7:46 AM, "Xin Wang" wrote: > > > hi Abhishek, > > I have done a lot for this. Do you

[GitHub] storm pull request #1543: STORM-1939 Ignore InterruptedException on ShellBol...

2016-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-1939) Frequent InterruptedException raised by ShellBoltMessageQueue.poll

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376882#comment-15376882 ] ASF GitHub Bot commented on STORM-1939: --- Github user asfgit closed the pull request at:

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376874#comment-15376874 ] ASF GitHub Bot commented on STORM-1966: --- Github user HeartSaVioR commented on a diff in the pull

[GitHub] storm pull request #1560: STORM-1966 Expand metric having Map type as value ...

2016-07-14 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/1560#discussion_r70801243 --- Diff: storm-core/src/jvm/org/apache/storm/metric/api/IMetricsConsumer.java --- @@ -54,6 +54,25 @@ public String toString() { }

[jira] [Commented] (STORM-1966) Expand metric having Map type as value into multiple metrics based on entries

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376872#comment-15376872 ] ASF GitHub Bot commented on STORM-1966: --- Github user HeartSaVioR commented on a diff in the pull

  1   2   >