[GitHub] storm issue #2272: Try fixing travis build by explicitly setting dist and up...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2272 +1 Nice finding. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #2202: STORM-2623: Add in a whitelist for scheduler strategies

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2202 @knusbaum Kindly reminder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request #2248: STORM-2028: Fix for uprooting the JDBC client exce...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2248: STORM-2028: Fix for uprooting the JDBC client exceptions ...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2248 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #2262: STORM-2679: Need to close resources and streams after use

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2262 Post +1 (missed) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm pull request #2262: STORM-2679: Need to close resources and streams af...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #2261: STORM-2678 Improve performance of LoadAwareShuffleGroupin...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2261 I explored and applied more changes: * change ArrayList to pre-allocated array (they're only allocated from `prepare()`) * fixed length of `chooses` length: 1000 * at first I set

[GitHub] storm pull request #2272: Try fixing travis build by explicitly setting dist...

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2272 Try fixing travis build by explicitly setting dist and updating integ… …ration test Zookeeper version It looks like Travis has begun moving builds to Trusty from Precise

[GitHub] storm issue #2271: STORM-2675: Fix storm-kafka-client Trident spout failing ...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2271 Also stumbled on an issue with the way the coordinator and spout communicate, which I've put here https://issues.apache.org/jira/browse/STORM-2691. --- If your project is set up for it, you can

[GitHub] storm pull request #2271: STORM-2675: Fix storm-kafka-client Trident spout f...

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2271 STORM-2675: Fix storm-kafka-client Trident spout failing to serialize meta objects to Zookeeper See https://issues.apache.org/jira/browse/STORM-2675 This builds on

[GitHub] storm issue #2255: [STORM-2672] Expose a metric for calls to reportError()

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2255 @roshannaik Could you please let me know what issues you are talking about? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #2270: [STORM-2686] Add Locality Aware Shuffle Grouping

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2270 The last commit added license to files: LocalityAwareShuffleGrouping.java and LocalityAwareShuffleGroupingTest.java --- If your project is set up for it, you can reply to this email and have your

[GitHub] storm issue #2269: [STORM-2685] Calculate and update taskNetworkDistance in ...

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2269 Close this as it's a subtask of https://github.com/apache/storm/pull/2270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request #2269: [STORM-2685] Calculate and update taskNetworkDista...

Github user Ethanlm closed the pull request at: https://github.com/apache/storm/pull/2269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2270: [STORM-2686] Add Locality Aware Shuffle Grouping

GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2270 [STORM-2686] Add Locality Aware Shuffle Grouping see: https://issues.apache.org/jira/browse/STORM-2686 We want to add a locality aware shuffle grouping to favor the target tasks in closest

[GitHub] storm pull request #2268: STORM-2689: Simplify dependency configuration for ...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2268#discussion_r131997782 --- Diff: examples/storm-kafka-examples/pom.xml --- @@ -24,6 +24,11 @@ 2.0.0-SNAPSHOT ../../pom.xml + +

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2241 I am really nervous about this patch in general and I am still a -1 on it. For me to remove my -1 at a minimum all of the unit tests have to pass and all critical functionality has to be

[GitHub] storm pull request #2269: [STORM-2685] Calculate and update taskNetworkDista...

GitHub user Ethanlm opened a pull request: https://github.com/apache/storm/pull/2269 [STORM-2685] Calculate and update taskNetworkDistance in WorkerState periodically https://issues.apache.org/jira/browse/STORM-2685 Preparing for LocalityAwareShuffleGrouping.

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2241 @roshannaik removing thread safety from the emits is a bug and breaks backwards compatibility. In the past the shuffle grouping was the only one that was not thread safe. Because of this

[GitHub] storm issue #2268: STORM-2689: Simplify dependency configuration for storm-k...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2268 ping @HeartSaVioR and @hmcl since you reviewed https://github.com/apache/storm/pull/2243 and this is related. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request #2268: STORM-2689: Simplify dependency configuration for ...

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2268 STORM-2689: Simplify dependency configuration for storm-kafka-example… …s, storm-kafka-client-examples and storm-elasticsearch-examples See

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2241 I second @roshannaik. We're exposing possibilities as much as possible so that users can compose users' topologies flexible, but as a trade-off we are giving up chances for improving

[GitHub] storm issue #2156: STORM-2549: Fix broken enforcement mechanism for maxUncom...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2156 Rebased again to fix conflicts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2249 Added some tests and updated the docs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2241 **Thread Safety and Bolt/Spout Emits:** @HeartSaVioR & @satishd brought up this topic that is worth discussing in the interest of communicating clearly to users. The basic issue is ...

[GitHub] storm issue #2241: STORM-2306 : Messaging subsystem redesign.

Github user roshannaik commented on the issue: https://github.com/apache/storm/pull/2241 **FYI:** After rebasing to the latest master I see a drop in peak throughput from the original ~8.1mill/sec to ~7.2mill/sec. Lots of changes have come in since the original version of the master