[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70955540 --- Diff: storm-core/src/jvm/org/apache/storm/topology/base/BaseWindowedBolt.java --- @@ -66,10 +66,14 @@ public String toString() { * Holds

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70955173 --- Diff: storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -76,7 +76,7 @@ public WindowedBoltExecutor(IWindowedBolt bolt)

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70835839 --- Diff: storm-core/src/jvm/org/apache/storm/trident/windowing/config/WindowConfig.java --- @@ -31,13 +31,13 @@ * Returns the length of the

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70834283 --- Diff: storm-core/src/jvm/org/apache/storm/windowing/CountEvictionPolicy.java --- @@ -26,10 +26,10 @@ * @param the type of event tracked by

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70832297 --- Diff: storm-core/src/jvm/org/apache/storm/topology/base/BaseWindowedBolt.java --- @@ -66,10 +66,14 @@ public String toString() { * Holds a

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user darionyaphet commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r70831175 --- Diff: storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -76,7 +76,7 @@ public WindowedBoltExecutor(IWindowedBolt bolt) {

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r69674524 --- Diff: storm-core/src/jvm/org/apache/storm/windowing/CountEvictionPolicy.java --- @@ -26,10 +26,10 @@ * @param the type of event tracked by this

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r69674507 --- Diff: storm-core/src/jvm/org/apache/storm/trident/windowing/config/WindowConfig.java --- @@ -31,13 +31,13 @@ * Returns the length of the

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r69674336 --- Diff: storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -117,7 +117,7 @@ private void ensureCountLessThanMaxPending(int

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r69672789 --- Diff: storm-core/src/jvm/org/apache/storm/windowing/CountEvictionPolicy.java --- @@ -26,10 +26,10 @@ * @param the type of event tracked by

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r69672262 --- Diff: storm-core/src/jvm/org/apache/storm/topology/base/BaseWindowedBolt.java --- @@ -66,10 +66,14 @@ public String toString() { * Holds

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1527#discussion_r69671675 --- Diff: storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java --- @@ -76,7 +76,7 @@ public WindowedBoltExecutor(IWindowedBolt bolt)

[GitHub] storm pull request #1527: [STORM-1932] Change Duration's value data type

GitHub user darionyaphet opened a pull request: https://github.com/apache/storm/pull/1527 [STORM-1932] Change Duration's value data type [STORM-1932](https://issues.apache.org/jira/browse/STORM-1932) BaseWindowedBolt Duration value is integer now . Use long to