Hi,
I'm reproducing an email I found interesting on the Git list [0]
especially for those invested in the git-svn effort.
[0]: http://thread.gmane.org/gmane.comp.version-control.git/192801/focus=193737
--
This is the second draft of the SVN branching language. If you're
interested in how SVN
Hi Mark,
Mark Phippard wrote:
On Thu, Mar 29, 2012 at 10:39 AM, Ramkumar Ramachandra
artag...@gmail.com wrote:
[0]:
http://thread.gmane.org/gmane.comp.version-control.git/192801/focus=193737
Isn't this similar to what Eric Raymond has already done?
http://esr.ibiblio.org/?p=4071
Quite
Hi,
Ramkumar Ramachandra wrote:
Quite similar- the difference is that reposurgeon parses the dump
stream to figure out the mapping, while this file format makes no such
effort. Thanks for the pointer nevertheless.
Er, sorry; looks like both of them parse the dumpstream.
Ram
Hi Stefan,
Stefan Sperling writes:
On Wed, Aug 17, 2011 at 01:55:27PM -0400, Mark Phippard wrote:
I could just be basing it on the original proposal. Maybe that planted the
seed with me that it was going to be faster:
http://svn.haxx.se/dev/archive-2010-07/0154.shtml
The proposal says:
Hi,
Guenter Knauf writes:
I would like to suggest adding a commandline switch for svn to
override the native eol style. Why do I want this? On windows
platform the native eol style defaults to CRLF which is usual what
we want. Now if you want to work from MSYS bash shell and want to
check
Hi Daniel,
Daniel Shahaf writes:
CC += artagnon
Ramkumar, I think the lesson from Mike and I's recent fixes is: Mark
unreachable code with a run-time assertion, not with a source comment.
i.e., if those places were marked with SVN__NOT_IMPLEMENTED(), debugging
would have been easier.
Hi,
Stefan Sperling writes:
On Wed, Feb 16, 2011 at 03:08:39PM +, Hyrum K Wright wrote:
This is because the bindings are generated with SWIG.
We cannot really fix this without using a different approach.
We could improve the documentation. An introductory document that
explains how to
Hi Daniel,
On Tue, Jan 25, 2011 at 7:24 PM, Daniel Shahaf d...@daniel.shahaf.name wrote:
In svnrdump_tests.py, nearly all tests are paired --- dump test and
corresponding load test --- except a handful (basic_dump,
only_trunk_dump, only_trunk_A_with_changes_dump,
copy_bad_line_endings_dump).
Hi,
Hyrum K Wright writes:
I'm working on getting a web-based translation system installed on ASF
hardware for use by Subversion, and possibly other projects, and will
report progress here as it happens. I am in the unfortunate position
of being a monoglot, and hence unable to actually do
Hi Julian and Daniel,
Here's another revision after your suggestions on IRC. Thanks.
[[[
Determine default perms in an elegant thread-safe way, not racily.
* subversion/libsvn_subr/io.c
(default_perms_baton, perms_init_state): New struct, variable.
(get_default_file_perms): Remove all
Hi Julian and Daniel,
Julian Foad writes:
Just a few comments on the implementation from me...
Thanks for the wonderful review! I've also included a few of Daniel's
suggestions (on IRC)- I hope I've got it right this time. I'm not sure
the volatile qualifier is necessary either- I'm just using
Hi Daniel,
Daniel Shahaf writes:
If you send another patch that indents/dedents a block, could you please
attach a 'svn diff -x-w' version of the patch too? It would make
reviewing easier.
Sure. Here's the (hopefully) final patch. Sorry about the slopiness
earlier -- I was in a hurry to get
Hi Stefan,
Stefan Sperling writes:
LD_LIBRARY_PATH in the Makefile is only used by targets that are supposed
to run the executables compiled by the Makefile, and need to *dynamically*
load some libraries at run time (e.g. bindings) via dlopen().
This doesn't affect the checkout/export steps
[[[
Makefile.svn: Make stock SVN binary configurable
* tools/dev/unix-build/Makefile.svn: Introduce a new variable
$STOCK_SVN that defaults to `env LD_LIBRARY_PATH= svn`. Change
references to `svn export` and `svn co` to use $STOCK_SVN.
]]]
Index: tools/dev/unix-build/Makefile.svn
Hi Daniel,
Daniel Shahaf writes:
Ping, this doesn't seem to have been fixed yet?
Thanks for the ping, and sorry about the delay. I think this should
work -- I'll write a commit message if you think this is okay.
Index: subversion/libsvn_subr/io.c
Hi Stefan,
Stefan Sperling writes:
On Sat, Jan 08, 2011 at 02:33:46PM +0530, Ramkumar Ramachandra wrote:
[[[
Makefile.svn: Make stock SVN binary configurable
* tools/dev/unix-build/Makefile.svn: Introduce a new variable
$STOCK_SVN that defaults to `env LD_LIBRARY_PATH= svn`. Change
Hi Lieven,
Lieven Govaerts writes:
Yes, what will you be using it for? Any specific ideas?
I originally requested it to run callgraph and heap profilers on
svnrdump. I suppose others can use it to plug leaks and tune the
performance of several other Subversion components.
-- Ram
Hi,
Here's a quick patch to fix Makefile.svn. I need a +1 to commmit this.
Thanks.
[[[
Makefile.svn: Fix build
* tools/dev/unix-build/Makefile.svn: Configure APR to build with
threads enabled to prevent breaking the Subversion build.
]]]
Index: tools/dev/unix-build/Makefile.svn
Hi Eric,
Greg Stein writes:
We have an import/export format that has existed since svn 1.0, and
that is our dumpfile format. I do not think we are required or need
to be shamed into supporting additional formats.
And for what it's worth, a *git* GSoC student wrote a remote dumpfile
Hi Eric,
Eric Raymond writes:
Ramkumar Ramachandra artag...@gmail.com:
Yep, that's completely true. I am that GSoC student, and
subversion/svnrdump is complete. The Subversion community was
supportive of it. And yes, I wrote both dump and load
functionality. So there is some factual
Hi,
Eric Raymond writes:
Ramkumar Ramachandra artag...@gmail.com:
`svnrdump (dump|load)` behaves almost exactly like `svnadmin
(dump|load)` over the network.
What do you mean 'over the network'? Can I get a exported stream on stdout
from the dump mode? Can I feed a stream on stdin
Hi,
I didn't know what else to write, so it's fairly short :p
Thanks.
[[[
community-guide: Add new section referring to ^/tools/dev/unix-build
* publish/docs/community-guide/building.part.html: Add a new
quickstart section pointing users to Makefile.svn
*
Hi,
I need a +1 to commit this. Also, please suggest a better link for the
ASF Infra team (if there is one).
Thanks.
[[[
community-guide: Rewrite the Buildbot section
* publish/docs/community-guide/building.part.html: Remove historical
cruft and update with relevant information.
]]]
Index:
Hi,
Stefan Sperling writes:
The first is that I use OpenBSD and OpenBSD's threading implementation
is a pure userspace implementation. It has to set stdin and stdout to
non-blocking -- otherwise, whenever a thread blocks for i/o in the kernel the
userspace thread-scheduler would also be
Hi Stefan,
Thanks for the suggestions. How about this?
[[[
Makefile.svn: Optionally allow building with threading support
* tools/dev/unix-build/Makefile.svn: Add a new THREADING variable to
control whether APR and sqlite should be built with threading
support.
Suggested by: stsp
Review
Hi,
[+CC: Daniel, for making me notice this email in the first place]
Eric Raymond writes:
My interest in tools for repository surgery has continued, and I recently
spotted an opportunity in the increasing use of git-fast-import streams
as a history-interchange format. I have written what I
Hi Stefan,
Stefan Fuhrmann writes:
Hm. Works here (LINUX ggc 4.3.3 and Win32 MS VisualStudio 2010).
I'll check this -- must be some issue at my end; saw Daniel's response
too. Thanks.
That would be awesome! Any weekend would do ;)
:)
-- Ram
Hi Philip,
Philip Martin writes:
Most of the functions don't share any state between threads, so they
have no atomic issues. svn_io_temp_dir is one of the few that does,
so it uses svn_atomic__init_once. I think the file perms stuff should
also use it.
I see. Could you point me to some
Hi Philip,
[sorry about the delayed reply; was ill]
Philip Martin writes:
Ramkumar Ramachandra artag...@gmail.com writes:
Hm. I read up a little more about this, but what confuses me is-
shouldn't the rest of the code already be needing this?
I don't understand your questions. To what
Hi Philip,
[sorry about the delayed reply: I had a bad internet connection]
Philip Martin writes:
If we are going to use the APR atomic interface then the two reads
should use apr_atomic_read32.
It would be better to use svn_atomic__init_once. It's a clear
indication that we are doing
Hi Bert and Julian,
Bert Huijben writes:
-Original Message-
From: Julian Foad [mailto:julian.f...@wandisco.com]
On Mon, 2010-10-11, Julian Foad wrote:
http://stackoverflow.com/questions/54188/are-c-reads-and-writes-of-
an-int-atomic.
On an IA32 a correctly aligned address
Hi Gavin,
Gavin Beau Baumanis writes:
Ping. This patch has received no comments.
This patch has been committed. See r1003064- the directory baton is
now allocated in `eb-pool`. I hoped that it would fix test 27, but it
didn't- that is fixed in r1005035/ r1005050.
Thanks for picking this up.
Hi Stefan,
Stefan Fuhrmann writes:
I enabled it, but there's still some issue:
subversion/svnadmin/main.c:1892: undefined reference to
`svn_fs_get_cache_config'
It builds here. Did you run autogen.sh before ./configure?
Yep, I did. I tried it several times again; same issue. Is the
Hi Julian,
Julian Foad writes:
Hi Ram. I wasn't comfortable with giving a +1 for this change just
then, but now I've satisfied myself. The only potential negative impact
I can imagine is if a user has a very long-running instance of
Subversion and is accustomed to Subversion tracking
Hi Bert,
Bert Huijben writes:
Do you really need a 'named' file here?
The named file algorithm of svn_io_open_uniquely_named() is very slow
compared to the 'just get me a temporary file' implemented by
svn_io_open_unique_file3(). Especially when you need more than a few
tempfiles with
Hi Julian,
Julian Foad writes:
Looks good to me.
I wondered if it is safe in a long-running Subversion process, like
TortoiseSvn or a Linux equivalent.
It seems to me that it won't really matter much in practice. If someone
changes their umask and finds that Subversion carries on
Hi Stefan,
Stefan Sperling writes:
Can I get an explicit +1 to commit this? I just want to get as many of
Stefan's changes merged in quickly so that there's enough time before
the 1.7 release to test them.
Technical detail: How do I merge?
cd svn-trunk-working-copy
svn merge -c
Hi Stefan,
Stefan Fuhrmann writes:
You obviously don't have APR threads enabled.
Thanks for finding this. Fixed in r1003430.
I enabled it, but there's still some issue:
subversion/svnadmin/main.c:1892: undefined reference to
`svn_fs_get_cache_config'
The server caches almost everything. So,
Hi,
I would like to get r985477 merged into trunk. I've applied and used
it successfully and checked that all tests pass.
Warning: I have no background knowledge. I'm just reviewing the patch
as-it-is, because Stefan asked me to.
[[[
r985477 | stefan2 | 2010-08-14 18:02:04 +0530 (Sat, 14 Aug
Hi,
This is an experimental patch to fix svnrdump test 27 dump:
subdirectory with changes on root on Windows. It's experimental
because it's based simply on a hunch, and I don't have Windows to test
it. Could someone who has Windows test it for me?
Thanks.
Index:
Hi Daniel,
Daniel Shahaf writes:
So, you use a top-level pool but never destroy it?
That's not good.
Can you please find another solution? (Either get the caller to
guarantee something about the lifetime of the pool they provide (there
is precedent for this), or figure out why
Hi Daniel,
Daniel Shahaf writes:
==
--- subversion/trunk/subversion/svnrdump/dump_editor.c (original)
+++ subversion/trunk/subversion/svnrdump/dump_editor.c Wed Sep 29 07:52:55
2010
@@ -143,8 +143,7 @@
Hi Philip,
Philip Martin writes:
The performance of svnrdump is likely to be dominated by IO from the
repository, network or disk depending on the RA layer. strace is a
useful tool to see opens/reads/writes. You can see what order the
calls occur, how many there are, how big they are and
Hi,
I'd like to know what happened to svndiff version 1 format. All the
specs and code including notes/dump-load-format.txt seem to refer only
to svndiff0.
-- Ram
Hi Stefan,
Stefan Fuhrmann writes:
My measurements seem to support what Philip wrote:
The expensive part is run on the server. Even with my
optimized server, the svnrdump CPU usage is less than
the time taken by the server. Some numbers (hot file
cache):
svnadmin dump
1.7 trunk 70s
Hi Daniel,
Daniel Shahaf writes:
$ cat /test.dump
Node-path: test.txt
Node-path: trunk
Node-path: trunk/A
Node-path: trunk/A/B
Node-path: trunk/A/B/E
Node-path: trunk/A/B/E/alpha
Node-path: trunk/A/B/E/beta
Node-path: trunk/A/B/F
Node-path: trunk/A/B/lambda
Node-path:
Hi Stefan,
Stefan Fuhrmann writes:
Under Linux, I'm using Valgrind / Callgrind and visualize in KCachegrind.
That gives me a good idea of what code gets executed too often, how
often a jump (loop or condition) has been taken etc. It will not show the
non-user and non-CPU runtime, e.g. wait
Hi Neels,
Neels J Hofmeyr writes:
On a side note, svnsync happens to be relatively slow. I tried to svnsync
the ASF repos once (for huge test data). The slowness of svnsync made it
practically unfeasible to pull off. I ended up downloading a zipped dump and
'svnadmin load'ing that dump. Even
Hi Stefan,
Stefan Sperling writes:
I don't really mind where svnrdump lives.
The community is committed to supporting both the tools/ and subversion/
directories.
tools and subversion are merely directory names. All I'm saying is
this: I don't want packaging/ distribution overheads for such a
Hi Stefan,
Stefan Sperling writes:
tools and subversion are merely directory names. All I'm saying is
this: I don't want packaging/ distribution overheads for such a simple
package; users should be able to use whatever Subversion-interop tools
that other developers build by just having
Hi Daniel,
Daniel Shahaf writes:
svnsync allows you to sync a subdir of a repository (i.e.,
svnsync $REPOS/trunk/A/B $MIRROR
), but does it also create /trunk/A/B in the mirror?
Yes, it does.
But for now I still think that svnrdump invocation I quoted above
shouldn't have outputted a
Hi Stefan,
Could you tell me which tools you use to profile the various
applications in trunk? I'm looking to profile svnrdump to fix some
perf issues, but OProfile doesn't seem to work for me.
Thanks.
-- Ram
Hi,
Daniel Shahaf writes:
Would svnrdump benefit if, once 1.7.x branched and RC's start being
rolled, it were subjected to a more relaxed backporting policy?
If so, we might consider moving it to tools/ for 1.7.x, with intent to
move it back to subversion/svnrdump/ for 1.8.x (as soon as
Hi,
Daniel Shahaf writes:
I agree that svnrdump does something very useful and that it belongs in
Subversion. But I'm not sure whether it's mature enough today to belong
in subversion/svnrdump/.
svnrdump is still young (less than, how much, 6 months old?). The code
still needs a bit of
Hi Karl,
Karl Heinz Marbaise writes:
i just want to give an other information which i found about the
subject which seemed to be related to the svnrdump tool...
http://rsvndump.sourceforge.net/
Yes, I saw this tool before I decided to write svnrdump. The main
difference is that rsvndump
Hi Daniel,
Daniel Shahaf writes:
Does
svnrdump dump -r 100 https://svn.apache.org/repos/asf/subversion
also produce a deltified dump? (of r100 to its predecessor)
Yes, it does.
Is it currently possible to cause svnrdump to dump rN in full? (like
svnadmin dump --incremental)
Hi Daniel,
Daniel Shahaf writes:
Here's a stab at implementing 'svnrdump dump --incremental'.
It does what 'svn checkout' does to get the first revision --- namely,
calls svn_ra_do_update2() with start_empty=TRUE.
TODO: it passes send_copyfrom_args=TRUE to svn_ra_do_update2(), so it
Hi Daniel,
Daniel Shahaf writes:
Daniel Shahaf wrote on Sat, Sep 25, 2010 at 16:49:08 +0200:
0:/tmp/svn% $svnrdump dump file://$PWD/r1/trunk/A/B 21 | grep Node-path
Node-path: trunk
Node-path: trunk/A
Node-path: trunk/A/B
Node-path: trunk/A/B/E
Node-path:
Hi Daniel,
Daniel Shahaf writes:
Ramkumar Ramachandra wrote on Mon, Sep 20, 2010 at 09:39:57 +0530:
Daniel Shahaf writes:
* ignore Prop-delta... why?
This is because svnrdump outputs Prop-delta: true everytime, whether
it's really a delta or a delta from /dev/null. This is quite
Hi Daniel,
Daniel Shahaf writes:
Ramkumar Ramachandra wrote on Wed, Sep 22, 2010 at 22:24:10 +0530:
Ok, I think you've misunderstood this. Both of them DO dump the exact
same properties. Think of the Prop-delta header as just an extra
cosmetic line. In dumpfile v3, everything is a delta
Hi Daniel,
Daniel Shahaf writes:
It actually makes sense: either there is a parent baton, or I'm
creating the root baton (and therefore the caller passed path=NULL).
Choosing path=NULL to represent the root seems odd to me (that's not
how we usually represent it), but that's for another
Hi again,
Ramkumar Ramachandra writes:
I think you've got your pointers confused. Can you drop the pstrdup(),
see that nothing breaks, and then we can discuss why nothing broke?
Hehe, I wouldn't be surprised if this is the case -- I've been working
with APR pools day and night now :p
Hi,
Daniel Shahaf writes:
abspath is a pointer, lives on the stack, and is passed by value (like
any old int) in function calls. What you allocate from the pool is the
value it points to --- i.e., the two bytes of /.
However, literal string constants are static strings --- they are loaded
Hi Daniel,
Thanks for the review.
Daniel Shahaf writes:
- /* Disallow a path relative to nothing. */
- SVN_ERR_ASSERT_NO_RETURN(!path || pb);
-
Why did you drop this assertion?
I thought about it for a bit, and I can't seem to figure out why I
added it in the first place. My current
Hi,
Daniel Shahaf writes:
Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200:
On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote:
1. Please don't duplicate code.
I think it's fine for svnrdump to have its own copy of this for now.
We could at some point merge
Hi,
I thought this patch might need a little bit of special attention. Let
me know quickly if something is obviously wrong with it- as far as I
know, all tests pass and this patch works as expected. I'm going ahead
and adding lots of tests and fixing whatever bugs there may be shortly.
[[[
Add
Hi,
I've committed this to r998661, but the Subversion bot reports some
breakages. I'm not sure what to make of them though.
-- Ram
Hi Daniel,
Daniel Shahaf writes:
+# Mismatched headers during dumping operation
+mismatched_headers_re = \
+Prop-delta: |Text-content-sha1: |Text-copy-source-md5: | \
+Text-copy-source-sha1: |Text-delta-base-sha1: .*
+
So:
* ignore sha1 because RA doesn't provide it yet
Hi Daniel,
Daniel Shahaf writes:
Ramkumar Ramachandra wrote on Sun, Sep 19, 2010 at 16:52:50 +0530:
Daniel Shahaf writes:
Stefan Sperling wrote on Sun, Sep 19, 2010 at 11:40:49 +0200:
On Sun, Sep 19, 2010 at 10:29:58AM +0100, Daniel Shahaf wrote:
2. If you do duplicate code
Hi Vijayguru,
Vijayaguru Guruchave writes:
'svnrdump dump -r n URL' dumps the revisions from 'n' to HEAD.The attached
patch dumps the single specified revision alone.
[[[
Log:
svnrdump to dump the single specified revision.
* subversion/svnrdump/svnrdump.c
(main): Dump the
Hi Daniel,
Daniel Shahaf writes:
From IRC logs...
09:53 @danielsh wayita: tell artagnon
http://colabti.org/irclogger/irclogger_log/svn-dev?date=2010-08-20#l83 ---
has that been resolved?
(can't find any record in mail/irc archives)
So, do you remember what that race
Hi Daniel,
Daniel Shahaf writes:
Ping. Was the 'race condition' I mentioned in my other mail related to
'svnrdump load' setting revprop (which may fail if a hook hadn't been
set up)?
Yep. I have to try setting some dummy revprop and barf out quickly
before getting caught up in between real
Hi Julian,
Julian Foad writes:
On Thu, 2010-08-19 at 10:25 +0300, Daniel Shahaf wrote:
Ramkumar Ramachandra wrote on Thu, Aug 19, 2010 at 11:12:14 +0530:
Hi,
I sent a patch a while ago for svn_repos_parse_dumpstream3. While I
wait for approval, this is an RFC patch describing my
Hi Daniel,
Daniel Shahaf writes:
- SVN_ERR(svn_repos_parse_dumpstream2(stream, parser, parse_baton,
- NULL, NULL, pool));
+ SVN_ERR(svn_repos_parse_dumpstream3(stream, parser, parse_baton,
+ NULL, NULL,
+
Hi Daniel,
Daniel Shahaf writes:
That patch is still an RFC, and it's unlikely to be approved soon I
think. If I were able to send a series, it would roughly look like
this:
1. Create parse_dumpstream3 to include the logic for checking equality
in version.
2. Note the lack of
Hi Hyrum,
Hyrum K. Wright writes:
+ * If @a version_number is -1, it is ignored and the dumpstream is
+ * parsed without this information. If not -1, the function checks the
We try to avoid magic numbers. Is there a #define or constant
somewhere that you could use? If not, I'd add a
Hi Daniel,
Daniel Shahaf writes:
- * @since New in 1.1.
+ * @since New in 2.0.
s/2.0/1.7/
Fixed.
+/**
+ * Similar to svn_repos_parse_dumpstream3(), but is dumpfile version
+ * agnostic.
+ *
Perhaps say: with @a version_number always set to -1 ?
Fixed, along with Hyrum's
Hi,
I sent a patch a while ago for svn_repos_parse_dumpstream3. While I
wait for approval, this is an RFC patch describing my future plan once
that patch gets approved. It can be described tersely as While at it
(adding the new callback), fix everything that's wrong with the
struct. I'm planning
[[[
* subversion/libsvn_repos/load.c
(svn_repos_parse_dumpstream2, svn_repos_parse_dumpstream3): Rename
the older function and add a version_number argument; error out if
there's a version mismatch.
* subversion/include/svn_repos.h
(svn_repos_parse_dumpstream2,
Hi Daniel,
Daniel Shahaf writes:
Ramkumar Ramachandra wrote on Thu, Aug 12, 2010 at 12:17:34 +0530:
The dump functionality is also complete- thanks to Stefan's review and
MANY others for cleaning it up. It's however hit a brick wall now
because of missing headers in the RA layer
Hi Hyrum,
Hyrum K. Wright writes:
On Sun, Aug 1, 2010 at 1:17 AM, Ramkumar Ramachandra artag...@gmail.com
wrote:
Hi,
I've found that I need the functionality to change a repository's UUID
over the RA layer in 'svnrdump load' (see my recently committed tests
to see why). I initially
Hi Bert,
Bert Huijben writes:
copyfrom_path is probably relative from the repository or session root (not
sure which in your case). You are now appending the basename of
a/paths/basename and then joining the copyfrom_path after it. Shouldn't that
be the other way around?
Really silly
Hi Daniel,
Daniel Shahaf writes:
It's been a few weeks since I got partial committer access, and ~80
commits later, this is what we have:
Firstly, thanks to Daniel for motivating me and driving me to submit
the series to the list, and guiding me through everything. Without
him, I'd
Hi Daniel,
Daniel Shahaf writes:
Ramkumar, I've noticed before in your patches that they tend to have
multiple separable parts, and this commit is a good opportunity to explain:
Thanks for the review.
if (strcmp(hname, SVN_REPOS_DUMPFILE_NODE_COPYFROM_REV) == 0)
Hi Daniel,
Daniel Shahaf writes:
artag...@apache.org wrote on Sat, Aug 07, 2010 at 12:31:50 -:
Author: artagnon
Date: Sat Aug 7 12:31:50 2010
New Revision: 983222
URL: http://svn.apache.org/viewvc?rev=983222view=rev
Log:
svnrdump: Fix a bug in the load_editor; it was unable
Hi Daniel,
Daniel Shahaf writes:
The implementation should be trivial (over ra_local and ra_svn; probably
over ra_dav too but I don't know that one as well). But what about authz
concerns?
Do you want to allow any authenticated user to change the repository UUID?
No, this doesn't make
Hi Greg,
Greg Stein writes:
Why would an admin install a hook to allow changing a UUID? Why would
a UUID be allowed to change over time? If a UUID is supposed to be
changed, then why wouldn't that admin just do it himself? Why does
this have to be allowed remotely?
Agreed- this feature has a
Hi Kamesh and Philip,
Philip Martin writes:
Kamesh Jayachandran kam...@collab.net writes:
On 07/26/2010 07:25 PM, artag...@apache.org wrote:
Author: artagnon
Date: Mon Jul 26 13:55:25 2010
New Revision: 979282
URL: http://svn.apache.org/viewvc?rev=979282view=rev
Log:
svnrdump:
Hi Hyrum,
Hyrum K. Wright writes:
I don't think that easy of typing into the debugger should be a
primary qualification for API naming conventions...
Hehe, ofcourse. I just meant to say that I'll save the formal naming
until I get past the point where the program can go a few seconds
without
Hi Daniel,
Daniel Shahaf writes:
Ramkumar Ramachandra wrote on Sun, Aug 01, 2010 at 11:47:51 +0530:
However, Daniel asked me not to expect this and start working on a branch
instead after notifying the list-
No, I didn't ask you to notify the list; I asked you to start a design
Hi Bert,
Bert Huijben writes:
But I think you forget that before creating a commit editor that user had to
setup an ra session. And every ra session allows retrieving the repository
root (in most cases it is even cached before the first ra operation). So you
can just store this in the initial
Hi,
I've found that I need the functionality to change a repository's UUID
over the RA layer in 'svnrdump load' (see my recently committed tests
to see why). I initially planned to put this off until functionality
until someone thinks I'm capable of handling this and gets me commit
access to
Hi,
The patch should be pretty much self-explanatory. It makes no sense
for the caller of the commit editor to find out the repository's URL.
This information is actually accessible but hidden inside the
`edit_baton` structure; but this structure is not public and the
caller simply sees a void
Hi,
Ramkumar Ramachandra writes:
The patch should be pretty much self-explanatory. It makes no sense
for the caller of the commit editor to find out the repository's URL.
This information is actually accessible but hidden inside the
`edit_baton` structure; but this structure is not public
Hi,
Ramkumar Ramachandra writes:
[[[
Followup r979295 to handle the expected_is_regexp case in
display_lines.
* subversion/tests/cmdline/svntest/verify.py
(display_lines): When expected is a string and not a list (in the
expected_in_regexp case), put it in a one-member list, and don't
Hi,
Ramkumar Ramachandra writes:
[[[
svnrdump: Add new copy-and-modify test.
* subversion/tests/cmdline/svnrdump_tests_data/copy-and-modify.dump:
Add a new testdata to be used by the copy_and_modify test in
svnrdump. Taken originally from svnsync_test_data/ and converted to
dumpfile
[[[
svnrdump: Add new copy-and-modify test.
* subversion/tests/cmdline/svnrdump_tests_data/copy-and-modify.dump:
Add a new testdata to be used by the copy_and_modify test in
svnrdump. Taken originally from svnsync_test_data/ and converted to
dumpfile v3 format.
*
[[[
Followup r979295 to handle the expected_is_regexp case in
display_lines.
* subversion/tests/cmdline/svntest/verify.py
(display_lines): When expected is a string and not a list (in the
expected_in_regexp case), put it in a one-member list, and don't
output a diff.
Found by: rhuijben
]]]
Hi Daniel,
Ramkumar Ramachandra writes:
Daniel Shahaf writes:
I suggest
fromfile=EXPECTED %s % label,
tofile=ACTUAL %s % label,
Do I get a +1 for this?
I just got one from Bert. Committed in r979710.
Thanks.
-- Ram
Hi,
Ramkumar Ramachandra writes:
The tests in svnsync_tests_data/ are in dumpfile v2 and these are
unsuitable for testing svnrdump. Hence, load all of them into a
repository and re-dump them in dumpfile v3 format before attempting to
add them to svnrdump_tests_data/. I still have to figure
1 - 100 of 184 matches
Mail list logo
