Re: Getting to first release of pristines-on-demand feature (#525).

2024-01-18 Thread Evgeny Kotkov via dev
Evgeny Kotkov writes: > Merged in https://svn.apache.org/r1905955 > > I'm going to respond on the topic of SHA1 a bit later. For the history: thread [1] proposes the `pristine-checksum-salt` branch that adds the infrastructure to support new pristine checksum kinds in the working copy and makes

Re: Switching from SHA1 to a checksum type without known collisions in 1.15 working copy format (was: Re: Getting to first release of pristines-on-demand feature (#525).)

2022-12-20 Thread Daniel Shahaf
Evgeny Kotkov via dev wrote on Tue, Dec 20, 2022 at 11:14:00 +0300: > [Moving discussion to a new thread] > > We currently have a problem that a working copy relies on the checksum type > with known collisions (SHA1). A solution to that problem Why is libsvn_wc's use of SHA-1 a problem? What's

Re: Switching from SHA1 to a checksum type without known collisions in 1.15 working copy format (was: Re: Getting to first release of pristines-on-demand feature (#525).)

2022-12-20 Thread Branko Čibej
On 20.12.2022 09:14, Evgeny Kotkov wrote: 2) We already need a working copy format bump for the pristines-on-demand feature. So using that format bump to solve the SHA1 issue might reduce the overall number of required bumps for users (assuming that we'll still need to switch from

Switching from SHA1 to a checksum type without known collisions in 1.15 working copy format (was: Re: Getting to first release of pristines-on-demand feature (#525).)

2022-12-20 Thread Evgeny Kotkov via dev
Karl Fogel writes: > > While here, I would like to raise a topic of incorporating a switch from > > SHA1 to a different checksum type (without known collisions) for the new > > working copy format. This topic is relevant to the pristines-on-demand > > branch, because the new "is the file

Re: Getting to first release of pristines-on-demand feature (#525).

2022-12-13 Thread Karl Fogel
On 13 Dec 2022, Evgeny Kotkov wrote: Evgeny Kotkov writes: Merged in https://svn.apache.org/r1905955 W00t!! Thank you, and Julian and Daniel and everyone who's contributed to this. So... do we have a release manager? :-)

Re: Getting to first release of pristines-on-demand feature (#525).

2022-12-13 Thread Evgeny Kotkov via dev
Evgeny Kotkov writes: > I think that the `pristines-on-demand-on-mwf` branch is now ready for a > merge to trunk. I could do that, assuming there are no objections. Merged in https://svn.apache.org/r1905955 I'm going to respond on the topic of SHA1 a bit later. Thanks, Evgeny Kotkov

Re: Getting to first release of pristines-on-demand feature (#525).

2022-12-10 Thread Daniel Shahaf
Nathan Hartman wrote on Wed, Dec 07, 2022 at 20:29:11 -0500: > On Wed, Dec 7, 2022 at 12:11 PM Evgeny Kotkov via dev < > dev@subversion.apache.org> wrote: > > > > > I think that the `pristines-on-demand-on-mwf` branch is now ready for a > > merge to trunk. I could do that, assuming there are no

Re: Getting to first release of pristines-on-demand feature (#525).

2022-12-07 Thread Nathan Hartman
On Wed, Dec 7, 2022 at 12:11 PM Evgeny Kotkov via dev < dev@subversion.apache.org> wrote: > > I think that the `pristines-on-demand-on-mwf` branch is now ready for a > merge to trunk. I could do that, assuming there are no objections. I'd like to echo what others have already said by saying a

Re: Getting to first release of pristines-on-demand feature (#525).

2022-12-07 Thread Karl Fogel
On 07 Dec 2022, Evgeny Kotkov wrote: The branch passes all tests in my Windows and Linux environments, in both --store-pristine=yes and =no modes. FYI, it passes all tests here too (on Debian GNU/Linux, up-to-date 'testing' distro). Attached file has details; there were some XFAILs, but no

Re: Getting to first release of pristines-on-demand feature (#525).

2022-12-07 Thread Karl Fogel
On 07 Dec 2022, Evgeny Kotkov wrote: Evgeny Kotkov writes: I think that the `pristines-on-demand-on-mwf` branch is now ready for a merge to trunk. I could do that, assuming there are no objections. +1, and thank you. Now, I haven't had time to do a real code review -- my manager hat

Re: Getting to first release of pristines-on-demand feature (#525).

2022-12-07 Thread Daniel Sahlberg
Evgeny, Thanks so much for your hard work in pushing this project forward! I don't think I can contribute much in getting this merged to trunk (from lack of C experience and lack of time to dig into the inner workings), but I hope it can be completed! Kind regards, Daniel Sahlberg Den ons 7

Re: Getting to first release of pristines-on-demand feature (#525).

2022-12-07 Thread Evgeny Kotkov via dev
Evgeny Kotkov writes: > > IMHO, once the tests are ready, we could merge it and release > > it to the world. > > Apart from the required test changes, there are some technical > TODOs that remain from the initial patch and should be resolved. > I'll try to handle them as well. I think that the

Re: Getting to first release of pristines-on-demand feature (#525).

2022-12-01 Thread Karl Fogel
On 29 Nov 2022, Johan Corveleyn wrote: My thanks also to the courageous people having developed this, and the gentle souls keeping the ball rolling :-). About the name: [...] FWIW, my vote still goes to --store-pristines={yes|no} Same here, FWIW. I understand the argument that this

Re: Getting to first release of pristines-on-demand feature (#525).

2022-11-29 Thread Johan Corveleyn
My thanks also to the courageous people having developed this, and the gentle souls keeping the ball rolling :-). About the name: On Thu, Nov 24, 2022 at 3:57 PM Nathan Hartman wrote: ... > Previously we got stuck trying to choose the user-facing name of this > feature and its command line

Re: Getting to first release of pristines-on-demand feature (#525).

2022-11-24 Thread Nathan Hartman
On Wed, Nov 23, 2022 at 9:53 AM Julian Foad wrote: > Nathan, I see you replied enthusiastically and mentioned "I have much to > say on both of these [TODOs] but I won't go into detail yet...". It > seems to me it could be helpful to get that started sooner rather than > later, too, if those

Re: Getting to first release of pristines-on-demand feature (#525).

2022-11-23 Thread Julian Foad
I'm glad to see you all picking up this project again. While working on this at the beginning of the year I turned on the pristines-on-demand mode in some of my own WCs such as my 'Documents' tree which includes lots of scanned paper docs. It works nicely for cases like this, and feels right, the

Re: Getting to first release of pristines-on-demand feature (#525).

2022-11-16 Thread Karl Fogel
On 16 Nov 2022, Evgeny Kotkov wrote: Apart from the required test changes, there are some technical TODOs that remain from the initial patch and should be resolved. I'll try to handle them as well. Thank you!

Re: Getting to first release of pristines-on-demand feature (#525).

2022-11-16 Thread Evgeny Kotkov via dev
Karl Fogel writes: > Thank you, Evgeny! Just to make sure I understand correctly -- > the status now on the 'pristines-on-demand-on-mwf' branch is: > > 1) One can do 'svn checkout --store-pristines=no' to get an > entirely pristine-less working copy. In that working copy, > individual files

Re: Getting to first release of pristines-on-demand feature (#525).

2022-11-15 Thread Karl Fogel
On 15 Nov 2022, Evgeny Kotkov wrote: Evgeny Kotkov writes: Perhaps we could transition into that state by committing the patch and maybe re-evaluate things from there. I could do that, assuming no objections, of course. Committed the patch in https://svn.apache.org/r1905324 I'll try to

Re: Getting to first release of pristines-on-demand feature (#525).

2022-11-15 Thread Evgeny Kotkov via dev
Evgeny Kotkov writes: > Perhaps we could transition into that state by committing the patch > and maybe re-evaluate things from there. I could do that, assuming > no objections, of course. Committed the patch in https://svn.apache.org/r1905324 I'll try to handle the related tasks in the near

Re: Getting to first release of pristines-on-demand feature (#525).

2022-11-08 Thread Evgeny Kotkov via dev
Karl Fogel writes: > By the way, in that thread, Evgeny Kotkov -- whose initial work > much of this is based on -- follows up with a patch that does a > first-pass implementation of 'svn checkout --store-pristines=no' > (by implementing a new persistent setting in wc.db). Perhaps we could

Re: Getting to first release of pristines-on-demand feature (#525).

2022-11-06 Thread Nathan Hartman
On Sat, Nov 5, 2022 at 6:13 PM Karl Fogel wrote: > > Hi, all. This is a high-level mail in which I try to figure out > the current status of the issue #525 work and what's left to land > it in trunk and release it. Corrections and feedback welcome. Thanks for the overview and the work already