Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-10 Thread Stefan Sperling
On Mon, Aug 09, 2010 at 09:45:18PM +0300, Daniel Shahaf wrote: Also, this isn't really related to performance; it belongs on /trunk. Next time, you could send this with a [PATCH] marker in the subject line, and a full committer could +1 you to commit that to directly to /trunk. Yes, please

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-10 Thread Stefan Sperling
On Tue, Aug 10, 2010 at 12:56:19PM +0200, Stefan Sperling wrote: On Mon, Aug 09, 2010 at 09:45:18PM +0300, Daniel Shahaf wrote: Also, this isn't really related to performance; it belongs on /trunk. Next time, you could send this with a [PATCH] marker in the subject line, and a full

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Julian Foad
On Mon, 2010-08-09, danie...@apache.org wrote: +/** Return TRUE if @a err's chain contains the error code @a apr_err. + * + * @since New in 1.7. + */ +svn_boolean_t +svn_error_has_cause(svn_error_t *err, apr_status_t apr_err); This looks like it could be a useful API. I would expect to

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Daniel Shahaf
(I intended to commit that to trunk) Julian Foad wrote on Tue, Aug 10, 2010 at 12:17:24 +0100: On Mon, 2010-08-09, danie...@apache.org wrote: +/** Return TRUE if @a err's chain contains the error code @a apr_err. + * + * @since New in 1.7. + */ +svn_boolean_t

Re: svn commit: r983720 - in /subversion/trunk/subversion: libsvn_client/repos_diff.c tests/cmdline/diff_tests.py

2010-08-10 Thread Julian Foad
On Mon, 2010-08-09, sbut...@apache.org wrote: Fix issue 2333 diff URL1 URL2 not reverse of diff URL2 URL1. When the repository reports a deleted directory, recursively walk the directory (in the repository) and report files as deleted. TODO: Handle non-infinite depth correctly. Review

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Julian Foad
On Tue, 2010-08-10 at 15:04 +0300, Daniel Shahaf wrote: (I intended to commit that to trunk) Julian Foad wrote on Tue, Aug 10, 2010 at 12:17:24 +0100: On Mon, 2010-08-09, danie...@apache.org wrote: +/** Return TRUE if @a err's chain contains the error code @a apr_err. + * + *

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Daniel Shahaf
Julian Foad wrote on Tue, Aug 10, 2010 at 13:48:20 +0100: On Tue, 2010-08-10 at 15:04 +0300, Daniel Shahaf wrote: I can see several options: * forbid passing SVN_NO_ERROR * return FALSE on SVN_NO_ERROR * reture (apr_err == APR_SUCCESS ? TRUE : FALSE) on SVN_NO_ERROR Right now, the

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-10 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Aug 10, 2010 at 13:06:43 +0200: On Tue, Aug 10, 2010 at 12:56:19PM +0200, Stefan Sperling wrote: On Mon, Aug 09, 2010 at 09:45:18PM +0300, Daniel Shahaf wrote: Also, this isn't really related to performance; it belongs on /trunk. Next time, you could

Re: svn commit: r983766 - /subversion/branches/performance/subversion/libsvn_client/export.c

2010-08-10 Thread Hyrum K. Wright
On Tue, Aug 10, 2010 at 5:56 AM, Stefan Sperling s...@elego.de wrote: On Mon, Aug 09, 2010 at 09:45:18PM +0300, Daniel Shahaf wrote: Also, this isn't really related to performance; it belongs on /trunk.  Next time, you could send this with a [PATCH] marker in the subject line, and a full

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Julian Foad
On Tue, 2010-08-10, Daniel Shahaf wrote: Julian Foad wrote on Tue, Aug 10, 2010 at 13:48:20 +0100: On Tue, 2010-08-10 at 15:04 +0300, Daniel Shahaf wrote: I can see several options: * forbid passing SVN_NO_ERROR * return FALSE on SVN_NO_ERROR * reture (apr_err == APR_SUCCESS ?

Upgrade to single-DB: problem locking an empty DB

2010-08-10 Thread Julian Foad
Upgrading a WC to single-DB: upgrade_to_wcng() calls svn_wc__db_upgrade_begin() to create a new DB, and then svn_wc__db_wclock_obtain() and then svn_wc__write_upgraded_entries() The _wclock_obtain() fails because it checks that the node with relpath exists. Normally in libsvn_wc a new

repository corruption by svnadmin upgrade

2010-08-10 Thread Vincent Lefevre
I've posted messages about the following problem in the users list, but here's other information. After a svnadmin upgrade with svn version 1.5.1 (r32289), which terminated without any error, and svn-populate-node-origins-index, the repository got corrupted: /svnroot/mpfr/db/format now contains:

Re: Upgrade to single-DB: problem locking an empty DB

2010-08-10 Thread Julian Foad
On Tue, 2010-08-10 at 15:31 +0100, Julian Foad wrote: Upgrading a WC to single-DB: upgrade_to_wcng() calls svn_wc__db_upgrade_begin() to create a new DB, and then svn_wc__db_wclock_obtain() and then svn_wc__write_upgraded_entries() The _wclock_obtain() fails because it checks

Re: Upgrade to single-DB: problem locking an empty DB

2010-08-10 Thread Julian Foad
On Tue, 2010-08-10 at 16:26 +0100, Julian Foad wrote: On Tue, 2010-08-10 at 15:31 +0100, Julian Foad wrote: Upgrading a WC to single-DB: upgrade_to_wcng() calls svn_wc__db_upgrade_begin() to create a new DB, and then svn_wc__db_wclock_obtain() and then

RE: Bikeshed: configuration override order

2010-08-10 Thread Bolstridge, Andrew
Summary... There are two issues here... 1. The repo admin wants to enforce what is commited to their repo. This exists with scripts but common request can be made inherient repo settings (probably need to be path based). The issue with pre-commit hooks is that they are run after all

Re: buildbot failure in ASF Buildbot on svn-x64-centos gcc

2010-08-10 Thread Greg Stein
What is up with these authz failures? It seems the buildbots have been failing miserably over the past couple weeks. Is nobody looking at and correcting the failures? On Tue, Aug 10, 2010 at 11:58, build...@apache.org wrote: The Buildbot has detected a new failure of svn-x64-centos gcc on ASF

Re: Bikeshed: configuration override order

2010-08-10 Thread C. Michael Pilato
On 08/10/2010 12:15 PM, Julian Foad wrote: On Tue, 2010-08-10 at 17:12 +0100, Bolstridge, Andrew wrote: Summary... There are two issues here... 1. The repo admin wants to enforce what is commited to their repo. This exists with scripts but common request can be made inherient repo

Re: Bikeshed: configuration override order

2010-08-10 Thread C. Michael Pilato
On 08/10/2010 01:10 PM, C. Michael Pilato wrote: On 08/10/2010 12:15 PM, Julian Foad wrote: On Tue, 2010-08-10 at 17:12 +0100, Bolstridge, Andrew wrote: Summary... There are two issues here... 1. The repo admin wants to enforce what is commited to their repo. This exists with scripts but

Re: buildbot failure in ASF Buildbot on svn-x64-centos gcc

2010-08-10 Thread Hyrum K. Wright
The general ambivalence toward buildbot failures on the 1.6.x branch is due (at least for me) to the fact that some of the build slaves aren't configured to properly build the branch, so they *always* fail. However, I can reproduce the authz failure on the 1.6.x branch, which is a bit

RE: Bikeshed: configuration override order

2010-08-10 Thread Bob Archer
Summary... There are two issues here... 1. The repo admin wants to enforce what is commited to their repo. This exists with scripts but common request can be made inherient repo settings (probably need to be path based). The issue with pre-commit hooks is that they are run

Re: Bikeshed: configuration override order

2010-08-10 Thread C. Michael Pilato
On 08/10/2010 01:25 PM, Julian Foad wrote: Oh? All I know about Andrew's particular requirements related to this query is what's quoted above - If I ... accidentally leave the banned buildlog.htm file in ... - which sounded vaguely like a requirement for a path-based rule. Maybe I missed

Re: Bikeshed: configuration override order

2010-08-10 Thread Stefan Sperling
On Tue, Aug 10, 2010 at 06:25:15PM +0100, Julian Foad wrote: All I know about Andrew's particular requirements related to this query is what's quoted above - If I ... accidentally leave the banned buildlog.htm file in ... - which sounded vaguely like a requirement for a path-based rule. Maybe

Re: Bikeshed: configuration override order

2010-08-10 Thread C. Michael Pilato
On 08/07/2010 12:18 PM, Greg Hudson wrote: My thinking about repository configuration is that the uses cases should be divided into two categories: 1. Stuff that isn't really client configuration at all, like auto-props, should come from the repository instead, and should only come from

Re: RFC: How should revert handle copied/added items?

2010-08-10 Thread Paul Burba
On Tue, Aug 10, 2010 at 12:18 AM, Greg Stein gst...@gmail.com wrote: Greg and Peter, Thanks for your views on this topic. A few comments/questions below. On Mon, Aug 9, 2010 at 12:54, Paul Burba ptbu...@gmail.com wrote: We have several issues related to the question of how revert should

RE: Bikeshed: configuration override order

2010-08-10 Thread Bob Archer
On 08/07/2010 12:18 PM, Greg Hudson wrote: My thinking about repository configuration is that the uses cases should be divided into two categories: 1. Stuff that isn't really client configuration at all, like auto-props, should come from the repository instead, and should only come

Re: Bikeshed: configuration override order

2010-08-10 Thread Greg Hudson
On Tue, 2010-08-10 at 14:24 -0400, C. Michael Pilato wrote: The foremost bit of client configuration that CollabNet's Subversion customers are demanding (besides auto-props, which I think we all agree on) is a way for the server to set a policy which dictates that clients may not use plaintext

Re: RFC: How should revert handle copied/added items?

2010-08-10 Thread Greg Stein
On Tue, Aug 10, 2010 at 14:41, Paul Burba ptbu...@gmail.com wrote: On Tue, Aug 10, 2010 at 12:18 AM, Greg Stein gst...@gmail.com wrote: ... For example, $ svn cp A/B C $ svn revert C/D/file That should error. $ svn revert C Should succeed, and undo the copy that was made. Since we

Re: NODE_DATA (2nd iteration)

2010-08-10 Thread Greg Stein
I'll work on reviewing this stuff. I believe there are quite a few details that need to be worked out (like exact presence values). Cheers, -g On Tue, Aug 10, 2010 at 12:18, Julian Foad julian.f...@wandisco.com wrote: Any responses would be greatly appreciated. - Julian On Tue, 2010-08-03,

Bug in svn_fs_paths_changed2() Python bindings?

2010-08-10 Thread Alexey Neyman
Hi all, Looks like the binding for svn_fs_paths_changed2() incorrectly specifies the type of structures contained in the hash it returns: the following code s = fs.paths_changed2(rev_root, pool) for i in s: sys.stderr.write(%s = %s\n % (i, repr(s))) indicates that bindings assume the hash to

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

2010-08-10 Thread Daniel Shahaf
Julian Foad wrote on Tue, Aug 10, 2010 at 14:33:24 +0100: On Tue, 2010-08-10, Daniel Shahaf wrote: +++ subversion/libsvn_subr/error.c (working copy) @@ -274,9 +274,8 @@ { svn_error_t *child; - if (! err ! apr_err) -/* The API doesn't specify the behaviour when ERR is

Re: repository corruption by svnadmin upgrade

2010-08-10 Thread Daniel Shahaf
Vincent Lefevre wrote on Tue, Aug 10, 2010 at 17:21:50 +0200: I've posted messages about the following problem in the users list, but here's other information. After a svnadmin upgrade with svn version 1.5.1 (r32289), which terminated without any error, and svn-populate-node-origins-index,

Re: svnrdump: The BIG update

2010-08-10 Thread Daniel Shahaf
Ramkumar Ramachandra wrote on Tue, Aug 10, 2010 at 19:32:34 +0530: Hi, I've been putting this off for some time now- it's so much easier to write code than to write English :p Anyway, here it is- a massive status update. Thanks for the update. It's been a few weeks since I got partial

Re: Looking to improve performance of svn annotate

2010-08-10 Thread Johan Corveleyn
Hi all, Other priorities have unfortunately kept me from focusing on the project of speeding up blame. But recently I've spent some time thinking about it, reading the other mail threads, studying the code and profiling a little bit. I hope I can still do something useful for blame, whether it be

Re: Bug in svn_fs_paths_changed2() Python bindings?

2010-08-10 Thread Alexey Neyman
Small update to the patch: change doxygen comment to match new argument name. Regards, Alexey. On Tuesday, August 10, 2010 02:53:50 pm Alexey Neyman wrote: Hi all, Looks like the binding for svn_fs_paths_changed2() incorrectly specifies the type of structures contained in the hash it

[atomic-revprops] status update

2010-08-10 Thread Daniel Shahaf
For the last few weeks I've been working on the atomic-revprop branch. (Its goal is port the new svn_fs_change_rev_prop2() to libsvn_ra, which should allow callers to specify both a value and an optional previous value and have the revprop change atomic; see [1].) Currently, the API is

Re: [atomic-revprops] status update

2010-08-10 Thread Daniel Shahaf
(hitted send too soon) Daniel Shahaf wrote on Wed, Aug 11, 2010 at 03:40:51 +0300: For the last few weeks I've been working on the atomic-revprop branch. (Its goal is port the new svn_fs_change_rev_prop2() to libsvn_ra, which should allow callers to specify both a value and an optional

Re: [atomic-revprops] status update

2010-08-10 Thread Hyrum K. Wright
On Tue, Aug 10, 2010 at 7:51 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: (hitted send too soon) Daniel Shahaf wrote on Wed, Aug 11, 2010 at 03:40:51 +0300: For the last few weeks I've been working on the atomic-revprop branch. (Its goal is port the new svn_fs_change_rev_prop2() to

Re: [atomic-revprops] status update

2010-08-10 Thread Daniel Shahaf
Hyrum K. Wright wrote on Tue, Aug 10, 2010 at 20:10:54 -0500: Do you think the work is sufficiently non-disruptive to be moved back to trunk? Yes. Updated plan: I'll do the marshal error codes in ra_dav work on trunk, re-test/review the status of the ra_dav part of the branch, and merge the

NOTICE: Testing over ra-dav has changed in trunk!!

2010-08-10 Thread C. Michael Pilato
Per the commit's log message: On 08/10/2010 09:38 PM, cmpil...@apache.org wrote: Author: cmpilato Date: Wed Aug 11 01:38:40 2010 New Revision: 984280 [...] NOTE: The test suite changes brought in by this merge require modifications to developers' httpd.conf files. So if you see the

Re: svn commit: r984280 - in /subversion/trunk: ./ subversion/include/ subversion/libsvn_client/ subversion/libsvn_ra/ subversion/libsvn_ra_local/ subversion/libsvn_ra_neon/ subversion/libsvn_ra_ser

2010-08-10 Thread Hyrum K. Wright
On Tue, Aug 10, 2010 at 8:38 PM, cmpil...@apache.org wrote: Author: cmpilato Date: Wed Aug 11 01:38:40 2010 New Revision: 984280 URL: http://svn.apache.org/viewvc?rev=984280view=rev Log: Reintegrate the issue-2779-dev branch.  Permanent redirect responses from an HTTP server now cause the

Re: [atomic-revprops] status update

2010-08-10 Thread Hyrum K. Wright
On Tue, Aug 10, 2010 at 8:28 PM, Daniel Shahaf d...@daniel.shahaf.name wrote: Hyrum K. Wright wrote on Tue, Aug 10, 2010 at 20:10:54 -0500: Do you think the work is sufficiently non-disruptive to be moved back to trunk? Yes. Updated plan: I'll do the marshal error codes in ra_dav work on