villebro commented on issue #4324: Cannot create a visualisation given a nested
query
URL:
https://github.com/apache/incubator-superset/issues/4324#issuecomment-365193700
Can you post the contents of "View Query" on the explore page where you are
getting the error message? This should hel
xrmx commented on a change in pull request #4394: Implement the column config
and row config in pivot table
URL:
https://github.com/apache/incubator-superset/pull/4394#discussion_r167797482
##
File path: superset/viz.py
##
@@ -584,8 +584,12 @@ def get_data(self, df):
villebro opened a new issue #4412: Comment row at end of query in SQL Lab fails
to render in Explore window
URL: https://github.com/apache/incubator-superset/issues/4412
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to
render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365200288
sqlparse.format has an option for striping comments
http://sqlparse.readthedocs.io/en/latest/api/#fo
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to
render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365200288
sqlparse.format has an option for removing comments
http://sqlparse.readthedocs.io/en/latest/api/#fo
villebro commented on issue #4412: Comment row at end of query in SQL Lab fails
to render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365203863
Thanks, that looks much better:
```
diff --git a/superset/connectors/sqla/models.py
b/
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to
render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365207248
Looks good to me, bonus points for adding a test :)
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to
render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365207900
Looking again at the code we may want to clean the sql *after* poking with
the template processor.
villebro commented on issue #4412: Comment row at end of query in SQL Lab fails
to render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365210867
Right you are, I missed that. New try:
```
diff --git a/superset/connectors/sqla/models
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to
render in Explore window
URL:
https://github.com/apache/incubator-superset/issues/4412#issuecomment-365217960
@villebro please open a PR so it can be reviewed and merged.
--
xiaohanyu commented on a change in pull request #4394: Implement the column
config and row config in pivot table
URL:
https://github.com/apache/incubator-superset/pull/4394#discussion_r167819769
##
File path: superset/viz.py
##
@@ -584,8 +584,12 @@ def get_data(self, df):
xiaohanyu commented on issue #4394: Implement the column config and row config
in pivot table
URL:
https://github.com/apache/incubator-superset/pull/4394#issuecomment-365168066
Hi, @mistercrunch
Above is the overall features of this so-called "column and row
configuration". Actual
xiaohanyu commented on a change in pull request #4394: Implement the column
config and row config in pivot table
URL:
https://github.com/apache/incubator-superset/pull/4394#discussion_r167819769
##
File path: superset/viz.py
##
@@ -584,8 +584,12 @@ def get_data(self, df):
xiaohanyu commented on issue #4403: Test case not passing when callbacks are
used in DateFilterControl_spec.jsx + a repeated test case
URL:
https://github.com/apache/incubator-superset/issues/4403#issuecomment-365221725
+1, confirmed with the bugs in a47a51280, code inside `setTimeout()` a
xiaohanyu commented on issue #4394: Implement the column config and row config
in pivot table
URL:
https://github.com/apache/incubator-superset/pull/4394#issuecomment-365168066
Hi, @mistercrunch
Above is the overall features of this so-called "column and row
configuration". Actual
romankierzkowski commented on issue #4407: Error on SQL execution: "Could not
broadcast input array from shape (26896) into shape (1,164)"
URL:
https://github.com/apache/incubator-superset/issues/4407#issuecomment-365230606
PostgreSQL 9.6.2
villebro opened a new pull request #4413: Remove comments from queries in SQL
Lab that break Explore view
URL: https://github.com/apache/incubator-superset/pull/4413
This fixes an issue where comments on the last line of the source query
comment out the closing parenthesis of the subquery.
maver1ck opened a new issue #4414: Query on hive: Expected state FINISHED, but
found ERROR
URL: https://github.com/apache/incubator-superset/issues/4414
Make sure these boxes are checked before submitting your issue - thank you!
- [X] I have checked the superset logs for python stack
kahernandez opened a new issue #4415: Feature request: please add Y min to Dual
Axis chart type
URL: https://github.com/apache/incubator-superset/issues/4415
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python
xrmx commented on issue #4415: Feature request: please add Y min to Dual Axis
chart type
URL:
https://github.com/apache/incubator-superset/issues/4415#issuecomment-365302674
Please reproduce with latest superset version.
Thi
mistercrunch opened a new pull request #4416: [dashboard] more granular grid
layout
URL: https://github.com/apache/incubator-superset/pull/4416
Moving to a grid that is 4 times more granular. 48 columns.
![2cabm6nh2v](https://user-images.githubusercontent.com/487433/36162139-73dd50ec-10
timifasubaa commented on issue #4405: Disable user access request
URL:
https://github.com/apache/incubator-superset/pull/4405#issuecomment-365345137
Done
This is an automated message from the Apache Git Service.
To respond to
villebro commented on issue #4413: Remove comments from queries in SQL Lab that
break Explore view
URL:
https://github.com/apache/incubator-superset/pull/4413#issuecomment-365350711
Sorry, I'm kinda new to this, will add a test shortly.
graceguo-supercat closed pull request #4401: [SqlLab] Fix a few height related
UI issues
URL: https://github.com/apache/incubator-superset/pull/4401
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
rumbin commented on issue #4413: Remove comments from queries in SQL Lab that
break Explore view
URL:
https://github.com/apache/incubator-superset/pull/4413#issuecomment-365362266
Will this strip the comments when transferring to a table definition, or
will they still exist right there bu
rumbin commented on issue #4416: [dashboard] more granular grid layout
URL:
https://github.com/apache/incubator-superset/pull/4416#issuecomment-365362529
Thanks!
This is an automated message from the Apache Git Service.
To re
rumbin commented on issue #4406: Need to use more than table in a slice and
able to make List of values(LOVs) for filtering
URL:
https://github.com/apache/incubator-superset/issues/4406#issuecomment-365365071
Assuming that the second table resides within the same DB, you have at least
aabdinur commented on issue #3498: Add check_ownership call in
save_or_overwrite_slice
URL:
https://github.com/apache/incubator-superset/issues/3498#issuecomment-365366385
Doesn't this problem also exist on a dashboard level? Users with read only
access are able to delete slices from the
vylc opened a new issue #4417: [Explore] Stop button for queries doesn't work?
URL: https://github.com/apache/incubator-superset/issues/4417
Stop button functionality, when pressed:
(1) Cancel query on DB side
(2) Reset explore view to state before query was run
(3) Currently, when
mistercrunch closed pull request #4389: [geo] introduce "Auto Zoom" control
URL: https://github.com/apache/incubator-superset/pull/4389
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
mistercrunch commented on issue #4417: [Explore] Stop button for queries
doesn't work?
URL:
https://github.com/apache/incubator-superset/issues/4417#issuecomment-365371644
fixed here:
https://github.com/apache/incubator-superset/pull/4301
---
timifasubaa commented on a change in pull request #4409: Add permissions
decider for delegating access controls.
URL:
https://github.com/apache/incubator-superset/pull/4409#discussion_r167971247
##
File path: superset/config.py
##
@@ -364,6 +364,24 @@ class CeleryConfig(o
mistercrunch closed pull request #4411: use full path in case of there are
query params
URL: https://github.com/apache/incubator-superset/pull/4411
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
mistercrunch closed pull request #4410: Unset 'series limit' default from 50 to
null
URL: https://github.com/apache/incubator-superset/pull/4410
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
mistercrunch commented on a change in pull request #4409: Add permissions
decider for delegating access controls.
URL:
https://github.com/apache/incubator-superset/pull/4409#discussion_r167973124
##
File path: superset/config.py
##
@@ -364,6 +364,24 @@ class CeleryConfig(
mistercrunch commented on issue #4405: Disable user access request
URL:
https://github.com/apache/incubator-superset/pull/4405#issuecomment-365377069
Wait you're deleting all those tests :(
Why not just have them look at the same config/feature flag?
---
timifasubaa commented on issue #4405: Disable user access request
URL:
https://github.com/apache/incubator-superset/pull/4405#issuecomment-365378668
Ah, true. I'll do it that way instead.
This is an automated message from th
villebro commented on issue #4413: Remove comments from queries in SQL Lab that
break Explore view
URL:
https://github.com/apache/incubator-superset/pull/4413#issuecomment-365383714
The comments are only removed when the table is queried on, i.e. they remain
in the table definition.
rumbin commented on issue #4413: Remove comments from queries in SQL Lab that
break Explore view
URL:
https://github.com/apache/incubator-superset/pull/4413#issuecomment-365394462
Perfect. Thanks for the explanation...
This
timifasubaa commented on a change in pull request #4409: Add permissions
decider for delegating access controls.
URL:
https://github.com/apache/incubator-superset/pull/4409#discussion_r168007018
##
File path: superset/config.py
##
@@ -364,6 +364,24 @@ class CeleryConfig(o
timifasubaa commented on a change in pull request #4409: Add permissions
decider for delegating access controls.
URL:
https://github.com/apache/incubator-superset/pull/4409#discussion_r168007018
##
File path: superset/config.py
##
@@ -364,6 +364,24 @@ class CeleryConfig(o
raffas opened a new pull request #4418: Updated Italian Translation
URL: https://github.com/apache/incubator-superset/pull/4418
Improved Italian translation
This is an automated message from the Apache Git Service.
To resp
timifasubaa commented on a change in pull request #4418: Updated Italian
Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168029690
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -120,15 +121,15 @@ msgstr "10 minuti
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168030701
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -1244,19 +1245,19 @@ msgstr ""
#: superse
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168029490
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -120,15 +121,15 @@ msgstr "10 minuti"
#: su
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168031082
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -2274,16 +2275,16 @@ msgstr ""
#: superset/
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168029891
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -229,23 +230,23 @@ msgstr "Serie Temporali -
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168031394
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -2296,7 +2297,7 @@ msgstr ""
#: superset/
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168030742
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -1271,20 +1272,20 @@ msgstr "Tipo di Visuali
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168030030
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -229,23 +230,23 @@ msgstr "Serie Temporali -
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168029816
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -197,7 +198,7 @@ msgstr "Grafico a Bolle"
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168029236
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -9,7 +9,8 @@ msgstr ""
"Project-Id-Version:
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168029376
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -120,15 +121,15 @@ msgstr "10 minuti"
#: su
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168029733
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -137,11 +138,11 @@ msgstr "Vista Tabella"
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168030589
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -1171,68 +1172,68 @@ msgstr ""
#:
supers
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168030212
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -319,7 +320,7 @@ msgstr "Disposizione a Forz
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168030267
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -1075,69 +1076,69 @@ msgstr ""
#: superse
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168029316
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -120,15 +121,15 @@ msgstr "10 minuti"
#: su
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168030460
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -1075,69 +1076,69 @@ msgstr ""
#: superse
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168030645
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -1244,19 +1245,19 @@ msgstr ""
#: superse
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168031715
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -2464,15 +2465,15 @@ msgstr ""
#: superse
xrmx commented on a change in pull request #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#discussion_r168031607
##
File path: superset/translations/it/LC_MESSAGES/messages.po
##
@@ -2343,48 +2344,48 @@ msgstr ""
#: superse
ahsanshah opened a new issue #4419: Unclear on how to migrate metadata across
Superset versions
URL: https://github.com/apache/incubator-superset/issues/4419
Make sure these boxes are checked before submitting your issue - thank you!
- [ x] I have checked the superset logs for python
raffas commented on issue #4418: Updated Italian Translation
URL:
https://github.com/apache/incubator-superset/pull/4418#issuecomment-365444718
@xrmx Updated translation with your changes
This is an automated message from the
graceguo-supercat commented on issue #3993: [Explore view] Use POST method for
charting requests
URL:
https://github.com/apache/incubator-superset/pull/3993#issuecomment-365463834
Merged.
This is an automated message from th
graceguo-supercat closed pull request #3993: [Explore view] Use POST method for
charting requests
URL: https://github.com/apache/incubator-superset/pull/3993
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of pro
graceguo-supercat closed issue #3795: [WiP] Shorten URL for explore
URL: https://github.com/apache/incubator-superset/issues/3795
This is an automated message from the Apache Git Service.
To respond to the message, please log
graceguo-supercat commented on issue #4394: Implement the column config and row
config in pivot table
URL:
https://github.com/apache/incubator-superset/pull/4394#issuecomment-365467433
@xiaohanyu We had a PR to convert all charting request method from GET to
POST here:
https://github.c
mistercrunch commented on issue #4394: Implement the column config and row
config in pivot table
URL:
https://github.com/apache/incubator-superset/pull/4394#issuecomment-365471239
Haven't dug deep in this PR yet, but it looks like colors are quite binary,
as opposed to a spectrum. Seems l
mistercrunch commented on issue #4419: Unclear on how to migrate metadata
across Superset versions
URL:
https://github.com/apache/incubator-superset/issues/4419#issuecomment-365472115
https://superset.incubator.apache.org/installation.html#upgrading
I would not recommend using sqlit
vnnw opened a new pull request #4420: 20180214
URL: https://github.com/apache/incubator-superset/pull/4420
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
vnnw closed pull request #4420: 20180214
URL: https://github.com/apache/incubator-superset/pull/4420
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork),
vnnw opened a new pull request #4421: Update core.py
URL: https://github.com/apache/incubator-superset/pull/4421
Impliment: Cache endpoint by datasource and column
This is an automated message from the Apache Git Service.
To r
xiaohanyu commented on issue #4394: Implement the column config and row config
in pivot table
URL:
https://github.com/apache/incubator-superset/pull/4394#issuecomment-365502660
@graceguo-supercat will definitely rebase the code.
xiaohanyu commented on issue #4394: Implement the column config and row config
in pivot table
URL:
https://github.com/apache/incubator-superset/pull/4394#issuecomment-365503599
@mistercrunch Yes, we only provide binary colors in this PR. However, we've
already implemented a new internal f
xiaohanyu commented on issue #4394: Implement the column config and row config
in pivot table
URL:
https://github.com/apache/incubator-superset/pull/4394#issuecomment-365503599
@mistercrunch Yes, we only provide binary colors in this PR. However, we've
already implemented a new internal f
mistercrunch opened a new pull request #4422: [geoviz] lines made from
locations in time (can be animated)
URL: https://github.com/apache/incubator-superset/pull/4422
![ppz6fl8g8g](https://user-images.githubusercontent.com/487433/36189905-d9d80bac-1109-11e8-8595-a4dafb20ae61.gif)
mistercrunch commented on issue #4394: Implement the column config and row
config in pivot table
URL:
https://github.com/apache/incubator-superset/pull/4394#issuecomment-365507520
Oh that looks neat!
This is an automated mes
ahsanshah closed issue #4419: Unclear on how to migrate metadata across
Superset versions
URL: https://github.com/apache/incubator-superset/issues/4419
This is an automated message from the Apache Git Service.
To respond to
ahsanshah commented on issue #4419: Unclear on how to migrate metadata across
Superset versions
URL:
https://github.com/apache/incubator-superset/issues/4419#issuecomment-365508701
Got it. Thanks.
This is an automated mes
DaimonPl opened a new issue #4423: Pivot table - ability to specify row limit
URL: https://github.com/apache/incubator-superset/issues/4423
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and inc
81 matches
Mail list logo