[GitHub] codecov-io commented on issue #4909: [Explore] Adding Adhoc Filters
codecov-io commented on issue #4909: [Explore] Adding Adhoc Filters URL: https://github.com/apache/incubator-superset/pull/4909#issuecomment-385514806 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4909?src=pr=h1) Report > Merging [#4909](https://codecov.io/gh/apache/incubator-superset/pull/4909?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **increase** coverage by `0.06%`. > The diff coverage is `92.85%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4909?src=pr=tree) ```diff @@Coverage Diff@@ ## master #4909 +/- ## = + Coverage 77.14% 77.2% +0.06% = Files 44 44 Lines85398578 +39 = + Hits 65876623 +36 - Misses 19521955 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4909?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4909/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `81.11% <100%> (-0.06%)` | :arrow_down: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4909/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.12% <100%> (+0.05%)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4909/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `80.22% <91.66%> (+0.32%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4909?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4909?src=pr=footer). Last update [e1d2150...c85c7f1](https://codecov.io/gh/apache/incubator-superset/pull/4909?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ttannis commented on a change in pull request #4760: URL shortner for dashboards
ttannis commented on a change in pull request #4760: URL shortner for dashboards
URL:
https://github.com/apache/incubator-superset/pull/4760#discussion_r185122682
##
File path:
superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
##
@@ -157,27 +151,6 @@ class ExploreViewContainer extends React.Component {
}
}
- addHistory({ isReplace = false, title }) {
Review comment:
@graceguo-supercat would you like to revisit/or discuss that decision again?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] john-bodley commented on issue #4740: Add extraction function support for Druid queries
john-bodley commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385579265 @mistercrunch I don't believe we use extraction functions in any of the Druid clusters connected to Superset (per a quick code search). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4910: Use React.PureComponent everywhere
codecov-io commented on issue #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910#issuecomment-385572529 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=h1) Report > Merging [#4910](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4910 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=footer). Last update [e1d2150...fb7534b](https://codecov.io/gh/apache/incubator-superset/pull/4910?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4910: Use React.PureComponent everywhere
mistercrunch opened a new pull request #4910: Use React.PureComponent everywhere URL: https://github.com/apache/incubator-superset/pull/4910 s/React.Component/React.PureComponent/g Did a bit of manual testing but I think we've had good hygiene of not mutating props. This should result in much less rendering. @graceguo-supercat @williaster what do you all think? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida opened a new pull request #4911: Fix for week_start_sunday and week_ending_saturday
betodealmeida opened a new pull request #4911: Fix for week_start_sunday and
week_ending_saturday
URL: https://github.com/apache/incubator-superset/pull/4911
The granularity options `week_ending_saturday` ("truncate forward til next
Saturday") and `week_start_sunday` ("truncate back til last Sunday") are not
working correctly. Currently the granularity dropdown has the same key (`P1W`,
one week) for `week`, `week_ending_saturday` and `week_start_sunday`, and only
the first one can be selected.
I fixed this bug by making the key unique. The ISO 8601 spec supports `time
intervals`, so I used `1969-12-28T00:00:00Z/P1W` to represent
`week_start_sunday` (since 1969-12-28 was a Sunday), and
`P1W/1970-01-03T00:00:00Z` to represent (week_ending_saturday` (since
1970-01-03 was a Saturday). This required modifying the `getPlaySliderParams`
function, since it parses the ISO duration in order to get its props.
I also added these two granularities to the SQLite backend, in order to test
it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4760: URL shortner for dashboards
mistercrunch commented on a change in pull request #4760: URL shortner for
dashboards
URL:
https://github.com/apache/incubator-superset/pull/4760#discussion_r185149117
##
File path:
superset/assets/javascripts/explore/components/ExploreViewContainer.jsx
##
@@ -157,27 +151,6 @@ class ExploreViewContainer extends React.Component {
}
}
- addHistory({ isReplace = false, title }) {
Review comment:
@ttannis can we just keep `addHistory` as untouched as possible?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] jeffreythewang commented on issue #4740: Add extraction function support for Druid queries
jeffreythewang commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385596164 We currently don't use extraction functions either. This may have already been answered, but I'm curious why you didn't use the pydruid [`DimensionSpec`](https://github.com/druid-io/pydruid/blob/master/pydruid/utils/dimensions.py#L8) builder? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...d850f31](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4740: Add extraction function support for Druid queries
mistercrunch commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385571371 @fabianmenges @john-bodley I'm identifying this PR as something that could break things in your environment but I can't really test it in my environment since we don't have a lot of charts on Druid at this point. Can you 2 review/greenlight this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...d850f31](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...d850f31](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fabianmenges commented on issue #4740: Add extraction function support for Druid queries
fabianmenges commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-385575931 Ack, will do. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...d850f31](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4740: Add extraction function support for Druid queries
codecov-io commented on issue #4740: Add extraction function support for Druid queries URL: https://github.com/apache/incubator-superset/pull/4740#issuecomment-378676086 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr=h1) Report > Merging [#4740](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fa3da8c888e25b62e72faaab8987631f07096b56?src=pr=desc) will **increase** coverage by `0.12%`. > The diff coverage is `75.43%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4740 +/- ## == + Coverage 76.97% 77.09% +0.12% == Files 44 44 Lines8537 8576 +39 == + Hits 6571 6612 +41 + Misses 1966 1964 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `80.54% <75.43%> (-0.63%)` | :arrow_down: | | [superset/data/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YS9fX2luaXRfXy5weQ==) | `100% <0%> (ø)` | :arrow_up: | | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `44.06% <0%> (ø)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `97.7% <0%> (ø)` | :arrow_up: | | [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `93.93% <0%> (ø)` | :arrow_up: | | [superset/extract\_table\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr=tree#diff-c3VwZXJzZXQvZXh0cmFjdF90YWJsZV9uYW1lcy5weQ==) | `0% <0%> (ø)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.54% <0%> (ø)` | :arrow_up: | | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0% <0%> (ø)` | :arrow_up: | | [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `98.59% <0%> (ø)` | :arrow_up: | | ... and [29 more](https://codecov.io/gh/apache/incubator-superset/pull/4740/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr=footer). Last update [fa3da8c...5197a1e](https://codecov.io/gh/apache/incubator-superset/pull/4740?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new issue #4912: Missing predefined metrics options in MetricsControls
mistercrunch opened a new issue #4912: Missing predefined metrics options in MetricsControls URL: https://github.com/apache/incubator-superset/issues/4912 @GabeLoins I noticed that many of the basic predefined metrics are not showing up in the dropdowns. This is easy to reproduce with most datasources (births does it) in the examples. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday
codecov-io commented on issue #4911: Fix for week_start_sunday and week_ending_saturday URL: https://github.com/apache/incubator-superset/pull/4911#issuecomment-385575078 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=h1) Report > Merging [#4911](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e1d2150391ba827a64cebd0c0573aab0a82a3634?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4911 +/- ## === Coverage 77.14% 77.14% === Files 44 44 Lines8539 8539 === Hits 6587 6587 Misses 1952 1952 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4911/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `52.69% <ø> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=footer). Last update [e1d2150...d850f31](https://codecov.io/gh/apache/incubator-superset/pull/4911?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4907: translations: rename pt_BR gettext files
mistercrunch closed pull request #4907: translations: rename pt_BR gettext files URL: https://github.com/apache/incubator-superset/pull/4907 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/superset/translations/pt_BR/LC_MESSAGES/pt_BR.mo b/superset/translations/pt_BR/LC_MESSAGES/messages.mo similarity index 100% rename from superset/translations/pt_BR/LC_MESSAGES/pt_BR.mo rename to superset/translations/pt_BR/LC_MESSAGES/messages.mo diff --git a/superset/translations/pt_BR/LC_MESSAGES/pt_BR.po b/superset/translations/pt_BR/LC_MESSAGES/messages.po similarity index 100% rename from superset/translations/pt_BR/LC_MESSAGES/pt_BR.po rename to superset/translations/pt_BR/LC_MESSAGES/messages.po This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4906: requirements: bump gunicorn to 19.8.0
mistercrunch closed pull request #4906: requirements: bump gunicorn to 19.8.0 URL: https://github.com/apache/incubator-superset/pull/4906 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/requirements.txt b/requirements.txt index ea4f830cf9..b93965a0d8 100644 --- a/requirements.txt +++ b/requirements.txt @@ -14,7 +14,7 @@ flask-wtf==0.14.2 flower==0.9.2 future==0.16.0 geopy==1.11.0 -gunicorn==19.7.1 +gunicorn==19.8.0 humanize==0.5.1 idna==2.6 markdown==2.6.11 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4908: Replace NaN/Infinity with null
mistercrunch commented on a change in pull request #4908: Replace NaN/Infinity
with null
URL:
https://github.com/apache/incubator-superset/pull/4908#discussion_r185031456
##
File path: superset/views/core.py
##
@@ -2435,7 +2436,7 @@ def sql_json(self):
resp = json_success(json.dumps(
{'query': query.to_dict()}, default=utils.json_int_dttm_ser,
-allow_nan=False), status=202)
+ignore_nan=True), status=202)
Review comment:
This is a little bit scary as it was set to False explicitly in the past,
probably for a reason. I'm guessing the default is `True` and someone set it to
`False` for some specific reason. We should do a bit of git forensics to
understand how it came to be.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] williaster commented on issue #4893: add sticky to sidepane
williaster commented on issue #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#issuecomment-385475575 Going through the code now but some UI/UX thoughts (cc @elibrumbaugh): - the sidebar should always be the full height of the screen (see designs) - there should be no gap between the dashboard title header and the side pane - as a user scrolls down, the side bar should scroll up _until_ it hits the top of the screen, at which point it becomes sticky/fixed. as we discussed before, this might be done most easily with `react-sticky`. Also, will this approach also be compatible with making top-level tabs sticky? It should behave in the same way. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SpyderRivera commented on issue #4812: Filter by lookup
SpyderRivera commented on issue #4812: Filter by lookup URL: https://github.com/apache/incubator-superset/issues/4812#issuecomment-382020998 Did you check the "filter" box in the dimension creation screen? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4905: [wip][missing values] Removing replacing missing values
williaster commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385473973 I think that option 1 above is the best^ it's super misleading to have nulls replaced with 0s, and if you interpolate between nulls (ie connect them with a line) I think it's just as misleading. users should be able to make the connection between the line segments interrupted by nulls using line color. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4893: add sticky to sidepane
williaster commented on issue #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#issuecomment-385475575 Going through the code now but some UI/UX thoughts (cc @elibrumbaugh): - the sidebar should always be the full height of the screen (see designs) - there should be no gap between the dashboard title header and the side bar - as a user scrolls down, the side bar should scroll up _until_ it hits the top of the screen, at which point it becomes sticky/fixed. as we discussed before, this might be done most easily with `react-sticky`. Also, will this approach also be compatible with making top-level tabs sticky? It should behave in the same way. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4893: add sticky to sidepane
williaster commented on issue #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#issuecomment-385480121 - the builder pane Title should be `"Insert components"` instead of `"Add"` - the transition on the css also seems off a bit, when you go back and forth with "insert" and "chart", it looks like it transitions twice almost (not quite sure how to describe it) - there's some sort of issue with css here as well, you can see both panes (the two headers should match size, looks like the nested chart panel ["Add chart"] has a larger bottom margin)  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabeLoins opened a new pull request #4909: [Explore] Adding Adhoc Filters
GabeLoins opened a new pull request #4909: [Explore] Adding Adhoc Filters URL: https://github.com/apache/incubator-superset/pull/4909 Here I'm following a similar design pattern as Adhoc Metrics (https://github.com/apache/incubator-superset/pull/4663 and https://github.com/apache/incubator-superset/pull/4736). Adhoc Filters introduces a new control that unifies the 4 previous filter controls (free text where, free text having, structured where filter, structured having filter). It allows you to select a column or any saved metric / adhoc metric currently being used in the metric field to filter by:  and then once a metric or column is selected lets you switch between writing a SQL filter or simple filter for that metric/column:  (for druid datsources, metric and column filters can only be edited in the simple view. for table datsources, column filters can be edited in either but metrics filters can only be edited in the sql view) This PR also removes the legacy filter controls. When loading a chart that has legacy filters already attached to it, they will be cast to adhoc filters:  Here are some more demos of the feature in action, creating and editing filters:  transitioning between simple tab and sql tab:  selecting adhoc metrics to filter on:  notes to reviewers: The meat of the frontend lies in the three AdhocFilterEditPopover* files and the AdhocFilterControl file. The meat of the backend lies in viz.py where I break adhoc filters out into the four base types of filters for processing. reviewers: @michellethomas @williaster @graceguo-supercat @john-bodley @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SpyderRivera commented on issue #4812: Filter by lookup
SpyderRivera commented on issue #4812: Filter by lookup URL: https://github.com/apache/incubator-superset/issues/4812#issuecomment-385459832 I am getting similar results for Druid data sources only I didn't realize it until I tried to look at the == results instead on !=. I'm on version v0.24.0. For some reason, the filter is not being applied correctly. I looked at the query that is generated and the lookup is passed and the filter is also applied in the query. This makes me think it is something on the druid end or how exactly the query is formed. Possible solutions in fixing the query building piece: - Add an extractionFn to the selector filter which repeats the map from the list of dimensions. http://druid.io/docs/latest/querying/filters.html#filtering-with-extraction-functions - Use a having filter instead which will apply the filter after the grouping. I suspect the former to be slightly more performant because it'll row the row's to be scanned for the grouping. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SpyderRivera commented on issue #4812: Filter by lookup
SpyderRivera commented on issue #4812: Filter by lookup URL: https://github.com/apache/incubator-superset/issues/4812#issuecomment-385459832 I am getting similar results for Druid data sources only I didn't realize it until I tried to look at the == results instead on !=. I'm on version v0.24.0. For some reason, the filter is not being applied correctly. I looked at the query that is generated and the lookup is passed and the filter is also applied in the query. This makes me think it is something on the druid end or how exactly the query is formed. Possible solutions in fixing the query building piece: - Add an extractionFn to the selector filter which repeats the map from the list of dimensions. http://druid.io/docs/latest/querying/filters.html#filtering-with-extraction-functions - Use a having filter instead which will apply the filter after the grouping. I suspect the former to be slightly more performant. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida commented on issue #4819: Visualization for multiple line charts
betodealmeida commented on issue #4819: Visualization for multiple line charts URL: https://github.com/apache/incubator-superset/pull/4819#issuecomment-385463031 @mistercrunch, I removed the SQL and filter controls in the last commit. I'll do a separate PR handling them properly, accounting for multiple datasources. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values
john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385464671 @mistercrunch this PR is very much WIP as I need to go through each visualization type and update the logic were necessary. At the moment I've only taken a pass at the box-plot visualization. The reason I put this PR out was to gain more context (like your comment around `' NULL'`) to better understand what the logic should be and what tests I should write. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4905: [wip][missing values] Removing replacing missing values
mistercrunch commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385468553 Glad you're taking this on! I've had some conversations with @betodealmeida about sorting some of this out. I'm taking a tangent here thinking about NULL handling in time series. Users may want or expect a set of behaviors: * break the line, restart it on the other side (highcharts does this I think) * replace with 0 * link the line across both sides of the null Option 1 is arguably the best visual representation of what is happening, but as far as I know NVD3 doesn't do this well (maybe it didn't in the past but does now...) Option 2 makes it pretty clear that data is missing, though clearly NULL is not zero and that's somewhat wrong and ugly (steep diagonals) Option 3 is misleading, especially in the absence of markers, you may care and never know that data is missing. Recently we introduced ISO notation to `db_engine_specs` concept of time grain, which means Superset now knows about the time granularity. This can help us to time resampling and doing proper handling of missing values eventually. Eventually we could have a control section "Handling NULLs" this and offering all the needed options. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4897: Heatmap improvements
mistercrunch closed pull request #4897: Heatmap improvements
URL: https://github.com/apache/incubator-superset/pull/4897
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/src/explore/controls.jsx
b/superset/assets/src/explore/controls.jsx
index ae964ef03c..ffe264b547 100644
--- a/superset/assets/src/explore/controls.jsx
+++ b/superset/assets/src/explore/controls.jsx
@@ -387,8 +387,10 @@ export const controls = {
xscale_interval: {
type: 'SelectControl',
label: t('XScale Interval'),
+renderTrigger: true,
choices: formatSelectOptionsForRange(1, 50),
default: '1',
+clearable: false,
description: t('Number of steps to take between ticks when ' +
'displaying the X scale'),
},
@@ -397,7 +399,9 @@ export const controls = {
type: 'SelectControl',
label: t('YScale Interval'),
choices: formatSelectOptionsForRange(1, 50),
-default: null,
+default: '1',
+clearable: false,
+renderTrigger: true,
description: t('Number of steps to take between ticks when ' +
'displaying the Y scale'),
},
@@ -726,6 +730,7 @@ export const controls = {
bottom_margin: {
type: 'SelectControl',
+clearable: false,
freeForm: true,
label: t('Bottom Margin'),
choices: formatSelectOptions(['auto', 50, 75, 100, 125, 150, 200]),
@@ -747,6 +752,7 @@ export const controls = {
left_margin: {
type: 'SelectControl',
freeForm: true,
+clearable: false,
label: t('Left Margin'),
choices: formatSelectOptions(['auto', 50, 75, 100, 125, 150, 200]),
default: 'auto',
diff --git a/superset/assets/src/explore/visTypes.js
b/superset/assets/src/explore/visTypes.js
index 28dfdff646..5f4418e99c 100644
--- a/superset/assets/src/explore/visTypes.js
+++ b/superset/assets/src/explore/visTypes.js
@@ -1487,6 +1487,7 @@ export const visTypes = {
},
{
label: t('Heatmap Options'),
+expanded: true,
controlSetRows: [
['linear_color_scheme'],
['xscale_interval', 'yscale_interval'],
@@ -1494,7 +1495,7 @@ export const visTypes = {
['left_margin', 'bottom_margin'],
['y_axis_bounds', 'y_axis_format'],
['show_legend', 'show_perc'],
- ['show_values'],
+ ['show_values', 'normalized'],
['sort_x_axis', 'sort_y_axis'],
],
},
@@ -1506,14 +1507,13 @@ export const visTypes = {
all_columns_y: {
validators: [v.nonEmpty],
},
+ normalized: t('Whether to apply a normal distribution based on rank on
the color scale'),
y_axis_bounds: {
label: t('Value bounds'),
-renderTrigger: false,
-description: (
+renderTrigger: true,
+description: t(
'Hard value bounds applied for color coding. Is only relevant ' +
- 'and applied when the normalization is applied against the whole ' +
- 'heatmap.'
-),
+ 'and applied when the normalization is applied against the whole
heatmap.'),
},
y_axis_format: {
label: t('Value Format'),
diff --git a/superset/assets/src/visualizations/heatmap.js
b/superset/assets/src/visualizations/heatmap.js
index a8d3ccf694..7d471d5d80 100644
--- a/superset/assets/src/visualizations/heatmap.js
+++ b/superset/assets/src/visualizations/heatmap.js
@@ -92,7 +92,7 @@ function heatmapVis(slice, payload) {
const height = slice.height();
const hmWidth = width - (margin.left + margin.right);
const hmHeight = height - (margin.bottom + margin.top);
- const fp = d3.format('.3p');
+ const fp = d3.format('.2%');
const xScale = ordScale('x', null, fd.sort_x_axis);
const yScale = ordScale('y', null, fd.sort_y_axis);
@@ -102,7 +102,9 @@ function heatmapVis(slice, payload) {
const Y = 1;
const heatmapDim = [xRbScale.domain().length, yRbScale.domain().length];
- const color = colorScalerFactory(fd.linear_color_scheme);
+ const minBound = fd.y_axis_bounds[0] || 0;
+ const maxBound = fd.y_axis_bounds[1] || 1;
+ const colorScaler = colorScalerFactory(fd.linear_color_scheme, null, null,
[minBound, maxBound]);
const scale = [
d3.scale.linear()
@@ -149,11 +151,9 @@ function heatmapVis(slice, payload) {
}
if (fd.show_legend) {
-const legendScaler = colorScalerFactory(
- fd.linear_color_scheme, null, null, payload.data.extents);
const colorLegend = d3.legend.color()
.labelFormat(valueFormatter)
-.scale(legendScaler)
+.scale(colorScaler)
.shapePadding(0)
.cells(50)
.shapeWidth(10)
@@ -183,7 +183,7 @@ function heatmapVis(slice, payload) {
s += '' + fd.all_columns_y + ': ' + obj.y + '';
s += '' + fd.metric + ': ' +
[GitHub] codecov-io commented on issue #4908: Replace NaN/Infinity with null
codecov-io commented on issue #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908#issuecomment-385454285 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=h1) Report > Merging [#4908](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d533ce09676921ec2f72e1032bbca0d2a37f65b6?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4908 +/- ## == - Coverage 77.13% 77.12% -0.02% == Files 44 44 Lines8542 8542 == - Hits 6589 6588 -1 - Misses 1953 1954 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4908/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.68% <100%> (ø)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4908/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.85% <0%> (-0.22%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=footer). Last update [d533ce0...1a66e63](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4905: [wip][missing values] Removing replacing missing values
mistercrunch commented on a change in pull request #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#discussion_r185045726 ## File path: superset/viz.py ## @@ -961,7 +936,6 @@ def as_floats(field): return d def get_data(self, df): -df = df.fillna(0) Review comment: Are we sure that this particular visualization handles null nicely? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SpyderRivera commented on issue #4812: Filter by lookup
SpyderRivera commented on issue #4812: Filter by lookup URL: https://github.com/apache/incubator-superset/issues/4812#issuecomment-385459832 I am getting similar results for Druid data sources only I didn't realize it until I tried to look at the == results instead on !=. I'm on version v0.24.0. For some reason, the filter is not being applied correctly. I looked at the query that is generated and the lookup is passed and the filter is also applied in the query. This makes me think it is something on the druid end or how exactly the query is formed. Possible solutions in fixing the query building piece: - Add an extractionFn to the selector filter which repeats the map from the list of dimensions. http://druid.io/docs/latest/querying/filters.html#filtering-with-extraction-functions - Use a having filter instead which will apply the filter after the grouping. The former is slightly more performant. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4908: Replace NaN/Infinity with null
codecov-io commented on issue #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908#issuecomment-385454285 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=h1) Report > Merging [#4908](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d533ce09676921ec2f72e1032bbca0d2a37f65b6?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4908 +/- ## == - Coverage 77.13% 77.12% -0.02% == Files 44 44 Lines8542 8542 == - Hits 6589 6588 -1 - Misses 1953 1954 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4908/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.68% <100%> (ø)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4908/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.85% <0%> (-0.22%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=footer). Last update [d533ce0...1a66e63](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4908: Replace NaN/Infinity with null
codecov-io commented on issue #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908#issuecomment-385454285 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=h1) Report > Merging [#4908](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d533ce09676921ec2f72e1032bbca0d2a37f65b6?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4908 +/- ## == - Coverage 77.13% 77.12% -0.02% == Files 44 44 Lines8542 8542 == - Hits 6589 6588 -1 - Misses 1953 1954 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4908/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.68% <100%> (ø)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4908/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.85% <0%> (-0.22%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=footer). Last update [d533ce0...1a66e63](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4908: Replace NaN/Infinity with null
codecov-io commented on issue #4908: Replace NaN/Infinity with null URL: https://github.com/apache/incubator-superset/pull/4908#issuecomment-385454285 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=h1) Report > Merging [#4908](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d533ce09676921ec2f72e1032bbca0d2a37f65b6?src=pr=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4908 +/- ## == - Coverage 77.13% 77.12% -0.02% == Files 44 44 Lines8542 8542 == - Hits 6589 6588 -1 - Misses 1953 1954 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4908/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.68% <100%> (ø)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4908/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.85% <0%> (-0.22%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=footer). Last update [d533ce0...1a66e63](https://codecov.io/gh/apache/incubator-superset/pull/4908?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4883: Add note about 0.25.0 upgrade in UPDATING.md
mistercrunch closed pull request #4883: Add note about 0.25.0 upgrade in UPDATING.md URL: https://github.com/apache/incubator-superset/pull/4883 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/UPDATING.md b/UPDATING.md index 9a8b9b83df..0baf1133f8 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -3,8 +3,13 @@ This file documents any backwards-incompatible changes in Superset and assists people when migrating to a new version. +## Superset 0.25.0 +Superset 0.25.0 contains a backwards incompatible database migration script. +If you run a production system you should schedule downtime for this +upgrade. +* [4587](https://github.com/apache/incubator-superset/pull/4587) + ## Superset 0.23.0 * [4565](https://github.com/apache/incubator-superset/pull/4565) -* [4587](https://github.com/apache/incubator-superset/pull/4587) * [4835](https://github.com/apache/incubator-superset/pull/4835) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4905: [wip][missing values] Removing replacing missing values
mistercrunch commented on a change in pull request #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#discussion_r185045338 ## File path: superset/viz.py ## @@ -123,24 +122,6 @@ def run_extra_queries(self): """ pass -def get_fillna_for_col(self, col): -"""Returns the value for use as filler for a specific Column.type""" -if col: -if col.is_string: -return ' NULL' Review comment: I think @xrmx added some of this logic. `null`-labeled series creates issues on some visualizations. I believe the leading space has to do with sorting NULL first. We may want to reuse some of the logic I added recently around filtering that replaces `None` by `` and empty stings by ``. This should only be applied to dimensions / strings. Note that it applies only to string columns, thus not "zerofying" NULL values. I'm pretty sure that removing this will break many charts. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4905: [wip][missing values] Removing replacing missing values
mistercrunch commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385461702 Some visualizations may not handle NULL properly, I'd double check that they do prior to pushing this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] calve commented on issue #4390: Fix 4 security vulnerabilities
calve commented on issue #4390: Fix 4 security vulnerabilities URL: https://github.com/apache/incubator-superset/pull/4390#issuecomment-385464980 hi, would you consider requesting a CVE for those vulnerabilities to inform users ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida commented on a change in pull request #4908: Replace NaN/Infinity with null
betodealmeida commented on a change in pull request #4908: Replace NaN/Infinity
with null
URL:
https://github.com/apache/incubator-superset/pull/4908#discussion_r185049884
##
File path: superset/views/core.py
##
@@ -2435,7 +2436,7 @@ def sql_json(self):
resp = json_success(json.dumps(
{'query': query.to_dict()}, default=utils.json_int_dttm_ser,
-allow_nan=False), status=202)
+ignore_nan=True), status=202)
Review comment:
Yeah. This is super confusing naming. Just to clarify:
- `allow_nan=False`: will raise an exception if the data has NaN/Infinity;
- `ignore_nan=True`: will encode NaN/Infinity as nulls.
I'm assuming what happened was that someone had an async query returning
NaN/Infinity, and since the stdlib `json` module does not have the `ignore_nan`
argument the easiest way is to work around is to raise an exception here. It
took me a while to learn that `simplejson` had this option.
I looked at the blame and couldn't find any info about this. The reason I
changed this as well was to make it consistent with the sync call.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ghulands commented on issue #4875: Add support for druid in cache flushing handler
ghulands commented on issue #4875: Add support for druid in cache flushing handler URL: https://github.com/apache/incubator-superset/pull/4875#issuecomment-385466729 The warm_up_cache handler only supported the sql connector. This implements support for the native druid connector. I'll try and add some tests today for it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values
john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385464671 @mistercrunch this PR is very much WIP as I need to go through each visualization type and update the logic were necessary. At the moment I've only taken a pass at the box-plot visualization. The reason I put this PR out was to gain more context (like your comment around `' NULL'`) to better understand what the logic should be and what tests I should write. I think there is merit in having consistency between how data in rendered in SQL Lab and slices, i.e., there are inconsistencies [here](https://github.com/apache/incubator-superset/issues/3603#issuecomment-373280675) where SQL Lab reports `null` and slices report ` NULL` (note the leading whitespace which messes with alignment). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values
john-bodley commented on issue #4905: [wip][missing values] Removing replacing missing values URL: https://github.com/apache/incubator-superset/pull/4905#issuecomment-385464671 @mistercrunch this PR is very much WIP as I need to go through each visualization type and update the logic were necessary. At the moment I've only taken a pass at the box-plot visualization. The reason I put this PR out was to gain more context (like your comment around `' NULL'`) to better understand what the logic should be and what tests I should write. I think there is merit in having consistency between how data in rendered in SQL Lab and slices, i.e., there are inconsistencies [here](https://github.com/apache/incubator-superset/issues/3603#issuecomment-373280675) where SQL Lab reports `null` and slices report ` NULL` (with a leading whitespace which messes with alignment). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
