ilgrosso commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636617535
##
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##
@@ -216,28 +217,27 @@
}
ilgrosso merged pull request #264:
URL: https://github.com/apache/syncope/pull/264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso opened a new pull request #265:
URL: https://github.com/apache/syncope/pull/265
Attempting to solve the problems raised in [this ML
thread](https://lists.apache.org/thread.html/913b0e77db9d5bb346a24cd85d9b4393e383700a7998ab249af703f4%40%3Cdev.syncope.apache.org%3E).
--
This is
ilgrosso merged pull request #265:
URL: https://github.com/apache/syncope/pull/265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636028258
##
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##
@@ -96,7 +97,7 @@
}
}
-public
DmitriyBrashevets opened a new pull request #264:
URL: https://github.com/apache/syncope/pull/264
…conf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
DmitriyBrashevets commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636167234
##
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##
@@ -216,28 +217,27 @@
}
ilgrosso commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636173742
##
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##
@@ -216,28 +217,27 @@
}
DmitriyBrashevets commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636195578
##
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##
@@ -216,28 +217,27 @@
}
ilgrosso merged pull request #266:
URL: https://github.com/apache/syncope/pull/266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso merged pull request #267:
URL: https://github.com/apache/syncope/pull/267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
coheigea commented on pull request #268:
URL: https://github.com/apache/syncope/pull/268#issuecomment-848915752
Yes, it does, as does the WADL, openapi + Swagger links.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
coheigea opened a new pull request #268:
URL: https://github.com/apache/syncope/pull/268
As Syncope 2.1.x is stuck on CXF 3.2.x, it is vulnerable to:
http://cxf.apache.org/security-advisories.data/CVE-2020-13954.txt.asc
I confirmed with this PR you can no longer see the
ilgrosso commented on pull request #268:
URL: https://github.com/apache/syncope/pull/268#issuecomment-848907146
@coheigea when you disable service listing, does doc page still works,
a.k.a. /syncope/ which output is similar to
http://syncope.apache.org/rest/2.1/index.html ?
--
This is
coheigea commented on pull request #266:
URL: https://github.com/apache/syncope/pull/266#issuecomment-847764964
Yep exactly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
coheigea opened a new pull request #266:
URL: https://github.com/apache/syncope/pull/266
It's not used since the move to use SSHA-256 by default in MavenUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
coheigea opened a new pull request #267:
URL: https://github.com/apache/syncope/pull/267
…ithm anymore for the admin password
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ilgrosso commented on pull request #267:
URL: https://github.com/apache/syncope/pull/267#issuecomment-847766359
@coheigea please don't forget to cherry-pick this commit to branch `2_1_X`
once merged, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
DmitriyBrashevets commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636167234
##
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##
@@ -216,28 +217,27 @@
}
DmitriyBrashevets commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636180820
##
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##
@@ -48,7 +49,7 @@
private static
DmitriyBrashevets commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636192432
##
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##
@@ -48,7 +49,7 @@
private static
DmitriyBrashevets commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636191747
##
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##
@@ -216,28 +217,27 @@
}
DmitriyBrashevets commented on a change in pull request #264:
URL: https://github.com/apache/syncope/pull/264#discussion_r636195578
##
File path:
core/spring/src/main/java/org/apache/syncope/core/spring/ImplementationManager.java
##
@@ -216,28 +217,27 @@
}
andrea-patricelli opened a new pull request #269:
URL: https://github.com/apache/syncope/pull/269
… single pull
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
ilgrosso commented on pull request #269:
URL: https://github.com/apache/syncope/pull/269#issuecomment-850197309
@andrea-patricelli it seems that Travis CI is failing at
https://travis-ci.com/github/apache/syncope/builds/227158553#L6736
```
PullTaskITCase.remediationSinglePull:845
andrea-patricelli commented on pull request #269:
URL: https://github.com/apache/syncope/pull/269#issuecomment-850264678
> @andrea-patricelli it seems that Travis CI is failing at
https://travis-ci.com/github/apache/syncope/builds/227158553#L6736
>
> ```
>
andrea-patricelli merged pull request #269:
URL: https://github.com/apache/syncope/pull/269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
andrea-patricelli opened a new pull request #271:
URL: https://github.com/apache/syncope/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
ilgrosso opened a new pull request #270:
URL: https://github.com/apache/syncope/pull/270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ilgrosso merged pull request #268:
URL: https://github.com/apache/syncope/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso merged pull request #270:
URL: https://github.com/apache/syncope/pull/270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
andrea-patricelli merged pull request #271:
URL: https://github.com/apache/syncope/pull/271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
ilgrosso merged pull request #272:
URL: https://github.com/apache/syncope/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso opened a new pull request #272:
URL: https://github.com/apache/syncope/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ilgrosso commented on a change in pull request #273:
URL: https://github.com/apache/syncope/pull/273#discussion_r663732471
##
File path: pom.xml
##
@@ -3002,16 +2939,16 @@ under the License.
-common
-core
-client
+
Review comment:
Please
mmoayyed commented on a change in pull request #273:
URL: https://github.com/apache/syncope/pull/273#discussion_r663683511
##
File path: wa/starter/src/main/resources/log4j2.xml
##
@@ -37,9 +37,14 @@ under the License.
-
+
Review comment:
No objections,
mmoayyed commented on a change in pull request #273:
URL: https://github.com/apache/syncope/pull/273#discussion_r663684568
##
File path: wa/starter/src/main/resources/log4j2.xml
##
@@ -37,9 +37,14 @@ under the License.
-
+
Review comment:
OTOH, I think
ilgrosso commented on a change in pull request #273:
URL: https://github.com/apache/syncope/pull/273#discussion_r663656966
##
File path: wa/starter/src/main/resources/log4j2.xml
##
@@ -37,9 +37,14 @@ under the License.
-
+
Review comment:
I think this
loredicola merged pull request #275:
URL: https://github.com/apache/syncope/pull/275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged pull request #276:
URL: https://github.com/apache/syncope/pull/276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mmoayyed commented on pull request #273:
URL: https://github.com/apache/syncope/pull/273#issuecomment-873060998
Update: I am working on fixing/diagnosing issues with OIDC/SAML2 tests.
There are changes that need to be mad to handle dynamic issuers for OIDC, and
almost none belong in the
ilgrosso merged pull request #274:
URL: https://github.com/apache/syncope/pull/274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mmoayyed commented on pull request #273:
URL: https://github.com/apache/syncope/pull/273#issuecomment-878369661
I would prefer to wait since the next RC would be out on a few days. I will
probably do another merge with master right before the rc release to make sure
everything runs ok and
ilgrosso opened a new pull request #277:
URL: https://github.com/apache/syncope/pull/277
…l components
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
ilgrosso opened a new pull request #276:
URL: https://github.com/apache/syncope/pull/276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged pull request #274:
URL: https://github.com/apache/syncope/pull/274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged pull request #276:
URL: https://github.com/apache/syncope/pull/276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso commented on a change in pull request #273:
URL: https://github.com/apache/syncope/pull/273#discussion_r663732471
##
File path: pom.xml
##
@@ -3002,16 +2939,16 @@ under the License.
-common
-core
-client
+
Review comment:
Please
ilgrosso edited a comment on pull request #262:
URL: https://github.com/apache/syncope/pull/262#issuecomment-831143894
~~Still TODO: add a pre-defined `GROUP_OWNER` Role where to place the set of
Entitlements to assign, rather than do it by code~~
--
This is an automated message from
ilgrosso commented on pull request #262:
URL: https://github.com/apache/syncope/pull/262#issuecomment-831143894
Still TODO: add a pre-defined `GROUP_OWNER` Role where to place the set of
Entitlements to assign, rather than do it by code
--
This is an automated message from the Apache
DimaAy opened a new pull request #241:
URL: https://github.com/apache/syncope/pull/241
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ilgrosso commented on a change in pull request #241:
URL: https://github.com/apache/syncope/pull/241#discussion_r566138845
##
File path:
client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/DomainWizardBuilder.java
##
@@ -103,7 +103,7 @@ public
ilgrosso opened a new pull request #252:
URL: https://github.com/apache/syncope/pull/252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ilgrosso merged pull request #249:
URL: https://github.com/apache/syncope/pull/249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso merged pull request #252:
URL: https://github.com/apache/syncope/pull/252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso commented on a change in pull request #251:
URL: https://github.com/apache/syncope/pull/251#discussion_r603822506
##
File path:
common/am/lib/src/main/java/org/apache/syncope/common/lib/wa/ImpersonationAccount.java
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache
mmoayyed commented on a change in pull request #251:
URL: https://github.com/apache/syncope/pull/251#discussion_r603867863
##
File path:
common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/wa/ImpersonationService.java
##
@@ -0,0 +1,65 @@
+/*
+ *
ilgrosso opened a new pull request #255:
URL: https://github.com/apache/syncope/pull/255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ilgrosso merged pull request #254:
URL: https://github.com/apache/syncope/pull/254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso merged pull request #255:
URL: https://github.com/apache/syncope/pull/255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso commented on a change in pull request #251:
URL: https://github.com/apache/syncope/pull/251#discussion_r603231512
##
File path:
core/am/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/wa/ImpersonationServiceImpl.java
##
@@ -0,0 +1,63 @@
+/*
+ *
ilgrosso commented on pull request #251:
URL: https://github.com/apache/syncope/pull/251#issuecomment-809320091
@mmoayyed I think a sub-task of SYNCOPE-1545 would be needed for this
implementation, also to be used in this PR's title and final commit message.
--
This is an automated
ilgrosso opened a new pull request #256:
URL: https://github.com/apache/syncope/pull/256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ilgrosso opened a new pull request #257:
URL: https://github.com/apache/syncope/pull/257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
mmoayyed merged pull request #251:
URL: https://github.com/apache/syncope/pull/251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso merged pull request #257:
URL: https://github.com/apache/syncope/pull/257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
mmoayyed commented on pull request #258:
URL: https://github.com/apache/syncope/pull/258#issuecomment-813973306
It seems like the exceptions are due to the fact that xmlsectool ships with
and leaks opensaml 4.0.1, whereas the configuration requires 4.1.0. I will play
around with some
ilgrosso commented on pull request #258:
URL: https://github.com/apache/syncope/pull/258#issuecomment-813877241
@mmoayyed please merge latest changes from `master` to fix build with Payara.
About CAS / Pac4j upgrade, I am getting the same exceptions locally:
mmoayyed edited a comment on pull request #258:
URL: https://github.com/apache/syncope/pull/258#issuecomment-813973306
It seems like the exceptions are due to the fact that xmlsectool ships with
and leaks opensaml 4.0.1, whereas the configuration requires 4.1.0. I will play
around with
mmoayyed commented on pull request #251:
URL: https://github.com/apache/syncope/pull/251#issuecomment-809470168
Thanks much for the review! I'll take care of the sub-task and other
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ilgrosso opened a new pull request #253:
URL: https://github.com/apache/syncope/pull/253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ilgrosso opened a new pull request #254:
URL: https://github.com/apache/syncope/pull/254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ilgrosso merged pull request #253:
URL: https://github.com/apache/syncope/pull/253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
mmoayyed commented on pull request #258:
URL: https://github.com/apache/syncope/pull/258#issuecomment-814080962
Fixed the exceptions locally. Further testing however shows that there are
number of other issues regarding logout operations for SAML2 and OIDC. So, at
the moment it's not
ilgrosso opened a new pull request #246:
URL: https://github.com/apache/syncope/pull/246
This is an attempt to allow Travis CI run painfully the integration tests
under `fit/wa-reference`
This is an automated message from
mmoayyed commented on a change in pull request #244:
URL: https://github.com/apache/syncope/pull/244#discussion_r594087735
##
File path: wa/starter/src/main/resources/application.properties
##
@@ -40,9 +40,14 @@ management.endpoint.loggers.enabled=true
ilgrosso commented on a change in pull request #244:
URL: https://github.com/apache/syncope/pull/244#discussion_r594091131
##
File path: wa/starter/src/main/resources/application.properties
##
@@ -40,9 +40,14 @@ management.endpoint.loggers.enabled=true
mmoayyed opened a new pull request #247:
URL: https://github.com/apache/syncope/pull/247
When running with initializr in separate servlet container, session tracking
modes are left to their defaults and `SessionConfiguringInitializer` backs
away, as it only affects embedded servlet
mmoayyed merged pull request #244:
URL: https://github.com/apache/syncope/pull/244
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mmoayyed merged pull request #247:
URL: https://github.com/apache/syncope/pull/247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso opened a new pull request #248:
URL: https://github.com/apache/syncope/pull/248
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ilgrosso opened a new pull request #249:
URL: https://github.com/apache/syncope/pull/249
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ilgrosso merged pull request #248:
URL: https://github.com/apache/syncope/pull/248
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ilgrosso opened a new pull request #250:
URL: https://github.com/apache/syncope/pull/250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ilgrosso merged pull request #250:
URL: https://github.com/apache/syncope/pull/250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso opened a new pull request #245:
URL: https://github.com/apache/syncope/pull/245
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ilgrosso commented on a change in pull request #244:
URL: https://github.com/apache/syncope/pull/244#discussion_r592944710
##
File path:
ext/saml2sp4ui/logic/src/main/java/org/apache/syncope/core/logic/SAML2SP4UILogic.java
##
@@ -252,10 +254,10 @@ public SAML2Request
ilgrosso merged pull request #245:
URL: https://github.com/apache/syncope/pull/245
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mdisabatino merged pull request #243:
URL: https://github.com/apache/syncope/pull/243
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mdisabatino closed pull request #242:
URL: https://github.com/apache/syncope/pull/242
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mmoayyed opened a new pull request #244:
URL: https://github.com/apache/syncope/pull/244
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mdisabatino opened a new pull request #243:
URL: https://github.com/apache/syncope/pull/243
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ilgrosso commented on a change in pull request #243:
URL: https://github.com/apache/syncope/pull/243#discussion_r583593878
##
File path:
client/console/src/main/java/org/apache/syncope/client/console/panels/AnyPanel.java
##
@@ -269,7 +269,7 @@ public void onEvent(final IEvent
mdisabatino opened a new pull request #242:
URL: https://github.com/apache/syncope/pull/242
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ilgrosso opened a new pull request #259:
URL: https://github.com/apache/syncope/pull/259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ilgrosso merged pull request #260:
URL: https://github.com/apache/syncope/pull/260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso commented on a change in pull request #258:
URL: https://github.com/apache/syncope/pull/258#discussion_r610533237
##
File path:
fit/wa-reference/src/test/java/org/apache/syncope/fit/ui/SAML2SP4UIITCase.java
##
@@ -156,6 +158,20 @@ public static void idpSetup() {
ilgrosso merged pull request #259:
URL: https://github.com/apache/syncope/pull/259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
ilgrosso opened a new pull request #261:
URL: https://github.com/apache/syncope/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
ilgrosso merged pull request #261:
URL: https://github.com/apache/syncope/pull/261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
301 - 400 of 818 matches
Mail list logo
