ilgrosso commented on code in PR #373:
URL: https://github.com/apache/syncope/pull/373#discussion_r961352502
##
common/am/rest-api/src/main/java/org/apache/syncope/common/rest/api/service/OIDCJWKSService.java:
##
@@ -18,6 +18,8 @@
*/
package
mmoayyed opened a new pull request, #373:
URL: https://github.com/apache/syncope/pull/373
In particular, produce images compatible with ARM architectures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ilgrosso commented on PR #369:
URL: https://github.com/apache/syncope/pull/369#issuecomment-1235296838
@mmoayyed there are some build failures that I believe could be easily fixed:
```
Error: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile
ilgrosso commented on PR #373:
URL: https://github.com/apache/syncope/pull/373#issuecomment-1235326520
@mmoayyed I can confirm that Docker images are built correctly and that I am
able to run them on my `amd64`.
--
This is an automated message from the Apache Git Service.
To respond to
ilgrosso commented on PR #373:
URL: https://github.com/apache/syncope/pull/373#issuecomment-1235335452
@mmoayyed it should be enough to merge from `master`, I've just pushed a
commit to fix the build.
Anyway, no need to wait for it as GH actions don't check for Docker: please
go ahead.
mmoayyed commented on PR #373:
URL: https://github.com/apache/syncope/pull/373#issuecomment-1235287168
Sure, I corrected the commit log.
You can test the builds locally of course, but the true test would be to
actually run the containers on different platforms. I can sort of confirm
mmoayyed merged PR #373:
URL: https://github.com/apache/syncope/pull/373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso commented on PR #373:
URL: https://github.com/apache/syncope/pull/373#issuecomment-1235290890
Thank you @mmoayyed I'll test the images on my `amd64`: there are a few
[docker-compose
samples](https://github.com/apache/syncope/tree/master/docker/src/main/resources/docker-compose)
mmoayyed commented on PR #373:
URL: https://github.com/apache/syncope/pull/373#issuecomment-1235332718
Great news. Should we merge, or would you prefer to wait for the build
status to turn green first?
--
This is an automated message from the Apache Git Service.
To respond to the
ilgrosso commented on PR #373:
URL: https://github.com/apache/syncope/pull/373#issuecomment-1235514316
[This](https://github.com/apache/syncope/commit/0795d3007467ebb698fea4534a172d7e78389f53#diff-fd766026eed3770e4012fd6668e47f1bfeecebebdaa5758f34f2037752e20cf6R48)
should fix it, let's see
ilgrosso commented on PR #373:
URL: https://github.com/apache/syncope/pull/373#issuecomment-1235448413
@mmoayyed so it seems that build is failing for `arm64`:
https://ci-builds.apache.org/job/Syncope/job/Syncope-master-deploy/617/console
```
[INFO] DOCKER> #43 89.63 The following
github-code-scanning[bot] commented on code in PR #374:
URL: https://github.com/apache/syncope/pull/374#discussion_r964871164
##
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/validation/entity/ProvisioningTaskValidator.java:
##
@@ -22,19 +22,13 @@
ilgrosso merged PR #374:
URL: https://github.com/apache/syncope/pull/374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso opened a new pull request, #374:
URL: https://github.com/apache/syncope/pull/374
JPA improvements:
1. using one table per class for tasks, e.g. `PropagationTask`, `PullTask`,
`PushTask`, `NotificationTask`, `SchedTask` instead of single `Task`; this also
implies different
github-code-scanning[bot] commented on code in PR #374:
URL: https://github.com/apache/syncope/pull/374#discussion_r963705548
##
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/validation/entity/ProvisioningTaskValidator.java:
##
@@ -34,7 +35,9 @@
github-code-scanning[bot] commented on code in PR #374:
URL: https://github.com/apache/syncope/pull/374#discussion_r963854270
##
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/propagation/PropagationActions.java:
##
@@ -67,7 +68,7 @@
* @param
ilgrosso merged PR #370:
URL: https://github.com/apache/syncope/pull/370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged PR #371:
URL: https://github.com/apache/syncope/pull/371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso opened a new pull request, #370:
URL: https://github.com/apache/syncope/pull/370
Missing:
- [ ] additional tests
- [ ] docs update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
andrea-patricelli opened a new pull request, #377:
URL: https://github.com/apache/syncope/pull/377
…resent aux classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ilgrosso commented on code in PR #377:
URL: https://github.com/apache/syncope/pull/377#discussion_r982238298
##
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ResourceDataBinderImpl.java:
##
@@ -518,21 +519,21 @@ protected void
ilgrosso commented on code in PR #377:
URL: https://github.com/apache/syncope/pull/377#discussion_r982238145
##
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ResourceDataBinderImpl.java:
##
@@ -518,21 +519,21 @@ protected void
andrea-patricelli merged PR #376:
URL: https://github.com/apache/syncope/pull/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
andrea-patricelli merged PR #377:
URL: https://github.com/apache/syncope/pull/377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso commented on code in PR #376:
URL: https://github.com/apache/syncope/pull/376#discussion_r981224603
##
client/idrepo/console/src/main/java/org/apache/syncope/client/console/audit/AuditHistoryDetails.java:
##
@@ -118,74 +153,176 @@ private static Class cast(final Class
andrea-patricelli commented on code in PR #376:
URL: https://github.com/apache/syncope/pull/376#discussion_r981255912
##
client/idrepo/console/src/main/java/org/apache/syncope/client/console/audit/AuditHistoryDetails.java:
##
@@ -118,74 +153,176 @@ private static Class
andrea-patricelli commented on code in PR #376:
URL: https://github.com/apache/syncope/pull/376#discussion_r981237536
##
common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/types/AuditElements.java:
##
@@ -33,9 +33,9 @@ public enum EventCategoryType {
github-code-scanning[bot] commented on code in PR #376:
URL: https://github.com/apache/syncope/pull/376#discussion_r981357153
##
client/idrepo/console/src/main/java/org/apache/syncope/client/console/audit/AuditHistoryDetails.java:
##
@@ -118,74 +153,176 @@
private static
ilgrosso merged PR #382:
URL: https://github.com/apache/syncope/pull/382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged PR #383:
URL: https://github.com/apache/syncope/pull/383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged PR #384:
URL: https://github.com/apache/syncope/pull/384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-code-scanning[bot] commented on code in PR #383:
URL: https://github.com/apache/syncope/pull/383#discussion_r1006691739
##
core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/ProvisioningActions.java:
##
@@ -28,7 +28,7 @@
* @param
ilgrosso opened a new pull request, #383:
URL: https://github.com/apache/syncope/pull/383
…nsaction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-code-scanning[bot] commented on code in PR #383:
URL: https://github.com/apache/syncope/pull/383#discussion_r1006548975
##
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/LDAPMembershipPullActions.java:
##
@@ -190,15 +212,49 @@
andrea-patricelli closed pull request #375: anytype kind must be lowercase when
invoking auditManager methods
URL: https://github.com/apache/syncope/pull/375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
andrea-patricelli commented on PR #375:
URL: https://github.com/apache/syncope/pull/375#issuecomment-1253773885
This is going to be replaced by PR for SYNCOPE-1695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
andrea-patricelli merged PR #363:
URL: https://github.com/apache/syncope/pull/363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso commented on code in PR #363:
URL: https://github.com/apache/syncope/pull/363#discussion_r966774192
##
client/idrepo/enduser/pom.xml:
##
@@ -269,7 +269,6 @@ under the License.
andrea-patricelli commented on code in PR #363:
URL: https://github.com/apache/syncope/pull/363#discussion_r966777861
##
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java:
##
@@ -197,8 +197,8 @@ protected void onClickTemplate(final
github-code-scanning[bot] commented on code in PR #363:
URL: https://github.com/apache/syncope/pull/363#discussion_r966776924
##
client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/panels/SimpleListViewPanel.java:
##
@@ -0,0 +1,261 @@
+/*
+ * Licensed to
ilgrosso commented on code in PR #363:
URL: https://github.com/apache/syncope/pull/363#discussion_r966780528
##
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java:
##
@@ -197,8 +197,8 @@ protected void onClickTemplate(final AjaxRequestTarget
andrea-patricelli commented on code in PR #363:
URL: https://github.com/apache/syncope/pull/363#discussion_r966817832
##
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java:
##
@@ -197,8 +197,8 @@ protected void onClickTemplate(final
andrea-patricelli commented on code in PR #363:
URL: https://github.com/apache/syncope/pull/363#discussion_r966887525
##
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java:
##
@@ -197,8 +197,8 @@ protected void onClickTemplate(final
ilgrosso commented on code in PR #363:
URL: https://github.com/apache/syncope/pull/363#discussion_r966748439
##
client/idrepo/enduser/pom.xml:
##
@@ -269,7 +269,6 @@ under the License.
andrea-patricelli commented on code in PR #363:
URL: https://github.com/apache/syncope/pull/363#discussion_r966782665
##
client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java:
##
@@ -197,8 +197,8 @@ protected void onClickTemplate(final
ilgrosso commented on code in PR #363:
URL: https://github.com/apache/syncope/pull/363#discussion_r966822041
##
client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/panels/SimpleListViewPanel.java:
##
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apache
andrea-patricelli commented on code in PR #363:
URL: https://github.com/apache/syncope/pull/363#discussion_r966763164
##
client/idrepo/enduser/pom.xml:
##
@@ -269,7 +269,6 @@ under the License.
mmoayyed merged PR #381:
URL: https://github.com/apache/syncope/pull/381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993326009
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993326009
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993342196
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993342196
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993347291
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993304181
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993307335
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on PR #381:
URL: https://github.com/apache/syncope/pull/381#issuecomment-1276033757
I think you can also add a test case to `UserIssuesITCase` like the
following, which would fail with NPE in the current `master`
```java
@Test
public void
mmoayyed commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993324192
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
ilgrosso commented on PR #381:
URL: https://github.com/apache/syncope/pull/381#issuecomment-1276123377
> I think my original implementation of this was correct. Please take
another look.
I agree, all began with my tendence to try to optimize around decoding path
parameters if not
ilgrosso commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993347291
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
mmoayyed commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993389942
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
mmoayyed commented on code in PR #381:
URL: https://github.com/apache/syncope/pull/381#discussion_r993344004
##
core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java:
##
@@ -61,8 +61,23 @@ public abstract class AbstractService
mmoayyed merged PR #380:
URL: https://github.com/apache/syncope/pull/380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mmoayyed commented on PR #381:
URL: https://github.com/apache/syncope/pull/381#issuecomment-1276119538
I think my original implementation of this was correct. Please take another
look. I included your test as well as one extra one to show how this would
work. (Thanks for the test By the
mmoayyed opened a new pull request, #381:
URL: https://github.com/apache/syncope/pull/381
Please see https://issues.apache.org/jira/browse/SYNCOPE-1699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ilgrosso opened a new pull request, #378:
URL: https://github.com/apache/syncope/pull/378
Missing:
- [ ] Macro implementation and tests
- [ ] Console support
- [ ] Docs update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mmoayyed merged PR #379:
URL: https://github.com/apache/syncope/pull/379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-code-scanning[bot] commented on code in PR #378:
URL: https://github.com/apache/syncope/pull/378#discussion_r991202302
##
client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/CommandWrapper.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache
ilgrosso merged PR #378:
URL: https://github.com/apache/syncope/pull/378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-code-scanning[bot] commented on code in PR #378:
URL: https://github.com/apache/syncope/pull/378#discussion_r991060625
##
client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/CommandWizardBuilder.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the
mmoayyed merged PR #369:
URL: https://github.com/apache/syncope/pull/369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso commented on PR #379:
URL: https://github.com/apache/syncope/pull/379#issuecomment-1271455790
@mmoayyed I think you should include here the revert of
SamuelGaro merged PR #368:
URL: https://github.com/apache/syncope/pull/368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso commented on PR #366:
URL: https://github.com/apache/syncope/pull/366#issuecomment-1205165611
Thank you @eeleren !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ilgrosso merged PR #366:
URL: https://github.com/apache/syncope/pull/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged PR #367:
URL: https://github.com/apache/syncope/pull/367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged PR #385:
URL: https://github.com/apache/syncope/pull/385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged PR #397:
URL: https://github.com/apache/syncope/pull/397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso opened a new pull request, #399:
URL: https://github.com/apache/syncope/pull/399
…ionships
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged PR #399:
URL: https://github.com/apache/syncope/pull/399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso commented on PR #398:
URL: https://github.com/apache/syncope/pull/398#issuecomment-1369659086
At this point all looks good but some WA tests failing because of
unavailabilty of Console and Enduser applications.
Once https://github.com/MarcGiffing/wicket-spring-boot/pull/198
ilgrosso merged PR #398:
URL: https://github.com/apache/syncope/pull/398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-code-scanning[bot] commented on code in PR #397:
URL: https://github.com/apache/syncope/pull/397#discussion_r1052126922
##
common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/to/ProvisioningTaskTO.java:
##
@@ -114,6 +111,20 @@
this.matchingRule =
github-code-scanning[bot] commented on code in PR #392:
URL: https://github.com/apache/syncope/pull/392#discussion_r1026451477
##
core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAReportExecDAO.java:
##
@@ -70,16 +70,45 @@
return
ilgrosso merged PR #392:
URL: https://github.com/apache/syncope/pull/392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged PR #393:
URL: https://github.com/apache/syncope/pull/393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged PR #395:
URL: https://github.com/apache/syncope/pull/395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mmoayyed merged PR #391:
URL: https://github.com/apache/syncope/pull/391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged PR #396:
URL: https://github.com/apache/syncope/pull/396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ilgrosso merged PR #394:
URL: https://github.com/apache/syncope/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hboutemy commented on PR #402:
URL: https://github.com/apache/syncope/pull/402#issuecomment-1396554161
@ilgrosso ok, this filtered properties issue is harder: let's see later
I added 2 other fixes
with the 3 fixes in place, the 7 non-reproducible artifact from releases
3.0.0 and 3.0.1
ilgrosso merged PR #404:
URL: https://github.com/apache/syncope/pull/404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hboutemy opened a new pull request, #402:
URL: https://github.com/apache/syncope/pull/402
see https://issues.apache.org/jira/browse/SYNCOPE-1723
this PR fixes one source of non-reproducible bits
for full path in properties, it would be easy to change value in pom.xml
ilgrosso commented on PR #403:
URL: https://github.com/apache/syncope/pull/403#issuecomment-1386657043
Honestly, I don't like much the idea of ditching `gitbox.apache.org` for
GitHub...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ilgrosso commented on PR #403:
URL: https://github.com/apache/syncope/pull/403#issuecomment-1386689299
@hboutemy let's discuss this proposed change in the dev@syncope mailing
list, please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ilgrosso commented on PR #402:
URL: https://github.com/apache/syncope/pull/402#issuecomment-1386596889
Thank for this PR @hboutemy
I see no issues with the proposed change in this PR, e.g. excluding some GIT
properties.
Abouth full-path filtered properties, we haven't been
hboutemy opened a new pull request, #403:
URL: https://github.com/apache/syncope/pull/403
like done on https://maven.apache.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ilgrosso opened a new pull request, #405:
URL: https://github.com/apache/syncope/pull/405
Need to remove the following Maven properties:
- [ ] conf.directory
- [ ] bundles.directory
- [ ] connid.location
- [X ] log.directory
--
This is an automated message from the Apache
ilgrosso commented on PR #405:
URL: https://github.com/apache/syncope/pull/405#issuecomment-1397188174
@hboutemy this is the follow up from #402
First results are encouraging, I'll try to see if all static paths can be
removed altogether.
--
This is an automated message from the
ilgrosso commented on PR #402:
URL: https://github.com/apache/syncope/pull/402#issuecomment-1397042366
@hboutemy I have verified that your changes to archetype are not affecting
any feature so I'll go ahead and merge this PR to `master` then cherry-pick to
`3_0_X` (which is the actual
ilgrosso merged PR #402:
URL: https://github.com/apache/syncope/pull/402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
701 - 800 of 818 matches
Mail list logo
