[GitHub] [syncope] ilgrosso commented on pull request #405: [SYNCOPE-1723] Removing static paths from generated archetypes

2023-01-19 Thread GitBox
ilgrosso commented on PR #405: URL: https://github.com/apache/syncope/pull/405#issuecomment-1397188174 @hboutemy this is the follow up from #402 First results are encouraging, I'll try to see if all static paths can be removed altogether. -- This is an automated message from the

[GitHub] [syncope] ilgrosso opened a new pull request, #405: [SYNCOPE-1723] Removing static paths from generated archetypes

2023-01-19 Thread GitBox
ilgrosso opened a new pull request, #405: URL: https://github.com/apache/syncope/pull/405 Need to remove the following Maven properties: - [ ] conf.directory - [ ] bundles.directory - [ ] connid.location - [X ] log.directory -- This is an automated message from the Apache

[GitHub] [syncope] ilgrosso merged pull request #402: SYNCOPE-1723 remove non-reproducible entries from git.properties

2023-01-19 Thread GitBox
ilgrosso merged PR #402: URL: https://github.com/apache/syncope/pull/402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on pull request #402: SYNCOPE-1723 remove non-reproducible entries from git.properties

2023-01-19 Thread GitBox
ilgrosso commented on PR #402: URL: https://github.com/apache/syncope/pull/402#issuecomment-1397042366 @hboutemy I have verified that your changes to archetype are not affecting any feature so I'll go ahead and merge this PR to `master` then cherry-pick to `3_0_X` (which is the actual

[GitHub] [syncope] ilgrosso merged pull request #404: [SYNCOPE-1724] Providing SyncopeElasticsearchHealthContributor

2023-01-19 Thread GitBox
ilgrosso merged PR #404: URL: https://github.com/apache/syncope/pull/404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] hboutemy commented on pull request #402: SYNCOPE-1723 remove non-reproducible entries from git.properties

2023-01-18 Thread GitBox
hboutemy commented on PR #402: URL: https://github.com/apache/syncope/pull/402#issuecomment-1396554161 @ilgrosso ok, this filtered properties issue is harder: let's see later I added 2 other fixes with the 3 fixes in place, the 7 non-reproducible artifact from releases 3.0.0 and 3.0.1

[GitHub] [syncope] ilgrosso closed pull request #403: add edit button in site breadcrumb

2023-01-18 Thread GitBox
ilgrosso closed pull request #403: add edit button in site breadcrumb URL: https://github.com/apache/syncope/pull/403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [syncope] ilgrosso commented on pull request #403: add edit button in site breadcrumb

2023-01-18 Thread GitBox
ilgrosso commented on PR #403: URL: https://github.com/apache/syncope/pull/403#issuecomment-1396464245 Thank you. I'll close this for now: feel free to reach up our dev mailing list to further discuss this topic, we can always re-open later. -- This is an automated message from the

[GitHub] [syncope] hboutemy commented on pull request #403: add edit button in site breadcrumb

2023-01-18 Thread GitBox
hboutemy commented on PR #403: URL: https://github.com/apache/syncope/pull/403#issuecomment-1387463839 I'll have a look at your ML I understand your relunctance to GH: yes, there is a choice to do to ease access to documentation source or keep everything pointing to Gitbox don't

[GitHub] [syncope] ilgrosso commented on pull request #403: add edit button in site breadcrumb

2023-01-18 Thread GitBox
ilgrosso commented on PR #403: URL: https://github.com/apache/syncope/pull/403#issuecomment-1386689299 @hboutemy let's discuss this proposed change in the dev@syncope mailing list, please -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [syncope] ilgrosso commented on pull request #403: add edit button in site breadcrumb

2023-01-18 Thread GitBox
ilgrosso commented on PR #403: URL: https://github.com/apache/syncope/pull/403#issuecomment-1386657043 Honestly, I don't like much the idea of ditching `gitbox.apache.org` for GitHub... -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [syncope] hboutemy opened a new pull request, #403: add edit button in site breadcrumb

2023-01-18 Thread GitBox
hboutemy opened a new pull request, #403: URL: https://github.com/apache/syncope/pull/403 like done on https://maven.apache.org/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [syncope] ilgrosso commented on pull request #402: SYNCOPE-1723 remove non-reproducible entries from git.properties

2023-01-17 Thread GitBox
ilgrosso commented on PR #402: URL: https://github.com/apache/syncope/pull/402#issuecomment-1386596889 Thank for this PR @hboutemy I see no issues with the proposed change in this PR, e.g. excluding some GIT properties. Abouth full-path filtered properties, we haven't been

[GitHub] [syncope] hboutemy opened a new pull request, #402: SYNCOPE-1723 remove non-reproducible entries from git.properties

2023-01-17 Thread GitBox
hboutemy opened a new pull request, #402: URL: https://github.com/apache/syncope/pull/402 see https://issues.apache.org/jira/browse/SYNCOPE-1723 this PR fixes one source of non-reproducible bits for full path in properties, it would be easy to change value in pom.xml

[GitHub] [syncope] ilgrosso merged pull request #398: [SYNCOPE-1717] Minimum JDK required and dependency versions upgraded

2023-01-12 Thread GitBox
ilgrosso merged PR #398: URL: https://github.com/apache/syncope/pull/398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #399: [SYNCOPE-1719] No more limitations when setting memberships and relationships

2023-01-03 Thread GitBox
ilgrosso merged PR #399: URL: https://github.com/apache/syncope/pull/399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso opened a new pull request, #399: [SYNCOPE-1719] No more limitations when setting memberships and relationships

2023-01-03 Thread GitBox
ilgrosso opened a new pull request, #399: URL: https://github.com/apache/syncope/pull/399 …ionships -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on pull request #398: [SYNCOPE-1717] Minimum JDK required and dependency versions upgraded

2023-01-03 Thread GitBox
ilgrosso commented on PR #398: URL: https://github.com/apache/syncope/pull/398#issuecomment-1369659086 At this point all looks good but some WA tests failing because of unavailabilty of Console and Enduser applications. Once https://github.com/MarcGiffing/wicket-spring-boot/pull/198

[GitHub] [syncope] ilgrosso merged pull request #397: [SYNCOPE-1716] Introducing PushTask's and PullTask's ThreadPoolSettings

2022-12-24 Thread GitBox
ilgrosso merged PR #397: URL: https://github.com/apache/syncope/pull/397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #397: [SYNCOPE-1716] Introducing PushTask's and PullTask's ThreadPoolSettings

2022-12-19 Thread GitBox
github-code-scanning[bot] commented on code in PR #397: URL: https://github.com/apache/syncope/pull/397#discussion_r1052126922 ## common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/to/ProvisioningTaskTO.java: ## @@ -114,6 +111,20 @@ this.matchingRule =

[GitHub] [syncope] ilgrosso merged pull request #396: Empowering Spring Boot best-practices to Console and Enduser

2022-12-01 Thread GitBox
ilgrosso merged PR #396: URL: https://github.com/apache/syncope/pull/396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #395: [SYNCOPE-1697] Improving input and validation of CommandArgs instances

2022-11-29 Thread GitBox
ilgrosso merged PR #395: URL: https://github.com/apache/syncope/pull/395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #394: Consolidating labels into SyncopeSchema to save some joins

2022-11-23 Thread GitBox
ilgrosso merged PR #394: URL: https://github.com/apache/syncope/pull/394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #393: [SYNCOPE-1713] Adding after and before parameter to Audit, Task, Report and Remediation queries (#392)

2022-11-18 Thread GitBox
ilgrosso merged PR #393: URL: https://github.com/apache/syncope/pull/393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #392: [SYNCOPE-1713] Adding after and before parameter to Audit, Task, Report and Remediation queries

2022-11-18 Thread GitBox
ilgrosso merged PR #392: URL: https://github.com/apache/syncope/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #392: [SYNCOPE-1713] Adding after and before parameter to Audit, Task, Report and Remediation queries

2022-11-18 Thread GitBox
github-code-scanning[bot] commented on code in PR #392: URL: https://github.com/apache/syncope/pull/392#discussion_r1026451477 ## core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/JPAReportExecDAO.java: ## @@ -70,16 +70,45 @@ return

[GitHub] [syncope] mmoayyed merged pull request #391: SYNCOPE-1709: Persist Jobs' current status in the database (Backport 2_1_X)

2022-11-16 Thread GitBox
mmoayyed merged PR #391: URL: https://github.com/apache/syncope/pull/391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on a diff in pull request #391: SYNCOPE-1709: Persist Jobs' current status in the database (Backport 2_1_X)

2022-11-15 Thread GitBox
ilgrosso commented on code in PR #391: URL: https://github.com/apache/syncope/pull/391#discussion_r1022915553 ## core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/JobStatusUpdater.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software

[GitHub] [syncope] ilgrosso commented on a diff in pull request #391: SYNCOPE-1709: Persist Jobs' current status in the database (Backport 2_1_X)

2022-11-15 Thread GitBox
ilgrosso commented on code in PR #391: URL: https://github.com/apache/syncope/pull/391#discussion_r1022755891 ## core/logic/src/main/java/org/apache/syncope/core/logic/AbstractExecutableLogic.java: ## @@ -28,19 +26,22 @@ import

[GitHub] [syncope] mmoayyed opened a new pull request, #391: SYNCOPE-1709: Persist Jobs' current status in the database (Backport 2_1_X)

2022-11-15 Thread GitBox
mmoayyed opened a new pull request, #391: URL: https://github.com/apache/syncope/pull/391 Backporting https://github.com/apache/syncope/pull/390 to 2_1_X. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [syncope] mmoayyed merged pull request #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments

2022-11-14 Thread GitBox
mmoayyed merged PR #390: URL: https://github.com/apache/syncope/pull/390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on pull request #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments

2022-11-11 Thread GitBox
ilgrosso commented on PR #390: URL: https://github.com/apache/syncope/pull/390#issuecomment-1311768516 @mmoayyed one checkstyle issue left: ``` Error: src\test\java\org\apache\syncope\core\provisioning\java\job\JobStatusUpdaterTest.java:[30,1] (imports) ImportOrder: Wrong order

[GitHub] [syncope] ilgrosso commented on a diff in pull request #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments

2022-11-11 Thread GitBox
ilgrosso commented on code in PR #390: URL: https://github.com/apache/syncope/pull/390#discussion_r1020137794 ## core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/report/UserReportlet.java: ## @@ -363,11 +362,20 @@ protected int count() {

[GitHub] [syncope] ilgrosso commented on a diff in pull request #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments

2022-11-11 Thread GitBox
ilgrosso commented on code in PR #390: URL: https://github.com/apache/syncope/pull/390#discussion_r1020090342 ## core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/ReportLogic.java: ## @@ -272,8 +274,8 @@ public void exportExecutionResult( final

[GitHub] [syncope] mmoayyed opened a new pull request, #390: SYNCOPE-1709: Persist Jobs' current status in the database to support multi-node deployments

2022-11-11 Thread GitBox
mmoayyed opened a new pull request, #390: URL: https://github.com/apache/syncope/pull/390 ## JIRA https://issues.apache.org/jira/browse/SYNCOPE-1709 I have tested this quite a lot. There are minor issues with the UI but I think most of what I found was the result of me

[GitHub] [syncope] valerio-crescia opened a new pull request, #389: SYNCOPE-1617

2022-11-09 Thread GitBox
valerio-crescia opened a new pull request, #389: URL: https://github.com/apache/syncope/pull/389 Syncope refactoring and initial setup for livesync extension. TODO: - [ ] Add unit and integration for livesync. - [ ] Update

[GitHub] [syncope] ilgrosso merged pull request #388: [SYNCOPE-1696] Adding support to manage Audit entries via Elasticsearch

2022-11-04 Thread GitBox
ilgrosso merged PR #388: URL: https://github.com/apache/syncope/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #387: [SYNCOPE-1696] Adding support to manage Audit entries via Elasticsearch

2022-11-03 Thread GitBox
ilgrosso merged PR #387: URL: https://github.com/apache/syncope/pull/387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #387: [SYNCOPE-1696] Adding support to manage Audit entries via Elasticsearch

2022-11-03 Thread GitBox
github-code-scanning[bot] commented on code in PR #387: URL: https://github.com/apache/syncope/pull/387#discussion_r1012792804 ## ext/elasticsearch/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/dao/ElasticsearchAuditConfDAO.java: ## @@ -0,0 +1,182 @@ +/*

[GitHub] [syncope] ilgrosso merged pull request #386: [SYNCOPE-1708] added extension enable configuration to enduser form layout

2022-11-03 Thread GitBox
ilgrosso merged PR #386: URL: https://github.com/apache/syncope/pull/386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] andrea-patricelli commented on pull request #386: added extension enable configuration to enduser form layout

2022-11-03 Thread GitBox
andrea-patricelli commented on PR #386: URL: https://github.com/apache/syncope/pull/386#issuecomment-1301894204 > @andrea-patricelli please open an issue on JIRA for this improvement done -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [syncope] ilgrosso commented on pull request #386: added extension enable configuration to enduser form layout

2022-11-03 Thread GitBox
ilgrosso commented on PR #386: URL: https://github.com/apache/syncope/pull/386#issuecomment-1301875703 @andrea-patricelli please open an issue on JIRA for this improvement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [syncope] ilgrosso merged pull request #385: [SYNCOPE-1692] Ensure not to ignore attributeDeltas for the rename case

2022-10-31 Thread GitBox
ilgrosso merged PR #385: URL: https://github.com/apache/syncope/pull/385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #384: [SYNCOPE-1706] Notification task not created with event category PROPAGATION

2022-10-28 Thread GitBox
ilgrosso merged PR #384: URL: https://github.com/apache/syncope/pull/384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #383: [SYNCOPE-1705] Encapsulating each object processing into an inner transaction

2022-10-27 Thread GitBox
ilgrosso merged PR #383: URL: https://github.com/apache/syncope/pull/383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #383: [SYNCOPE-1705] Encapsulating each object processing into an inner transaction

2022-10-27 Thread GitBox
github-code-scanning[bot] commented on code in PR #383: URL: https://github.com/apache/syncope/pull/383#discussion_r1006691739 ## core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/pushpull/ProvisioningActions.java: ## @@ -28,7 +28,7 @@ * @param

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #383: [SYNCOPE-1705] Encapsulating each object processing into an inner transaction

2022-10-27 Thread GitBox
github-code-scanning[bot] commented on code in PR #383: URL: https://github.com/apache/syncope/pull/383#discussion_r1006548975 ## core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/LDAPMembershipPullActions.java: ## @@ -190,15 +212,49 @@

[GitHub] [syncope] ilgrosso opened a new pull request, #383: [SYNCOPE-1705] Encapsulating each object processing into an inner transaction

2022-10-27 Thread GitBox
ilgrosso opened a new pull request, #383: URL: https://github.com/apache/syncope/pull/383 …nsaction -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso merged pull request #382: [SYNCOPE-1700] Introducing ojson

2022-10-21 Thread GitBox
ilgrosso merged PR #382: URL: https://github.com/apache/syncope/pull/382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] mmoayyed merged pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
mmoayyed merged PR #381: URL: https://github.com/apache/syncope/pull/381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
ilgrosso commented on PR #381: URL: https://github.com/apache/syncope/pull/381#issuecomment-1276123377 > I think my original implementation of this was correct. Please take another look. I agree, all began with my tendence to try to optimize around decoding path parameters if not

[GitHub] [syncope] mmoayyed commented on pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
mmoayyed commented on PR #381: URL: https://github.com/apache/syncope/pull/381#issuecomment-1276119538 I think my original implementation of this was correct. Please take another look. I included your test as well as one extra one to show how this would work. (Thanks for the test By the

[GitHub] [syncope] mmoayyed commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
mmoayyed commented on code in PR #381: URL: https://github.com/apache/syncope/pull/381#discussion_r993389942 ## core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java: ## @@ -61,8 +61,23 @@ public abstract class AbstractService

[GitHub] [syncope] ilgrosso commented on pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
ilgrosso commented on PR #381: URL: https://github.com/apache/syncope/pull/381#issuecomment-1276033757 I think you can also add a test case to `UserIssuesITCase` like the following, which would fail with NPE in the current `master` ```java @Test public void

[GitHub] [syncope] ilgrosso commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
ilgrosso commented on code in PR #381: URL: https://github.com/apache/syncope/pull/381#discussion_r993347291 ## core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java: ## @@ -61,8 +61,23 @@ public abstract class AbstractService

[GitHub] [syncope] ilgrosso commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
ilgrosso commented on code in PR #381: URL: https://github.com/apache/syncope/pull/381#discussion_r993347291 ## core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java: ## @@ -61,8 +61,23 @@ public abstract class AbstractService

[GitHub] [syncope] mmoayyed commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
mmoayyed commented on code in PR #381: URL: https://github.com/apache/syncope/pull/381#discussion_r993344004 ## core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java: ## @@ -61,8 +61,23 @@ public abstract class AbstractService

[GitHub] [syncope] ilgrosso commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
ilgrosso commented on code in PR #381: URL: https://github.com/apache/syncope/pull/381#discussion_r993342196 ## core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java: ## @@ -61,8 +61,23 @@ public abstract class AbstractService

[GitHub] [syncope] ilgrosso commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
ilgrosso commented on code in PR #381: URL: https://github.com/apache/syncope/pull/381#discussion_r993342196 ## core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java: ## @@ -61,8 +61,23 @@ public abstract class AbstractService

[GitHub] [syncope] ilgrosso commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
ilgrosso commented on code in PR #381: URL: https://github.com/apache/syncope/pull/381#discussion_r993326009 ## core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java: ## @@ -61,8 +61,23 @@ public abstract class AbstractService

[GitHub] [syncope] ilgrosso commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
ilgrosso commented on code in PR #381: URL: https://github.com/apache/syncope/pull/381#discussion_r993326009 ## core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java: ## @@ -61,8 +61,23 @@ public abstract class AbstractService

[GitHub] [syncope] mmoayyed commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
mmoayyed commented on code in PR #381: URL: https://github.com/apache/syncope/pull/381#discussion_r993324192 ## core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java: ## @@ -61,8 +61,23 @@ public abstract class AbstractService

[GitHub] [syncope] mmoayyed merged pull request #380: Remove jitpack.io from the Maven build

2022-10-12 Thread GitBox
mmoayyed merged PR #380: URL: https://github.com/apache/syncope/pull/380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
ilgrosso commented on code in PR #381: URL: https://github.com/apache/syncope/pull/381#discussion_r993307335 ## core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java: ## @@ -61,8 +61,23 @@ public abstract class AbstractService

[GitHub] [syncope] ilgrosso commented on a diff in pull request #381: SYNCOPE-1699: Extract key from path if undefined in request body

2022-10-12 Thread GitBox
ilgrosso commented on code in PR #381: URL: https://github.com/apache/syncope/pull/381#discussion_r993304181 ## core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/AbstractService.java: ## @@ -61,8 +61,23 @@ public abstract class AbstractService

[GitHub] [syncope] mmoayyed opened a new pull request, #381: SYNCOPE-1699: Extract key from path for UserUpdate ops if undefined in request body

2022-10-12 Thread GitBox
mmoayyed opened a new pull request, #381: URL: https://github.com/apache/syncope/pull/381 Please see https://issues.apache.org/jira/browse/SYNCOPE-1699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [syncope] ilgrosso merged pull request #378: [SYNCOPE-1697] Command and Macro introduced

2022-10-10 Thread GitBox
ilgrosso merged PR #378: URL: https://github.com/apache/syncope/pull/378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #378: [SYNCOPE-1697] Command and Macro introduced

2022-10-10 Thread GitBox
github-code-scanning[bot] commented on code in PR #378: URL: https://github.com/apache/syncope/pull/378#discussion_r991202302 ## client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/CommandWrapper.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #378: [SYNCOPE-1697] Command and Macro introduced

2022-10-10 Thread GitBox
github-code-scanning[bot] commented on code in PR #378: URL: https://github.com/apache/syncope/pull/378#discussion_r991060625 ## client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/CommandWizardBuilder.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the

[GitHub] [syncope] mmoayyed merged pull request #379: Update CAS to 6.6.1

2022-10-07 Thread GitBox
mmoayyed merged PR #379: URL: https://github.com/apache/syncope/pull/379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on pull request #379: Update CAS

2022-10-07 Thread GitBox
ilgrosso commented on PR #379: URL: https://github.com/apache/syncope/pull/379#issuecomment-1271455790 @mmoayyed I think you should include here the revert of

[GitHub] [syncope] ilgrosso opened a new pull request, #378: [SYNCOPE-1697] Command and Marco introduced

2022-10-05 Thread GitBox
ilgrosso opened a new pull request, #378: URL: https://github.com/apache/syncope/pull/378 Missing: - [ ] Macro implementation and tests - [ ] Console support - [ ] Docs update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [syncope] andrea-patricelli merged pull request #377: [SYNCOPE-1698] added check to avoid adding to the provision already p…

2022-09-28 Thread GitBox
andrea-patricelli merged PR #377: URL: https://github.com/apache/syncope/pull/377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] ilgrosso commented on a diff in pull request #377: [SYNCOPE-1698] added check to avoid adding to the provision already p…

2022-09-28 Thread GitBox
ilgrosso commented on code in PR #377: URL: https://github.com/apache/syncope/pull/377#discussion_r982238298 ## core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ResourceDataBinderImpl.java: ## @@ -518,21 +519,21 @@ protected void

[GitHub] [syncope] ilgrosso commented on a diff in pull request #377: [SYNCOPE-1698] added check to avoid adding to the provision already p…

2022-09-28 Thread GitBox
ilgrosso commented on code in PR #377: URL: https://github.com/apache/syncope/pull/377#discussion_r982238145 ## core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ResourceDataBinderImpl.java: ## @@ -518,21 +519,21 @@ protected void

[GitHub] [syncope] andrea-patricelli opened a new pull request, #377: [SYNCOPE-1698] added check to avoid adding to the provision already p…

2022-09-28 Thread GitBox
andrea-patricelli opened a new pull request, #377: URL: https://github.com/apache/syncope/pull/377 …resent aux classes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [syncope] andrea-patricelli merged pull request #376: SYNCOPE-1695 audit view improvements

2022-09-28 Thread GitBox
andrea-patricelli merged PR #376: URL: https://github.com/apache/syncope/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #376: SYNCOPE-1695 audit view improvements

2022-09-27 Thread GitBox
github-code-scanning[bot] commented on code in PR #376: URL: https://github.com/apache/syncope/pull/376#discussion_r981357153 ## client/idrepo/console/src/main/java/org/apache/syncope/client/console/audit/AuditHistoryDetails.java: ## @@ -118,74 +153,176 @@ private static

[GitHub] [syncope] andrea-patricelli commented on a diff in pull request #376: SYNCOPE-1695 audit view improvements

2022-09-27 Thread GitBox
andrea-patricelli commented on code in PR #376: URL: https://github.com/apache/syncope/pull/376#discussion_r981255912 ## client/idrepo/console/src/main/java/org/apache/syncope/client/console/audit/AuditHistoryDetails.java: ## @@ -118,74 +153,176 @@ private static Class

[GitHub] [syncope] andrea-patricelli commented on a diff in pull request #376: SYNCOPE-1695 audit view improvements

2022-09-27 Thread GitBox
andrea-patricelli commented on code in PR #376: URL: https://github.com/apache/syncope/pull/376#discussion_r981237536 ## common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/types/AuditElements.java: ## @@ -33,9 +33,9 @@ public enum EventCategoryType {

[GitHub] [syncope] ilgrosso commented on a diff in pull request #376: SYNCOPE-1695 audit view improvements

2022-09-27 Thread GitBox
ilgrosso commented on code in PR #376: URL: https://github.com/apache/syncope/pull/376#discussion_r981224603 ## client/idrepo/console/src/main/java/org/apache/syncope/client/console/audit/AuditHistoryDetails.java: ## @@ -118,74 +153,176 @@ private static Class cast(final Class

[GitHub] [syncope] andrea-patricelli commented on pull request #375: anytype kind must be lowercase when invoking auditManager methods

2022-09-21 Thread GitBox
andrea-patricelli commented on PR #375: URL: https://github.com/apache/syncope/pull/375#issuecomment-1253773885 This is going to be replaced by PR for SYNCOPE-1695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [syncope] andrea-patricelli closed pull request #375: anytype kind must be lowercase when invoking auditManager methods

2022-09-21 Thread GitBox
andrea-patricelli closed pull request #375: anytype kind must be lowercase when invoking auditManager methods URL: https://github.com/apache/syncope/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [syncope] andrea-patricelli merged pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring

2022-09-12 Thread GitBox
andrea-patricelli merged PR #363: URL: https://github.com/apache/syncope/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] andrea-patricelli commented on a diff in pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring

2022-09-09 Thread GitBox
andrea-patricelli commented on code in PR #363: URL: https://github.com/apache/syncope/pull/363#discussion_r966887525 ## client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java: ## @@ -197,8 +197,8 @@ protected void onClickTemplate(final

[GitHub] [syncope] ilgrosso commented on a diff in pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring

2022-09-09 Thread GitBox
ilgrosso commented on code in PR #363: URL: https://github.com/apache/syncope/pull/363#discussion_r966822041 ## client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/panels/SimpleListViewPanel.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache

[GitHub] [syncope] andrea-patricelli commented on a diff in pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring

2022-09-09 Thread GitBox
andrea-patricelli commented on code in PR #363: URL: https://github.com/apache/syncope/pull/363#discussion_r966817832 ## client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java: ## @@ -197,8 +197,8 @@ protected void onClickTemplate(final

[GitHub] [syncope] andrea-patricelli commented on a diff in pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring

2022-09-09 Thread GitBox
andrea-patricelli commented on code in PR #363: URL: https://github.com/apache/syncope/pull/363#discussion_r966782665 ## client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java: ## @@ -197,8 +197,8 @@ protected void onClickTemplate(final

[GitHub] [syncope] ilgrosso commented on a diff in pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring

2022-09-09 Thread GitBox
ilgrosso commented on code in PR #363: URL: https://github.com/apache/syncope/pull/363#discussion_r966780528 ## client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java: ## @@ -197,8 +197,8 @@ protected void onClickTemplate(final AjaxRequestTarget

[GitHub] [syncope] andrea-patricelli commented on a diff in pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring

2022-09-09 Thread GitBox
andrea-patricelli commented on code in PR #363: URL: https://github.com/apache/syncope/pull/363#discussion_r966777861 ## client/idrepo/console/src/main/java/org/apache/syncope/client/console/pages/Realms.java: ## @@ -197,8 +197,8 @@ protected void onClickTemplate(final

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring

2022-09-09 Thread GitBox
github-code-scanning[bot] commented on code in PR #363: URL: https://github.com/apache/syncope/pull/363#discussion_r966776924 ## client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/panels/SimpleListViewPanel.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to

[GitHub] [syncope] ilgrosso commented on a diff in pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring

2022-09-09 Thread GitBox
ilgrosso commented on code in PR #363: URL: https://github.com/apache/syncope/pull/363#discussion_r966774192 ## client/idrepo/enduser/pom.xml: ## @@ -269,7 +269,6 @@ under the License.

[GitHub] [syncope] andrea-patricelli commented on a diff in pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring

2022-09-09 Thread GitBox
andrea-patricelli commented on code in PR #363: URL: https://github.com/apache/syncope/pull/363#discussion_r966763164 ## client/idrepo/enduser/pom.xml: ## @@ -269,7 +269,6 @@ under the License.

[GitHub] [syncope] ilgrosso commented on a diff in pull request #363: [SYNCOPE-1665] show error on propagation failure, made some refactoring

2022-09-09 Thread GitBox
ilgrosso commented on code in PR #363: URL: https://github.com/apache/syncope/pull/363#discussion_r966748439 ## client/idrepo/enduser/pom.xml: ## @@ -269,7 +269,6 @@ under the License.

[GitHub] [syncope] ilgrosso merged pull request #374: Task: one table per class + Preferring JSON arrays to @ElementCollection

2022-09-07 Thread GitBox
ilgrosso merged PR #374: URL: https://github.com/apache/syncope/pull/374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #374: Task: one table per class + Preferring JSON arrays to @ElementCollection

2022-09-07 Thread GitBox
github-code-scanning[bot] commented on code in PR #374: URL: https://github.com/apache/syncope/pull/374#discussion_r964871164 ## core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/validation/entity/ProvisioningTaskValidator.java: ## @@ -22,19 +22,13 @@

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #374: Task: one table per class + Preferring JSON arrays to @ElementCollection

2022-09-06 Thread GitBox
github-code-scanning[bot] commented on code in PR #374: URL: https://github.com/apache/syncope/pull/374#discussion_r963854270 ## core/provisioning-api/src/main/java/org/apache/syncope/core/provisioning/api/propagation/PropagationActions.java: ## @@ -67,7 +68,7 @@ * @param

[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #374: Task: one table per class + Preferring JSON arrays to @ElementCollection

2022-09-06 Thread GitBox
github-code-scanning[bot] commented on code in PR #374: URL: https://github.com/apache/syncope/pull/374#discussion_r963705548 ## core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/validation/entity/ProvisioningTaskValidator.java: ## @@ -34,7 +35,9 @@

[GitHub] [syncope] ilgrosso opened a new pull request, #374: Task: one table per class + Preferring JSON arrays to @ElementCollection

2022-09-06 Thread GitBox
ilgrosso opened a new pull request, #374: URL: https://github.com/apache/syncope/pull/374 JPA improvements: 1. using one table per class for tasks, e.g. `PropagationTask`, `PullTask`, `PushTask`, `NotificationTask`, `SchedTask` instead of single `Task`; this also implies different

[GitHub] [syncope] mmoayyed merged pull request #369: Upgrade CAS/WA in prep for the final 6.6 release

2022-09-05 Thread GitBox
mmoayyed merged PR #369: URL: https://github.com/apache/syncope/pull/369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   4   5   6   7   8   9   >