[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-07 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532214#comment-14532214 ] Konrad Grochowski commented on THRIFT-3130: --- oh, there is a confusion (at least

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-07 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532258#comment-14532258 ] Konrad Grochowski commented on THRIFT-3130: --- after short investigation: when

[jira] [Commented] (THRIFT-3099) cmake build is broken on FreeBSD

2015-05-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533060#comment-14533060 ] ASF GitHub Bot commented on THRIFT-3099: Github user marco-m closed the pull

[jira] [Commented] (THRIFT-3097) cmake targets unconditionally depend on optional libraries

2015-05-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533062#comment-14533062 ] ASF GitHub Bot commented on THRIFT-3097: Github user marco-m closed the pull

[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...

2015-05-07 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/483 THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF Testing proved it was unnecessary. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532548#comment-14532548 ] ASF GitHub Bot commented on THRIFT-3130: Github user jeking3 closed the pull

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532549#comment-14532549 ] ASF GitHub Bot commented on THRIFT-3130: GitHub user jeking3 reopened a pull

[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...

2015-05-07 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2006) TVirtualTransport::readAll_virt core dump

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533825#comment-14533825 ] James E. King, III commented on THRIFT-2006: There should be an upper limit

[jira] [Commented] (THRIFT-2583) Thrift on xPC target (SpeedGoat)

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533860#comment-14533860 ] James E. King, III commented on THRIFT-2583: TSocket and TServerSocket are a

[jira] [Updated] (THRIFT-2006) TBinaryProtocol message header call name length is not validated and can be used to core the server

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2006: --- Summary: TBinaryProtocol message header call name length is not validated and can be

[jira] [Commented] (THRIFT-878) Document core vs extra features

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533841#comment-14533841 ] James E. King, III commented on THRIFT-878: --- Might be easier to do this in a

[jira] [Commented] (THRIFT-1642) Miscalculation lead to throw unexpected TTransportException::TIMED_OUT(or called EAGAIN (timed out)) exception

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533831#comment-14533831 ] James E. King, III commented on THRIFT-1642: I think the use of

[jira] [Updated] (THRIFT-3128) Go generated code produces name collisions between services

2015-05-07 Thread Adam Beberg (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Beberg updated THRIFT-3128: Attachment: THRIFT-3128-Go-name-collisions.patch Test case to break it, patch to fix it. Tested

[jira] [Commented] (THRIFT-2028) Cleanup threading headers / libraries

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533852#comment-14533852 ] James E. King, III commented on THRIFT-2028: Please submit a pull request,

[jira] [Commented] (THRIFT-2353) Unexpected 'No more data to read.' when using TCompactProtocolT

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533856#comment-14533856 ] James E. King, III commented on THRIFT-2353: What are the implications of

[jira] [Commented] (THRIFT-1944) Binding to zero port

2015-05-07 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532578#comment-14532578 ] Ben Craig commented on THRIFT-1944: --- To recap from earlier in the thread... 1)

[jira] [Resolved] (THRIFT-2035) TSSLServerSocket createSocket implementation

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-2035. Resolution: Duplicate Fix Version/s: 0.9.2 Assignee: James E. King,

[jira] [Commented] (THRIFT-747) C++ TSocket-close calls shutdown breaking forked parent process

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532657#comment-14532657 ] James E. King, III commented on THRIFT-747: --- Recommend a decision be made by the

[jira] [Resolved] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-07 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Grochowski resolved THRIFT-3130. --- Resolution: Fixed Fix Version/s: 0.9.3 Assignee: James E. King, III

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532581#comment-14532581 ] ASF GitHub Bot commented on THRIFT-3130: Github user asfgit closed the pull

[jira] [Commented] (THRIFT-1201) getaddrinfo resource leak

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532670#comment-14532670 ] James E. King, III commented on THRIFT-1201: I reviewed there getaddrinfo is

[jira] [Updated] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3130: --- Description: In THRIFT-1316 some macros were added that have proven to be

[jira] [Commented] (THRIFT-1834) Unable to build C++ Thrift dynamic library on Windows

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532647#comment-14532647 ] James E. King, III commented on THRIFT-1834: Some of this is also being

[GitHub] thrift pull request: THRIFT-3130 finish removal of THRIFT_OVERLOAD...

2015-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532649#comment-14532649 ] Hudson commented on THRIFT-3130: SUCCESS: Integrated in Thrift #1536 (See

[jira] [Commented] (THRIFT-424) Steal ProtocolBuffers' VarInt implementation for C++

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532655#comment-14532655 ] James E. King, III commented on THRIFT-424: --- Recommend a decision be made by the

[jira] [Commented] (THRIFT-1676) Allow specifying IP/hostname in TServer::serve

2015-05-07 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532639#comment-14532639 ] James E. King, III commented on THRIFT-1676: Recommend the title of this

[jira] [Assigned] (THRIFT-3130) Remove the last vestiges of THRIFT_OVERLOAD_IF from THRIFT-1316

2015-05-07 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Grochowski reassigned THRIFT-3130: - Assignee: Konrad Grochowski (was: James E. King, III) Remove the last

[jira] [Created] (THRIFT-3131) Make suggested import paths for go thrift library consistent

2015-05-07 Thread Konstantin Shaposhnikov (JIRA)
Konstantin Shaposhnikov created THRIFT-3131: --- Summary: Make suggested import paths for go thrift library consistent Key: THRIFT-3131 URL: https://issues.apache.org/jira/browse/THRIFT-3131

[jira] [Commented] (THRIFT-3131) Make suggested import paths for go thrift library consistent

2015-05-07 Thread Konstantin Shaposhnikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533050#comment-14533050 ] Konstantin Shaposhnikov commented on THRIFT-3131: - A separate related

[jira] [Updated] (THRIFT-3131) Make suggested import path for go thrift library consistent with generated code

2015-05-07 Thread Konstantin Shaposhnikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantin Shaposhnikov updated THRIFT-3131: Summary: Make suggested import path for go thrift library consistent with

[GitHub] thrift pull request: THRIFT-3099 cmake build is broken on FreeBSD

2015-05-07 Thread marco-m
Github user marco-m closed the pull request at: https://github.com/apache/thrift/pull/446 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: Thrift 3097

2015-05-07 Thread marco-m
Github user marco-m closed the pull request at: https://github.com/apache/thrift/pull/443 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is