Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/561
The PropertySerializer doesn't exist in the `tp32` branch, it was only
added to the master. So the problem also only exists in `master`.
---
If your project is set up for it, you can
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/561
TINKERPOP-1635 Fix duplicate serialization of element property in
PropertySerializer
This fixes the duplicate serialization issue in gremlin-python's
PropertySerializer:
[https
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/509
TINKERPOP-1576 gremlin-python calls non-existent methods
https://issues.apache.org/jira/browse/TINKERPOP-1576
This removes the methods `__.__()` and `__.start()` from gremlin
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/509
Yeah, `start()` could really lead to problems in client applications. I
will remove it from the statics.
---
If your project is set up for it, you can reply to this email and have your
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/509
Ok, I wasn't sure whether those methods make sense for a GLV, but it's good
to know as I can now also implement it that way for the C# GLV.
My last commit adds hard-coded
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/509
Sure, the conflicts should be resolved now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/600
TINKERPOP-1552 Add Gremlin-CSharp and Gremlin-DotNet
https://issues.apache.org/jira/browse/TINKERPOP-1552
Organization of the C# project:
- `Gremlin.CSharp` is the C# GLV
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/600
I developed the C# project before in another repository and only used the
development branch in the end to merge it into TinkerPop. That's why it seemed
to go so quickly ð
Do
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/690#discussion_r132150241
--- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs ---
@@ -0,0 +1,55 @@
+#region License
+
+/*
+ * Licensed
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/690#discussion_r132149297
--- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs ---
@@ -0,0 +1,55 @@
+#region License
+
+/*
+ * Licensed
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/690#discussion_r132157746
--- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs ---
@@ -0,0 +1,55 @@
+#region License
+
+/*
+ * Licensed
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/690#discussion_r132156425
--- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs ---
@@ -0,0 +1,55 @@
+#region License
+
+/*
+ * Licensed
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/625
TINKERPOP-1552: Add support for authentication (Plain SASL) to Gremlin.Net
https://issues.apache.org/jira/browse/TINKERPOP-1552
This adds support for authentication with Plain
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/625
cc @jorgebay
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/600
I don't know how it works with Java, but NuGet uses semantic versioning and
treats packages with a suffix as pre-release packages. So something like
`3.2.5-prerelease1` or `3.2.5-beta01
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/600
Thanks!
What's your stance on publishing prerelease packages of the GLVs? That
would allow users to test them out so we can get some early feedback and
additionally graph vendors
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/600
Ok, so for Java you can simply publish new `SNAPSHOT` packages and clients
will always take the latest version?
That won't work for NuGet as it will first search for the package
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/623
TINKERPOP-1552: Minor code cleanup for Gremlin.Net
https://issues.apache.org/jira/browse/TINKERPOP-1552
This mainly removes explicit type castings that are now obsolete thanks
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/627
TINKERPOP-1552: Improve comments in Gremlin-DotNet
https://issues.apache.org/jira/browse/TINKERPOP-1552
This change adds many comments to Gremlin-DotNet, especially for the GLV
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/627
It shouldn't be too hard to create the link, but I don't really know where
to include it. The `summary` element should just include a short description
and the `remarks` element is only
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/629
TINKERPOP-1552: Clean-up Gremlin-DotNet project files
https://issues.apache.org/jira/browse/TINKERPOP-1552
This removes some obsolete configuration options and improves
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/629#discussion_r122388282
--- Diff: gremlin-dotnet/glv/AnonymousTraversal.template ---
@@ -27,6 +27,8 @@ using Gremlin.Net.Structure;
// THIS IS A GENERATED FILE - DO
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/629#discussion_r122460079
--- Diff: gremlin-dotnet/glv/AnonymousTraversal.template ---
@@ -27,6 +27,8 @@ using Gremlin.Net.Structure;
// THIS IS A GENERATED FILE - DO
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/619
Tinkerpop 1552 Reorganize Gremlin-DotNet project
https://issues.apache.org/jira/browse/TINKERPOP-1552
I merged the formerly three .NET projects into just one as discussed
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/704
Thanks for the explanation @spmallette. I was about to ask about the
approach for merging pull requests as the documentation only talks about the
case where separate pull requests
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/704
I just cherry-picked the two commits from @jorgebay's PR and merged tp32
into master afterwards. So master should be in a good state now.
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/719
VOTE: +1
---
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/716#discussion_r139986227
--- Diff: gremlin-dotnet/glv/Gremlin.Net.csproj.template ---
@@ -25,7 +25,9 @@ limitations under the License
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/712
Rebased on tp32, but now one of the two CI builds failed due to a failing
test in `spark-gremlin`:
`SparkContextStorageCheck.shouldSupportDirectoryFileDistinction`. From what I
can see
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/712
Ok, good to know.
In addition to the Gremlin.Net tests, all tests pass with `docker/build.sh
-t -i`.
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/712
@spmallette No problem, I could also have seen that by myself. To be
honest, I just looked at the title of that PR and didn't recognize that it was
about simplifying the GLV generation
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/716#discussion_r139976910
--- Diff: gremlin-dotnet/glv/Gremlin.Net.csproj.template ---
@@ -25,7 +25,9 @@ limitations under the License
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/729
> The .net build is failing:
`Double` seems to be a type that we didn't have in the traversal API until
now. It should be simply mapped to `double` in C#. This should only requ
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/704
> Should we file a different ticket for the pool improvements?
Yes, I think a dedicated ticket for those improvements is a good idea and
it makes probably sense if you cre
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/710#discussion_r138116451
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/Messages/ResponseResult.cs
---
@@ -23,13 +23,14 @@
using System.Collections.Generic
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/710#discussion_r138111430
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/DriverRemoteConnection/GraphTraversalTests.cs
---
@@ -102,9 +102,9
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/710#discussion_r138109326
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/Path3Deserializer.cs ---
@@ -0,0 +1,45 @@
+#region License
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/710#discussion_r138113216
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/DriverRemoteConnection/SideEffectTests.cs
---
@@ -129,10 +139,8
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/704
Thanks for your comments so far, I'll implement the changes you suggested.
I definitely agree that the driver and especially the connection pool needs
to be improved and I would
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/710#discussion_r138366459
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Traversal/DriverRemoteConnection/GraphTraversalTests.cs
---
@@ -102,9 +102,9
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/710
VOTE: +1
---
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/712
TINKERPOP-1752: Gremlin.Net: Generate completely type-safe methods
https://issues.apache.org/jira/browse/TINKERPOP-1752
All steps are now (basically) type-safe and the original
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/712#discussion_r141104538
--- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bytecode.cs ---
@@ -79,7 +85,77 @@ public void AddSource(string sourceName, params
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/712#discussion_r141376043
--- Diff: gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bytecode.cs ---
@@ -79,7 +85,77 @@ public void AddSource(string sourceName, params
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/704
TINKERPOP-1766 Gremlin.Net: Add handling for closed connections
https://issues.apache.org/jira/browse/TINKERPOP-1766
This avoids `Connections` from being added back
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/712
I finally found some time to work on this again and fixed the issues
mentioned by @jorgebay. However, I left the `Bindings` implementation unchanged
despite the problems with concurrent
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/757#discussion_r153193506
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs ---
@@ -86,9 +87,61 @@ public void Reset
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/757
The changes look good to me.
VOTE +1
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/754
With your latest commit all scenarios work for me.
I try to review the changes by the end of the week.
---
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/757#discussion_r153068981
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs ---
@@ -86,9 +87,61 @@ public void Reset
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/754#discussion_r153073133
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs
---
@@ -0,0 +1,472 @@
+#region
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/754#discussion_r153073126
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs
---
@@ -0,0 +1,472 @@
+#region
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/757#discussion_r153126228
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs ---
@@ -86,9 +87,61 @@ public void Reset
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/757#discussion_r153148019
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Process/Traversal/DefaultTraversal.cs ---
@@ -86,9 +87,61 @@ public void Reset
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/758
VOTE +1
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/754
VOTE +1
---
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/741#discussion_r150529077
--- Diff:
gremlin-python/src/main/jython/tests/structure/io/test_graphson.py ---
@@ -121,6 +125,19 @@ class X(object
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/749
VOTE +1
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/752
The separate jobs are really useful.
VOTE +1
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/712
I had to do a few changes during the merge into master which can be seen
[in this
commit](https://github.com/apache/tinkerpop/commit/ab2fd2cadd64a7af1438977ad9d31e9feff16eec),
but now
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/712
> @FlorianHockmann Can we merge this?
Sure, I was on vacation, hence the delay. I'll merge it today.
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/760
I think you got all occurrences of Gremlin-DotNet, so: VOTE +1
---
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/754#discussion_r154526844
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs ---
@@ -0,0 +1,381 @@
+#region License
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/754#discussion_r154526959
--- Diff:
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/DecimalConverter.cs ---
@@ -0,0 +1,34 @@
+#region License
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/761
LGTM, VOTE +1
---
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/867
TINKERPOP-1836 Add Gremlin.Net.Template project
https://issues.apache.org/jira/browse/TINKERPOP-1836
This adds a dotnet template that can be installed and then used to create
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
Probably one of the dependencies of the project has in turn a dependency on
Newtonsoft.Json and wants explicitly version 9 of it and not some higher
version. [The
docs](https
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
Yeah, I also did a quick search but only found dependencies like >= 9.0.0.
> but I'm puzzled why it runs locally
Did you modify your Nuget.config? It's po
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/802
Rebased and removed the hard-coded version. The major and minor version are
now parsed with the `build-helper-maven-plugin` and added as tags to the image
when it's not a `SNAPSHOT
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
Good to see that you resolved the problem with the Newtonsoft.Json version.
I think it makes sense to only support GraphSON types for which we find
good equivalents in .NET
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r188654244
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,88 @@
+#region License
+
+/*
+ * Licensed
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r188661041
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs ---
@@ -167,6 +168,25 @@ public class GremlinClientTests
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r188653381
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs ---
@@ -80,6 +80,7 @@ internal class Connection : IConnection
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r188658381
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,88 @@
+#region License
+
+/*
+ * Licensed
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r188657194
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,88 @@
+#region License
+
+/*
+ * Licensed
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r188655675
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,88 @@
+#region License
+
+/*
+ * Licensed
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r188657021
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,88 @@
+#region License
+
+/*
+ * Licensed
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r188657628
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,88 @@
+#region License
+
+/*
+ * Licensed
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
Yeah, but they all extend `NumberConverter`, don't they? I remember that
there was a decision for gremlin-python a while back to separate serializers
and deserializers in different
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/842#discussion_r188686243
--- Diff:
gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs
---
@@ -39,7 +39,13 @@ public class
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/842#discussion_r188710881
--- Diff:
gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs
---
@@ -39,7 +39,13 @@ public class
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
Great and thanks for your contribution @danielcweber!
VOTE +1
---
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
Rebased and I extended the `gremlin-archetypes` section in the reference
docs by splitting it into two sections: _Maven Archetypes_ and _Gremlin.Net
Template_. In the future, we can add
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
You're right. It shouldn't be necessary to have an internet connection when
all dependencies are already available. I thought that nuget.exe would only be
downloaded once as we have
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
> so if the version changed from 4..4.1
Good point, I haven't considered that. I amended my last commit to include
the solution you proposed. The downloaded exe now sim
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
I'm ok with either direction - either to only support types symmetrically
or try to support at the reading site as much types as possible - as long as we
make that decision clear
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
After thinking a bit more about this, my conclusion was that deprecating
those types doesn't really make sense unless we plan on GraphSON 4.0 as we
couldn't remove the types before
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
In case someone is following here but is not on the dev mailing list:
https://lists.apache.org/thread.html/32c47e8682c2848a9cc90eaff0a0da1f9bf4bd5a94b746a3e143f341
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/842
> @FlorianHockmann Why would we do that? If we can construct (i.e.
deserialize) e.g. a DateTime of whatever a server gives us, fine. Doesn't mean
we have to send (i.e. serialize) obsc
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/868#discussion_r189275849
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/ResultSet.cs ---
@@ -0,0 +1,88 @@
+#region License
+
+/*
+ * Licensed
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
> Or, would it be crazy to only package templates if mono is present?
I think that would be the best solution here. It wouldn't introduce any new
dependencies to the bu
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/802#discussion_r189340476
--- Diff: gremlin-console/pom.xml ---
@@ -336,5 +336,59 @@ limitations under the License
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/802#discussion_r190319039
--- Diff:
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/ResultQueueTest.java
---
@@ -281,7 +281,7 @@ public void
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/802#discussion_r190320705
--- Diff: docs/src/reference/gremlin-applications.asciidoc ---
@@ -353,6 +353,38 @@ variable initialization code into the console.
Like
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/802
No, you're right. That is something that is very unlikely to occur and I
can't think of other (more likely) reasons where the build of the docker images
could fail as they really only
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/868
@ashwini-ms did you see my comment regarding whether `IGremlinClient`
should return a `ResultSet` now instead of an `IReadOnlyCollection`? It's now a
bit hidden as GitHub collapsed
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/802
> what is the advantage to building these images if a .docker file is
present?
A reason to keep this option is that it makes it easier to detect when
changes break the Doc
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
> we require nuget (to run nuget pack) only as part of the deploy phase.
I understand that part and I don't have anything against it, especially
when we add something to the &
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/867#discussion_r195899631
--- Diff: .travis.yml ---
@@ -20,9 +20,13 @@ install:
before_install:
- wget -q
https://packages.microsoft.com/config/ubuntu/14.04
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/867
I just rebased and made the changes so that now the template is only packed
with:
`mvn clean install -Dnuget`.
---
1 - 100 of 207 matches
Mail list logo
