Re: [VOTE] Release Apache Tomcat 10.1.24

2024-05-10 Thread Romain Manni-Bucau
Thanks Mark. +1 then, tested on several embed servers which use the standard artifacts (Yupiik Fusion, Apache Meecrowave apps, ...). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibuca

Re: [VOTE] Release Apache Tomcat 10.1.24

2024-05-10 Thread Romain Manni-Bucau
Hi Christopher, Is it possible to close the staging repo please (I get a 404)? Best, Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rm

Re: [VOTE] Release Apache Tomcat 10.1.22

2024-04-11 Thread Romain Manni-Bucau
+1 (non binding), mainly tested downstream tomcat embedded cases (but using plain artifacts not embed ones). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github &

Re: Stop releasing Tomcat 9 or adding back Tomcat 10.0?

2024-03-29 Thread Romain Manni-Bucau
Proposed that as well, not yet sure since means there is no more cetifiable version but let see. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://g

Re: Stop releasing Tomcat 9 or adding back Tomcat 10.0?

2024-03-29 Thread Romain Manni-Bucau
Le ven. 29 mars 2024 à 13:41, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Romain, > > On 3/29/24 03:18, Romain Manni-Bucau wrote: > > Side note: what I meant about ASF is that there was a help habit between > > communities. I know it got "broken

Re: Stop releasing Tomcat 9 or adding back Tomcat 10.0?

2024-03-29 Thread Romain Manni-Bucau
hristopher Schultz < ch...@christopherschultz.net> a écrit : > Romain, > > On 3/27/24 15:29, Romain Manni-Bucau wrote: > > FYI here is the diff between servlet 5 and 6 API jars: > > > > New API: - jakarta.servlet.ServletConnection Deleted A

Re: Stop releasing Tomcat 9 or adding back Tomcat 10.0?

2024-03-27 Thread Romain Manni-Bucau
idn't have time to check yet - is if the new API are used directly from jakarta package (if so it would fail running with servlet 5 api else it will run smoothly and could be a win-win?). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawe

Re: Stop releasing Tomcat 9 or adding back Tomcat 10.0?

2024-03-27 Thread Romain Manni-Bucau
Ok, let see if we can maybe have an exceptional certification status with servlet 6 as an exception but I doubt (but would make everyone happy) :( Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Ol

Re: Stop releasing Tomcat 9 or adding back Tomcat 10.0?

2024-03-27 Thread Romain Manni-Bucau
Hi Chris, Le mer. 27 mars 2024 à 13:13, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Romain, > > On 3/27/24 06:13, Romain Manni-Bucau wrote: > > Le mer. 27 mars 2024 à 10:58, Rémy Maucherat a écrit : > > > >> On Wed, Mar 27, 2024 at 9:

Re: Stop releasing Tomcat 9 or adding back Tomcat 10.0?

2024-03-27 Thread Romain Manni-Bucau
Le mer. 27 mars 2024 à 10:58, Rémy Maucherat a écrit : > On Wed, Mar 27, 2024 at 9:49 AM Romain Manni-Bucau > wrote: > > > > Hi all, > > > > Checkout out TomEE's notifications I realized Tomcat is in a weirdish > > situation where Tomcat 9 is Servlet 4 and

Re: Stop releasing Tomcat 9 or adding back Tomcat 10.0?

2024-03-27 Thread Romain Manni-Bucau
ing 10.0.x is likely wrong from a community standpoint and at least TomEE would be interested in dropping its fork of Tomcat 10 for that reason. Any way we get back a 10.0 or a 10.1 runnable with Servlet 5.0 API (guess it would be better for everyone)? Romain Manni-Bucau @rmannibucau <

Stop releasing Tomcat 9 or adding back Tomcat 10.0?

2024-03-27 Thread Romain Manni-Bucau
re TCK. Wdyt? Best, Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> |

Re: Observability of virtual threads

2024-03-20 Thread Romain Manni-Bucau
Chris, added some comments inline. Le mer. 20 mars 2024 à 19:41, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Romain, > > On 3/20/24 13:34, Romain Manni-Bucau wrote: > > Thread dumps being dump of threads - literally os threads - and virtual > >

Re: Observability of virtual threads

2024-03-20 Thread Romain Manni-Bucau
Le mer. 20 mars 2024 à 18:43, Rainer Jung a écrit : > Am 20.03.24 um 18:34 schrieb Romain Manni-Bucau: > > Hi Chris, > > > > Thread dumps being dump of threads - literally os threads - and virtual > > threads not being threads at all - they are runnables in a

Re: Observability of virtual threads

2024-03-20 Thread Romain Manni-Bucau
attern for ex. But if you come from a plain sync application it can be very interesting if it stays compatible and you don't need to add throttling to control the memory - often in the old style you throttle with the number of threads, now you need a semaphore or alike. Will not be a free lunch ;).

Re: Observability of virtual threads

2024-03-20 Thread Romain Manni-Bucau
for performance related work but not for hanging investigation (for good since it enables a better scalability in general) so guess it is mainly a habit switch in terms of tools, no? Hope it makes sense. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog

Re: [VOTE] Release Apache Tomcat 10.1.20

2024-03-19 Thread Romain Manni-Bucau
+1 (non-binding), tested on several apps with "AsfEE" stack and Yupiik Fusion, no issue so far. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <

Re: FFM in Tomcat 10.1

2024-02-26 Thread Romain Manni-Bucau
Le lun. 26 févr. 2024 à 13:16, Rémy Maucherat a écrit : > On Fri, Feb 23, 2024 at 4:39 PM Romain Manni-Bucau > wrote: > > > > Hi all, > > > > Sounds very good overall but would be great to not do it at the cost to > > break tomcat IDE support maybe - c

Re: FFM in Tomcat 10.1

2024-02-23 Thread Romain Manni-Bucau
make contributions easy ;). Indeed just my 2cts feedback. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn &

Re: [bug] websocket generics?

2024-01-22 Thread Romain Manni-Bucau
to another module until it is final wouldnt be bad IMHO, in particular while no LTS supports the required code and it still moves, no? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpres

Re: [bug] websocket generics?

2024-01-22 Thread Romain Manni-Bucau
handler = message -> { }; Assert.assertEquals(Object.class, Util.getMessageType(handler)); } So guess we can play the status-quo. Side note: seems ide-intellij ant task got broken with java 22 API usage of the source. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau>

[bug] websocket generics?

2024-01-21 Thread Romain Manni-Bucau
it more concrete. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in

Re: Supposed to provide performance at daemon thread in tomcat

2024-01-15 Thread Romain Manni-Bucau
the root cause of your issue but a side effect. Regards, Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn &

Re: Invalid CVE on sonatype?

2023-10-16 Thread Romain Manni-Bucau
Think it had been done since the report seems to concern v8/v9, this is why from my window sonatype missed a data in their db and it triggers false positives for any recent tomcat build. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.met

Invalid CVE on sonatype?

2023-10-16 Thread Romain Manni-Bucau
more than an actual issue or did I miss something? Should we send a mail to ossin...@sonatype.org to get it fixed? Best, Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com&g

Re: [VOTE] Release Apache Tomcat 10.1.15

2023-10-16 Thread Romain Manni-Bucau
+1, thanks for the quick fix Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in

Re: org.apache.tomcat.jdbc.pool.ConnectionPool interface?

2023-10-10 Thread Romain Manni-Bucau
Thanks a lot Mark. In the mean time using tomcat-jdbc v10.1.13 works as a workaround (but needs to take care of transitive deps). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpres

Re: org.apache.tomcat.jdbc.pool.ConnectionPool interface?

2023-10-10 Thread Romain Manni-Bucau
PS: if it eases the analyzis I guess it is an autoimport/refactor issue: https://github.com/apache/tomcat/commit/a5821ce8ec4626b615a71c9920279a3066735b11#diff-6ec6f1cfd5466f7bef8987d0931a9847d1691c5a81385e4ffd6a7fdb6ddb6cecL371 Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibu

org.apache.tomcat.jdbc.pool.ConnectionPool interface?

2023-10-10 Thread Romain Manni-Bucau
Hi, in 10.1.14 PooledConnection is a class but it is used to create a jvm proxy (org.apache.tomcat.jdbc.pool.ConnectionPool#getProxyConstructor) so it does not work, is it a typo? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.ne

Re: Potential performance improvement

2023-09-13 Thread Romain Manni-Bucau
char set more than the algo? Anyway while it does not add much code a perf boost is always good so +1 too for the reasons you mentionned. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibuca

Re: Hide jakarta.annotations from tomcat-catalina?

2023-07-13 Thread Romain Manni-Bucau
Ok, and doing a tomcat-catalina-xxx which wouldnt target spec explicitly, would more be a http server reusable is not an option too I guess? So for the record I guess the best option is to switch to SimpleInstanceManager automatically. Thanks for the clarification Mark. Romain Manni-Bucau

Re: multipart streaming as fileupload native usage?

2023-07-12 Thread Romain Manni-Bucau
Le mer. 12 juil. 2023 à 17:53, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Romain, > > On 7/11/23 08:57, Romain Manni-Bucau wrote: > > on commons fileupload list there was the need to have streaming for > Parts. > > > > As of today Se

Re: Hide jakarta.annotations from tomcat-catalina?

2023-07-12 Thread Romain Manni-Bucau
Le mer. 12 juil. 2023 à 10:47, Mark Thomas a écrit : > On 07/07/2023 09:33, Romain Manni-Bucau wrote: > > Hi, > > > > Do you think we can make jakarta.annotations optional from > tomcat-catalina? > > Would ease IDE completion when this is not supported and tomcat i

multipart streaming as fileupload native usage?

2023-07-11 Thread Romain Manni-Bucau
want to provide this thru the current API implementing a LazyList (while only Iterator is touched the list is not materialized)? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com&g

Hide jakarta.annotations from tomcat-catalina?

2023-07-07 Thread Romain Manni-Bucau
Hi, Do you think we can make jakarta.annotations optional from tomcat-catalina? Would ease IDE completion when this is not supported and tomcat is wrapped in another web api. Technically it does not look crazy but wonder if it can end upstream.

Re: Tomcat and filesystems

2023-06-26 Thread Romain Manni-Bucau
If it helps, here is a draft: https://github.com/apache/tomcat/pull/630 Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibuc

Tomcat and filesystems

2023-06-25 Thread Romain Manni-Bucau
? It would enable to not only rely on local filesystem but also more exotic ones (in mem for ex). Was it already discussed/studied? Would it makes sense in tomcat codebase? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Ol

Re: [tomcat] branch main updated: Add control of byte decoding errors to ByteChunk and StringCache

2023-06-23 Thread Romain Manni-Bucau
the annotation processor, really nothing crazy IMHO on that part (hard one is to use Blackhole properly and tune the jvm for the bench) but happy to help if needed. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Ol

Re: Tomcat, Jakarta TCKs and Arquillian

2023-06-21 Thread Romain Manni-Bucau
t been > migrated yet) run in just over 5 mins and I haven't even looked at > tuning (parallel) options yet. > > Mark > > > > > Rémy > > > >> Mark > >> > >> > >> > >> On 16/06/2023 20:18, Mark Thomas wrote: > >>>

Re: Tomcat, Jakarta TCKs and Arquillian

2023-06-16 Thread Romain Manni-Bucau
k > > > > On 16/06/2023 16:34, Romain Manni-Bucau wrote: > > Hi Mark, > > > > On TomEE side (and other spec impl ones) we had a hybrid approach: > > > > * Add arquillian container properties when reusable (ex: context > > customization for tomcat

Re: Tomcat, Jakarta TCKs and Arquillian

2023-06-16 Thread Romain Manni-Bucau
arquillian.xml for this particular case or if not willed, let tomcat-tck module patch the default container to do it programmatically specifically for tck runner. Kind of least worse compromise IMHO. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog

Re: Java 21 and virtual threads

2023-05-05 Thread Romain Manni-Bucau
+1 for java 21, since tomcat 11 is still in the "dont use" area I think it can start with 21 and thanks to the backport policy if java 17 is needed later, work will not be crazy IMHO. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmann

Re: Workaround for misbehaving ClassLoader

2023-05-03 Thread Romain Manni-Bucau
a fix it since this one is very trivial to do in the failing project ([1]). [1] https://github.com/CodeGerm/osgi-server/blob/master/plugins/org.cg.dao.webcontainer/src/org/cg/dao/webcontainer/tomcat/DaoClassLoader.java#L132 Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> |

Re: Utility Executor

2023-04-28 Thread Romain Manni-Bucau
Le ven. 28 avr. 2023 à 11:55, Rémy Maucherat a écrit : > On Fri, Apr 28, 2023 at 9:02 AM Romain Manni-Bucau > wrote: > > > > Le ven. 28 avr. 2023 à 08:36, Rémy Maucherat a écrit : > > > > > On Fri, Apr 28, 2023 at 8:10 AM Romain Manni-Bucau

Re: Utility Executor

2023-04-28 Thread Romain Manni-Bucau
Le ven. 28 avr. 2023 à 08:36, Rémy Maucherat a écrit : > On Fri, Apr 28, 2023 at 8:10 AM Romain Manni-Bucau > wrote: > > > > Hi > > > > Guess this utility should be there very early so before other > starts/stops > > sounds good but ultimately init/destro

Re: Utility Executor

2023-04-28 Thread Romain Manni-Bucau
Hi Guess this utility should be there very early so before other starts/stops sounds good but ultimately init/destroy is better since it avoids to create custom utility threads in subcomponents init/destroy (more destroy for real cases I think, not sure for init). What about getting it injected

Re: sendfile and async?

2023-04-21 Thread Romain Manni-Bucau
jeu. 20 avr. 2023 à 22:30, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Rmoain, > > On 4/20/23 15:27, Romain Manni-Bucau wrote: > > I just notice using nio connector+sendfile+asynccontext seems quite not > > functional, is it intended? > >

sendfile and async?

2023-04-20 Thread Romain Manni-Bucau
this sendfile issue with such a mode. Is it intended or just part of the code which didnt get enough love? Best, Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github &

Re: Support of ReadListener for Reader?

2023-04-03 Thread Romain Manni-Bucau
Overall +1 but in the meantime what's the option, not using req.getReader? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibuc

Support of ReadListener for Reader?

2023-04-02 Thread Romain Manni-Bucau
if RequestFacade would be casted as such or if some Unwrap API can help but it would really help to promote this API without enforcing InputStream usage which can make the code not respecting the encoding quite easily - or enforce to duplicate servlet logic and its optimizations. Wdyt? Best, Romain Manni

Re: PersistentManager, PersistentValve, and DataSource/JDBCStore can cause PK violations

2023-03-08 Thread Romain Manni-Bucau
Le mer. 8 mars 2023 à 16:23, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Romain, > > On 3/8/23 04:10, Romain Manni-Bucau wrote: > > Seems doing it only there will get back to the issue the synchronization > > was introduced (there are other synch

Re: PersistentManager, PersistentValve, and DataSource/JDBCStore can cause PK violations

2023-03-08 Thread Romain Manni-Bucau
but more complex) solution so not sure which compromise is the best. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn

Re: Loom research

2023-02-28 Thread Romain Manni-Bucau
only the pool to configure IMHO and tomcat could autoswitch to loom when available :). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rm

Re: Loom research

2023-02-27 Thread Romain Manni-Bucau
Le lun. 27 févr. 2023 à 20:21, Mark Thomas a écrit : > On 27/02/2023 18:02, Romain Manni-Bucau wrote:> Le lun. 27 févr. 2023 à > 18:38, Mark Thomas a écrit : > > > >> On 27/02/2023 17:09, Romain Manni-Bucau wrote: > >>> Hi, > >>> > >>&g

Re: Loom research

2023-02-27 Thread Romain Manni-Bucau
Le lun. 27 févr. 2023 à 18:38, Mark Thomas a écrit : > On 27/02/2023 17:09, Romain Manni-Bucau wrote: > > Hi, > > > > AFAIK loom or a standard thread pool are exactly the same except when you > > use loom you need to ensure you pass the contextual executor to use >

Re: Loom research

2023-02-27 Thread Romain Manni-Bucau
/ThreadBuilders(Executor) to configure it and pass a standard executor to it. Hope it makes sense. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://g

Re: [tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread Romain Manni-Bucau
Le mar. 24 janv. 2023 à 14:48, Rémy Maucherat a écrit : > On Tue, Jan 24, 2023 at 2:37 PM Romain Manni-Bucau > wrote: > > > > here is the idea https://github.com/apache/tomcat/pull/576 > > People care about stats these days and the performance benefit of > disabli

Re: [tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread Romain Manni-Bucau
here is the idea https://github.com/apache/tomcat/pull/576 Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn &

Re: [tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread Romain Manni-Bucau
If you care about the (perf) diff, shouldnt tomcat have a config to be able to disable stats overhead at all (using a Runnable or Counter {incr(), get()} as abstraction is sufficient) when it is not used (most of the time in dev+prod - ie not sizing/tuning phases)? Romain Manni-Bucau @rmannibucau

Re: Tomcat 11 - minimum Java version

2023-01-11 Thread Romain Manni-Bucau
Guess it was more about default java for linux distro, build is only reproducible if target --release flag is <= java distro version which will not be the case for java 21 soon enough probably, not really a build issue by itself more an ecosystem one - distro consumming sources. Le mer. 11 janv.

Re: Tomcat 11 - minimum Java version

2023-01-11 Thread Romain Manni-Bucau
Side question from an user standpoint: does it mean tomcat 11 must not be used today too since it will abruptally switch its baseline (potentially against the app baseline)? Isnt it against the 11 releases idea? Thinking out loud and understanding jakarta decision is likely "weird"/inconsistent

Re: Tomcat 11 - minimum Java version

2023-01-11 Thread Romain Manni-Bucau
Hi, As an user we are adopting Tomcat 11 (even if still "on the edge") with Java 17 (in particular for some lib/stacks) and the more reactive servlet 6.1 is very interesting so hope it can be made Java 17 compliant until technically blocked. Romain Manni-Bucau @rmannibucau <https:

Any graalvm diet planned?

2023-01-06 Thread Romain Manni-Bucau
/RestrictedServlets\\.properties"}, {"pattern": "org\\/apache\\/catalina\\/core\\/RestrictedFilters\\.properties"}, {"pattern": "org\\/apache\\/catalina\\/core\\/RestrictedListeners\\.properties"}, {"pattern": "org\\/ap

Re: Extended access log valve merged with AbstractAccessLogValve?

2022-12-12 Thread Romain Manni-Bucau
ossible. I don't see a big negative effect to support tomcat extensions in the abstract impl so I'm proposing it as an option. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com>

Extended access log valve merged with AbstractAccessLogValve?

2022-12-12 Thread Romain Manni-Bucau
sted and I need to do a PR, would be more than happy to help if relevant. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |

Re: [VOTE] Release Apache Tomcat 11.0.0-M1

2022-12-02 Thread Romain Manni-Bucau
[X] Stable (non binding) tested on a few downstream projects (like Yupiik Uship or Apache OpenWebBeans Meecrowave - based on 10.x as of today) and detected no issue. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Ol

Re: CDI and injection issues

2022-11-24 Thread Romain Manni-Bucau
Le jeu. 24 nov. 2022 à 16:58, Rémy Maucherat a écrit : > On Thu, Nov 24, 2022 at 10:19 AM Romain Manni-Bucau > wrote: > > > > Le jeu. 24 nov. 2022 à 10:13, Rémy Maucherat a écrit : > > > > > On Wed, Nov 23, 2022 at 11:10 AM Romain Manni-Bucau &

Re: CDI and injection issues

2022-11-24 Thread Romain Manni-Bucau
Le jeu. 24 nov. 2022 à 10:13, Rémy Maucherat a écrit : > On Wed, Nov 23, 2022 at 11:10 AM Romain Manni-Bucau > wrote: > > > > Well, it is not that simple. > > > > Two notes on that: > > > > 1. One point is the API, injector and instance manager are th

Re: CDI and injection issues

2022-11-23 Thread Romain Manni-Bucau
rg/apache/meecrowave/tomcat/CDIInstanceManager.java and it is very few lines so not sure the injector would help much more for a tomcat-cdi integration. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://

Re: CDI and injection issues

2022-11-22 Thread Romain Manni-Bucau
. Guess you don't have this issue but something making it easier to handle can also probably be welcomed by consumers. Le mar. 22 nov. 2022 à 17:26, Rémy Maucherat a écrit : > On Tue, Nov 22, 2022 at 4:30 PM Romain Manni-Bucau > wrote: > > > > Hi Rémy, > > > > I pu

Re: CDI and injection issues

2022-11-22 Thread Romain Manni-Bucau
Hi Rémy, I put a few comments inline hoping it helps Le mar. 22 nov. 2022 à 16:11, Rémy Maucherat a écrit : > Hi, > > Following a post on the user list, I have looked into CDI and > injection processing in Tomcat standalone (or standalone extended by > CDI) and found the following issues: >

Re: Security manager support

2022-10-02 Thread Romain Manni-Bucau
Hi, If it helps, commons weaver ( https://commons.apache.org/proper/commons-weaver/commons-weaver-parent/commons-weaver-modules-parent/commons-weaver-privilizer-parent/index.html) can help for the backport part (enable or not the run in build.xml). Romain Le dim. 2 oct. 2022 à 06:42,

Re: jakarta.el, useless getResource?

2022-08-25 Thread Romain Manni-Bucau
Hi Chris, My x10 dropping it was on java 17. Romain Le ven. 26 août 2022 à 02:39, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Mark, > > On 8/22/22 07:54, Mark Thomas wrote: > > On 22/08/2022 11:48, Mark Thomas wrote: > >> On 22/08/2022 1

Re: jakarta.el, useless getResource?

2022-08-24 Thread Romain Manni-Bucau
Hi Went ahead and created https://github.com/apache/tomcat/pull/547 (if it helps) Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rm

Re: jakarta.el, useless getResource?

2022-08-22 Thread Romain Manni-Bucau
s the perf there too - a lot when enabled. Side note: graalvm integration is way easier without that check ;). Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <

jakarta.el, useless getResource?

2022-08-22 Thread Romain Manni-Bucau
missed items be cached in some (webapp) classloader to help to exit faster? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau>

Re: Tomcat embed packaging clarification

2022-05-20 Thread Romain Manni-Bucau
Le ven. 20 mai 2022 à 12:10, Mark Thomas a écrit : > On 20/05/2022 10:36, Romain Manni-Bucau wrote: > > Hi all, > > > > Checking a project with multiple tomcat integrators (spring boot, uship, > > meecrowave, tomee, ...) I realised Tomcat ecosystem is quite explo

Tomcat embed packaging clarification

2022-05-20 Thread Romain Manni-Bucau
cal. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <

Re: Tomcat mitigations for CVE-2022-21449

2022-04-29 Thread Romain Manni-Bucau
Hi Openj9 is not affected I think so version wouldnt be enough, jvm name should be tested too. Le sam. 30 avr. 2022 à 00:18, Mark Thomas a écrit : > On 29/04/2022 19:41, Christopher Schultz wrote: > > > > > 1. The underlying JVM is affected > > 2. A Connector is defined with uses mutual TLS >

Re: ULRStreamHandlerFactory proposal

2022-02-17 Thread Romain Manni-Bucau
+1 to encourage Oracle to make the JVM support nicer and plural but I'm not sure it will happen tomorrow so there are still rooms to enhance tomcat "integrability" way before IMHO. Hope it makes sense. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau>

Re: Reproducible builds update

2022-01-18 Thread Romain Manni-Bucau
the few classes you want. Also wonder if you tried -notimestamp option. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibuc

Re: Enable to "json stringify" access logs

2021-12-24 Thread Romain Manni-Bucau
Le jeu. 23 déc. 2021 à 22:53, Christopher Schultz < ch...@christopherschultz.net> a écrit : > Romain, > > On 12/18/21 14:28, Romain Manni-Bucau wrote: > > I wonder if you would be interested in an access log "function" enabling > to > > make an access log e

Enable to "json stringify" access logs

2021-12-18 Thread Romain Manni-Bucau
cation which would benefit from some json encoding is org.apache.catalina.valves.JsonErrorReportValve#report since currently it produces invalid json depending the message value. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/>

Re: default context path

2021-11-26 Thread Romain Manni-Bucau
sense. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <htt

Re: Drop module-info from tomcat*.jar?

2021-09-15 Thread Romain Manni-Bucau
Le mer. 15 sept. 2021 à 13:13, Mark Thomas a écrit : > On 15/09/2021 11:07, Romain Manni-Bucau wrote: > > I think the last option is maybe the target: modularize tomcat properly. > > "Properly" is a highly subjective judgement. There are going to be > wildly differi

Re: Drop module-info from tomcat*.jar?

2021-09-15 Thread Romain Manni-Bucau
regarding JPMS I think it is either being really modular or not being modular since the in between state leads to unsatisfied people and the biggest constraints come from JPMS. Is it something targettable or do you think it is too much work? side note: fine for me if it targets only 10.1. Romain M

Drop module-info from tomcat*.jar?

2021-09-15 Thread Romain Manni-Bucau
but happy with other solutions not requiring to fork. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <ht

Re: Graal now supports JMX?

2021-07-08 Thread Romain Manni-Bucau
Le jeu. 8 juil. 2021 à 15:36, Rémy Maucherat a écrit : > On Thu, Jul 8, 2021 at 1:21 PM Romain Manni-Bucau > wrote: > > > > Hi Mark, > > > > My understanding of the issue is that the isGraal test is not sufficient > > and should be precised to be

Re: Graal now supports JMX?

2021-07-08 Thread Romain Manni-Bucau
is not precise enough but that the disabling should stay by default for native-image. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rm

Re: Time to create Tomcat 10.1.x and master->main migration

2021-05-18 Thread Romain Manni-Bucau
+1 to move forward even if jakarta is not yet adopted (there is a single time direction - at least at our scale ;)) -0 to break all clones and related toolings/automotion for hypothetical reasons, didn't pay in all projects which did AFAIK Romain Manni-Bucau @rmannibucau <https://twitter.

Re: [VOTE] Release Apache Tomcat 10.0.6

2021-05-10 Thread Romain Manni-Bucau
+1, new instance manager usage for websocket layer works perfectly! Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibuc

server.json?

2021-05-08 Thread Romain Manni-Bucau
ruby, python and more recently typescript where XML is not so lovely to use so think JSON can help automotion there. Wdyt? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com&g

Re: Implementing web.xml default-context-path

2021-05-05 Thread Romain Manni-Bucau
Le mer. 5 mai 2021 à 11:19, Mark Thomas a écrit : > On 05/05/2021 09:58, Rémy Maucherat wrote: > > On Sun, May 2, 2021 at 3:17 PM Jean-Louis MONTEIRO > > wrote: > > > >> Hi, > >> > >> Still working on getting TomEE certified for Jakarta EE 9.1 > >> We are using latest Tomcat 10.x and we indeed

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.0

2021-05-04 Thread Romain Manni-Bucau
+1, xml fix is helping Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in

Re: mod_headers as a Filter

2021-04-27 Thread Romain Manni-Bucau
Isnt the response buffer size giving a sufficient hint or callback like (dont rewrite before it is reached or body starts to be read)? Guess filter must force some size if not set but sounds like something to check, no? Le mar. 27 avr. 2021 à 21:32, Raymond Augé a écrit : > Couldn't you add a

Re: [PROPOSAL] Deprecate JAAS Realm in 10.0.x and remove in 10.1.x

2021-04-27 Thread Romain Manni-Bucau
"glue" to compensate a drop or is it still "too much" to maintain in your opinion? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://

Re: Websocket server configurator as @ServiceProvider: a bug?

2021-04-26 Thread Romain Manni-Bucau
n > > in another jar usable when not relying on tomcat-ws-api. Both options > work > > too even if first one would be simpler probably. > > > > Le jeu. 22 avr. 2021 à 18:29, Raymond Augé .invalid> > > a écrit : > > > >> Romain are yo

Re: [PROPOSAL] Deprecate JAAS Realm in 10.0.x and remove in 10.1.x

2021-04-26 Thread Romain Manni-Bucau
Le lun. 26 avr. 2021 à 18:57, Mark Thomas a écrit : > On 26/04/2021 17:38, Romain Manni-Bucau wrote: > > JAASRealm is quite commonly used whereas JASPIC is almost never used > > References? > Sadly not public but all project not using a custom valve/auth where using jaas

Re: Clarify what Tomcat means with "Jakarta EE 9 "mention

2021-04-26 Thread Romain Manni-Bucau
Thanks a lot! Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> |

Re: [PROPOSAL] Deprecate JAAS Realm in 10.0.x and remove in 10.1.x

2021-04-26 Thread Romain Manni-Bucau
are not so it means you easily find a JAAS login module implementation and you don't find integrations for others so think it makes sense to keep JAAS integration more than others in default delivery. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog

  1   2   3   4   5   >