Re: WebSocket progress report

2013-03-09 Thread Nick Williams
On Mar 7, 2013, at 5:33 PM, Mark Thomas wrote: The current status of the WebSocket implementation is largely complete. The remaining TODOs are (in roughly the order I intend to tackle them): 1. Implement decoding 2. Figure out why there are failures in Autobahn with WSS and NIO and

Re: WebSocket progress report

2013-03-09 Thread Mark Thomas
On 09/03/2013 15:29, Nick Williams wrote: On Mar 7, 2013, at 5:33 PM, Mark Thomas wrote: The current status of the WebSocket implementation is largely complete. The remaining TODOs are (in roughly the order I intend to tackle them): 1. Implement decoding 2. Figure out why there are

Re: WebSocket progress report

2013-01-14 Thread Mark Thomas
On 21/12/2012 23:13, Mark Thomas wrote: After that, I intend to run the Autobahn test suite and fix any issues that identifies. Passes for BIO and NIO. ~30 failures for APR/native Next step will be to look at making the buffer sizes configurable to address the failures above before moving on

Re: WebSocket progress report

2012-12-21 Thread Mark Thomas
On 12/12/2012 21:23, Mark Thomas wrote: The next step is to implement support for outgoing messages from server endpoints. Done. Once that is in place, I will update the examples to use the new implementation and fix any issues that identifies. Done. After that, I intend to run the

Re: WebSocket progress report

2012-02-23 Thread Mark Thomas
On 23/02/2012 01:32, Petr Praus wrote: On Mon, Feb 20, 2012 at 16:19, Mark Thomas ma...@apache.org wrote: Haven't looked too hard at those yet. Assuming Java can tell the UTF-8 is invalid then handling that should be easy. Yes, except that the java CharsetDecoder didn't seem to think that

Re: WebSocket progress report

2012-02-22 Thread Petr Praus
On Mon, Feb 20, 2012 at 16:19, Mark Thomas ma...@apache.org wrote: On 20/02/2012 21:28, Petr Praus wrote: I'm glad to hear that. BTW, Jonathan quite significantly overhauled our implementation over the weekend. The WebSocketFrame no longer buffers data but just stores a reference to

Re: WebSocket progress report

2012-02-20 Thread Mark Thomas
On 20/02/2012 02:55, Petr Praus wrote: Hi Mark, I noticed you wrote a websocket test client, I haven't looked at it extensively It won't take long to look at - it is a very simple client. but I wanted to ask - have you considered using Autobahn for testing? It's rather extensive opensource

Re: WebSocket progress report

2012-02-20 Thread Mark Thomas
On 20/02/2012 10:04, Mark Thomas wrote: On 20/02/2012 02:55, Petr Praus wrote: but I wanted to ask - have you considered using Autobahn for testing? It's rather extensive opensource websocket testing suite. I haven't. I just took a quick look. Looks like a nice tool. My test client is

Re: WebSocket progress report

2012-02-20 Thread Petr Praus
I'm glad to hear that. BTW, Jonathan quite significantly overhauled our implementation over the weekend. The WebSocketFrame no longer buffers data but just stores a reference to inputstream from which the data can be read by the client code receiving the frame. This is not exactly what you

Re: WebSocket progress report

2012-02-20 Thread Mark Thomas
On 20/02/2012 21:28, Petr Praus wrote: I'm glad to hear that. BTW, Jonathan quite significantly overhauled our implementation over the weekend. The WebSocketFrame no longer buffers data but just stores a reference to inputstream from which the data can be read by the client code receiving

Re: WebSocket progress report

2012-02-20 Thread Mark Thomas
On 20/02/2012 22:19, Mark Thomas wrote: Based on progress today, things should move along pretty quickly. Next step is to get ping/pong working. Yep. Progress has been pretty quick. Ping/pong tests (section 2) now all pass as do sections 3 (reserved bits) and 4 (opcodes). There are a few

Re: WebSocket progress report

2012-02-19 Thread Petr Praus
Hi Mark, I noticed you wrote a websocket test client, I haven't looked at it extensively but I wanted to ask - have you considered using Autobahn for testing? It's rather extensive opensource websocket testing suite. It already contains a lot of stuff we need to test including fragmentation

Re: WebSocket progress report

2012-02-17 Thread Mark Thomas
On 16/02/2012 04:01, Petr Praus wrote: Hello, attached is our patch. It applies cleanly on top of current trunk rev. 1244719. It has rudimentary support for fragmentation (callback after last frame), supports close messages and ping/pong. Sorry for not sending a patchset but I thought it

Re: WebSocket progress report

2012-02-16 Thread Petr Praus
Thanks Johno Crawford for pointing out that attachments are stripped, I uploaded the patch here: https://gist.github.com/1844837 On Wed, Feb 15, 2012 at 22:01, Petr Praus p...@praus.net wrote: Hello, attached is our patch. It applies cleanly on top of current trunk rev. 1244719. It has

Re: WebSocket progress report

2012-02-15 Thread Petr Praus
Hi, sorry for the delay, we got stalled a little bit, I'll post the patch today (US central time) after I manage to merge it (oh the cursed newlines). Thanks, Petr On Mon, Feb 13, 2012 at 14:18, Christopher Schultz ch...@christopherschultz.net wrote: Jeremy, On 2/10/12 12:08 PM, Jeremy Brown

Re: WebSocket progress report

2012-02-15 Thread Petr Praus
Hello, attached is our patch. It applies cleanly on top of current trunk rev. 1244719. It has rudimentary support for fragmentation (callback after last frame), supports close messages and ping/pong. Sorry for not sending a patchset but I thought it wouldn't really make sense, since there were

Re: WebSocket progress report

2012-02-13 Thread Christopher Schultz
Mark, On 2/10/12 11:49 AM, Mark Thomas wrote: I prefer the work pid did on the Tomcat 7 index page for the ROOT webapp. +1 -chris signature.asc Description: OpenPGP digital signature

Re: WebSocket progress report

2012-02-13 Thread Christopher Schultz
Jeremy, On 2/10/12 12:08 PM, Jeremy Brown wrote: I suspect it will need more than that. The XLST will almost certainly need some tweaks too. How timely, I'm doing xml transformations in my SOA class right now. If you have any questions about XSLT, I'd be happy to answer them. It's

Re: WebSocket progress report

2012-02-10 Thread Jeremy Brown
Hi Mark, I think I can work on the website. Is it mostly a css refresh you are speaking of? Are there new features that are needed? I like the look of the apache mina site http://mina.apache.org/ with the soft edges, gradients and nice spacing. Is there any php in the webpage source or is it just

Re: WebSocket progress report

2012-02-10 Thread Mark Thomas
On 10/02/2012 16:06, Jeremy Brown wrote: Hi Mark, I think I can work on the website. Is it mostly a css refresh you are speaking of? I suspect it will need more than that. The XLST will almost certainly need some tweaks too. Are there new features that are needed? I don't think so. I

Re: WebSocket progress report

2012-02-10 Thread Jeremy Brown
Hi Mark, I suspect it will need more than that. The XLST will almost certainly need some tweaks too. How timely, I'm doing xml transformations in my SOA class right now. I prefer the work pid did on the Tomcat 7 index page for the ROOT webapp. I haven't used 7 yet, only 5 and 6. But I would

Re: WebSocket progress report

2012-02-10 Thread Slavka Jaromerska
Hi, I haven't communicated with you yet, but I am from the same team as Petr and Jonathan. This is a list of what we have done. We need to clean the code, but we will send a patch tomorrow. So far we started with incoming communation, sending was not done yet. We created two levels of

Re: WebSocket progress report

2012-02-09 Thread Jeremy brown
Hi Jonathan and Petr, I'm an Application Development Graduate Student at Illinois Institute of Technology and I'd like to get started contributing to Tomcat. If you have any tasks I can help out with please let me know. I'd even be happy to start with simple tasks in order begin to familiarize

Re: WebSocket progress report

2012-02-09 Thread Mark Thomas
On 09/02/2012 02:41, Petr Praus wrote: Our initial idea was some form of a streaming API where the reader code receiving the message fills a stream that's somehow connected to a client code that would be consuming it. Hence the Piped[Input|Output]Stream stuff. I also think the individual

Re: WebSocket progress report

2012-02-09 Thread Mark Thomas
On 09/02/2012 15:07, Jeremy brown wrote: Hi Jonathan and Petr, I'm an Application Development Graduate Student at Illinois Institute of Technology and I'd like to get started contributing to Tomcat. If you have any tasks I can help out with please let me know. I'd even be happy to start

Re: WebSocket progress report

2012-02-08 Thread Petr Praus
On Tue, Feb 7, 2012 at 03:47, Mark Thomas ma...@apache.org wrote: On 07/02/2012 02:23, Jonathan Drake wrote: I'm one the three CS grad students working on WebSocket (along with Petr Praus). Just wanted to give an update on our progress, to let you know what we're working on: Adding

Re: WebSocket progress report

2012-02-07 Thread Mark Thomas
On 07/02/2012 02:23, Jonathan Drake wrote: I'm one the three CS grad students working on WebSocket (along with Petr Praus). Just wanted to give an update on our progress, to let you know what we're working on: Adding support for fragmented payloads: Excellent. That and handling control

Re: WebSocket progress report

2012-02-06 Thread Jonathan Drake
I'm one the three CS grad students working on WebSocket (along with Petr Praus). Just wanted to give an update on our progress, to let you know what we're working on: Adding support for fragmented payloads: Right now, after receiving a frame, StreamInbound unmasks the payload in a WsInputStream

Re: WebSocket progress report

2012-02-01 Thread Petr Praus
Hello, we're group of three CS grad students taking a course in advanced networking. As a course project, each of us has implemented a basic websocket server in Java with functionality roughly equal to the current state of Mark's patch. The next stage of the project is to continue in a group and

Re: WebSocket progress report

2012-02-01 Thread Mark Thomas
On 01/02/2012 21:57, Petr Praus wrote: Hello, we're group of three CS grad students taking a course in advanced networking. As a course project, each of us has implemented a basic websocket server in Java with functionality roughly equal to the current state of Mark's patch. The next stage of

Re: WebSocket progress report

2012-01-29 Thread Mark Thomas
On 29/01/2012 01:20, Costin Manolache wrote: On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas ma...@apache.org wrote: Not complaining - it's great to add this feature, please commit it - but I'm wondering if a lighter interface wouldn't be better. From looking at the implementation, it seems

Re: WebSocket progress report

2012-01-29 Thread sebb
On 29 January 2012 10:19, Mark Thomas ma...@apache.org wrote: On 29/01/2012 01:20, Costin Manolache wrote: On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas ma...@apache.org wrote: Not complaining - it's great to add this feature, please commit it - but I'm wondering if a lighter interface

Re: WebSocket progress report

2012-01-29 Thread Costin Manolache
On Sun, Jan 29, 2012 at 2:19 AM, Mark Thomas ma...@apache.org wrote: On 29/01/2012 01:20, Costin Manolache wrote: On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas ma...@apache.org wrote: Not complaining - it's great to add this feature, please commit it - but I'm wondering if a lighter

Re: WebSocket progress report

2012-01-29 Thread Mark Thomas
On 29/01/2012 22:49, Costin Manolache wrote: On Sun, Jan 29, 2012 at 2:19 AM, Mark Thomas ma...@apache.org wrote: On 29/01/2012 01:20, Costin Manolache wrote: On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas ma...@apache.org wrote: Not complaining - it's great to add this feature, please commit

Re: WebSocket progress report

2012-01-28 Thread Costin Manolache
On Fri, Jan 27, 2012 at 3:09 PM, Mark Thomas ma...@apache.org wrote: On 26/01/2012 23:15, Mark Thomas wrote: Good news. The WebSocket implementation has reached a state where you should be able to play with it. Receiving and sending of binary and text data via streams/writers and messages

Re: WebSocket progress report

2012-01-27 Thread Mark Thomas
On 26/01/2012 23:15, Mark Thomas wrote: Good news. The WebSocket implementation has reached a state where you should be able to play with it. Receiving and sending of binary and text data via streams/writers and messages is all working as long as you don't use continuation frames. See the Echo

Re: WebSocket progress report

2012-01-26 Thread Mark Thomas
On 25/01/2012 13:17, jean-frederic clere wrote: On 01/25/2012 02:00 PM, Mark Thomas wrote: On 25/01/2012 08:11, Mladen Turk wrote: On 01/24/2012 10:15 PM, Mark Thomas wrote: I have made some further headway with this and the latest patch is on people.a.o [1]. How that relates to Servlet

Re: WebSocket progress report

2012-01-25 Thread Mladen Turk
On 01/24/2012 10:15 PM, Mark Thomas wrote: I have made some further headway with this and the latest patch is on people.a.o [1]. How that relates to Servlet spec 3.1? Regards -- ^TM - To unsubscribe, e-mail:

Re: WebSocket progress report

2012-01-25 Thread Mark Thomas
On 25/01/2012 08:11, Mladen Turk wrote: On 01/24/2012 10:15 PM, Mark Thomas wrote: I have made some further headway with this and the latest patch is on people.a.o [1]. How that relates to Servlet spec 3.1? TBD :) Current thinking is that servlet 3.1 will provide some hooks to start and

Re: WebSocket progress report

2012-01-25 Thread jean-frederic clere
On 01/25/2012 02:00 PM, Mark Thomas wrote: On 25/01/2012 08:11, Mladen Turk wrote: On 01/24/2012 10:15 PM, Mark Thomas wrote: I have made some further headway with this and the latest patch is on people.a.o [1]. How that relates to Servlet spec 3.1? TBD :) Even if it would not make it

Re: WebSocket progress report

2012-01-25 Thread Rainer Jung
On 24.01.2012 22:15, Mark Thomas wrote: I have made some further headway with this and the latest patch is on people.a.o [1]. Looks nice, especially I like that the integration into the existing code base isn't very complex. Good work! Thanks also for all the additional explanations.