[GitHub] [tomcat] larsgrefer commented on a change in pull request #272: Loop can be terminated after condition is met

larsgrefer commented on a change in pull request #272: Loop can be terminated after condition is met URL: https://github.com/apache/tomcat/pull/272#discussion_r405148102 ## File path: java/org/apache/catalina/realm/RealmBase.java ## @@ -756,10 +756,11 @@ public void backgr

[GitHub] [tomcat] michael-o commented on a change in pull request #272: Loop can be terminated after condition is met

michael-o commented on a change in pull request #272: Loop can be terminated after condition is met URL: https://github.com/apache/tomcat/pull/272#discussion_r405110647 ## File path: java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java ## @@ -824,17 +824,23 @@

[GitHub] [tomcat] michael-o commented on a change in pull request #272: Loop can be terminated after condition is met

michael-o commented on a change in pull request #272: Loop can be terminated after condition is met URL: https://github.com/apache/tomcat/pull/272#discussion_r405110590 ## File path: java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java ## @@ -824,17 +824,23 @@

[GitHub] [tomcat] michael-o commented on a change in pull request #272: Loop can be terminated after condition is met

michael-o commented on a change in pull request #272: Loop can be terminated after condition is met URL: https://github.com/apache/tomcat/pull/272#discussion_r405110511 ## File path: java/org/apache/catalina/realm/RealmBase.java ## @@ -756,10 +756,11 @@ public void backgro

buildbot success in on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5099 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

buildbot success in on tomcat-9-trunk

The Buildbot has detected a restored build on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/158 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchSchedu

Re: API Change - Connector.java Constructor

On Tue, Apr 7, 2020 at 8:42 PM Mark Thomas wrote: > On 07/04/2020 19:03, Filip Hanik wrote: > > > > > > On Tue, Apr 7, 2020 at 9:35 AM Rémy Maucherat > > wrote: > > > > > > Does the connector need to know about the actual implementations? > > > > > > Ideally n

[tomcat] branch 9.0.x updated: Improve Connector creation

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new e540983 Improve Connector creation e540983 is descr

[tomcat] branch master updated: Move getProtocol method to be consistent

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 1eabf4e Move getProtocol method to be consistent

Re: API Change - Connector.java Constructor

On 07/04/2020 19:03, Filip Hanik wrote: > > > On Tue, Apr 7, 2020 at 9:35 AM Rémy Maucherat > wrote: > > > Does the connector need to know about the actual implementations? > > > Ideally no, but it removes the reflection you say is bad for Graal. > > > C

[tomcat] branch master updated: Add boilerplate javadoc

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8f3f98b Add boilerplate javadoc 8f3f98b is descri

[GitHub] [tomcat] fhanik commented on issue #267: Remove reflection from Connector.java

fhanik commented on issue #267: Remove reflection from Connector.java URL: https://github.com/apache/tomcat/pull/267#issuecomment-610548217 AbstractProtocol and AbstractEndpoint use reflection for all property setters. This change is a step in the right direction, but only has minimal impa

Re: API Change - Connector.java Constructor

On Tue, Apr 7, 2020 at 9:35 AM Rémy Maucherat wrote: > >> Does the connector need to know about the actual implementations? >> > > Ideally no, but it removes the reflection you say is bad for Graal. > Correct. Turns out that the connectors use setProperty/getProperty via reflection (Introspectio

[Bug 64311] org.apache.tomcat.jni.TestSocketServerAnyLocalAddress locks entire testbed run under certain conditions

https://bz.apache.org/bugzilla/show_bug.cgi?id=64311 --- Comment #2 from Michael Osipov --- (In reply to Mark Thomas from comment #1) > I'm struggling to recreate this. > > I have APR 1.7.x compiled with --disable-threads > I have Tomcat-Native at 57da160 (just before the fix for BZ 63671) > I h

[Bug 64311] org.apache.tomcat.jni.TestSocketServerAnyLocalAddress locks entire testbed run under certain conditions

https://bz.apache.org/bugzilla/show_bug.cgi?id=64311 --- Comment #1 from Mark Thomas --- I'm struggling to recreate this. I have APR 1.7.x compiled with --disable-threads I have Tomcat-Native at 57da160 (just before the fix for BZ 63671) I have tomcat master (current HEAD) The tests fail becaus

buildbot failure in on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5097 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler sc

[tomcat] branch master updated: Improve Connector creation

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 1554030 Improve Connector creation 1554030 is des

Re: API Change - Connector.java Constructor

On Tue, Apr 7, 2020 at 5:22 PM Filip Hanik wrote: > On Tue, Apr 7, 2020 at 8:15 AM Rémy Maucherat wrote: > >> On Tue, Apr 7, 2020 at 10:16 AM Mark Thomas wrote: >> >>> > Noted, I think a compromise may be in order. Where we simply add a >>> > constructor that avoids the Class.forName >>> > and

[GitHub] [tomcat] larsgrefer opened a new pull request #272: Loop can be terminated after condition is met

larsgrefer opened a new pull request #272: Loop can be terminated after condition is met URL: https://github.com/apache/tomcat/pull/272 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [tomcat] larsgrefer opened a new pull request #271: Use empty arrays for Collections.toArray()

larsgrefer opened a new pull request #271: Use empty arrays for Collections.toArray() URL: https://github.com/apache/tomcat/pull/271 There are two styles to convert a collection to an array: either using a pre-sized array (like `c.toArray(new String[c.size()])`) or using an empty arra

[GitHub] [tomcat] larsgrefer opened a new pull request #270: Bulk operation can be used instead of iteration

larsgrefer opened a new pull request #270: Bulk operation can be used instead of iteration URL: https://github.com/apache/tomcat/pull/270 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [tomcat] larsgrefer opened a new pull request #269: Use parameterized collection constructors where possible

larsgrefer opened a new pull request #269: Use parameterized collection constructors where possible URL: https://github.com/apache/tomcat/pull/269 This allows collections like ArrayList and HashSet to initialize their backing arrays with the correct size. --

Re: API Change - Connector.java Constructor

On Tue, Apr 7, 2020 at 8:15 AM Rémy Maucherat wrote: > On Tue, Apr 7, 2020 at 10:16 AM Mark Thomas wrote: > >> > Noted, I think a compromise may be in order. Where we simply add a >> > constructor that avoids the Class.forName >> > and that allows the developer to explicitly invoke a constructor

Re: API Change - Connector.java Constructor

On Tue, Apr 7, 2020 at 10:16 AM Mark Thomas wrote: > > Noted, I think a compromise may be in order. Where we simply add a > > constructor that avoids the Class.forName > > and that allows the developer to explicitly invoke a constructor that > > avoids it. > > My thinking was more along the follo

[GitHub] [tomcat] biya-bi opened a new pull request #268: Improve Catalina class loader repositories regular expression

biya-bi opened a new pull request #268: Improve Catalina class loader repositories regular expression URL: https://github.com/apache/tomcat/pull/268 The goal of this enhancement is to improve the regular expression used for searching class loader repositories when bootstrapping Catalina.

[tomcat-jakartaee-migration] branch master updated: Avoid deprecation warning

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new 54c1fe1 Avoid deprecation war

Re: [Bug 64309] Improve repository regular expression performance used for bootstrapping Catalina

Yes, I also think the same. I will push the pull request for the enhancement. Paul > On Apr 7, 2020, at 8:48 AM, Mark Thomas wrote: > > On 07/04/2020 13:39, Paul Muriel Biya-Bi wrote: >> Hi Mark, >> >> In our case, the performance difference is indeed very small. On my Ubuntu >> system, I d

Re: [Bug 64309] Improve repository regular expression performance used for bootstrapping Catalina

On 07/04/2020 13:39, Paul Muriel Biya-Bi wrote: > Hi Mark, > > In our case, the performance difference is indeed very small. On my Ubuntu > system, I did a basic performance measurement (using > System.currentTimeMillis()) on my common.loader path. With the > Bootstrap.getPaths() method, I gai

Re: [Bug 64309] Improve repository regular expression performance used for bootstrapping Catalina

Hi Mark, In our case, the performance difference is indeed very small. On my Ubuntu system, I did a basic performance measurement (using System.currentTimeMillis()) on my common.loader path. With the Bootstrap.getPaths() method, I gained only 2 illiseconds on a repository path of 340 characte

Re: Jakarta EE migration tool improvements

Le 07/04/2020 à 13:50, Rémy Maucherat a écrit : > I would want to keep the basic tool available. Of course, this is in addition to the command line tool. > Ideally it is nice to avoid having too many options. I hardly imagine more than 10 options for this kind of tool. Emmanuel Bourg ---

Re: API Change - Connector.java Constructor

On Tue, Apr 7, 2020 at 10:16 AM Mark Thomas wrote: > My thinking was more along the following lines... > > Rewrite the Connector (and possibly some/all other components) so that > If we're talking about embedded, then the other components don't have the problem. For example to create a context y

Re: Jakarta EE migration tool improvements

On Tue, Apr 7, 2020 at 11:54 AM Emmanuel Bourg wrote: > Hi, > > So I've started working on the Jakarta EE migration tool. I've some > enhancements in mind but I'd like to ensure there is a consensus before > proceeding. > > Here are my suggestions: > > - Turn the tool into a plugin for the main b

Re: Jakarta EE migration tool improvements

Le 07/04/2020 à 12:41, Mark Thomas a écrit : >> - Use a CLI parsing library (picocli, jcommander or commons-cli) to ease >> the addition of command line options. It may also bring help/manpage >> generation, tab completion, colored messages. > Are we at the point where we need one? The lack of p

[tomcat-jakartaee-migration] branch master updated: Fix an IDE nag

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new 8c95d25 Fix an IDE nag 8c95d

[tomcat-jakartaee-migration] branch master updated: Really use the charset parameter in the Util.toString(InputStream, Charset) method

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new d3c805d Really use the char

Re: [tomcat-jakartaee-migration] branch master updated (397ff8a -> c4e5c18)

Le 07/04/2020 à 12:24, Mark Thomas a écrit : > +1 to all of the above. Thank you for the review. >> new 3618367 Renamed NoOpConverter to PassThroughConverter > > What problem does this commit address and/or what new feature does it > add? It looks more like a personal preference for a di

Re: Jakarta EE migration tool improvements

On 07/04/2020 10:54, Emmanuel Bourg wrote: > Hi, > > So I've started working on the Jakarta EE migration tool. I've some > enhancements in mind but I'd like to ensure there is a consensus before > proceeding. > > Here are my suggestions: > > - Turn the tool into a plugin for the main build syste

Re: [tomcat-jakartaee-migration] branch master updated (397ff8a -> c4e5c18)

On 07/04/2020 01:56, ebo...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > ebourg pushed a change to branch master > in repository > https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git. > > > from 397ff8a Travis integration >

Re: Jakarta EE migration tool release

On 07/04/2020 10:15, Emmanuel Bourg wrote: > Hi all, > > I'd like to start packaging the Jakarta EE migration tool for Debian > since it's now a prerequisite to build Tomcat 10. For that I'd need a > recent tag, do you think we could tag the current code as 0.0.2? Do we > need a formal vote at thi

Jakarta EE migration tool improvements

Hi, So I've started working on the Jakarta EE migration tool. I've some enhancements in mind but I'd like to ensure there is a consensus before proceeding. Here are my suggestions: - Turn the tool into a plugin for the main build systems (Maven, Gradle, Ant) to easily post process the jar/war fi

[tomcat-jakartaee-migration] branch master updated: Implicit phase binding for the shade plugin

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new c9bec12 Implicit phase bind

Jakarta EE migration tool release

Hi all, I'd like to start packaging the Jakarta EE migration tool for Debian since it's now a prerequisite to build Tomcat 10. For that I'd need a recent tag, do you think we could tag the current code as 0.0.2? Do we need a formal vote at this stage? Emmanuel Bourg -

Re: [tomcat-jakartaee-migration] 01/03: Replaced NonClosing{In, Out}putStream with the equivalent classes from Commons IO

On Tue, Apr 7, 2020 at 11:05 AM Emmanuel Bourg wrote: > Le 07/04/2020 à 09:41, Rémy Maucherat a écrit : > > > Reimplemeting ... It was already done, and this was a better trivial > > solution. This is a veto (unlike Mark I will not withdraw it), so please > > revert this commit. > > Remy, this is

Re: [tomcat-jakartaee-migration] 01/03: Replaced NonClosing{In, Out}putStream with the equivalent classes from Commons IO

Le 07/04/2020 à 09:41, Rémy Maucherat a écrit : > Reimplemeting ... It was already done, and this was a better trivial > solution. This is a veto (unlike Mark I will not withdraw it), so please > revert this commit. Remy, this is honestly more a rant on an insignificant detail than a reasonably j

Re: [tomcat-jakartaee-migration] branch master updated (5c96c0b -> 61ba095)

On 07/04/2020 09:40, Emmanuel Bourg wrote: > Le 07/04/2020 à 10:12, Mark Thomas a écrit : > >> The dependencies are only embedded to create a single JAR to make it >> easier for users to use on the command line. If the code was re-used I'd >> expect the "standard" JAR to be used and leave the deci

Re: [tomcat-jakartaee-migration] branch master updated (5c96c0b -> 61ba095)

Le 07/04/2020 à 10:12, Mark Thomas a écrit : > The dependencies are only embedded to create a single JAR to make it > easier for users to use on the command line. If the code was re-used I'd > expect the "standard" JAR to be used and leave the decision on how to > handle the dependencies up to the

[tomcat-jakartaee-migration] branch master updated: Revert "Relocated the dependencies in the shaded jar"

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new 7106838 Revert "Relocated t

Re: sources repository for taglibs-standard-impl/specs-1.2.5-migrated-0.0.1

On 07/04/2020 00:44, Olivier Lamy wrote: > Hi > This weekend I have started running this on a server > > svn2git https://svn.apache.org/repos/asf/tomcat/taglibs/standard/ > > It may take few days to finish... > > Working with a svndump might be easier. Do you know if INFRA can provide > this? h

Re: API Change - Connector.java Constructor

On 06/04/2020 20:50, Filip Hanik wrote: > On Mon, Apr 6, 2020 at 11:20 AM Mark Thomas > wrote: > > On 06/04/2020 17:56, Filip Hanik wrote: > > Team, > > > > As I'm slowly transitioning between projects, Apache Tomcat has once > > again showed up in my

Re: [tomcat-jakartaee-migration] branch master updated (5c96c0b -> 61ba095)

On 06/04/2020 17:45, Emmanuel Bourg wrote: > Le 06/04/2020 à 18:33, Mark Thomas a écrit : > >> OK. But that is still 7.2k of classes rather than 2.4k of classes for >> zero benefit. >> >> I'll withdraw my -1 because we are approaching the point where the >> differences aren't worth the time spent

[tomcat-jakartaee-migration] branch master updated: Remove broken variable

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new 0a021b3 Remove broken variabl

Re: [tomcat-jakartaee-migration] 01/03: Replaced NonClosing{In, Out}putStream with the equivalent classes from Commons IO

On Mon, Apr 6, 2020 at 3:45 PM Emmanuel Bourg wrote: > Le 06/04/2020 à 15:38, Rémy Maucherat a écrit : > > > commit 29ea1891489060f3b3e40259098def5ae47645ef > > Author: Emmanuel Bourg mailto:ebo...@apache.org > >> > > AuthorDate: Mon Apr 6 15:24:35 2020 +0200 > > > > Replaced