Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/1
+1 for @hsaputra idea of not checking in the binary jar. To not mess with
the classpath, you can simply generate an empty class using ASM and write it to
a jar (shouldn't be too complicate to use
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/1
Actually you don't need to use ASM. You can just create two jars, one
contains `org/apache/twill/internal/utils/Class1.class`, the other has
`org/apache/twill/internal/utils/Class2.class`. Then create
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/31
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/28
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/27
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/26#discussion_r98118427
--- Diff:
twill-yarn/src/test/java/org/apache/twill/filesystem/FileContextLocationTest.java
---
@@ -17,26 +17,36 @@
*/
package
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101789920
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -38,7 +38,6 @@
import
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101699381
--- Diff: twill-api/src/main/java/org/apache/twill/api/Configs.java ---
@@ -75,6 +82,7 @@ private Keys() {
*/
public static final int
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/32
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/25
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/24
Please use 2 spaces instead of 4 for indentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/1#discussion_r75587121
--- Diff:
twill-core/src/test/java/org/apache/twill/internal/utils/ApplicationBundlerTest.java
---
@@ -17,27 +17,32 @@
*/
package
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/35
(TWILL-207) Only use list of class names as the cache name
- Also some indentation changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/34
Feature/twill 186
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill feature/twill-186
Alternatively you can review and apply
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/34#discussion_r103596214
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/yarn/AbstractYarnAMClient.java
---
@@ -50,12 +51,11 @@
private static final Logger LOG
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/34
Seems like the github sync is lagging. I merged this change about 6 hours
ago
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/34
I squashed them after getting LGTM to prepare for the merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/35
Force push a change to trigger travis build again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/8
(TWILL-177) Make ZKDiscoveryService AutoCloseable
- Release ZK watches when closed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/6#discussion_r76685365
--- Diff:
twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAppClient.java
---
@@ -62,18 +62,26 @@
public final class
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/6#discussion_r76685965
--- Diff:
twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAppClient.java
---
@@ -176,22 +184,27 @@ private void addRMToken
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/6#discussion_r76685638
--- Diff:
twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAppClient.java
---
@@ -62,18 +62,26 @@
public final class
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/7
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/8
Rebased on master and resolved conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82098250
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java
---
@@ -236,6 +236,23 @@
TwillPreparer setLogLevel(LogEntry.Level logLevel
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82097429
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,29 @@
* @return A {@link Future} that will be completed
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82097947
--- Diff:
twill-api/src/main/java/org/apache/twill/api/TwillRunResources.java ---
@@ -59,6 +61,16 @@
/**
* @return the enabled log level
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82098461
--- Diff:
twill-common/src/main/java/org/apache/twill/internal/Constants.java ---
@@ -82,6 +82,14 @@ private Files
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82099064
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -72,7 +76,7 @@ public String getZkConnectStr
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82099632
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/utils/LogLevelUtil.java ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82034877
--- Diff:
twill-common/src/main/java/org/apache/twill/internal/Constants.java ---
@@ -78,6 +78,15 @@ private Files
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82034301
--- Diff:
twill-api/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82035336
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/json/TwillRuntimeSpecificationCodec.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82034651
--- Diff:
twill-api/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82066987
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerMain.java
---
@@ -112,9 +115,7 @@ public static void main(final String
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82060475
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/json/TwillRuntimeSpecificationCodec.java
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82060058
--- Diff: twill-core/src/main/java/org/apache/twill/internal/EnvKeys.java
---
@@ -22,36 +22,25 @@
*/
public final class EnvKeys {
- public
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82059585
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/ServiceMain.java ---
@@ -145,9 +145,8 @@ protected static Location createAppLocation(final
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82059853
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82069017
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/json/TwillRuntimeSpecificationCodec.java
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/13#discussion_r82069407
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -169,7 +172,7 @@ public Reader getInput() throws
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/13
LGTM. Please squash the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/7#discussion_r76519593
--- Diff: twill-core/src/main/java/org/apache/twill/internal/Configs.java
---
@@ -31,6 +31,11 @@
*/
public static final String
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/6#discussion_r76378304
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunnableProcessLauncher.java
---
@@ -76,6 +76,11 @@ public String toString
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/4
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/7#discussion_r76454915
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java ---
@@ -157,11 +158,25 @@ public YarnTwillRunnerService(YarnConfiguration
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/6#discussion_r76430188
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunnableProcessLauncher.java
---
@@ -76,6 +76,11 @@ public String toString
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87238505
--- Diff:
twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java
---
@@ -129,7 +153,7 @@ public String toString
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87244253
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -17,12 +17,14 @@
*/
package
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87237581
--- Diff:
twill-api/src/main/java/org/apache/twill/api/TwillRunResources.java ---
@@ -58,7 +60,18 @@
/**
* @return the enabled log level
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87242433
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/ContainerLiveNodeData.java
---
@@ -43,4 +51,15 @@ public String getHost() {
public String
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87239528
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,59 @@
* @return A {@link Future} that will be completed
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87244879
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/ServiceMain.java ---
@@ -264,6 +262,10 @@ protected String getLoggerLevel(Logger logger
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87239353
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java
---
@@ -170,6 +171,37 @@ public String apply(Set input
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83519594
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/DefaultResourceReport.java
---
@@ -39,25 +44,33 @@
private final TwillRunResources
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83519663
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/DefaultResourceReport.java
---
@@ -39,25 +44,33 @@
private final TwillRunResources
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r89038468
--- Diff:
twill-core/src/main/java/org/apache/twill/kafka/client/KafkaOffsetProvider.java
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r89038384
--- Diff:
twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java ---
@@ -35,8 +35,10 @@
* Invoked when new messages is available
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r89038561
--- Diff:
twill-core/src/main/java/org/apache/twill/kafka/client/KafkaOffsetProvider.java
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/15
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87353645
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java
---
@@ -227,15 +227,34 @@
TwillPreparer addSecureStore(SecureStore secureStore
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87863869
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java
---
@@ -227,15 +227,34 @@
TwillPreparer addSecureStore(SecureStore secureStore
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87875415
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerService.java
---
@@ -56,24 +66,27 @@
public
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87864069
--- Diff:
twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java
---
@@ -90,8 +104,14 @@ public Integer getDebugPort
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87353516
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,30 @@
* @return A {@link Future} that will be completed
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82901837
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/utils/LogLevelUtil.java ---
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82899928
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/LogLevelChangeTestRun.java ---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82901178
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -298,6 +299,29 @@ public TwillPreparer addSecureStore(SecureStore
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82898688
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/ResourceReportTestRun.java ---
@@ -36,6 +36,7 @@
import org.junit.Test;
import
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83108745
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/json/TwillRunResourcesCodec.java
---
@@ -41,7 +43,8 @@
private static final String
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83083471
--- Diff:
twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java
---
@@ -30,17 +34,33 @@
private final int memoryMB
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83089162
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/DefaultResourceReport.java
---
@@ -149,6 +161,51 @@ public void setServices(List services
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83112064
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/utils/LogLevelUtil.java ---
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83116829
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -951,4 +958,34 @@ public void run
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83116780
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -200,7 +201,9 @@ private RunningContainers
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83118218
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -132,16 +149,22 @@ void start(String runnableName
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83117233
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -951,4 +958,34 @@ public void run
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83108717
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/json/TwillRunResourcesCodec.java
---
@@ -41,7 +43,8 @@
private static final String
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83083453
--- Diff:
twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java
---
@@ -30,17 +34,33 @@
private final int memoryMB
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83472057
--- Diff:
twill-api/src/main/java/org/apache/twill/api/TwillRunResources.java ---
@@ -59,6 +61,16 @@
/**
* @return the enabled log level
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83471666
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,34 @@
* @return A {@link Future} that will be completed
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83472284
--- Diff:
twill-api/src/main/java/org/apache/twill/internal/DefaultTwillRunResources.java
---
@@ -129,7 +152,7 @@ public String toString
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83471254
--- Diff: twill-api/src/main/java/org/apache/twill/api/ResourceReport.java
---
@@ -61,4 +63,11 @@
* @return list of services of the application master
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83471522
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,34 @@
* @return A {@link Future} that will be completed
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r91844834
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -151,8 +152,9 @@
this.reservedMemory =
yarnConfig.getInt
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r91846095
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -384,6 +408,24 @@ private void setEnv(String runnableName, Map<Str
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r90134835
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillService.java ---
@@ -197,16 +198,16 @@ protected final void shutDown() throws
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r90134323
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,45 @@
* @return A {@link Future} that will be completed
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r91844729
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,48 @@
* @return A {@link Future} that will be completed
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r91844825
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -384,6 +408,24 @@ private void setEnv(String runnableName, Map<Str
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r90134468
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java
---
@@ -89,4 +90,45 @@
* @return A {@link Future} that will be completed
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/17
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/20
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/18
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/14
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94918807
--- Diff:
twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java ---
@@ -33,14 +33,16 @@
/**
* Invoked when new
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94817038
--- Diff:
twill-core/src/test/java/org/apache/twill/kafka/client/KafkaTest.java ---
@@ -189,6 +194,49 @@ public void finished() {
}
@Test
Github user chtyim commented on the issue:
https://github.com/apache/twill/pull/22
For the stop timeout, it is cover by TWILL-192, as the changes are more
complicate in the stop case
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/22#discussion_r95050430
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java
---
@@ -257,8 +258,19 @@
TwillPreparer setLogLevels(String runnableName, Map
GitHub user chtyim opened a pull request:
https://github.com/apache/twill/pull/22
(TWILL-187) Added max start time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/twill feature/twill-187
Alternatively you can review
1 - 100 of 209 matches
Mail list logo
