Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/283#discussion_r241308791
--- Diff:
wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java ---
@@ -167,6 +168,10 @@ protected IPageStore newPersistentStore
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/283#discussion_r239994141
--- Diff:
wicket-core/src/main/java/org/apache/wicket/pageStore/disk/NestedFolders.java
---
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/283#discussion_r239994086
--- Diff:
wicket-core/src/main/java/org/apache/wicket/DefaultPageManagerProvider.java ---
@@ -167,6 +168,10 @@ protected IPageStore newPersistentStore
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/272
This PR has been merged.
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/288
This PR has been merged.
Thanks a lot for the changes!
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/284
This PR has been merged.
Thanks a lot for the changes!
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/285
This PR has been merged and can be closed.
Thanks a lot for the changes!
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/275
Hey @solomax - sadly I am totally busy right now, but I try my best to
change this.
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/283
A lot of changes there and we should carefully test this, but I like the
idea to unify PageStore / DataStore! ð
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/275
Due to the vote that Wicket is going to drop the support of Browser
detection I am closing this branch right now.
@solomax - yes why not a wicketstuff module. ð
/closed
---
Github user klopfdreh closed the pull request at:
https://github.com/apache/wicket/pull/275
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/275
To create UserAgentAnalyzer takes rather a long time. Maybe we are able to
find a way to resolve the bottleneck, but my concerns to implement the browser
detection in such a bad way like
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r184343253
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java
---
@@ -133,24 +140,99 @@ public final String getUserAgent
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/269
Close this one in favour of the mentioned one?
(https://github.com/apache/wicket/pull/275)
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/275
What about merging this? Or do we proceed with this PR after the release
@bitstorm ?
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/275
I send you an invitation to the repo in which the branch of the PR is
located. just push to it and merge if you are done. I think we are on a good
way with this integration.
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/275
Hi @solomax - thanks a lot for the review. Because I am not able to work on
it currently I am going to grant you access to my repo for further commits. Is
this ok for you?
---
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181303063
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -59,9 +58,52 @@ public void before
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181296712
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -59,9 +58,52 @@ public void before
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181295733
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -59,9 +58,52 @@ public void before
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181293718
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -59,9 +58,52 @@ public void before
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181293658
--- Diff:
wicket-core/src/test/java/org/apache/wicket/protocol/http/request/WebClientInfoTest.java
---
@@ -59,9 +58,52 @@ public void before
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/275
Following changes have been made:
* The init() method has been changed into gatherExtendedInfo() which is
only be executed
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181286646
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java
---
@@ -46,14 +46,20
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/275#discussion_r181286230
--- Diff:
wicket-core/src/main/java/org/apache/wicket/protocol/http/request/WebClientInfo.java
---
@@ -193,165 +198,117 @@ protected String getRemoteAddr
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/269
See my suggestion over here: https://github.com/apache/wicket/pull/269
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/269
In my opinion and because of such a big pool of browsers I would say yes.
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/269
I also looked a bit around and stumbled over Apache DeviceMap which has
been moved into the Attic and from the Attic
(http://attic.apache.org/projects/devicemap.html) I followed the link to
https
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/273
Hi,
we are using a CORS enum for media tags already, maybe this is a good
moment to use this class in there, too.
@svenmeier I just told that if there are more places I remember
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/268#discussion_r172125436
--- Diff: wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
---
@@ -226,9 +227,9 @@ private DequeueTagAction canDequeueTag(ComponentTag
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/268#discussion_r172100972
--- Diff: wicket-core/src/main/java/org/apache/wicket/DequeueContext.java
---
@@ -226,9 +227,9 @@ private DequeueTagAction canDequeueTag(ComponentTag
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/267
Hi @try0
The fix is integrated, now:
master -
https://github.com/apache/wicket/commit/6c91b495738c597a9c89f624d6f675cd6eb1f609
wicket-7.x -
https://github.com/apache/wicket
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/255
Hi,
is this PR reflection a subset of changes of:
https://github.com/apache/wicket/pull/256?
If yes we might consider to close this one and continue it in only one PR
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/257
Much better! Now only the relevant things are available and if the user
wants to go for logback he just can add it, but doesn't need to remove not used
xmls if logback isn't used. ð
---
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159287015
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/OnLoadHeaderItem.java
---
@@ -86,8 +86,8 @@ public void render(Response response
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159286873
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
---
@@ -106,8 +107,7 @@ public void renderHead(final
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159286930
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CoreLibrariesContributor.java
---
@@ -63,8 +64,7 @@ public static void contributeAjax
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159220270
--- Diff:
wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java
---
@@ -106,8 +107,7 @@ public void renderHead(final
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159219467
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/OnLoadHeaderItem.java
---
@@ -86,8 +86,8 @@ public void render(Response response
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/253#discussion_r159220379
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/CoreLibrariesContributor.java
---
@@ -63,8 +64,7 @@ public static void contributeAjax
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/242
One little question left - what is this:
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/242
Very nice! ð¸ - its working flawless with index.html! ð
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/242
ð - okay then I am going to test this and report back. Thanks @bitstorm
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/242
Maybe we can use the filter path for the link - WDYT?
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/242
Hi @bitstorm ,
ah ok! So my question then would be if there is a way to get the ârealâ
root path somehow.
thanks a lot for clarification. ð
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/242
If this is working like the external link I would be ok with it. I just
want to achieve the examples working on each context root,
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/242
Hi @bitstorm - sure ð - please look at your last commit - there was the
external link removed which leads to an issue if the context root is not /
---
Github user klopfdreh closed the pull request at:
https://github.com/apache/wicket/pull/242
---
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/242
Hi @bitstorm
I just adjusted the resources management to also be available for other
context roots then for / - when I start the examples using "StartExamples.java"
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/242
https://user-images.githubusercontent.com/980773/32403623-21b641b6-c13f-11e7-9d83-9434157af58b.png;>
---
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/242
WICKET-6490
* Changed resource management
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket WICKET-6490
Alternatively you can
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/230
@martin-g what do you thing of extracting the lines:
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/protocol/http/WicketFilter.java#L583
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/230
Just my thoughts:
/* - maps every path - root paths and sub paths to the specific filter
/ - maps only the root path but not every sub path
So from my understanding they aren't
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/229
The changes of the PR are integrated with commit
075d8371ef3eb2e5f3bdadf008ae904cafd222b3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/227
Thanks again @martin-g ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/226
Thanks a lot @martin-g!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/224
Thanks a lot for your effort. @martin-g I saw you did the review already. I
created a JIRA ticket: https://issues.apache.org/jira/browse/WICKET-6434.
---
If your project is set up for it, you can
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/226
Ticket: https://issues.apache.org/jira/browse/WICKET-6433
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/227#discussion_r131109718
--- Diff:
wicket-experimental/wicket-http2/wicket-http2-core/src/main/java/org/apache/wicket/http2/markup/head/PushHeaderItem.java
---
@@ -361,7 +366,32
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/227
Thanks for reviewing! I apply the changes, now! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/227#discussion_r131109906
--- Diff:
wicket-experimental/wicket-http2/wicket-http2-core/src/main/java/org/apache/wicket/http2/markup/head/PushHeaderItem.java
---
@@ -361,7 +366,32
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/227#discussion_r131109859
--- Diff:
wicket-experimental/wicket-http2/wicket-http2-core/src/main/java/org/apache/wicket/http2/markup/head/PushHeaderItem.java
---
@@ -361,7 +366,32
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/227#discussion_r131109822
--- Diff:
wicket-experimental/wicket-http2/wicket-http2-core/src/main/java/org/apache/wicket/http2/markup/head/PushHeaderItem.java
---
@@ -361,7 +366,32
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/226
Ok I create a JIRA ticket for this! ð
Thanks for reviewing @martin-g
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/226#discussion_r131109389
--- Diff:
wicket-core/src/main/java/org/apache/wicket/markup/head/CssHeaderItem.java ---
@@ -169,6 +171,39 @@ public static CssReferenceHeaderItem
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/227#discussion_r130974278
--- Diff:
wicket-experimental/wicket-http2/wicket-http2-core/src/main/java/org/apache/wicket/http2/markup/head/PushHeaderItem.java
---
@@ -361,7 +366,32
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/226
Maybe we can create a ticket for this PR to have something for the version
changes file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user klopfdreh closed the pull request at:
https://github.com/apache/wicket/pull/225
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/227
Fixes issue of pushing resources
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket push_issue_fix
Alternatively you can
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/226
Allow to set the rel attribute with CssHeaderItem
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/225#discussion_r130393784
--- Diff:
wicket-experimental/wicket-http2/wicket-http2-core/src/main/java/org/apache/wicket/http2/markup/head/PushHeaderItem.java
---
@@ -361,7 +366,32
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/225
All in all there are currently some errors regarding the caching of the
resources which are pushed. It currently behaves like this:
Resource pushed (no status code) > 200 OK (served
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/225#discussion_r130389962
--- Diff:
wicket-experimental/wicket-http2/wicket-http2-core/src/main/java/org/apache/wicket/http2/markup/head/PushHeaderItem.java
---
@@ -361,7 +366,32
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/225
Some regarding CssHeaderItem / push integration
* there are some methods to apply the rel attribute to css header items
* fixed a bug that the resources were not pushed correctly to the client
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/214#discussion_r130276480
--- Diff:
wicket-core/src/main/java/org/apache/wicket/page/PageAccessSynchronizer.java ---
@@ -93,8 +94,8 @@ public Duration getTimeout(int pageId
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/224
Just do a revert commit and apply the changes you originally wanted to do
in a separate one ð
I think your IDE is also supporting this.
---
If your project is set up for it, you can
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/219#discussion_r30176
--- Diff:
wicket-core/src/main/java/org/apache/wicket/resource/FileSystemResource.java ---
@@ -95,7 +95,9 @@ protected ResourceResponse
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/131
I think this PR can be closed, now. Thanks a lot for the great new guide!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
@bitstorm - the changes are made - JSONObject does not throw any checked
exceptions anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Thanks a lot @tdunning !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
@bitstorm - the issue about the checked exceptions is fixed in the master
branch we only have to wait until the release and increase our version in the
pom.xml. Then there should be no further
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
I changed the method propertiesAsMap to throw the JSONException, because
the first statement of a constructor always has to be the super / this call.
---
If your project is set up for it, you can
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/203
It seems that you have selected the wrong branch for the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Hi @bitstorm ,
I saw that JSONObject throws a JSONException which extends RuntimeException
- I thought it is unchecked.
---
If your project is set up for it, you can reply to this email
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/194
Closed due to:
*
https://github.com/apache/wicket/commit/0ba87f062cad8664d216abccb2a47126f637b87c
*
https://github.com/apache/wicket/commit/6f764146a007ab38686a7d54210db0fcdfc2a7ef
Github user klopfdreh closed the pull request at:
https://github.com/apache/wicket/pull/194
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Closed due to:
*
https://github.com/apache/wicket/commit/3dacec4c55bb95618f604ad2ccea279346de279c
*
https://github.com/apache/wicket/commit/6b1d53b17a0aa77a8b131fd161e12e08d335a251
Github user klopfdreh closed the pull request at:
https://github.com/apache/wicket/pull/195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user klopfdreh closed the pull request at:
https://github.com/apache/wicket/pull/193
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/193
Closed due to:
*
https://github.com/apache/wicket/commit/4e3194466c4df50c9d38ea1ed50800dea592c72b
*
https://github.com/apache/wicket/commit/cc98cb0675ffbe9be956e33d6b827f4d61f9f3d7
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/193
Hi @tdunning - thanks for keeping us up to date with the changes! ð
I am going to set the version to 1.6 so that we get the latest version.
---
If your project is set up for it, you
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/193
I vote to merge the 8.x PR. For 6.x / 7.x @martin-g already did build tests
and pointed out some issues and I would suggest to check out the PRs and test
them even with wicketstuff to ensure
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/193
@bitstorm - there are two different PRs for 6.x and 7.x to preserve the API
integrity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Great! ð - so if everything is working - we should integrate all PR for
open-json. But I suggest to test all dependencies (also for wicketstuff)
---
If your project is set up for it, you can
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
@martin-g I rebased it and pushed it again. Should be up to date now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/193
Summary before integration:
* json.org is replaced with open-json, now
* Because Apache Wicket 8 is at milestone level API changes are allowed and
because of this all JSON library
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/194
Summary before integration:
* json.org is replaced with open-json, now
* Method calls not supported by open-json throw a WicketRuntimeException to
inform the user
* If users still
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/195
Summary before integration:
* json.org is replaced with open-json, now
* Method calls not supported by open-json throw a WicketRuntimeException to
inform the user
* If the users
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/194
Hi @martin-g - this was because Objects.hashCode is only available since
idk > 7.
I replaced the call with a return 0; - this is done by
Objects.hashCode(null) anyway.
I a
Github user klopfdreh commented on the issue:
https://github.com/apache/wicket/pull/194
Hi @martin-g - thanks for the hint - I am going to have a look at it, soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
1 - 100 of 339 matches
Mail list logo
