Re: [Dev] [IoT] Changing Geo Location Enabling Configuration

2018-01-22 Thread Geeth Munasinghe
+1 for the Charitha's idea. It is good to give the ability to decide which operation response goes to DAS and which will not. Thanks Geeth On Mon, Jan 22, 2018 at 2:07 PM, Kamidu Punchihewa wrote: > Hi Rasika, > > + 1 for filter out required operations responses that the

Re: [Dev] [IoT] Changing Geo Location Enabling Configuration

2018-01-22 Thread Kamidu Punchihewa
Hi Rasika, + 1 for filter out required operations responses that the user needs to get the related analytics. IMO this will improve the UX even better than just allowing or disallowing all the operation whether the information is needed to the user or not. @Charitha, good suggestion on

Re: [Dev] [IoT] Changing Geo Location Enabling Configuration

2018-01-22 Thread Rasika Perera
Hi All, Please find inline comments. @Ruwan: > > true > true > > IMO, this wording makes a bit more sense. Also, let's make sure to include > explanations as to what these params enable. Looks good to me. However; `Operation Analytics` too make sense to me when we consider it as

Re: [Dev] [IoT] Changing Geo Location Enabling Configuration

2018-01-21 Thread Charitha Goonetilleke
Hi Rasika & all, BTW, with our current implementation we are publishing operation response of DeviceInfo if *PublishOperationResponse* is enabled. So shall we changed it as *PublishDeviceInfoResponse* ? Also since it is useful to publish Operation response payloads to Analytics for further

Re: [Dev] [IoT] Changing Geo Location Enabling Configuration

2018-01-21 Thread Inosh Perera
Hi Rasika, +1, I assume in the default configuration we will keep both these values to false since by default we would not need the publish info to DAS. Also, when you say publish operation response, does it mean we are publishing all operation info such as application list, device info and

Re: [Dev] [IoT] Changing Geo Location Enabling Configuration

2018-01-21 Thread Imesh Chandrasiri
Hi Rasika, In a UX point of view, IMHO it's better to have both options as configurations giving the user more flexibility of using the product. Furthermore it would avoid sending in unnecessary data if only one option is needed. +1 for having separate configurations IMO. On Mon, Jan 22, 2018

Re: [Dev] [IoT] Changing Geo Location Enabling Configuration

2018-01-21 Thread Ruwan Yatawara
Hi Rasika, +1 for the change, but how about : true true IMO, this wording makes a bit more sense. Also, let's make sure to include explanations as to what these params enable. Thanks and Regards, Ruwan Yatawara Technical Lead, WSO2 Inc. email : ruw...@wso2.com mobile : +94 77

[Dev] [IoT] Changing Geo Location Enabling Configuration

2018-01-21 Thread Rasika Perera
Hi All, In IoT Server v3.1.0 geo location services is enabled with the following configuration; true true ​With the new feature developments; In latest IoT Server(master branch); now we also allow publishing device-info responses through the same configuration. true