Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Allow me to remind you of the history of this PR:
1) There was an [initial
commit](https://github.com/apache/zeppelin/pull/3013/commits/cabb83e82a2e77326e214a6e506e53f6fb00ff07
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
As suggested by @jongyoul earlier, a mail was sent out to the dev list on
9th July 2018 with this subject: Should we remove "Download Data as CSV/TSV"
button from ver
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3108
Hi @zjffdu I have added a couple of simple suggestions to the Scala code.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3068
This is a great idea @zjffdu.
There are also a few other things to think of - like automatically
generating the name of the enabler parameter on a per-interpreter basis
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3068
Thanks for the suggestion @zjffdu.
The same idea was given earlier by Leemoonsoo
[here](https://github.com/apache/zeppelin/pull/2502#issuecomment-323272122),
and I had
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3068
The two failed tests on travis - apparently unrelated to the code from this
PR - are really stubborn and wont go away no matter what I do!
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3068
Thanks for pointing out the issue @felixcheung
I've corrected the link as well as some of the preceding words as the
ZeppelinContext documentation is now in its own page
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/3068
[ZEPPELIN-3438] Passing Z variables to BigQuery
### What is this PR for?
This PR enables the interpolation of ZeppelinContext objects into the
paragraph text of BigQuery cells
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3065
This will also make it possible to access paragraph results easily using
the z-variable interpolation feature of various interpreters. So a simple
command like `%sh echo {population-table
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3064
There are similarities between the two features that all users will notice,
and think about for some time. There needs to be good documentation to avoid
any confusion. The substitution
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
Cleaning the cache helped. Thanks for the hint @zjffdu
All green now @jongyoul
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3027
ping @jongyoul
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
Hi @jongyoul one test is still red. I have restarted it 3 times, but it has
failed with the same result each time. Please let me know if there is anything
else to try.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
@jongyoul please ignore my previous comments (now deleted)
The rebase has been done.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
@jongyoul the merge occurred by mistake, and I am not being able to revert
it using the `git revert -m 1 ` command.
I've tried looking up all help on the net, but am not getting
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
I have been a little busy @jongyoul, but have not forgotten it ;-)
Will be done today. Thanks.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
I've fixed the style issues pointed out.
One test still fails on travis--despite a rebase and restart. But the
failure seems unrelated to the changes made in this PR.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
@jongyoul I agree.
Will return to this in a day or two.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
@jongyoul, @Tagar, could you please confirm my understanding of your
suggestions below:
1) The old button should **not** be removed. It should retain its visual
form and function
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3027
Hi Jeff,
The window is popped up only when the user tries to export a notebook that
would be more than 1Mb in size.
The problem with such a notebook (greater than 1Mb
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Thanks for the ideas @Tagar
If we focus on long term advantages and stability, then continuing to
maintain the old button will be a disadvantage. If the old button is retained
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Thanks @prabhjyotsingh.
I will wait for a clear common view before making any further changes.
---
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/3027
[ZEPPELIN-2605] Import notebook has 1MB size limit but bigger notebooks can
be saved without error or warning
### What is this PR for?
Notebooks of any size can be exported and saved
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
ping @felixcheung
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Please see my suggestion (described above) implemented in the image below.
The legacy method's button (with the very familiar download icon) has been
retained with a different tool-tip
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3013
Thanks for the input @prabhjyotsingh.
Allow me to list the advantages of both methods, and to suggest a possible
way forward for your consideration.
1) **The legacy
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/3013
[ZEPPELIN-3511] remove old button "Download Data as CSV/TSV"
### What is this PR for?
This PR removes the legacy method (button and dropdown near the top left of
each
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
@Tagar thanks for your comments.
The thought here was to make the best of a bad situation. If and when the
`delete()` fails, no recovery action is possible at the user level. So
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/3000
Agreed @zjffdu.
I also made two other (similar) changes. If the `tempFile.delete()` fails,
then `tempFile.deleteOnExit()` is invoked to request the system to handle it if
possible
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/3000
[ZEPPELIN-3467] two-step, atomic configuration file
### What is this PR for?
This PR continues the discussion and implementation in
[PR-2978](https://github.com/apache/zeppelin/pull
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2998
I had to recycle my fork, and had forgotten to link up Travis again.
It's been done now. The errors appear unrelated to the changes in this PR.
Thanks.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2992
Done, please check: https://issues.apache.org/jira/browse/ZEPPELIN-3522 and
https://github.com/apache/zeppelin/pull/2998
---
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/2998
[ZEPPELIN-3522] String "defaultValue" instead of boolean in some
"interpreter-settings.json" files
### What is this PR for?
The _interpreter-settings.json_ file
Github user sanjaydasgupta closed the pull request at:
https://github.com/apache/zeppelin/pull/2967
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2967
Need to make corrections in my repo, so am closing this PR now. Will be
back with a new PR later.
---
Github user sanjaydasgupta closed the pull request at:
https://github.com/apache/zeppelin/pull/2978
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2978
There is a problem in my repo that needs correction.
I am closing this PR now, and will reopen it later if possible, or return
with a new PR.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2978
Hi @felixcheung, @Tagar
Any suggestions on how to push this forward from here?
Thanks
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2992
@zjffdu, there are a few other interpreters that have
`interpreter-setting.json` files with such boolean values in strings. Is it
useful to open a JIRA for those others interpreter-setting
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2978
Hi @zjffdu, can you please confirm if anything more remains to be done in
[FileSystemStorage.writeFile](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2978
Hi @zjffdu
While reading the code of `FileSystemConfigStorage.java`, I noticed that
the method `save(...)` delegates its work to
`FileSystemStorage.writeFile(...)`. Interestingly
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2978
@felixcheung have made the suggested changes. But am not sure how to add
tests for this. Any hints will be useful.
@zjffdu, @Tagar do you recommend similar treatment
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2978
Added code to delete the temp file if the write fails. Re-throwing the
exception serves two purposes:
1) Ensure that the caller sees the same exception when the write fails
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2978
Done. Also used more formal way of creating the temporary file.
I've tested the integrated code on Ubuntu 16.04 - success case only :-) but
am not sure how things will work
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/2978
[ZEPPELIN-3467] two-step, atomic configuration file writes
### What is this PR for?
This PR prevents the total loss of configuration information that happens
when zeppelin attempts
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/2967
[ZEPPELIN-3438] Passing Z variables to BigQuery interpreter
### What is this PR for?
This PR enables the interpolation of ZeppelinContext objects into the
paragraph text
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2960
Hi @felixcheung could you release this into the next RC for 0.8.0?
Thanks.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2960
Yes @felixcheung the other links are ok.
---
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/2960
[Zeppelin 3388] Correcting documentation link to zeppelin-context
documentation
### What is this PR for?
A small change was needed in the documentation of the JDBC interpreter
also
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2953
This is how it looks when squeezed into a really narrow space:
to your earlier question about the unrelated documentation change
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/2903
[ZEPPELIN-3377] Passing Z variables to JDBC interpreter
### What is this PR for?
This PR enables the interpolation of ZeppelinContext objects into the
paragraph text of JDBC cells
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2834
@felixcheung following [the earlier
discussion](https://github.com/apache/zeppelin/pull/2834#discussion_r176976263),
the _propertyName_ field in both _interpreter-setting.json_ files have
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2834
@zjffdu Thanks for your review - that was very helpful.
Have fixed all the issues - please see [details added after your
comment](https://github.com/apache/zeppelin/pull/2834/files
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2834
Hello reviewers, this PR has accumulated many ideas from the wisdom of its
past and present reviewers (@zjffdu @felixcheung @Tagar @Leemoonsoo ), and it
would be interesting to see how
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2834
Thanks for your review @felixcheung
The 3 points have been addressed as described individually above.
---
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2834
I have added code, documentation, and configuration-template files for a
single environment-variable named `ZEPPELIN_INTERPRETER_INTERPOLATION` (and a
corresponding java-property
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2834
Here is one approach: define two new [zeppelin configurable
properties](http://zeppelin.apache.org/docs/latest/install/configuration.html)
as follows:
1) A boolean property named
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2834
Hi @felixcheung @Tagar @zjffdu @Leemoonsoo
I have taken care of all the ideas and concerns expressed earlier (in the
closed [PR-2502](https://github.com/apache/zeppelin/pull/2502
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/2834
[ZEPPELIN-1967] Passing Z variables to Shell and SQL Interpreters
### What is this PR for?
The code in this PR enables embedding/interpolating Z variables into
command strings
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2825
Created from wrong branch in source repo. Need to correct branch and
reissue.
---
Github user sanjaydasgupta closed the pull request at:
https://github.com/apache/zeppelin/pull/2825
---
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/2825
[ZEPPELIN-1967]: New pull request
### What is this PR for?
The code in this PR enables embedding/interpolating Z variables into
command strings passed to Spark's SQL and Shell
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
@felixcheung - We've exchanged many ideas back and forth on this PR to the
point where it has become more of a discussion document than a software
submission :-)
I'm in favor
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
Would like to hear about any further improvements required on this feature
@felixcheung, @Leemoonsoo
Thanks for your thoughts @Tagar
---
If your project is set up for it, you
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
Thanks for the suggestions @felixcheung
I was not able to find more documentation on Jupyter's feature, but tried
it with many different variants. There are some behaviors
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
Thanks for the catch # @Leemoonsoo
I have fixed and committed the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sanjaydasgupta closed the pull request at:
https://github.com/apache/zeppelin/pull/2502
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user sanjaydasgupta reopened a pull request:
https://github.com/apache/zeppelin/pull/2502
[ZEPPELIN-2807] Passing Z variables to SQL Interpreter (One part of
ZEPPELIN-1967)
### What is this PR for?
This feature allows embedding/interpolating Z variables into SQL
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
Please let me know if there are any further comments or concerns
@felixcheung. I have addressed the suggestion on structure of the code in the
documentation
([here](https://github.com
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
@felixcheung I have added a couple of paragraphs of documentation including
an example showing interaction between the Scala and SQL interpreters to
_spark.md_ (at the end of the text
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
I can have a go at creating/updating the documentation if someone can help
me with any guideance on where/how to begin.
My familiarity with Jupyter is very limited, so while I
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
Digging a little deeper to clarify the conflict ... The class
`BaseZeppelinContext` uses two different key-value repositories for two
different needs:
1. **Storage of user
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
Hello @felixcheung @Tagar @zjffdu, this is for any further comments and
suggestions. Here are the features implemented:
1. - The substitution pattern is `{ ... }` as suggested
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
Agreed, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
Thank you for the insight. Do you think we may retain variable substitution
within literal strings as in the following contrived example?
`%sql select * from spares where part_no
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
I would like your views @felixcheung @zjffdu @Tagar on the following
approach to escaping and regex errors etc:
I wish to suggest that no escaping is needed, as the substitution
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
The choice of {...} for identifying parameter/variable names comes from the
parent issue
[ZEPPELIN-1967](https://issues.apache.org/jira/browse/ZEPPELIN-1967). Though
#{...} seems more
Github user sanjaydasgupta commented on the issue:
https://github.com/apache/zeppelin/pull/2502
Thank you for the observations @felixcheung.
Will review these points and make suitable changes.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user sanjaydasgupta opened a pull request:
https://github.com/apache/zeppelin/pull/2502
[ZEPPELIN-2807] Passing Z variables to SQL Interpreter (One part of
ZEPPELIN-1967)
### What is this PR for?
This feature allows embedding/interpolating Z variables into SQL
92 matches
Mail list logo
