Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/722#discussion_r237470021
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderBean.java
---
@@ -51,6 +51,15 @@ public String followerInfo
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/719
@anmolnar yes, it is okay
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/726#discussion_r236977045
--- Diff:
zookeeper-jute/src/test/java/org/apache/jute/XmlInputArchiveTest.java ---
@@ -0,0 +1,120 @@
+/**
+ * Licensed to the Apache Software
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/726#discussion_r236804588
--- Diff:
zookeeper-jute/src/test/java/org/apache/jute/BinaryInputArchiveTest.java ---
@@ -41,4 +42,136 @@ public void testReadStringCheckLength
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/294
@anmolnar green lights from CI
This is a trivial patch, do you need another committer ?
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/722#discussion_r236150403
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderBean.java
---
@@ -51,6 +51,15 @@ public String followerInfo
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/720
@TyqITstudent
For the 'recursive' flag I mean:
- true: recurse thw tree
- false: count only first level
About the build...does the build pass locally on your machine
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/720
At every push CI will retest your work.
Alternatively you can close and reopen the PR
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235712847
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -121,6 +126,18 @@
*/
private
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/707#discussion_r235713462
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -108,7 +109,11 @@
LocalPeerBean
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/710#discussion_r235529044
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -60,6 +60,12 @@
public abstract class X509Util
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/712#discussion_r235386450
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/ZookeeperServerStabilizerConfig.java
---
@@ -0,0 +1,30
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/712
Can we add in the descriptoin the original problem fro findbugs ?
It is not clear what we are going to fix.
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/711#discussion_r235383411
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
---
@@ -864,6 +860,17 @@ public static int getSnapCount
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/710#discussion_r235223996
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -60,6 +60,12 @@
public abstract class X509Util
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/294#discussion_r234984710
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java ---
@@ -69,9 +69,13 @@ public static void registerLog4jMBeans
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/294
We should also add the property to the docs
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/700#discussion_r234624742
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
---
@@ -209,6 +209,8 @@ public void run
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/294
I would go for a system property
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/294#discussion_r234430242
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java ---
@@ -71,7 +71,7 @@ public static void registerLog4jMBeans
Github user eolivelli commented on the pull request:
https://github.com/apache/zookeeper/commit/82da83a7176bbdd73dedb6fc3d96dac706cefad3#commitcomment-31339939
In zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java:
In zookeeper-server/src/main/java/org/apache
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/702#discussion_r234101680
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java
---
@@ -38,10 +38,10 @@
public static final
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/700#discussion_r233723763
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
---
@@ -209,6 +209,8 @@ public void run
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/700#discussion_r233723629
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
---
@@ -181,7 +181,7 @@ protected void fastCloseSock
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/692
Do you have a preview in some staging site?
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/692#discussion_r233605749
--- Diff: src/main/resources/markdown/bylaws.md ---
@@ -1,7 +1,19 @@
-layout: page
-title: Project Bylaws
+
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/700#discussion_r232832500
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
---
@@ -181,7 +181,7 @@ protected void fastCloseSock
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/700#discussion_r232832059
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
---
@@ -209,6 +209,8 @@ public void run
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/690#discussion_r232363306
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapStream.java
---
@@ -0,0 +1,336 @@
+/**
+ * Licensed
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/690#discussion_r232363107
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapStream.java
---
@@ -0,0 +1,336 @@
+/**
+ * Licensed
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/692
Awesome work
May we rename 'hbase' files to 'zookeeper' ?
Is bootstrap compatible from a licensing perspective? Should we add some
'NOTICE' ?
---
Github user eolivelli closed the pull request at:
https://github.com/apache/zookeeper/pull/691
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/691
retest this please
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/691
retest this please
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/691
retest this please
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/691
retest this please
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/691
retest this please
---
GitHub user eolivelli opened a pull request:
https://github.com/apache/zookeeper/pull/691
This is only a test for Jenkins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/zookeeper test
Alternatively you can review
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/690
@yisong-yue sorry for the spam. There is a problem with the pre-commit job.
I won't disturb you anymore on this PR
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/690
retest this please
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/690
retest this please
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/690
retest this please
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/678
Maybe you should use docker.
As soon as possible I will copy the command line we are using in Jenkins
job.
Maybe it is already available on the job log
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/676
@lvfangmin
I guess the problem is not a 'test' in Curator but that class. Curator is
used very much in tests of downstream projects in order to start Zookeeper
servers as it provides easy
Github user eolivelli commented on the pull request:
https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151817
In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java:
In zookeeper-server/src/main/java/org/apache
Github user eolivelli commented on the pull request:
https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151441
In
zookeeper-server/src/test/java/org/apache/zookeeper/common/FileChangeWatcherTest.java:
In
zookeeper-server/src/test
Github user eolivelli commented on the pull request:
https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151424
In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java:
In zookeeper-server/src/main/java/org/apache
Github user eolivelli commented on the pull request:
https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151383
In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java:
In zookeeper-server/src/main/java/org/apache
Github user eolivelli commented on the pull request:
https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31139429
In
zookeeper-server/src/test/java/org/apache/zookeeper/common/FileChangeWatcherTest.java:
In
zookeeper-server/src/test
Github user eolivelli commented on the pull request:
https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31139412
In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java:
In zookeeper-server/src/main/java/org/apache
Github user eolivelli commented on the pull request:
https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31139343
In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java:
In zookeeper-server/src/main/java/org/apache
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/678
'Non binding' means that I am not a 'committer' so I can't merge the patch
by myself.
Btw the other guys which are reviewing this patch are committers so I think
this patch will be merged
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/678
For Apache httpcomponents there is nothing to write, the NOTICE already
covers it, as it is an Apache Project
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r229202470
--- Diff: NOTICE.txt ---
@@ -3,3 +3,9 @@ Copyright 2009-2014 The Apache Software Foundation
This product includes software developed
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r229021572
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java ---
@@ -0,0 +1,224 @@
+/*
+ * Licensed under the Apache
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r228738342
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java ---
@@ -221,15 +279,45 @@ public SSLContext createSSLContext
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/678
@ivmaykov
The code can stay where you put it.
About the NOTICE file I will try to help past the weekend
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/678#discussion_r228406071
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java ---
@@ -0,0 +1,224 @@
+/*
+ * Licensed under the Apache
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/678
retest this please
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/676
@lvfangmin IMHO initQuorumPeer is a better name than getQuorumPeer because
getQuorumPeer seems a 'getter' but is it not.
It is cleaner to have a initQuorumPeer or makeQuorumPeer.
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/676
retest this please
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/673#discussion_r227557275
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
---
@@ -1107,6 +1102,19 @@ public void processPacket
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/669
@maoling there is no generic benchmarks.
For instance in Bookkeeper we switched to Netty 4 and now we are able to
leverage all the cool stuff about memory and so we are able to be more
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226849723
--- Diff: ivy.xml ---
@@ -59,9 +59,11 @@
-
-
-
+
--- End diff --
I forgot about
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/669
@ivmaykov I answered to all of your comments.
I expect this to be the very first step.
Coming with Netty 4 it is more easier to reduce memory allocations,
expecially on the hot
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226839154
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -267,7 +298,7 @@ private void sendPkt(Packet p
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226839114
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226838972
--- Diff:
zookeeper-common/src/test/java/org/apache/zookeeper/common/TestByteBufAllocator.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226836043
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -439,13 +466,34 @@ public void messageReceived
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226835980
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -267,7 +298,7 @@ private void sendPkt(Packet p
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226835913
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +108,95 @@
boolean isConnected
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226835891
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -68,18 +70,21 @@
public class
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226687650
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java
---
@@ -200,24 +186,13 @@ public void setSessionId(long
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226684843
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -439,13 +466,34 @@ public void messageReceived
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226685450
--- Diff:
zookeeper-common/src/test/java/org/apache/zookeeper/common/TestByteBufAllocator.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226690017
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226684209
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -267,7 +298,7 @@ private void sendPkt(Packet p
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226683922
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -184,7 +213,9 @@ void cleanup
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226681741
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -68,18 +70,21 @@
public class
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226690548
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -335,29 +260,34 @@ public void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226682998
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +108,95 @@
boolean isConnected
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226689302
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/673#discussion_r226542744
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
---
@@ -1107,6 +1102,19 @@ public void processPacket
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/652
retest this please
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/670#discussion_r225419531
--- Diff:
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ZKClientConfig.java
---
@@ -23,7 +23,7 @@
import
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/670#discussion_r225402543
--- Diff: zookeeper-client/zookeeper-client-java/pom.xml ---
@@ -0,0 +1,59 @@
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://w
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/670#discussion_r225402885
--- Diff: zookeeper-server/pom.xml ---
@@ -0,0 +1,67 @@
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/670#discussion_r225402462
--- Diff: zookeeper-common/pom.xml ---
@@ -0,0 +1,123 @@
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/670#discussion_r225402727
--- Diff: zookeeper-jute/pom.xml ---
@@ -0,0 +1,169 @@
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/667
@maoling Actually wakeupCnxn cannot really throw exceptions (I did not
check the code when I reviewed the diff), so I think the adding a test is very
difficult and so a big deal.
---
Github user eolivelli commented on the issue:
https://github.com/apache/zookeeper/pull/667
Good.
What about adding a test case to demonstrate the problem and prevent
regressions in the future?
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/663#discussion_r223854802
--- Diff: pom.xml ---
@@ -30,7 +30,7 @@
org.apache.zookeeper
zookeeper
pom
- 2.6.0-SNAPSHOT
+ 3.5.5-beta-SNAPSHOT
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r223347154
--- Diff:
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
---
@@ -68,14 +71,16 @@ public
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r223346987
--- Diff:
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
---
@@ -68,14 +71,16 @@ public
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/587#discussion_r223215411
--- Diff:
zookeeper-client/zookeeper-client-java/src/main/java/org/apache/zookeeper/client/ConnectStringParser.java
---
@@ -68,14 +71,16 @@ public
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r223181405
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -1521,4 +1562,179 @@ public boolean removeWatch(String path
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r223181364
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -1521,4 +1562,179 @@ public boolean removeWatch(String path
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/632#discussion_r223181383
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java ---
@@ -1521,4 +1562,179 @@ public boolean removeWatch(String path
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/654#discussion_r222023353
--- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
@@ -85,60 +85,73 @@ public static SSLContext createSSLContext() throws
Github user eolivelli commented on the pull request:
https://github.com/apache/zookeeper/commit/c57b62d57b8b22d568b1cea3b8039566936e0558#commitcomment-30735811
In src/java/main/org/apache/zookeeper/SaslServerPrincipal.java:
In src/java/main/org/apache/zookeeper
1 - 100 of 281 matches
Mail list logo
