[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440181#comment-13440181
]
Ivan Kelly commented on BOOKKEEPER-272:
---
{quote}
If I understand correctly, on
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440199#comment-13440199
]
Ivan Kelly commented on BOOKKEEPER-272:
---
{quote}
L0001 contains only BK1. while
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440202#comment-13440202
]
Rakesh R commented on BOOKKEEPER-272:
-
Oh! yeah, there was a small mistake in my
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440205#comment-13440205
]
Ivan Kelly commented on BOOKKEEPER-272:
---
Yes, the code I posted does exactly
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440211#comment-13440211
]
Rakesh R commented on BOOKKEEPER-272:
-
Thanks Ivan. I'll do the changes by just
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440310#comment-13440310
]
Rakesh R commented on BOOKKEEPER-272:
-
Attached latest patch addressing Ivan's
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439427#comment-13439427
]
Rakesh R commented on BOOKKEEPER-272:
-
Hi Ivan, Hope I'm not confusing you:-)
As
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13438689#comment-13438689
]
Ivan Kelly commented on BOOKKEEPER-272:
---
I've had another look over this patch.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13438711#comment-13438711
]
Uma Maheswara Rao G commented on BOOKKEEPER-272:
{quote}
There should
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13438718#comment-13438718
]
Ivan Kelly commented on BOOKKEEPER-272:
---
I was thinking along the same lines.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13438856#comment-13438856
]
Rakesh R commented on BOOKKEEPER-272:
-
Thanks again Ivan for detailed review.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13438865#comment-13438865
]
Rakesh R commented on BOOKKEEPER-272:
-
I also agree with you guys. Since Auditor
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400518#comment-13400518
]
Rakesh R commented on BOOKKEEPER-272:
-
@Ivan
I've refactored as per the comments,
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400522#comment-13400522
]
Flavio Junqueira commented on BOOKKEEPER-272:
-
{quote}
{quote}
For the
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13400531#comment-13400531
]
Rakesh R commented on BOOKKEEPER-272:
-
bq.I think that whether the auditor runs or
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294542#comment-13294542
]
Ivan Kelly commented on BOOKKEEPER-272:
---
{quote}
bq. I don't think we need the
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294398#comment-13294398
]
Rakesh R commented on BOOKKEEPER-272:
-
Hi,
As part of this Auditor logic, I'm
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294493#comment-13294493
]
Ivan Kelly commented on BOOKKEEPER-272:
---
I don't think we need the bookie. As we
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294534#comment-13294534
]
Rakesh R commented on BOOKKEEPER-272:
-
{quote}
I don't think we need the bookie
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294548#comment-13294548
]
Rakesh R commented on BOOKKEEPER-272:
-
Oh, seems that I did't explain clearly at
[
https://issues.apache.org/jira/browse/BOOKKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13291802#comment-13291802
]
Ivan Kelly commented on BOOKKEEPER-272:
---
New patch is a lot clearer. Comments
21 matches
Mail list logo
