Re: Apache build failing with test-core-cppunit

2017-11-23 Thread Andor Molnar
> >> > > >> > > >> > Notice that it's not jenkins. > >> > > >> > > >> > Can you (Abe?) submit a jira/patch (ASAP as it's breaking the build) > >> > to create a new di

Re: Proposal for reworked ZK web site generation: CMS -> jekyll

2017-12-01 Thread Andor Molnar
Although I'm not a committer I really appreciate this work. Andor On Fri, Dec 1, 2017 at 1:51 AM, Michael Han wrote: > +1, the new publish process sounds much better. Thanks Pat. > > On Thu, Nov 30, 2017 at 5:00 AM, Camille Fournier > wrote: > > > +1 good

Squash/fixup commits

2017-11-30 Thread Andor Molnar
Hi, @afine raised this on my latest PR: "going forward it would be great if you didn't squash your commits when updating your pr in response to comments (I'm guilty of doing this too), i think the pr merge script handles that plus it is more difficult to see exactly what you changed in response

Re: how zookeeper promise FIFO client order

2017-11-13 Thread Andor Molnar
t requests. I would take a look at the > > section "Order in the Presence of Connection Loss" in the "ZooKeeper: > > Distributed Process Coordination" book for the best answer to this > > question. > > > > Thanks, > > Abe > > &

Re: Apache build failing with test-core-cppunit

2017-11-21 Thread Andor Molnar
Looks like only https://builds.apache.org/job/ZooKeeper-trunk is affected. On Tue, Nov 21, 2017 at 3:22 PM, Andor Molnar <an...@cloudera.com> wrote: > Hi, > > Zookeeper build has been failing for a while with some weird error in > test-core-cppunit task. In most cases the erro

Apache build failing with test-core-cppunit

2017-11-21 Thread Andor Molnar
Hi, Zookeeper build has been failing for a while with some weird error in test-core-cppunit task. In most cases the error is the following: ... [exec] Zookeeper_simpleSystem::testGetChildren2 : elapsed 1052 : OK [exec] Zookeeper_simpleSystem::testLastZxid : elapsed 4520 : OK

Re: Apache build failing with test-core-cppunit

2017-11-21 Thread Andor Molnar
'/tmp/zkdata/myid': Permission denied > > check whether it's happening on just one host (jenkins). > > Patrick > > On Tue, Nov 21, 2017 at 6:25 AM, Andor Molnar <an...@cloudera.com> wrote: > > > Looks like only https://builds.apache.org/job/ZooKeeper-trunk is >

Re: [VOTE] Apache ZooKeeper release 3.4.11 candidate 1

2017-11-03 Thread Andor Molnar
Hi Pat, I've done verification with JDK 1.7.0_141 on my mac desktop: - signatures verified. - started a few different cluster sizes(1,3,5). - ran command line zk client - create, delete, get data, set data znode. - ran few 4lw commands. - ran unit test, looks good. Not sure if it's a problem,

Re: [VOTE] Apache ZooKeeper release 3.4.11 candidate 1

2017-11-03 Thread Andor Molnar
Sent too early. - also verified JMX beans On Fri, Nov 3, 2017 at 5:50 PM, Andor Molnar <an...@cloudera.com> wrote: > Hi Pat, > > I've done verification with JDK 1.7.0_141 on my mac desktop: > > - signatures verified. > - started a few different cluster sizes(1,3,5).

Re: [VOTE] Migrate ZK to Maven build

2018-05-06 Thread Andor Molnar
gt; > > +1 > > > > On Mon, Apr 23, 2018 at 4:06 AM, Jordan Zimmerman < > > jor...@jordanzimmerman.com> wrote: > > > > > +1 (non binding) > > > > > > > On Apr 23, 2018, at 6:21 PM, Mohammad arshad < > > mohammad.ars...@huawe

Re: Name resolution in StaticHostProvider

2018-05-08 Thread Andor Molnar
I'm happy to do that once we have an agreement. On Tue, May 8, 2018 at 8:34 AM, Flavio Junqueira <f...@apache.org> wrote: > It might be a good idea to document whatever we end up doing. > > -Flavio > > > On 8 May 2018, at 17:22, Andor Molnar <an...@cloudera.com>

Re: Name resolution in StaticHostProvider

2018-05-08 Thread Andor Molnar
or issue pending other than one polishing issue that > I brought upon in the PR. > > -Flavio > > > On 8 May 2018, at 21:08, Andor Molnar <an...@cloudera.com> wrote: > > > > I'm happy to do that once we have an agreement. > > > > > > > > >

Re: Name resolution in StaticHostProvider

2018-05-08 Thread Andor Molnar
's converge on what semantics we are trying to provide first, > please. > > -Flavio > > > On 8 May 2018, at 21:20, Andor Molnar <an...@cloudera.com> wrote: > > > > Sorry, I thought you were against the whole refactoring. > > > > "2- That we discu

Re: Txn logs and snapshots in git repo

2018-05-09 Thread Andor Molnar
Hi Ed, Static data used by unit tests. Andor On Wed, May 9, 2018 at 9:46 AM, Edward Ribeiro wrote: > I am updating my local repo and noticed some transaction logs and snapshots > files in src/java/test/data/invalidsnap/version-2. Are those files static > data used

Re: [SUGGESTION] JvmPauseMonitor in ZooKeeper

2018-05-09 Thread Andor Molnar
+1 cool! On Wed, May 9, 2018 at 7:59 AM, Norbert Kalmar wrote: > Okay, thanks Ed, I created the Jira, will look into it soon :) > https://issues.apache.org/jira/browse/ZOOKEEPER-3037 > > Regards, > Norbert > > On Wed, May 9, 2018 at 4:44 PM Edward Ribeiro

Re: Apache ZooKeeper meetup May 9th in Palo Alto?

2018-05-10 Thread Andor Molnar
Thanks everybody for joining. It was great to see you folks in person and talk. Regards, Andor On Wed, May 9, 2018 at 9:44 PM, Patrick Hunt wrote: > On Wed, May 9, 2018 at 9:24 PM, Jeff Widman wrote: > > > Many thanks to Patrick, Andor and the rest of

Re: Name resolution in StaticHostProvider

2018-05-10 Thread Andor Molnar
topping the client. Throwing > might actually be an improvement as it will output a log message, but I'm > now wondering if we should propagate it all the way to the application. > Responding to myself, one reason for not doing it is that it is not a fatal > error unless no server can

Re: Discover LEADER from JMX

2018-05-10 Thread Andor Molnar
"in order to guess which is the leader I have to ask to all of the three nodes in the cluster" That's correct. Regards, Andor On Thu, May 10, 2018 at 4:07 AM, Enrico Olivelli wrote: > Il giorno mer 9 mag 2018 alle ore 20:24 Patrick Hunt ha > scritto:

Re: Name resolution in StaticHostProvider

2018-05-12 Thread Andor Molnar
Hi team, Anyone else has thoughts about whether we should use checked or unchecked exception here? Thanks, Andor On Thu, May 10, 2018 at 8:19 AM, Andor Molnar <an...@cloudera.com> wrote: > Interesting idea. What difference you think it could make comparing to > checked? > &g

Re: Name resolution in StaticHostProvider

2018-05-08 Thread Andor Molnar
Molnar <an...@cloudera.com> wrote: > Hi Abe, > > Unfortunately we haven't got any feedback yet. What do you think of > implementing Option #3? > > Regards, > Andor > > > On Thu, Feb 22, 2018 at 6:06 PM, Andor Molnar <an...@cloudera.com> wrote: > >> Di

Re: Name resolution in StaticHostProvider

2018-05-08 Thread Andor Molnar
lready, which means by calling getByName() you don't necessarily fire a DNS request, only when the TTL is expired. Andor On Tue, May 8, 2018 at 8:12 AM, Flavio Junqueira <f...@apache.org> wrote: > Hi Andor, > > Thanks for your work on addressing the issue. > > >

Re: Name resolution in StaticHostProvider

2018-05-17 Thread Andor Molnar
ooks one element from the list, > but there's an error with that address. then I think it is reasonable to > expect the caller to recover. > > But I'm also open to pros and cons :) > > Regards, > Norbert > > > > On Sat, May 12, 2018 at 4:09 PM Andor Molnar <a

Re: [VOTE] Apache ZooKeeper release 3.5.4-beta candidate 0

2018-05-15 Thread Andor Molnar
Hi Pat, Sorry for being late with my tests, please find my +1 here: - verified xsum/sig, - verified cluster with 11 nodes, - verified with few 4lw commands. - all unit test passed locally, - running rolling restart test for a while without errors. Thanks, Andor On Tue, May 15, 2018 at 8:51

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-08 Thread Andor Molnar
This PR is also related: https://github.com/apache/zookeeper/pull/362 Andor On Fri, Jun 8, 2018 at 3:18 PM, Andor Molnar wrote: > Hi devs, > > I'm having problems resolving the issue mentioned in this Jira and need > some feedback from you: > > https://issues.apac

ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-08 Thread Andor Molnar
Hi devs, I'm having problems resolving the issue mentioned in this Jira and need some feedback from you: https://issues.apache.org/jira/browse/ZOOKEEPER-3034 In a nutshell the situation with *cppunit* is as follows: LibreOffice team confirmed that from version *1.14.0* they will no longer ship

Re: [ANNOUNCE] New ZooKeeper committer: Andor Molnar

2018-06-11 Thread Andor Molnar
Thanks everyone!! On Fri, Jun 8, 2018 at 11:44 PM, Michael Han wrote: > Congrats Andor, welcome aboard, and keep up the good work! > > On Fri, Jun 8, 2018 at 1:38 PM, Tamas Penzes wrote: > > > Congrats Andor, well deserved! > > > > On Fri, Jun 8, 2018 at 3:48 PM Patrick Hunt wrote: > > > > >

Re: Maven migration doc - thoughts and suggestions

2018-06-11 Thread Andor Molnar
lanation why we arrived to > > the above conclusions in the above statements. > > The link again: > > https://docs.google.com/document/d/1WXqhaPlCwchcWc8RCEzbCmVa4WbBD > lfR3GQngikGjqc/edit?usp=sharing > > > > Regards, > > Norbert > > > > On Mon,

Re: Maven migration doc - thoughts and suggestions

2018-05-28 Thread Andor Molnar
Excellent job Norbert, this doc will be very useful to discuss all kinds of aspects of the migration. I've left some comments already. Thanks, Andor On Fri, May 25, 2018 at 3:14 PM, Norbert Kalmar wrote: > Hi, > > After doing some proof of work and had some discussion,

Re: ZooKeeper 3.4 to 3.5.x upgrade: "No snapshot found, but there are log entries. Something is broken!"

2018-06-05 Thread Andor Molnar
Hi Matteo / Michael, I confirmed that ZK cannot be upgraded to 3.5.4-beta if there's no snapshot file in the datadir. I get the same error message as Matteo reported. This could be a critical / blocker for the 3.5 release. Michael, how should we track this? I've seen you reopened ZOOKEEPER-2325

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-25 Thread Andor Molnar
Does anybody else has strong or not that strong opinion? Andor On Wed, Jun 20, 2018 at 8:30 PM, Andor Molnar wrote: > What do you think @andschwa? > You did some contribution on CMake recently. > > Andor > > > > On Wed, Jun 20, 2018 at 8:09 PM, Patrick Hunt wrot

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

2018-06-27 Thread Andor Molnar
Hi Michael, Thanks for putting together this new release. My vote: -1 I've run the following tests so far: + signatures verified + java unit tests successful - unable to build C client / C++ unit tests, because ./configure script is not executable BUILD FAILED

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

2018-06-27 Thread Andor Molnar
+ tested with different cluster sizes: 1,3,5,7 + verified a few 4lw commands + verified JMX interface Regards, Andor On Wed, Jun 27, 2018 at 2:51 PM, Andor Molnar wrote: > Hi Michael, > > Thanks for putting together this new release. > > My vote: -1 > > I've run the f

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-20 Thread Andor Molnar
ady do something > special like generate the configure script and ship that as part of the > release? > > Patrick > > On Fri, Jun 8, 2018 at 6:44 AM Andor Molnar wrote: > > > This PR is also related: > > > > https://github.com/apache/zookeeper/pull/362 &g

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-20 Thread Andor Molnar
gt; other option? > > Patrick > > On Wed, Jun 20, 2018 at 11:05 AM Andor Molnar > wrote: > > > "When is pkg-config needed?" > > > > Both. You need the macro to generate ./configure and you need pkg-config > > and cppunit.pc (part of cppunit packa

Re: Maven migration doc - thoughts and suggestions

2018-06-27 Thread Andor Molnar
hit the points that I was going to highlight. Norbert, nice work > > pulling this together. > > > > No major red flags for me. +1 > > > > On Mon, Jun 11, 2018 at 3:29 AM, Andor Molnar > wrote: > > > > > ​Hi team, > > > > > > Just a quick

Re: Bug in Zookeeper 3.4.11 release

2018-01-08 Thread Andor Molnar
check on startup that > > forces a failure if snapshots/logs are where they shouldn't be. That way > we > > prevent people that are running 3.4.11 from experiencing data loss. > > > > Abe > > > > On Wed, Jan 3, 2018, at 03:07, Andor Molnar wrote: > > &g

Re: Bug in Zookeeper 3.4.11 release

2018-01-18 Thread Andor Molnar
I created the jira and started to work on it. https://issues.apache.org/jira/browse/ZOOKEEPER-2967 Andor On Thu, Jan 18, 2018 at 6:15 AM, Andor Molnar <an...@cloudera.com> wrote: > Perhaps we should introduce a check of some kind? If datalogdir is > different that datadir and sna

Re: Bug in Zookeeper 3.4.11 release

2018-01-17 Thread Andor Molnar
. > > Abe - is there a jira to add this check? I'd like to resolve this and the > crc issue and push out a 3.4.12 ASAP. > > Patrick > > > On Mon, Jan 8, 2018 at 1:44 AM, Andor Molnar <an...@cloudera.com> wrote: > > > Thanks Camille. I closed the pull request. > &g

ZooKeeper 3.4.11 bug: dataDir and dataLogDir swapped

2018-02-02 Thread Andor Molnar
Hi all, Please be aware that 3.4.11 has a quite unfortunate bug which causes ZooKeeper to swap dataDir and dataLogDir parameters. If you configured ZK to use separate txn and snapshot folders in these two options and plan to upgrade, you'll experience that ZK is trying to load transaction logs

Re: [ANNOUNCE] New ZooKeeper committer: Abraham Fine

2018-01-30 Thread Andor Molnar
Great news! Congratulations Abe! On Tue, Jan 30, 2018 at 1:22 AM, Patrick Hunt wrote: > The Apache ZooKeeper PMC recently extended committer karma to Abe and he > has accepted. Abe has made some great contributions and we are looking > forward to even more :) > >

[NEW] ZK upgrade test tool

2018-02-06 Thread Andor Molnar
Hi, I thought it could be interesting for some of you that I started to work on an automated upgrade testing tool for ZooKeeper. https://github.com/anmolnar/zk-upgrade-test Reasoning behind it is that later, when 3.5 becomes stable, we'd like to validate if we can upgrade our 3.4 instances

[SUGGESTION] Target branches 3.5 and master (3.6) to Java 8

2018-02-16 Thread Andor Molnar
Hi all, I think it would be nice to draw a line at branch-3.5 and target Java version 8 onwards. It seems to be a good opportunity for the upgrade before we release a stable version of 3.5. The benefit would be the ability to use new features of Java 8 in the code: Do think it's feasible?

Name resolution in StaticHostProvider

2018-02-19 Thread Andor Molnar
Hi all, We need more eyes and brains on the following PR: https://github.com/apache/zookeeper/pull/451 I added a comment few days ago about the way we currently do DNS name resolution in this class and a suggestion on how we could simplify things a little bit. We talked about it with Abe Fine,

Re: [SUGGESTION] Target branches 3.5 and master (3.6) to Java 8

2018-02-22 Thread Andor Molnar
ava for the > client > > > and the server. I think this has the potential to create a lot of > > > confusion for users and contributors. > > > > > > > > I would support moving master (3.6) to java 8, I also think it is > worth > > > considering movin

Re: Name resolution in StaticHostProvider

2018-02-22 Thread Andor Molnar
, Andor On Mon, Feb 19, 2018 at 12:18 PM, Andor Molnar <an...@cloudera.com> wrote: > Hi all, > > We need more eyes and brains on the following PR: > > https://github.com/apache/zookeeper/pull/451 > > I added a comment few days ago about the way we currently do DNS name

Re: [SUGGESTION] Target branches 3.5 and master (3.6) to Java 8

2018-02-16 Thread Andor Molnar
Another option is that we > set a release to be the one in which we migrate and let everyone know that > they need to migrate. > > -Flavio > > > > On 16 Feb 2018, at 12:05, Andor Molnar <an...@cloudera.com> wrote: > > > > Hi all, > > > > I th

Re: Multiple watches in queue

2018-01-02 Thread Andor Molnar
Hi Prasanna, I replied on the SO thread. Regards, Andor On Fri, Dec 22, 2017 at 5:09 AM, Prasanna koirala wrote: > Here is my problem > https://stackoverflow.com/questions/47924402/is-there-a- > way-to-add-watcher-queue-in-zookeeper > > Is there any solution to it ?? Any

Bug in Zookeeper 3.4.11 release

2018-01-03 Thread Andor Molnar
Hi all, Looks like we've a pretty serious bug in 3.4.11: https://issues.apache.org/jira/browse/ZOOKEEPER-2960 In a nutshell: ZK uses dataDir and dataLogDir parameters in the wrong order, meaning it tries to access logs in the snapshot folder and vica versa. Not sure what's the process in such

Re: Discover LEADER from JMX

2018-06-21 Thread Andor Molnar
gt; > Cheers > > > Enrico > > > > > > Il giorno mer 20 giu 2018 alle ore 13:45 Enrico Olivelli < > > > eolive...@gmail.com> ha scritto: > > > > > > > This is my JIRA > > > > I am going to work on a patch > > > >

Re: Discover LEADER from JMX

2018-06-21 Thread Andor Molnar
, if not, skip that. Hope that helps. Regards, Andor On Thu, Jun 21, 2018 at 2:39 PM, Enrico Olivelli wrote: > Andor, > > I had already tried that way but without success. > I have updated the patch with a proposal. > Thanks > > Enrico > > Il gio 21 giu 2

Re: Recent ZK Jenkins failures due to SSL protocol changes on central

2018-06-22 Thread Andor Molnar
+1, drop JDK 1.6 support Andor On Fri, Jun 22, 2018 at 5:53 AM, Michael Han wrote: > +1 on dropping JDK 1.6 support for branch-3.4. > > On Thu, Jun 21, 2018 at 3:55 PM, Brian Nixon > wrote: > > > +1 for discontinuing support for jdk1.6 > > > > > > On Thu, Jun 21, 2018 at 7:58 AM, Norbert

Re: ZooKeeper 3.5 blocker issues

2018-08-14 Thread Andor Molnar
One more item to the list which is very-very important: ZOOKEEPER-236 (SSL/TLS support for Atomic Broadcast protocol) Andor On Mon, Aug 13, 2018 at 2:09 PM, Andor Molnar wrote: > Looking at the list of Critical issues, I think the following items might > be considered as blocke

Re: Hello from your ZooKeeper friends @ Facebook

2018-08-17 Thread Andor Molnar
Great news, thanks Mohamed! Really appreciate your patches so far, I think contribution from Facebook is very valuable for the project. Looking forward for more! Meetup in Menlo Park would be awesome too. I'm located in Hungary so I need to make some efforts to get there, but the sooner you

Re: A new Pluggable Metrics System for ZooKeeper

2018-08-13 Thread Andor Molnar
Thanks for the great work Enrico. Given that you've already opened a pull request on GitHub, I think it's preferable to move the discussion to either GitHub or Jira. Regards, Andor On Fri, Aug 3, 2018 at 2:02 PM, Enrico Olivelli wrote: > ping > > Il giorno mar 24 lug 2018 alle ore 13:03

ZooKeeper 3.5 blocker issues

2018-08-13 Thread Andor Molnar
Hi folks, This has been raised on the user list recently as well, so I think it’s good time to review what’s left for a stable 3.5 release. The list of unresolved blocker issues from Jira is the following:

Re: ZooKeeper 3.5 blocker issues

2018-08-13 Thread Andor Molnar
Looking at the list of Critical issues, I think the following items might be considered as blockers too: ZOOKEEPER-2418 (data inconsistency) ZOOKEEPER-2778 ZOOKEEPER-2846 (data inconsistency) ZOOKEEPER-2930 (leader election deadlock) Regards, Andor > On 2018. Aug 13., at 12:38, Andor Mol

Re: Interesting FB article on CM at scale; LAD

2018-07-20 Thread Andor Molnar
Great article, thanks Pat. There're 2 things which I found particularly interesting: - Is Zeus going to be decod as part of the migration? Are the patches/improvements in it going to be open sources and possibly backported to ZooKeeper? - "Independent data store: ZooKeeper couples a data store

Trying to find pattern in Flaky Tests

2018-07-18 Thread Andor Molnar
Hi, *branch-3.4* I've taken a quick look at our Jenkins builds and in terms of flaky tests, it looks like branch-3.4 is in a pretty good shape. The build hasn't failed for 5-6 days on all JDKs which I think is pretty awesome. *branch-3.5* This branch is in very bad condition. Which is quite

Re: question for observer read only mode

2018-07-17 Thread Andor Molnar
Hi, You might want to take a look at the following issue, looks like it's related: https://issues.apache.org/jira/browse/ZOOKEEPER-1607 Patch available, but never been committed, so the feature is basically not yet implemented. Regards, Andor On Tue, Jul 17, 2018 at 4:31 AM, 凌风郎少 wrote: >

Re: Re: ZooKeeper 3.5 blocker issues

2018-09-10 Thread Andor Molnar
ssed the test for the record > https://aphyr.com/posts/291-jepsen-zookeeper > * Fix all flaky tests on 3.5 - 3.4 has little or no flaky tests at all. > > > On Tue, Sep 4, 2018 at 1:48 AM, Andor Molnar > wrote: > > > Thanks Maoling! That would be huge help, I appreciate it. > > > > Andor > > >

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 1

2018-07-03 Thread Andor Molnar
+1 - signatures verified - successfully run java/c++ unit test suite on CentOS 7 - tested 1,3,7 node clusters - tested rolling upgrade from version 3.4.12 - ran a few smoke tests manually Thanks, Andor On Tue, Jul 3, 2018 at 10:54 AM, Enrico Olivelli wrote: > +1 (non binding) > > Checked

Re: Stable version for SSL/TLS support

2018-01-24 Thread Andor Molnar
Hi Makarand, Afaik there's an ongoing effort to backport TLS support to version 3.4 which is currently the stable branch of Zookeeper. Abe Fine can comment on the progress I believe. As you said 3.5 and 3.6 version are still in alpha and not recommended for production usage. There's no ETA yet of

Re: ZOOKEEPER-2936

2018-02-28 Thread Andor Molnar
Thanks Asutosh! I've added my comments to the pull request. Regards, Andor On Mon, Feb 26, 2018 at 4:42 PM, Asutosh Pandya wrote: > Hello Team, > > Have created below Pull Request for ZOOKEEPER-2936. > > Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2936 > PR:

Re: [SUGGESTION] Target branches 3.5 and master (3.6) to Java 8

2018-03-07 Thread Andor Molnar
s consistent with what the > rest of the ecosystem has defined. Hadoop/Hbase/Kafka/... components, > Curator, etc... > > Regards, > > Patrick > > On Thu, Feb 22, 2018 at 7:52 AM, Andor Molnar <an...@cloudera.com> wrote: > > > Is everybody happy with the pl

Re: Name resolution in StaticHostProvider

2018-03-06 Thread Andor Molnar
Hi Abe, Unfortunately we haven't got any feedback yet. What do you think of implementing Option #3? Regards, Andor On Thu, Feb 22, 2018 at 6:06 PM, Andor Molnar <an...@cloudera.com> wrote: > Did anybody happen to take a quick look by any chance? > > I don't want to push this to

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-05 Thread Andor Molnar
ts rare depends on the number of observers and participants. For > example with very few participants and many observers > your chance of hitting this are quite high. > > Alex > > On Thu, Apr 5, 2018 at 11:44 AM, Andor Molnar <an...@cloudera.com> wrote: > > > Maybe I'm mi

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-05 Thread Andor Molnar
I don't think it's a blocker. The jira and PR has been open since last December and 3.4.11 has released without it. Although this bug is also important to fix, I believe it's more important to release a fix for the regression we've found in 3.4.11 asap. Abe, any thoughts? Regards, Andor On

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-04-05 Thread Andor Molnar
> It is certainly a blocker, just not sure if for 3.4.11 or 3.4.12. > > > Alex > On Thu, Apr 5, 2018 at 10:29 AM Andor Molnar <an...@cloudera.com> wrote: > > > I don't think it's a blocker. > > The jira and PR has been open since last December and 3.4.11 has rele

Re: [VOTE] Upgrade 3.5 and trunk to Java8

2018-04-17 Thread Andor Molnar
; > > +1 (non-binding) > > > > > > On Sat, Mar 24, 2018 at 1:42 PM, Brian Nixon <brian.nixon...@gmail.com > > > > > wrote: > > > > > > > +1 (non-binding) > > > > > > > > On Fri, Mar 23, 2018 at 2:15 AM, Mark Fe

Re: [VOTE] Upgrade 3.5 and trunk to Java8

2018-04-19 Thread Andor Molnar
eper_branch35_jdk7 > ZooKeeper_branch35_openjdk7 > > > On Tue, Apr 17, 2018 at 5:40 AM, Andor Molnar <an...@cloudera.com> wrote: > > > Hi all, > > > > Java 8 upgrade has been merged to the master and 3.5 branches. Thanks > > Michael and thanks everybody for the parti

Re: [VOTE] Migrate ZK to Maven build

2018-04-23 Thread Andor Molnar
+1 (non-binding) On Mon, Apr 23, 2018 at 10:30 AM, Tamas Penzes wrote: > +1 (non-binding) > > On Fri, Apr 20, 2018 at 4:06 PM, Norbert Kalmar > wrote: > > > Hi, > > > > Let's start a vote on migrating to maven instead of ant. > >

Re: Move github discussions from JIRA comments to the JIRA worklog?

2018-04-24 Thread Andor Molnar
definitely +1 On Tue, Apr 24, 2018 at 1:13 AM, Patrick Hunt wrote: > Hey devs, I noticed this recently filed by the Apache Arrow team: > > "Change GitHub Bot to post to Work Log instead of Comments" > https://issues.apache.org/jira/browse/INFRA-16426 > > which really

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 1

2018-03-27 Thread Andor Molnar
+1 for candidate 1 - verified signatures - unit test passed on Mac and Ubuntu 16.04 (including c++) - verified 3 node cluster Andor On Tue, Mar 27, 2018 at 7:05 AM, Abraham Fine wrote: > This is a bugfix release candidate for 3.4.12. It fixes 22 issues, > including issues

Re: Let's cut a ZK 3.5.4-beta release

2018-03-26 Thread Andor Molnar
I'm currently working on ZOOKEEPER-2184. PR has been open for ages on 3.4 branch, please review if you have some capacity. I'll port the fix to the 3.5 branch too, if we have an agreement and 3.4-version is merged. ZK-2982 is somewhat related, I believe my changes will fix that one too. ZK-1818

Re: [VOTE] Apache ZooKeeper release 3.4.12 candidate 0

2018-03-26 Thread Andor Molnar
Hi Abe, Thanks for putting this important release together. +1 I've run the following tests: - verified signatures, - all unit tests passed on Mac (java only) and Ubuntu 16.04 (java & c++ successful), - tested standalone and 3-node cluster, - verified the fix & validation of datadir/logdir

Re: [SUGGESTION] Target branches 3.5 and master (3.6) to Java 8

2018-03-19 Thread Andor Molnar
>From the responses on 'user' list, I think we are good to go. What do you think? Andor On Wed, Mar 7, 2018 at 12:04 PM, Andor Molnar <an...@cloudera.com> wrote: > Okay, I dropped a mail on the user list to get some feedback. > > > Regards, > Andor > > >

Re: [SUGGESTION] Target branches 3.5 and master (3.6) to Java 8

2018-03-22 Thread Andor Molnar
Silence probably means 'yes', so I start the vote now. *Shall we upgrade the minimum required Java version to compile and run ZooKeeper on 3.5 and master branches to Java 1.8?* *Yes / No* I vote for 'Yes'. Regards, Andor On Mon, Mar 19, 2018 at 1:35 PM, Andor Molnar <an...@cloudera.

[VOTE] Upgrade 3.5 and trunk to Java8

2018-03-22 Thread Andor Molnar
Hi all, Let's start the vote on upgrading to Java8. https://issues.apache.org/jira/browse/ZOOKEEPER-3002 *Shall we upgrade the minimum required Java version to compile and run ZooKeeper on 3.5 and master branches to Java 1.8?* Please cast your vote by replying 'Yes' or 'No' to this thread.

Re: [VOTE] Upgrade 3.5 and trunk to Java8

2018-03-22 Thread Andor Molnar
+1 On Thu, Mar 22, 2018 at 7:04 PM, Jordan Zimmerman < jor...@jordanzimmerman.com> wrote: > +1 (non binding) > > > On Mar 22, 2018, at 12:57 PM, Andor Molnar <an...@cloudera.com> wrote: > > > > Hi all, > > > > Let's start the vote on upgrading to

3.4.12

2018-03-01 Thread Andor Molnar
Hi dev, User has recently run into the regression of 3.4.11 (ZOOKEEPER-2960 ) (again?) Are we good to cut 3.4.12 soon or still waiting for something to be committed? Andor

Re: ZooKeeper 3.5 blocker issues

2018-10-08 Thread Andor Molnar
off the on disk txn sync by default for now to >>>> avoid this issue, after we finished ZOOKEEPER-3114, we can use that to >>>> validate the on disk txns during syncing. >>>> >>>> Thanks, >>>> Fangmin >>>> >>>>

Re: Decrease number of threads in Jenkins builds to reduce flakyness

2018-10-12 Thread Andor Molnar
rformance. Reducing > is fine, but do we understand why it's failing? Perhaps it's finding real > issues as a result of the artificial concurrency/load. > > Patrick > > On Fri, Oct 12, 2018 at 7:12 AM Andor Molnar > wrote: > >> Thanks for the feedback. >> I'm run

Re: Decrease number of threads in Jenkins builds to reduce flakyness

2018-10-12 Thread Andor Molnar
he runs. (Although it is much faster, but if we have to run 6-8-10 > times sometimes to get a green run...) > > Norbert > > On Fri, Oct 12, 2018 at 2:05 PM Enrico Olivelli > wrote: > > > +1 > > > > Enrico > > > > Il ven 12 ott 2018, 13:52 Andor Molnar ha sc

Decrease number of threads in Jenkins builds to reduce flakyness

2018-10-12 Thread Andor Molnar
Hi, What do you think of changing number of threads running unit tests in Jenkins from current 8 to 4 or even 2? Running unit tests inside Cloudera environment on a single thread shows the builds much more stable. That would be probably too slow, but maybe running at least less threads would

Re: Decrease number of threads in Jenkins builds to reduce flakyness

2018-10-15 Thread Andor Molnar
is more problematic than it >>>>> appears. there is a race between finding a free port and actually >>>>> grabbing it. i think that contributes to the flakiness. >>>>> >>>> >>>> This is very hard to solve for our test cases, because we need to bu

Re: Decrease number of threads in Jenkins builds to reduce flakyness

2018-10-15 Thread Andor Molnar
+1 On Mon, Oct 15, 2018 at 1:55 PM, Enrico Olivelli wrote: > Il giorno lun 15 ott 2018 alle ore 12:46 Andor Molnar > ha scritto: > > > > Thank you guys. This is great help. > > > > I remember your efforts Bogdan, as far as I remember you observer thread

Re: [VOTE] Maven migration - separation of java files to server and client project?

2018-10-16 Thread Andor Molnar
Thanks Norbert for taking care of this. No surprise here in a 10+ year old project. -1 (binding) for the separation Let’s keep server + client + common together for now. We can revisit this later, but the pro is that we keep the release artifact structure and not introducing breaking changes.

Re: Decrease number of threads in Jenkins builds to reduce flakyness

2018-10-18 Thread Andor Molnar
Lots of ConnectionLoss and Address already in use failures on branch34_java9. Looks like specific to Jenkins slave H22. Andor On Mon, Oct 15, 2018 at 2:50 PM, Andor Molnar wrote: > +1 > > > > On Mon, Oct 15, 2018 at 1:55 PM, Enrico Olivelli > wrote: > >> Il gior

Re: ZooKeeper 3.5 blocker issues

2018-10-26 Thread Andor Molnar
has already been resolved. Have you created a separate ticket for the backport or shall I just reopen it with the right fix versions? Thanks, Andor > On 2018. Oct 8., at 12:34, Andor Molnar wrote: > > Hi, > > Let me summarize and give a quick update on the outstanding is

Re: Decrease number of threads in Jenkins builds to reduce flakyness

2018-10-26 Thread Andor Molnar
tests on trunk is pretty stable >>> https://builds.apache.org/job/zookeeper-trunk-single-thread/ (some >>> failures >>> are due to C tests). The build time is longer, but not too bad (for >>> pre-commit build, for nightly build, build time should not be

Re: asfgit commenting on PRs

2018-11-07 Thread Andor Molnar
t;>>> >>>> Enrico >>>> >>>> >>>> Il giorno mar 6 nov 2018 alle ore 03:44 毛蛤丝 >>>> ha scritto: >>>>> >>>>> +1,for removing the asfgit successful build comments. >>>>> >&

Re: asfgit commenting on PRs

2018-11-05 Thread Andor Molnar
I also feel the comments redundant. Enrico - shall we remove this? Andor > On 2018. Nov 5., at 12:24, Norbert Kalmar > wrote: > > Hi all, > > One of the recent development was that asfgit now comments on the PRs every > successful builds. > But we do have the same information under "Show

Re: [ANNOUNCE] New ZooKeeper committer: Fangmin Lv

2018-11-07 Thread Andor Molnar
Repeating what was said in person - congratulations Fangmin! Andor > On 2018. Nov 7., at 16:31, Michael Han wrote: > > The Apache ZooKeeper PMC recently extended committer karma to Fangmin > and he has accepted. Fangmin has made some great contributions and we > are looking forward to even

Re: question about approach to take

2018-11-13 Thread Andor Molnar
Hi Ted, Thanks for your contribution and the accurate design of this proposal. I have the following comments on it: 1) What's the need of the explicit support of multiple network interfaces? DNS names can resolve into multiple address and we could easily implement trying the multiple addresses

Maven migration - main src dir moved

2018-10-05 Thread Andor Molnar
Hi, Please be aware that the patch which moved ZooKeeper server’s src folder to the new location has been merged. You probably need to rebase your PRs and resolve conflicts to get them merged. Sorry for the inconvenience. Regards, Andor

Trunk builds are failing

2018-09-28 Thread Andor Molnar
Hi, As far as I can see ZOOKEEPER-2847 broke testReconfigRemoveClientFromStatic. Is that correct? Hope it will be fixed soon. Regards, Andor

Re: Prometheus Metrics Provider

2018-10-02 Thread Andor Molnar
Awesome news! I recommend waiting for Norbert to finish migrating the server code, before implementing a new feature to avoid harmful conflicts. He’s just about to finish rebasing: https://github.com/apache/zookeeper/pull/633 Regards, Andor >

Re: ZooKeeper 3.5 blocker issues

2018-09-03 Thread Andor Molnar
believe that if these tickets can be closed in one way or the other, we'll be able to release the upcoming 3.5 version as stable. Thoughts? Regards, Andor On Tue, Aug 14, 2018 at 11:08 AM, Andor Molnar wrote: > One more item to the list which is very-very important: > > ZOOKEEPER-236

Re: Re: ZooKeeper 3.5 blocker issues

2018-09-04 Thread Andor Molnar
Thanks Maoling! That would be huge help, I appreciate it. Andor

Re: New precommit job 'retest this please' trick

2018-09-24 Thread Andor Molnar
Thanks Enrico. Afaik the Rebuild button was already available for committers. How the new process any different from that? Andor On Sun, Sep 23, 2018 at 8:09 AM, Enrico Olivelli wrote: > Hi ZooKeepers, > we have enhanced the "precommit" automated QA testing. > Before merging any patch the

  1   2   3   4   5   6   7   8   9   10   >