eolivelli commented on a change in pull request #858: ZOOKEEPER-3321: Add
metrics for Leader
URL: https://github.com/apache/zookeeper/pull/858#discussion_r266520216
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java
##
@@ -101,6
jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics
for prep processor
URL: https://github.com/apache/zookeeper/pull/855#discussion_r266550581
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java
##
@@ -78,6
jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics
for prep processor
URL: https://github.com/apache/zookeeper/pull/855#discussion_r266645839
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
##
@@
jhuan31 opened a new pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics
URL: https://github.com/apache/zookeeper/pull/859
This is an automated message from the Apache Git Service.
To respond to the message, please log
enixon commented on issue #851: ZOOKEEPER-3311: Allow a delay to the
transaction log flush
URL: https://github.com/apache/zookeeper/pull/851#issuecomment-474044383
@lvfangmin I'm not sure that we have performance data to share on this
setting.
We do use 20ms internally, is there a
anmolnar commented on issue #439: ZOOKEEPER-1621: Delete and skip txn log with
incomplete header
URL: https://github.com/apache/zookeeper/pull/439#issuecomment-474636132
@abhishekrai please rebase this.
This is an automated
anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474637051
Not a big difference though if you don't want to use the extra features of
`AtomicReference`.
anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474594384
@eolivelli I got you, I've just found the `enum` more readable (no need for
`getMetrics()` call). In
anmolnar commented on issue #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket
if defined
URL: https://github.com/apache/zookeeper/pull/427#issuecomment-474635544
@fr0stbyte @phunt Do you still want this patch to be committed?
3.5 gets stable soon, Jira has already been closed, I'd
anmolnar commented on issue #363: branch-3.4 -- bugfix -- ZOOKEEPER-2894
URL: https://github.com/apache/zookeeper/pull/363#issuecomment-474634875
ping @xoiss
This is an automated message from the Apache Git Service.
To
anmolnar commented on issue #360: branch-3.4 -- bugfix -- ZOOKEEPER-2891
URL: https://github.com/apache/zookeeper/pull/360#issuecomment-474634769
ping @xoiss
This is an automated message from the Apache Git Service.
To
anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r267153406
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
anmolnar commented on issue #247: ZOOKEEPER-2778: Potential server deadlock
between follower sync with leader and follower receiving external connection
requests.
URL: https://github.com/apache/zookeeper/pull/247#issuecomment-474634011
Resolved by #707
anmolnar closed pull request #247: ZOOKEEPER-2778: Potential server deadlock
between follower sync with leader and follower receiving external connection
requests.
URL: https://github.com/apache/zookeeper/pull/247
This is
enixon commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474633770
I like this version. My only comment is to second with @anmolnar 's question
about AtomicReference.
jhuan31 opened a new pull request #861: ZOOKEEPER-3326: Add session/connection
related metrics
URL: https://github.com/apache/zookeeper/pull/861
This is an automated message from the Apache Git Service.
To respond to the
anmolnar commented on issue #438: ZOOKEEPER-2959: ignore accepted epoch and
LEADERINFO ack from observers
URL: https://github.com/apache/zookeeper/pull/438#issuecomment-474635872
Already resolved by @lavacat . Thanks.
This
anmolnar closed pull request #438: ZOOKEEPER-2959: ignore accepted epoch and
LEADERINFO ack from observers
URL: https://github.com/apache/zookeeper/pull/438
This is an automated message from the Apache Git Service.
To
maoling commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r267165855
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
maoling opened a new pull request #823: ZOOKEEPER-2694:sync CLI command does
not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823
- Thanks the original work from [arshad.mohammad
](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=arshad.mohammad)
maoling closed pull request #823: ZOOKEEPER-2694:sync CLI command does not wait
for result from server
URL: https://github.com/apache/zookeeper/pull/823
This is an automated message from the Apache Git Service.
To respond
eolivelli commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474718572
@anmolnar @enixon as far as I know AtomicReference wraps a volatile field so
not a big deal
jhuan31 opened a new pull request #862: ZOOKEEPER-3327: Add unrecoverable error
count
URL: https://github.com/apache/zookeeper/pull/862
This is an automated message from the Apache Git Service.
To respond to the message,
jhuan31 opened a new pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics
URL: https://github.com/apache/zookeeper/pull/859
This is an automated message from the Apache Git Service.
To respond to the message, please log
jhuan31 closed pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics
URL: https://github.com/apache/zookeeper/pull/859
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jhuan31 commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics
for Leader
URL: https://github.com/apache/zookeeper/pull/858#discussion_r267417587
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderMetricsTest.java
##
@@
anmolnar commented on issue #848: ZOOKEEPER-3306: Fixing node not accessible
issue due the the inconsistent ACL reference map after SNAP sync
URL: https://github.com/apache/zookeeper/pull/848#issuecomment-474923661
@lvfangmin Huh, this is not easy. Another edge case captured by FB. :)
jhuan31 opened a new pull request #862: ZOOKEEPER-3327: Add unrecoverable error
count
URL: https://github.com/apache/zookeeper/pull/862
This is an automated message from the Apache Git Service.
To respond to the message,
jhuan31 closed pull request #862: ZOOKEEPER-3327: Add unrecoverable error count
URL: https://github.com/apache/zookeeper/pull/862
This is an automated message from the Apache Git Service.
To respond to the message, please
eolivelli commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474986961
Currently having ServerMetrics is good, because it is the only point (a part
from a bunch of other
jhuan31 opened a new pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics
URL: https://github.com/apache/zookeeper/pull/859
This is an automated message from the Apache Git Service.
To respond to the message, please log
jhuan31 commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474978041
Is ServerMetrics going to stay around after we completely migrate to the new
APIs? Is it still going
jhuan31 closed pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics
URL: https://github.com/apache/zookeeper/pull/859
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
anmolnar commented on issue #853: ZOOKEEPER-3316: Remove unused code in
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853#issuecomment-474995714
@jhuan31 Would you please elaborate on why is that code not needed anymore?
@phunt You added it originally, are you happy
eolivelli commented on a change in pull request #856: ZOOKEEPER-3319: Add
metrics for follower and observer
URL: https://github.com/apache/zookeeper/pull/856#discussion_r266676199
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java
##
@@
eolivelli commented on a change in pull request #856: ZOOKEEPER-3319: Add
metrics for follower and observer
URL: https://github.com/apache/zookeeper/pull/856#discussion_r266676004
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java
##
@@
jhuan31 opened a new pull request #860: ZOOKEEPER-3324: Add read/write metrics
for top level znodes
URL: https://github.com/apache/zookeeper/pull/860
another example of Set metrics.
This is an automated message from the
anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r266713330
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
jhuan31 opened a new pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics
URL: https://github.com/apache/zookeeper/pull/859
This is an automated message from the Apache Git Service.
To respond to the message, please log
jhuan31 closed pull request #859: ZOOKEEPER-3323: Add TxnSnapLog metrics
URL: https://github.com/apache/zookeeper/pull/859
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
anmolnar commented on a change in pull request #831: ZOOKEEPER-3286: xid
wrap-around causes connection loss/segfault when hitting predefined XIDs
URL: https://github.com/apache/zookeeper/pull/831#discussion_r266697000
##
File path:
asfgit closed pull request #838: ZOOKEEPER-2168 Add C APIs for new
createContainer Methods
URL: https://github.com/apache/zookeeper/pull/838
This is an automated message from the Apache Git Service.
To respond to the
anmolnar commented on a change in pull request #831: ZOOKEEPER-3286: xid
wrap-around causes connection loss/segfault when hitting predefined XIDs
URL: https://github.com/apache/zookeeper/pull/831#discussion_r266697000
##
File path:
ccma14 commented on a change in pull request #831: ZOOKEEPER-3286: xid
wrap-around causes connection loss/segfault when hitting predefined XIDs
URL: https://github.com/apache/zookeeper/pull/831#discussion_r266701482
##
File path: zookeeper-client/zookeeper-client-c/src/mt_adaptor.c
anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r266712939
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r266712939
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
anmolnar commented on issue #33: ZOOKEEPER-2168 - first pass at C changes for
containers
URL: https://github.com/apache/zookeeper/pull/33#issuecomment-474149570
Committed by #838
This is an automated message from the Apache
anmolnar closed pull request #33: ZOOKEEPER-2168 - first pass at C changes for
containers
URL: https://github.com/apache/zookeeper/pull/33
This is an automated message from the Apache Git Service.
To respond to the message,
anmolnar commented on issue #838: ZOOKEEPER-2168 Add C APIs for new
createContainer Methods
URL: https://github.com/apache/zookeeper/pull/838#issuecomment-474149379
Merged to 3.5 and master branches. Thanks @meszibalu !
This
anmolnar commented on a change in pull request #831: ZOOKEEPER-3286: xid
wrap-around causes connection loss/segfault when hitting predefined XIDs
URL: https://github.com/apache/zookeeper/pull/831#discussion_r266710758
##
File path:
maoling commented on issue #832: ZOOKEEPER-2503:do a hard constraints on the
number of myid which must be between 1 and 255
URL: https://github.com/apache/zookeeper/pull/832#issuecomment-474186545
- @lvfangmin the `validateServerId` logic in `EphemeralType` is not a good
place.
jhuan31 commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics
for Leader
URL: https://github.com/apache/zookeeper/pull/858#discussion_r266731253
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java
##
@@ -101,6
anmolnar commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474153585
Thanks @eolivelli . Great stuff.
Unfortunately I kinda lost tracking the conversation in the
jhuan31 commented on a change in pull request #856: ZOOKEEPER-3319: Add metrics
for follower and observer
URL: https://github.com/apache/zookeeper/pull/856#discussion_r266711644
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java
##
@@
lvfangmin commented on issue #800: ZOOKEEPER-3268: Add commit processor metrics
URL: https://github.com/apache/zookeeper/pull/800#issuecomment-474204490
@anmolnar is this looking good to you?
This is an automated message from
eolivelli commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable
metrics system for ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#discussion_r266769668
##
File path:
lvfangmin commented on issue #853: ZOOKEEPER-3316: Remove unused code in
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853#issuecomment-474202012
I'll merge it tomorrow if there is no objection from the other reviewers.
jhuan31 commented on a change in pull request #858: ZOOKEEPER-3321: Add metrics
for Leader
URL: https://github.com/apache/zookeeper/pull/858#discussion_r266737276
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderMetricsTest.java
##
@@
jhuan31 commented on a change in pull request #854: ZOOKEEPER-3143 Pluggable
metrics system for ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#discussion_r266711426
##
File path:
lvfangmin commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474205055
@eolivelli thanks for making those changes, looks good to me in general, I
have the same question
eolivelli commented on a change in pull request #858: ZOOKEEPER-3321: Add
metrics for Leader
URL: https://github.com/apache/zookeeper/pull/858#discussion_r266758349
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderMetricsTest.java
##
eolivelli commented on a change in pull request #859: ZOOKEEPER-3323: Add
TxnSnapLog metrics
URL: https://github.com/apache/zookeeper/pull/859#discussion_r266860647
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnSnapLogMetricsTest.java
Randgalt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard
constraints on the number of myid which must be between 1 and 255
URL: https://github.com/apache/zookeeper/pull/832#discussion_r266876255
##
File path:
Randgalt commented on a change in pull request #832: ZOOKEEPER-2503:do a hard
constraints on the number of myid which must be between 1 and 255
URL: https://github.com/apache/zookeeper/pull/832#discussion_r266876255
##
File path:
maoling commented on issue #688: reduce session revalidation time after zxid
roll over
URL: https://github.com/apache/zookeeper/pull/688#issuecomment-473825950
@TyqITstudent
- I have some other concern:
comparing the timestamp between leader and follwers in a distributed system
may
eolivelli commented on issue #854: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/854#issuecomment-474259942
> Thanks @eolivelli . Great stuff.
>
> Unfortunately I kinda lost tracking the conversation
jhuan31 commented on a change in pull request #859: ZOOKEEPER-3323: Add
TxnSnapLog metrics
URL: https://github.com/apache/zookeeper/pull/859#discussion_r266963336
##
File path:
zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnSnapLogMetricsTest.java
jhuan31 commented on issue #840: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/840#issuecomment-471616862
> Currently I had to put DefaultMetricsProvider (which is a wrapper around
Facebook implementation)
lvfangmin commented on a change in pull request #843: ZOOKEEPER-3296:
Explicitly closing the sslsocket when it failed handshake to prevent issue
where peers cannot join quorum
URL: https://github.com/apache/zookeeper/pull/843#discussion_r264328572
##
File path:
eolivelli commented on issue #840: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/840#issuecomment-471628313
@jhuan31 yes, exactly
This is an
jhuan31 commented on issue #840: ZOOKEEPER-3143 Pluggable metrics system for
ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/840#issuecomment-471630416
@eolivelli Since you don't think my questions are stupid, so here comes more
:)
Could you
asfgit closed pull request #825: ZOOKEEPER-2474:add a way for client to
reattach to a session when using ZKClientConfig
URL: https://github.com/apache/zookeeper/pull/825
This is an automated message from the Apache Git
anmolnar commented on issue #825: ZOOKEEPER-2474:add a way for client to
reattach to a session when using ZKClientConfig
URL: https://github.com/apache/zookeeper/pull/825#issuecomment-472118746
Committed to master and 3.5 branches. Thanks @maoling @arshadmohammad
@timothyjward
jhuan31 commented on a change in pull request #849: ZOOKEEPER-3305: Add Quorum
Packet metrics
URL: https://github.com/apache/zookeeper/pull/849#discussion_r264763382
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
##
@@
jhuan31 opened a new pull request #850: ZOOKEEPER-3309: Add sync processor
metrics
URL: https://github.com/apache/zookeeper/pull/850
This is an automated message from the Apache Git Service.
To respond to the message,
anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r264821757
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
anmolnar commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r264821463
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
jhuan31 commented on a change in pull request #850: ZOOKEEPER-3309: Add sync
processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r264900279
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
##
@@
jhuan31 commented on a change in pull request #850: ZOOKEEPER-3309: Add sync
processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r264901406
##
File path:
jhuan31 commented on a change in pull request #850: ZOOKEEPER-3309: Add sync
processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r264901448
##
File path:
eolivelli commented on a change in pull request #850: ZOOKEEPER-3309: Add sync
processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r264893579
##
File path:
eolivelli commented on a change in pull request #850: ZOOKEEPER-3309: Add sync
processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r264893397
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
##
eolivelli commented on a change in pull request #850: ZOOKEEPER-3309: Add sync
processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r264893822
##
File path:
eolivelli commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r264864002
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
eolivelli commented on a change in pull request #823: ZOOKEEPER-2694:sync CLI
command does not wait for result from server
URL: https://github.com/apache/zookeeper/pull/823#discussion_r264864554
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
jhuan31 commented on a change in pull request #849: ZOOKEEPER-3305: Add Quorum
Packet metrics
URL: https://github.com/apache/zookeeper/pull/849#discussion_r266088306
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
##
@@
jhuan31 commented on a change in pull request #849: ZOOKEEPER-3305: Add Quorum
Packet metrics
URL: https://github.com/apache/zookeeper/pull/849#discussion_r266088100
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
##
@@
jhuan31 commented on a change in pull request #849: ZOOKEEPER-3305: Add Quorum
Packet metrics
URL: https://github.com/apache/zookeeper/pull/849#discussion_r266089095
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
##
@@
jhuan31 commented on a change in pull request #850: ZOOKEEPER-3309: Add sync
processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r266107659
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
##
@@
anmolnar commented on issue #761: ZOOKEEPER-3237: Allow IPv6 wildcard address
in peer config
URL: https://github.com/apache/zookeeper/pull/761#issuecomment-473381316
@enixon Did you have a chance to try writing unit test?
jhuan31 commented on a change in pull request #849: ZOOKEEPER-3305: Add Quorum
Packet metrics
URL: https://github.com/apache/zookeeper/pull/849#discussion_r266093642
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
##
@@
jhuan31 commented on a change in pull request #849: ZOOKEEPER-3305: Add Quorum
Packet metrics
URL: https://github.com/apache/zookeeper/pull/849#discussion_r266093558
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
##
@@
jhuan31 opened a new pull request #853: ZOOKEEPER-3316: Remove unused code in
SyncRequestProcessor
URL: https://github.com/apache/zookeeper/pull/853
This is an automated message from the Apache Git Service.
To respond to
ccma14 commented on a change in pull request #831: ZOOKEEPER-3286: xid
wrap-around causes connection loss/segfault when hitting predefined XIDs
URL: https://github.com/apache/zookeeper/pull/831#discussion_r266115547
##
File path: zookeeper-client/zookeeper-client-c/src/st_adaptor.c
jhuan31 commented on a change in pull request #849: ZOOKEEPER-3305: Add Quorum
Packet metrics
URL: https://github.com/apache/zookeeper/pull/849#discussion_r266094269
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
##
@@
jhuan31 opened a new pull request #800: ZOOKEEPER-3268: Add commit processor
metrics
URL: https://github.com/apache/zookeeper/pull/800
This is an automated message from the Apache Git Service.
To respond to the message,
jhuan31 closed pull request #800: ZOOKEEPER-3268: Add commit processor metrics
URL: https://github.com/apache/zookeeper/pull/800
This is an automated message from the Apache Git Service.
To respond to the message, please log
jhuan31 commented on a change in pull request #850: ZOOKEEPER-3309: Add sync
processor metrics
URL: https://github.com/apache/zookeeper/pull/850#discussion_r266112585
##
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
##
@@ -74,6
anmolnar commented on issue #838: ZOOKEEPER-2168 Add C APIs for new
createContainer Methods
URL: https://github.com/apache/zookeeper/pull/838#issuecomment-473108515
@meszibalu I tend to accept this patch with that unit test. Seems like
there's literally nothing more we can do about it.
anmolnar commented on a change in pull request #838: ZOOKEEPER-2168 Add C APIs
for new createContainer Methods
URL: https://github.com/apache/zookeeper/pull/838#discussion_r265811014
##
File path: zookeeper-client/zookeeper-client-c/include/proto.h
##
@@ -40,6 +40,8 @@
901 - 1000 of 2630 matches
Mail list logo
