zk-merger-pr.py and PR 1444

i found an interesting issue when merging PR 1444: an unintended icloud email popped up. (it looks like the simple retrigger commits were done with that email.) i thought i could override it with the author prompt but that only adds authors. i ended up modifying the script slightly to account for

Re: Re: [Commit Accident Case Study] Commit 4faf507 broke the build

thank you for figuring this out! two questions: 1) is there a daily test build still running? if so, where can we see its status? 2) what is the easiest way to retrigger tests? (sorry, i know i've asked this before :'( ) ben On Wed, Feb 10, 2021 at 2:18 AM Szalay-Bekő Máté wrote: > > > For

rebase and retest on github

i would really like to get ZOOKEEPER-3922 but it needs to be rebased and retested. is there a nice way to do that on github? or does the pull requestor need to do that? happy new year, ben

[jira] [Created] (ZOOKEEPER-3922) Add support for two server ZooKeeper with hardware oracle

Benjamin Reed created ZOOKEEPER-3922: Summary: Add support for two server ZooKeeper with hardware oracle Key: ZOOKEEPER-3922 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3922 Project

Re: committing changes

great thanx! i've put a reference to this page at the top of the other page. (i'm glad we have a script!!!) thanx ben On Thu, Apr 16, 2020 at 11:05 AM Enrico Olivelli wrote: > > Il Gio 16 Apr 2020, 19:39 Benjamin Reed ha scritto: > > > i want to start getting christopher'

committing changes

i want to start getting christopher's maven changes in! starting with https://github.com/apache/zookeeper/pull/1313 it's been a while since I've actually pushed. i wanted to make sure https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes is still update before i followed the

Re: Contribs as separate git repos

did you mean to mention the c client in the list of things to move to another repo? it's not in contribs right now. i think it would be nice to clean the contrib a bit. i don't really support moving it to a separate repo. the nice thing about keeping it in the same repo is that when there is a

Re: Decrease number of threads in Jenkins builds to reduce flakyness

i think the unique port assignment (d) is more problematic than it appears. there is a race between finding a free port and actually grabbing it. i think that contributes to the flakiness. ben On Fri, Oct 12, 2018 at 8:50 AM Andor Molnar wrote: > > That is a completely valid point. I started to

[jira] [Commented] (ZOOKEEPER-3108) use a new property server.id in the zoo.cfg to substitute for myid file

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615566#comment-16615566 ] Benjamin Reed commented on ZOOKEEPER-3108: -- the reason we kept myid out of the config is so

Re: Jute max buffer size related question

we stop reading the socket once we hit max buffer size so we don't overflow memory. it was put in when a buggy client cause the server to think it was getting a 1G packet and ran out of memory trying to allocate memory for it. in theory we could read in the data and just drop it on the floor. this

[jira] [Resolved] (ZOOKEEPER-3104) Potential data inconsistency due to NEWLEADER packet being sent too early during SNAP sync

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3104. -- Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 583

[jira] [Commented] (ZOOKEEPER-3036) Unexpected exception in zookeeper

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561968#comment-16561968 ] Benjamin Reed commented on ZOOKEEPER-3036: -- can you give a bit more detail as to what

[jira] [Resolved] (ZOOKEEPER-3095) Connect string fix for non-existent hosts

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3095. -- Resolution: Fixed Issue resolved by pull request 579 [https://github.com/apache

[jira] [Resolved] (ZOOKEEPER-3072) Race condition in throttling

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3072. -- Resolution: Fixed > Race condition in throttl

[jira] [Updated] (ZOOKEEPER-3072) Race condition in throttling

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-3072: - Fix Version/s: 3.5.4 3.6.0 > Race condition in throttl

[jira] [Resolved] (ZOOKEEPER-3061) add more details to 'Unhandled scenario for peer' log.warn message

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3061. -- Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 555

[jira] [Resolved] (ZOOKEEPER-3073) fix couple of typos

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3073. -- Resolution: Fixed > fix couple of ty

[jira] [Resolved] (ZOOKEEPER-3078) Remove unused print_completion_queue function

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3078. -- Resolution: Fixed > Remove unused print_completion_queue funct

[jira] [Resolved] (ZOOKEEPER-3079) Fix unsafe use of sprintf(3) for creating IP address strings

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-3079. -- Resolution: Fixed > Fix unsafe use of sprintf(3) for creating IP address stri

[jira] [Resolved] (ZOOKEEPER-2886) Permanent session moved error in multi-op only connections

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-2886. -- Resolution: Fixed > Permanent session moved error in multi-op only connecti

rerunning jenkins test

is there a button on jenkins somewhere that we can push to rerun a test? thanx ben

[jira] [Commented] (ZOOKEEPER-3056) Fails to load database with missing snapshot file but valid transaction log file

[ https://issues.apache.org/jira/browse/ZOOKEEPER-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508441#comment-16508441 ] Benjamin Reed commented on ZOOKEEPER-3056: -- how are you getting in a state where you have

Re: Meetup at Cloudera

is there still going to be a meetup tomorrow? i don't see an announcement anywhere. ben On Fri, Oct 13, 2017 at 12:02 PM, Jordan Zimmerman wrote: > Damn - I'm in Germany - that's 2 in the morning. Can't make it. If it's the > week after, though, I can do it. > >

[jira] [Resolved] (ZOOKEEPER-2772) Delete node command does not honor Acl policy

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-2772. -- Resolution: Not A Bug > Delete node command does not honor Acl pol

[jira] [Commented] (ZOOKEEPER-2772) Delete node command does not honor Acl policy

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009215#comment-16009215 ] Benjamin Reed commented on ZOOKEEPER-2772: -- this appears to be a misunderstanding of what

Re: Ever considered using buck to build?

from patrick's response: "My intent at this point is not to replace anything, just to add the ability to build with buck." this isn't to move to a boutique build system. patrick is just suggesting that he can make available the build files we use inside facebook for others to try. ben On Mon,

Re: Ever considered using buck to build?

part of the reason we haven't moved to maven (this is supposition since i have not been involved in the decision at all) is that it doesn't buy that much over ant. both maven and ant are complex and slow. the one thing maven has is the repository for dependencies. i have been using buck for a

[jira] [Commented] (ZOOKEEPER-2748) Admin command to voluntarily drop client connections

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964730#comment-15964730 ] Benjamin Reed commented on ZOOKEEPER-2748: -- we do this using the JMX interface. i think

[jira] [Commented] (ZOOKEEPER-2693) DOS attack on wchp/wchc four letter words (4lw)

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929091#comment-15929091 ] Benjamin Reed commented on ZOOKEEPER-2693: -- can someone put a good link to the exploit

using java 8 code

have people given thought about moving to java8? i'm really not that excited about moving to java8, but we are running into libraries that we want to use that are compiled with java8. ben

[jira] [Commented] (ZOOKEEPER-2184) Zookeeper Client should re-resolve hosts when connection attempts fail

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873747#comment-15873747 ] Benjamin Reed commented on ZOOKEEPER-2184: -- another option would be to have a background

[jira] [Assigned] (ZOOKEEPER-27) Unique DB identifiers for servers and clients

[ https://issues.apache.org/jira/browse/ZOOKEEPER-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed reassigned ZOOKEEPER-27: -- Assignee: (was: Mahadev konar) Fix Version/s: (was: 3.0.0

[jira] [Commented] (ZOOKEEPER-27) Unique DB identifiers for servers and clients

[ https://issues.apache.org/jira/browse/ZOOKEEPER-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854717#comment-15854717 ] Benjamin Reed commented on ZOOKEEPER-27: had the joy of running into this problem today

[jira] [Updated] (ZOOKEEPER-27) Unique DB identifiers for servers and clients

[ https://issues.apache.org/jira/browse/ZOOKEEPER-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-27: --- Description: Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php

Re: zookeeper git not getting bridged to github

. > > On Fri, Jan 13, 2017 at 3:47 PM, Benjamin Reed <br...@apache.org> wrote: > >> i committed ZOOKEEPER-261 pull request to apache git using the perl >> script. my .netrc wasn't setup properly and then i had a problem >> trying to rerun with the failed branches i

zookeeper git not getting bridged to github

i committed ZOOKEEPER-261 pull request to apache git using the perl script. my .netrc wasn't setup properly and then i had a problem trying to rerun with the failed branches in place. then i started getting very weird errors at the last step of the script and realized that the patch had already

[jira] [Resolved] (ZOOKEEPER-261) Reinitialized servers should not participate in leader election

[ https://issues.apache.org/jira/browse/ZOOKEEPER-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-261. - Resolution: Fixed committed to master > Reinitialized servers should not particip

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752196#comment-15752196 ] Benjamin Reed commented on ZOOKEEPER-2325: -- [~rgs] can you commit this? we need it to get

[jira] [Created] (ZOOKEEPER-2640) fix test coverage for single threaded C-API

Benjamin Reed created ZOOKEEPER-2640: Summary: fix test coverage for single threaded C-API Key: ZOOKEEPER-2640 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2640 Project: ZooKeeper

Re: committing doc changes

ld the documentation > right before generating the first rc for a release and create blocker jiras > in the case there is any issue. > > -Flavio > >> On 30 Nov 2016, at 23:12, Benjamin Reed <br...@apache.org> wrote: >> >> yeah, that's a deeper questio

Re: committing doc changes

gt; > -Jordan > >> On Nov 30, 2016, at 11:23 PM, Benjamin Reed <br...@apache.org> wrote: >> >> when we commit pull requests with doc changes, i think we should >> commit the generated doc as a separate commit. what do you all think? >> i would like to do th

committing doc changes

when we commit pull requests with doc changes, i think we should commit the generated doc as a separate commit. what do you all think? i would like to do that to keep the change from the contributors pristine :) and i think it simplifies things a bit. ben

[jira] [Commented] (ZOOKEEPER-2325) Data inconsistency if all snapshots empty or missing

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706785#comment-15706785 ] Benjamin Reed commented on ZOOKEEPER-2325: -- hey andrew, i've merged all the patches

Re: Apache ZooKeeper Meetup - draft Community Update

looks good! On Wed, Nov 16, 2016 at 2:20 PM, Patrick Hunt wrote: > Hi folks. Ben asked me to give a quick 5-10 minute overview at the meetup > tomorrow giving insight into progress over the last year. Please see the > linked slides that I put together. If you have any comments

november 17 zk meetup (additional registration info required)

sorry for the late notice, but we have found out from security that we will need an email and phone number to get you in without the usual visitor NDA. if you are coming, please send an email to acon...@fb.com with that information by tonight. if you forget to do this or decide to come at the

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645962#comment-15645962 ] Benjamin Reed commented on ZOOKEEPER-2014: -- shall i commit it or are we waiting on something

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635265#comment-15635265 ] Benjamin Reed commented on ZOOKEEPER-2014: -- ah that makes sense. i didn't dig deep enough

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634422#comment-15634422 ] Benjamin Reed commented on ZOOKEEPER-2014: -- just a curious observer: why are we propagating

[jira] [Commented] (ZOOKEEPER-2619) Client library reconnecting breaks FIFO client order

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632820#comment-15632820 ] Benjamin Reed commented on ZOOKEEPER-2619: -- i would love to see ZOOKEEPER-22 fixed, but i

[jira] [Commented] (ZOOKEEPER-2619) Client library reconnecting breaks FIFO client order

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632811#comment-15632811 ] Benjamin Reed commented on ZOOKEEPER-2619: -- multi will handle some of the use cases

[jira] [Commented] (ZOOKEEPER-2623) CheckVersion outside of Multi causes NullPointerException

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632776#comment-15632776 ] Benjamin Reed commented on ZOOKEEPER-2623: -- i agree that we should handle this gracefully

[jira] [Commented] (ZOOKEEPER-2592) Zookeeper is not recoverable once running system( machine on which zookeeper is running) is out of space

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632763#comment-15632763 ] Benjamin Reed commented on ZOOKEEPER-2592: -- it sounds like we should close

november 17 zk meetup reminder

this is just a reminder that we have a zookeeper meetup at facebook on november 17. note that usually you have to sign an NDA to get into facebook, but for the meetup we are giving security a list of people for the event so that they can get in without an NDA. that's why we need you to mark you

Re: QA github pre-commit queue

i also pushed a new version for https://issues.apache.org/jira/browse/ZOOKEEPER-761 although that one might be tricky since there are attached patches and a pr. should the pr still be qaed? On Thu, Oct 27, 2016 at 12:04 PM, Michael Han wrote: > Created PR94 to

[jira] [Commented] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

[ https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612002#comment-15612002 ] Benjamin Reed commented on ZOOKEEPER-761: - not yet, i have a mac and tests don't seem to work

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15607124#comment-15607124 ] Benjamin Reed commented on ZOOKEEPER-2597: -- btw thanx for the script edward! even though

[jira] [Resolved] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-2597. -- Resolution: Fixed > Add script to merge PR from Apache git repo to Git

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15607121#comment-15607121 ] Benjamin Reed commented on ZOOKEEPER-2597: -- i used the script to commit the pull request. i

[jira] [Commented] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

[ https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605468#comment-15605468 ] Benjamin Reed commented on ZOOKEEPER-761: - for some reason my comments/changes do not get

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605414#comment-15605414 ] Benjamin Reed commented on ZOOKEEPER-2597: -- i'll commit at end of day unless someone has

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15605408#comment-15605408 ] Benjamin Reed commented on ZOOKEEPER-2597: -- for some reason my comments were not bridged over

[jira] [Commented] (ZOOKEEPER-2619) Client library reconnecting breaks FIFO client order

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15604093#comment-15604093 ] Benjamin Reed commented on ZOOKEEPER-2619: -- thanx diego, you did express well what i

[jira] [Commented] (ZOOKEEPER-2619) Client library reconnecting breaks FIFO client order

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598842#comment-15598842 ] Benjamin Reed commented on ZOOKEEPER-2619: -- i think it's a good idea to document this issue

Re: svn ref in build.xml

en? Could you create a jira and propose a > > patch or at least describe the issue? > > > > -Flavio > > > > > On 19 Oct 2016, at 18:25, Benjamin Reed <br...@apache.org> wrote: > > > > > > build.xml still has some svn stuff in it. can someone fix? pat? > > > > > > thanx > > > ben > > > > >

svn ref in build.xml

build.xml still has some svn stuff in it. can someone fix? pat? thanx ben

[jira] [Commented] (ZOOKEEPER-761) Remove *synchronous* calls from the *single-threaded* C clieant API, since they are documented not to work

[ https://issues.apache.org/jira/browse/ZOOKEEPER-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586819#comment-15586819 ] Benjamin Reed commented on ZOOKEEPER-761: - this is a pretty good patch to make things start

Re: november 17, 2016 zookeeper meetup at facebook

yes. we'll put up streaming information on the event page when the time gets closer. On Tue, Oct 18, 2016 at 5:10 AM, Edward Ribeiro <edward.ribe...@gmail.com> wrote: > There will be live streaming? :) > > Thanks, > Edward > > On Tue, Oct 18, 2016 at 2:51 AM, Benjami

november 17, 2016 zookeeper meetup at facebook

we would like to invite you all to a zookeeper meetup at the facebook campus on november 17, 2016 starting at 5pm. please use the following link to the facebook event to get details and rsvp. https://www.facebook.com/events/1228722650504268 we need you to rsvp to make sure we plan appropriately

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567516#comment-15567516 ] Benjamin Reed commented on ZOOKEEPER-2597: -- cool i opened an infra jira to see if they can

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15567338#comment-15567338 ] Benjamin Reed commented on ZOOKEEPER-2597: -- are you still working on this edward? do you want

[jira] [Comment Edited] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559081#comment-15559081 ] Benjamin Reed edited comment on ZOOKEEPER-2597 at 10/9/16 2:16 AM

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559081#comment-15559081 ] Benjamin Reed commented on ZOOKEEPER-2597: -- no problem. i made some reviews. (i though

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558730#comment-15558730 ] Benjamin Reed commented on ZOOKEEPER-2597: -- did you put up the pull request? > Add scr

Re: [VOTE] move Apache Zookeeper to git

> > > the > > > > >>> Kafka setup, so perhaps he can give an update if I'm right. Kafka > > > > doesn't > > > > >>> send every comment to the mailing list, though, but I'm not sure > if > > > > >> that's > >

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15556598#comment-15556598 ] Benjamin Reed commented on ZOOKEEPER-2597: -- great thanx! i have a couple of questions about

[jira] [Commented] (ZOOKEEPER-2597) Add script to merge PR from Apache git repo to Github

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552617#comment-15552617 ] Benjamin Reed commented on ZOOKEEPER-2597: -- i'm just starting to look at this script. it's

Re: november meetup at facebook (take 2)

ep 30, 2016 2:26 PM, "Marshall McMullen" < > > marshall.mcmul...@gmail.com> > > wrote: > > +1. I would love to attend along with a few of my coworkers and > > this > > date > > works for us. > > On Fri, Sep 30, 2016 at 3:10 PM, Benjamin Reed <br

Re: ZooKeeper clients does not handle new error codes properly

did we bump the protocol version when we added the new errors? the server could do the conversion when it responds to older clients. On Mon, Oct 3, 2016 at 3:05 AM, Flavio Junqueira wrote: > Hi Arshad, > > It makes sense to me. What if we convert unknown server errors to >

Re: ZooKeeper ping requests Unnecessarily go though request processor chain

yes, vitalii is correct. the ping is a mutual test of health, so we want it to go through the full pipeline. On Mon, Oct 3, 2016 at 5:26 AM, Vitalii Tymchyshyn wrote: > Hi. > > I think this would break ordering guarantie, would not it? > Also ping is supposed to test health and I

[jira] [Resolved] (ZOOKEEPER-2600) dangling ephemerals on overloaded server with local sessions

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-2600. -- Resolution: Cannot Reproduce > dangling ephemerals on overloaded server with lo

[jira] [Commented] (ZOOKEEPER-2600) dangling ephemerals on overloaded server with local sessions

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15518765#comment-15518765 ] Benjamin Reed commented on ZOOKEEPER-2600: -- i investigated this further and it appears

[jira] [Created] (ZOOKEEPER-2600) dangling ephemerals on overloaded server with local sessions

Benjamin Reed created ZOOKEEPER-2600: Summary: dangling ephemerals on overloaded server with local sessions Key: ZOOKEEPER-2600 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2600 Project

Re: [VOTE] move Apache Zookeeper to git

dev list in a > separate thread - Chris do you want to implement that change now that we've > moved to git? > > Patrick > > On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed <br...@apache.org> wrote: > >> > 1) actually in the previous step that was just adding new fi

Re: [VOTE] move Apache Zookeeper to git

> > > 1) actually in the previous step that was just adding new files. you > still > > need the commit -a for the rest of the changes. that's my normal > workflow. > > I think that will be confusing for most folks. They typically stage > all the changes and then commit or don't stage and use -a. >

Re: [VOTE] move Apache Zookeeper to git

; from that same wiki page. I recommend you add back the > --no-prefix until we are able to address (also impacts any pending > patches created using the old style) > > Patrick > > On Mon, Sep 12, 2016 at 10:13 PM, Benjamin Reed <br...@apache.org> wrote: > >

Re: [VOTE] move Apache Zookeeper to git

rtunity to learn a bit more about the > moving parts of an Apache project if you consider becoming a ZK committer > eventually. > > -Flavio > > > On 13 Sep 2016, at 06:13, Benjamin Reed <br...@apache.org> wrote: > > > > i've updated the contributing to zookeep

[jira] [Commented] (ZOOKEEPER-2465) Documentation copyright notice is out of date.

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485391#comment-15485391 ] Benjamin Reed commented on ZOOKEEPER-2465: -- the last time a similar issue came up like

Re: [VOTE] move Apache Zookeeper to git

gt; > > Any concerns with such an approach? > > > > > > > > Patrick > > > > > > > > On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt <ph...@apache.org> > wrote: > > > > > > > >> Follow alon

[jira] [Commented] (ZOOKEEPER-2169) Enable creation of nodes with TTLs

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469376#comment-15469376 ] Benjamin Reed commented on ZOOKEEPER-2169: -- can't you just do a stat to find this out

Re: [VOTE] move Apache Zookeeper to git

: > > > > > > > > +1 (non binding) > > > > > > > > On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman < > > > jor...@jordanzimmerman.com > > > >> wrote: > > > > > > > >> +1 (non binding) > > > >&g

[jira] [Commented] (ZOOKEEPER-2536) When provide path for "dataDir" with trailing space, it is taking correct path (by trucating space) for snapshot but creating temporary file with some junk folder n

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457459#comment-15457459 ] Benjamin Reed commented on ZOOKEEPER-2536: -- BTW i think the patch is not applying because you

[jira] [Commented] (ZOOKEEPER-2537) When provide path for "dataDir" with heading space, it is taking correct path (by trucating space) for snapshot but zookeeper_server.pid is getting created in root

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457457#comment-15457457 ] Benjamin Reed commented on ZOOKEEPER-2537: -- isn't this the same as ZOOKEEPER-2536? > W

[jira] [Commented] (ZOOKEEPER-2536) When provide path for "dataDir" with trailing space, it is taking correct path (by trucating space) for snapshot but creating temporary file with some junk folder n

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457447#comment-15457447 ] Benjamin Reed commented on ZOOKEEPER-2536: -- +1 LGTM > When provide path for "

[jira] [Commented] (ZOOKEEPER-2539) Throwing nullpointerException when run the command "config -c" when client port is mentioned as separate and not like new style

[ https://issues.apache.org/jira/browse/ZOOKEEPER-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457427#comment-15457427 ] Benjamin Reed commented on ZOOKEEPER-2539: -- +1 looks good, just a formatting nit you need

Re: Issue with NettyServerCnxn.java

hecked the methods that call sendResponse and they seem to be able > to > > >> handle IOExceptions fine. For example, in NettyServerCnxn.process, we > > call > > >> close upon IOException, which is exactly the behavior you mention you > > >> should have. >

Re: Issue with NettyServerCnxn.java

s. > I will submit a JIRA on this (hopefully today). Either we should not > bubble up any exception by IOException or ZK server should be stopped, as > it is really hard to figure out without turning on tracing what really > happened. > ThanksYuliya > > From: Benjamin Reed <

Re: Issue with NettyServerCnxn.java

if i remember correctly the case in sendResponse where it is catching the IOException is due to the fact that we are opportunistically trying to send something on a non-blocking channel. if it works, ok, but if we can't send because we are blocked then we will just send later. in the case of

[VOTE] move Apache Zookeeper to git

flip the switch to git and update the relevant scripts and docs. i couldn't figure out which timeframe this falls under in the voting procedure table, but i think it's safe to go with 3 days, so the vote will close on Saturday, September 3 at 6:30pm pdt. +1 from me

Re: switching to git?

t;f...@apache.org> wrote: > > > On 30 Aug 2016, at 07:42, Benjamin Reed <br...@apache.org> wrote: > > > > i'm curious, can we get the qa > > bot to trigger off a pull request? > > Yes, we can. See this Kafka build queue: > > https://build

Re: switching to git?

that the qabot is purposely setup to run arbitrary code from a web page. a security nightmare :) ) ben On Mon, Aug 29, 2016 at 8:56 PM, Patrick Hunt <ph...@apache.org> wrote: > On Mon, Aug 29, 2016 at 8:48 AM, Benjamin Reed <br...@apache.org> wrote: > > > gerritt is pretty a

  1   2   3   4   5   6   >