Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated אפריל 12, 2016, 6:55 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated אפריל 12, 2016, 6:26 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On March 25, 2016, 9:05 a.m., Rakesh R wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 269 > > > > > > Should the admin take any action on seeing this error? I'm

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On March 25, 2016, 9:05 a.m., Rakesh R wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 269 > > > > > > Should the admin take any action on seeing this error? I'm

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On March 26, 2016, 6:49 p.m., Raul Gutierrez Segales wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 231 > > > > > > shouldn't this be an assertion? if request is

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On March 26, 2016, 6:38 p.m., Raul Gutierrez Segales wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 99 > > > > > > hmm, should preallocate memory for this hashmap?

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On Feb. 13, 2016, 6:27 p.m., Alexander Shraer wrote: > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java, > > line 216 > > > > > > also check that all the following reads

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On March 27, 2016, 2:42 p.m., fpj wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 96 > > > > > > Could you align the lines of the comment pls? Done. > On March 27,

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review125565 --- The patch looks mostly good. I have several trivial comments, but

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On March 26, 2016, 6:49 p.m., Raul Gutierrez Segales wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 231 > > > > > > shouldn't this be an assertion? if request is

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On March 26, 2016, 6:38 p.m., Raul Gutierrez Segales wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 99 > > > > > > hmm, should preallocate memory for this hashmap?

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated מרץ 26, 2016, 7:06 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review125540 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On March 26, 2016, 6:38 p.m., Raul Gutierrez Segales wrote: > > minor, though important, nit: mind dropping the extra whitespaces and tabs included? Thanks! - Raul --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review125537 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On מרץ 25, 2016, 9:05 בבוקר, Rakesh R wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 269 > > > > > > Should the admin take any action on seeing this error? I'm

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated מרץ 26, 2016, 5:37 בבוקר) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review125396 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 19, 2016, 12:56 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review119818 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 19, 2016, 6:02 בבוקר) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review119810 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 19, 2016, 3:55 בבוקר) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 18, 2016, 7:01 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 18, 2016, 1:45 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 17, 2016, 9:07 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review119463 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 17, 2016, 2:11 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review119336 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 16, 2016, 11:44 בבוקר) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 16, 2016, 11:38 בבוקר) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review119280 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On פבר' 13, 2016, 6:27 אחר הצהריים, Alexander Shraer wrote: > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java, > > line 216 > > > > > > also check that all the following

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On פבר' 13, 2016, 10:05 אחר הצהריים, Alexander Shraer wrote: > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java, > > line 224 > > > > > > isnt this a read only workload (#writes = 0)

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review119151 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review119163 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 12, 2016, 12:23 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 12, 2016, 7:05 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

> On פבר' 10, 2016, 9:59 אחר הצהריים, Chris Conroy wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 98 > > > > > > shouldn't this be a concurrent map OR by `@GaurdedBy`

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 10, 2016, 8:18 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review118732 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated פבר' 11, 2016, 5:43 בבוקר) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated יאנ' 25, 2016, 10:53 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated יאנ' 25, 2016, 11:51 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated יאנ' 26, 2016, 12:08 בבוקר) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated Sept. 11, 2014, 9:25 a.m.) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

On ספט' 9, 2014, 6:14 אחר הצהריים, Alexander Shraer wrote: ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java, line 158 https://reviews.apache.org/r/25160/diff/6/?file=683706#file683706line158 I'm not sure this does what you think it does. If I understand

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated ספט' 10, 2014, 8:31 אחר הצהריים) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated Sept. 9, 2014, 8:33 a.m.) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

On Sept. 9, 2014, 5:48 a.m., Alexander Shraer wrote: ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, line 283 https://reviews.apache.org/r/25160/diff/2-4/?file=675058#file675058line283 Instead of addToPending I suggest to call this function

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated Sept. 9, 2014, 8:51 a.m.) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review52755 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated Sept. 8, 2014, 7:42 a.m.) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

On Sept. 7, 2014, 9:39 p.m., Alexander Shraer wrote: ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, line 202 https://reviews.apache.org/r/25160/diff/2/?file=675058#file675058line202 indentation Not sure if I got this one right, please verify. - Kfir

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review52675 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review52561 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

On Sept. 7, 2014, 9:39 p.m., Alexander Shraer wrote: ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, line 86 https://reviews.apache.org/r/25160/diff/2/?file=675058#file675058line86 Please move comment to preceding line (try to have ~80 chars per line

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated Sept. 8, 2014, 5:18 a.m.) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

On Sept. 7, 2014, 9:39 p.m., Alexander Shraer wrote: ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, line 519 https://reviews.apache.org/r/25160/diff/2/?file=675058#file675058line519 indentation (I dropped all the issues that aren't found at version 3.)

Re: Review Request 25160: Major throughput improvement with mixed workloads

On Sept. 2, 2014, 9:39 p.m., Grant Monroe wrote: ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, line 351 https://reviews.apache.org/r/25160/diff/1/?file=671464#file671464line351 Should this be continue instead of return? If a single session has

Re: Review Request 25160: Major throughput improvement with mixed workloads

On Sept. 2, 2014, 8:23 p.m., Grant Monroe wrote: ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, line 391 https://reviews.apache.org/r/25160/diff/1/?file=671464#file671464line391 what if request is null? Right, it'll be an error since we reach this code

Re: Review Request 25160: Major throughput improvement with mixed workloads

On Sept. 2, 2014, 10:02 p.m., Grant Monroe wrote: ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, line 277 https://reviews.apache.org/r/25160/diff/1/?file=671464#file671464line277 This looks controversial. I can see the advantage of fast forwarding

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- (Updated Sept. 3, 2014, 8:52 a.m.) Review request for zookeeper, Raul

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review52074 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review52075 ---

Re: Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review52091 ---

Review Request 25160: Major throughput improvement with mixed workloads

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/ --- Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer.