Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Ehsan Akhgari
On Fri, Nov 30, 2018 at 4:08 PM Gregory Szorc wrote: > On Fri, Nov 30, 2018 at 10:00 AM wrote: > > > Now that all of mozilla-central is been migrated to use clang-format > > automated code formatting, the question of what should happen with editor > > modelines at the top of files should be

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Ehsan Akhgari
On Fri, Nov 30, 2018 at 2:06 PM Nathan Froyd wrote: > On Fri, Nov 30, 2018 at 1:51 PM Ehsan Akhgari > wrote: > > I think these are all great points. It seems like for Emacs, it is not > > actually necessary to sprinkle modelines across all of the files in your > > repository (per

Re: Intent to ship: stop dispatching "keypress" events when pressed key (key combination) does not introduce text input

2018-11-30 Thread Eli Grey via dev-platform
On Thursday, November 29, 2018 at 5:22:47 PM UTC-8, masayuki nakano wrote: > Summary: We'll stop dispatching non-printable "keypress" events. > "non-printable" means that key press or key combination does not > introduce text input without IME. For example, arrow key press, Ctrl+A, > etc. > >

Re: Intent to ship: stop dispatching "keypress" events when pressed key (key combination) does not introduce text input

2018-11-30 Thread Eli Grey via dev-platform
On Thursday, November 29, 2018 at 5:22:47 PM UTC-8, masayuki nakano wrote: > Summary: We'll stop dispatching non-printable "keypress" events. > "non-printable" means that key press or key combination does not > introduce text input without IME. For example, arrow key press, Ctrl+A, > etc. > >

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Mike Hommey
On Fri, Nov 30, 2018 at 09:57:00AM -0800, tcampb...@mozilla.com wrote: > Now that all of mozilla-central is been migrated to use clang-format > automated code formatting, the question of what should happen with editor > modelines at the top of files should be considered. > >

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Gregory Szorc
On Fri, Nov 30, 2018 at 10:00 AM wrote: > Now that all of mozilla-central is been migrated to use clang-format > automated code formatting, the question of what should happen with editor > modelines at the top of files should be considered. > >

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Tom Tromey
Nathan> Unfortunately, it doesn't look like .dir-locals.el provides any way to Nathan> set file modes, e.g. setting python-mode for moz.build file That's correct, it's a hole in dir-locals (there's already a bug filed against Emacs for this). It's also easy to document how to update

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Nathan Froyd
On Fri, Nov 30, 2018 at 1:51 PM Ehsan Akhgari wrote: > I think these are all great points. It seems like for Emacs, it is not > actually necessary to sprinkle modelines across all of the files in your > repository (per https://bugzilla.mozilla.org/show_bug.cgi?id=1023839#c7). > For Vim, Benjamin

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Andrew McCreight
On Fri, Nov 30, 2018 at 10:00 AM wrote: > Now that all of mozilla-central is been migrated to use clang-format > automated code formatting, the question of what should happen with editor > modelines at the top of files should be considered. > >

Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Ehsan Akhgari
On Fri, Nov 30, 2018 at 1:00 PM wrote: > Now that all of mozilla-central is been migrated to use clang-format > automated code formatting, the question of what should happen with editor > modelines at the top of files should be considered. > >

Re: The tree has been reformatted now!

2018-11-30 Thread Emilio Cobos Álvarez
And https://hg.mozilla.org/mozilla-central/rev/138f65958545 if you use the git driver if you don't want sadness :) -- Emilio On 11/30/18 6:20 PM, Andi-Bogdan Postelnicu wrote: Hello all, I’m coming back with a followup email since I don’t think that in the previous email we mentioned what

What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread tcampbell
Now that all of mozilla-central is been migrated to use clang-format automated code formatting, the question of what should happen with editor modelines at the top of files should be considered. https://bugzilla.mozilla.org/show_bug.cgi?id=clang-format Here are some options and some arguments

Re: Upcoming C++ standards meeting in San Diego, California

2018-11-30 Thread Botond Ballo
Hi everyone, My blog post about the C++ standards meeting that took place earlier this month is now published: https://botondballo.wordpress.com/2018/11/30/trip-report-c-standards-meeting-in-san-diego-november-2018/ Cheers, Botond On Mon, Oct 22, 2018 at 5:52 PM Botond Ballo wrote: > > Hi

Re: The tree has been reformatted now!

2018-11-30 Thread Andi-Bogdan Postelnicu
Hello all, I’m coming back with a followup email since I don’t think that in the previous email we mentioned what is the minimum version that should be used for rebasing. o changeset: 501271:bf92aff5b93d | tag: tip | fxtree: central | user:Andi-Bogdan Postelnicu |

The tree has been reformatted now!

2018-11-30 Thread Andi-Bogdan Postelnicu
Hello all Starting with revision 6f3709b3878117466168c40affa7bca0b60cf75b mozilla-central has been formatted using ./mach clang-format following the Google coding style. In order to diminish as much as

Re: Intent to ship: set keyCode or charCode of "keypress" event to the other's non-zero value

2018-11-30 Thread James Graham
On 30/11/2018 01:37, Masayuki Nakano wrote: web-platform-tests: N/A due to requiring user input, but we have mochitests with synthesized events. I think it should be possible to write web-platform-tests for this kind of thing now, using the testdriver API and in particular the actions