Re: reproducing bug 808466

2012-12-18 Thread Gijs Kruitbosch
On 18/12/2012 12:02 PM, Robert O'Callahan wrote: Bug 808466 is about changes in selection sometimes not being rendered in a timely manner. Basically you select something and the selection doesn't show up immediately. It will usually show up after some delay. I *think* this is a rendering bug

Re: Rethinking the amount of system JS we use in Gecko on B2G

2013-04-22 Thread Gijs Kruitbosch
On 23/04/13 24:18 , Nicolas B. Pierron wrote: On 04/22/2013 07:53 AM, Justin Lebar wrote: This is the wifi worker. I think script-sources is code. Note that fragmentation (unused-arenas) is way too high, but even despite this the worker uses too much memory. 2.38 MB (05.13%) --

Re: Can't get the xpcom service with do_GetService

2013-07-10 Thread Gijs Kruitbosch
On 29/05/13 08:22 , Hao Dong wrote: I try to use the following code to get the the jsdIDebuggerService, but it failed nsresult rv; const char jsdServiceCtrID[] = @mozilla.org/js/jsd/debugger-service;1; nsCOMPtr jsds = do_GetService(jsdServiceCtrID, rv); who can help me solve

Re: Can't get the xpcom service with do_GetService

2013-07-10 Thread Gijs Kruitbosch
On 29/05/13 10:50 , Neil wrote: Gijs Kruitbosch wrote: Don't use the old JSD1 debugger service anymore. It has been replaced by JSD2. Do you mean replaced in the sense of here's how to replace what you were doing in JSD1 or in the sense of JSD2 is cool! Let's drop JSD1? The latter

Re: Replacing Gecko's URL parser

2013-07-10 Thread Gijs Kruitbosch
On 01/07/13 19:01 , Boris Zbarsky wrote: On 7/1/13 12:43 PM, Anne van Kesteren wrote: I outlined two issues below, but I'm sure there are more. Another big one I'm aware of is the issue of how to treat '\\' in URLs. -Boris We also have issues with hashes and URI-encoding (

Re: Reparenting a XulRunnner window in a Firefox Window

2013-07-10 Thread Gijs Kruitbosch
On 02/07/13 17:34 , Paul Rouget wrote: The Firefox OS Simulator is a XulRunner instance run from Firefox. Two processes, two windows, two different version of gecko. It would be very useful if we could display the simulator as part of Firefox. Inside a tab. With Linux, we could use

Re: review stop-energy (was 24hour review)

2013-07-11 Thread Gijs Kruitbosch
On 11/07/13 12:09 , Nicholas Nethercote wrote: On Thu, Jul 11, 2013 at 7:48 AM, Jeff Walden jwalden+...@mit.edu wrote: Establishing one-day turnaround time on reviews, or on requests, would require a lot more polling on my review queue. You poll your review queue? Like, by visiting your

Re: How to check if an element is visible...

2013-09-17 Thread Gijs Kruitbosch
On 17/09/13 11:18 , Neil wrote: Gavin Sharp wrote: On Mon, Sep 16, 2013 at 5:12 AM, Aryeh Gregor a...@aryeh.name wrote: The real question is: what's the use-case you're trying to solve? If it's some sort of optimization, false positives should be okay. The find bar wants to avoid finding

Re: Does nsIXULChromeRegistry work in non-XUL products?

2013-09-20 Thread Gijs Kruitbosch
On 20/09/13 13:29 , Henri Sivonen wrote: I don't happen to have multi-locale Android or B2G builds set up, but I need to know how they behave to avoid breaking them. Does anyone happen to know if the following code would end up printing the locale code for the active browser UI localization on

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Gijs Kruitbosch
On 02/10/13 21:33 , Erik Rose wrote: What features do you most use in MXR and DXR? Over in the recently renamed Web Engineering group, we're working hard to retire MXR. It hasn't been maintained for a long time, and there's a lot of duplication between it and DXR, which rests upon a more

Re: Faster builds, now.

2013-10-07 Thread Gijs Kruitbosch
On 07/10/13 14:11 , Honza Bambas wrote: Is this supposed to work on Windows too? a clobbered build of up to date m-c with export MOZ_PSEUDO_DERECURSE=1 gives me an error during configure phase (./mach build): No: On 10/2/2013 3:17 AM, Mike Hommey wrote: snip Except if you're using pymake,

Re: Poll: What do you need in MXR/DXR?

2013-10-08 Thread Gijs Kruitbosch
http://dxr.mozilla.org/mozilla-central shouldn't 404, but do something useful (probably redirect to either root or %source/) ~ Gijs ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: devolution of cleartype rendering in Fx chrome

2013-10-16 Thread Gijs Kruitbosch
On 16/10/13 22:52 , Brian Smith wrote: On Wed, Oct 16, 2013 at 1:39 PM, al...@yahoo.com wrote: In general, if I understand correctly, it's hard to use native subpixel AA in layers that use hardware accelerated compositing. So in some cases we might need to choose between speed and subpixel

Re: Overriding content window methods with chrome functions

2013-10-21 Thread Gijs Kruitbosch
On 21/10/13 16:19 , Matthew Gertner wrote: I'm loading a page into a browser type=content but I want the close() method to call a function defined in chrome. I tried the obvious: window.wrappedJSObject.close() = function() { ... }; However, the old close() method is still called (as far as I

Re: how long are we continuing 32-bit OS X support?

2013-10-21 Thread Gijs Kruitbosch
On 21/10/13 17:24 , Nathan Froyd wrote: [Not sure if this is strictly dev-platform material; dev-planning might have been more appropriate in some respects.] Our Firefox builds for OS X currently build a 32-bit version, a 64-bit version, and then squash those together to produce a universal

Re: Faster builds, now ; on windows, too.

2013-10-21 Thread Gijs Kruitbosch
I tend to use something like ./mach build browser/base browser/components browser/themes browser/locales browser/devtools (obviously including only the directories where I changed stuff) Which is fast and works. ~ Gijs On 21/10/13 23:47 , David Rajchenbach-Teller wrote: Wouldn't it be

Re: Mozilla development bootcamp

2013-11-03 Thread Gijs Kruitbosch
On 03/11/13, 11:46 , Neil wrote: 14. Rebasing a bitrotted patch 14.0 What it looks like when you qpush a patch that has conflics 14.1 Open a rej file 14.2 Apply the change to the file Shouldn't be necessary these days ;-) Uh, why not? ~ Gijs

Re: Mozilla development bootcamp

2013-11-04 Thread Gijs Kruitbosch
On 04/11/13, 10:30 , Neil wrote: Gijs Kruitbosch wrote: On 03/11/13, 11:46 , Neil wrote: 14. Rebasing a bitrotted patch 14.0 What it looks like when you qpush a patch that has conflics 14.1 Open a rej file 14.2 Apply the change to the file Shouldn't be necessary these days ;-) Uh, why

Re: Running a backout branch with Mercurial at JAWS.

2013-11-25 Thread Gijs Kruitbosch
On 25/11/13, 10:25 , Philip Chee wrote: Original blog post at http://msujaws.wordpress.com/2013/11/21/running-a-backout-branch-with-mercurial/ An other problem with identifying a patch as Australis specific are patches with bits in Australis/browser and bits in Gecko (e.g. layout or content).

Re: Improvements to the Sphinx in-tree documentation generation

2013-12-16 Thread Gijs Kruitbosch
From what I've been able to tell from the interwebs, extracting documentation (autodoc-fashion) from JS/C++/IDL isn't possible with Sphinx. Is that correct? This makes me sad because it means I probably have to end up copy-pasting my source code documentation elsewhere either way (in which

Re: Workaround for hg.mozilla.org timeouts with TBPL try results

2014-01-19 Thread Gijs Kruitbosch
On 19/01/2014 16:38, Ed Morley wrote: On 19 January 2014 16:35:11, Ed Morley wrote: In addition, this change will mean that try repository resets (done periodically to avoid problems with the way we abuse mercurial for try server) will no longer stop you accessing old job results - as long as

Re: Possible to make all (CSS) transitions 0/1ms to speed up FxOS Gaia tests?

2014-02-17 Thread Gijs Kruitbosch
While I realize this is unlikely to be an option for gaia, I'll just note that for (Firefox Desktop's) Australis' Customization Mode, we ended up just having a pref which tests toggle, in which case we set an attribute, in which case we override the CSS transition duration to be really short.

Re: Always brace your ifs

2014-02-23 Thread Gijs Kruitbosch
On 23/02/2014 00:33, Joshua Cranmer  wrote: On 2/22/2014 5:57 PM, Gregory Szorc wrote: On Feb 22, 2014, at 8:18, Kyle Huey m...@kylehuey.com wrote: If you needed another reason to follow the style guide: https://www.imperialviolet.org/2014/02/22/applebug.html Code coverage would have

Re: Memory management in features implemented in JS

2014-03-20 Thread Gijs Kruitbosch
On 20/03/2014 02:25, Boris Zbarsky wrote: On 3/19/14 9:41 PM, Justin Dolske wrote: It uses a weak reference with the observer service, plus a dummy strong reference (via addEventListener()) to automatically manage the lifetime... When the node/document does away, so does the event listener.

Re: Spring cleaning: Reducing Number Footprint of HG Repos

2014-03-27 Thread Gijs Kruitbosch
On 27/03/2014 13:43, Justin Wood (Callek) wrote: On 3/27/2014 2:58 AM, Doug Turner wrote: Want to move to github? (0) sudo apt-get install python-setuptools (1) sudo easy_install hg-git (2) add |hggit =| under [extensions] in your .hgrc file (3) Go to GitHub.com and create your new repo. (4)

Re: Is XPath still a thing?

2014-04-15 Thread Gijs Kruitbosch
On 15/04/2014 14:21, Andreas Tolfsen wrote: On 15/04/2014 11:17, Anne van Kesteren wrote: On Mon, Apr 14, 2014 at 10:54 PM, Jorge Villalobos jo...@mozilla.com wrote: FWIW, many add-ons use XPath. If there's anything we should be recommending add-on developers to migrate to, please let me know.

Re: Oculus VR support somehwat-non-free code in the tree

2014-04-15 Thread Gijs Kruitbosch
On 15/04/2014 22:34, K. Gadd wrote: Arguably if you wait for other vendors to expose VR before you do it, you'll end up having to implement a sub-standard proprietary API like you did with Web Audio. We had an alternative implementation + API ( https://wiki.mozilla.org/Audio_Data_API ). I

Re: Using rr to track down intermittent test failures

2014-04-15 Thread Gijs Kruitbosch
On 16/04/2014 00:05, Robert O'Callahan wrote: We just released rr 1.2 and I think this would be a good time for people to try to use it for one of the tasks it was designed for: debugging intermittent test failures. This is awesome! Three questions: 1) Is anyone working on something similar

Re: OMTC on Windows

2014-05-22 Thread Gijs Kruitbosch
Looking on from m.d.tree-management, on Fx-Team, the merge from this change caused a 40% CART regression, too, which wasn't listed in the original email. Was this unforeseeen, and if not, why was this considered acceptable? As gavin noted, considering how hard we fought for 2% improvements

Re: error running mochitest-browser

2014-05-26 Thread Gijs Kruitbosch
On 22/05/2014 14:56, thills wrote: Hi Gijs: Thanks for your response. Please see inline. On 5/22/14, 9:46 AM, Gijs Kruitbosch wrote: Some questions: What platform is this on? This is on Mac OSX Mavericks How are you invoking the test suite? I'm doing a sudo ./mach mochitest-browser from

Re: error running mochitest-browser

2014-05-29 Thread Gijs Kruitbosch
concerning to me as a newbie as I want to make sure I've got all the proper tests chosen. Thanks, -tamara On 5/26/14, 8:44 AM, Gijs Kruitbosch wrote: On 22/05/2014 14:56, thills wrote: Hi Gijs: Thanks for your response. Please see inline. On 5/22/14, 9:46 AM, Gijs Kruitbosch wrote: Some questions

Re: OMTC on Windows

2014-06-02 Thread Gijs Kruitbosch
On 30/05/2014 16:16, andreas@gmail.com wrote: Please read my email again. This kind of animation cannot be rendered with high FPS by any engine. This doesn't make sense. Avih posted numbers sans-OMTC, and the same machine he used that doesn't manage to get 60fps with OMTC gets almost

Re: Update on sheriff-assisted checkin-needed bugs

2014-06-02 Thread Gijs Kruitbosch
Playing devil's advocate for a bit - are there more non-checkin-needed backouts? That is, people who, err, feel it is unnecessary to push to try to land something with checkin-needed, and therefore then land it themselves and burn the tree? :-) And also: has the throughput in checkin-needed

Re: Standardized assertion methods

2014-06-02 Thread Gijs Kruitbosch
Warning: pet peeve coming up. I agree we should separate these things more clearly. I don't think making people type the same 7 characters repeatedly is a good way to do that. I think we should be more liberal with using blank lines instead. It's too often I see 30-line blocks of code with

Re: Standardized assertion methods

2014-06-03 Thread Gijs Kruitbosch
On 03/06/2014 12:27, Mike de Boer wrote: snip 5. Assertion semantics are indeed poorly specified, across the board. Our switch from `do_check_matches()` to `deepEqual()` even revealed a buggy implementation there, which we didn’t know about. Apart from that, it was largely undocumented, not

Re: Standardized assertion methods

2014-06-03 Thread Gijs Kruitbosch
of our test framework(s) seem eminently on-topic for m.d.platform. ~ Gijs On 03/06/2014 14:45, Mike de Boer wrote: I understand all that and I *think* you missed the header mentioning I was going off-topic… Mike. On 03 Jun 2014, at 15:39, Gijs Kruitbosch gijskruitbo...@gmail.com wrote: On 03

Re: Future improvements to Javascript unit-test runners

2014-06-03 Thread Gijs Kruitbosch
On 03/06/2014 15:35, Mike de Boer wrote: I started to summarise the things I’d like to see in a JS unit test runner here[1]: * mini-core. * Async support as a base. We’ve added `add_task()` methods where possible, but we haven’t made it a core feature of the legacy suites in use today.

Re: bugzilla can now show bugs that have been updated since you last visited them

2014-06-04 Thread Gijs Kruitbosch
On 04/06/2014 07:34, Byron Jones wrote: thanks to dylan's work on bug 489028, bugzilla now tracks when you view a bug, allowing you to search for bugs which have been updated since you last visited them. see my blog post for more details: http://wp.me/p1JUqW-9M Hrm. But this includes trivial

Re: bugzilla can now show bugs that have been updated since you last visited them

2014-06-05 Thread Gijs Kruitbosch
On 05/06/2014 15:56, Ehsan Akhgari wrote: On Wed, Jun 4, 2014 at 12:43 PM, Gijs Kruitbosch gijskruitbo...@gmail.com wrote: On 04/06/2014 07:34, Byron Jones wrote: thanks to dylan's work on bug 489028, bugzilla now tracks when you view a bug, allowing you to search for bugs which have been

Re: Standardized assertion methods

2014-06-06 Thread Gijs Kruitbosch
On 06/06/2014 10:29, James Graham wrote: On 05/06/14 10:38, Mike de Boer wrote: As I tried to explain, the CommonJS API naively made sense to me at the time. To others as well, because we’re happily using it. As I now understand, some of us are very attached to a specific, different, API.

Re: Standardized assertion methods

2014-06-06 Thread Gijs Kruitbosch
On 06/06/2014 11:56, James Graham wrote: On 06/06/14 11:41, Gijs Kruitbosch wrote: On 06/06/2014 10:29, James Graham wrote: On 05/06/14 10:38, Mike de Boer wrote: As I tried to explain, the CommonJS API naively made sense to me at the time. To others as well, because we’re happily using

Re: Standardized assertion methods

2014-06-06 Thread Gijs Kruitbosch
On 06/06/2014 15:26, Boris Zbarsky wrote: On 6/6/14, 7:12 AM, Gijs Kruitbosch wrote: No, I think that in 99.99% of cases, I don't care about the type, and therefore I would normally use is() and not care that it's using non-strict equality. I think the case where there is (a) a possibility

Re: Standardized assertion methods

2014-06-07 Thread Gijs Kruitbosch
On 07/06/2014 03:40, Ehsan Akhgari wrote: On 2014-06-06, 4:11 PM, Boris Zbarsky wrote: On 6/6/14, 3:19 PM, Ehsan Akhgari wrote: Can we make is() do those checks explicitly and if neither of these cases apply, fall back to a non-strict equality check? Yes. As in, we could make it

Re: Is it time for mochitest-chrome on Android and B2G

2014-06-20 Thread Gijs Kruitbosch
Yeah, this caught me out yesterday. xpcshell tests on Android have, for instance, a pre-existing default search engine, whereas xpcshell tests running on desktop do not. It would be nice if this were documented on MDN. ~ Gijs On 20/06/2014 02:24, Mark Finkle wrote: Fennec/Android does have

Re: Improving our flow of new bugs

2014-07-02 Thread Gijs Kruitbosch
(I meant to loop in m.d.platform originally, but the message seems to have gotten lost in the void) On 01/07/2014 20:14, Gijs Kruitbosch wrote: (Followup/reply-to: m.tools.bmo / tools-bmo@lists.m.o) For a little over half a year now, I've been following new bugs filed in Firefox::Untriaged

Re: Where is the document for jar.mn file format

2014-07-02 Thread Gijs Kruitbosch
On 02/07/2014 17:46, Joshua Cranmer  wrote: On 7/2/2014 11:18 AM, Gregory Szorc wrote: I find the current state extremely frustrating. I had big plans for the in-tree docs, including capturing JavaScript docs and having JSM APIs automatically published to MDN so we don't have to write docs

Re: Misunderstood the Assigned at bugs! Sorry !!!

2014-07-09 Thread Gijs Kruitbosch
On 09/07/2014 16:00, Tobias B. Besemer wrote: Am Mittwoch, 9. Juli 2014 03:51:32 UTC+2 schrieb Tobias B. Besemer: I tried to help and clean up a bit Bugzilla with updating the Target Milestone to a Milestone that get still developed ... I did this:

Re: Misunderstood the Assigned at bugs! Sorry !!!

2014-07-09 Thread Gijs Kruitbosch
), then why do we still have it? If it isn’t equivalent, then we may be losing some information if we reset it back to New. -- - Milan On Jul 9, 2014, at 11:27 , Daniel Holbert dholb...@mozilla.com wrote: On 07/09/2014 08:16 AM, Gijs Kruitbosch wrote: On 09/07/2014 16:00, Tobias B. Besemer wrote

Re: How does xpcshell unittest are runned

2014-07-11 Thread Gijs Kruitbosch
This is the case on opt builds, but at least on tbpl, debug builds of xpcshell dump error information about why a file failed to load/run, e.g. https://tbpl.mozilla.org/php/getParsedLog.php?id=43053178tree=Mozilla-Esr24 ~ Gijs On 11/07/2014 09:12, Mike de Boer wrote: Error code 3, for me,

Re: Non-backward compatible changes to JS 'let' semantics

2014-08-15 Thread Gijs Kruitbosch
On 15/08/2014 07:17, Jeff Walden wrote: I think our best bet is probably to evangelize the change hard, update AMO linters to flag the issue, and (gulp) wait for, and assist wherever possible, addon authors to update their code. Part #1, shouldn't be too bad because they're syntax errors easily

Re: Switching to Visual Studio 2013

2014-08-22 Thread Gijs Kruitbosch
On 22/08/2014 15:55, Benjamin Smedberg wrote: On 8/22/2014 5:04 AM, xunxun wrote: And we should use VC2013 update2 or newer edition, whose PGO is faster than WPO. Yes, we had to wait for update 2 for fixes that would allow Firefox PGO builds to complete at all (there were previously internal

Re: xul browser / iframe tag not showing any content

2014-10-04 Thread Gijs Kruitbosch
On 04/10/2014 13:50, Heinrich Boers wrote: e.g.: browser type=content src=localhost flex=1 Have you tried making src an actual valid URI (e.g. http://localhost/ ) ? Gijs ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: WARNING: bugzilla review granted emails no longer contain review comments

2014-10-15 Thread Gijs Kruitbosch
On 14/10/2014 21:53, L. David Baron wrote: There is a regression in bugzilla.mozilla.org such that review granted, feedback granted, etc., emails no longer contain the comments made when granting the review. This bug is tracked in: https://bugzilla.mozilla.org/show_bug.cgi?id=1082887 Until

Re: Moratorium on new XUL features

2014-10-17 Thread Gijs Kruitbosch
On 16/10/2014 13:56, Robert O'Callahan wrote: On Fri, Oct 17, 2014 at 9:45 AM, Gijs Kruitbosch gijskruitbo...@gmail.com wrote: There are also interesting height computation issues that I'm pretty sure HTML (flexbox) doesn't have, e.g. bug 451997. I'm not sure that's a function of the box model

Re: Switching to Visual Studio 2013

2014-10-20 Thread Gijs Kruitbosch
Hi, Can you or someone else in the know update https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Windows_Prerequisites and friends, or (if you don't like wiki software, don't want to create an account, or have other reasons not to want to do this...) provide

Re: Switching to Visual Studio 2013

2014-10-20 Thread Gijs Kruitbosch
On 20/10/2014 16:56, Ehsan Akhgari wrote: On 2014-10-20 11:44 AM, Gijs Kruitbosch wrote: Hi, Can you or someone else in the know update https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Windows_Prerequisites and friends, or (if you don't like wiki software, don't

Re: Win64 builds tests coming soon!

2014-10-21 Thread Gijs Kruitbosch
On 21/10/2014 21:00, Chris AtLee wrote: Hi, Just a quick note that we're hoping to enable 64-bit windows builds tests across most trunk branches this week. This includes branches such as mozilla-central, mozilla-inbound, fx-team, etc. In order to get adequate test coverage without at the same

Re: MozReview ready for general use

2014-11-06 Thread Gijs Kruitbosch
All of hg.m.o is currently 503 https://bugzilla.mozilla.org/show_bug.cgi?id=1094922 ~ Gijs On 06/11/2014 16:58, Benoit Girard wrote: Cool. I'm eager to try this out. Sadly https://hg.mozilla.org/hgcustom/version-control-tools is giving me a 503 error at this time. On Wed, Nov 5, 2014 at

Re: e10s is now enabled by default for Nightly!

2014-11-07 Thread Gijs Kruitbosch
Where can we read about how this decision was made? On my profiles with Force RTL, e10s perma-crashes ( https://bugzilla.mozilla.org/show_bug.cgi?id=1072980 ), and in most other cases, I only ever see spinners for remote content (ie can't actually browse the web - doesn't matter too much for

Re: e10s is now enabled by default for Nightly!

2014-11-07 Thread Gijs Kruitbosch
On 07/11/2014 10:12, Marco Bonardo wrote: On 07/11/2014 10:40, Gijs Kruitbosch wrote: Where can we read about how this decision was made? On my profiles with Force RTL, e10s perma-crashes ( https://bugzilla.mozilla.org/show_bug.cgi?id=1072980 ), and in most other cases, I only ever see spinners

Re: e10s is now enabled by default for Nightly!

2014-11-07 Thread Gijs Kruitbosch
On 07/11/2014 16:26, Dave Townsend wrote: wrote: Where can we read about how this decision was made? On my profiles with Force RTL, e10s perma-crashes ( https://bugzilla.mozilla.org/ show_bug.cgi?id=1072980 ), and in most other cases, I only ever see spinners for remote content (ie can't

Re: e10s is now enabled by default for Nightly!

2014-11-07 Thread Gijs Kruitbosch
Are we currently planning to let this default ride into aurora in 2 weeks' time? ~ Gijs On 07/11/2014 21:44, Gavin Sharp wrote: Yes, it is currently disabled by safe mode. There is currently a checkbox in prefs to toggle it, in Nightly builds. When it rides the trains, we'll have to

Re: MozReview ready for general use

2014-11-10 Thread Gijs Kruitbosch
It looks like all reviews (and patches) are currently public. Is there some way to have them not be so, for security/confidential bugs/reviews? ~ Gijs On 06/11/2014 04:50, Mark Côté wrote: A couple months ago I gave a sneak peak into our new repository-based code-review tool based on Review

Re: Test coverage?

2014-11-25 Thread Gijs Kruitbosch
On 25/11/2014 10:40, Kan-Ru Chen (陳侃如) wrote: Hi, Currently we have many tests that are skipped for various reasons. Do we have data on which test runs on which platforms? For example if a test is accidentally skipped on all platforms, could we identify it? Kanru A tool called Test

Re: after NPAPI ?

2014-11-25 Thread Gijs Kruitbosch
On 25/11/2014 14:22, rayna...@gmail.com wrote: I need to get the audio sample data and do some math on it, then play it in the speaker, with the minimum of latency (arround 20ms). Only the wasapi driver could allow this. Have you actually tried using getusermedia/web audio for this? Or are

Re: Bug 639134 changed boolean browser.display.use_document_colors to tristate browser.display.document_color_use

2014-12-06 Thread Gijs Kruitbosch
(replying to m.d.platform, but also pulling some folks into the CC list) Hi Philip, Thanks for raising this. On 05/12/2014 23:13, Philip Chee wrote: I think the changes for this bug are sub-optimal. First: https://hg.mozilla.org/mozilla-central/rev/460d573b8822#l3.17 +!ENTITY

Wish list for tools to help fix intermittent bugs

2014-12-08 Thread Gijs Kruitbosch
Because I've been working on a few of them and here's what I think would make them a lot easier to fix, and therefore improve our test coverage and make sheriffs much happier 1) make it easier to figure out from bugzilla/treeherder when and where the failure first occurred - I don't want to

Re: Bug 639134 changed boolean browser.display.use_document_colors to tristate browser.display.document_color_use

2014-12-08 Thread Gijs Kruitbosch
On 07/12/2014 05:11, Philip Chee wrote: People using high contrast themes in windows would know what high contrast themes are since they have to select those themes from the High Contrast Themes section. So you're suggesting... ? (fwiw, *I* have no idea what beware of leopard means) That

Re: PSA: Flaky timeouts in mochitest-plain now fail newly added tests

2014-12-19 Thread Gijs Kruitbosch
On 19/12/2014 14:56, Ehsan Akhgari wrote: Logging sufficiently is almost always enough to not have to use these timers, as those tests have demonstrated in practice. Who's working on improving the log output from tinderbox? Timestamps get mashed [0], sometimes only the failing assertion is

Re: Is anyone still using JS strict warnings?

2014-12-19 Thread Gijs Kruitbosch
On 19/12/2014 20:45, William McCloskey wrote: I was the person in the previous thread who found them useful, and I still do. Some of the extraWarnings stuff is of questionable value, but the undefined property stuff is really useful. Can you give an example of a useful undefined property

Re: Test Informant Report - Week ending Dec 28

2015-01-26 Thread Gijs Kruitbosch
I was looking at these now... it looks like the mochitest-bc-e10s count went up from 48% in the week ending Dec. 12 to 57% in the week ending Dec. 28. Yet this report records no change since the previous run. What gives? :-) ~ Gijs On 29/12/2014 15:50, Test Informant wrote: Test Informant

Re: HTTP/2 and User-Agent strings?

2015-01-27 Thread Gijs Kruitbosch
On 27/01/2015 21:31, Chris Peterson wrote: On 1/27/15 9:29 AM, Jonas Sicking wrote: We keep telling websites to not use the UA string, however we've so far been very bad at asking them why they use the UA string and then create better alternatives for them. Essentially many websites need to do

Re: HTTP/2 and User-Agent strings?

2015-01-28 Thread Gijs Kruitbosch
On 28/01/2015 15:25, Gervase Markham wrote: On 27/01/15 09:16, Chris Peterson wrote: btw, here is the spartan User-Agent string for Microsoft's new Spartan browser: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.71 Safari/537.36 Edge/12.0 Really?

Re: Is anyone still using JS strict warnings?

2015-01-05 Thread Gijs Kruitbosch
On 29/12/2014 13:48, Paolo Amadini wrote: On 12/26/2014 5:59 PM, Jeff Walden wrote: On 12/22/2014 08:08 AM, Paolo Amadini wrote: Maybe we could make available an opt-in code linting solution - and these typos would become errors, not warnings, Introducing our own proprietary version of JS

Re: Intent to deprecate: persistent permissions over HTTP

2015-03-06 Thread Gijs Kruitbosch
On 06/03/2015 17:27, Anne van Kesteren wrote: A large number of permissions we currently allow users to store persistently for a given origin. I suggest we stop offering that functionality when there's no lock in the address bar. Can we make an exception for localhost and its IPv4 and IPv6

Re: What are your pain points when running unittests?

2015-03-12 Thread Gijs Kruitbosch
IME the issue is not so much about not running tests identical to the ones on CI, but the OS environment which doesn't match, and then reproducing intermittent failures. If a failure happens once in 100 builds, it is very annoying for the sheriffs (happens multiple times a day) and needs

Further improving what builds get triggered on what changesets

2015-02-21 Thread Gijs Kruitbosch
Hi, I've been noticing that the number of builds + tests we run on certain changesets could still do with improving. I realize that we try to be conservative because we don't want magically appearing orange, but I still think that it should be possible to do better here. That seems like it

Re: Excessive inbound bustage

2015-04-22 Thread Gijs Kruitbosch
On 22/04/2015 01:26, Mike Hommey wrote: Here are a few crude stats, gathered over the last 25271 changesets, assuming my pattern matching worked properly: - 1438 changesets were backed out (~5.7%) Thank you for some stats, which is clearly better than no stats at all! (Like everyone else who

Re: (mozci) Triggering jobs on treeherder

2015-04-24 Thread Gijs Kruitbosch
Are you going to build a web UI for this so I don't need to check out a repo and run a python script with syntax that I'll likely need to look up every time I want to do it, guessing builder names that I don't know? (don't get me wrong, I could probably use it if I needed to, but it's harder

Re: Survey on code review quality

2015-04-29 Thread Gijs Kruitbosch
Can you link to the previous study? ~ Gijs On 29/04/2015 17:59, olgabay...@gmail.com wrote: (Sorry for cross-posting) Dear Mozilla developer, We, researchers from the University of Waterloo and Universite de Montreal, Canada (some of you might remember our names from the previous study),

Re: PSA: Minor changes to mochitest harness and mach command arguments

2015-05-06 Thread Gijs Kruitbosch
On 06/05/2015 14:33, Andrew Halberstadt wrote: 2) --close-when-done is now the default, so this option has been removed. Use --keep-open to turn it off. It was a pain to get this right for people's expectations when I messed with this - mochitest-browser and mochitest-plain behave

Re: PSA: Minor changes to mochitest harness and mach command arguments

2015-05-06 Thread Gijs Kruitbosch
On 06/05/2015 15:14, Andrew Halberstadt wrote: Yeah, you shouldn't notice any difference when running from mach. The only change is that the harness is handling defaults instead of the mach command, and that they now both have the same command line. I think what you are thinking of is when you

Changing the style guide's preference for loose over strict equality checks in non-test code (was: Re: PSA: The mochitest ise() function is dead, please use is() instead)

2015-05-14 Thread Gijs Kruitbosch
On 14/05/2015 01:21, Martin Thomson wrote: On Wed, May 13, 2015 at 4:54 PM, Matthew N. mattn+firefox-...@mozilla.com wrote: In JavaScript, == is preferred to ===. from https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Operators Ahh, that's where it was hiding.

Re: Changing the style guide's preference for loose over strict equality checks in non-test code

2015-05-14 Thread Gijs Kruitbosch
On 14/05/2015 18:12, Martin Thomson wrote: On Thu, May 14, 2015 at 9:40 AM, Gijs Kruitbosch gijskruitbo...@gmail.com wrote: Crockford offers plenty of reasons in his book. I've not read Crockford's book and have no plans to, but there are plenty of reasons against, too. :-) Do you want me

Re: Changing the style guide's preference for loose over strict equality checks in non-test code

2015-05-14 Thread Gijs Kruitbosch
On 14/05/2015 17:14, Martin Thomson wrote: On Thu, May 14, 2015 at 5:17 AM, Gijs Kruitbosch gijskruitbo...@gmail.com wrote: On 14/05/2015 01:21, Martin Thomson wrote: On Wed, May 13, 2015 at 4:54 PM, Matthew N. mattn+firefox-...@mozilla.com wrote: In JavaScript, == is preferred to ===. from

Re: Changing the style guide's preference for loose over strict equality checks in non-test code

2015-05-14 Thread Gijs Kruitbosch
On 14/05/2015 19:08, Martin Thomson wrote: On Thu, May 14, 2015 at 10:35 AM, Gijs Kruitbosch gijskruitbo...@gmail.com wrote: I mean, obviously the example is simplified. You seem to think that === means I'm sure this will be the right type. In the same way you imply that == indicates

Re: Changing the style guide's preference for loose over strict equality checks in non-test code

2015-05-14 Thread Gijs Kruitbosch
On 14/05/2015 23:15, Adam Roach wrote: On 5/14/15 16:33, Gijs Kruitbosch wrote: Can you give a concrete example where you had to change a contributor's patch in frontend gaia code to prefer === to prevent real bugs? From what I've seen, it's typically a matter of making the results

Re: Changing the style guide's preference for loose over strict equality checks in non-test code

2015-05-14 Thread Gijs Kruitbosch
On 14/05/2015 21:45, Andrew Sutherland wrote: On 05/14/2015 04:22 PM, Gijs Kruitbosch wrote: == is not any less explicit than ===. Both versions have an exact, specified meaning. They both have exact meanings. But people, especially new contributors new to JS, frequently use == without

Re: Changing the style guide's preference for loose over strict equality checks in non-test code

2015-05-14 Thread Gijs Kruitbosch
On 14/05/2015 22:55, Eric Rescorla wrote: On Thu, May 14, 2015 at 1:22 PM, Gijs Kruitbosch gijskruitbo...@gmail.com mailto:gijskruitbo...@gmail.com wrote: Maybe there is a difference with firefox browser JS and platform JS here (on which you seem to be working), in terms of which

Re: New Developer Tools Feature: prettifying JSON

2015-04-16 Thread Gijs Kruitbosch
On 16/04/2015 09:37, Jan Odvarko wrote: If not, can you take the same approach here? We are obviously trying to avoid C++ code in devtools, but also XUL/XBL in favor of pure JS/HTML/CSS stack. Not sure if there is yet another way how to manipulate content with a script that is living outside

Re: New Developer Tools Feature: prettifying JSON

2015-04-16 Thread Gijs Kruitbosch
On 16/04/2015 15:30, Boris Zbarsky wrote: On 4/16/15 4:52 AM, Gijs Kruitbosch wrote: but that would still require that application/json loads as text in the browser, which I think it currently doesn't? Totally does ever since https://bugzilla.mozilla.org/show_bug.cgi?id=667533 (so about 3.5

Re: The e10s throbber

2015-04-08 Thread Gijs Kruitbosch
On 07/04/2015 23:41, Robert O'Callahan wrote: On Wed, Apr 8, 2015 at 6:27 AM, Gavin Sharp ga...@gavinsharp.com wrote: We don't have telemetry yet. I've done some measurements and haven't found any cases where tab switching consistently takes longer in e10s. However, it's certainly possible

Re: nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT and add-on chrome

2015-06-09 Thread Gijs Kruitbosch
On 09/06/2015 13:12, Neil wrote: Boris Zbarsky wrote: That said, it's pretty weird to me that we're exposing the entirety of chrome://browser like that. Seems like we should scope it down. You could move the relevant files (presumably the CSS for those about: pages) into a different

Re: Modifying Element.prototype for all globals

2015-06-18 Thread Gijs Kruitbosch
I'm sure this is a dumb question, but why not modify the actual implementation of innerHTML in the core DOM if you're doing a modified try-run anyway? ~ Gijs On 18/06/2015 13:37, Frederik Braun wrote: Hi, I am planning to do a little analysis of FxOS Gaia to identify instances of innerHTML

Re: openDialog(DOM, ..)

2015-07-06 Thread Gijs Kruitbosch
On 06/07/2015 17:08, Marcello Stanisci wrote: Alternatively, create an empty dialog and manipulate the dialog using DOM based on the arguments you pass using window.open[Dialog](...). This is What do you mean by 'empty dialog'? Is it a a. xul skeleton file This. ~ Gijs

Re: openDialog(DOM, ..)

2015-07-06 Thread Gijs Kruitbosch
Use a data: URL, or failing that, define your own protocol handler and use that to return the XUL DOM you want, when used with openDialog. Alternatively, create an empty dialog and manipulate the dialog using DOM based on the arguments you pass using window.open[Dialog](...). This is probably

Re: I think XUL overlays should also ignore query strings.

2015-08-17 Thread Gijs Kruitbosch
As others have said, XUL is going away. It is not going away tomorrow. We should be careful about if and how we invest here, so usecases are important. On 15/08/2015 20:48, Philip Chee wrote: Use case 1: chrome://foo/content/bar.xul?a=bc=d This could be written as

Re: NPAPI plugin use case: native chipcard reader

2015-10-12 Thread Gijs Kruitbosch
Are you effectively saying that you use crypto for signing financial transactions, and the PIN is used for authenticating the user but not involved in the actual signature/crypto algorithm? Therefore, if a user finds a way to invoke the same crypto without providing the PIN, they can effect

Re: |hg bzexport| and Bugzilla two-factor authentication

2015-09-16 Thread Gijs Kruitbosch
On Windows I still get "No module named Cookie!" after using ./mach mercurial-setup to update vcs-tools. ~ Gijs On 15/09/2015 22:52, Jeff Walden wrote: The Mercurial extensions to interact with Bugzilla -- bzexport and the like -- have been updated to handle 2fa details. No need to add API

Re: |hg bzexport| and Bugzilla two-factor authentication

2015-09-16 Thread Gijs Kruitbosch
. Things have or will break unless running MozillaBuild 2.0. Please file a Developer Services product bug with the command output with --traceback added to the args so we can track failing more gracefully. On Sep 16, 2015, at 05:02, Gijs Kruitbosch <gijskruitbo...@gmail.com> wrote: On Win

  1   2   3   >