Re: Changes to JS components/JSMs

2012-10-30 Thread Kartikaya Gupta
On 12-10-30 16:31 , Dave Townsend wrote: In case people missed this part specifically, I just want to point out that the change in bug 798491 are targeted for FF18 (Aurora). See comment 75 for philikon's early risk evaluation. From our read of the bug, although this represents major code change,

Re: Scrolling, Scrolling and more Scrolling

2013-01-29 Thread Kartikaya Gupta
I agree, we should try to unify all of this code. A related (but possibly deferrable) problem is to unify all of the gesture detection. I can help you with the Java code in Fennec, in terms of understanding what it does and helping replace it with the B2G fork. This has been on my to-do list

Re: Proposal for using a multi-headed tree instead of inbound

2013-04-04 Thread Kartikaya Gupta
On 13-04-03 23:05 , Jesse Ruderman wrote: I suggest adding an Auto branch between Try and Central. Advantages: [snip] * In Scenario D (when subtle patch interactions cause build or test failures), automation can move on to another set of Try landings, giving sheriffs time react without the

Re: Proposal for using a multi-headed tree instead of inbound

2013-04-04 Thread Kartikaya Gupta
On 13-04-03 19:49 , Jesse Ruderman wrote: +1. But can we do this with rebased changesets instead of trivial merge changesets? While the core of hg can handle merges, pretty much none of the tools we rely on for understanding history (hg {log, grep, diff, bisect}) handle them well. Thinking

Proposal for using a multi-headed tree instead of inbound (updated)

2013-04-05 Thread Kartikaya Gupta
Sorry for starting a new thread, but I screwed up the previous thread by mashing together my replies to unrelated messages in a single message. If you didn't read all the messages in all sub-threads you may have missed my response. Most of my responses were in this message:

Re: Some data on mozilla-inbound

2013-04-23 Thread Kartikaya Gupta
On 13-04-23 11:41 , Chris AtLee wrote: We've considered enforcing this using some cryptographic token. After you push to try and get good results, the system gives you a token you need to include in your commit to m-i. ... or you could just merge the cset directly from try to m-i or m-c.

Re: Some data on mozilla-inbound

2013-04-23 Thread Kartikaya Gupta
On 13-04-23 00:39 , Ehsan Akhgari wrote: How hard would it be to gather a list of the total number of patches being backed out plus the amount of time that we spent building/testing those, hopefully in a style similar to http://people.mozilla.org/~catlee/highscores/highscores.html? Not

Re: Some data on mozilla-inbound

2013-04-23 Thread Kartikaya Gupta
On 13-04-23 03:57 , Axel Hecht wrote: Do we know how many of these have been pushed to try, and passed/compiled what they'd fail later? I haven't looked at this. It would be useful to know but short of pulling patches and using some similarity heuristic or manually examining patches I can't

Re: Some data on mozilla-inbound

2013-04-23 Thread Kartikaya Gupta
On 13-04-23 19:21 , Nicholas Nethercote wrote: - The 'inbound was closed for 15.3068% of the total time due to bustage' number is an underestimate, in one sense. When inbound is closed at 10am California time, it's a lot more inconvenient to developers than when it's busted at midnight

Reviewer checklist

2013-07-10 Thread Kartikaya Gupta
Some of us over in #mobile brainstormed a list of things that reviewers (and patch-writers) should check for in patches. The idea is to have a handy list of these things that often get forgotten, overlooked, or otherwise slip through. I have put up our list on the MDN wiki at [1] - please feel

Tegra build backlog is too big!

2013-09-11 Thread Kartikaya Gupta
Earlier today the backlog on Android build jobs was on the order of 1300. It seems to be coming down a little now but for a while there I was worried it was going to grow unboundedly. Try jobs from over 10 hours ago still have pending jobs - as I'm sure you all know, having a 10-hour

Re: Tegra build backlog is too big!

2013-09-12 Thread Kartikaya Gupta
2:31 PM, Kartikaya Gupta wrote: Earlier today the backlog on Android build jobs was on the order of 1300. It seems to be coming down a little now but for a while there I was worried it was going to grow unboundedly. Try jobs from over 10 hours ago still have pending jobs - as I'm sure you all know

Re: Central location for tracking known broken build configurations (with bugs)

2013-11-20 Thread Kartikaya Gupta
I would favour a whiteboard tag or keyword on the bug tracking the build failure. It should be easy enough to create a query for all open bugs with this tag. Usually you want to get to the bug anyway for the latest workaround and/or info on what to back out locally. Cheers, kats On 13-11-19

Target Milestone field in bugzilla

2014-01-09 Thread Kartikaya Gupta
I think the Target Milestone field is poorly named, at least with respect to what we use it for. In practice this field is set to the version of m-c on which the patches originally landed, and doesn't change when patches are uplifted to other branches. However, I've seen many people mistake

Re: Target Milestone field in bugzilla

2014-01-14 Thread Kartikaya Gupta
That sounds pretty reasonable to me. Cheers, kats On 14-01-14 10:59 , dklaw...@gmail.com wrote: After some discussion with other BMO devs, how about this proposal? We add a (info) link next to the Milestone label on the show_bug.cgi page that has some custom documentation explaining the

Non-technical comments in Bugzilla

2014-02-13 Thread Kartikaya Gupta
Hi all, Recently I've noted a significant increase in the number of bug comments that are meta-information and not particularly relevant to the bug itself. Often these comments are product/planning people moving the bug around asking for attention on it (this particularly happens in B2G-land

Re: Recommendations on source control and code review

2014-04-12 Thread Kartikaya Gupta
Just a reminder that this page exists: https://developer.mozilla.org/en-US/docs/Developer_Guide/Reviewer_Checklist and you should feel free to add things to it, and use it when reviewing any code (your own or other people's). kats On 11/4/2014, 17:47, Mike Conley wrote: Whoa, didn't expect

Re: Follow up on clang-format

2014-05-23 Thread Kartikaya Gupta
I tried using clang-format on entire files and I noticed two things (there might be others, I didn't look too closely): 1) When it reformats comments to fit in the line length, it just inserts linebreaks rather than rewrapping the text. So you end up with text like this, where the last couple

Re: Intent to implement: CSSOM-View scroll-behavior property

2014-05-23 Thread Kartikaya Gupta
On 23/5/2014, 6:12, Jonas Sicking wrote: Basically we need an API like div.addToScrollPosition(hightOfNewContent); This would allow the browser to send this delta to the compositing thread along with the newly updated painting of the DOM. This is certainly a valid use case, and it has come

Re: PSA: ./mach build subdirectory doesn't work reliably any longer

2014-08-25 Thread Kartikaya Gupta
On 25/8/2014, 14:16, Aryeh Gregor wrote: FWIW, I've often made changes like this when touching files like nsCOMPtr.h or nsINode.h -- or switching nsresult from a typedef to an enum class! -- and I find just doing ./mach build binaries works fine. It reports errors randomly from all over the

Re: Intent to ship: CSSOM-View Scroll-Behavior CSS Property and CSSOM-View DOM Extensions for Smooth Scrolling

2014-10-31 Thread Kartikaya Gupta
On 30/10/2014, 19:02, Jonas Sicking wrote: Couldn't we simply change the defined behavior of element.scrollBy({ top: 50, behavior: smooth }) such that it sends the delta coordinates to the composition thread, and adds the current scroll position there instead of on the main thread? FYI we

Re: Revisions to the Job Visibility Policy

2015-07-06 Thread Kartikaya Gupta
Looks good to me! On Mon, Jul 6, 2015 at 10:52 AM, Ryan VanderMeulen rvandermeu...@mozilla.com wrote: For a little over 2 years, our Job Visibility Policy has been in place to identify all the requirements necessary for a build or test suite to be visible in our infrastructure.

Re: Proposal: Turning off Eideticker perf testing

2015-08-17 Thread Kartikaya Gupta
FWIW one of the original driver behind Eideticker (tuning Fennec for checkerboarding during scrolling) will become relevant again in the next couple of months as we transition Fennec to using the C++ APZ code and off the old Java pan/zoom code. While it would be nice to have Eideticker around to

Re: Decreasing quality?

2015-08-20 Thread Kartikaya Gupta
There are some bugs about this (1189565 and 1193933 are the ones I'm aware of), but please do file bugs if you haven't already and if your symptoms don't match the existing bugs. kats On Thu, Aug 20, 2015 at 2:52 PM, Dirkjan Ochtman dirk...@ochtman.nl wrote: On Thu, Aug 20, 2015 at 8:45 PM,

Re: layers.async-pan-zoom.enabled amazing performance increase

2015-07-30 Thread Kartikaya Gupta
The OP filed bug 1189237 for this issue, but it seems like it was reported on Firefox 39 where we don't support async-pan-zoom. If you can reproduce this issue in a Nightly build please file a new bug. Thanks, kats On Thu, Jul 30, 2015 at 5:32 PM, Andreas Tolfsen a...@mozilla.com wrote: On Thu,

Re: New policy: 48-hour backouts for major Talos regressions

2015-08-14 Thread Kartikaya Gupta
In general I'm in favour of this proposal, although it will probably come back to haunt me in the not-too-distant future. That being said I would like to know what criteria you used to distinguish reliable talos tests from the rest. kats On Fri, Aug 14, 2015 at 5:26 PM, Vladan Djeric

PSA: Enabling APZ on nightly desktop (OS X, Windows)

2015-07-21 Thread Kartikaya Gupta
Just a heads-up that I just pushed bug 1157746 to inbound, which enables async scrolling for trackpad/wheel scrolling by default for nightly OS X desktop builds. It requires e10s, and so if you have e10s disabled it has no effect for you. If you have e10s enabled, you should see smoother/more

PSA: New reftest analyzer keyboard shortcuts

2015-07-24 Thread Kartikaya Gupta
Since keyboard shortcuts aren't very discoverable this is just a note to let you all know that in bug 1187025 I added some more keyboard shortcuts to the reftest analyzer. Previously '1' and '2' would switch between the test/reference images, and now 'd' will toggle the differences view and 'p'

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-14 Thread Kartikaya Gupta
On Tue, Jul 14, 2015 at 10:10 AM, Tom Tromey ttro...@mozilla.com wrote: That assumes that the 'Foo' of aFoo is stable across function boundaries, which is not always the case. Ehsan No, it doesn't. In the scenario above, all you're looking for is when Ehsan a value was computed, so you can

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-14 Thread Kartikaya Gupta
./xulrunner 0 On Tue, Jul 14, 2015 at 10:30 AM, L. David Baron dba...@dbaron.org wrote: On Tuesday 2015-07-14 10:27 -0400, Kartikaya Gupta wrote: Admittedly not perfect, but as a first-order approximation: kats@kgupta-air mozilla-git$ find . -name *.cpp | xargs grep ^ *a[A-Z]\w* = | wc -l

Re: Date, time, week, month and datetime attributes in the in Firefox

2015-11-01 Thread Kartikaya Gupta
IMO given the number of people who have complained about the lack of this feature on bug 825294, we should assume it is desirable to have even if unstylable. If somebody claims otherwise the burden of proof should be on them to show data that falsifies the assumption. kats On Sun, Nov 1, 2015 at

Re: Is APZ meant to be a permanent part of the platform?

2015-10-05 Thread Kartikaya Gupta
I think that as it stands, yes, APZ is going to be a "permanent" part of the platform. You're right that having higher-latency scroll events creates some problems and makes it harder to drive animations off it. We do have plans to provide more APIs for controlling things in the compositor which

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread Kartikaya Gupta
On Tue, Jul 7, 2015 at 3:33 PM, Jeff Gilbert jgilb...@mozilla.com wrote: On Tue, Jul 7, 2015 at 6:03 AM, Kartikaya Gupta kgu...@mozilla.com wrote: I'd be interested to know: of those people who are in favour of removing the prefix, how many regularly have to deal with functions

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread Kartikaya Gupta
I'd be interested to know: of those people who are in favour of removing the prefix, how many regularly have to deal with functions that are longer than two pages (a page is however much code you can see at a time in your coding environment)? I'd be happy to support removing the prefix if people

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread Kartikaya Gupta
On Tue, Jul 7, 2015 at 9:18 AM, Honza Bambas hbam...@mozilla.com wrote: I'd be happy to support removing the prefix if people also commit to splitting any giant functions they touch as part of the prefix removal. That's (sorry) non-sense. In almost all cases longer methods/functions cannot

Re: APZ enabled on Fennec nightly

2015-12-02 Thread Kartikaya Gupta
Thanks for trying it out and reporting these issues! I've filed them as separate bugs - bug 1229840, bug 1229839, and bug 1229841. We should be able to address 2 and 3 by tuning some prefs, 1 will take a bit more investigation. Cheers, kats On Wed, Dec 2, 2015 at 11:31 AM,

Re: SPS Profiles are now captured for entire subprocess lifetime

2015-12-03 Thread Kartikaya Gupta
\o/ Does this get us all the way to "profile talos runs with e10s enabled", or are there still pieces missing for that? IIRC this set of patches was a prerequisite for being able to do that. On Thu, Dec 3, 2015 at 4:52 PM, Mike Conley wrote: > Just a heads up that there

Re: APZ enabled on Fennec nightly

2015-12-01 Thread Kartikaya Gupta
will also unblock smooth scrolling and scroll snapping for > fennec. > > Cheers, > - Kearwood “Kip” Gilbert > >> On Nov 30, 2015, at 8:37 AM, Kartikaya Gupta <kgu...@mozilla.com> wrote: >> >> Hi all, >> >> Just a heads up that I landed th

Re: [webkit] More Responsive Tapping on iOS

2015-12-17 Thread Kartikaya Gupta
FWIW we support the fast-click on unzoomable pages and pages with width<=device-width in the meta-viewport tag. We don't support touch-action fully yet. Cheers, kats On Dec 16, 2015 9:55 PM, "Karl Dubost" wrote: > Just a heads up about WebKit changing behavior on a couple

Too many oranges!

2015-12-21 Thread Kartikaya Gupta
Is it just me, or has the number of intermittent oranges gone up quite a lot in the last couple of months? It seems like every try push I do has a lot of oranges which are completely unrelated to may patch. Clearly everbody has more urgent things to do than fix intermittent failures (myself

Re: Adding jobs to pushes having some issues

2015-12-23 Thread Kartikaya Gupta
For the record it seems like even if adding new jobs via TH fails, the old try-extender tool at http://try-extender.herokuapp.com/ still works (at least for try pushes). On Tue, Dec 22, 2015 at 2:56 PM, Armen Zambrano G. wrote: > Hello team, > Thanks for using the ability of

Re: about:profiles and the new profile manager

2015-12-18 Thread Kartikaya Gupta
Note that there are add-ons such as "Profile Switcher" which allow you to display the profile manager dialog without touching the command-line. I don't know if that qualifies as "user facing" or not. It's certainly an advanced user feature that most people will never see. kats On Fri, Dec 18,

Re: Too many oranges!

2015-12-22 Thread Kartikaya Gupta
On Mon, Dec 21, 2015 at 3:11 PM, L. David Baron wrote: > I agree it's definitely gone up recently, and agree that it causes a > lot of wasted time. I'm not convinced about closing the tree, > though; keeping the tree closed for extended periods just leads to > big backups. > >

Re: Too many oranges!

2015-12-22 Thread Kartikaya Gupta
aintenance is fixing oranges, closing out papercuts, >> refactoring, etc. >> >> On 21 December 2015 at 17:35, <jmath...@mozilla.com> wrote: >> >> > On Monday, December 21, 2015 at 1:16:13 PM UTC-6, Kartikaya Gupta wrote: >> > > So, I propose that w

Re: Too many oranges!

2015-12-22 Thread Kartikaya Gupta
On Tue, Dec 22, 2015 at 11:16 AM, Douglas Turner wrote: > Mike -- totally supportive of this. I would *love* to see a release cycle > completely dedicated to quality. We branch again on January 26. We could > use that cycle to focus on nothing but quality (fixing tests, bug

Re: Thanks for all the great teamwork with the Sheriffs in 2015!

2015-12-30 Thread Kartikaya Gupta
Yes, thank you to all the sheriffs for all their hard work! On Wed, Dec 30, 2015 at 9:19 AM, Carsten Book wrote: > Hi, > > Sheriffing is not just about Checkins, Uplifts and Backouts - its also a > lot of teamwork with different Groups and our Community like Developers, IT >

Re: Dan Stillman's concerns about Extension Signing

2015-11-28 Thread Kartikaya Gupta
So it seems to me that people are actually in general agreement about what the validator can and cannot do, but have different evaluations of the cost-benefit tradeoff. On the one hand we have the camp (let's say camp A) that believes the validator provides negligible actual benefit, because it

APZ enabled on Fennec nightly

2015-11-30 Thread Kartikaya Gupta
Hi all, Just a heads up that I landed the patch to enable APZ on Fennec (nightly channel only for now). It should be in the Dec 1 nightly and onwards. This will make scrolling around, and general touch input handling, feel different on Fennec. The main improvement should be that scrolling of

Re: Better mach support for Firefox for Android

2015-11-30 Thread Kartikaya Gupta
Thanks for all your work in making this happen! I've used some of these commands recently and they work much better than they used to for Fennec :) On Mon, Nov 30, 2015 at 12:32 PM, Geoffrey Brown wrote: > In recent months, many improvements have been made to mach commands to

Re: Dan Stillman's concerns about Extension Signing

2015-11-26 Thread Kartikaya Gupta
On Thu, Nov 26, 2015 at 8:50 AM, Thomas Zimmermann wrote: > For anything non-AMO, the user is on > their own. > I don't know if that would fly. As I understand it, a large part of the purpose of extension signing is to protect users from malicious add-ons that get

Re: The Whiteboard Tag Amnesty

2016-06-08 Thread Kartikaya Gupta
What happens after June 24? Is the whiteboard field going to be removed? On Wed, Jun 8, 2016 at 4:32 PM, Emma Humphries wrote: > tl;dr -- nominate whiteboard tags you want converted to keywords. Do it by > 24 June 2016. > > We have a love-hate relationship with the whiteboard

Re: All about crashes

2016-05-26 Thread Kartikaya Gupta
On Wed, May 25, 2016 at 9:45 PM, Nicholas Nethercote wrote: > On Wed, May 25, 2016 at 6:58 AM, Lawrence Mandel wrote: >> "Crashes are caused by defects" >> >> Reading this I think it implies defects in Firefox. This is not always the >> case. Crashes

Re: How badly out of date is this?

2016-06-01 Thread Kartikaya Gupta
Or make the warning a fixed-position item, so it's on-screen regardless of where on the page you are. On Wed, Jun 1, 2016 at 10:06 AM, Mike Hoye wrote: > On 2016-06-01 5:02 AM, L. David Baron wrote: >> >> >> So I tend to think it's worth keeping, but with a preface that >>

Re: Triage for Component Leads

2016-06-16 Thread Kartikaya Gupta
The wiki says everything from July 1 onwards should be triaged, but the triage-center tool produces bugzilla links from June 1 onwards (when you select the "no priority decision" link). Is this intentional, or just a mix-up? On Thu, Jun 16, 2016 at 5:17 PM, Emma Humphries

Re: Touch events enabled on Windows desktop (nightly only)

2016-02-01 Thread Kartikaya Gupta
bugs in this configuration, again, please file. If you want to force-enable e10s (and therefore APZ), you can set the browser.tabs.remote.force-enable pref to true. On Mon, Feb 1, 2016 at 12:46 PM, Kartikaya Gupta <kgu...@mozilla.com> wrote: > In bug 1180706

Re: Does SSE2 usage still need to be conditional?

2016-01-29 Thread Kartikaya Gupta
I also want to highlight the thing at the end of the gist linked above - the majority of the non-SSE2 population are on 43.0.4. That is, they're keeping up-to-date, and would likely be affected by this more than somebody stranded on an old version. On Fri, Jan 29, 2016 at 3:29 PM, Chris H-C

Re: Adding new jobs to pushes in better shape

2016-01-21 Thread Kartikaya Gupta
Thanks! I just used this on inbound and it seems to be working well. :) On Thu, Jan 21, 2016 at 9:26 AM, Armen Zambrano G. wrote: > I've spent the last two days fixing most issues affecting adding jobs on > Treeherder. > I believe it is now working properly. > You don't need

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-03-14 Thread Kartikaya Gupta
On Thu, Mar 10, 2016 at 5:45 PM, Anthony Jones wrote: > My understanding is that the reason people stick to 10.6 is because of > Rosetta[1] which offers PowerPC compatibility. I have a laptop on 10.6. The hardware can theoretically support newer OS X versions, and I've

Re: Coding style for C++ enums

2016-04-11 Thread Kartikaya Gupta
Based on all the feedback so far I think the best compromise is to use enum classes with the "e" prefix on the values. As was mentioned, the "e" prefix is useful to distinguish between enum values and function pointer passing at call sites, but is a small enough prefix that it shouldn't be too

Re: Triage Plan for Firefox Components

2016-04-08 Thread Kartikaya Gupta
On Fri, Apr 8, 2016 at 10:54 AM, Benjamin Smedberg wrote: > On Thu, Apr 7, 2016 at 2:50 AM, L. David Baron wrote: >> Why it's important >> What makes this problem important or urgent to fix? >> > > Yes! If this isn't clear, who owns this?

Coding style for C++ enums

2016-04-08 Thread Kartikaya Gupta
Is there a recommendation for what enum values in C++ code should be styled as? The coding style doesn't say and we use a variety of things in existing code, so I was wondering if we should settle on something for new enums being added to the code, and update the style guide accordingly. enum

Re: Coding style for C++ enums

2016-04-11 Thread Kartikaya Gupta
On Mon, Apr 11, 2016 at 1:46 PM, Seth Fowler wrote: > I'd honestly prefer to see this discussion drag on a little longer. The > original email was on Friday, so given that most participants on this list > aren't actively debating C++ coding style on the weekend, we've actually

Re: [Bug 1224726] High memory consumption when opening and searching a large Javascript file in debugger.

2016-04-11 Thread Kartikaya Gupta
He seems to have gotten the message: https://bugzilla.mozilla.org/show_bug.cgi?id=1255526#c21 On Mon, Apr 11, 2016 at 6:47 PM, Mark Côté wrote: > Tagging the comments as spam will autoban the account after a certain > number. It will also autocollapse the comments. > > Mark >

Re: Testing Wanted: APZ Scrollbar dragging

2016-04-01 Thread Kartikaya Gupta
On Apr 1, 2016 2:45 AM, "Sam Harrington" wrote: > I've been seeing some rather weird middle-click scrolling behavior in recent nightlies, and your test page seems to be a good way to reproduce it (see https://gfycat.com/FarflungCoarseBoutu for a video). Is this a

Re: Triage Plan for Firefox Components

2016-04-01 Thread Kartikaya Gupta
It seems to me that when this bug program was started, it had these two goals (quoted from Emma's previous email): "First, we want to make better assertions about the quality of our releases by making clear decisions about which bugs must be fixed for each release (urgent) and actively tracking

Re: FF49a1: Page load of jumping points doesn't work like it should in Wikipedia

2016-05-20 Thread Kartikaya Gupta
Note that this might get fixed in chrome with their new "scroll anchoring" feature - https://developers.google.com/web/updates/2016/04/scroll-anchoring?hl=en kats On Fri, May 20, 2016 at 12:15 PM, Adam Roach wrote: > On 5/20/16 10:13, Gijs Kruitbosch wrote: >> >> On 20/05/2016

Re: Intent to implement and ship: "passive" option for AddEventListenerOptions

2016-05-05 Thread Kartikaya Gupta
he console? > > Justin > > On Wed, May 4, 2016 at 3:19 PM, Kartikaya Gupta <kgu...@mozilla.com> wrote: >> >> Summary: Authors can declare in their addEventListener call that the >> listener will not be calling preventDefault() on the event. This >> unlocks certain pe

Re: Intent to implement and ship: "passive" option for AddEventListenerOptions

2016-05-06 Thread Kartikaya Gupta
Correct, the preventDefault() is ignored from a passive listener, and we will probably log a warning to the console (I have a patch up for review that does that, let's see what smaug says). On Fri, May 6, 2016 at 1:01 AM, Anne van Kesteren wrote: > On Fri, May 6, 2016 at 4:43

Intent to implement and ship: "passive" option for AddEventListenerOptions

2016-05-05 Thread Kartikaya Gupta
Summary: Authors can declare in their addEventListener call that the listener will not be calling preventDefault() on the event. This unlocks certain performance optimizations. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1266066 Link to standard:

Re: Telemetry experiments need to be easier (on Nightly)

2016-05-10 Thread Kartikaya Gupta
; and evidently for Kats as well). > > I hope these suggestions are helpful. > > Cheers, > > Jared > > > [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1174937 > [2] https://wiki.mozilla.org/QA/Telemetry > [3] > http://hg.mozilla.org/webtools/telemetry-experiment-server/file/tip

Re: Telemetry experiments need to be easier (on Nightly)

2016-05-10 Thread Kartikaya Gupta
err [1] is https://wiki.mozilla.org/Telemetry/Experiments and [2] is https://wiki.mozilla.org/QA/Telemetry/Developing_a_Telemetry_Experiment :) On Tue, May 10, 2016 at 10:53 AM, Kartikaya Gupta <kgu...@mozilla.com> wrote: > Just to close the loop on this, I went ahead and updated the wik

Re: PSA: Cancel your old Try pushes

2016-04-15 Thread Kartikaya Gupta
I also often have multiple pushes going at the same time. My suggestion to solve this problem is: have a cron job that detects users who have more than N pushes with jobs still going, and send them an email saying "you have a lot of jobs going, here's the list; you might find something you should

Re: Moving XP to ESR?

2016-04-18 Thread Kartikaya Gupta
On Mon, Apr 18, 2016 at 2:02 PM, Chris Peterson wrote: > > OTOH, if an XP users doesn't mind running an unpatched OS, then they > probably won't care/know about running an unpatched Chrome browser. > >From data that Chris H-C posted in some previous thread, we know that

Telemetry experiments need to be easier (on Nightly)

2016-04-19 Thread Kartikaya Gupta
(Cross-posted to dev-platform and release-management) Hi all, Not too long ago I ran a telemetry experiment [1] to figure out how to tune some of our code to get the best in-the-wild behaviour. While I got the data I wanted, I found the process of getting the experiment going to be very

Re: PSA: Cancel your old Try pushes

2016-04-17 Thread Kartikaya Gupta
On Apr 17, 2016 1:55 PM, "Steve Fink" wrote: > > Generally speaking, Firefox's stability has not been good for me for 2-3 months. I'd like to file a bug, but I've already used up my quota of unactionable bugs, and if I dug into all of my idiosyncratic issues I'd never get any

Re: Telemetry experiments need to be easier (on Nightly)

2016-04-20 Thread Kartikaya Gupta
o go and update the page to reflect what you've said here, provided you're willing to review my changes to make sure I don't go overboard :) Cheers, kats > On Tue, Apr 19, 2016 at 4:43 PM, Kartikaya Gupta <kgu...@mozilla.com> wrote: >> (Cross-posted to dev-platform and release-managemen

Intent to enable: touch-action (on Nightly)

2016-07-05 Thread Kartikaya Gupta
In the next few days, I intend to enable support for touch-action on Nightly (#ifdef NIGHTLY_BUILD), for all platforms. The implementation is behind the layout.css.touch_action.enabled property. touch-action is spec'd as part of the Pointer Events spec [1] - the rest of the spec is currently being

New macro: NS_INLINE_DECL_PURE_VIRTUAL_REFCOUNTING

2017-01-26 Thread Kartikaya Gupta
Just a heads-up that I pushed bug 1312319 which adds a new NS_INLINE_DECL_PURE_VIRTUAL_REFCOUNTING macro to nsISupportsImpl.h. This macro just defines pure-virtual AddRef/Release functions. It's intended for use if you're creating a non-nsISupports interface where you want the implementing classes

Fwd: Merging Quantum Render into mozilla-central

2017-01-30 Thread Kartikaya Gupta
(Explicitly forwarding to dev-tech-gfx and dev-platform, since apparently bcc'ing lists gets messages stuck in moderation. Please reply on dev-tree-management. Sorry for my mail-fail!) -- Forwarded message -- From: Kartikaya Gupta <kgu...@mozilla.com> Date: Mon, Jan 30, 201

Quantum Render builds now on m-c

2017-02-10 Thread Kartikaya Gupta
(cross-posted to dev-platform and dev-tech-gfx) This is just a heads up that earlier today we merged the graphics branch to m-c, so Quantum Render builds can now be done on central if you put --enable-webrender in your mozconfig. We will be running a limited set of builds (linux64 only) and

Re: Should cheddar-generated headers be checked in?

2017-02-27 Thread Kartikaya Gupta
On Mon, Feb 27, 2017 at 1:57 PM, Henri Sivonen wrote: > Now that the build.rs in commented out in the crates.io crate and the > generated header is shipped in the crates.io crate: > Considering that editing the vendored crates is not allowed, so I > can't put moz.build files

Intent to ship: TouchEvents (Windows), touch-action (all platforms), accessible caret

2016-10-04 Thread Kartikaya Gupta
In Firefox 52 I intend to ship support for TouchEvents on Windows e10s. TouchEvent support has already been enabled on Android for a long time and has been enabled on Linux e10s as well (if you have MOZ_USE_XINPUT2=1 in your environment). The pref that controls this feature is

Re: Adding Rust code to Gecko, now documented

2016-11-09 Thread Kartikaya Gupta
I'm actually trying to debug a rust issue right now and have some questions. I've done the |mach vendor rust| step and got all the vendored crates. Now let's say that in one of the dependencies (the 'cmake' crate in my case) there's some sort of behaviour that I'd like to investigate/debug. If I

Re: Adding Rust code to Gecko, now documented

2016-11-09 Thread Kartikaya Gupta
On Wed, Nov 9, 2016 at 11:51 AM, Ralph Giles <gi...@mozilla.com> wrote: > On Wed, Nov 9, 2016 at 8:41 AM, Kartikaya Gupta <kgu...@mozilla.com> wrote: > >> If I edit the third_party/rust/cmake/src/lib.rs >> in-place, the build fails because of a hash mismatch. >

Re: [ANN] Changing the default bug view for BMO

2017-01-06 Thread Kartikaya Gupta
Right now if I turn on the experimental UI, the bugzilla setting for skin changes from my preference of "Dusk" to "Mozilla", and doesn't let me change it back. Will the Dusk skin still be supported going forward? On Fri, Jan 6, 2017 at 12:09 PM, Dave Lawrence wrote: >

Re: Async scrollbar dragging enabled on Nightly

2016-12-21 Thread Kartikaya Gupta
On Wed, Dec 21, 2016 at 6:19 AM, Gervase Markham wrote: > Why do we paint a checkerboard We don't actually paint a checkerboard pattern. > rather than the default single background > colour of the page? This is what we do. It's still *called* checkerboarding though. The

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-23 Thread Kartikaya Gupta
On Thu, Mar 9, 2017 at 10:31 AM, Kartikaya Gupta <kgu...@mozilla.com> wrote: > On Wed, Mar 8, 2017 at 6:02 PM, L. David Baron <dba...@dbaron.org> wrote: >> As of 5 days ago, "Treeherder Bug Filer" was not using BUG_COMPONENT >> information. I say this base

Re: Intent to build (but not enable) WebRender by default on some Nightly platforms

2017-03-23 Thread Kartikaya Gupta
it, but please file a bug as well and mark it blocking bug 1342450. Thanks! On Mon, Mar 13, 2017 at 6:08 PM, Kartikaya Gupta <kgu...@mozilla.com> wrote: > (Cross-posted to dev-platform and dev-tech-gfx, please reply to dev-platform) > > In the near future I'm planning to m

PSA: git mirrors are not updating

2017-03-28 Thread Kartikaya Gupta
Just a heads-up that the git mirrors of m-c (e.g. github.com/mozilla/gecko-dev and github.com/mozilla/gecko-projects) are not updating, and are stuck on a changeset from sometime on March 24. Bug 1350696 is open for the investigation. Cheers, kats ___

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-09 Thread Kartikaya Gupta
On Wed, Mar 8, 2017 at 6:02 PM, L. David Baron wrote: > As of 5 days ago, "Treeherder Bug Filer" was not using BUG_COMPONENT > information. I say this based on: > https://bugzilla.mozilla.org/show_bug.cgi?id=1344304 > being filed in Core :: Layout despite: > > $ ./mach

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-08 Thread Kartikaya Gupta
I've been reading this thread with much sadness, but refraining from commenting because I have nothing good to say. But I feel like I should probably comment regardless. What makes me sad is all the developers in this thread trying to push back against disabling of clearly problematic tests,

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-08 Thread Kartikaya Gupta
On Wed, Mar 8, 2017 at 4:01 PM, wrote: > In the past I have not always been made aware when my tests were disabled, > which has lead to me feeling jaded. We have a process (in theory) that ensures the relevant people get notified of tests. The process involves

Intent to build (but not enable) WebRender by default on some Nightly platforms

2017-03-13 Thread Kartikaya Gupta
(Cross-posted to dev-platform and dev-tech-gfx, please reply to dev-platform) In the near future I'm planning to make a change so that WebRender will be built (but not enabled) by default in most Nightly/local builds [1]. This will allow anybody running a stock nightly to turn on The

Re: All the processes

2017-03-06 Thread Kartikaya Gupta
On Mon, Mar 6, 2017 at 7:08 PM, Eric Rahm wrote: > I assume WebRenderer will have it's own process, but maybe that just gets > lumped in with the GPU process. WebRender will live in the GPU process, if there is one. The UI process otherwise. Cheers, kats

Heads-up: WebRender now requires HWA enabled

2017-08-09 Thread Kartikaya Gupta
TLDR: Once bug 1387764 merges to mozilla-central, anybody running with WebRender enabled on Linux will need to force-enable hardware acceleration (layers.acceleration.force-enabled=true) to keep WebRender enabled. Long version: Previously the check for enabling WebRender ignored the status of

Re: Bulk Closing Intermittents

2017-07-10 Thread Kartikaya Gupta
It might be a good idea to integrate this process with the OrangeFactor Robot, to avoid race conditions like what happened on bug 1328486 (it was bulk-closed, and then a couple of hours later the OF robot reported that there were two failures this week - but the bug remained closed). Cheers, kats

Re: git mirror

2017-07-22 Thread Kartikaya Gupta
https://github.com/mozilla/gecko-dev is generally pretty up-to-date. It should have a branch for ESR as well. Cheers, kats On Jul 22, 2017 15:43, "Enrico Weigelt, metux IT consult" < enrico.weig...@gr13.net> wrote: Hi folks, are there any official git mirrors (at least for the esr branches),

Re: Correct format specifier for size_t

2017-07-25 Thread Kartikaya Gupta
I filed bug 1384233 for removing the header and unnecessary defines. On Tue, Jul 25, 2017 at 2:13 PM, Honza Bambas wrote: > Thanks! OTOH, I think we no longer need it. Since VS2015 (our minimal > toolchain version on Win) supports %z modifier. Only VS2013 and down only >

Re: Editing vendored crates take #2

2017-04-28 Thread Kartikaya Gupta
At one point the steps at https://wiki.mozilla.org/Platform/GFX/Quantum_Render#Testing_third-party_rust_library_changes were known to work. I don't know if they have since been broken. On Fri, Apr 28, 2017 at 3:07 PM, Boris Zbarsky wrote: > On 4/28/17 1:05 PM, Josh Matthews

Re: PSA: pushing to try is broken right now

2017-08-04 Thread Kartikaya Gupta
gps did some magic and things seem to be working again. Pushes that occurred previously are now showing up on try, so I've reopened the tree. On Fri, Aug 4, 2017 at 11:02 AM, Kartikaya Gupta <kgu...@mozilla.com> wrote: > Pushes to try appear to succeed, but the pushlog is somehow busted

  1   2   >