Re: Dropping support for compiling with MSVC in the near future

2019-02-14 Thread Mike Hommey
Hi, Bug 1512504 has now landed on autoland, meaning that compiling Firefox with MSVC is now not supported anymore. MSVC is however still necessary as a build requirement for its headers and libraries (as well as its assembler on aarch64 and the preprocessor for midl ; and maybe a few other things)

Re: Dropping support for compiling with MSVC in the near future

2018-12-11 Thread Kartikaya Gupta
This makes sense, thanks! On Tue, Dec 11, 2018 at 6:45 AM Ted Mielczarek wrote: > > On Mon, Dec 10, 2018, at 8:29 PM, Kartikaya Gupta wrote: > > This is sort of tangential, but what's the linking story currently? > > Are we still linking with MSVC, or with lld? > > > We're using lld-link for Windo

Re: Dropping support for compiling with MSVC in the near future

2018-12-11 Thread Ted Mielczarek
On Mon, Dec 10, 2018, at 8:29 PM, Kartikaya Gupta wrote: > This is sort of tangential, but what's the linking story currently? > Are we still linking with MSVC, or with lld? We're using lld-link for Windows builds in CI: https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8

Re: Dropping support for compiling with MSVC in the near future

2018-12-10 Thread Kartikaya Gupta
This is sort of tangential, but what's the linking story currently? Are we still linking with MSVC, or with lld? I discovered recently that the rust toolchain we use in automation on windows tries to use link.exe for linking. I'm in the process of trying to get standalone webrender tests running on

Re: Dropping support for compiling with MSVC in the near future

2018-12-10 Thread Kris Maglione
On Fri, Dec 07, 2018 at 10:57:41AM -0500, Gabriele Svelto wrote: On 06/12/18 15:39, Kris Maglione wrote: As it stands, we need to remain compatible with at least GCC and Clang, because some of our static analysis code still depends on GCC plugins. Some Linux distros will keep building Firefox

Re: Dropping support for compiling with MSVC in the near future

2018-12-10 Thread Jim Mathies
On Thursday, December 6, 2018 at 5:08:53 PM UTC-6, Gijs Kruitbosch wrote: > Can someone elaborate on what this means for debugging on Windows, and > for our onboarding story on Windows? I just checked to be sure this was all working, and it is. I have VS 2017 and the 'Install Microsoft Child Pro

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Ted Mielczarek
On Thu, Dec 6, 2018, at 3:34 PM, Jonathan Kew wrote: > While I sympathize with the concern that "supporting more than one > compiler is a maintenance burden", this still leaves me feeling a little > uneasy. Ensuring that our code builds successfully with multiple > compilers is a useful way to k

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Ted Mielczarek
On Thu, Dec 6, 2018, at 6:08 PM, Gijs Kruitbosch wrote: > Can someone elaborate on what this means for debugging on Windows, and > for our onboarding story on Windows? For debugging: as others have pointed out, nothing should change. For onboarding we will continue to require users to install Vi

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Ted Mielczarek
On Fri, Dec 7, 2018, at 8:37 AM, Simon Sapin wrote: > On 07/12/2018 00:08, Gijs Kruitbosch wrote: > > We're already making people install MSVS to get the relevant Windows > > SDKs (manually, not supported via ./mach bootstrap, and hopefully > > ticking the right boxes in the installer or they have

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Gabriele Svelto
On 06/12/18 15:39, Kris Maglione wrote: > As it stands, we need to remain compatible with at least GCC and Clang, > because some of our static analysis code still depends on GCC plugins. Some Linux distros will keep building Firefox with GCC so there's going to be at least some external users of t

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Simon Sapin
On 07/12/2018 00:08, Gijs Kruitbosch wrote: We're already making people install MSVS to get the relevant Windows SDKs (manually, not supported via ./mach bootstrap, and hopefully ticking the right boxes in the installer or they have to do it again until they do win at checkbox-golfing) We should

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Honza Bambas
On 2018-12-07 04:23, Nathan Froyd wrote: On Thu, Dec 6, 2018 at 6:10 PM Gijs Kruitbosch wrote: Can someone elaborate on what this means for debugging on Windows, and for our onboarding story on Windows? At least in terms of stepping through, examining variables, etc., clang-cl is on par with M

Re: Dropping support for compiling with MSVC in the near future

2018-12-06 Thread Nathan Froyd
On Thu, Dec 6, 2018 at 6:10 PM Gijs Kruitbosch wrote: > Can someone elaborate on what this means for debugging on Windows, and > for our onboarding story on Windows? At least in terms of stepping through, examining variables, etc., clang-cl is on par with MSVC. If there are specific, stop-the-pr

Re: Dropping support for compiling with MSVC in the near future

2018-12-06 Thread Gijs Kruitbosch
Can someone elaborate on what this means for debugging on Windows, and for our onboarding story on Windows? I don't do this very often, but I ran into this today and the story is already very poor. I'm currently trying to work out why a patch I have crashes on startup. I tried using google, an

Re: Dropping support for compiling with MSVC in the near future

2018-12-06 Thread Kris Maglione
On Thu, Dec 06, 2018 at 03:34:59PM -0500, Jonathan Kew wrote: While I sympathize with the concern that "supporting more than one compiler is a maintenance burden", this still leaves me feeling a little uneasy. Ensuring that our code builds successfully with multiple compilers is a useful way to

Re: Dropping support for compiling with MSVC in the near future

2018-12-06 Thread Jonathan Kew
On 06/12/2018 15:00, Ted Mielczarek wrote: Hello, In light of the fact that we've switched to clang-cl for our Windows builds[1], we are planning to drop support for compiling Firefox with MSVC in the near future[2]. Our estimate is that this will happen sometime in Q1. Supporting more than o

Re: Dropping support for compiling with MSVC in the near future

2018-12-06 Thread Kris Maglione
\o/ On Thu, Dec 06, 2018 at 03:00:12PM -0500, Ted Mielczarek wrote: Hello, In light of the fact that we've switched to clang-cl for our Windows builds[1], we are planning to drop support for compiling Firefox with MSVC in the near future[2]. Our estimate is that this will happen sometime in Q